[00:08:51] Excuse me where I can request admin rights at test.wikidata.org [00:09:15] ? [00:09:20] Reedy: ^ [00:39:36] Hey everyone. I'm doing an interview of Wikidata editors for a piece I'm doing to commemorate the one year anniversary of the project being publicly editable. If you'd like to participate, it's in ##Sven_Manguard [00:41:07] It's a group interview, so everyone can answer the questions themselves, or play off of responses that other people made. At the end, I'll condense it together (and publish the full answers separately) like they do on the Signpost [00:41:17] It's happening right now [01:10:48] hey Hazard-SJ - you interested in being part of an interview of Wikidata editors for a piece I'm doing to commemorate the one year anniversary of the project being publicly editable? [01:11:11] It's a group interview, so everyone can answer the questions themselves, or play off of responses that other people made. At the end, I'll condense it together (and publish the full answers separately) like they do on the Signpost and It's happening right now [06:00:37] Sometimes, when several languages' Wikipedias have the same geographic coordinates for a location, I use the smaller, less well known language as the "imported from" source, just to spice things up. Is that bad? [06:09:23] Sven_Manguard: Ideally you would cite all of the wikipedias with the same coord [06:10:08] legoktm: except that that's a massive time sink. Ideally the bots that were handling coordinate imports would have not all apparently stopped midway through their assigned duties [06:10:24] heheheh [06:10:32] unless they're running, but really, really slowly [06:11:06] the geocoord for Greenville, North Carolina is sourced to Russian Wikipedia [06:11:36] legoktm: https://www.wikidata.org/w/index.php?search=Greenville&button=&title=Special%3ASearch <-- common name, eh? [06:12:04] lololol [06:12:54] as is the geocoord for Greenville, Kentucky [06:14:08] Greenville, Rhode Island's geocoord is cited to persian Wikipedia [06:14:15] and none of those are me [06:14:26] persian is Amir [06:14:53] ? [06:15:00] oh, the bot op [06:16:13] aude was doing coordinate locations up until 10:22, 2 September 2013, but seems to have... stopped [06:16:59] probably went to sleep? [06:17:03] amir == ladsgroup [06:18:51] legoktm: aude's bot [06:19:09] some bot ops don't run their bot if they aren't supervising [06:19:13] it looks like it was working a list, got to the end, and shut off. Woefully incomplete list. [06:19:21] Weird. "The Miami (Miami-Illinois: Myaaniaki) are a Native American nation originally found in what is now Indiana, southwest Michigan, and western Ohio." [06:19:30] so... I get Miami, Ohio... [06:19:35] why Miami, Florida? [07:45:12] I got bored [07:45:18] And [07:45:31] setup working interwiki transclusion with wikidata! [07:46:48] ? [07:47:29] transcluding a template from another wiki [07:47:30] like [07:47:37] yeah. [07:47:55] small testcase [07:48:20] if you have "Hi" on your central source, the template locally should also say "Hi" [07:48:31] of course, that's pretty easy [07:48:40] the tough part is setting up arguments and stuff like that [07:49:21] so if you look at https://www.wikidata.org/wiki/Wikidata:BOX [07:49:29] right now it just has "{{Wikipedia:Sandbox}}" [07:49:30] 10[10] 04https://www.wikidata.org/wiki/Template:Wikipedia:Sandbox [07:49:53] but whatever you put there, will automatically be transcluded at the bottom of https://en.wikipedia.org/wiki/Wikipedia:Wikidata/Wikidata_Sandbox (all wikitext in context of local site) [07:50:00] it shouldnt be hard to set stuff like {{{1}}} working [07:50:33] huh [07:51:00] interesting [07:51:20] it's a verrry old bug https://bugzilla.wikimedia.org/4547 [07:55:53] hey lego, im back ;p [07:55:57] o/ [07:56:10] time to break stuff! [07:56:37] \o/ [08:18:53] addshore https://gerrit.wikimedia.org/r/#/c/81904/ [08:25:52] Abraham_WMDE: https://gerrit.wikimedia.org/r/#/c/81924/ that one should fix the changehandler tests again [08:26:44] Tobi_WMDE: thx! [08:36:26] Only 36 hours until I have imported the wikidata DB :D [08:41:33] Granjow: your importing from where to where? :P [08:42:25] I just thought, you could have simply copied the replica dbs on labs ;p [08:57:14] http://ultimategerardm.blogspot.nl/2013/09/information-lost-in-viaf.html [08:57:16] addshore: I downloaded the DB dump from the ... dumps :D (the 1.7 GB file without history) and started to put it on tools-db. But I stopped the process since it is maybe better to run it with jsub anyway. And I either need to find out how to get either pretty URLs for my wiki or I have to fix my code so that it also works for index.php?title= URLs. [08:58:20] It seems that the properties are imported after the items, and I would really like to have the instance-of property in the DB as I make heavy use of it too. [08:58:35] JeroenDeDauw: Are you here? [08:58:42] no ;p [08:58:49] ;-( [08:59:15] sudo wget JeroenDeDauw --now [08:59:33] :) magic happens often [09:12:26] hi [09:12:56] what are the requirements for a property proposal to be implemented? [09:26:39] (03PS14) 10Tobias Gritschacher: (bug 53678) make change handler compatible with site link badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [09:43:23] Schisma__: in the end, for an admin to do it :) they would know [09:44:09] Denny_WMDE: I am waiting for a while already but it seems i wont receive more comments :/ [09:44:11] what can i do? [09:44:27] Denny_WMDE: ' for an admin to do it' Hm? [09:44:49] kick an admin in the… i mean, ask an admin nicely to get it unstuck [09:45:31] If we are talking about a Wikidata admin, Yes? [09:45:57] JohnLewis maybe you can help Schisma__ [09:46:29] Denny_WMDE: I have hinted at it twice xD I don't know what the request is though; Schisma__. [09:48:22] Schisma__; What is you request and I'll be more than happy to help. [09:49:10] JohnLewis: there are actually three requests who are interconnected. the fist one might not be necessary (see comments) [09:49:24] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#story_set_in_time_.2F_Handlung_spielt_zur_Zeit_.2F_.D0.98.D1.81.D1.82.D0.BE.D1.80.D0.B8.D1.8F_.D0.BF.D1.80.D0.BE.D0.B8.D1.81.D1.85.D0.BE.D0.B4.D0.B8.D1.82_.D0.B2.D0.BE_.D0.B2.D1.80.D0.B5.D0.BC.D1.8F_.2F_.3F_.2F_.3F [09:49:33] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#story_set_in_location_.2F_Handlung_spielt_an_Ort_.2F_.D0.98.D1.81.D1.82.D0.BE.D1.80.D0.B8.D1.8F_.D0.BF.D1.80.D0.BE.D0.B8.D1.81.D1.85.D0.BE.D0.B4.D0.B8.D1.82_.D0.B2_.D0.BC.D0.B5.D1.81.D1.82.D0.B5_.2F_.3F_.2F_.3F [09:49:40] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#Filming_Location_.2F_Drehort_.2F_.D0.BC.D0.B5.D1.81.D1.82.D0.BE_.D1.81.D1.8A.D0.B5.D0.BC.D0.BE.D0.BA [09:51:49] would be happy to receive some comments [09:52:20] Well; I am declined the first one. [09:52:27] *I declined [09:53:18] Second seems fine, consensus is there. Creating. [09:53:29] thanks :) [09:54:01] i thought there is something like a minimal amount of votes [09:54:20] Not really. [09:54:50] If it has been 1 week and there is one support, it can be created. If there has been 1 week and 30 supports, we treat it the same as the one. [09:56:32] Schisma__: Anything else? [09:56:42] https://www.wikidata.org/wiki/Property:P840 btw [09:57:52] JohnLewis: thx [09:58:00] no, thank you very much :) [09:58:07] Denny_WMDE: Always willing to help :p [09:58:11] Schisma__: Alright. [10:03:04] https://www.wikidata.org/wiki/Q208460 [10:06:31] (03PS1) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [10:06:43] (03CR) 10jenkins-bot: [V: 04-1] Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [10:07:39] funny case: https://www.wikidata.org/wiki/Q145269 [10:09:01] is it possible to force safe my edits when the user interface just sucks? ^^ [10:15:07] (03PS2) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [10:16:52] (03PS3) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [10:17:47] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/82594/ [10:18:33] (03PS23) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [10:20:57] wooo [10:20:58] ! [10:21:50] ! [10:21:58] | [10:22:06] l [10:22:12] I [10:22:22] i [10:22:28] (03CR) 10Daniel Kinzler: [C: 04-1] "please add a positive test case for building a SimpleSiteLink from a data array without badges" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [10:23:00] addshore: I forgot to ask you; how could I copy the DB directly? Would this be faster? [10:23:12] hmm, im not entirly sure [10:23:22] well, i know how to do it, but not sure if it would be faster ;p [10:23:29] also not sure if it would work on the replicase [10:23:52] http://stackoverflow.com/questions/5551301/clone-mysql-database [10:24:21] although its probably quicker to use the wikibase dump file itself rather than creating your own ;p [10:36:28] (03PD1) 10Addshore: Reuse duplicate code in LinkTitles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82596 [10:41:35] Tobi_WMDE: did you see my comment? [10:49:08] (03PD2) 10Addshore: Stop using deprecated contentfactory singleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82597 [10:49:24] JeroenDeDauw: ping -a :) [10:49:58] no JeroenDeDauw yet ;p [10:50:42] mlocate JeroenDeDauw [10:50:42] :P [10:51:12] is mlocate something like finger or poke? [10:51:33] Denny_WMDE: don't know them, it is like locate for searching files but uses a DB, so it is very fast. [10:52:47] Actually locate seems to do that too ... not sure where mlocate is better now :) [10:53:15] JohnLewis: is the date of birth and deat not a qualifier of a person ? [10:53:36] Anyway; I have a question you can maybe answer. In my JavaScript code I need to get some data from api.php. How can I get the path/to/api.php? [10:54:04] GerardM: it should be a property not a qualifier, usually [10:54:17] What Denny_WMDE said :p [10:54:39] Granjow: is this JS called from an external site or from a script on Wikidata? [10:54:46] why ? [10:55:07] qualifiers qualify a statement, not an item [10:55:20] so you would need an existing statement to qualify [10:56:26] by making it a qualifier, you indicate that he is more likely a natural person and you qualify actions attributed to the person [10:56:57] what is "it" in your sentence? [10:57:10] dob dod [10:57:24] you can use dob as a qualifier [10:57:31] but the question is on which statement? [10:57:37] on the person [10:57:45] a person is an item, not a statement [10:57:57] you can use a dob statement on an item [10:58:19] i think this issue might be merely terminological though [10:58:43] the item is "Gerard Meijssen" the statement is "is a person" [10:59:23] or any other person naturally [11:00:20] yes, then you can make a qualifier on that statement [11:00:28] technically [11:00:51] I still would say that it seems more widespread to make a dob statement directly on Gerard [11:01:17] this had the advantage that you can add a reference solely for that, etc [11:01:17] Denny_WMDE: From a mediawiki extension, i.e. same site. [11:01:29] ok ... [11:02:36] Granjow: in that case there should be functions to call the API [11:02:44] something like mw.api or whatever [11:02:51] check out other scripts [11:04:29] Denny_WMDE: Ah, right, completely forgot this. Thanks! [11:10:49] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [11:13:26] (03PS1) 10Addshore: Add sort example to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82599 [11:14:20] Denny_WMDE: DanielK_WMDE, fancy an easy review before branching? :P ^^ [11:15:46] (03CR) 10Daniel Kinzler: [C: 032] Add sort example to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82599 (owner: 10Addshore) [11:17:13] (03Merged) 10jenkins-bot: Add sort example to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82599 (owner: 10Addshore) [11:23:59] is there a way to bulk copy and paste claims? [11:24:11] Schisma__: not through the UI [11:24:19] but? [11:24:27] probably through the API [11:24:42] but not practical? ^^ [11:24:53] i think it should be practical [11:24:59] heh [11:25:03] theres a bug for that ;p [11:25:13] addshore: UI or API? [11:25:20] api, give me 2 secs :) [11:25:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=53619 [11:28:01] infact there is already a super secret patchset in gerrit for it :) thats just needs tests [11:30:06] okay, so I'll wat [11:30:08] wait ^^ [11:33:11] what is the difference between 'no value' and 'unknown'? [11:33:17] (03CR) 10Michał Łazowik: "Is this really needed? In the new structure badges are always there, and the old one is not an array at all." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [11:33:42] which to choose if something is like 'not knowable' [11:34:53] Schisma__: no value means that it is known that there is no value. e.g. we know that Prince Harry has no children [11:35:18] ic [11:35:28] Schisma__: unknown is to be used for "there is one, but we do not know what" [11:35:56] e.g. the dob of zarathustra is unknown [11:35:59] so i should pick this also for things that can never be known? [11:36:15] dunno. what is the actual example? [11:37:03] https://www.wikidata.org/wiki/Q1768716 [11:37:15] its known where the narrative is set [11:37:24] but the time isn't mentioned in the story [11:37:36] yeah, sounds right [11:37:51] but it has to be known that it is unknown :) [11:38:01] also here: https://www.wikidata.org/wiki/Q145269 [11:38:02] what i mean, you can imagine a reference saying that [11:38:09] the time is known but not the place [11:38:29] could be anywhere [11:38:31] it does not mean "i do not know", it means "according to general knowledge, as you can see in this reference, it is unknown" [11:39:03] thats what i wanted to know [11:39:06] thanks ^^ [11:39:59] you know its not easy: "There are known knowns; there are things we know that we know. [11:39:59] There are known unknowns; that is to say, there are things that we now know we don't know. [11:39:59] But there are also unknown unknowns – there are things we do not know we don't know." [11:40:20] https://en.wikipedia.org/wiki/There_are_known_knowns [11:41:02] :D [11:48:02] Hi all [11:48:21] (03CR) 10Daniel Kinzler: "@michal: apparently, the API sometimes constructs an array structure and turns it into a SimpleSiteLink using newFromArray. Since the API " [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [11:48:35] J am talib [11:49:06] i love sex with goat [12:02:22] -.- [12:08:16] (03PS4) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [12:09:14] DanielK_WMDE: added test https://gerrit.wikimedia.org/r/#/c/82594/ [12:54:43] it would be great if someone could improve geneawiki or geneawiki2 ;) [13:04:20] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/81966/ [13:07:29] I need help, I can't see my own contributions! [13:07:42] and this is getting really bothering [13:09:27] Sannita: link? [13:09:40] Lydia_WMDE: Special:Contributions/Sannita [13:10:00] Sannita: works for me [13:10:02] hmmmm [13:10:10] can you make a screenshot? [13:10:18] https://www.wikidata.org/wiki/Wikidata:Paper_cuts#I_cannot_see_my_contributions [13:10:24] i need to run but will have a look later if no-one else does [13:10:29] 504 Gateway Time-out [13:10:49] meanwhile I'll try Lavallen's trick [13:11:10] ok [13:11:15] * Lydia_WMDE leaves [13:12:06] see ya [13:15:50] would anyone agree that a description should be as short as possible and as long as necessary? [13:20:31] Granjow: pong [13:21:19] JeroenDeDauw: Wow, good timing, returned this second from painting :) [13:22:46] JeroenDeDauw: Not sure if you read my last messages. I'm still working on the Mediawiki extension for the identification key where I need e.g. all items that have “instance-of“ set to the item “Tree”. [13:23:58] The way I'm currently doing it is that I scan the whole DB the first time, then remember all elements that match, and cache it with APC. When there is a cached object, I update the cache by refreshing all items that have changed since (by parsing the changelog). [13:24:05] (03PS6) 10Jeroen De Dauw: Add code to read in table definitions from the db [DNM, DRAFT] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/81254 [13:25:40] This works fine for my database, containing around 300 items. But Wikidata has 13 million, and I am pretty sure my code will fail there. [13:26:01] Granjow: sound like you'd want to use the QueryEngine functionality [13:26:23] I also need up-to-date data, so if a “Tree” object is changed, I need the data now and not after 5 minutes. [13:26:43] JeroenDeDauw: Can QueryEngine do that? (That's the reason why I'm asking :) ) [13:28:47] Granjow: it can find the entities that have a certain value for some property yes [13:29:34] Granjow: while most of the infrastructure is ready, it is not fully hooked up yet [13:29:43] so you cannot play with actual data if you use it [13:29:49] though the interface is already clear [13:29:59] you can thus already build on top of it if you want [13:30:40] JeroenDeDauw: Ok. But caching is planned (for the Wikidata amount of data)? When do you expect it to be ready for use? [13:31:15] Granjow: this is more about querying and change notification than caching [13:31:15] (I have to finish my thesis in 6 weeks) [13:31:29] Granjow: this is very unlikely to be deployed in 6 weeks [13:31:39] Might happen if we push for it [13:31:45] Probably not tho [13:33:17] JeroenDeDauw: Okay. Well, deployment of my extension to Wikidata.org would take more weeks anyway, if it is going to happen. (What I hope.) [13:33:34] What do you mean by querying instead of caching? [13:33:58] Granjow: what you described involves query answering [13:34:13] To do this efficiently you need indexing and caching [13:34:19] The main thing is not caching though [13:35:01] JeroenDeDauw: You mean like indexing the instance-of property? [13:38:33] (03PS1) 10Addshore: Add indexes to TableCreationAndDeletionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82605 [13:50:24] (03PS1) 10Addshore: Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 [13:51:11] (03PS5) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [13:52:36] (03PS6) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [13:54:22] (03PS7) 10Tobias Gritschacher: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 [13:54:56] DanielK_WMDE: another turn: https://gerrit.wikimedia.org/r/#/c/82594/ [14:10:08] (03PS1) 10Addshore: Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 [14:10:18] (03PS15) 10Daniel Kinzler: (bug 53678) make change handler compatible with site link badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [14:10:24] Tobi_WMDE: ---^ [14:11:56] (03CR) 10Daniel Kinzler: [C: 032] Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [14:12:10] (03Merged) 10jenkins-bot: Badges should be optional when creating SiteLink with newFromArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82594 (owner: 10Tobias Gritschacher) [14:12:49] JeroenDeDauw: any comments on https://gerrit.wikimedia.org/r/#/c/82405/1 would be great [14:18:28] (03CR) 10Daniel Werner: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81923 (owner: 10Tobias Gritschacher) [14:19:13] (03PS4) 10Daniel Werner: SpecialWikibaseQueryPage::formatRow is no longer abstract [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79345 [14:30:56] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [14:31:14] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/81924/ [14:38:08] hello [14:38:08] DanielK_WMDE: I'm confused [14:39:39] I've created newFromArray for SimpleSiteLink [14:39:39] so I can't be using that [14:39:39] and if it uses Item::newFromArray [14:39:39] then it passes the legacy format [14:39:39] were there any actual failures? [14:40:01] (03PS2) 10Tobias Gritschacher: Add additional css classes to toolbarbuttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81923 [14:41:12] (03PS3) 10Tobias Gritschacher: Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 [14:42:24] (03CR) 10Daniel Werner: [C: 032] Add additional css classes to toolbarbuttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81923 (owner: 10Tobias Gritschacher) [14:43:01] lazowik: yes, there were actual failures. i was wrong, it wasn't the api, though [14:43:22] DanielK_WMDE: the only thing I think is possible is patching [14:43:24] lazowik: it was the patching code. you can trigger the error ba adding two sitelinks to an item without reloading the page [14:43:35] yep [14:43:54] I had that initially but JeroenDeDauw told me to change that [14:44:05] then he should fix the dioff code :) [14:44:20] and at that time I couldn't remember why I needed that [14:44:28] btw, the differ should really handle this as a MapDiff, not a generic list diff. [14:44:31] but no big deal for now [14:45:17] DanielK_WMDE: there is another problem [14:45:57] tests for api create enities by feeding wbeditentity with serialized data [14:46:10] (03PS16) 10Daniel Kinzler: (bug 53678) make change handler compatible with site link badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [14:46:15] which is in EntityTestHelper [14:46:27] *are [14:47:27] and there is a patch for testing getting of entities, including badges [14:47:59] and I could expand it to also check if the badges returned by api are actually ItemIds [14:48:28] but for that test to work I need to expand wbeditentity [14:48:44] :O [14:48:54] (03PS4) 10Tobias Gritschacher: Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 [14:49:04] and tests for expanding wbeditentity would also depend on refactoring done by addshore [14:49:22] I'm not sure in which order should I do all of this [14:49:39] if needed I'm sure we could knock up other tests which dont depend on the refactoring of the getentities tests [14:49:45] (03PS5) 10Tobias Gritschacher: Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 [14:49:56] why does wbeditentity need to be expanded? [14:50:31] bacause that's how entities for api test are created [14:50:48] and tests for expanding wbeditentity would also depend on refactoring done by addshore <- wrong, sorry [14:51:14] Tobi_WMDE: re XXX: i have now re-installed the pre-commit script that keeps me from forgetting that :P [14:51:31] Im not sure i quite follow the problem, (which set of tests are we even looking at? :P [14:51:42] the test for getting badges, that depends on addshore refactoring would depend on wbeditentity expanding [14:51:56] addshore: I mean data from EntityTestHelper [14:52:24] so the issue is that the data in the test helper doesnt have the sitelinks in it...? [14:52:53] nope, it's that if I add badges it won't add them to entities [14:53:07] ahh, because editentity doesnt support it! [14:53:10] yep [14:53:11] I see [14:53:36] (03CR) 10Tobias Gritschacher: [C: 032] (bug 53678) make change handler compatible with site link badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [14:53:49] \o/ [14:53:52] (^) [14:54:03] addshore: also now after looking at the code I'm not so sure about separate module for badges [14:54:21] that would mean a separate edit for changing badges [14:54:39] I think that this should be connected with UI [14:54:59] if UI allows editing badges and sitelink at once, then expand setsitelinks [14:55:10] indeed [14:55:23] if editing is another [edit] for each sitelink, then separate module [14:55:46] so the issue with editentity is it doesnt handle the badges :P [14:55:47] (i.e. there is a dedicated [edit] for badges) [14:55:53] (03Merged) 10jenkins-bot: (bug 53678) make change handler compatible with site link badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude) [14:55:56] addshore: yes [14:56:19] I've started adding the support yesterday [14:56:33] got any sort of draft up yet? :) [14:56:38] nope [14:56:47] but I don't know whether to wait with badges getting test until it's merged [14:57:05] or expand the getting test after editentity expanding [14:57:27] wait with badges getting test until it's merged? [14:57:44] I would just try and add badges to editentity now :) [14:57:53] heh, it = editentity [14:57:59] ok [14:58:47] the main things I think you will need fiddle with is getSitelinksChangeOps() in EditEntity and therefore the ChangeOpSiteLink class [14:58:53] and of course tests ;p [14:59:04] addshore: yup, changed that [14:59:20] but looks like mine merged code for getting is bad [14:59:24] but no need to worry [14:59:35] now it can't break as it has no badges to work with [14:59:59] also need to be sure that badges are not touched when the key 'badges' is not set [15:01:12] addshore: and what with separate module vs. expanding setsitelinks ? [15:01:48] (03PS1) 10Jeroen De Dauw: Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82617 [15:02:21] I'd love some input about UI [15:03:34] lazowik: your merged code for getting is bad? link? :O [15:04:03] (03PS2) 10Jeroen De Dauw: Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82617 [15:04:07] sadly I t [15:04:14] (03PS3) 10Jeroen De Dauw: Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82617 [15:04:19] havne't thought about testing that manually [15:04:26] (with manually fed badges) [15:04:36] which bit of code? :O [15:04:44] adding badges to api result [15:04:53] it won't break anything, there are no badges [15:05:14] or it's editing that's wrong... [15:05:17] need to make sure [15:05:30] (editing I'm doing right now, no patch yet) [15:06:03] addshore: https://gerrit.wikimedia.org/r/#/c/81934/ line 109 might not be correct [15:06:26] heh, i couldnt find it [15:07:17] line 109 so hasImpliedSiteLinksProp ? [15:07:45] huh, nope [15:07:52] I have a feeling I am still greatly confused [15:07:53] fke [15:07:58] *file lib/includes/serializers/SiteLinkSerializer.php [15:08:00] (03CR) 10Daniel Werner: [C: 032] Remove DataTypes as its now in its own git repo [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81958 (owner: 10Jeroen De Dauw) [15:08:18] $response['badges'][] = $badge->getSerialization(); [15:08:18] addshore: $response['badges'][] = $badge->getSerialization(); [15:08:21] yep [15:09:03] (03CR) 10Daniel Werner: [C: 032] Remove obsolete and unhelpfull boilerplate docs [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81965 (owner: 10Jeroen De Dauw) [15:09:23] lazowik: whats type of object is a $badge there? [15:09:33] ItemId [15:09:43] okay [15:09:56] [travis-ci] wikimedia/mediawiki-extensions-DataValues#213 (master - 5cd610b : jeroendedauw): The build passed. [15:09:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/d821357703d7...5cd610b46fdb [15:09:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/10978737 [15:11:06] lazowik: remind me, whats the format of the serialization of an id? :P [15:11:21] should be Q... [15:11:24] I think so... [15:11:42] (string) [15:12:55] addshore: http://wklej.org/hash/2b19d0f469c/ [15:13:21] hmm, whats query produces that? [15:13:26] [travis-ci] wikimedia/mediawiki-extensions-DataValues#214 (master - d76561c : jeroendedauw): The build passed. [15:13:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/5cd610b46fdb...d76561cc3801 [15:13:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/10978811 [15:13:48] (just to be sure I explained myself: that's a getting after adding badges with my not yet published code) [15:14:21] lazowik: can you send me an exported item with a sitelink? :P [15:15:09] addshore: and that came up late yesterday, haven't looked at that myself even [15:15:21] just a moment, I need to reorganize myself [15:15:27] :> [15:18:20] addshore: http://wklej.org/hash/a1fb976f4d9/ [15:18:24] looks OK [15:18:35] that's print_r( $this->data ) [15:18:40] somewhere in Item [15:18:54] I mean, go to Special:Export and send me one so I can import it locally ;p [15:19:36] ah [15:21:04] has integer keys without _element value [15:21:16] so is that on a sitelink with no badges? [15:22:01]