[06:15:13] <GerardM>	 good morning
[06:24:43] <JeroenDeDauw>	 GerardM: morning? oh fuck... its light already
[06:25:05] <GerardM>	 sorry :)
[06:25:17] <GerardM>	 08:25
[06:25:38] <JeroenDeDauw>	 guess I better go find a dinner somewhere then
[06:31:38] <Sven_Manguard>	 JeroenDeDauw: happens to me all the time
[07:20:23] <lazowik>	 'morning
[07:20:41] <legoktm>	 https://www.wikidata.org/w/index.php?title=Q7857851&diff=prev&oldid=65860738 :<
[07:22:13] <lazowik>	 :|
[07:25:56] <grrrit-wm>	 (03PS5) 10Tpt: (bug 47071) Allow use of the Lua API on a Wikibase repository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 
[07:48:21] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 (owner: 10Tpt)
[07:57:11] <lazowik>	 JeroenDeDauw: meeeeergeeeeee  https://gerrit.wikimedia.org/r/#/c/82842/
[07:58:38] <lazowik>	 (DanielK told that this is not necessary like that, but did'n say what he meant)
[07:58:50] <lazowik>	 JeroenDeDauw: ^
[08:17:05] <Sven_Manguard>	 legoktm: Does Wikidata have an archive bot? Is that Bene*
[08:17:13] <legoktm>	 It's Hazard's
[08:21:58] <Sven_Manguard>	 ah, okay, thanks
[08:46:00] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 (owner: 10Michał Łazowik)
[09:03:30] <grrrit-wm>	 (03CR) 10Michał Łazowik: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 (owner: 10Michał Łazowik)
[09:05:24] <grrrit-wm>	 (03PS2) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[09:05:28] <JeroenDeDauw>	 Abraham_WMDE: first!
[09:05:52] <Abraham_WMDE>	 JeroenDeDauw: don't think so ;)
[09:06:28] <grrrit-wm>	 (03CR) 10Michał Łazowik: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 (owner: 10Michał Łazowik)
[09:09:25] <grrrit-wm>	 (03PS3) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[09:09:47] <JeroenDeDauw>	 Abraham_WMDE: :0 ?
[09:10:47] <JeroenDeDauw>	 lazowik: still has no tests lo
[09:10:49] <JeroenDeDauw>	 ;p
[09:11:51] <lazowik>	 JeroenDeDauw: <sigh>, see the commit message
[09:13:26] <lazowik>	 (by hand === with my local changes for editing entities)
[09:14:08] <lazowik>	 I have only summaries and some more tests to add and editing will be ready for review
[09:14:44] <JeroenDeDauw>	 lazowik: I do not understand why you cannot write a test? Just add some stuff to SiteLinkSerializerTest ?
[09:15:06] <JeroenDeDauw>	 Then again its 11:14AM and I'm still awake, so might be missing the obvious
[09:15:42] <lazowik>	 JeroenDeDauw: the tests create entities by wbeditentity
[09:16:00] <lazowik>	 I have no way to insert badges into Item...
[09:16:19] <lazowik>	 or...
[09:16:29] <lazowik>	 I could add by addSimpleSiteLink
[09:16:44] <lazowik>	 but that would probably be temporary
[09:17:38] <JeroenDeDauw>	 lazowik: in order to create a unit test, you do not need the api and you do not need to store items
[09:17:48] <JeroenDeDauw>	 If you did, you'd have a system test, not a unit test
[09:18:01] <JeroenDeDauw>	 lazowik: did you look at SiteLinkSerializerTest?
[09:18:11] <lazowik>	 now I'm looking
[09:18:27] <lazowik>	 and before looked in repo tests ;p
[09:19:00] <lazowik>	 ok, there it can be tested
[09:20:22] <lazowik>	 JeroenDeDauw: still awake => since yesterday? :O
[09:20:48] <JeroenDeDauw>	 lazowik: that code has been there since around the time of the dinosaurs
[09:21:24] <JeroenDeDauw>	 or not
[09:21:26] <JeroenDeDauw>	 huh
[09:21:37] <JeroenDeDauw>	 its doing some evil stuff tho
[09:21:45] <JeroenDeDauw>	 who +2'd this :<0
[09:22:27] <JeroenDeDauw>	 damn, guessed the wrong one of the two
[09:22:33] <lazowik>	 JeroenDeDauw: I can fix at once
[09:24:07] <lazowik>	 JeroenDeDauw: hmm, you mean serializer or tests for it?
[09:24:28] <JeroenDeDauw>	 tests
[09:24:38] <lazowik>	 and what's evil?
[09:26:58] <lazowik>	 JeroenDeDauw: do you want me to wait for you undoing evil?
[09:27:27] <JeroenDeDauw>	 no
[09:36:25] <grrrit-wm>	 (03PS4) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[09:36:29] <lazowik>	 JeroenDeDauw: ^
[09:36:48] <lazowik>	 though now I have one doubt: it's _should_usekeys
[09:37:05] <lazowik>	 is there a ways to force badges always to _not_ be keyed?
[09:37:15] <lazowik>	 i.e. always set "badge" tag
[09:37:43] <JeroenDeDauw>	 WHAAAAAAAT? omfg? So I watch this presentation for 1h and then it cuts off? End of video?
[09:37:45] <JeroenDeDauw>	 FUUUU
[09:38:10] <lazowik>	 ...
[09:39:09] <JeroenDeDauw>	 lazowik: will have to ask me when I'm awake again, off to get some sleep
[09:39:16] <lazowik>	 :D
[09:39:24] <lazowik>	 I'll try to find out
[10:01:03] <grrrit-wm>	 (03PS5) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[10:04:43] <grrrit-wm>	 (03PS4) 10Michał Łazowik: Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 
[10:06:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik)
[10:08:41] <grrrit-wm>	 (03PS5) 10Michał Łazowik: Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 
[11:20:25] <lazowik>	 DanielK_WMDE_: hey, could you explain what is not decided in https://gerrit.wikimedia.org/r/#/c/82842/
[11:23:27] <lazowik>	 you only said it's not that trivial and I don't even know what to do now ;p
[11:26:25] <DanielK_WMDE_>	 lazowik: i would have left it as it was. was there an actual problem to fix?
[11:26:32] <lazowik>	 yep
[11:26:44] <DanielK_WMDE_>	 (sorry, i have to run away in a minute and take care of the kids)
[11:26:51] <lazowik>	 np
[11:27:02] <lazowik>	 xml (and probably some other formats) failed
[11:27:13] <lazowik>	 with usekeys = true
[11:27:30] <DanielK_WMDE_>	 lazowik: but why? the indexTagName is set, so it should work, no?
[11:27:41] <lazowik>	 the thing is that is didn't...
[11:27:51] <lazowik>	 and provided an error saying to use setIndexedTagName
[11:27:56] <DanielK_WMDE_>	 xml should never have usekeys = true
[11:28:00] <GerardM>	 http://ultimategerardm.blogspot.nl/2013/09/wikidata-supports-280-wikipedias-and-10.html
[11:28:19] <DanielK_WMDE_>	 usekeys is for json & co. for xml, it should always be false
[11:28:19] <lazowik>	 DanielK_WMDE_: it has after wbsetsitelinks
[11:28:37] <DanielK_WMDE_>	 now i'm completely confused
[11:29:03] <lazowik>	 after === when showing result of edit
[11:29:06] <DanielK_WMDE_>	 sorry, i'd have to investigate the concrete error case. top me it seems like the logic is backwards
[11:29:17] <lazowik>	 mhm
[11:29:22] <DanielK_WMDE_>	 but i can't do this now
[11:29:45] <lazowik>	 eh, ok
[11:29:45] <DanielK_WMDE_>	 anyway, treating this as a map (with usekeys, etc) seems odd. i'd just keep it as a  list, I think
[11:29:48] <DanielK_WMDE_>	 and supply a tag name
[11:29:49] <DanielK_WMDE_>	 that *
[11:29:54] <DanielK_WMDE_>	 thet *should* be sufficient
[11:30:03] <DanielK_WMDE_>	 but as i said, i'd have to investiagte
[11:30:05] <DanielK_WMDE_>	 ok, gotta go
[11:30:29] <lazowik>	 bye
[12:40:32] <lazowik>	 DanielK_WMDE_: got it!
[12:59:58] <grrrit-wm>	 (03PS6) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[13:07:58] <grrrit-wm>	 (03PS7) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 
[18:06:07] <lazowik>	 JeroenDeDauw: awake? ;p
[18:24:19] <Tpt_>	 Lydia_WMDE: Hi! Is it wanted that keys in claim array have change of case in 1.22wmf16 version?
[18:24:28] <Tpt_>	 see https://test.wikidata.org/wiki/Special:EntityData/Q17.json
[18:24:53] <Tpt_>	 This will break a lot of bots and lua modules
[18:53:23] <lazowik>	 DanielK_WMDE_: got it!
[18:53:48] <lazowik>	 addSiteLinksToResult wasn't setting usekeys for sitelinkserializer
[18:53:56] <DanielK_WMDE_>	 lazowik: awesome!
[18:54:22] <lazowik>	 DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/82842/
[19:02:03] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Looks like the right thing to do. Remind me to poke at this on monday, so it can go in." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 (owner: 10Michał Łazowik)
[19:11:59] <lazowik>	 huh
[19:12:27] <lazowik>	 Fun fact: SetSiteLinks uses enwiktionary as bad site...
[19:14:30] <DanielK_WMDE_>	 lazowik: i guess the intend was to use a site that is known but not a valid target in the default config
[19:14:53] <lazowik>	 mhm
[19:14:54] <DanielK_WMDE_>	 would of course be better to avoid global state completely, and provide a set of known and a set of allowed sites just for the test
[19:15:16] <DanielK_WMDE_>	 not easily done for an api test though, since we can't really inject stuff into api modules.
[19:27:35] <lazowik>	 DanielK_WMDE_: do you know what I should do to make EntityTestHelper::getId work in provider in a unit test?
[19:44:11] <Tpt_>	 DanielK_WMDE_: Hi! Is it wanted that keys in claim array are now in upper case in 1.22wmf16 version?
[19:44:12] <Tpt_>	 see https://test.wikidata.org/wiki/Special:EntityData/Q17.json
[19:44:12] <Tpt_>	 This will break, I think, a lot of bots and lua modules
[19:55:51] <DanielK_WMDE_>	 lazowik: you can't. The ID is only there after the test entities are in the database. and the test "overlay" of the db isn't available when the proivers run. 
[19:56:25] <DanielK_WMDE_>	 lazowik: the solution is to make the provider return well known "handles" for test entities, and resolve them to real entities when the test itself is run.
[19:56:32] <DanielK_WMDE_>	 (that'S exactly what getId is for)
[19:56:49] <legoktm>	 Tpt_: that's not good….
[19:57:11] <Tpt_>	 legoktm: Yes :-(
[19:57:27] <legoktm>	 I'll file a bug for it...
[19:57:33] <DanielK_WMDE_>	 Tpt_, legoktm: hm, we were pretty inconsistent about upper/lower case for IDs in the past. We are trying to be consistent now. I can't see a way to do that without breaking anything...
[19:58:02] <legoktm>	 DanielK_WMDE_: 1) if something like that gets changed, it needs to be announced. 2) what's wrong with sticking with lowercase?
[19:58:02] <DanielK_WMDE_>	 Tpt_, legoktm: do file a bug report though, we should think about minimizing the fallout.
[19:58:21] <DanielK_WMDE_>	 maybe there could be an parameter to enable "legacy id format" or some such
[19:59:30] <DanielK_WMDE_>	 legoktm: 1) yes indeed - my guess is that it's the result of an internal refactoring, and nobody thought about the resulting change in the apih. (just a guess though).
[19:59:36] <DanielK_WMDE_>	 2) consistency with page titles
[20:00:26] <DanielK_WMDE_>	 so, do file a bug report
[20:00:47] <Tpt_>	 This affect the MW API and the Lua API
[20:01:37] <legoktm>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=53894
[20:02:06] * legoktm  goes afk

[20:12:37] <lazowik>	 DanielK_WMDE_: ok, thanks
[20:14:56] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#79 (master - 0f2d70d : Translation updater bot): The build was broken.
[20:14:56] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/aa53f20b2fdf...0f2d70db6909
[20:14:56] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/11102942
[21:07:04] <Emw>	 Is there any impression on when queries will be ready?
[21:09:50] <lazowik>	 Lydia_WMDE: ^
[21:10:29] <lazowik>	 Emw: though I doubt she's here
[21:38:43] <Sven_Manguard>	 Any impression on when the INI datatype will be ready?
[21:51:53] <DanielK_WMDE_>	 Emw: "hopefully by the end of the year"
[21:52:05] <DanielK_WMDE_>	 Sven_Manguard: INI?
[21:52:12] <Emw>	 DanielK_WMDE_: good to know!  thanks.
[21:52:31] <Sven_Manguard>	 is that not what it's called? The datatype that allows us to use websites
[21:52:36] <Sven_Manguard>	 stick in a URL
[21:53:11] <DanielK_WMDE_>	 that data type is called "url". it's already on test.wikidata.org and will be deployed next week.
[21:53:32] <DanielK_WMDE_>	 we were dicussing whether that should be handled as a string or an IRI internally, but that doesn't really concern the user end of things
[21:54:04] <DanielK_WMDE_>	 (note the confusing difference between "data type" and "value type": the data type "commonsMedia" uses the value type "string")
[21:54:34] <DanielK_WMDE_>	 value types are an internal thing. you shouldn't have to think about them.
[22:23:11] <Sven_Manguard>	 oh cool
[23:19:40] <JeroenDeDauw>	 lazowik: nope, still sleeping
[23:19:59] <lazowik>	 ah, sorry I've waken you :/
[23:20:07] <lazowik>	 (does that word even exist?)
[23:20:16] <JeroenDeDauw>	 woken
[23:20:21] <lazowik>	 ah
[23:21:18] <lazowik>	 applied word formation
[23:22:13] <lazowik>	 JeroenDeDauw: anyways, good thing DanielK took a look at the change, the logic is reversed
[23:22:28] <lazowik>	 badges are always a list now
[23:23:12] <lazowik>	 and it didn't work before because addSiteLinksToResult didn't set usekeys for siteLinkSerializer