[04:41:54] I'm just going to be over here, reveling in sin, if anyone needs me [05:32:26] JeroenDeDauw: you're staff, right? [05:32:34] WMDE staff* [05:34:52] Sven_Manguard: if one assumes I have not been fired without me knowing, yeah [05:35:02] why? [05:40:16] PMed you [06:06:22] Anyone here a translation administrator? [06:34:01] if a translation admin happens to see this, there's a new section on https://www.wikidata.org/wiki/Wikidata:List_of_properties/Works and it needs translate tags [06:34:19] Sven_Manguard: https://www.wikidata.org/wiki/Wikidata:TN [06:34:33] you can make a request there and someone will get to it [06:35:05] {{done}} [06:35:05] How cool, Sven_Manguard! [06:44:34] JeroenDeDauw: do we have an exact date when the URL datatype goes live on wikidata? [06:45:31] Sven_Manguard: nope, to far removed from what I'm doing - better Ask Lydia_WMDE_ [06:46:58] that's a project for another day then. I need to catch some sleep [09:01:47] moin [09:02:02] i screwed up my desktop. no audio or video. happy is till have internet :) [09:02:08] i'll send my daily via mail [09:08:25] (03PD3) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [09:08:37] (03PS4) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [09:08:48] (03PS3) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [09:09:00] let's see whether jenkins still fails... [09:09:24] (03CR) 10jenkins-bot: [V: 04-1] Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [09:09:37] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [09:09:39] oh, now it fails on the first patch too. yay [09:10:13] oh ffs. PHP Fatal error: Class Ask\Serializers\DescriptionSerializer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Serializers\Serializer::canSerialize) in /srv/ssd/jenkins-slave/workspace/mwext-Wikibase-repo-tests/extensions/Ask/src/Ask/Serializers/DescriptionSerializer.php on line 98 [09:10:27] THis means master is broken, yes? [09:11:26] Looks like fallout from renaming canSerialize to isSerializerFor. Ugh. [09:16:02] DanielK_WMDE: panic! [09:17:10] JeroenDeDauw: http://www.3dsupply.de/products/1103-welcome-dark-side/ [09:24:18] This commit got eaten by nyancat https://gerrit.wikimedia.org/r/#/c/82860/ [09:24:22] Merged on gerrit [09:24:30] not in the actual git repo rthough [09:25:55] huh? [09:26:27] JeroenDeDauw: can you submit it again? then i'll merge it again :) [09:26:40] or self-approve with a reference to the original merge [09:26:43] DanielK_WMDE: it is actually in the git repo [09:26:47] but not on master [09:26:50] checkout 2.0 tag [09:26:52] ... [09:28:41] now I did a pull... [09:28:45] and it works [09:28:56] but not for jenkins... [09:29:04] retrigger test [09:29:10] i did [09:29:22] or do you mean something changed in the last 10 minutes? [09:29:47] (03PS5) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [09:29:57] we'll see [09:31:48] cheers [09:32:47] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [09:38:15] Abraham_WMDE: addshore: hehe [09:38:55] :P [09:39:00] More appropriate to have a tshirt with something like https://dl.dropboxusercontent.com/u/7313450/entropy/hate-friendshipbeam.jpg [09:45:15] (03CR) 10Jeroen De Dauw: [C: 04-1 V: 04-1] "Still uses symphony :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [09:50:29] JeroenDeDauw: is https://gerrit.wikimedia.org/r/#/c/82633/4 merged? O_o [09:51:21] I cant see it in git.... [09:54:04] addshore: ... [09:54:14] addshore: lets ditch this gerrit thing and just use GitHub? [09:54:20] hah! [09:54:42] JeroenDeDauw: gerrit got fucked up during the upgrade, lemme find the bug [09:54:43] addshore: all you need is a big box of belgian chocolates and Abraham_WMDE will make it happen [09:54:58] im just watching things vanish :P [09:55:04] JeroenDeDauw: addshore yes! [09:55:14] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=53841 [09:55:37] So we now have a bunch of commits that dissapeard? [09:55:45] How can we find them all? [09:56:04] This can turn out to be quite costly [09:56:07] time wise [09:56:22] dangling commit ea2305885613f4e5ec0971b81866238ce16d5faa [09:56:22] dangling commit 684639691ad94676b2f702317330d806beccead7 [09:56:22] dangling commit 3c43c62128c8c3d95fa4f9b02363cd8c3b103674 [09:56:22] dangling commit 3e79721c6396d0356dfba1a32e6d4e64b6917d99 [09:56:22] dangling commit 7df0de7d396c76004b8e26b8f8de810e08ef1d55 [09:56:24] dangling commit 4b6df3c288b00861cd9dd693f53865a9be228db4 [09:56:25] dangling commit 707797fba7f201c9d6676ba8d392f83b6eafdd51 [09:56:26] dangling commit e6949f08377a4f2953cc0823e24f7cae0303c706 [09:56:26] (03PD1) 10Addshore: Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83397 [09:56:27] i think those are the ones [09:56:32] (from http://p.defau.lt/?h77fp6ucbNckf1mMsypoIg) [09:56:47] (03PS1) 10Jeroen De Dauw: Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83398 [09:56:51] HAH [09:57:03] (03CR) 10Addshore: [C: 032] Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83398 (owner: 10Jeroen De Dauw) [09:57:04] (03CR) 10Jeroen De Dauw: [C: 032] "Gerrit is full of fail... https://gerrit.wikimedia.org/r/#/c/82633/4" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83398 (owner: 10Jeroen De Dauw) [09:57:15] (03Abandoned) 10Addshore: Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83397 (owner: 10Addshore) [09:57:27] hehe [09:58:13] legoktm: and for what repo are those? [09:58:20] those were wikibase [09:58:23] look at the pastebin [09:58:27] it has all the repos [09:59:38] ... [09:59:43] We need to fix all of those? [09:59:43] ergh [10:00:03] 21 commits :D [10:00:06] Seriously? Why did WMF not fix these? [10:00:08] i assume chad was going to work on it, but i dont think he did anything over the weekend.... [10:01:21] that is not professional behaviour [10:01:43] hmm, e243f8f2eea24ce16f053e63e645cce6318ff36b which says it was dangling was merged fine [10:02:16] infact, the commit I just found that hadnt merged isnt in the pastebin legoktm :/ [10:02:52] addshore: idk, it's chad's list, not mine :x [10:02:57] ;_; [10:07:31] (03CR) 10Jeroen De Dauw: "(13 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:18:06] (03PD1) 10Addshore: Implement ClaimGuid class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [10:18:37] (03Abandoned) 10Addshore: Implement ClaimId class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [10:18:42] (03CR) 10Addshore: "(6 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [10:19:15] (03CR) 10Addshore: "Please see the last changeset @ https://gerrit.wikimedia.org/r/#/c/82405/ ..." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [10:25:06] Tobi_WMDE: https://github.com/JeroenDeDauw/PhpCompatTest [10:29:08] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Nikola Smolenski link https://www.mediawiki.org/w/index.php?diff=778858 edit summary: [-747] /* alwaysSort */ This no longer exists [10:30:30] linux desktop: fixed. [10:30:56] Yay for Linux :D [10:33:08] (03CR) 10Jeroen De Dauw: "(13 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:42:33] * Lydia_WMDE_ waves [10:43:07] Lydia_WMDE_: hey! [10:43:22] have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=53894 btw? if that gets rolled out, lots of things are going to break :/ [10:43:31] legoktm: looking [10:44:19] legoktm: hmmmmm addshore ^ DanielK_WMDE ^ [10:44:50] JeroenDeDauw: before i start going through your comments - does the -2 mean you disagree with the change conceptually? [10:45:03] (03CR) 10Jeroen De Dauw: [C: 04-2] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:46:06] Lydia_WMDE_: yes, I have seen this. we decided some time ago to use uppercase IDs consistently. we'd have to go back on the decision if we want to maintain full B/C [10:46:47] Lydia_WMDE_: we can hack the serialization easily enough, but we should think about the implications. Would be really good to have denny's input on this [10:47:08] DanielK_WMDE: when is this scheuduled for deployment? next week? [10:47:14] yup [10:47:26] ok i will send an email to denny about it [10:47:37] and cc [10:47:53] Lydia_WMDE_: this week, afaik... should be on the whiteboard. [10:48:09] Lydia_WMDE_: makring this as a blocker [10:48:18] i am in edingurgh ;-) [10:48:23] can't check the whiteboard [10:48:27] thanks [10:48:38] Lydia_WMDE_: where is edingurgh ? :P [10:49:00] If you need a presentation of Wikidata in French, the slides are on Commons https://commons.wikimedia.org/wiki/File:2013-09_Introduction_%C3%A0_Wikidata.pdf [10:49:13] Pyb: was this your presentation? [10:49:21] addshore: :P [10:49:52] Lydia_WMDE_: no, it's from Coyau. I was just a participant. [10:50:10] Pyb: cool - how was it? [10:51:03] (03PS1) 10Jeroen De Dauw: Fix ItemId invalid serialization message. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83401 [10:52:31] Lydia_WMDE_: the basic presentation of Wikidata was ok (it's the second workshop made in Paris). We also tried to explain bots. This session was too short. [10:52:54] :) [10:53:10] (03CR) 10Jeroen De Dauw: [C: 032] "Already merged, gerrit failed" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83401 (owner: 10Jeroen De Dauw) [10:53:17] it's aweosme to see some local stuff happening now [10:55:21] (03PS1) 10Jeroen De Dauw: Move b/c code for ReferenceObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83403 [10:55:22] (03PS1) 10Jeroen De Dauw: Move b/c code for ClaimObject and StatementObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83404 [10:55:23] (03PS1) 10Jeroen De Dauw: Fix Aliasing direction [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83405 [10:55:36] (03CR) 10Jeroen De Dauw: "Already merged, gerrit failed" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83403 (owner: 10Jeroen De Dauw) [10:55:41] (03CR) 10Jeroen De Dauw: [C: 032] "Already merged, gerrit failed" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83403 (owner: 10Jeroen De Dauw) [10:55:48] (03CR) 10Jeroen De Dauw: [C: 032] "Already merged, gerrit failed" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83404 (owner: 10Jeroen De Dauw) [10:55:56] (03CR) 10Jeroen De Dauw: [C: 032] "Already merged, gerrit failed" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83405 (owner: 10Jeroen De Dauw) [10:56:19] DanielK_WMDE: read the message [10:56:25] (03PS1) 10Tobias Gritschacher: Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 [11:06:05] (03PS1) 10Jeroen De Dauw: Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83407 [11:06:22] (03CR) 10Jeroen De Dauw: [C: 032] "Already merged https://gerrit.wikimedia.org/r/#/c/82617/" [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83407 (owner: 10Jeroen De Dauw) [11:09:35] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#80 (master - cfffc82 : jeroendedauw): The build was fixed. [11:09:35] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/0f2d70db6909...cfffc82766a6 [11:09:35] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/11147163 [11:13:25] (03CR) 10Jeroen De Dauw: [C: 04-2] "There already is TableNameFormatter" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83394 (owner: 10Addshore) [11:17:25] (03PS2) 10Tobias Gritschacher: Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 [11:22:12] (03CR) 10Jeroen De Dauw: [C: 04-1] "(5 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [11:23:20] addshore: ^ to bad... I want to have this class ;p [11:25:04] (03CR) 10Jeroen De Dauw: [C: 032] Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 (owner: 10Michał Łazowik) [11:25:25] addshore: meeergeee https://gerrit.wikimedia.org/r/#/c/82867/ [11:25:43] (03PS4) 10Jeroen De Dauw: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [11:26:39] (03CR) 10Addshore: [C: 032] Remove test class that was moved to another component a while back [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82867 (owner: 10Jeroen De Dauw) [11:26:49] (03Merged) 10jenkins-bot: Remove test class that was moved to another component a while back [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82867 (owner: 10Jeroen De Dauw) [11:26:59] (03CR) 10Jeroen De Dauw: [C: 031] Style the flag 'D' on watchlist and recentchanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82886 (owner: 10Umherirrender) [11:27:12] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [11:36:09] (03PS1) 10Jeroen De Dauw: Remove system tests from phpunit config as this group cannot be run via the normal runner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83408 [11:39:31] (03PS2) 10Addshore: Use the TableNameFormatter when building [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83394 [11:40:17] JeroenDeDauw: ^^ [11:40:51] (03CR) 10Jeroen De Dauw: Use the TableNameFormatter when building [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83394 (owner: 10Addshore) [11:43:29] (03CR) 10Jeroen De Dauw: [C: 032] Use the TableNameFormatter when building [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83394 (owner: 10Addshore) [11:43:58] addshore: I +4'd it [11:44:13] :O [11:51:54] (03PS1) 10Jeroen De Dauw: Add SchemaUpdateFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83410 [11:53:41] (03PS2) 10Jeroen De Dauw: Schema updating stub [DO NOT MERGE] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82630 [11:54:02] (03CR) 10Addshore: [C: 032] Add SchemaUpdateFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83410 (owner: 10Jeroen De Dauw) [11:54:07] (03Merged) 10jenkins-bot: Add SchemaUpdateFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83410 (owner: 10Jeroen De Dauw) [12:05:52] (03PS3) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [12:18:23] (03PS6) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [12:18:32] JeroenDeDauw: --^ [12:18:56] (03CR) 10Daniel Kinzler: "(25 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [12:29:10] (03PS2) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 [12:29:11] (03PS2) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter and TypedValueFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 [12:29:12] (03PS7) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [12:29:13] (03PS5) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [12:29:33] (03CR) 10Daniel Kinzler: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [12:29:44] (03CR) 10Daniel Kinzler: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 (owner: 10Daniel Kinzler) [12:29:52] (03CR) 10Daniel Kinzler: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler) [12:31:04] (03CR) 10jenkins-bot: [V: 04-1] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler) [12:31:17] orrr. [12:32:29] (03CR) 10jenkins-bot: [V: 04-1] (bug 53745) Remove old SnakFormatter and TypedValueFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 (owner: 10Daniel Kinzler) [12:32:56] hm, i wonder how i missed that [12:34:11] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [12:47:16] (03PS6) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [12:47:48] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [12:47:49] (03PS3) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter and TypedValueFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 [12:50:15] (03PS4) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 [12:50:49] (03PS3) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 [13:01:30] it's said that we changed pXX and qXX to PXX and QXX ? [13:01:33] what does it affect [13:06:36] the web API and the lua API [13:11:55] liangent: we'd have to go through all the Serializers to override this. though it should probably be an option anyway [13:12:46] legoktm: DanielK_WMDE: in all api output? [13:12:52] yes [13:13:12] what's its benefit, in exchange for potential breakage? [13:14:04] liangent: consistency. we were using uppercase in some places, lowercase in others. but that this is happening now is really an effect of refactoring. [13:14:17] i suppose we should have thought about the consequences for bots a bit earlier :/ [13:14:36] It shouldn't be that much effort for the tools to be fixed to not care about case, the issue is noone has been told :> [13:15:40] addshore: not really. not caring about case is hard when you want to look up something in a map. you always have to try both keys. [13:15:40] that sucks. [13:15:48] * aude hopes someone is around during deployment time in addition to myself [13:16:05] addshore: I have at least some lines of code saying: if 'pXXX' in data['snaks'] [13:16:16] ^^ thats what a ton of pwb code looks like [13:16:25] plus a ton of lua across a bunch of wikis [13:17:01] mhhhmm [13:18:13] DanielK_WMDE: where did we use uppercase in code? [13:18:26] liangent: EntityId [13:19:18] JeroenDeDauw: for any user visible data? [13:19:37] $this->serialization = strtoupper( $idSerialization ); [13:20:01] liangent: for everything [13:20:23] JeroenDeDauw: *did*, ie. in the past, before the recent change [13:20:54] liangent: in the UI [13:21:18] stuff like "label (Q###)" [13:21:21] on special pages [13:21:25] or in edit summaries [13:21:27] oh [13:22:26] and it's thought that uppercase is prettier? [13:22:29] at least for human reads [13:23:16] DanielK_WMDE: JeroenDeDauw as far as I can see its a one line change to go back to lowercase for this deployment? [13:23:43] addshore: what line? [13:24:04] 62 in EntityId, change strtoupper to strtolower ;p [13:24:55] lulz. [13:25:02] ;p [13:25:44] then give people time to not care about case and then switch for upper [13:26:06] addshore: please check how we were writing IDs to the database; property IDs in the internal serialization. Database fields (at least one, iirc). [13:26:26] addshore: I *think* we were using lower case there, and we actually can't just change that. especially not in the DB table. [13:26:45] JeroenDeDauw: actually, one more reason not to have prefixed IDs in the DB ----^ [13:26:46] DanielK_WMDE: we are, or at least were doign that [13:27:03] yea... [13:27:09] we can't just change that now [13:27:17] people dealing with dumps get lowercase ids [13:27:29] well, in the JSON, it'S probably not a big deal, but we have to triple check when using the ID for a lookup in an array [13:27:31] not a big deal [13:27:44] we may have to check both versions of the id, or normalize the keys first - that sucks [13:28:03] and for what goes into the database itself - it must not change. we also have to check the queries. [13:28:09] DanielK_WMDE: you do not have to do this unless you are messing up something else [13:28:21] JeroenDeDauw: hm? [13:28:24] like what? [13:28:53] addshore: this woulod break the tests, and IIRC there was some fail case sensitive code we ourselves had, which might not be fixed. And hard to tell if the tests fail [13:29:18] DanielK_WMDE: normalization happens in the domain model [13:29:24] Lookups happen in the domain layer [13:29:38] if you have a lower case id in the db, this has no affect [13:29:46] *effect [13:30:12] JeroenDeDauw: unless your domain level now uses an upper case key to make a lookup. [13:30:18] i don't know if we do, but we need to check. [13:30:35] JeroenDeDauw: also, in the database fields, it would be rather horrible to have mixed upper and lower case ids [13:30:43] what would the query look like?... [13:30:59] (i hope we don't have any queries over that field, let me have a look) [13:31:09] DanielK_WMDE: that second point is obvious and can trivially be taken care of by the store [13:31:53] hoo: if you have time fancy re reviewing the getentites test refactor? [13:32:02] DanielK_WMDE: for the array lookup - like I said the problem will not occur unless you put domain logic where it should not be [13:32:20] in fact one now no longer has to care about the capitalization at all in the domain layer [13:32:29] while before it could actually have been different [13:32:30] addshore: mhm, I doubt I can come to that... there's a lot of stuff on my review dashboard :/ [13:32:35] :P [13:33:11] JeroenDeDauw: do we have tests for uppoer and lower case data for all the relevant code? [13:33:19] including db queries? [13:34:05] DanielK_WMDE: did we have tests before? Since it was quite possible to have EntityIds with any capitialization [13:34:16] Also, what is the point of that question? [13:34:48] To be quite honest I'm getting the imptression you just are trying to find something to complain about [13:36:31] JeroenDeDauw: o_O [13:37:04] JeroenDeDauw: we are deploying a major braking change without proper tests. [13:37:20] JeroenDeDauw: I'm disturbed that I didn't realize this earier. [13:37:38] * aude concerned [13:37:38] I'm also disturbed nobody else did. [13:38:31] not that i make decisions, but i am tempted to say we update wikidata on wednesday to give more testing time and deal with these things [13:39:02] there are a bunch of big changes in the code and likely something might break [13:39:38] * aude updating my development wikis and catching up [13:40:21] change_object_id is lower case at the moment, and will become upper case, right? [13:40:43] i can check but not until i get my setup updated [13:40:53] which table? [13:40:59] wb_changes [13:41:09] i think it should be fine, as we did test the change propagation extensively [13:41:15] i don't think we are doing queries on that field. but if we do, they'll likely get confused [13:41:48] DanielK_WMDE: yes its going to change to uppercase [13:41:59] oh, ick [13:42:04] yes i see Q4 there [13:42:08] and q4 [13:43:12] \o/ [13:43:30] well, as long as we don't query the field: no big deal. it'll get normalized by EntityId [13:43:39] ok, i have looked at the internal JSON [13:43:46] i don't think the inconsistency is good [13:44:00] seems like the only thing that may get screwed up are claim IDs. [13:44:00] although wb changes will get pruned soon [13:44:07] and then will be only uppercase [13:44:09] they use a lower case "q" at the moment [13:44:17] * aude nods [13:44:20] DanielK_WMDE: indeed [13:44:34] so, when looking up a claim by upper case ID, will it work? [13:44:40] we need compat code foir that [13:44:47] i think it is considered valid [13:44:50] DanielK_WMDE: since we want drama - oh! this is not covered by tests?! better add some change handler tests then! [13:44:53] ;) [13:45:28] *goes to look at claim guids.. [13:46:36] DanielK_WMDE: opened ChangeHandler to look at what it does with change_object_id [13:46:43] First thing I see is usage of an undefined class [13:46:48] ie code that is broken [13:47:54] so yeah, some strtolower will need to be added there. And the code needs tests, obviously for more then just the id stuff [13:50:12] DanielK_WMDE: did you mean looking up a claim with guid through the api or somewhere else specific? [13:56:54] addshore: anywhere, but especially via the API. Claims::getClaimWithGuid etc need to apply normalization [13:57:00] ...or use ClaimId [13:57:10] heh! [13:58:55] mhhm, Q42$GUID is treated separately to q42$GUID but I dont know if thats really an issue [14:00:26] addshore: I think it is, yes [14:01:21] mhhm, but people aren't going to randomly choose guids they want to view, they will request them from the api where they will be both upper and lower case, and if you try to access either you would still get the expected claim [14:02:21] addshore: do bots still need to generate claim guids? [14:02:24] for new claims? [14:02:37] they never should have!!!! [14:02:39] :< [14:02:45] addshore: they are defined to be equivalent. they should behave as equivalents. [14:02:52] but nothing has changed in that module yet aude [14:02:59] addshore: would be nice to have guids generated for me [14:03:14] aude: that code is in review, i think [14:03:15] addshore: ok, so bots should start generating guids with Q42 [14:03:16] aude indeed, hopfully in the next feww weeks [14:03:23] DanielK_WMDE: ok [14:03:33] aude: bots should stop generating guids :P [14:03:37] JeroenDeDauw: strtolower won't do in ChangeHandler, since the ids can be upper OR lower case in the DB table. [14:03:44] it makes me want to cry.. [14:03:45] or we have to make sure they are always lower case there [14:03:51] heh [14:04:42] DanielK_WMDE: yes, that is the idea - always have them lowercase there [14:04:50] Not sure how that was not clear [14:04:55] What else would you do? [14:05:23] You could have both and just bang your head against the wall, though I'd rather go with lowercasing stuff [14:06:05] JeroenDeDauw: also see if this is aiming towards what you were thinking https://gerrit.wikimedia.org/r/#/c/83411/ [14:06:09] finding all places where that needs to be done is going to be painful :/ [14:06:39] DanielK_WMDE: change handler is writing to the field in many different places? [14:09:10] (03PS7) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [14:10:08] JeroenDeDauw: ChangeHandler isn't writing this to the database at all. ChangeHandler is the receiving end. [14:10:18] EntityChange is what defines how this gets written to the DB [14:10:45] JeroenDeDauw: but the thing is - when we read a change from the DB, we mayb be comparing the entity ID, or use it as an array key, or whatever [14:11:02] and we have to find and check all those places, because they will no longer just work with what EntityId returns [14:11:10] that's the tricky bit [14:12:10] JeroenDeDauw: maybe EntityChange could upper-case on loading? would that help, or make things worse? [14:12:20] in that case, you can't use the value from the record in a db query... [14:12:29] DanielK_WMDE: doing normalization when reading the thing from the db should not be tricky. If it is, this indicates leaky abstraction [14:12:54] And for EntityChange it should be easy to add a strtolower there so we keep consistency with what is already in the db [14:13:26] DanielK_WMDE: entity change is used both for writing and reading the thing? [14:14:11] JeroenDeDauw: yes. It's an ORMThingy [14:15:19] JeroenDeDauw: the fact that we deal with IDs as strings at all is one big leak of abstraction. it's all over the code. [14:15:41] well, not as bad as it used to be, but there are quite a few places. [14:15:48] like the claim id stuff [14:19:31] DanielK_WMDE: yeah, its all so bad [14:22:38] legoktm: hi can you update this page? https://www.wikidata.org/wiki/Wikidata:Database_reports/Popular_items [14:22:49] you update the properties but not this, strange [14:22:52] * legoktm looks [14:23:05] lolwut [14:23:06] um [14:23:51] (03PS4) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 [14:23:52] (03PS5) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 [14:25:55] File "/home/project/d/b/r/dbreps/bin/popular_items.py", line 64, in mk_report [14:25:55] text+= table_row.format(qid, count) [14:25:55] IndexError: tuple index out of range [14:27:21] Amir1: I fixed it, re-running right now [14:27:34] (03PS1) 10Daniel Kinzler: Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 [14:27:41] legoktm: thank you :) [14:28:03] legoktm: I heard there are some problems about sf-->bugzilla, do you need more hands? [14:28:13] (03CR) 10Addshore: [C: 032] Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 (owner: 10Daniel Kinzler) [14:28:36] https://www.mediawiki.org/wiki/Manual:Pywikipediabot/Migrating_to_bugzilla#Script_to-dos [14:28:41] i'm working on the OAuth thing [14:28:42] (03CR) 10Jeroen De Dauw: [C: 032] Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 (owner: 10Daniel Kinzler) [14:28:50] setting priority is the last thing we have to do [14:28:52] (i think!) [14:28:57] JeroenDeDauw: i beatz you again ;p [14:29:05] (03CR) 10Jeroen De Dauw: [C: 04-2] Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 (owner: 10Daniel Kinzler) [14:29:11] (03CR) 10Jeroen De Dauw: [C: 032] Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 (owner: 10Daniel Kinzler) [14:30:31] addshore: :<0 [14:30:37] (03Merged) 10jenkins-bot: Added missing class import. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83412 (owner: 10Daniel Kinzler) [14:30:40] addshore, JeroenDeDauw, aude: so, to preserve our internal consistency, where do we need to convert to/from lower case? I can think of two classes: Claims and EntityChange [14:30:40] !no | addshore [14:30:40] addshore: https://bit.ly/dennyno [14:30:45] anyone already working on these? [14:31:41] legoktm: let me check [14:38:12] legoktm: I'll do the last one [14:38:17] tonight [14:46:55] (03PS1) 10Daniel Kinzler: Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 [14:48:21] oh duh, tested with the client setup :/ [14:48:33] (03CR) 10jenkins-bot: [V: 04-1] Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 (owner: 10Daniel Kinzler) [14:52:50] (03PS2) 10Daniel Kinzler: Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 [14:53:34] addshore: do you have a change in the queue that would make the Claims class use ClaimIds? [14:56:56] JeroenDeDauw: I don't see tests for Claims::xxxClaimWithGuid. Am I missing something? [14:57:01] DanielK_WMDE: on https://wikitech.wikimedia.org/wiki/Deployments it says "September 26: Wikidata deploy with MediaWiki" [14:57:06] and "Also: Wikidata on Mediawiki.org will be upgraded" for wednesday [14:57:12] any clue what that is? [14:57:21] it sounds like an error [14:57:27] yea, no idea [14:57:31] ok [14:57:36] i can ask [15:03:25] DanielK_WMDE: idk, not looked at this code for a year [15:12:08] DanielK_WMDE: nope [15:14:50] hrm... [15:15:20] addshore: are you changing the return type of Claim::getGuid? Probably shouldn't but add Claim::getId() [15:17:05] DanielK_WMDE: still blocked on that Content thingy :( [15:17:32] (03CR) 10Addshore: "(3 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [15:17:48] DanielK_WMDE: thats as my current changes go ^^ [15:19:18] ignore the fact its in a new changeset... gerrit was being rather annoying this morning [15:20:03] Abraham_WMDE: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#!cart [15:28:15] (03PS1) 10Jeroen De Dauw: Move ALL of the files [DNM, NDY] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83415 [15:28:20] (03CR) 10jenkins-bot: [V: 04-1] Move ALL of the files [DNM, NDY] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83415 (owner: 10Jeroen De Dauw) [15:29:29] addshore: it'S called ClaimGuid again, not ClaimId? [15:29:32] why? [15:29:46] JeroenDeDauw: ^^ join in :P [15:30:06] I have no preference, you said ClaimId, JeroenDeDauw says ClaimGuid [15:30:47] it is referenced everywhere in code as a claim guid not an Id, but then the datamodel only contains IDs currently for entities items and props [15:35:27] addshore, JeroenDeDauw: i'd pref that the Claim itself contains a GUID as a string, with no prefix, and has a getGuid methid for fetching it. The ClaimId would include an entity ID as a prefix, and would be used by the API etc. Claims could have conveniance methods supporting both. [15:35:57] Any internal lookup should happen without the prefix. though we have a lot of legacy data in the db now that does have prefixes in claim guids. [15:37:28] (03PS4) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [15:37:35] hmm [15:38:27] I'm not sure I totally follow :/ so a claim would have both a guid and an id? [15:40:54] addshore: the claim would *have* a guid. the ClaimId would include that and the entity ID. [15:41:02] the Claim itself wouldn't know the entity ID [15:41:22] hmm, okay [15:41:43] There could be something like Entity::getClaimId( Claim ) returns ClaimId [15:42:04] DanielK_WMDE: addshore do you think we'll really be ready for deployment in 2 hours? [15:42:10] There are aguments both for having the entity id in there and for not having it. DanielK_WMDE, if you want to change this, a thread on the mailing list would be best suited [15:42:13] and Entitiy::getClaimById( ClaimId ) as well as Entitiy::getClaimByGuid( string ) [15:42:20] and then the api would allow access using a serialised ClaimId which would be be entityId$guid ? [15:42:34] are there any other issues? [15:42:44] JeroenDeDauw: probably. i want to have the entity ID in there for the external representation, but not internally. [15:42:48] internally, it gets i nthe way. [15:42:56] ...and makes construction awkward. [15:43:08] Assuming we would want to drop the entity id from the claim identifier, it would be bad to have a ClaimId class that does have it anyway [15:43:52] JeroenDeDauw: why? we do need the pair og entity id and guid. just not *inside* the claim. [15:44:31] aude: i'd prefer mroe time for testing. i'm finishing the last tests for the things i could think of. but that's no guarantee. [15:44:42] in effect youd just be asking for a claimguid and entityid pair rather than the concatinated string [15:44:45] DanielK_WMDE: ClaimId would be a bad name [15:45:15] JeroenDeDauw: yea, might be misleading, but i can't think of a better one. ClaimLocator? [15:45:18] if everything handeled them separately at this stage things would probably be easier [15:45:47] DanielK_WMDE: i'd like to think over all the new stuff we have and test things again (e.g. change dispatching) [15:46:04] in case there's something else we overlooked [15:46:07] addshore: yes and no: I didn't want to have them as separate parameters in the API. I still stand by that decision: when I operate on a claim, i want to provide a single, opaque identifier for that claim. [15:46:21] the caller shouldn't care how the software addresses or accesses it. [15:46:54] aude: i'd prefer that too, but does that mean we'd push deployment for a full week? [15:47:04] that would be sad. though better than breaking the site. [15:47:12] no, it could be maybe tomorrow or otherwise wednesday with the wikiepdais [15:47:15] wikipedias [15:47:17] indeed! so we could leave guid as a string and have a claimId class that uses both the guid and entityid (or a locater or whatever) [15:47:30] aude: tomorrow is good, i'll be at the office in the evening [15:47:32] issue is that this would also affect wikivoyage so i need to check if that is okay [15:47:39] addshore: yes. [15:47:55] I think thats a perfectly reasonable idea [15:48:15] and best of all, externally nothing would change ;p [15:48:17] addshore: hehe... are you volunteering to work on it? [15:48:33] greg-g: Reedy poke [15:48:35] DanielK_WMDE: no, that would be bad as well. ExternalClaimId is clearer [15:48:54] addshore: or, actually... let's definitly put this on bugzilla. want to write it? [15:49:00] DanielK_WMDE: addshore: Looking at this code, I am questioning if it makes sense to have a guid inside of Claim at all [15:49:06] Right now it is not enforced [15:49:13] Bettre to either enforce it or not have it [15:49:14] .. [15:49:23] its not enforced? O_o [15:49:25] JeroenDeDauw: it should be enforced. [15:49:28] It is not enforced because it is not needed in all cases [15:49:36] addshore: you can have no guid, or a random string as a guid, [15:49:39] In fact, the guid thing is something not specific to claim at all [15:49:40] aude: heya [15:49:51] JeroenDeDauw: it'S not enforced because right now, we can't - in some cases, we don't know the entity id yet [15:49:55] We cannot enforce it without preventing valid usage of Claim [15:50:13] DanielK_WMDE: Which indicates a deisgn flaw yes [15:50:19] greg-g: would there be time tomorrow or wednesday to deploy wmf16 to wikidata, instead of today? [15:50:23] I suggest moving it out of Claim and into Entity [15:50:31] the guid? O_o [15:50:35] yes [15:50:39] JeroenDeDauw: which is exactly what i'm trying to get rid of be dropping the entityid [15:50:48] we have a couple important breaking changes and would prefer additional time to test / ensure there are no problems [15:50:53] DanielK_WMDE: that is clear yes [15:51:03] DanielK_WMDE: that only solves part of the probl;em though [15:51:11] JeroenDeDauw: no, moving that into entity is not going to work. at least not without a *lot* of pain. [15:51:20] im not sure totally follow again.. [15:51:28] look at how CLaims is used, ahow the diff is constructed, etc [15:52:05] DanielK_WMDE: are you talking purely about the refactoring/migration process? [15:52:06] JeroenDeDauw: i think removing the guid (or whatever kind of id) from the Claim is going to cause mroe trouble than it would save. [15:52:27] no, i'm talking about what information/objects are required to perform specific tasks. [15:52:37] if claims have no guid, how would you interact with a given claim? [15:52:42] a claim *has* identity. so it should have an id string. [15:52:50] DanielK_WMDE: then please explain how this will be problematic [15:52:56] DanielK_WMDE: it has identity in some use cases [15:53:17] in which use cases does it not have identity? [15:53:24] aude: tomorrow, yeah. [15:53:30] greg-g: ok [15:53:43] would it be okay to switch wikivoyage then also? [15:53:57] Reedy: aude is requesting delaying the wd upgrade/wikivoyage deploy until tomorrow, we have the day open. [15:54:00] aude: yah [15:54:07] JeroenDeDauw: we currently use Claims to build a diff. The diff relies on the guids in order to compare the "right" claims with each other [15:54:08] greg-g: great [15:54:11] aude: :) [15:54:25] * aude prefer to catch any issues before deployment :) [15:54:26] DanielK_WMDE: what code exactly? [15:54:31] JeroenDeDauw: the required information could come from somewhere else, but I see no nice way of doing that [15:54:37] Claims::getDiff [15:54:43] i am around all day and evening tomorrow and daniel is also around tomorrow evening [15:55:28] DanielK_WMDE: yes, this would indeed not be possible any longer in Claims [15:55:39] DanielK_WMDE: we can however just move the code [15:56:31] DanielK_WMDE: notice where the current only user of this method is [15:57:05] JeroenDeDauw: always possible. the question is what it gains us. unless there are use cases where a claim really can't have identitiy. [15:57:09] i can't think of any [15:57:23] To me, identity is an integral part of Claim-ness. We should enforce it, not remove it. [15:57:31] +1 [15:57:45] DanielK_WMDE: it will be enforced for all claims we have in Wikidata via Entity [15:58:21] DanielK_WMDE: explain to me how identity is any more integral to Clainm then to Snaks? [15:58:30] These objects do not inherenttly care about this [15:58:36] So why force it upon them? [15:58:49] Why force people generate a GUID when they do not need it? [15:59:16] JeroenDeDauw: A snak is defined by its type and value. it has no identity beyond that. two snaks are either equal or not. you can not "modify a snak". you replace it. [15:59:35] Claims however, like entities, have an identity: you can modify a given claim and compare versions. [15:59:41] DanielK_WMDE: that is high level policy and usage [15:59:46] It is not defined by the data model [15:59:59] JeroenDeDauw: no, that's the conceptual definition of the thing the code is suzpposed to model. [16:00:10] DanielK_WMDE: isn't modifying a claim handled as remove old one / add new one [16:00:13] ? [16:00:17] it gets a new claim guid [16:00:18] aude: no [16:00:23] or it shouldnt be [16:00:23] not anymore? [16:00:37] JeroenDeDauw: actually, we discussed exactlky this distinction when building the data model. But it's probably not explicit in what is written down. [16:01:00] aude: if it gets a new guid, that's a massive bug. it would mess up diffs biig time. [16:01:09] DanielK_WMDE: i think that used to be the case [16:01:20] I think it is still in many places actually [16:01:20] and yes, it made the diffs look odd [16:01:23] aude: maybe. but it shouldn't. [16:01:26] agree [16:01:41] addshore: time to fix that then [16:01:52] DanielK_WMDE: I want to fix everything claimy and guidy [16:01:58] :) [16:02:03] it means that changing one snak in one reference gives you a diff of one bug claim being removed and another added. [16:02:06] that's NOIT good. [16:02:18] addshore: yes! write it down first though, please. [16:02:25] on bugzilla, if possible [16:02:41] DanielK_WMDE: that is/was how things worked in soem places and is ugly [16:02:44] evil [16:02:47] JeroenDeDauw: it's an interesting conceptual discussion. and well worth a thread on the ML [16:02:48] the first issue I stumbled on is there is no way to find out the entity from claim, which is used in a hackyway in many places, and now it just keeps getting bigger and bigger [16:02:53] * DanielK_WMDE needs to submit his last patch [16:02:57] DanielK_WMDE: ok [16:03:02] aude: yes, let'S fix it :) [16:03:45] addshore: removing the guid from Claim will obviously solve that issue [16:03:55] *sigh* [16:06:19] (03PS1) 10Aude: (bug 53367) ensure both sites and titles for GetEntities lookup by site link [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83416 [16:06:41] DanielK_WMDE: addshore can you please look at https://gerrit.wikimedia.org/r/#/c/83416/ [16:07:07] that again.... [16:07:11] yes [16:08:28] * aude is going home and eating [16:08:31] around later [16:09:13] aude, addshore: have to fix dinner and mind the kids for a few hours, sorry. i'll finish up the fix for Claims later. [16:09:22] quite a few tests are affected :/ [16:18:07] (03CR) 10Zfilipin: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 (owner: 10Tobias Gritschacher) [16:20:38] (03PS3) 10Tobias Gritschacher: Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 [16:22:56] (03PS4) 10Zfilipin: Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 (owner: 10Tobias Gritschacher) [16:23:04] (03CR) 10Zfilipin: [C: 032] Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 (owner: 10Tobias Gritschacher) [16:26:04] (03Merged) 10jenkins-bot: Browsertests: send build-number to saucelabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83406 (owner: 10Tobias Gritschacher) [16:49:13] (03PS6) 10Zfilipin: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 (owner: 10Tobias Gritschacher) [16:49:31] (03CR) 10Zfilipin: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 (owner: 10Tobias Gritschacher) [17:44:28] Lydia_WMDE_: Hmm, you started about Commons without addressing the namespace issues.... :-( [17:44:53] multichill: file namespace you mean? intentional tbh [17:45:10] No, gallery and category namespace [17:45:38] hi Lydia_WMDE_ [17:45:49] multichill: then i am missing something, sorry - can you elaborate? [17:45:58] aude: hey! how was sotm? [17:46:02] Lydia_WMDE_: http://lists.wikimedia.org/pipermail/wikidata-l/2013-August/002626.html [17:46:04] Lydia_WMDE_: good! [17:46:19] just fyi, we're going to do deployment tomorrow instead of today [17:46:35] so we have more chance to test everything etc. [17:46:38] multichill: sorry can't load that atm - network is crap :( [17:46:45] aude: what's going live? [17:46:51] tomorrow? [17:46:55] yes [17:46:57] i believe urls are ready [17:47:03] i thought that was in a week [17:47:08] hmmm [17:47:16] Yeah, blame it on the network, it's probably just your shitty computer :P:P [17:47:20] in a week is nothing [17:47:23] multichill: ;-) [17:47:31] * multichill is a network engineer by day and gets this all the time [17:47:37] and changes to entity id that can affect bots/tools [17:47:50] aude: hmmmm then maybe i am mixing things up [17:47:54] and i think it will be possible to save badges via the api [17:47:59] although there is no ui for that yet [17:48:25] hence extra day for me to be sure about all this and sure there are no issues :) [17:48:36] ok [17:48:48] i am traveling tomorrow but this seems to need some handholding [17:48:54] i will be back tomorrow evening [17:48:59] ok, that's fine [17:49:13] any chance you can figure out the details during the day and let me know? [17:49:35] i think those are the details but if i find out differently, then i will tell you [17:49:51] and we'll do stuff later in the day, like late afternoon/evening [17:50:01] ok [17:50:35] also, we have geocoordinates in autosummaries and diffs [17:50:45] great [17:50:46] they already are in diffs [17:50:51] due to backport [17:51:02] they should be both places now [17:51:27] i don't think there is sorting of statements yet but need to check [18:14:35] 3 PHP Catchable fatal error: Argument 2 passed to Wikibase\Api\ItemByTitleHelper::getEntityIds() must be an array, null given, called in /usr/local/apache/common [18:14:35] -local/php-1.22wmf16/extensions/Wikibase/repo/includes/api/GetEntities.php on line 72 and defined in /usr/local/apache/common-local/php-1.22wmf16/extensions/Wikibase/re [18:14:35] po/includes/api/ItemByTitleHelper.php on line 64 [18:15:33] aude: ^ [18:15:48] Reedy: https://gerrit.wikimedia.org/r/83416 [18:19:44] Reedy: that's on test wikidata i assume? [18:19:52] I didn't look [18:19:59] is it rare? [18:34:14] Lydia_WMDE_: Damn, Commons vs. Wikidata topic is really spread over multiple locations :S [18:35:52] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Generic#Topic_main_category <- time to deprecate "Commons category" :-) [19:14:18] shimgray: ping [19:15:47] pong. I saw your comment, but I can't read lua :-) [19:16:11] (03PS1) 10Daniel Kinzler: Set GUID in Claims used in tests. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83439 [19:17:17] heheh ok [19:17:29] (03PS1) 10Daniel Kinzler: Make Claims handle GUIDs case-insensitive. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83440 [19:17:38] well i was wondering what you thought of the MBID being twice as long as all the other ids? [19:18:00] hmm. longer than ISNI/ORCID? [19:18:03] that's 20 chars [19:18:17] "e9fb8bad-ec0e-4cf1-aa82-a7e04a34b278" [19:18:27] 36 [19:18:30] yeek [19:18:52] I think we'll get resistance to that appearing on articles! [19:18:59] (03PS2) 10Daniel Kinzler: Set GUID in Claims used in tests. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83439 [19:19:54] well i think thats going to be a problem going forward [19:20:07] the more data you try and store uniquely, the longer IDs you need to have [19:20:30] why does the ID have to show in articles, though [19:21:44] DanielK_WMDE: i suppose it doesnt. https://en.wikipedia.org/wiki/Winston_churchill#External_links is how it looks right now (scroll a bit for "Authority control") [19:21:45] DanielK_WMDE: Yeah! Commons! [19:31:42] if we cover them, it begins to start shifting into "autogenerated external links". which I'm not actually opposed to, if relevant. hmm. but that's a different debate. [19:32:58] Well for now i'll just have it display the full id, and we'll see who complains [19:33:16] worst case, we can just abbreviate the id with some thing like "e9fb8bad..." [19:56:54] legoktm: the image is available at Commons.. It is NOT the same as the article [19:57:03] :< [19:57:12] * legoktm is ignoring everyone else [19:57:46] anyway, I responded to the process of speedy deletion [20:57:24] (03CR) 10Daniel Kinzler: "Why do we need separate Lua libraries for client and repo? the client extension can be run on the same wiki as the repo extension, includi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 (owner: 10Tpt) [21:06:50] (03CR) 10Hoo man: "Can't we move the Lua API into lib? That sounds more straightforward than installing client on the repo and might be easier." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 (owner: 10Tpt) [21:13:54] (03CR) 10Tpt: "My current implementation (patch set 5) moves the Lua API (mw.wikibase.lua) to the lib and let remains on the client and repo components t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 (owner: 10Tpt)