[00:26:11] legoktm: Yay. [00:26:15] legoktm: Thanks for fixing that report. [00:26:22] :) [04:11:24] Who's running data importing bots other than Bene* ? [04:12:08] lego [04:12:37] legoktm: you still awake? [04:15:04] probably yes but AFK [05:30:57] (03CR) 10Jeroen De Dauw: [C: 032] Set GUID in Claims used in tests. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83439 (owner: 10Daniel Kinzler) [05:34:31] (03CR) 10Jeroen De Dauw: [C: 04-2] "ItemId and PropertyId are case insensitive. Thus q1 and Q1 are the same. Nothing specifies that claim GUIDs are case insensitive. Unless t" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83440 (owner: 10Daniel Kinzler) [05:58:42] legoktm: you back? [06:05:18] still away and now probably asleep [06:27:54] good moaning [08:25:02] (03PS6) 10Henning Snater: toolbarcontroller: Detach event handlers before re-attaching. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79776 [08:26:03] (03PS7) 10Henning Snater: toolbarcontroller: Detach event handlers before re-attaching. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79776 [08:30:56] (03PS2) 10Jeroen De Dauw: Move ALL of the files [DNM, NDY] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83415 [08:31:03] (03CR) 10jenkins-bot: [V: 04-1] Move ALL of the files [DNM, NDY] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83415 (owner: 10Jeroen De Dauw) [08:44:45] (03PS3) 10Jeroen De Dauw: Move ALL of the files [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83415 [08:50:29] consider all of the files moved [08:55:29] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#52 (master - 38c5970 : jeroendedauw): The build was broken. [08:55:29] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/2acfd9d6a2fe...38c5970bd02c [08:55:29] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/11185815 [09:15:31] aude: wouldn't it be nice if the badges element of the array was only added if there were actually badges? [09:16:27] sure :) [09:17:31] mhhhm [09:17:41] ill poke lazowick when he gets here :P [09:25:11] (03PS14) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [09:25:18] https://www.wikidata.org/wiki/Wikidata:Project_chat#Error_messages_when_moving_links_from_one_item_to_another [09:25:21] and .... [09:25:37] https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Page_not_rendering [09:27:49] https://www.wikidata.org/wiki/Special:Export/Q14874453 [09:30:11] yep, bot-created items look the same as that one [09:30:29] with the old sitelink structure? [09:30:41] yes [09:31:08] https://www.wikidata.org/wiki/Special:Export/Q14874430 [09:38:13] (03PS8) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [09:38:39] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 (owner: 10Tobias Gritschacher) [09:38:46] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 (owner: 10Tobias Gritschacher) [09:42:46] (03PS1) 10Jeroen De Dauw: Match renaming and interface splits in WikibaseDatabase [DNM] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83621 [09:47:49] Abraham_WMDE: https://github.com/watching [09:47:57] That has a checkbox to get rid of all the stupid notifications [09:49:14] JeroenDeDauw: yea! thx [09:59:19] (03CR) 10Tobias Gritschacher: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 (owner: 10Tobias Gritschacher) [10:00:18] JeroenDeDauw: what name for the claim class did we end up sticking with? [10:00:22] ClaimIsGuidPair? O_o [10:00:31] *id [10:06:00] (03PS9) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [10:07:07] (03PS1) 10Tobias Gritschacher: Add additional class to aliases add button [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83623 [10:09:21] ExternalClaimId! [10:11:09] (03CR) 10Henning Snater: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83623 (owner: 10Tobias Gritschacher) [10:11:59] (03PS10) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [10:14:24] (03PS2) 10Tobias Gritschacher: Add additional class to aliases add button [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83623 [10:14:37] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83623 (owner: 10Tobias Gritschacher) [10:16:10] (03CR) 10Henning Snater: [C: 032] Add additional class to aliases add button [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83623 (owner: 10Tobias Gritschacher) [10:17:41] (03PS2) 10Addshore: Implement ExternalClaimId class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [10:18:43] (03PS3) 10Addshore: Implement ExternalClaimId class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [10:19:31] (03PS1) 10Jeroen De Dauw: Fixes to prefixing code [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83624 [10:19:52] (03PS2) 10Jeroen De Dauw: Match renaming and interface splits in WikibaseDatabase [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83621 [10:20:28] (03PS3) 10Jeroen De Dauw: Match renaming and interface splits in WikibaseDatabase [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83621 [10:21:31] (03PS1) 10Aude: add forward compatibility for retrieving item site links [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83625 [10:22:01] DanielK_WMDE: addshore Tobi_WMDE https://gerrit.wikimedia.org/r/#/c/83625/ [10:22:20] i'd like that in the old branch [10:22:46] running the change dispatcher with old client and new repo, i see a similar error as mentioned on project chat [10:22:51] this would take care of it [10:23:09] did anyone else see such error in dispatcher? [10:23:55] (03CR) 10Addshore: [C: 032] Fixes to prefixing code [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83624 (owner: 10Jeroen De Dauw) [10:23:59] (03Merged) 10jenkins-bot: Fixes to prefixing code [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83624 (owner: 10Jeroen De Dauw) [10:29:04] (03CR) 10Addshore: [C: 032] Match renaming and interface splits in WikibaseDatabase [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83621 (owner: 10Jeroen De Dauw) [10:29:15] (03Merged) 10jenkins-bot: Match renaming and interface splits in WikibaseDatabase [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/83621 (owner: 10Jeroen De Dauw) [10:29:21] (03CR) 10Addshore: [C: 032] fix covers tag [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83617 (owner: 10Jeroen De Dauw) [10:29:41] (03CR) 10Addshore: [C: 032] Fix file name [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83616 (owner: 10Jeroen De Dauw) [10:34:34] (03PS2) 10Daniel Kinzler: (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 [10:46:52] DanielK_WMDE: when will that uppercase change be live? [10:47:40] liangent: tonight, if all goes well [10:51:12] DanielK_WMDE: I think I'd prefer to change everything to uppercase in my code, which is easier, rather than make them compatible with both format [10:51:26] at the exact deployment time [10:51:58] liangent: i can't give you an exact time, it depends on when reedy is awake and gets around to it. [10:52:06] unless you'll revert the deployment at some point, which would be annoying [10:52:10] stick around here and watch for reedy [10:56:10] (03PS4) 10Addshore: Implement ExternalClaimId class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [10:56:18] DanielK_WMDE: JeroenDeDauw ^^ [10:56:50] addshore: "add an option "lowercaseids" to all API modules just seems silly :/" not really, it might be possible to add lowercaseids to some global request params [10:56:58] and avoid fixing case everywhere [10:57:17] to some global request params? [10:57:51] for example, I have a function request( params ) { } [10:58:02] I can simply params['lowercaseids'] = '' in it [10:58:30] and ignore warning from irrelevant modules [10:58:33] indeed, but its probably no more effort than removing the dependency on lowercase ids :P [11:00:02] addshore: changing every occurrence of lowercase ids to uppercase ones is labor work, which many people dislike [11:01:16] so is adding params['lowercaseids'] = '', and if we did add a lowercaseids param to the api I don't see it staying forever, it would more than likely be marked as deprecated instantly (or in my opinion it should be) as the scripts at the end of the day do need to change [11:02:02] addshore: not all scripts will run forever [11:02:53] for example, I have / will create some scripts importing data from some datasources, and it takes one year to import every datasource [11:03:07] then if the param lives for longer than one year, it's enough [11:03:21] as long as I write no more scripts depending on lowercase ida [11:03:22] *ids [11:03:57] your can read that "one year" as "one month" or something [11:04:30] what cases are there that people depend on lowercase ids currently? [11:04:32] those importing scripts must be very task-specific, so it's not surprised to see many hardcoded pXXX or qXXX in them [11:04:42] addshore: for me, mapping keys [11:04:45] liangent: doing this for every API modules we have is sadly a pretty big and messy task :/ [11:05:09] liangent: it cant be that hard to change the p to a P ? [11:05:22] liangent: as far as I can see, only hardcoded ids are problematic. [11:05:31] DanielK_WMDE: right [11:06:01] I used a regular expression earlier to fix a documentation page with lots of IDs :) [11:06:21] shouldn't be hard to find & replace literals of the form p\d+ with P$1 [11:06:29] p(\d+) [11:06:44] addshore: changing is easy; making sure everything is changed before they break is not that easy [11:27:30] (03PS1) 10Aude: fix compatibility with site link badge structure [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83626 [11:27:51] (03CR) 10jenkins-bot: [V: 04-1] fix compatibility with site link badge structure [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83626 (owner: 10Aude) [11:30:17] (03PS11) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [11:31:34] addshore: y u name it ExternalClaimId ? :<0 [11:31:37] ;p [11:31:45] >.< [11:32:03] I asked hours ago what it should be called again, noone replied to I scrolled back and thats the last name I found :P [11:32:12] suggested by you actually x [11:32:14] xD [11:37:09] (03CR) 10Jeroen De Dauw: [C: 04-1] "(4 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [11:37:36] * JeroenDeDauw hides from addshore behind monitor wall [11:40:57] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#53 (master - e42b3f8 : jeroendedauw): The build is still failing. [11:40:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/38c5970bd02c...e42b3f84bede [11:40:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/11188564 [11:46:06] hi [11:47:27] (03CR) 10Henning Snater: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 (owner: 10Henning Snater) [11:58:58] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#54 (master - a14c249 : Addshore): The build was fixed. [11:58:58] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/e42b3f84bede...a14c24908f80 [11:58:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/11188709 [11:59:09] Hi Astur [12:01:57] (03PS15) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [12:08:16] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#55 (master - 23bb2d9 : Addshore): The build was fixed. [12:08:16] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/a14c24908f80...23bb2d990b17 [12:08:16] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/11188731 [12:11:29] addshore: meeergeee https://gerrit.wikimedia.org/r/#/c/83408/ [12:12:08] (03PS1) 10Jeroen De Dauw: Match changes in Wikibase QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83629 [12:13:16] addshore: your commit got that -1 from me at 13:37? ;p [12:16:23] (03PS12) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [12:17:21] que tais echando un pitu? [12:20:21] hm, what happend to http://wikidata.beta.wmflabs.org/ ? [12:21:29] Tobi_WMDE: labs is having some issues currently [12:21:54] addshore: ok, so nothig new [12:21:59] :D [12:25:44] (03PS1) 10Tobias Gritschacher: Add more tags to cucumber tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83630 [12:33:46] (03PS8) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [12:39:40] (03PS7) 10Henning Snater: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 [12:39:41] (03PS7) 10Henning Snater: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 [12:39:42] (03PS5) 10Henning Snater: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 [12:39:43] (03PS4) 10Henning Snater: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 [12:48:36] JeroenDeDauw: PS5 >> https://gerrit.wikimedia.org/r/#/c/83400/ [12:48:52] silly grrrit-wm stopped spamming :< [14:11:14] Danwe_WMDE: y u no https://www.mediawiki.org/wiki/Wikibase/Coding_conventions ? ;p [14:11:59] JeroenDeDauw: one day [14:14:56] addshore: well, that is fine now [14:15:00] except the style issues :D [14:15:05] ...... [14:15:25] oh well... :P [14:15:27] addshore: [14:15:33] can merge if you do follow up ;p [14:15:42] what style issues? [14:15:45] just comment and ill fix them [14:26:34] addshore: I had already commented [14:26:42] silly grrrit-wm [14:26:48] perhaps I broke it [14:27:10] * JeroenDeDauw kicks grrrit-wm [14:27:20] mhh, the old bot kicked back [14:43:50] JeroenDeDauw: why we have no interface for parsers? [14:53:58] JeroenDeDauw: again >> https://gerrit.wikimedia.org/r/#/c/83400 [14:56:02] cdfsfsddsa [14:56:06] dsklafjdklsf;sdljf [14:56:15] adsk;lfjdsaf [14:56:15] ads [14:56:15] dfs [14:56:15] fds [14:56:16] afd [14:56:16] fads [14:56:16] fs [14:56:16] fas [14:56:17] fads [14:56:17] dfs [14:56:18] af [14:56:18] df [14:56:19] d [14:56:19] d [14:56:20] d [14:56:20] d [14:56:25] cat! [14:56:39] cats! [14:57:12] !cat is https://www.youtube.com/watch?v=QH2-TGUlwu4 [14:57:13] Key was added [14:57:15] :) [14:57:20] heh [14:58:14] addshore: what is this interface good for? [14:58:46] addshore: I do not see how it adds any value [14:58:46] well, otherwise i can not typehint where you want me to typehint :P [15:01:22] addshore: ah, indeed [15:01:33] I thought there already was something to type hint against an entity id parser [15:01:35] apparently not [15:01:40] ill do a followup to implement the interface in other places :P [15:01:40] And this is indeed needed [15:01:45] ie. other parsers.. [15:08:26] im a daniel [15:08:34] that after a year can still not lock his screen [15:42:45] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/83640/ and https://gerrit.wikimedia.org/r/#/c/83641/ [15:47:08] JeroenDeDauw: REEEVIEW!!!!!eleven https://gerrit.wikimedia.org/r/#/c/82400/ [15:47:21] there's a few discussion points open, but i think i adressed most of your comments [15:47:42] try diffing PS 5 vs PS 7 [16:13:56] (03PS4) 10Henning Snater: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 [16:13:57] (03PS5) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 [16:14:00] (03PS5) 10Addshore: Implement ClaimGuid and Parser class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [16:14:06] (03PS1) 10Tobias Gritschacher: Split up test`scenarios for label and description tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83632 [16:14:08] (03PS6) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 [16:14:09] (03PS2) 10Tobias Gritschacher: Split up test`scenarios for label and description tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83632 [16:14:12] (03PS3) 10Tobias Gritschacher: Split up test`scenarios for label and description tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83632 [16:14:19] grrrit-wm is back!!! :P [16:14:24] (03PS13) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [16:14:25] (03PS1) 10Tobias Gritschacher: Make wait-for-request method more robust in selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83634 [16:14:26] (03CR) 10Tobias Gritschacher: [V: 032] Make wait-for-request method more robust in selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83634 (owner: 10Tobias Gritschacher) [16:14:27] (03CR) 10Tobias Gritschacher: [C: 032] Make wait-for-request method more robust in selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83634 (owner: 10Tobias Gritschacher) [16:14:28] (03Merged) 10jenkins-bot: Make wait-for-request method more robust in selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83634 (owner: 10Tobias Gritschacher) [16:14:29] (03CR) 10Jeroen De Dauw: [C: 04-1] "(6 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [16:14:31] JeroenDeDauw: ^^ :D [16:14:32] (03PS14) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [16:14:43] (03PS1) 10Aude: ensure correct navigation ids in client for all site groups [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83636 [16:14:46] (03PS6) 10Addshore: Implement ClaimGuid and Parser class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 [16:14:47] (03CR) 10Aude: [C: 04-1] "strtolower is also needed in Wikibase.hooks in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 (owner: 10Daniel Kinzler) [16:14:48] (03PS1) 10Daniel Kinzler: Allow serializers to use upper and/or lower case ids, as needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83638 [16:14:49] (03CR) 10Jeroen De Dauw: [C: 032] Implement ClaimGuid and Parser class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83400 (owner: 10Addshore) [16:14:50] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83638 (owner: 10Daniel Kinzler) [16:14:51] (03PS1) 10Jeroen De Dauw: Added TableDeletionFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83639 [16:14:54] (03PS1) 10Jeroen De Dauw: Update docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83642 [16:14:55] (03CR) 10Jeroen De Dauw: [C: 032] Update docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83642 (owner: 10Jeroen De Dauw) [16:14:57] (03PD3) 10Addshore: Implement EntityIdParser as an Interface [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83640 [16:14:58] (03PD2) 10Addshore: Match changes in DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83641 [16:15:00] (03PS1) 10Jeroen De Dauw: Fix documentation [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83644 [16:15:01] (03CR) 10Jeroen De Dauw: [C: 032] Fix documentation [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83644 (owner: 10Jeroen De Dauw) [16:15:02] (03PS1) 10Jeroen De Dauw: SimpleTableSchemaUpdater [DNM] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83645 [16:15:03] (03PS1) 10Daniel Werner: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 [16:15:04] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83638 (owner: 10Daniel Kinzler) [16:15:05] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [16:15:07] (03PS1) 10Daniel Werner: Follows Core change Ib7a8a8f, implements EntityContent::getActualContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83648 [16:15:09] (03PS1) 10Jeroen De Dauw: Improve FieldDefinitionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83650 [16:15:10] (03PS1) 10Jeroen De Dauw: Update TravisCi config to not mess up coverage report [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83652 [16:15:12] (03CR) 10Jeroen De Dauw: [C: 032] Update TravisCi config to not mess up coverage report [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83652 (owner: 10Jeroen De Dauw) [16:15:13] (03CR) 10Jeroen De Dauw: Allow serializers to use upper and/or lower case ids, as needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83638 (owner: 10Daniel Kinzler) [16:15:14] (03PS2) 10Jeroen De Dauw: SimpleTableSchemaUpdater [DNM] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83645 [16:15:16] (03PS3) 10Daniel Kinzler: Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 [16:21:08] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83640 (owner: 10Addshore) [16:21:27] JeroenDeDauw: bah, gerrit ate my update. review PS 6, PS 7 is crap, it actually reverts PS 6. [16:27:03] (03PS8) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [16:27:35] (03CR) 10Daniel Kinzler: "PS 8 reverts PS 7, restoring PS 6." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [16:27:49] (03PS9) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [16:30:54] (03CR) 10Jeroen De Dauw: [C: 032] Implement EntityIdParser as an Interface [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83640 (owner: 10Addshore) [16:30:57] (03PS3) 10Jeroen De Dauw: Match changes in DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83641 (owner: 10Addshore) [16:31:08] addshore: can you follow up to https://gerrit.wikimedia.org/r/#/c/83640/ comments? [16:31:26] DanielK_WMDE: lmk when the stuff is unfucked [16:33:24] JeroenDeDauw: will do [16:34:40] (03PS2) 10Daniel Werner: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 [16:35:03] (03CR) 10Jeroen De Dauw: [C: 032] Match changes in DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83641 (owner: 10Addshore) [16:35:10] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [16:36:24] Danwe_WMDE: easy review is ewasy https://gerrit.wikimedia.org/r/#/c/83650/ [16:37:01] (03PS1) 10Addshore: Followup tidyup of EntityIdParser [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83654 [16:37:15] JeroenDeDauw: ^^ :) [16:37:19] what is THAT ^ ? [16:37:20] yay grrrrit is back [16:37:22] (03PS5) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 [16:37:23] (03PS6) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 [16:37:24] (03PS8) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [16:37:33] (03PS3) 10Daniel Werner: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 [16:37:35] (03CR) 10jenkins-bot: [V: 04-1] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler) [16:37:41] addshore: right, I though someone run a bot submitting changes... [16:37:42] JeroenDeDauw: unfucking stuff complete. [16:37:43] (03CR) 10jenkins-bot: [V: 04-1] (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 (owner: 10Daniel Kinzler) [16:37:47] or not. [16:37:50] whut? [16:37:51] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [16:38:07] :O [16:38:44] DanielK_WMDE: I guess you need to rebase on https://gerrit.wikimedia.org/r/#/c/83641/ or above now [16:38:58] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/82400/9 should be fine for review. you can diff PS 5 against PS 8, PS 9 is a rebase. [16:39:10] JeroenDeDauw: the follow-ups seems to be screwed still [16:39:28] addshore: i did [16:39:34] ahh :/ [16:39:47] actually... maybe not :) [16:40:00] could be i missed that. let me check. [16:40:01] heh 00:00:02.293 Errors parsing lib/includes/formatters/WikibaseSnakFormatterBuilders.php [16:40:07] o_O [16:40:11] the tests didnt even get around to running ;p [16:40:16] go fix your syntax error? ;p [16:40:17] merge artifact?? [16:40:22] (03CR) 10Daniel Werner: [C: 032] Improve FieldDefinitionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83650 (owner: 10Jeroen De Dauw) [16:40:23] something :P [16:40:34] PHP Parse error: syntax error, unexpected '*', expecting T_FUNCTION in lib/includes/formatters/WikibaseSnakFormatterBuilders.php on line [16:40:51] yea, will check it out in a minute [16:41:02] let me rebase the very first change again [16:41:13] Soooooooooooooooooooooooooooo [16:41:18] guh. that fails. again. whut?? [16:41:19] morning Reedy ;p [16:41:22] * aude waves [16:41:31] hey Reedy [16:42:27] so, we have a few backports going into our branches [16:42:34] and then should be ready [16:46:58] (03CR) 10Daniel Kinzler: [C: 032] "I don't want to have this on master :)" [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83636 (owner: 10Aude) [16:47:05] * aude neither :) [16:47:20] (03CR) 10jenkins-bot: [V: 04-1] ensure correct navigation ids in client for all site groups [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83636 (owner: 10Aude) [16:47:20] Awesome [16:47:30] I've an excuse to take my laptop with me [16:47:34] heh [16:47:44] ok, what's jenkins complaiing about [16:49:27] (03CR) 10Daniel Kinzler: [C: 032] fix compatibility with site link badge structure [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83626 (owner: 10Aude) [16:49:45] (03CR) 10Jeroen De Dauw: [C: 032] Followup tidyup of EntityIdParser [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83654 (owner: 10Addshore) [16:49:49] (03CR) 10jenkins-bot: [V: 04-1] fix compatibility with site link badge structure [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83626 (owner: 10Aude) [16:53:36] (03CR) 10Daniel Kinzler: [C: 032] add forward compatibility for retrieving item site links [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83625 (owner: 10Aude) [16:53:47] (03Merged) 10jenkins-bot: add forward compatibility for retrieving item site links [extensions/WikibaseDataModel] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83625 (owner: 10Aude) [17:02:26] (03CR) 10Aude: [C: 032] Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 (owner: 10Daniel Kinzler) [17:03:54] (03Merged) 10jenkins-bot: Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83413 (owner: 10Daniel Kinzler) [17:04:45] (03PS1) 10Aude: Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83659 [17:05:09] (03CR) 10jenkins-bot: [V: 04-1] Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83659 (owner: 10Aude) [17:05:16] * aude stabs jenkins [17:08:58] (03CR) 10Aude: [C: 032 V: 032] Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83659 (owner: 10Aude) [17:09:18] (03CR) 10jenkins-bot: [V: 04-1] Force entity IDs to be lower case in wb_changes. [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83659 (owner: 10Aude) [17:10:01] (03CR) 10Daniel Kinzler: [V: 032] ensure correct navigation ids in client for all site groups [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83636 (owner: 10Aude) [17:10:42] Abraham_WMDE: https://packagist.org/packages/scrutinizer/php-analyzer < recommended by the PHPUnit guy [17:10:58] Abraham_WMDE: apparently written by these guys https://scrutinizer-ci.com/ [17:11:12] Which looks like a very interesting service :) [17:11:26] JeroenDeDauw: thx [17:11:29] JeroenDeDauw: indeed [17:11:33] if we can get hosted reporting from all the standard PHP analysis tools... so much win [17:11:41] https://scrutinizer-ci.com/docs/tools/php/ [17:12:10] that would be cool indeed [17:12:41] JeroenDeDauw: the only thing which is a bit strange, that service seems to be an one man show: https://scrutinizer-ci.com/legal-notice [17:12:58] JeroenDeDauw: but if the tool is doing a good job I'm fine with that :) [17:15:28] (03CR) 10Daniel Kinzler: [V: 032] fix compatibility with site link badge structure [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/83626 (owner: 10Aude) [17:16:22] Abraham_WMDE: oh noez - its an evil german dude! [17:16:27] https://en.wikipedia.org/wiki/Module:Wikidata [17:16:33] https://en.wikipedia.org/wiki/Module:WikidataCheck [17:16:46] i know the check one is used and the other likely also [17:17:05] the check one does "{{WikidataCheck|property=p343|value={{{id|{{{1|}}}}}}|category=MusicBrainz artist id|namespaces=0}}" [17:17:07] 10[1] 04https://www.wikidata.org/wiki/Template:WikidataCheck [17:17:08] as an example [17:17:13] * aude kicks the bot [17:17:17] Oook [17:19:22] we can just wrap everything in {{uc:}} i guess. [17:19:24] 10[2] 04https://www.wikidata.org/wiki/Template:uc: [17:22:36] heh [17:23:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#774 (mw1.22-wmf16 - 25ce1bc : daniel): The build was broken. [17:23:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/605c15ff9f7f...25ce1bc152cd [17:23:05] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11204215 [17:24:10] o_0 [17:24:18] hm, what's the best way to phrase "Please translate this into X"? [17:25:15] YairRand: sounds good to me [17:25:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#775 (mw1.22-wmf16 - 08691d1 : Daniel Kinzler): The build was broken. [17:25:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/25ce1bc152cd...08691d134219 [17:25:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11204233 [17:26:14] okay, what's the best way to phrase it if probably most people reading it won't actually be able to translate it? [17:27:00] context? [17:28:10] I'm making a template, roughly equivalent to LangSwitch, except it can work without English being filled in, and when the user's language isn't available, it displays all translations, together with an invitation to translate [17:28:30] hmmmm [17:28:59] I'm thinking it could be useful on the property proposals pages and such [17:29:20] I think "please translate this into x" is okay [17:29:27] if most people can't, they won't [17:29:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#776 (mw1.22-wmf14 - 1b4d7b2 : aude): The build has errored. [17:29:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c1e96d366a5e...1b4d7b2ac3a4 [17:29:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11204481 [17:29:32] but it's inviting [17:29:33] okay, I'll go with that [17:29:53] anything more is too wordy, in my opinion [17:31:21] TRANSLATE IT [17:33:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#776 (mw1.22-wmf14 - 1b4d7b2 : aude): The build has errored. [17:33:11] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c1e96d366a5e...1b4d7b2ac3a4 [17:33:11] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11204481 [17:33:27] +1 on Reedy :D [17:33:43] Reedy: Or simply TRANSLATE!!!! [17:33:48] JFDI [17:33:56] NAO [17:33:56] BLOODY TRANSLATE IT! [17:33:58] ! [17:34:11] how inviting [17:34:14] Reedy say 'TRANSLATE OR DIE!' :D [17:34:18] *says [17:34:23] :D [17:34:43] YairRand: Translate or die is the most inviting ofc! :p [17:34:49] :) [17:39:02] anyone here know how to do translation admin stuff? [17:39:37] YairRand: What do you need? [17:39:43] [[Template:Help translate/text/en]] [17:39:44] 10[3] 10https://www.wikidata.org/wiki/Template:Help_translate/text/en [17:40:04] aude: hey :) finally at home \o/ [17:40:09] should be translatable through the normal Translate stuff [17:40:14] can you give me a shortstatus update aude? [17:40:19] Alright. [17:41:02] (03CR) 10Aude: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:42:10] JohnLewis: Hm, I'm not sure that worked the way it was supposed to... [17:42:51] Lydia_WMDE_: we are verifying that lua will still work [17:42:58] then can deploy [17:42:58] ok [17:43:03] what's going to be in? [17:43:09] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:43:13] maybe an hour [17:43:24] however long we need, but shouldn't be too long [17:43:34] take your time - just arrived ;-) [17:43:38] ok [17:43:43] how was scotland? [17:43:47] awesome [17:44:01] we shall open UK wikidata office :) [17:44:01] met up with kde friends there and had a really good time [17:44:05] hehe [17:44:09] Lydia_WMDE_: URLs, Badges, and a breaking change to the API :) [17:44:17] badges!? [17:44:19] for real? [17:44:24] rschen7754|away: no UI for them yet [17:44:27]