[08:20:17] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [V: 04-1] "needs rebase, but I have no clue where all the conflicts come from.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler)
[08:39:42] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "(6 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82451 (owner: 10Legoktm)
[09:01:50] <DanielK_WMDE>	 Tobi_WMDE: anyone around for the daily?
[09:07:15] <aude>	 we are here
[09:07:17] <aude>	 small grou
[09:07:18] <aude>	 p
[09:07:29] <aude>	 DanielK_WMDE: ^
[09:07:34] <aude>	 probably fine if you email us
[09:09:00] <DanielK_WMDE>	 no hangout then?
[09:09:01] <DanielK_WMDE>	 ok
[09:10:03] <aude>	 no one here to set it up
[09:10:27] * aude  not good with such technology :)

[09:10:42] <Tobi_WMDE>	 DanielK_WMDE: uups
[09:10:44] <Tobi_WMDE>	 :)
[09:11:11] <grrrit-wm>	 (03PS21) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 
[09:11:24] <addshore>	 DanielK_WMDE: ^^ (if you have any further suggestions to make it more readable im all ears :))
[09:11:39] <grrrit-wm>	 (03PS1) 10Addshore: Make removeClaimsEntityId check case insenstive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84298 
[09:12:57] <grrrit-wm>	 (03PS2) 10Aude: allow longitude coordinates up to 360 in JS globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 
[09:14:34] <Tobi_WMDE>	 DanielK_WMDE: tried to rebase your formatter patches (after the first one got in) and there are tons of merge conflicts..
[09:14:39] <aude>	 Tobi_WMDE: Henning_WMDE can someone please review https://gerrit.wikimedia.org/r/#/c/84117/ :)
[09:14:47] <Tobi_WMDE>	 but I have no clue where they come from
[09:14:52] <aude>	 if there are no issues, that needs to be backported
[09:15:31] <aude>	 if i am doing something wrong int he patch, please say :)
[09:16:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make removeClaimsEntityId check case insenstive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84298 (owner: 10Addshore)
[09:16:51] <aude>	 right now it's not possible to view coordinates with null precision, e.g. https://www.wikidata.org/wiki/Q30645
[09:16:56] <aude>	 unless you disable js
[09:17:10] <aude>	 it affects a largish number of items
[09:19:51] <grrrit-wm>	 (03PS8) 10Tobias Gritschacher: toolbarcontroller: Detach event handlers before re-attaching. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79776 (owner: 10Henning Snater)
[09:26:42] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] toolbarcontroller: Detach event handlers before re-attaching. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79776 (owner: 10Henning Snater)
[09:28:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: toolbarcontroller: Detach event handlers before re-attaching. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79776 (owner: 10Henning Snater)
[09:29:13] <DanielK_WMDE>	 Tobi_WMDE: yea, i'll look into that once i'm finishing with factoring out the SummaryFormatter
[09:32:22] <grrrit-wm>	 (03PS3) 10Aude: handle globe option in GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84200 
[09:32:49] <grrrit-wm>	 (03PS5) 10Tobias Gritschacher: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 (owner: 10Henning Snater)
[09:32:50] <grrrit-wm>	 (03PS7) 10Tobias Gritschacher: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[09:32:51] <grrrit-wm>	 (03PS6) 10Tobias Gritschacher: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 (owner: 10Henning Snater)
[09:32:52] <grrrit-wm>	 (03PS5) 10Tobias Gritschacher: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 (owner: 10Henning Snater)
[09:32:53] <aude>	 :)
[09:32:53] <grrrit-wm>	 (03PS8) 10Tobias Gritschacher: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 (owner: 10Henning Snater)
[09:32:54] <grrrit-wm>	 (03PS8) 10Tobias Gritschacher: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 (owner: 10Henning Snater)
[09:32:55] <grrrit-wm>	 (03PS16) 10Tobias Gritschacher: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 (owner: 10Henning Snater)
[09:32:57] <grrrit-wm>	 (03PS9) 10Tobias Gritschacher: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 (owner: 10Henning Snater)
[09:32:57] <addshore>	 eww
[09:33:05] <aude>	 merge all the changes!
[09:38:01] <grrrit-wm>	 (03PS2) 10Addshore: Make removeClaimsEntityId check case insenstive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84298 
[09:38:06] <addshore>	 aude Lydia_WMDE_ ^^
[09:38:18] <Lydia_WMDE_>	 \o/
[09:38:52] <aude>	 thanks!
[09:39:51] <addshore>	 DanielK_WMDE: JeroenDeDauw did you have any further comments re https://gerrit.wikimedia.org/r/#/c/82237/ ?
[09:41:22] <grrrit-wm>	 (03PS9) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 
[09:41:34] <grrrit-wm>	 (03CR) 10Addshore: "PS9 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore)
[09:43:10] <grrrit-wm>	 (03PS10) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 
[09:54:14] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Update gitignore [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84299 
[09:55:22] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Use camelCase for method name [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84301 
[09:57:39] <grrrit-wm>	 (03PD1) 10Addshore: Split ChangeOp into interface and base class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84300 
[10:15:14] <grrrit-wm>	 (03PS1) 10Addshore: Use ClaimGuidParser instead of deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84302 
[10:15:44] <legoktm>	 hmm
[10:15:52] <addshore>	 legoktm: ? :P
[10:15:54] <legoktm>	 is wgContentHandlerUseDB set to false on testwikidatawiki?
[10:16:23] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore)
[10:17:13] <aude>	 legoktm: hmmm
[10:17:40] <legoktm>	 aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=54114#c2
[10:17:52] <grrrit-wm>	 (03CR) 10Addshore: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore)
[10:18:42] <addshore>	 legoktm: it is indeed set to false
[10:18:48] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Update gitignore [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84299 (owner: 10Jeroen De Dauw)
[10:18:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update gitignore [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84299 (owner: 10Jeroen De Dauw)
[10:18:59] <legoktm>	 addshore: yeah. it probably should be true
[10:19:03] <addshore>	 wikidata is the only site where it is true :P
[10:19:19] <aude>	 i think it is true
[10:19:30] <aude>	 wikidata = wikidata family
[10:19:45] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Use camelCase for method name [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84301 (owner: 10Jeroen De Dauw)
[10:19:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use camelCase for method name [extensions/Diff] - 10https://gerrit.wikimedia.org/r/84301 (owner: 10Jeroen De Dauw)
[10:20:47] <legoktm>	 idk :P
[10:21:00] <legoktm>	 right, it would be just wikidatawiki
[10:21:03] <aude>	 looks true to me
[10:21:20] <addshore>	 mhhm, confusing configs :d
[10:21:38] <aude>	 i don't know how the imported page got interpreted as wikitext, though
[10:21:59] <legoktm>	 er, you mean got interpreted as an item?
[10:22:22] <aude>	 legoktm: initially it got interpreted as an item
[10:22:30] <aude>	 then after editing with edit page, it became wikitext
[10:22:34] <legoktm>	 huh.
[10:22:52] <aude>	 it's confused about its identity :)
[10:23:20] <aude>	 probably a bunch of details to be considered when importing an item that are not done currently
[10:24:00] <aude>	 if i have an entity that has no properties, i'd think it should work
[10:31:15] <grrrit-wm>	 (03PS4) 10Addshore: Remove NewClaim dependancy on Lib [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 
[10:37:26] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 (owner: 10Jeroen De Dauw)
[10:37:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 (owner: 10Jeroen De Dauw)
[11:00:43] <grrrit-wm>	 (03PD1) 10Addshore: Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 
[11:14:28] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "will you still address DanielK's concerns?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore)
[11:25:00] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Make removeClaimsEntityId check case insenstive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84298 (owner: 10Addshore)
[11:26:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make removeClaimsEntityId check case insenstive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84298 (owner: 10Addshore)
[12:06:08] <grrrit-wm>	 (03PS17) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 
[12:06:16] <grrrit-wm>	 (03PS10) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 
[12:06:22] <grrrit-wm>	 (03PS9) 10Henning Snater: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 
[12:06:27] <grrrit-wm>	 (03PS9) 10Henning Snater: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 
[12:06:34] <grrrit-wm>	 (03PS7) 10Henning Snater: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 
[12:06:39] <grrrit-wm>	 (03PS6) 10Henning Snater: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 
[12:06:44] <grrrit-wm>	 (03PS6) 10Henning Snater: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 
[12:06:49] <grrrit-wm>	 (03PS8) 10Henning Snater: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 
[12:08:23] <grrrit-wm>	 (03CR) 10Addshore: "I tried my best with the last patchset, if anyone has any further suggestions I am all ears!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore)
[12:09:16] <Korail_school>	 I see some error.
[12:09:18] <Korail_school>	 https://www.wikidata.org/wiki/Q8070457
[12:09:34] <Korail_school>	 in here codinate property makes error what happended?
[12:09:42] <aude>	 Korail_school: it's a bug in the javascript
[12:09:58] <Korail_school>	 The value does not comply with the property's definition.
[12:09:59] <Korail_school>	 The value's data value type "ununserializable" does not match the property's data type's data value type "globecoordinate".
[12:10:01] <aude>	 we are workign on it
[12:10:01] <Korail_school>	 Is bug?
[12:10:04] <aude>	 working
[12:10:07] <aude>	 yes a bug
[12:10:18] <Korail_school>	 Thank You
[12:13:01] <JeroenDeDauw>	 addshore: I see evil code being removed and not much else, so +2 :D
[12:13:10] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Remove NewClaim dependancy on Lib [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore)
[12:13:12] <addshore>	 wherE? :P
[12:13:14] <addshore>	 xD
[12:13:29] <addshore>	 you have to do the 2 changesets in wikibase also JeroenDeDauw 
[12:13:45] <JeroenDeDauw>	 addshore: err, those have -2?
[12:13:47] <JeroenDeDauw>	 lolwat?
[12:14:23] * JeroenDeDauw  runs away and continues doing random holiday stuff, leaving master broken due to addshore

[12:14:24] <grrrit-wm>	 (03PS6) 10Addshore: Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 
[12:14:32] <aude>	 hah
[12:14:42] <Tobi_WMDE>	 pANIC!!
[12:14:52] <grrrit-wm>	 (03PS5) 10Jeroen De Dauw: remove Entity->newClaim from MainSnakChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore)
[12:15:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 (owner: 10Henning Snater)
[12:15:36] <JeroenDeDauw>	 addshore: https://gerrit.wikimedia.org/r/#/c/82233/6/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php
[12:15:39] <JeroenDeDauw>	 that will not work
[12:15:45] <JeroenDeDauw>	 $entity->newClaimBase
[12:15:50] <JeroenDeDauw>	 method no longer exists right?
[12:16:07] <addshore>	 need to rebase it with newclaim
[12:16:09] <JeroenDeDauw>	 addshore: going to revert the thing I merged as clearly the required follow ups are not ready to go
[12:16:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 (owner: 10Henning Snater)
[12:16:16] <aude>	 not like jenkins runs qunit tests....
[12:16:25] <JeroenDeDauw>	 addshore: ??
[12:16:26] <addshore>	 JeroenDeDauw: yes :P
[12:16:26] <aude>	 (would be nice)
[12:16:33] <aude>	 someone broke master :P
[12:16:57] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Revert "Remove NewClaim dependancy on Lib" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/84314 
[12:17:03] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Revert "Remove NewClaim dependancy on Lib" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/84314 (owner: 10Jeroen De Dauw)
[12:17:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[12:17:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[12:17:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Remove NewClaim dependancy on Lib" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/84314 (owner: 10Jeroen De Dauw)
[12:17:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] remove Entity->newClaim from MainSnakChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore)
[12:17:52] <JeroenDeDauw>	 addshore: do create a re-apply by reverting https://gerrit.wikimedia.org/r/#/c/84314/
[12:18:09] <addshore>	 I will :) in the middle of rebasing the other 2 patchsets now :P
[12:18:11] <aude>	 revert revert revert :)
[12:18:14] <grrrit-wm>	 (03PS7) 10Tobias Gritschacher: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 (owner: 10Henning Snater)
[12:18:21] * JeroenDeDauw  reverts aude

[12:18:24] <aude>	 :D
[12:21:27] <grrrit-wm>	 (03PS9) 10Tobias Gritschacher: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[12:21:36] <grrrit-wm>	 (03PS7) 10Tobias Gritschacher: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 (owner: 10Henning Snater)
[12:21:44] <grrrit-wm>	 (03PS10) 10Tobias Gritschacher: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[12:28:10] <grrrit-wm>	 (03PS5) 10Tobias Gritschacher: Use cucumber for sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83651 
[12:30:04] <grrrit-wm>	 (03PS7) 10Addshore: Switch use of entity->newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 
[12:30:34] <grrrit-wm>	 (03Abandoned) 10Addshore: remove Entity->newClaim from MainSnakChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore)
[12:31:15] <grrrit-wm>	 (03PS1) 10Addshore: Revert "Revert "Remove NewClaim dependancy on Lib"" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/84316 
[12:32:16] <grrrit-wm>	 (03PS8) 10Addshore: Switch use of entity->newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 
[12:36:48] <grrrit-wm>	 (03PS11) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 
[12:37:09] <DanielK_WMDE>	 Tobi_WMDE: fixed the merge conflicts ---^
[12:37:25] <grrrit-wm>	 (03PS8) 10Daniel Kinzler: (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 
[12:37:34] <grrrit-wm>	 (03PS7) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 
[12:40:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler)
[12:45:03] <addshore>	 JeroenDeDauw: thw two patchsets are ready now ;p
[12:45:12] <addshore>	 all tests pass with them both :)
[12:46:22] <addshore>	 and apparently neither of them depend on one another now.. :P
[12:46:49] <grrrit-wm>	 (03PS8) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 
[12:47:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler)
[12:47:35] <DanielK_WMDE>	 o_O
[12:47:54] <aude>	 that looks explainable
[12:48:09] <DanielK_WMDE>	 yea, but i just fixed that?!
[12:48:15] <aude>	 hmmm
[12:48:20] <DanielK_WMDE>	 either i missed a line, or forgot to add a file, or something
[12:49:15] <aude>	 DanielK_WMDE: for putting the entity in the parser output,putting the object seems okay but....
[12:49:35] <aude>	 i don't think it's a good idea, as the structure of the object itself is too instable
[12:49:45] <grrrit-wm>	 (03PS9) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 
[12:50:02] <aude>	 i think putting in serialized form, with more robust deserialization would be better
[12:50:14] <aude>	 thoughts? suggestions?
[12:50:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler)
[12:51:02] <liangent>	 is there some good util function to format an entity into a string for console debug output?
[12:51:08] <aude>	 or how to handle changes in the enityt structure?
[12:51:12] <DanielK_WMDE>	 aude: i guess your are right
[12:51:50] <aude>	 DanielK_WMDE: putting an object works,if things were more stable
[12:52:58] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 (owner: 10Henning Snater)
[12:54:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 (owner: 10Henning Snater)
[12:58:45] <grrrit-wm>	 (03PS2) 10Addshore: Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 
[12:58:46] <grrrit-wm>	 (03PS2) 10Addshore: Switch use of ClaimModHelper to EntityModHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 
[12:58:47] <grrrit-wm>	 (03PS1) 10Addshore: Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[13:00:03] <aude>	 EntityModhelper?
[13:00:19] <addshore>	 EntityModificationHelper :>#
[13:00:26] <aude>	 oh, okay
[13:03:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[13:04:01] <addshore>	 stupid error codes
[13:05:29] <grrrit-wm>	 (03PS2) 10Addshore: Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[13:08:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[13:11:03] <grrrit-wm>	 (03PS3) 10Addshore: Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[13:11:12] <JeroenDeDauw>	 EntityModificationHelper... it does something related to modifying entities? how nice! editEntity was feeling lonely
[13:12:00] <JeroenDeDauw>	 addshore: wait, is that a new class?
[13:12:33] <addshore>	 yes
[13:14:47] <JeroenDeDauw>	 :(
[13:14:57] <addshore>	 :<
[13:18:04] <DanielK_WMDE>	 Uh, wtf? 
[13:18:13] <DanielK_WMDE>	 RemoveClaimsTest is broken for me on master
[13:18:31] <DanielK_WMDE>	 1) Wikibase\Test\Api\RemoveClaimsTest::testValidRequests
[13:18:32] <DanielK_WMDE>	 Argument 1 passed to Wikibase\Api\ClaimModificationHelper::getEntityTitle() must be an instance of Wikibase\DataModel\Entity\EntityId, null given, called in /var/www/daniel/wikidata/extensions/Wikibase/repo/includes/api/RemoveClaims.php on line 53
[13:18:33] <addshore>	 what version of datamodel are you on?
[13:18:42] <aude>	 could have to do with capitalization of entity id?
[13:18:45] <addshore>	 mhh O_o
[13:18:58] <aude>	 null?
[13:19:23] <addshore>	 they run fine for me >.<
[13:20:57] <grrrit-wm>	 (03PS1) 10Addshore: Use EntityModificationHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 
[13:21:20] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 (owner: 10Henning Snater)
[13:21:32] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 (owner: 10Henning Snater)
[13:21:43] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 (owner: 10Henning Snater)
[13:21:54] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 (owner: 10Henning Snater)
[13:22:03] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 (owner: 10Henning Snater)
[13:22:13] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 (owner: 10Henning Snater)
[13:22:24] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[13:22:42] <aude>	 \o/
[13:23:32] <DanielK_WMDE>	 addshore: ah, wrong branch of DataValues
[13:23:37] <addshore>	 :>
[13:23:42] <DanielK_WMDE>	 this is really annoying to keep track off...
[13:23:46] <addshore>	 :D
[13:23:54] <addshore>	 gotta love cross repo dependancy right ;p
[13:24:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 (owner: 10Henning Snater)
[13:24:13] <DanielK_WMDE>	 yea! let's make more repos! 
[13:24:17] <addshore>	 xD
[13:24:36] <addshore>	 DanielK_WMDE: any chance you can take a look at your -2 on https://gerrit.wikimedia.org/r/#/c/82233/ ?
[13:24:38] <DanielK_WMDE>	 hm... still no bananas
[13:24:39] <addshore>	 also you JeroenDeDauw xD
[13:24:55] <addshore>	 no bananas?
[13:25:16] <DanielK_WMDE>	 "still doesn't work"
[13:25:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added basic listview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80191 (owner: 10Henning Snater)
[13:25:38] <addshore>	 mhhhm
[13:25:53] <addshore>	 can I pull the changeset from somewhere?
[13:26:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implemented "move" functionality in listview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80200 (owner: 10Henning Snater)
[13:28:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Basic snaklistview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80364 (owner: 10Henning Snater)
[13:28:43] <DanielK_WMDE>	 addshore: no changeset. vanilla master.
[13:29:20] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[13:29:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implemented "move" functionality in snaklistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80386 (owner: 10Henning Snater)
[13:29:34] <Tobi_WMDE>	 Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=54166
[13:29:36] <addshore>	 mhhm, running just removeclaims test I get 5 tests and 75 assertions, all seems to pass
[13:30:04] <grrrit-wm>	 (03CR) 10Daniel Werner: "Seems like failing tests are actually not related to my change" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner)
[13:30:27] <DanielK_WMDE>	 addshore: yea, works now after running my "switch everything to master" script in the extension dir
[13:30:37] <DanielK_WMDE>	 i don't even know what was on the wrong branch, but *something* was :)
[13:30:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implemented movetoolbar widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80542 (owner: 10Henning Snater)
[13:30:41] <addshore>	 xD
[13:30:44] <DanielK_WMDE>	 sorry for the noise
[13:31:14] <addshore>	 noise is better than silence ;p
[13:31:17] <DanielK_WMDE>	 i should write a "list all subdirs with their branches" script
[13:31:39] <DanielK_WMDE>	 addshore: oh, so if silence is gold, noise is what, platinum?
[13:32:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Registered movetoolbar definition for qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater)
[13:32:19] <addshore>	 DanielK_WMDE: 
[13:32:51] <addshore>	 red yellow pink and green, orange and purple and blue, i can sing a rainbow, sing a rainbow, sing a rainbow too ;p
[13:32:59] <aude>	 :)
[13:33:56] <DanielK_WMDE>	 addshore: this makes Bob Marley sing in my head
[13:34:23] <DanielK_WMDE>	 (hm, i could listern to the Fatbox Slim version of that, to break the spell...)
[13:35:24] <liangent>	 is it us or mediawiki core misreading ISO 8601?
[13:35:39] <liangent>	 $ php maintenance/eval.php 
[13:35:39] <liangent>	 > new MWTimestamp('+00000002013-01-01T00:00:00Z')
[13:35:39] <liangent>	 MWTimestamp::setTimestamp: Invalid timestamp - +00000002013-01-01T00:00:00Z
[13:35:56] <grrrit-wm>	 (03PS10) 10Daniel Kinzler: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 
[13:36:13] <DanielK_WMDE>	 liangent: quite likely that it doesn't support all the leading zeros.
[13:36:38] <DanielK_WMDE>	 the timestamp class is quick & dirty, not a full implementation of the standard
[13:36:38] <aude>	 without the "+"?
[13:36:47] <DanielK_WMDE>	 that too
[13:37:26] <addshore>	 DanielK_WMDE: when you were talking about changeops checking permissions, did you have any ideas for the implementation?
[13:37:37] <liangent>	 DanielK_WMDE: anyway what's the best way to compare two TimeValues?
[13:38:07] <liangent>	 better to consider precision too
[13:38:25] <DanielK_WMDE>	 liangent: if you just want to known their order, use string comparison. the format is made for that to work
[13:38:41] <DanielK_WMDE>	 liangent: if you need the exact difference.... I have no idea.
[13:39:23] <DanielK_WMDE>	 addshore: the changeop should have a getRequiredPermissions method.
[13:39:41] <addshore>	 indeed, makes sense xD
[13:39:43] <Danwe_WMDE>	 DanielK_WMDE: what's the reason for still having the amount as string inside the quantity? why don't we use floats there?
[13:40:08] <DanielK_WMDE>	 addshore: "somethig" should then call EditEntitiy::addRequiredPermission for each of them
[13:40:44] <DanielK_WMDE>	 (at some point, i want to refactor EditEntity, so it can be made to operate directly on ChangeOps
[13:40:45] <DanielK_WMDE>	 )
[13:41:25] <liangent>	 DanielK_WMDE: hmm it doesn't look so good
[13:41:30] <liangent>	 it's not accepted in the other way
[13:41:35] <DanielK_WMDE>	 Danwe_WMDE: we are trying to cover values from a quantum length to the size of the observable universe. floats lose accuracy. a lot.
[13:41:42] <liangent>	 $ php maintenance/eval.php --wiki=metawiki
[13:41:42] <liangent>	 > new DataValues\TimeValue(wfTimestamp(TS_ISO_8601),0,0,0,0,'')
[13:41:43] <liangent>	 Unexpected non-MediaWiki exception encountered, of type "DataValues\IllegalValueException"
[13:41:43] <liangent>	 exception 'DataValues\IllegalValueException' with message '$time needs to be a valid ISO 8601 date' in .../extensions/DataValues/DataValues/src/TimeValue.php:111
[13:42:04] <DanielK_WMDE>	 Danwe_WMDE: also, we need to preserve the digits as entered, otherwise the number of significant digits is meaningless
[13:42:59] <liangent>	 DanielK_WMDE: the task is to check whether a TimeValue is in the past or the future
[13:43:10] <DanielK_WMDE>	 liangent: ah! that'S different: we expect a very specific subset of ISO-8601. We require a lot of 0 as padding. 
[13:43:18] <Danwe_WMDE>	 DanielK_WMDE: in that case, the getFloat should perhaps not be part of the DV. Your second argument, I don't get it, should make no difference in case of string vs float.
[13:44:00] <DanielK_WMDE>	 liangent: so we'd need a function to construct one of "our" timestamps from the unix epoch. that would be good to have, yes. can probably go into the TimeValue class. Talk to Danwe_WMDE about it.
[13:44:41] <addshore>	 mhh DanielK_WMDE okay :)
[13:44:44] <DanielK_WMDE>	 Danwe_WMDE: getFloat() is for used with things like database indexes, and to be able to compare the data values directly. it'S not exact, but good enough.
[13:44:49] <addshore>	 time to trya nd shuffle some more stuff around me thiinks
[13:45:08] <DanielK_WMDE>	 Danwe_WMDE: as to the number of digits... true if it was given explicitly. From the string, it can be derived, though
[13:45:23] <liangent>	 Danwe_WMDE: ^
[13:46:19] <DanielK_WMDE>	 Danwe_WMDE: to follow up on liangent question: do we have any PHP code for constructing a time value string as expected by TimeValue?
[13:46:26] <DanielK_WMDE>	 with all the padding, leading sign, etc?
[13:46:30] <addshore>	 i guess it might make snese to make the changeops do the edit at the same time
[13:46:47] <DanielK_WMDE>	 addshore: ick! no, please!
[13:46:51] <Danwe_WMDE>	 DanielK_WMDE: I don't think so
[13:47:02] <addshore>	 xionoflando162
[13:47:02] <DanielK_WMDE>	 addshore: hair should not know hoew to cut itself!
[13:47:11] <addshore>	 xionoflando162
[13:47:15] <DanielK_WMDE>	 Danwe_WMDE: can you point her to the JS code?
[13:47:28] <addshore>	 silly copy and paste >.<
[13:47:45] <DanielK_WMDE>	 addshore: a ChangeOp is something that manipulates an Entity. It should not have knowledge about storage mechanisms
[13:48:23] <DanielK_WMDE>	 addshore: i bet it's a password :)
[13:48:41] <addshore>	 i tell you now it is :P
[13:48:50] <DanielK_WMDE>	 hehe
[13:49:09] <addshore>	 best thing is I said it twice :P which makes it twice as nice ;p
[13:49:18] <Danwe_WMDE>	 DanielK_WMDE: liangent: For the time thing, we wrote a small library for time stuff which is then used by DataValues. There is time.Parser and the time.Time constructor.
[13:49:45] <DanielK_WMDE>	 i guess we'll need the same in php
[13:49:50] <Danwe_WMDE>	 can be found in DataValues\DataValues\resources\time.js\src\...
[13:49:53] <DanielK_WMDE>	 or at least some of that functionality
[13:50:09] <aude>	 globe coordinate is in the backend
[13:50:15] <aude>	 time not yet, it seems
[13:50:16] <Danwe_WMDE>	 DanielK_WMDE: we should port EVERYTHING to PHP , PLUS, make it right
[13:50:27] <aude>	 :)
[13:50:29] <addshore>	 *changes laptop password*
[13:50:34] <liangent>	 DanielK_WMDE: and btw string comparison is incorrect for negative years
[13:50:34] <aude>	 gjdskgljsdklgjds
[13:50:36] <aude>	 :D
[13:50:36] <DanielK_WMDE>	 Danwe_WMDE: that's a contradiction in itslef.
[13:50:40] <Danwe_WMDE>	 DanielK_WMDE: the JS stuff is still based on Denny's initial JS parser
[13:50:59] <DanielK_WMDE>	 liangent: )-;
[13:51:11] <liangent>	 so I want at least one more thing to correctly compare them
[13:51:36] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler)
[13:52:47] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 (owner: 10Daniel Kinzler)
[13:52:54] <liangent>	 better to have, fuzzy comparison
[13:53:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler)
[13:53:36] <addshore>	 DanielK_WMDE: I was meaning changeops to use EditEntity rather than have it in the api
[13:53:43] <DanielK_WMDE>	 liangent: strtr( $s, '+', '*' ), then compare
[13:53:46] * DanielK_WMDE  hides

[13:53:58] <liangent>	 is timevalue A is certainly greater / maybe greater / maybe equals / maybe lesser / certainly lesser than timevalue B
[13:54:08] <liangent>	 based on precision/before/after values
[13:54:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 53745) Remove old SnakFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83090 (owner: 10Daniel Kinzler)
[13:54:32] <DanielK_WMDE>	 addshore: EditEntity is high level storage interaction. ChangeOps is low level change representation.
[13:54:37] <DanielK_WMDE>	 ChangeOp should not rely on EditEntity
[13:54:39] <liangent>	 DanielK_WMDE: no. '-2' is greater than '-1'
[13:55:26] <addshore>	 mhmm, maybe there should be something else in between, I see a todo that says this could be factored out into a controller-like class for attemptsaventity
[13:55:35] <DanielK_WMDE>	 liangent: yea, you are right, you need to make two cases.
[13:55:44] <DanielK_WMDE>	 but also, ord(+) < ord(-)
[13:56:28] <DanielK_WMDE>	 addshore: i see no reason for ChangeOp to deal with any of that. In my mind, ChangeOp should ideally not know about any service objects
[13:56:52] <DanielK_WMDE>	 addshore: it does for formatting at the moment, but I think we can get rid of that as soon as i refactored the Summary class
[13:57:56] <addshore>	 so DanielK_WMDE something like Api call, Validate params, Get changeops, Check Permissions, Save
[13:59:50] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler)
[14:01:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 46366) Use SnakFormatter for diffs and summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83091 (owner: 10Daniel Kinzler)
[14:01:35] <DanielK_WMDE>	 addshore: + "apply changeops". yea. Though you can leave the checking to EditEntity, you'd just need to record the required permissions
[14:01:51] <DanielK_WMDE>	 Tobi_WMDE: thanks!
[14:01:58] <aude>	 does anyone want to review https://gerrit.wikimedia.org/r/#/c/84117/ ?
[14:02:01] <aude>	 :D
[14:02:05] <aude>	 reeeeeeview! 
[14:02:06] <grrrit-wm>	 (03PS12) 10Tobias Gritschacher: (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner)
[14:02:09] <addshore>	 yup, so your plan is to have editentity work with changeops did you say?
[14:02:26] <DanielK_WMDE>	 addshore: it's more an idea than a plan, but yea
[14:02:28] <addshore>	 aude: no, eww js
[14:02:38] <addshore>	 DanielK_WMDE: I think its a good idea ;p
[14:02:40] <aude>	 Danwe_WMDE: review https://gerrit.wikimedia.org/r/#/c/84117/
[14:02:43] <DanielK_WMDE>	 \o/
[14:02:51] <aude>	 it's kind of bad that wikidata is broken
[14:03:02] <DanielK_WMDE>	 addshore: we could also construct a diff directly from a set of changeops, how about that?
[14:03:05] <aude>	 or else, we need to revert the globe coordinate refactoring thing
[14:03:14] <DanielK_WMDE>	 actually, every ChangeOp could have a getDiffOp function
[14:03:23] <DanielK_WMDE>	 that would make the transition easy
[14:03:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner)
[14:03:34] <DanielK_WMDE>	 addshore: but that's just pipe dreams right now
[14:03:59] <addshore>	 i like dreams ;p
[14:04:30] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[14:04:42] <DanielK_WMDE>	 addshore: yea, the trick is not to mistake them for plans :) 
[14:06:35] <grrrit-wm>	 (03CR) 10Daniel Werner: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 (owner: 10Aude)
[14:07:02] <aude>	 thanks Danwe_WMDE :)
[14:07:15] <Danwe_WMDE>	 aude: -----~~^^
[14:07:29] * aude  is unfamiliar with the style guidelines

[14:07:32] <aude>	 easy to fix
[14:08:18] <grrrit-wm>	 (03PS9) 10Addshore: Switch use of entity->newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 
[14:08:22] <grrrit-wm>	 (03CR) 10Addshore: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[14:08:34] <aude>	 although i see that one violated  alot 
[14:08:46] <Danwe_WMDE>	 aude: that's because it is a new rule
[14:08:51] <aude>	 ok 
[14:08:57] * aude  will ignore a few lines below

[14:09:08] <aude>	 for new code, good to follow the guidelines
[14:09:59] <grrrit-wm>	 (03PS5) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 
[14:10:20] <grrrit-wm>	 (03PS6) 10Daniel Kinzler: (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 
[14:11:46] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent)
[14:13:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler)
[14:14:04] <addshore>	 mhhm, how anoying DanielK_WMDE , in changeops the only really way to get the required permissions is after apply has been called :<
[14:14:19] <addshore>	 actually lies
[14:14:22] <addshore>	 ..
[14:14:45] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "Sorry, I meant PS 15. Jeroen said: "This change adds a pile of procedural code. Please create new classes if your new behaviour does not f" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[14:20:21] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: Switch use of entity->newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[14:20:52] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Revert "Revert "Remove NewClaim dependancy on Lib"" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/84316 (owner: 10Addshore)
[14:21:02] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Switch use of entity->newClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore)
[14:24:04] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Looks a lot better now, and it'S mostly OK to merge, but I still have a few questions." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore)
[14:24:23] <JeroenDeDauw>	 LOOOOL
[14:24:32] <JeroenDeDauw>	 so much win
[14:24:39] <JeroenDeDauw>	 addshore: you merged https://gerrit.wikimedia.org/r/#/c/83815/
[14:24:41] <JeroenDeDauw>	 :D
[14:24:48] <JeroenDeDauw>	 DanielK_WMDE: ^^ haha
[14:26:07] <addshore>	 DanielK_WMDE: the merge one depends on the edit entities one ;p
[14:26:17] <addshore>	 which still has an old -2 from you currently
[14:26:57] <JeroenDeDauw>	 addshore: you do realize the Private class in there was not entirely serious right? ;p
[14:27:48] <JeroenDeDauw>	 addshore: ALL of the approaches https://gist.github.com/JeroenDeDauw/6525656
[14:27:56] <addshore>	 heh, I was hoping it might get moved :P#
[14:29:16] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore)
[14:29:20] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Looking good now, but I want to play with it before merging." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore)
[14:29:21] <addshore>	 naturally the best bit is // TODO
[14:31:10] <DanielK_WMDE>	 JeroenDeDauw, addshore: eek! passing parameters as members is horrible :(
[14:31:52] <DanielK_WMDE>	 JeroenDeDauw: damn, i wanted to reply to your mail. but i would have picked nither. how about doing the array_diff in updateTable, and then just calling addFiuelds and removeFields?
[14:32:19] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore)
[14:32:42] <addshore>	 Tobi_WMDE: >> https://gerrit.wikimedia.org/r/#/c/84321/
[14:36:40] <grrrit-wm>	 (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore)
[14:36:59] <grrrit-wm>	 (03PS20) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 
[14:37:36] <grrrit-wm>	 (03PS28) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 
[14:37:53] <grrrit-wm>	 (03CR) 10Addshore: "PS28 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore)
[14:38:51] <grrrit-wm>	 (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore)
[14:41:37] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#820 (master - 06ffdb5 : Jeroen De Dauw): The build was broken.
[14:41:37] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/5129fe0e55be...06ffdb54561c
[14:41:37] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11419488
[14:46:21] <JeroenDeDauw>	 DanielK_WMDE: my gist contains 7 different approaches
[14:46:30] <JeroenDeDauw>	 DanielK_WMDE: you dislike all of them? ;;p
[14:52:58] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 (owner: 10Aude)
[14:53:27] <aude>	 tabs!
[14:54:57] <grrrit-wm>	 (03PS6) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 
[14:56:18] <DanielK_WMDE>	 JeroenDeDauw: i just checked two over the weekend and meant to do the rest today. won't happen, i'm afraid. 
[14:56:22] <DanielK_WMDE>	 are you at the office tomorrow?
[14:59:54] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-2] "Superseded by Ide1e947d9" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84121 (owner: 10Aude)
[15:02:22] <grrrit-wm>	 (03Abandoned) 10Aude: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84121 (owner: 10Aude)
[15:02:47] <aude>	 merge https://gerrit.wikimedia.org/r/#/c/84117/ please :)
[15:03:17] <grrrit-wm>	 (03PS1) 10Addshore: Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 
[15:03:40] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:04:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:05:29] <aude>	 readapidenied?
[15:05:45] <aude>	  You need read permission to use this module
[15:08:22] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 032 V: 031] allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 (owner: 10Aude)
[15:11:27] * aude  gets UsageException: Unrecognized value for parameter 'action': wbsetstatementrank

[15:12:37] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore)
[15:12:50] * aude  makes sure i update all my extensions

[15:13:05] <aude>	 hmmm, failures
[15:13:06] <grrrit-wm>	 (03PS2) 10Tobias Gritschacher: Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:13:07] <aude>	 2 failures
[15:13:23] <DanielK_WMDE>	 addshore: ^--- maybe I'm missing something? Why is getEntityId adding something to the result? To make the mapping available to the client?
[15:13:24] <JeroenDeDauw>	 revert everything?
[15:13:32] <aude>	 SetStatementRankTest
[15:13:34] <JeroenDeDauw>	 DanielK_WMDE: nope, not in the office tomorrow
[15:13:35] <DanielK_WMDE>	 seems like it should at least be opptional...
[15:13:44] * aude  has experiemntal off

[15:14:30] <grrrit-wm>	 (03PS1) 10Henning Snater: Using listview to group referenceview's snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84326 
[15:14:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove myself.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:14:34] <aude>	 errr, i think i have experimental on
[15:16:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Using listview to group referenceview's snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84326 (owner: 10Henning Snater)
[15:16:29] <aude>	 tests pass now for me
[15:16:47] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Split ChangeOp into interface and base class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84300 (owner: 10Addshore)
[15:18:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split ChangeOp into interface and base class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84300 (owner: 10Addshore)
[15:18:20] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Use ClaimGuidParser instead of deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84302 (owner: 10Addshore)
[15:19:22] <grrrit-wm>	 (03PS3) 10Tobias Gritschacher: Remove myself.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:19:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use ClaimGuidParser instead of deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84302 (owner: 10Addshore)
[15:21:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:21:30] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 (owner: 10Addshore)
[15:24:22] <grrrit-wm>	 (03PS2) 10Henning Snater: Using listview to group referenceview's snaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84326 
[15:24:35] <grrrit-wm>	 (03PS1) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/84328 
[15:24:54] <grrrit-wm>	 (03CR) 10Aude: [C: 032 V: 032] allow globe coordinate precision to be null in JS [extensions/DataValues] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/84328 (owner: 10Aude)
[15:27:45] <grrrit-wm>	 (03CR) 10Liangent: "That comment is not valid anymore in PS 20." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[15:28:10] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#821 (master - 536651e : jenkins-bot): The build is still failing.
[15:28:10] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/06ffdb54561c...536651e42669
[15:28:10] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11421726
[15:30:12] <DanielK_WMDE>	 liangent: sorry about, i got confused by all the revisions. i'll try to do a full review again tonigh.
[15:30:52] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "sorry about, i got confused by all the revisions. i'll try to do a full review again" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[15:31:03] <grrrit-wm>	 (03CR) 10Daniel Kinzler: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[15:31:44] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 04-1] "(3 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[15:34:23] <DanielK_WMDE>	 Lydia_WMDE_: re puppet: perhaps send the mail to wikidata-tech too?
[15:34:49] <aude>	 addshore: it doesn't even had a rebase button for me?
[15:35:05] <addshore>	 both me and travis fail
[15:35:16] <addshore>	 jenkins seems to pass and fail...
[15:35:18] <aude>	 it's non-rebasable?
[15:35:20] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#822 (master - 35a1a69 : jenkins-bot): The build is still failing.
[15:35:20] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/536651e42669...35a1a6902028
[15:35:20] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11421822
[15:35:21] <addshore>	 and it passes for you and toby :P
[15:36:40] <aude>	 wtf!!!!
[15:36:50] <aude>	 it fails massively with your patch!
[15:37:03] <aude>	 PHP Fatal error:  Call to a member function getWikiPage() on a non-object in /Library/WebServer/Documents/wikidata-repo/extensions/Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataRequestHandlerTest.php on line 197
[15:39:13] <aude>	 is Factor 3 methods in EditEntity to smaller methods on master?
[15:39:19] <addshore>	 no
[15:39:27] <aude>	 that would explain things
[15:39:31] <grrrit-wm>	 (03PD3) 10Tobias Gritschacher: Remove addshore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84330 
[15:39:47] <Tobi_WMDE>	 review: https://gerrit.wikimedia.org/r/#/c/84330/ !!!
[15:39:55] <Tobi_WMDE>	 aude addshore ^^^^
[15:40:14] <aude>	 tests based on the commit before that pass fine :)
[15:40:21] <addshore>	 xD
[15:40:23] <aude>	 addshore: and that explains why there was no rebase button
[15:40:31] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-2] "here's a better one: https://gerrit.wikimedia.org/r/#/c/84330/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:40:43] <grrrit-wm>	 (03Abandoned) 10Addshore: Remove myself... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84325 (owner: 10Addshore)
[15:40:50] <addshore>	 DanielK_WMDE: did you break master? :>
[15:41:17] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(3 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[15:41:17] <DanielK_WMDE>	 addshore: uh, i hope not?
[15:41:27] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove addshore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84330 (owner: 10Tobias Gritschacher)
[15:41:36] <aude>	 addshore: also note that release notes are generated for each core branch, including list of wikibase commits
[15:41:39] <aude>	 https://www.mediawiki.org/wiki/MediaWiki_1.22/wmf16/Changelog#Wikibase
[15:41:51] <aude>	 something more descriptive thant "Remove myself" would be nice :)
[15:41:58] <aude>	 generally speaking
[15:42:11] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: allow longitude coordinates up to 360 in JS globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 (owner: 10Aude)
[15:42:26] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "These paths look wrong..." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 (owner: 10Aude)
[15:42:37] <grrrit-wm>	 (03PS4) 10Jeroen De Dauw: handle globe option in GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84200 (owner: 10Aude)
[15:42:40] <addshore>	 DanielK_WMDE: travis is having a random failure, and it seems to come from "(bug 46366) Use SnakFormatter for diffs and summaries"
[15:42:49] <Tobi_WMDE>	 DanielK_WMDE: it fails since the diff-formatter patch: https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11418347
[15:42:57] <Tobi_WMDE>	 very weird
[15:43:03] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] handle globe option in GlobeCoordinateParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84200 (owner: 10Aude)
[15:43:04] <Tobi_WMDE>	 randomly
[15:43:35] <aude>	 JeroenDeDauw:  you mean the way the test and src directory are setup?
[15:43:43] <aude>	 seems odd to me also
[15:43:57] <aude>	 and some globe coordinate stuff is in datavalues, some in data values commons, etc
[15:44:07] * aude  had to hunt to find everything

[15:45:23] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] allow longitude coordinates up to 360 in JS globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 (owner: 10Aude)
[15:46:22] <aude>	 odd that travis has "build exited with 1"
[15:46:27] <aude>	 no explaination
[15:48:16] * aude  tries running *all* the tests

[15:49:27] <MatmaRex>	 hi, is there some "speed limit" wikidata bots should adhere to?
[15:49:35] <addshore>	 567890-
[15:49:43] <aude>	 MatmaRex: keep an eye on dispatch stats
[15:49:55] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "(5 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[15:49:56] <aude>	 Special:DispatchStats, which unfortunatley has no api version yet
[15:50:11] <addshore>	 if someone goes to fast we will generally tell them and if its urgent block :o
[15:50:21] <addshore>	 other than that I wouldnt worry too much :)
[15:50:29] <MatmaRex>	 alright
[15:50:30] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#823 (master - e592efa : Tobias Gritschacher): The build is still failing.
[15:50:30] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/35a1a6902028...e592efa9e972
[15:50:31] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11422614
[15:50:31] <MatmaRex>	 thanks
[15:50:32] <addshore>	 keep an eye on project chant and the bots talk page is all
[15:50:49] <aude>	 you can also see edits per minute: http://wikipulse.herokuapp.com/
[15:51:00] <aude>	 right now, it's 70 per minute on wikidata which is very low
[15:51:09] <aude>	 most of the bots must be on holiday
[15:51:15] <addshore>	 because my bot is in hospital :< :P
[15:51:19] <aude>	 hah
[15:51:32] <aude>	 300 edits per minute is normal
[15:51:36] <aude>	 200-300
[15:51:43] <aude>	 500 should be okay
[15:52:00] <aude>	 1000 would perhaps be too much and i'm not sure what the threshold is now
[15:53:14] <MatmaRex>	 heh, wikipulse. okay.
[15:53:28] <MatmaRex>	 my bot will approximately double that, at most ;)
[15:53:38] <aude>	 should be fine
[15:53:58] <aude>	 we don't know the limit now, but when the change dispatcher was in tampa on slower hardware, we ran into issues
[15:54:11] <aude>	 i can't remember how fast the bot was going, but it was like 1000 per minute
[15:54:14] <aude>	 maybe
[15:54:36] <aude>	 now we are on better hardware, in ashburn, with redis handling job queue
[15:55:16] <aude>	 file_get_contents(/Library/WebServer/Documents/wikidata-repo/extensions/Wikibase/lib/includes/OldSnakFormatter.php): failed to open stream: No such file or directory
[15:56:51] <aude>	 get rid of it in WikibaseLib.classes.php and it probably passes build
[15:58:19] <grrrit-wm>	 (03PS1) 10Addshore: Remove OldSnakFormatter from classes list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84336 
[15:58:30] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Remove OldSnakFormatter from classes list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84336 (owner: 10Addshore)
[15:59:32] <aude>	 AutoLoaderTest::testAutoLoadConfig
[16:01:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove OldSnakFormatter from classes list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84336 (owner: 10Addshore)
[16:14:14] <JeroenDeDauw>	 travis is not happy...
[16:14:25] <grrrit-wm>	 (03CR) 10Daniel Werner: "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[16:14:42] <Danwe_WMDE>	 DanielK_WMDE: significantDigits should just go out of the constructor
[16:15:18] <lazowik>	 JeroenDeDauw: quick, need to feed him!
[16:15:44] * aude  awaits the results

[16:16:04] <aude>	 25) AutoLoaderTest::testAutoLoadConfig
[16:16:05] <aude>	 Failed asserting that two arrays are equal.
[16:17:18] <aude>	 http://pastebin.com/a5xSxXp8
[16:17:21] <aude>	 spot the difference
[16:20:15] <lazowik>	 heh, prefixes
[16:21:24] <aude>	 in https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11423285 it's php 5.4 and 5.5 that fail
[16:21:54] <Tobi_WMDE>	 it's 5.4 an 5.5 always
[16:24:02] <addshore>	 but i am on 5.4 xD
[16:26:02] <aude>	 PHP 5.3.27 (cli) (built: Jul 19 2013 18:25:06) 
[16:26:12] <aude>	 not php 5.4 or 5.5
[16:27:08] <addshore>	 PHP 5.4.7 (cli) (built: Sep 12 2012 23:48:31)
[16:27:29] <grrrit-wm>	 (03CR) 10Daniel Werner: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[16:51:16] <GerardM>	 is there a reason why bots time out at the moment ??
[16:51:44] <lazowik>	 wut?
[16:52:28] <lazowik>	 addshore: ^
[16:52:41] * aude  tries my bot

[16:52:42] <addshore>	 gerardM, in what way?
[16:53:52] <GerardM>	 it waits for 120 seconds and then again waits for 120 seconds
[16:53:59] <aude>	 i see MatmaRex bot running
[16:54:02] <aude>	 matmabot
[16:54:31] <MatmaRex>	 huh?
[16:54:33] <aude>	 my bot is able to edit
[16:54:33] <MatmaRex>	 did i break it?
[16:54:36] <aude>	 no
[16:55:08] <lazowik>	 MatmaRex: your bot is used as an example that bots are working :)
[16:55:09] <aude>	 250 edits per minute is within reason for wikidata
[16:55:14] <addshore>	 GerardM no errors at all? what exactly are you requesting?
[16:55:15] <aude>	 :)
[16:55:46] <aude>	 i also see ViscoBOt
[16:55:48] <aude>	 Bot
[16:55:58] <aude>	 creating claims, descriptions
[17:05:57] <GerardM>	 I rebooted my system to ensure that it is not something like memory leaks
[17:06:00] <GerardM>	 no difference
[17:08:24] <addshore>	 GerardM: what is the exact request your performing?
[17:08:36] <Reedy>	 addshore: get all the things
[17:08:42] <addshore>	 :>
[17:08:46] <GerardM>	 python pwb.py harvest_template.py -family:wikipedia -lang:en -transcludes:"Infobox Officeholder" -template:"Infobox Officeholder" -namespace:0 party p102
[17:09:10] <addshore>	 mhhm, that doesnt help much :P
[17:09:15] <addshore>	 does pywiki have some sort of debug log?
[17:10:15] <GerardM>	 not that I am aware off
[17:10:40] <addshore>	 mhhhm, i cant really help then as I have no idea what thats scripts doing or where it is going wrong for you :P
[17:10:49] <addshore>	 legoktm: ^^
[17:18:08] <grrrit-wm>	 (03PS3) 10Addshore: Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 
[17:21:15] <grrrit-wm>	 (03PS3) 10Addshore: Switch use of ClaimModHelper to EntityModHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 
[17:21:31] <grrrit-wm>	 (03PS2) 10Addshore: Use EntityModificationHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 
[17:21:32] <grrrit-wm>	 (03PS4) 10Addshore: Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[17:21:45] <grrrit-wm>	 (03CR) 10Addshore: "PS3 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 (owner: 10Addshore)
[17:22:01] <grrrit-wm>	 (03CR) 10Addshore: "PS2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 (owner: 10Addshore)
[17:22:08] <grrrit-wm>	 (03CR) 10Addshore: "PS4 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[17:22:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch use of ClaimModHelper to EntityModHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 (owner: 10Addshore)
[17:22:19] <addshore>	 yaY
[17:22:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityModificationHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 (owner: 10Addshore)
[17:22:49] <addshore>	 payh
[17:23:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[17:25:40] <grrrit-wm>	 (03PS4) 10Addshore: Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 
[17:26:32] <grrrit-wm>	 (03PS4) 10Addshore: Switch use of ClaimModHelper to EntityModHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 
[17:27:29] <grrrit-wm>	 (03PS5) 10Addshore: Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[17:28:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch use of ClaimModHelper to EntityModHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 (owner: 10Addshore)
[17:28:09] <lazowik>	 so many addshores
[17:28:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityModhelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[17:30:27] <grrrit-wm>	 (03PS3) 10Addshore: Use EntityHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 
[17:30:28] <grrrit-wm>	 (03PS5) 10Addshore: Switch use of ClaimModHelper to EntityHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 
[17:30:29] <grrrit-wm>	 (03PS6) 10Addshore: Use EntityHelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 
[17:30:50] <addshore>	 heh :P
[17:30:54] <addshore>	 no more now, time to leave :>
[17:31:08] <addshore>	 hows it going lazowik ? :(
[17:31:12] <addshore>	 :)
[17:31:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 (owner: 10Addshore)
[17:31:31] <addshore>	 heh, thats was definatly meant to be a smile, but I looked at the keyboard and naturally the keys are in the wrong place
[17:32:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switch use of ClaimModHelper to EntityHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 (owner: 10Addshore)
[17:32:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityHelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore)
[17:32:51] <grrrit-wm>	 (03PS4) 10Addshore: Use EntityHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 
[17:32:56] <addshore>	 PAH
[17:33:08] <addshore>	 no more until tomorrow *ignores fails*
[17:36:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EntityHelper for EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84321 (owner: 10Addshore)
[17:44:59] <lazowik>	 addshore: good on overall
[17:45:03] <lazowik>	 but got a cold
[17:45:26] <lazowik>	 didn't manage to finish api editing :(
[18:41:51] <Lydia_WMDE_>	 DanielK_WMDE: i think basically everyone on tech is also on l
[18:42:53] <aude>	 Lydia_WMDE_: coordinates are fixed now
[18:43:07] <Lydia_WMDE_>	 aude: \o/
[18:43:19] <aude>	 nothing should display as ununserializable, except possibly the few with null globe
[18:43:24] <aude>	 and i am not sure about mars
[18:43:47] <aude>	 mars coordinates should be rendered next week
[18:44:13] <aude>	 editing the globe might be optimistic :/
[18:47:04] <Lydia_WMDE_>	 that's perfectly fine
[18:47:18] <Lydia_WMDE_>	 it's not like it's a super important issue
[18:47:27] <Lydia_WMDE_>	 nice to have for sure but...
[18:47:38] <Lydia_WMDE_>	 nothing we have to kick ourself for ;-)
[18:47:47] <aude>	 well, it's odd to support it in the api but not in the UI
[18:48:07] <Lydia_WMDE_>	 sure
[18:48:11] * aude  shall take care that commons is ready though

[18:48:18] <Lydia_WMDE_>	 yeah :)
[18:48:29] <Lydia_WMDE_>	 that's kinda more important :P
[18:48:33] <aude>	 yep
[18:51:19] <multichill>	 aude: The week was over so I created https://www.wikidata.org/wiki/Property:P910
[18:52:23] <multichill>	 So that's ready for Commons :-)
[18:52:35] * aude  think i found my favorite item :)

[18:52:36] <aude>	 https://www.wikidata.org/wiki/Q653646
[18:52:45] <aude>	 shall need to read the book :D
[18:52:53] <Lydia_WMDE_>	 haha
[18:52:56] <Lydia_WMDE_>	 brilliant
[18:53:06] <aude>	 at least we allow labels that long :)
[18:53:46] <aude>	 multichill: interesting
[18:53:50] <multichill>	 aude: https://www.wikidata.org/w/index.php?title=Q9920&action=history <- +2,988 ?
[18:53:53] <multichill>	 huh?
[18:54:04] <aude>	 the property
[18:54:42] <multichill>	 I don't get it aude
[18:54:48] <aude>	 ?
[18:54:59] <aude>	 how are we supposed to use the property?
[18:55:57] <multichill>	 https://commons.wikimedia.org/wiki/File:Commons_Interwiki_links_-_with_wikidata_2.svg
[18:57:16] <multichill>	 aude: ^^
[18:58:28] <multichill>	 aude: How is the size difference calculated? How come a simple edit is +9034 ?
[19:00:28] <aude>	 multichill: because badges have been added to the site link structure
[19:00:47] <aude>	 they  are empty but added to the data structure
[19:01:01] <multichill>	 Badges? Missed that part, do you have a link explaining them?
[19:01:13] <multichill>	 https://www.wikidata.org/wiki/Q183 doesn't load any items for me btw
[19:01:15] <Pyb>	 Featured articles
[19:02:05] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=54025
[19:04:18] <aude>	 at the moment loading pages is slow for me
[19:05:31] <aude>	 seems better now
[19:08:29] <lazowik>	 aude: how many peeps were already wtfd by the size of edits? :)
[19:09:16] <aude>	 lazowik: a bunch of folks noticed it
[19:28:04] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Karima Rafes link https://www.mediawiki.org/w/index.php?diff=784146 edit summary: [+1] /* Poll for changes */
[20:09:22] <karima>	 Hi I'm discovering Wikidata... How insert a new statement in an item ? there is not button add
[20:10:07] <Sven_Manguard>	 karima - do you have javascript enabled? 
[20:10:26] <karima>	 on the client or repo ?
[20:10:55] <Sven_Manguard>	 on your browser
[20:12:02] <Sven_Manguard>	 I'm not a techie, I don't speak techie, so client or repo doesn't mean anything to me, but if you're trying to add a statement and don't see the addition button, the most common causes are either a) you don't have javascript on your browser, or b) you're trying to edit something else.  Just so you know, you're only able to edit one field at once, so if you accidentally clicked the button to...
[20:12:04] <Sven_Manguard>	 ...edit the label or the description, you wouldn't be able to edit the interwiki links until you stopped trying to edit the label or description.
[20:12:17] <Sven_Manguard>	 or, in your case, add a statement
[20:14:50] <karima>	 strange... my browser is chrome there is javascript but it's true the ajax is disable
[20:16:25] <Sven_Manguard>	 karima: It pains me to say this, but I've got no idea what ajax is or does
[20:16:37] * Sven_Manguard  sobs "I'm a liberal arts major" loudly

[20:16:56] <rschen7754>	 it's javascript that is asynchronous
[20:17:17] <rschen7754>	 meaning that the page updates without you having to load
[20:17:29] <Sven_Manguard>	 thank you. Karima, meet rschen7754. rschen7754, this is karima, who needs help. 
[20:17:45] <rschen7754>	 hi!
[20:17:47] <Sven_Manguard>	 I'm going to go wallow in uselessness over in a corner somewhere
[20:17:50] <Sven_Manguard>	 :D
[20:17:54] <rschen7754>	 yes, i assume ajax is needed...
[20:17:55] <karima>	 hi
[20:18:27] <karima>	 I have to insert a option for ajax in the localsettings ?
[20:18:47] <rschen7754>	 on your browser settings, i would assume?
[20:18:51] <rschen7754>	 i don't have chrome
[20:19:17] <karima>	 in chrome ajax is by default 
[20:20:05] <rschen7754>	 hm
[20:20:15] <rschen7754>	 the add button should be under statements, in the bottom right
[20:21:42] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#825 (master - 209ee8f : Translation updater bot): The build is still failing.
[20:21:42] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2276b6ca638c...209ee8fbc667
[20:21:42] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11432137
[20:21:42] <karima>	 on wikidata.org I see the button Add but in my wiki there no add with the statement... 
[20:23:14] <karima>	 rschen7754: it's probably a bug in my config... thanks for the infos
[20:23:20] <rschen7754>	 so you checked out the code and are hosting your own copy of wikidata?
[20:23:21] <karima>	 bye
[20:23:35] <karima>	 I host my own copy
[20:23:51] <karima>	 I test...
[20:23:58] <rschen7754>	 oh, ok… yeah, maybe asking a developer might be helpful
[20:26:15] <GerardM>	 did new functionality go life today ?
[20:28:36] <Sven_Manguard>	 GerardM: what functionality?
[20:35:54] <MatmaRex>	 huh, guys
[20:36:01] <MatmaRex>	 there's this item: https://www.wikidata.org/wiki/Q32024
[20:36:37] <MatmaRex>	 attempting to edit it via the wbsetdescription api seems impossible - it complains about a constrain violaiton for description in korean
[20:36:52] <MatmaRex>	 i was able to add a description from UI, though.
[20:37:04] <MatmaRex>	 (and yeah, the ko description is pretty damn long at a glance.)
[20:37:45] <MatmaRex>	 also, i randomly get this error when editing via the same api: "code"=>"internal_api_error_DBQueryError"
[20:38:43] <MatmaRex>	 as well as "code"=>"failed-save", "info"=>"Edit conflict.", but the page appears to be saved nevertheless
[20:39:51] <Sven_Manguard>	 I don't know anything about editing in Korean. I can see if DangSumM is online though.
[20:41:08] <MatmaRex>	 i didn't even try to edit the korean stuff :/
[20:41:17] <MatmaRex>	 i was adding a description in polish (pl)
[20:41:27] <MatmaRex>	 that's why i'm complaining
[20:41:54] <legoktm>	 MatmaRex: normally when i get those i just wipe out the too long description
[20:42:03] <legoktm>	 its not ideal, but having the item not editable is less ideal
[20:43:35] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[20:43:50] <MatmaRex>	 legoktm: well, but that shouldn't happen, should it?
[20:44:29] <GerardM>	 Sven_Manguard: I noticed that in stead of a number Arabic and Chinese labels were shown for people who did not have English labels
[20:44:44] <GerardM>	 it was the first time I noticed this
[20:44:47] <legoktm>	 MatmaRex: the constraints were imposed after many of these descriptions were set
[20:44:53] <Sven_Manguard>	 GerardM: I think that's being addressed in https://www.wikidata.org/wiki/Wikidata:Paper_cuts
[20:44:54] <legoktm>	 (cur | prev) 02:33, 13 November 2012‎ Sotiale (talk | contribs | block)‎ . . (3,225 bytes) (+277)‎ . . (‎Changed Korean description: 러시아의 정치인으로, 2012년 11월 6일 러시아 국방장관으로 임명되었으며, 그 이전에는 1994년 이후 비상사태부 장관을 맡고 있었다. 쇼이구는 투바인이며, 전직 러...) (undo) (restore)
[20:45:02] <legoktm>	 heh, thats a language fallback thing.
[20:45:17] <GerardM>	 yes it is ... but is that new today ?
[20:46:34] <MatmaRex>	 legoktm: i guessed that, but shouldn't some sort of a constraint checker be run after new ones are added?
[20:46:48] <legoktm>	 MatmaRex: probably ;)
[20:46:52] <MatmaRex>	 heh
[20:48:43] <lazowik>	 aude: ^
[20:49:15] <lazowik>	 (the constraints thingy)
[20:53:29] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 (owner: 10Addshore)
[20:53:41] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 (owner: 10Addshore)
[21:01:46] <Korail>	 ?
[21:03:09] <Korail>	 네 뭘 도와드려요?
[21:03:22] <Korail>	 What I need to help?
[21:03:25] <Sven_Manguard>	 MatmaRex: ^^^
[21:03:50] <Korail>	 too long discription?
[21:03:57] <Korail>	 description?
[21:04:12] <lazowik>	 Korail: mhm
[21:04:35] <lazowik>	 Korail: in https://www.wikidata.org/wiki/Q32024
[21:05:00] <Korail>	 too long description?
[21:05:04] <lazowik>	 yes
[21:05:21] <Korail>	 ok
[21:06:02] <lazowik>	 thanks :)
[21:06:04] <Korail>	 https://www.wikidata.org/w/index.php?title=Q32024&diff=70886854&oldid=70876643 done
[21:06:19] <lazowik>	 great
[21:07:10] <lazowik>	 MatmaRex: I think that this deserves a bug
[21:07:55] <Korail>	 No I think description is limited?
[21:07:58] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "On a quick glance, it looks like the amount of evilness has not increased significantly with the latest PS. So retracting my -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[21:08:50] <lazowik>	 Korail: yes, the problem is that the limit was added after some time
[21:09:02] <Korail>	 ok! I am leaving. If you have any more help please ping me
[21:09:09] <Korail>	 bye
[21:09:11] <lazowik>	 bye
[21:12:04] <lazowik>	 MatmaRex: looks similiar: https://bugzilla.wikimedia.org/show_bug.cgi?id=49642
[21:23:05] <MatmaRex>	 lazowik: ha, yeah, looks like the same thing. thanks
[21:28:23] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "(5 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler)
[22:36:52] <Sven_Manguard>	 anyone here speak Chinese?
[22:37:05] <Sven_Manguard>	 or, um, read Chinese?
[22:37:31] <Reedy>	 liangent does
[22:38:39] <Sven_Manguard>	 Or Japanese. Either would work. Just want to know what the label for https://www.wikidata.org/wiki/Q10911535 should be in English
[23:33:14] <grrrit-wm>	 (03PS1) 10Nilesh: Final wikiparser mapper and reducer modules using classes. Deleted old scripts. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 
[23:37:04] <grrrit-wm>	 (03PS2) 10Nilesh: Final wikiparser mapper and reducer modules using classes. Deleted old scripts. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 
[23:55:23] <grrrit-wm>	 (03CR) 10Nilesh: "(1 comment)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 (owner: 10Nilesh)