[00:51:56] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler)
[08:29:20] <grrrit-wm>	 (03PD1) 10Daniel Kinzler: Introducing DispatchingValueFormatter and OutputFormatValueFormatterFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84768 
[08:29:47] <grrrit-wm>	 (03PS2) 10Daniel Kinzler: Introducing DispatchingValueFormatter and OutputFormatValueFormatterFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84768 
[08:29:57] <pragunbhutani>	 aude: there?
[08:31:08] <DanielK_WMDE_>	 pragunbhutani: she's not here yet, probably on her way
[08:31:20] <pragunbhutani>	 okay, thanks
[08:31:34] <pragunbhutani>	 DanielK_WMDE_:  what do you think about using something like https://github.com/dave1010/jquery-fast-click on the mobile skin?
[08:32:10] <pragunbhutani>	 there's a noticeable delay between tapping and the jquery event being fired on mobiles
[08:33:20] <pragunbhutani>	 jquery fast click removes that 300ms delay
[08:33:25] <pragunbhutani>	 makes the page feel more 'native'
[08:36:02] <DanielK_WMDE_>	 pragunbhutani: sounds good, but I have no idea about the repurcussions of doing that. Best discuss it with Henning_WMDE and with Danwe, when he comes in.
[08:38:50] <pragunbhutani>	 Will do that :)
[09:13:19] <Lydia_WMDE>	 Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=51575 and https://bugzilla.wikimedia.org/show_bug.cgi?id=53157 are dupes right?
[09:15:52] <Henning_WMDE>	 Yes, I am pretty sure these are duplicates.
[09:16:28] <Lydia_WMDE>	 ok will mark
[09:30:24] <JeroenDeDauw>	 DanielK_WMDE_: last chance to give input on https://gist.github.com/JeroenDeDauw/6525656
[09:46:17] <DanielK_WMDE_>	 JeroenDeDauw: approach 3, but the table name should either go into the constructor or be passed as a parameter. Side effects should be avoided, and "pass by member" in particular.
[09:46:20] <DanielK_WMDE_>	 err
[09:46:46] <DanielK_WMDE_>	 JeroenDeDauw: http://p.defau.lt/?j5hk_gvFpB5KWfbNb8n7jw
[09:47:18] <grrrit-wm>	 (03PS2) 10Addshore: No longer require mainsnak when removing claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84958 
[09:47:19] <grrrit-wm>	 (03PS21) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 
[09:47:25] <grrrit-wm>	 (03PS29) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 
[09:47:51] <JeroenDeDauw>	 DanielK_WMDE_: mhh, disagree with that modification for classes such as this one
[09:48:14] <DanielK_WMDE_>	 why?
[09:48:18] <JeroenDeDauw>	 DanielK_WMDE_: also, while approach 3 is my favourite for the current amount of code, it becomes problematic when taking care of the todo
[09:48:26] <JeroenDeDauw>	 updateTable method gets to big
[09:48:33] <DanielK_WMDE_>	 "addFields" has no meaning without a table. it operates *on* a table. so it should take a table as a parameter.
[09:48:57] <grrrit-wm>	 (03CR) 10Addshore: "PS29 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore)
[09:49:22] <grrrit-wm>	 (03CR) 10Addshore: "PS21 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore)
[09:49:34] <JeroenDeDauw>	 DanielK_WMDE_: disagree that this implies having to pass as parameter
[09:50:09] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Add interfaces and stubs for schema modification functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/84959 
[09:50:29] <JeroenDeDauw>	 addshore: ^
[09:50:31] <DanielK_WMDE_>	 it's a good rule of thumb: "collaborators" go into the constructor, methods operate *with* them. Things the function operates *on* should be parameters. 
[09:51:11] <DanielK_WMDE_>	 JeroenDeDauw: but be that as it may, setting a member as a side-effect to a function like "updateTable" just in order to pass it to other methods is plain evil
[09:51:51] <DanielK_WMDE_>	 JeroenDeDauw: this kind of coding is what makes EditPage utterly incomprehensible. I fee for it again when writing EditEntity. I won't do it again. It's bad.
[09:51:52] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Add interfaces and stubs for schema modification functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/84959 (owner: 10Jeroen De Dauw)
[09:52:01] <DanielK_WMDE_>	 *I fell for it
[09:52:40] <JeroenDeDauw>	 DanielK_WMDE_: you can do quite evil things using fields yes. Are the problems you encountered however present in this class, or does it look like they will arise?
[09:53:04] <JeroenDeDauw>	 Making swopping statements such as using fields to pass values always being bad tends to lose sight of the actual dynamics
[09:54:25] <DanielK_WMDE_>	 again: a best practice arising from experience. it's not a problem *now*, but makes the flow of information less obvious, less explicite.
[09:54:43] <DanielK_WMDE_>	 so i'd consider it a Bad Idea, even if it's not A Problem right now.
[09:55:46] <DanielK_WMDE_>	 JeroenDeDauw: you could also just set the table to operate on in the constructor. 
[09:57:52] <JeroenDeDauw>	 DanielK_WMDE_: in what constructor? there is only one in approach 3, and there it clearly does not fit
[09:59:26] <JeroenDeDauw>	 addshore: if you can think of a way to get around the field type problem (the one we will not currently run into), then it'll be worthwhile in thinking of implementing that
[09:59:59] <JeroenDeDauw>	 addshore: while we can change a lot of the implementation in the db component easily, the Definition classes are part of the public interface, and will be very hard to change later
[10:00:15] <JeroenDeDauw>	 So if we get something really wrong there, that is going to be painfull
[10:00:27] <addshore>	 okay :)
[10:00:50] <DanielK_WMDE_>	 JeroenDeDauw: whether that fits depends on how that class is intended to be used. if it's to be used for updating multiple tables - then it's not appropriate, of course. but maybe that premise can be re-examined.
[10:00:51] <grrrit-wm>	 (03PS3) 10Addshore: No longer require mainsnak when removing claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84958 
[10:02:01] <JeroenDeDauw>	 DanielK_WMDE_: the goal of the class should not be changed to suit its implementation. If you want to have the thing in a constructor, then introducing a second class as shown in the later examples is the way to gop
[10:02:03] <JeroenDeDauw>	 *go
[10:05:36] <DanielK_WMDE_>	 JeroenDeDauw: I was just pointing out an alternative. I still prefer to just pass the table as a parameter
[10:12:21] <grrrit-wm>	 (03PS1) 10Aude: Fix typo in exception and clean style in DataFieldValidator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84960 
[10:14:10] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix typo in exception and clean style in DataFieldValidator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84960 (owner: 10Aude)
[10:14:15] <aude>	 :)
[10:14:26] * aude  can't ignore typos

[10:14:33] <addshore>	 xD
[10:16:06] <Tobi_WMDE>	 aude: DanielK_WMDE_: denny: there are critical issues with the wmf18 branch, see my email
[10:16:12] <aude>	 :(
[10:17:31] <aude>	 i'll let DanielK_WMDE_ look at the parser function
[10:17:39] <aude>	 i can look at the other issue
[10:18:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix typo in exception and clean style in DataFieldValidator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84960 (owner: 10Aude)
[10:18:49] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Fix reference to constant after it got moved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84961 
[10:18:59] <JeroenDeDauw>	 Tobi_WMDE: aude: fixed ^
[10:19:03] <JeroenDeDauw>	 at least one thing
[10:19:12] <aude>	 JeroenDeDauw: ok :)
[10:46:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix in edit sitelinks selenium test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84963 (owner: 10Tobias Gritschacher)
[10:47:01] <aude>	 oh, i see Tobi_WMDE 
[10:47:06] <grrrit-wm>	 (03PS9) 10Daniel Kinzler: Factoring formatting logic out of Summary class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 
[10:47:18] <Tobi_WMDE>	 aude: yes?
[10:47:24] <aude>	 the object is not constructed yet at line 38
[10:47:44] <aude>	 so there is no $this ?
[10:47:50] <aude>	 errr
[10:48:09] <aude>	 i don't know where context gets set
[10:49:24] <aude>	 http://pastebin.com/UuDezesc
[10:49:39] <aude>	 DanielK_WMDE_: ^
[11:12:26] <Schisma___>	 cheers
[12:20:24] <DanielK_WMDE_>	 Lydia_WMDE: Rogue Farm by Charles Stross: https://www.youtube.com/watch?v=Z2wb2DQNJsk
[12:28:57] <aude>	 multichill: commonswiki
[12:29:07] <aude>	 like wikidatawiki
[12:29:17] <multichill>	 ok. Thank you aude, can I already play with it on test? :P
[13:14:35] <JeroenDeDauw>	 Lydia_WMDE: random?
[13:14:50] <JeroenDeDauw>	 Lydia_WMDE: also, y u no rage reply to my email?
[13:15:49] <Lydia_WMDE>	 JeroenDeDauw: why should i? :P
[13:15:53] <Lydia_WMDE>	 much more fun not to
[13:18:18] <JeroenDeDauw>	 Lydia_WMDE: :<0 evil Lydia
[13:19:22] <Lydia_WMDE>	 yes!
[13:19:27] <Lydia_WMDE>	 and proud of it
[13:19:29] <Lydia_WMDE>	 :P
[13:31:38] <pragunbhutani>	 aude: no wonder I couldn't see any familiar names :p
[13:31:44] <aude>	 heh
[13:31:51] * aude  does that sometimes

[13:32:12] <pragunbhutani>	 so do you think it would be a good idea to include query fastclick?
[13:32:21] <pragunbhutani>	 *jquery
[13:32:39] <aude>	 it might be okay to use the plugin, but difficult for me to judge
[13:32:46] <aude>	 it's small
[13:33:14] <aude>	 i don't know if it's implemented well
[13:33:35] <pragunbhutani>	 it's about 2.24 kb
[13:33:41] <pragunbhutani>	 should be even lesser when minified
[13:34:00] <aude>	 another important thing to check is the license
[13:34:09] <aude>	 it has license MIT which is okay
[13:34:40] <pragunbhutani>	 yep
[13:34:51] <pragunbhutani>	 jquery seems to be a little laggy on mobile phones
[13:34:53] <aude>	 and, as with anything, has to pass code review (e.g. security)
[13:34:54] <pragunbhutani>	 especially android
[13:35:05] <aude>	 but its small so should be easy to review
[13:35:13] <aude>	 i'd say okay to try it
[13:35:37] <pragunbhutani>	 yep I'll give it a go
[13:35:45] <pragunbhutani>	 also, when trying to access the OutputPage object
[13:36:21] <pragunbhutani>	 do I need to first initialize a IContextSource object and then get to the output through that?
[13:36:33] <aude>	 skin derives from context
[13:36:55] <aude>	 follow the chain to see what skin mobile extends
[13:37:08] <aude>	 and so on, you will get to Skin and context
[13:37:34] <aude>	 so wikibase skin (whatever it's called) can do everything that context can do
[13:38:07] <aude>	 about the jquery thing, you can also ask jon
[13:38:29] <aude>	 but if for some reason it doesn't work, it seems easy to swap out
[13:38:33] <pragunbhutani>	 ah okay
[13:38:47] <pragunbhutani>	 so I can straightaway go for $this->getOutput()
[13:38:52] <aude>	 pragunbhutani: yes
[13:44:33] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 
[13:44:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 (owner: 10Daniel Kinzler)
[13:46:47] <pragunbhutani>	 aude: so once I do http://pastebin.com/FQkEz2Bg
[13:46:55] <pragunbhutani>	 I have an entity object with me
[13:47:30] <aude>	 newFromSerialization doesn't look right
[13:47:41] <aude>	 you need the entity serializer class
[13:48:32] <pragunbhutani>	 oh silly me, yes
[13:48:41] <pragunbhutani>	 I'll initialize an object of that class
[13:48:45] <grrrit-wm>	 (03PS1) 10Henning Snater: Included item namespace and language code in repo_url [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84976 
[13:48:45] <pragunbhutani>	 and call the function through it
[13:48:49] <aude>	 yep
[13:50:35] <pragunbhutani>	 I don't see a contructor
[13:50:55] <pragunbhutani>	 would simply $unSerilizer = new EntitySerializer(); work?
[13:54:30] <aude>	 does entity serializer have no constructor?
[13:54:52] <aude>	 also we'd want to use the appropriate serializer subclass (e.g. if it's an item or property)
[13:54:56] <pragunbhutani>	 aude: oh sorry, it does
[13:55:04] <aude>	 otherwise, it will fail to unserialize sitelinks
[13:56:41] <pragunbhutani>	 is there a method to find out if our entity is an item or property before it has been unserialized?
[14:00:45] <aude>	 errrr
[14:01:04] <aude>	 there are number of ways
[14:02:16] <aude>	 the title knows about content model
[14:02:31] <aude>	 and the output page can getTitle()
[14:02:37] <aude>	 i'm not sure that's best
[14:04:26] <pragunbhutani>	 the URL does too
[14:04:36] <aude>	 not necessarily
[14:17:17] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 
[14:17:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler)
[15:01:12] <Schisma>	 do you think i can change that proposal to use the url data type?
[15:01:12] <Schisma>	 https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#full_text_available_at_.28en.29_.2F_Vollst.C3.A4ndiger_Text_verf.C3.BCgbar_bei_.28de.29_.2F_.D0.BF.D0.BE.D0.BB.D0.BD.D1.8B.D0.B9_.D1.82.D0.B5.D0.BA.D1.81.D1.82_.D0.B4.D0.BE.D1.81.D1.82.D1.83.D0.BF.D0.B5.D0.BD_.D0.BD.D0.B0_.28ru.29_.2F_Volledige_tekst_beschikbaar_op_.28nl.29
[15:20:14] <JeroenDeDauw>	 http://stackoverflow.com/questions/18894433/nodejs-child-process-working-directory epic facepalm :)
[16:04:18] <travis-ci>	 [travis-ci] JeroenDeDauw/WikidataBuilder#15 (master - 417b8c4 : jeroendedauw): The build passed.
[16:04:18] <travis-ci>	 [travis-ci] Change view : https://github.com/JeroenDeDauw/WikidataBuilder/compare/75cdad4b70bf...417b8c46dd78
[16:04:18] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikidataBuilder/builds/11557792
[16:10:00] <travis-ci>	 [travis-ci] JeroenDeDauw/WikidataBuilder#16 (master - 83f9974 : jeroendedauw): The build failed.
[16:16:48] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "@Liangent: please let's not discuss this here on gerrit on this change. There should be a bug on bugzilla about language tags, let's discu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84984 (owner: 10Henning Snater)
[16:20:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Display entity id next to entity label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84984 (owner: 10Henning Snater)
[16:31:26] <JeroenDeDauw>	 OMNOMNOM http://www.lieferando.de/lieferservice-world-of-pizza-berlin#!
[16:38:20] * ^d  raises hand

[16:38:26] <^d>	 I have a question.
[16:38:27] <aude>	 hi
[16:38:32] <^d>	 Hi aude :)
[16:38:46] <lazowik>	 hello!
[16:39:20] <^d>	 aude: So, magical search future. Wanna turn it on for testwikidatawiki and see what breaks?
[16:39:37] <aude>	 yes we do :)
[16:39:42] <aude>	 it's the perfect candidate
[17:00:44] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 
[17:05:09] <aude>	 DanielK_WMDE_: are you reviewing?
[17:06:15] <travis-ci>	 [travis-ci] JeroenDeDauw/WikidataBuilder#20 (master - 827acf9 : jeroendedauw): The build is still failing.
[17:06:15] <travis-ci>	 [travis-ci] Change view : https://github.com/JeroenDeDauw/WikidataBuilder/compare/b19f72aa219f...827acf974556
[17:06:15] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikidataBuilder/builds/11560364
[17:10:30] <travis-ci>	 [travis-ci] JeroenDeDauw/WikidataBuilder#21 (master - 6124855 : jeroendedauw): The build is still failing.
[17:10:30] <travis-ci>	 [travis-ci] Change view : https://github.com/JeroenDeDauw/WikidataBuilder/compare/827acf974556...612485503dca
[17:10:30] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikidataBuilder/builds/11560500
[20:20:53] <Sven_Manguard>	 if this is something that you can hand off, I'd love to stick svenbot on it
[20:20:59] <Sven_Manguard>	 if not, legobot is fine
[20:21:09] <legoktm>	 https://de.wikipedia.org/w/index.php?title=Portal_%28Computerspiel%29&action=edit <-- says PEGI is 12+
[20:21:25] <legoktm>	 also, ew that font
[20:21:36] <Sven_Manguard>	 legoktm: https://www.wikidata.org/wiki/Q14915515
[20:21:50] <legoktm>	 so 12 == 12+?
[20:21:51] <legoktm>	 ok
[20:21:55] <Sven_Manguard>	 yeah
[20:22:24] <Sven_Manguard>	 if I did 12+ it'd be problematic seperating that 12+ from USK's 12 or Taiwan's 12 or Brazil's 12
[20:22:38] <Dispenser>	 So I'm reading about Wilson score interval.  Is it allowed to make a WMA voting property or view counts?
[20:23:30] <legoktm>	 Dispenser: what's WMA?
[20:23:38] <Dispenser>	 WikiMiniAtlas
[20:26:12] <Dispenser>	 http://toolserver.org/~wikiminiatlas/iframe.html?wma=0_0_0_0_commons_2
[20:26:35] <Dispenser>	 A vote count for an image
[20:27:10] <Dispenser>	 A view count (like grok.se) would work too
[20:29:59] <legoktm>	 oh wow
[20:30:21] <legoktm>	 sounds good to me
[20:30:37] <legoktm>	 Dispenser: you can add a new request at https://www.wikidata.org/wiki/Wikidata:Property_proposal/Unsorted