[01:11:31] hm, seems that we got dexbot doing some viwikivoyage stuff [01:13:03] rschen7754: it was asked for in the channel earlier [01:13:10] yay' [01:13:18] meanwhile, rschen7754, how *do* we 'fix this' [01:13:27] commons? [01:13:30] Yeah [01:13:43] well, it seems that we've started to have local discussions [01:13:46] I think we need a proposal to take to people and say "your options are Yes or No" [01:13:54] rschen7754: where? [01:13:57] well, it seems that there's 2 proposals [01:14:02] rschen7754: where? [01:14:13] https://www.wikidata.org/wiki/Wikidata:Wikimedia_Commons [01:15:01] ah [01:15:26] damn, I don't see discussion [01:15:33] I see someone made a decision [01:15:59] that's hopefully the right one, because without a discussion... the decision is happening [01:16:01] the VP of commons has more [01:16:34] where do i go vote? [01:16:36] i mean [01:16:39] !!vote [01:17:14] https://www.wikidata.org/wiki/Wikidata:Wikimedia_Commons#Ambassadors [01:17:19] Sven_Manguard: go put your name down! [01:17:47] multichill should automatically be volunteered too i think [01:21:45] perhaps when we introduce a new project, we need to go through and ask certain questions [01:21:49] who are the ambassadors? [01:21:55] who's gonna run the bots? [01:22:04] do existing bots need to be shut down? [01:22:09] what's the mapping to existing items? [01:22:14] do new items need to be made? [01:22:16] etc. [01:22:43] Yeah [01:22:57] because we're gonna have 6-7 more launches [01:23:11] I dropped the ball figuring that other people would step in for the Commons launch [01:23:20] I never bothered to keep track of the progress [01:23:26] and so didn't see there was none [01:23:26] and i know this is gonna offend people, but they're all for projects that people care about much less than wikipedia, commons, and wikivoyage [01:24:18] rschen7754: I am actually against Wikinews *existing* and while I won't work against it, if it comes to Wikidata I won't touch it at all [01:24:23] so the apathy level's gonna be high [01:25:11] rschen7754: all the more important that we approach the other projects pre-launch [01:25:31] yeah, i should have paid more attention… we were cutting it kinda close with wikivoyage [01:33:12] https://www.wikidata.org/wiki/Wikidata:Sister_projects [01:33:18] feel free to add more questions [03:14:12] aude: by chance are you awake? [03:15:27] didn't think so. When you wake up and get this aude, I'd love to speak with you about bot code [04:47:51] (03PS6) 10Nilesh: Final wikiparser mapper and reducer modules using classes. Added more docs. Reduced and polished code. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 [06:52:56] (03PS1) 10Nilesh: Small changes to fix some stuff breaking during test on server. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85957 [06:55:26] (03CR) 10Nilesh: "Daniel, please check this change and merge it. no big modifications here. Merging this will result in a smoothly running backend. (It was " [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85957 (owner: 10Nilesh) [07:58:41] when I want to add a "coat of arms image" I do not get the necessary input field [07:58:49] it is really annoying [08:06:08] where can I report potential interwiki conflicts? [09:24:43] GerardM: can't you add more fields to the coat of arms template ? [09:27:01] hashar ? [09:27:21] what I am adding is only the image of the coat of arms [09:28:13] my objective is to have a continuous list of all the grandmasters of the Knights Templar [09:28:31] I only know that these people have a coat of arms [09:31:53] no clue sorry GerardM :D [10:24:23] Denny_WMDE: kennst du die? http://www.opendatacity.de/portfolio/ [10:24:44] das ist der da http://re-publica.de/users/michaelkreil [10:25:44] auf dieser seite steht der johl auch drauf :) [10:26:45] :P [10:34:17] (03CR) 10Daniel Kinzler: "No way for me to test this, I havn't touched servlets since 2006 or so... I'll just merge it." [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85957 (owner: 10Nilesh) [10:34:39] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Small changes to fix some stuff breaking during test on server. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85957 (owner: 10Nilesh) [10:35:24] question for the WDians. With the new interwiki link for Commons, is that meant to replace Commonscat type link? [10:35:58] opr should the cat and interwiki be added? [10:36:03] or [10:46:43] sDrewth: where do you mean exactly? [10:52:21] (03CR) 10Daniel Kinzler: [C: 04-1] "(4 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 (owner: 10Nilesh) [10:55:57] hi Lydia_WMDE ... https://www.wikidata.org/wiki/Q5527395 [10:56:17] I added the cat as Wikimedia Commons page linked to this item [10:56:30] previously it was "Commons category" property [10:56:39] right [10:56:46] there is ongoing discussion about this [10:56:52] and what pages on commons to link [10:57:13] * sDrewth hates main ns pages at Commons in general [11:00:19] sDrewth: join the discussion [11:00:50] I have moved away from wiki-politics [11:01:27] sDrewth: very wise [12:18:30] (03CR) 10Tobias Gritschacher: [C: 032] Introducing DispatchingValueFormatter and OutputFormatValueFormatterFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84768 (owner: 10Daniel Kinzler) [12:23:07] (03Merged) 10jenkins-bot: Introducing DispatchingValueFormatter and OutputFormatValueFormatterFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84768 (owner: 10Daniel Kinzler) [12:23:56] thanks Tobi_WMDE! [12:28:13] DanielK_WMDE: with https://gerrit.wikimedia.org/r/#/c/84313/ the properties are not shown as links anymore in History and RecentChanges [12:30:26] e.g. now the autosummary looks like "Created claim: P479: Vienna" where it was before "Created claim: Property:P479: Vienna" while "Property:P479" was linking to the Property [12:30:33] ugh [12:30:38] this functionality seems to be gone now [12:31:13] didn't he remove formatting from summary [12:31:22] where is it supposed to format now? [12:31:51] (03PS5) 10Tobias Gritschacher: Remove formmating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [12:32:38] aude: no, i just factored it out and made it use the formatter classes instead of special case code. [12:33:11] Tobi_WMDE: hm... i'm always confused about when and where the comments are formatted [12:33:27] Tobi_WMDE: some formattign is doen when generating the comment, some is done when displaying it... [12:34:02] Tobi_WMDE: can you see the difference in the comment as it gets written to the database? [12:34:40] DanielK_WMDE: I know. and I guess some of the formatting logic requires to be the property in form "Property:P479" while it was changed to "P479" by this change [12:36:42] Tobi_WMDE: hm... I guess we want a EntityIdTitleFormatter and an EntityIdWikiLinkFormatter for this, then [12:37:04] DanielK_WMDE: hm, maybe.. :) [12:37:11] actually, being able to inject special purpose formatters to be used in different contexts is somethign that isn't fully supported yet [12:37:29] https://www.wikidata.org/wiki/Q1519081 [12:41:10] (03CR) 10Daniel Kinzler: [C: 04-1] "[14:28] DanielK_WMDE: with https://gerrit.wikimedia.org/r/#/c/84313/ the properties are not shown as links anymore in History " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [13:40:06] aude: what do I need to get commons into my sites table? [13:40:27] what secret option of the script does the trick? [13:41:43] Tobi_WMDE: use the populate sites script [13:41:49] that populates *all* the sites [13:42:02] if you want site identifiers (e.g. local interwikis), then use --site-group wikipedia [13:42:50] aude: oh, I have it already [13:42:56] yes [13:43:02] just misspelled the group [13:43:06] ok [13:44:49] (03CR) 10Tobias Gritschacher: "With this change the properties are not shown as links anymore in History and RecentChanges." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [14:02:04] (03CR) 10Nilesh: "Yes, it's running the master branch. I'm setting this up now, training the full datasets from an old data dump and will follow up after th" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85957 (owner: 10Nilesh) [14:10:09] (03CR) 10Nilesh: "(4 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 (owner: 10Nilesh) [14:19:13] DanielK_WMDE: Hi! May I as you a question in order to improve https://www.wikidata.org/wiki/Wikidata:Wikisource ? [14:19:30] *ask [14:19:42] Do you think it'll be possible to support oldwikisource (//wikisource.org) in the same list of links in the item UI as the others Wikisource, by using the "mul" languages code (and with the alias "old")? [14:22:44] Tpt_: i'd like to have support for "mul" in several places, but it's not trivial. see https://bugzilla.wikimedia.org/show_bug.cgi?id=41807 [14:23:11] Tpt_: as to improvements: suggestions and comments should go to the talk page. if you just want to fix spelling, links or syntax, go right ahead. [14:23:45] OK. Thanks :-) [14:26:27] (I've updated the proposal because it looks like there is a consensus for "mil") [14:26:39] * "mul", sorry [14:35:37] addshore: http://pastebin.com/XeB4M1p4 [14:35:44] output of action=wbeditentity [14:36:08] again, I'm feeding the external serialized form to the api [14:36:14] DanielK_WMDE: ^ [14:36:23] why there is Add link on file pages? [14:36:26] on commons :/ [14:36:55] https://commons.wikimedia.org/wiki/Commons:Village_pump#Wikidata is here! [14:38:16] Steinsplitter: the add links is going away entirely [14:38:25] liangent: addshore worked on making this work, but i don't think that has been deployed yet. [14:38:28] since the widget does not work properly on commons yet [14:38:45] when we re-enable the widget, i think we can exclude file namespace [14:39:01] liangent: addshore is on vacation until next week, try to mail him about it. or just file a bug [14:39:17] aude: ok, can you respond to the question onwiki? [14:39:21] DanielK_WMDE: so no existing bug / feature request? [14:39:49] let me check [14:39:50] DanielK_WMDE: and btw, can't we just unserialize the input, then save? [14:39:54] in overwrite mode [14:40:01] woah, lots of discussion on the village pump [14:40:55] Steinsplitter: i might let Lydia_WMDE answer there [14:41:01] ok :) [14:41:06] liangent: it'S not that easy considering we need to generate a comment, resolve edit conflicts, and (in the future) check different permissions for different bits of the item being changed [14:41:14] but can poke about the config change to remove the add links [14:41:25] i suppose we could diff the new item against the old, generate changeops from the diffops, and then use that... [14:41:42] but that would mean different code pathes for override vs patch [14:41:45] aude: if you like i can creat a bugreport about the links? [14:41:47] *addlinks [14:42:04] we might have one already [14:42:07] not sure [14:42:13] liangent: https://bugzilla.wikimedia.org/show_bug.cgi?id=54267 [14:42:28] liangent: i'm sure addshore worked on that, but there are no lonked changes [14:42:31] best ask him about it [14:42:36] Steinsplitter: https://bugzilla.wikimedia.org/show_bug.cgi?id=54497 [14:42:37] *linked [14:42:40] that's about the widget [14:42:48] DanielK_WMDE: only the last reason looks valid for me [14:42:49] thx, aude [14:42:53] if you want to make one about the file namespace, we don't have a bug for that [14:43:05] comments for overwrites say nothing useful currently [14:43:32] and for bots, automerge on editconflicts is not something important [14:44:53] DanielK_WMDE: and , "property" ? [14:45:04] should I just rename claims to property to workaround it now? [14:45:26] liangent: no, it's not just the key, there's a structural difference. [14:45:39] (03PS1) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [14:45:50] liangent: inder , claims are gouped by property, whereas in , they are ungrouped [14:45:53] *under [14:46:27] DanielK_WMDE: aude: Denny_WMDE: that would be a quickfix for the sitename-issue with commons and other special site groups: https://gerrit.wikimedia.org/r/#/c/85982/ [14:46:55] Tobi_WMDE: the message would be better in the wikimedia messages extension [14:47:30] that's where the messages for the site group headings are [14:47:46] aude: ok, what would be the key there? [14:48:09] Tobi_WMDE: the key is same, just needs to go not in wikibase [14:48:17] liangent: https://gerrit.wikimedia.org/r/#/c/84962/ fixes this [14:48:18] DanielK_WMDE: some other point: if you insist in overwrite-as-patch-against-new, and when "(in the future) check different permissions for different bits of the item being changed", [14:48:25] https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikimediaMessages [14:48:35] aude: ah, you mean I should add the message there.. [14:48:36] ok [14:48:38] yeah [14:48:41] passing wbgetentities output back shouldn't be considered a change of anything [14:48:53] liangent: i agree [14:48:53] we define the site groups in a setting [14:49:01] wikibase does not know about commons site group [14:49:06] that means you still need to do diff [14:50:06] Tobi_WMDE: i also expect some magic is needed to invalidate resource loader cache [14:50:22] not sure exactly what/how [14:50:28] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:50:49] aude: we might to base the message on the globalid rather than on the group [14:50:49] anyway, nobody besides me uses wbeditentity? [14:51:11] because probably all the "special" sites go into the same group [14:51:49] specialSiteLinkGroups is a new setting? [14:51:52] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:52:17] liangent: as i suspected: the fix is in master, but not yet deployed. [14:53:07] DanielK_WMDE: I mean, why is it always me who see these issues? [14:53:10] about wbeditentity [14:53:12] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:54:17] liangent: because you expect it to behave in a logical way, instead of just fiddeling until it does what you want. [14:54:30] aude: yes, it's a new setting [14:54:53] Tobi_WMDE: i am also concerned about the affect on the javascript stuff [14:55:04] if we want to make the list of sites with that special handling configurable then it's probably the best way [14:55:08] how is language name used? [14:55:13] * aude needs to look at the code [14:55:33] Tobi_WMDE: a setting seems fine [14:55:43] aude: it is used for display inside the dropdown [14:55:45] but it should have a default [14:55:48] an empty array [14:58:00] (03CR) 10Daniel Kinzler: [C: 04-1] "CR -1 as per tobi's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [15:00:01] (03PS2) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [15:01:44] aude: added [15:01:56] Tobi_WMDE: ok [15:01:59] * aude reviewing [15:02:23] aude: so I'll remove the messages from wikibase and add them to the WikimediaMessages extension, right? [15:02:30] yes [15:02:47] you can see how we handle the h2 message [15:03:23] might not be done in a totally ideal way but at least having both these things consistent is helpful [15:03:55] aude: should we make the message based on the group name or the globalid? [15:04:03] global id [15:04:03] aude: I mean the message key.. [15:04:08] ok [15:04:11] it's for the specific site [15:10:07] (03PS3) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [15:13:40] aude: https://gerrit.wikimedia.org/r/#/c/85986/ [15:13:58] Tobi_WMDE: ok [15:20:08] DanielK_WMDE: calling Title an Active Record might be doing unjustice to that pattern ;p Sure it is doing what active records do, though it is also doing a crapton of other stuff, and the fields dont nicely match the table [15:25:38] aude: did you have a commit to submit for the builder thing already? [15:27:01] JeroenDeDauw: nope, but almost [15:27:12] where do we want it on gerrit? [15:29:02] Tobi_WMDE: "Wikimedia Commons" line wraps in the UI [15:29:30] although "Wikimedia Commons" is more correct and complete, would "Commons" be okay? [15:29:36] Denny_WMDE: ^ opinion? [15:29:54] aude: yeah.. know. is an issue with other long language names too [15:30:05] just "Commons" should be sufficient [15:30:07] probably Henning_WMDE knows [15:30:14] or use a   [15:30:33] suppose it's better than "English" :) [15:30:34] but I think I'd prefer "Commons" [15:30:37] aye [15:30:55] it already says "Wikimedia Commons pages linked to this item" above [15:31:05] so think it's obvious [15:31:24] aye [15:31:30] ^^ [15:31:39] if it says "language" then actually "none" or "-" is also fine, I guess [15:31:41] aude: WikidataBuilder.git will do for now. (Does not exist yet). Not sure in which directory to best put this. /extensions is clearly not good [15:31:45] or will "language" be changed to project [15:31:55] aude: The result of the build can go in extensions/Wikidata.git, which already exists [15:32:03] JeroenDeDauw: okay [15:32:10] Though we d o not need to bother with that one for now yet, as the build tool is not done [15:32:21] i am just making more task(s) that create the branch [15:32:24] short q: why (English) Commons on thze wikidata base? :/ we hav de, it, es etc? [15:32:28] JeroenDeDauw: it's a hyperactive record :) [15:32:44] DanielK_WMDE: :D [15:33:09] DanielK_WMDE: we should write a "Design" Patterns of MediaWiki book ;p [15:33:40] Tobi_WMDE: can we change the column heading from "Language" to "Site" ? [15:33:43] aude: what should the table column heading say for these groups? [15:33:48] "Site" [15:33:49] :) [15:33:53] ok [15:33:54] or "Site name" [15:33:58] almost finished [15:34:03] ok [15:34:20] as far as editing with the js, works fine [15:34:39] Steinsplitter: what? [15:35:42] oh, i see the problem is fixed now :D :) [15:36:26] (Base: do you hav time to help on commons with the Translate Extension? Categoryzation dos not work?) [15:36:35] Steinsplitter: good :) [15:36:49] Steinsplitter: what do you mean by not work? [15:39:26] Base: https://commons.wikimedia.org/wiki/Category:Commons_policies moving cat:Commons:Project scope/Evidence/hu to cat:Commons policies/hu‎ [15:39:30] etc. [15:40:18] ah langcat [15:40:22] jepp^^ :DE [15:40:45] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/85986/ [15:40:50] is it saved? a weird guy wanted langcat to be deleted [15:41:24] omg O_O [15:42:07] https://commons.wikimedia.org/wiki/Commons:Deletion_requests/Template:Langcat [15:42:18] hopefuly it was kept [15:42:18] omg. but was keept. [15:43:06] Tobi_WMDE: i see that the sites module has "name" and "shortName" [15:43:16] could "Commons" go in "shortName" ? [15:43:30] * DanielK_WMDE wonders if there's a Template:Longcat to completement Template:Langcat [15:43:40] :D [15:43:42] kwj2772: ping, see above. why? [15:43:48] aude: don't know [15:43:57] I'm not sure of this is used [15:44:26] don't know if it's used [15:44:43] seems suitable for listing stuff in that column in the UI [15:44:52] aude: ok putting "Site" instead of "language" into the table header is easy for the "static" dom, but it's hard to do in javascript.. [15:44:53] but doesn't need to be done in this patch [15:45:03] hmmmm [15:46:03] (03PS4) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [15:46:03] aude: new patch up which solves it for the static site [15:46:46] aude: I'm not sure how to do it for the JS side, as we have no information whether a group is "special" [15:47:00] and passing the setting seems very hackish to me [15:48:24] Tobi_WMDE: having groupname available in the th css class ? [15:48:40] wb-sitelinks-sitename wb-sitelinks-sitename-commons headerSort [15:48:49] doable? [15:48:57] aude: the groupname is not a problem [15:49:08] but the information whether that group is special [15:49:15] or wb-sitelinks-sitename-special [15:49:57] aude: but if there is no sitelink yet, there is also no tableheader [15:50:01] i'm not sure how else to od [15:50:15] the template gets constructed in JS [15:50:22] oh [15:50:32] and we would need the information there [15:50:42] but the table is there [15:50:51] wb-sitelinks [15:51:00] aude: hm, the table is, but I guess it gets replaced [15:51:06] no ide [15:51:07] a [15:51:31] aude: I'll have a look [15:51:35] ok [15:52:02] Base: conflicts with the schema i see :/ [15:52:29] Steinsplitter: what schema ? [15:53:53] Tobi_WMDE: testCallbackComparisonReturningNyanCat... why do I get the impression you copied some of my tests? ;p [15:54:46] Tobi_WMDE: can haz +2 https://gerrit.wikimedia.org/r/#/c/85861/ ? [15:54:54] Tobi_WMDE: Then I can do the same for your change [15:55:04] (03CR) 10Jeroen De Dauw: (bug 54319) Introduce order-aware array comparer [extensions/Diff] - 10https://gerrit.wikimedia.org/r/85845 (owner: 10Tobias Gritschacher) [15:55:22] JeroenDeDauw: hm, I thought I +2 already.. [15:55:23] ok [15:55:47] (03CR) 10Tobias Gritschacher: [C: 032] Improve names, fix version number and update rel notes [extensions/Diff] - 10https://gerrit.wikimedia.org/r/85861 (owner: 10Jeroen De Dauw) [15:56:00] (03CR) 10Jeroen De Dauw: [C: 032] (bug 54319) Introduce order-aware array comparer [extensions/Diff] - 10https://gerrit.wikimedia.org/r/85845 (owner: 10Tobias Gritschacher) [15:56:07] (03Merged) 10jenkins-bot: Improve names, fix version number and update rel notes [extensions/Diff] - 10https://gerrit.wikimedia.org/r/85861 (owner: 10Jeroen De Dauw) [15:56:07] more nyan cat! [15:56:23] aude: it's complicated [15:56:30] will look into it again tomorrow [15:56:35] Tobi_WMDE: ok [15:56:43] it's the last remining issue [15:56:49] yeah [15:56:51] aude: just wait till we are in the new office. There will be ALL of the nyancat [15:56:55] Base: e.g. "Commons Richtlinien" for Gernan [15:56:58] *German [15:56:58] :D [15:57:38] ah yeah. that what a guy who wanted template to be deleted actually wanted [15:58:13] but same as pages now english/code categories should be named this way as well [15:58:40] we schold keep the acually cat schema. [15:58:46] imho [15:59:18] Steinsplitter: current schema is further from perfect [15:59:38] aude: I gave you push access to the builder repo on github, feel free to already push there if that is more convenient [16:00:13] Base: yes. but i think the communy will keep the actually schema :/:/ [16:01:22] its not about cat but just as an example - usual name for uk project's main page is Головна сторінка. In rue it's the same. So in meta rue and uk main pages are Головна сторінка/rue and Головна сторінка/uk - thats silly - better to name all with english base [16:03:23] (03PS7) 10Nilesh: Final wikiparser mapper and reducer modules using classes. Added more docs. Reduced and polished code. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 [16:03:40] also it's very complicated to use current schema with the extension - the easiest way imo is to make category's name translateble but in this case you never know what category a translator will put page in - same phrase can be translated several ways in many languages so translators may produce duplicates of categories of the same purpose in the same language [16:04:01] :-( [16:04:11] aude: scrap that, access revoked, this makes more sense https://github.com/Wikidata/WikidataBuilder [16:04:39] curenntly the extension breaks the schema. german pages in english cats etc. [16:04:41] hmmmm [16:04:45] :-( [16:04:48] anyther way is to keep 200+ localized names for each translatable category in some monster-like templages with switch - but who will be the one who will maintain these templates [16:04:50] @Base [16:05:06] jepp :/ [16:05:20] but we need communety consens to change the structure o the categorys [16:05:27] i think [16:05:44] or just go ahead as we done with pages which had localised names as well [16:06:10] hmmm.... [16:06:18] here is the diff that unlike pages we cant set visible title for categories [16:06:24] i dos not inoe [16:06:25] *know [16:07:04] but its same thing that we need to do to use best compatable with extension way [16:07:17] i know [16:09:51] (03PS1) 10Nilesh: Fixed a small doc mistake in the index.jsp file with the howMany parameter. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85995 [16:12:08] DanielK_WMDE: y u no review https://gerrit.wikimedia.org/r/85527 ? [16:26:29] (03PS2) 10Nilesh: Fixed howMany in index.jsp and made clickable links [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85995 [16:33:50] (03CR) 10Daniel Kinzler: [C: 032] Update DataType definition to match what we currently want it to be [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/85527 (owner: 10Jeroen De Dauw) [16:33:58] (03Merged) 10jenkins-bot: Update DataType definition to match what we currently want it to be [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/85527 (owner: 10Jeroen De Dauw) [16:34:44] (03CR) 10Daniel Kinzler: [C: 032] Match DataType updating in DataTypes component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85528 (owner: 10Jeroen De Dauw) [16:37:59] (03Merged) 10jenkins-bot: Match DataType updating in DataTypes component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85528 (owner: 10Jeroen De Dauw) [16:49:52] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [16:53:48] (03PS16) 10Daniel Kinzler: Factoring formatting logic out of Summary class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [16:55:21] (03PS17) 10Daniel Kinzler: Factoring formatting logic out of Summary class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [16:56:48] (03CR) 10Daniel Kinzler: "@tobi: PS 16 should fix the issue, so that properties are again represented as Property:P1234. It *should*, I haven't verified. Give it a " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [16:57:09] (03PS7) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 [16:57:13] (03PS7) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 [16:57:17] (03PS6) 10Daniel Kinzler: Remove formmating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 [17:18:19] (03PS4) 10Daniel Kinzler: Make QuantityValue use decimal notation [DNM]. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 [17:18:37] (03CR) 10jenkins-bot: [V: 04-1] Make QuantityValue use decimal notation [DNM]. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84016 (owner: 10Daniel Kinzler) [17:25:37] aude: there? [17:28:29] hi pragunbhutani [17:29:21] my repo on github is up to date [17:29:27] ok [17:29:27] I haven't been able to access my ssh config [17:29:29] I'm on a mac [17:29:34] ok good [17:30:16] the issue with gerrit could be just for git push [17:30:47] Yes! I don't think I had any such errors any time I was trying to push a patch [17:31:01] did you try the ssh -v thing? [17:32:57] yep [17:32:59] no luck [17:34:26] hmmmm [17:35:16] i get "remote: To push into this reference you need 'Push' rights." [17:35:49] think that is unrelated [17:37:37] I get a huge wall of statuses when I try the ssh -v thing [17:38:37] (03PS8) 10Michał Łazowik: Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [17:39:04] pragunbhutani: that's fine [17:39:21] can you put it in pastebin or email the contents to me? [17:39:21] ultimately ending in a 'Authentication failed' [17:39:27] okay [17:39:49] also, what about git config --local -l [17:39:55] and git config --global -l [17:41:22] http://pastebin.com/VJxgRZay [17:41:37] ok [17:42:11] you know which key to use for gerrit? [17:42:13] and where it is? [17:42:31] do you have multiple keys in .ssh [17:43:49] I don't have multiple keys to use with gerrit [17:43:56] this is the same that I've been using for a while [17:43:58] multiple keys in general? [17:44:00] nope [17:44:03] oh [17:44:03] http://pastebin.com/XPFwBgKs [17:44:17] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [17:44:28] hmmm [17:44:41] maybe try making a new one and put new public key on gerrit? [17:44:45] * aude running out of ideas [17:45:03] I'll give that a shot [17:45:36] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibaseMobile/refs%2Fheads%2Fmaster [17:45:42] meanwhile, got it pushed [17:45:52] required fiddling with permissions [17:46:41] pragunbhutani: you can try cloning the extension from gerrit and making a test patch [17:46:46] with git-review [17:47:11] all right, I'll try it [17:47:21] hey ho! [17:47:27] hi [17:47:41] I've got a bit of internetz \o/ [17:47:49] :) [17:50:42] aude: didn't work! [17:50:57] fatal: The remote end hung up unexpectedly [17:51:20] try new key [17:51:24] call it something different [17:51:40] okay, will just do that [17:51:54] I'm just finishing up on the evaluation form on google-melange [17:51:58] ok [17:52:03] i need to do mine [17:52:35] this one is longer than the mid term! [17:52:46] a [17:52:46] wow [17:52:50] sorry [17:54:46] LOL at three last messages :D [18:06:10] pragunbhutani: i am going home.... back in ~ hour [18:06:18] aude: okay [18:06:30] I'll try using a different key and see if it works soon as I'm done with this form [18:06:46] with the new key, you may have to give gerrit some time for the key to "propagate" [18:06:52] and be recognized [18:08:43] okay [19:31:22] hmm [19:31:55] why in the 275th line of EntityTestHelper [19:31:58] there is $entityProps[ $prop ] = array( $entityOutput[ $prop ] ); ? [19:32:07] why array? [19:32:37] addshore: ^ any idea? [19:34:26] *looks* [19:34:55] addshore: and then in foreach there's $value = $value[0]; :D [19:35:34] the only reason I can think of is that maybe flattenArray from WikibaseApiTestCase needs that [19:35:40] (blind guess) [19:41:19] lazowik: that indeed looks very bizzarre [19:41:44] addshore: maybe some leftover? [19:42:06] I have about 2KiB/s of internetz now [19:42:13] can't do much :) [19:42:39] maybe history of file will tell something [19:42:54] heh, it only has 6 revisions ;p [19:43:14] :O [19:45:50] lazowik: not sure if php store is just messing upf or me but the test file for that class appears to be the same as the class itself... [19:46:49] lazowik: what is the path of the entitytesthelper for you? [19:47:49] addshore: repo/tests/phpunit/includes/api/EntityTestHelper.php [19:48:36] oh, wait, thats fine, I thought I was going mad for a second, for some reason I was looking for it in repo/includes/api/... [19:48:50] heh [19:59:11] addshore: can I left badges testing only in assertEntityPropsSitelinksBadges in GetEntitiesTest [19:59:47] and delete them in stripUnwantedOutputValues from the helper when comparing whole entities? [20:00:14] they cause problems with flattenArray [20:01:52] addshore: I think I'll do that [20:02:03] sitelinks/urls is ignored when comparing entities [20:02:29] (whole entities, it's tested separately) [20:05:29] yes it is ignored and tested seperatly :) [20:07:22] addshore: given I tend to do too much in one patch, I should probably extend getEntities tests for badges in separate one? ;) [20:09:34] yes ;p [20:15:58] mhhm [20:16:02] gerrit seems unresponsive for me :/ [20:16:43] addshore: sorry, can't check [20:16:51] for me everything us unresponsive :) [20:16:58] *is [20:17:02] (maybe apart from IRC) [20:17:26] even git review is painfully slow with that internet [20:17:52] :< [20:17:53] oh well [20:18:40] * lazowik has just run 'time git review -R' [20:18:45] let's see the result [20:21:22] (03PS9) 10Michał Łazowik: Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [20:21:33] addshore: 3m2.354s [20:26:03] nice and fast then :P [20:27:03] addshore: now got a bit faster [20:27:17] still waiting for my patch to push :P [20:27:34] but the router is far far away (don't even know where) so it can disconnect at any point [20:31:11] (03PS10) 10Michał Łazowik: Extend API to support editing badges [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [20:31:28] addshore: ^ ready for first review \o/ [20:31:44] (still a DNM though) [20:41:09] aude: still around? Do you know if it's already possible to have both wikitext and other content in the same page using contenthandler? [20:49:31] bye! [21:06:23] multichill: i doubt it [21:07:00] The docs talk about multipart, but it looks like that has not been implemented (yet) [21:07:10] *perhaps* with some evil hack and at your own risk [21:07:35] i am not aware of multipart but would be cool [21:08:32] otherwise, it would be possible to have categories on a MediaWiki:___.js page [21:09:36] Lydia_WMDE: Here? [21:10:11] Damn. She's away. [21:12:21] :( [21:17:52] <^d> aude: Hey, so if you're wanting to play around with elasticsearch it's actually pretty easy. What OS is your primary development machhine? [21:18:39] Do you have an instance on labs ^d? [21:20:03] <^d> Yeah, it's in the confusingly named solr project. [21:20:26] <^d> Hmm, setting it up as a general service for labs would be kind of cool though. [21:49:16] (03PS1) 10Addshore: Remove silly code from EntityTestHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/86036 [21:56:22] (03CR) 10Jeroen De Dauw: "What about Ctrl+A delete?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/86036 (owner: 10Addshore) [21:57:36] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/86036 (owner: 10Addshore) [22:01:23] Hehe [22:36:46] Abraham_WMDE: whaaaaaat! Denny his presentation is at 12:00?! [22:36:53] What nonsense is that>? [22:37:20] Abraham_WMDE: is this a presentation for the team or for the whole office? [22:40:19] JeroenDeDauw: for the team and the office [22:40:27] JeroenDeDauw: so be there [22:41:12] Abraham_WMDE: so I can make the whole office sick? Sure [22:41:44] JeroenDeDauw: if you are sick, than stay at home of course. [22:42:41] JeroenDeDauw: that means you will not be there in the evening too? [22:44:38] at all events, get well soon! [23:17:36] rschen7754: ping [23:17:40] hi [23:17:50] Is it okay for someone to be creating stubs with no sources at all? [23:17:53] on wikipedia? [23:18:19] well, it's frowned upon… but if it's plausibly notable, not grounds for an AFD [23:21:15] Sven_Manguard: you got an example? [23:21:26] https://en.wikipedia.org/wiki/O.Z.,_Colorado [23:21:37] I can find no source that backs that the place ever existed [23:22:13] inhabited places have presumptive notability [23:22:27] PROD it and see what happens [23:22:30] *if* they can be found