[00:32:34] legoktm: did you mess with claimit.py? [00:34:38] umm, never mind, you just handed a script to a luddite, that's the issue [00:51:31] * falloir is [02:02:40] (03PS3) 10Nilesh: Added PHP API module. Broken down into classes. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 [03:06:20] yes hello [09:00:47] Abraham_WMDE: aude Lydia_WMDE daily? :D [09:01:07] addshore: jep :) [09:01:11] about to start [09:01:20] do you want to join via hangout? [09:02:00] now [09:04:47] Im in the ahngout :O [09:04:50] *hangout [09:09:47] okay, maybe I was there and forgot to click join.... [09:09:50] how silly :) [09:10:01] :P [09:10:22] How silly to clikc a button to join a hangout and then have to click another button saying join! [09:15:44] addshore: the scripts on lab still don't pass it seems [09:16:51] indeed, still nothing made it to the map [09:17:37] i dont have time today to work on it, sorry [09:17:41] just wanted to point to it [09:17:59] Ill have a poke at it :) [09:20:44] Denny_WMDE: got some different errores this time ;p [09:20:58] different errors mean progress :) [09:21:02] care to share? [09:21:51] https://etherpad.wikimedia.org/p/addshore [09:22:05] I think this is two runs worth, just trying to find where it starts to repeat [09:22:18] heh FATAL ERROR: Malloced operator new Allocation failed - process out of memory [09:22:28] looks like it needs more than 4G [09:22:40] hi [09:22:40] but in which script? [09:22:47] also there is no mepoints.txt [09:22:51] that should be timepoints.txt [09:22:52] did I use the unknown valie in a correct way? https://www.wikidata.org/wiki/Q14947316 [09:22:56] something wrong there [09:23:08] the lake has no river, inflows or outflows [09:23:21] Schisma_: yes, that is correct [09:23:32] this "no value", by the way, not "unkown value" [09:23:40] "unknown value" is to be used for known unknowns [09:23:49] yes sorry ^^ [09:23:58] but fully correct as used :) [09:23:59] thanks! [09:24:03] also the lake has no wikipedia article [09:24:11] but it exits i swear [09:24:23] ^^ [09:24:42] :D no comment [09:25:01] Denny_WMDE: sort timepoints.txt > timeline.txt (forsomereason it misses the ti in the output) [09:25:44] yes, that looks good [09:26:02] it messes the "sort ti" if it thinks that mepoints is a command [09:31:51] I if i want to query wikidata for lakes, I want to find also lakes that have no wikipedia article i guess [09:35:45] I guess so. Notfiability criteria structural completeness, I think. IIRC [09:37:38] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "merging for experimentation" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84463 (owner: 10Nilesh) [09:39:47] Schisma_ finding ALL lakes is obvious because there is no one Wikipedia ... there are 180+ [09:39:51] 280+ [09:40:16] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Fixed howMany in index.jsp and made clickable links [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85995 (owner: 10Nilesh) [09:44:26] DanielK_WMDE: hey review my code :p [09:45:03] :) [09:46:39] review review review :> [09:47:14] tons of meetings and goodbyes today [09:47:24] probably won't have much time for concentrated work [09:47:28] will try, though [09:47:40] (conference tomorrow - oh, so much to code, so little time) [09:50:05] (03CR) 10Nilesh: "Oops, Daniel, I should have abandoned the topproperties stuff ie. this change and https://gerrit.wikimedia.org/r/77070. The wikiparserfina" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77146 (owner: 10Nilesh) [09:54:38] (03CR) 10Daniel Kinzler: [C: 04-1] "(4 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 (owner: 10Nilesh) [09:56:37] (03CR) 10Daniel Kinzler: [C: 031] Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [11:00:26] Lydia_WMDE: https://wikimedia.de/wiki/Software_Developer_%28f/m%29_focus_on_Frontend_Development_with_JavaScript -> fronend -> frontend [11:39:18] siebrand: thx [11:39:54] Lydia_WMDE: sure. Pointed someone to the opening, too. Is it a job in Berlin only? It's not clear from the text. [11:40:20] siebrand: depends on the candidate to some degree [11:40:26] thx for spreading it [11:40:30] Lydia_WMDE: k. Thanks. [11:41:50] (03CR) 10Daniel Kinzler: [C: 032] Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [11:42:29] \o/ [11:42:58] merge all the code! [11:43:19] (03CR) 10Addshore: [C: 04-1] "(6 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:44:05] Abraham_WMDE: http://semantic-media-web.de/programm/programm_fachtagung_2013/ [11:44:54] evil german thing! [11:45:28] (03Merged) 10jenkins-bot: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [11:52:53] (03CR) 10Daniel Kinzler: [C: 032] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [11:52:59] (03CR) 10jenkins-bot: [V: 04-1] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [11:55:06] (03CR) 10Addshore: [C: 04-1] "I got an exception when trying to use Special:SetLabel to set a label!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:56:12] DanielK_WMDE: for the stacktrace see http://grab.by/qCB2 [11:57:01] addshore: thanks [11:57:11] now to work out why javascript isnt working on master for me ... [11:58:36] (03PS33) 10Daniel Kinzler: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [11:59:16] (03CR) 10Daniel Kinzler: [C: 032] "PS 33 is a rebase fixing a merge conflict" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [12:01:13] DanielK_WMDE: also seems to be a recurring thing with special pages as it also happens when trying to create a new property :) [12:01:43] * aude wonder if the special pages have tests [12:01:47] or adequate tests [12:01:50] probably not [12:01:52] addshore: hm, so something was reyling on __toString there I guess... [12:02:03] aude: no :P [12:02:07] aude: not enough in any case. mostly selenium, i think [12:02:21] aude: the best thing to do would be to get all of the logic out of the special page itself :D [12:02:27] addshore: absolutely [12:02:44] which i guess we are sloooowly heading towards :D [12:02:50] yeah [12:04:03] (03CR) 10Addshore: [C: 04-1] "This is based on an abandoned change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [12:05:02] (03Merged) 10jenkins-bot: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [12:11:31] (03PS32) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [12:11:44] (03CR) 10Addshore: "PS32 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [12:13:03] hashar: I love you for all build jobs being able to run simultaneously now :D [12:13:16] oh really ? [12:13:22] are they? [12:13:46] well, all jobs within a single build are! :D [12:14:00] or appear to be [12:15:10] (03CR) 10jenkins-bot: [V: 04-1] Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [12:15:22] aude: hello [12:16:03] hi [12:16:10] (03PS5) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [12:16:36] pragunbhutani: did you get the ssh key working? [12:16:40] I tried working with a new keyu [12:16:49] no, no luck still! [12:17:00] hmmmm [12:17:02] why don't I keep uploading to github in the meanwhile? [12:17:06] this is taking too much time [12:17:10] pragunbhutani: that's fine [12:17:26] but can you try the ssh -v -i thing again [12:17:32] okay [12:17:35] -vv even [12:17:36] 04Error: Command “vv” not recognized. Please review and correct what you’ve written. [12:17:45] not you, AsimovBot. [12:17:48] how about ssh -v -i /Users/pragun/.ssh/gerrit [12:17:50] go back to sleep. [12:17:57] full path to the key [12:18:06] how about ssh -v -i /Users/pragun/.ssh/gerrit gerrit.wikimedia.org [12:18:13] errr [12:18:17] gerrit.pub [12:18:38] addshore: re sorry. [12:18:45] addshore: so we trigger jslint and lint in parallel. When php linting is successful, the 3 test jobs are triggered in parralel [12:19:03] i do ssh -v -i .ssh/gerrit aude@gerrit.wikimedia.org [12:19:10] or full path to my key] [12:19:15] no .pub when trying that [12:19:36] (03CR) 10jenkins-bot: [V: 04-1] (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [12:20:06] neither of them work! [12:20:15] strange [12:20:27] I uploaded the new key a couple of hours ago [12:20:32] maybe I need to wait a few hours? [12:20:38] the .pub key? [12:20:41] yes [12:20:47] huh [12:20:55] shouldn't take that long but who knows [12:21:02] do upload to github in mean time [12:21:08] yep [12:21:14] I'll tackle this again over the weekend [12:21:18] ok [12:21:45] can you look over https://github.com/pragunbhutani/WikibaseMobile/blob/master/WikibaseMobile.skin.php once? [12:22:01] ok [12:22:30] basically, I need to work on printing the statements now [12:22:42] the title, description and aliases should work [12:22:45] and find a place for the site links [12:22:57] although can be hard coded until data access works fully [12:23:15] i don't know how best to incorporate site links into the design [12:23:21] or use them [12:24:18] I'm actually going to look over the design once again once we've got the data-access figured [12:24:24] ok [12:24:31] (03PS6) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [12:24:32] this isn't pretty enough :p [12:24:38] working on statements is good too [12:24:53] and I'd like it to be more consistent with Mobile Frontent [12:24:58] *Frontend [12:25:14] yeah [12:25:21] and there are still performance issues [12:25:30] * aude nods [12:25:31] animations are laggy on android devices [12:25:51] I think I might have to consult with the mobile team [12:26:01] they might have encountered and solved something like this before [12:26:01] yeah [12:26:06] not really my expertise so much [12:26:24] but data-access comes first [12:26:36] yep [12:27:28] (03PS4) 10Tobias Gritschacher: (bug 54319) Show diff when order of snaks changed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85844 [12:27:58] can you explain a little about how that would work? [12:28:14] as in, how can I query them from the Entity object [12:28:22] and what kind of a data structure they are in [12:28:25] (03CR) 10jenkins-bot: [V: 04-1] (bug 54319) Show diff when order of snaks changed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85844 (owner: 10Tobias Gritschacher) [12:28:33] and the structure of a claim/statement object [12:31:00] (03PS18) 10Daniel Kinzler: Factoring formatting logic out of Summary class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [12:33:49] pragunbhutani: look at the api output for example [12:33:53] wbgetentities [12:34:01] and the code in WikibaseDataModel [12:34:16] probably better than i can explain it [12:35:13] we'll need to add "referenced" entity data for all the properties and items referenced in an entity in statements [12:35:29] to allow labels displayed instead of Q76 or whatever [12:35:40] hmm [12:36:06] so there's this function getClaims that I'm assuming returns an array of claim objects? [12:36:11] or it's ugly code ,but you can see what the entity view pulls in for statements [12:36:43] pragunbhutani: i think so [12:37:02] in some places, we use php ArrayObjects (or subclasses of that) [12:37:15] I'm a little confused. Are 'claims' and 'statements' the same thing? [12:38:19] statements are a bit more complex [12:38:23] items have them [12:38:44] entities can have claims [12:39:06] claims don't hve references, for example [12:39:08] so basically properties don't have any statements? [12:39:14] statements do [12:39:20] pragunbhutani: Statement is a subclass of Claim. Statements can have sources, Claims can't [12:39:35] properties don't have statements... true [12:39:40] but other kinds of entities might [12:39:46] hypothetically in the future [12:39:58] err can have lcaims [12:40:00] aude, pragunbhutani: In the data model and also in the php code, properties can have claims. [12:40:00] claims [12:40:09] DanielK_WMDE: ah yes [12:40:17] but not statements [12:40:51] aude: they could. Statement is a subclass of claim. there's nothing preventing a Property from containing statements [12:41:07] we just don't support adding claims to Properties via the UI at the moment. it might even be possible to add them via editentity [12:41:11] addshore: ---^ ? [12:41:25] DanielK_WMDE: oooh [12:41:28] really? [12:41:36] okay, so for example in https://www.wikidata.org/wiki/Q989 [12:41:36] suppose so [12:41:40] not sure that there's anything preventing this [12:41:40] mhhhm, i think it might be now technically [12:41:46] :P [12:41:47] oooh [12:41:49] 'sex' is a claim and 'male' is a statement? [12:41:54] pragunbhutani: no. [12:42:11] pragunbhutani: "sex" is a property, "sex: mal" is a minimal claim or statement. [12:42:23] "male" is a value [12:42:29] hmm [12:42:31] okay [12:42:33] reference to the wikidata item for "male" [12:42:37] pragunbhutani: "sex: male (according to X)" is a statement [12:42:59] P21 : Q6581097 [12:43:08] is the claim [12:43:17] with the references, qualifiers, etc. it is a statement [12:43:17] (which may also be a statement) [12:43:32] DanielK_WMDE: aude: okay that makes it clearer [12:43:36] alright [12:44:03] it's slightly confusing but reading and re-reading the data model and working with the code, the differences become more clear [12:45:01] "Property : Value (according to Source)" is a statement [12:45:17] + possible qualifiers [12:45:29] qualifiers, yes [12:45:31] and it will also be possible to assign a rank / sort [12:45:50] to statements? [12:45:53] yes [12:46:01] so mark one as primary [12:46:13] e.g. current president in Q30 [12:46:24] while also list previous presidents, but not preferred [12:47:58] and separately, it will be possible to sort the statements in display order (e.g. instead of sex/male, allow to put occupation at the top) [12:48:14] or however users prefer [12:49:03] right now, stuff is displayed in the item in teh order the statements are added [12:50:11] aude: and what is a 'Snak'? [12:50:39] P21 : Q6581097 is a snak [12:50:43] property value snak [12:51:00] in place of value, it's also possible to have "unknown value" or no value [12:51:25] in which case they are not really values [12:54:41] okay, so getClaims gives me an array of claims [12:54:56] from each claim object, I can get an array of all Snak objects [12:55:52] pragunbhutani: yes [12:56:11] well. for the claim [12:56:17] you get the main snak [12:56:22] P21 : Q6581097 [12:57:50] claim.php also has a getAllSnaks [12:58:09] true [12:59:55] okay now I know what everything is [13:00:01] good :) [13:00:03] I'm still not clear what the algo would be [13:00:22] to get all the data [13:00:38] I'm not completely clueless but it's a little vague [13:01:23] there is some stuff in entity view that can probably be factored otu and shared [13:01:49] for example, getHtmlForClaims does stuff to aggregate claims by property and then in the same function, build the html [13:01:52] bad! [13:02:25] but a function that does just aggregate the claims in an entity would be useful [13:02:25] we already factored that out, didn't we? [13:02:37] yeah [13:02:48] aude: note that i have a patch in review that changest he way snaks are rendered in EntityView [13:02:59] :o [13:03:17] not a big deal, should be easy to fix any conflicts [13:03:30] pragunbhutani: we should rebase the get html for claims and get tests added, so that can be done [13:03:33] finished [13:03:51] and then maybe mobile can reuse some of the functionality [13:03:54] (03CR) 10Daniel Kinzler: [C: 04-1] "This changes the handling of entity IDs in an incompatible way. Will fix soon." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [13:03:58] hmm good idea [13:04:25] * aude thinks it's likely that somewhere else in wikibase, code is also aggregating claims by property [13:04:41] silly to duplicate that in multiple plaeces [13:04:45] places [13:04:58] oh the perils of working with a large code base [13:05:02] yep [13:05:21] * aude imagines the api does this [13:05:44] so what do we need to do with getHtmlForClaims? [13:05:53] api does what? :P [13:06:06] has to be rebased, as i'm sure it's diverged some from current master [13:06:16] addshore: aggregate an entity's claims by property [13:06:22] e.g. group them [13:06:33] i'm sure get entities does this [13:06:54] just not exactly sure where/how/ [13:07:20] aude: not sure how to rebase [13:07:22] indeed *looks* [13:07:28] * aude wonders if addshore has "api" set to highlight in irc :) [13:07:34] xD [13:07:56] pragunbhutani: might be something we help with in this case [13:08:22] but normally, you can do git rebase master (when on your branch) [13:08:50] and git automatically handles things [13:08:53] I'll go update my copy of Wikibase as well in the meanwhile [13:08:59] haven't done so in a bit :p [13:09:08] but if there is a conflict, then some stuff needs to be merged by hand [13:09:13] ok [13:09:33] there even is a rebase button in gerrit [13:09:57] but best to use that for simple, not very old stuff [13:10:06] okay I'll do that [13:11:06] to move forward with the skin, suppose it would be okay to get the claims to render "ungrouped" [13:11:21] e.g. if an entity has two things for P21 (unlikely), list them both [13:11:29] ungrouped [13:11:44] aude: ClaimsSerializer::getSerialized( $claims ) [13:11:50] which uses a ByPropertyListSerializer [13:11:50] addshore: hah [13:12:02] ah like, Country of Citizenship : Poland [13:12:06] pragunbhutani: yes [13:12:09] Country of citizenship : Vatican [13:12:11] someone migh thave two citizenships [13:12:23] that's what the aggregating does [13:13:23] I guess we could start with that [13:13:27] yeah [13:13:34] small steps are good [13:13:51] small, simple [13:14:09] btw, i won't be around in the evening but am around tomororw [13:14:11] tomorrow [13:14:20] * aude challenged with typing and spelling :) [13:14:32] hahah :p [13:15:01] omg something is wrong with my net connection [13:15:05] :( [13:15:11] I did a git pull and it's downloading at 6kb/s! [13:15:13] 6!! [13:15:18] yikes [13:15:20] reminds me of dial-up days [13:15:31] must be momentary, I'll call up the ISP [13:22:43] mhhhm, *hates rebasing this change* :< everything broke :D [13:25:16] addshore: huh [13:25:19] ? [13:25:42] Im rebasing my mergeapimodule but som much has changed since I last poked it :/ [13:31:57] (03CR) 10Aude: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [13:32:18] Tobi_WMDE: not tried it yet, but some minor style comments [13:32:22] or suggestions [13:32:34] (03PS5) 10Tobias Gritschacher: (bug 54319) Show diff when order of snaks changed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85844 [13:43:14] (03PS7) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [13:56:47] (03CR) 10Aude: [C: 031] "needs https://gerrit.wikimedia.org/r/#/c/85986/ merged, but otherwise this adequately addresses the bug" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:04:17] (03PS8) 10Tobias Gritschacher: (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 [14:05:07] (03CR) 10Aude: [C: 031] (bug 54492) Display a custom sitename for specific site groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:05:29] (03CR) 10Nilesh: "(4 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 (owner: 10Nilesh) [14:10:59] (03CR) 10Siebrand: [C: 031] "Per earlier i18n/L10n review." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85982 (owner: 10Tobias Gritschacher) [14:22:44] anyone any idea where the claimguid index is built in entity? [14:23:07] Lydia_WMDE: https://www.wikidata.org/entity/Q76.n3 [14:26:30] is this stuipid or am I missing something? In entity if you construct an object with an array of data including serialized claims, the claims get set to the [claims] key in $data.. [14:27:08] but $claims doesnt get touched... [14:34:17] addshore: i think it's hidden inside a Claims object [14:34:29] (which will often be used like an array) [14:35:30] I have a claim I create with an array of data, everything looks fine (it has a guid etc) and then later on in a Claims object it no longer has a guid :P just trying to figure out where exactly its happening :/ [14:36:03] even when the claims are unstubbed and suck in $claims the claim has a guid! grrrrrrr, just when does it disappear [14:36:11] i think there is weirdness and inconsistency in handling claims as arrays and as Claims objects [14:36:37] there is entity->setClaims( Claims $claims ) [14:36:43] and getClaims is an array of claims [14:36:45] * aude thinks [14:36:54] aude, addshore: i recall issues with that - it has to do with arrayes being automatically copied when passed as parameters. iirc [14:37:29] aude: I think there is a todo there somewhere saying to make setclaims just accept an array [14:37:37] err array of Claim objects to be clear, for getClaims [14:37:42] i saw that [14:38:14] * DanielK_WMDE hates the hidden magic in ArrayObjects [14:38:19] lol [14:41:09] this calls getclaims once, and the claim has a guid... then just when applying the changeop it calls getclaims again, and the guid is gone.. [15:02:55] mhhhm, think I might have found something wrong with editing claims through editentity :< [15:02:58] (03PS33) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [15:04:05] (03CR) 10jenkins-bot: [V: 04-1] Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [15:05:27] DanielK_WMDE: Multipart content handler (wikitext and other stuff in the same page object), what's the status of that? Only exists in your head? :P [15:13:46] (03CR) 10Addshore: [C: 04-1] "(2 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 (owner: 10Nilesh) [15:22:39] grrr, random failing test time :< [15:32:19] Tobi_WMDE: fixed [15:32:47] apparently data types was not updated every 20 minutes [15:33:04] aude: ok [15:33:05] thx [15:47:49] (03PS1) 10Nilesh: Added shell script to run runhadoop.sh and use curl to train the suggester, for convenience [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/86111 [15:51:54] (03Abandoned) 10Liangent: EntityViewHtml - DO NOT MERGE [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72363 (owner: 10Liangent) [15:52:24] (03CR) 10Nilesh: "(2 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 (owner: 10Nilesh) [16:04:46] nileshc: testing api modules is hard, the only way is to test the request as a whole. [16:05:15] the only way to make that more testable would be to factor the logic out in some way so that it can be tested seperatly [16:13:11] (03PS34) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [16:15:29] i need help [16:16:50] I would like to add an english label to a lake located in germany. i guess it has no official designation in english. should I invent one? should I simply use german? [16:17:18] https://www.wikidata.org/wiki/Q14947316 [16:17:48] Beetzer See literally translated means something like "Lake of Beetz" [16:18:20] but I'd simply call it "Beetz Lake" [16:51:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#903 (master - ee37a37 : jenkins-bot): The build was broken. [16:51:41] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/955804f89b2a...ee37a37a235f [16:51:41] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11819249 [17:20:16] Schisma_: "Beetz Lake" sounds good [17:44:53] mhhhm, broken testies :( [17:46:31] ahh, travis issues :) [17:47:07] legoktm: thx [18:46:28] (03CR) 10Michał Łazowik: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [18:46:36] addshore: hi, ^ [19:02:05] JeroenDeDauw: u 've stolen my headphones! https://plus.google.com/116122101180283047788/posts [19:05:55] hi lazowik [19:06:03] will take a look now :) cooking dinner :P [19:06:43] heh, no hurry [19:06:57] probably won't ci anything until the end of the month [19:07:57] ahh your comments look fine :) although re error codes i would stick with the one I mentioned for now :) [19:09:16] addshore: ok [19:09:34] addshore: what's the status with browser tests for that? [19:09:38] (is there anything to change/write) [19:09:39] also I havnt manually tested it yet, just code review [19:09:51] browser tests for? [19:09:58] I don't know [19:10:02] maybe history page [19:10:06] (summaries) [19:10:36] I haven't ever looked at any browser tests yet :( [19:33:55] tata for now [19:51:23] JeroenDeDauw: and look like usb hub too! [19:55:54] is there an archiver bot running on wikidatawiki? [20:01:32] MatmaRex: hey! [20:01:54]