[10:28:12] (03PS2) 10Addshore: Put changeops in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87533 [10:32:12] (03CR) 10jenkins-bot: [V: 04-1] Put changeops in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87533 (owner: 10Addshore) [10:33:04] (03PS3) 10Addshore: Put changeops in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87533 [10:54:51] (03PD1) 10Addshore: Get rid of use of EntityContentFactory singleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87534 [12:03:38] (03CR) 10Jeroen De Dauw: [C: 032] Get rid of use of EntityContentFactory singleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87534 (owner: 10Addshore) [12:11:09] woah, https://gerrit.wikimedia.org/r/#/c/87533/ like changes all the code! [12:11:17] (03CR) 10Jeroen De Dauw: [C: 032] "Follow up suggestion: rename dir to ChangeOp, to match NS and be more PSR-0 compliant" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87533 (owner: 10Addshore) [12:15:16] (03PS1) 10Addshore: Rename dir changeop to ChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87543 [12:15:21] JeroenDeDauw: ^^ [12:35:00] hehe method modifyEntity() has an NPath complexity of 49152. The configured NPath complexity threshold is 200 [12:36:26] which module? [12:36:32] editentity? [12:36:36] yup :D [12:36:49] * aude was poking at it yesterday [12:36:51] * addshore goes to tear it apart a bit [12:36:55] ok :) [12:37:16] if you want to review my patch and poke more [12:37:29] which patch? :O link? [12:37:38] i was wondering about how $status is used there [12:37:43] have some concerns [12:37:44] status is silly ;p [12:37:58] it seems like not all merged back into the end results [12:38:02] unless i am confused [12:38:17] (03PD1) 10Aude: Reduce complexity of functions in api EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87437 [12:38:22] addshore: ^ :) [12:38:32] needs a rebase now with the namespaces [12:38:54] * aude rebases [12:38:57] :> [12:39:13] * aude tired of phpcs and phpmd screaming at me [12:42:17] (03PS1) 10Aude: Add numeric validation for globe precision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87545 [12:43:09] (03CR) 10jenkins-bot: [V: 04-1] Add numeric validation for globe precision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87545 (owner: 10Aude) [12:44:35] aude: are you rebasing or shall I? :) [12:45:39] one sec [12:46:08] * aude waiting for latest phpcs and phpmd report [12:46:13] <: [12:46:28] The method modifyEntity() has an NPath complexity of 512. The configured NPath complexity threshold is 200. (PHPMD) [12:46:32] still too high but better [12:46:37] indeed :) [12:47:13] your patch looks good :) cleans up quite a few of the things I was going to! [12:47:24] Ill add a few more in another patchset :) [12:47:28] (03PS2) 10Aude: Reduce complexity of functions in api EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87437 [12:47:30] please do [12:47:40] and i am concerned about the use of $status in edit entity [12:47:54] needs more checking and tests to ensure the right thing is happening [12:48:20] or at least documentation of why it is used the way it is [12:49:30] http://dpaste.com/1405703/ [12:49:35] addshore: ^ [12:50:18] Lydia_WMDE: http://dpaste.com/1405696/ if you are curious about usage of globe in wikidata [12:50:30] 17880 null globes and a bunch of others used [12:50:37] 69 = 'earth' [12:52:50] Lydia_WMDE: http://dpaste.com/1405706/ precision [12:53:09] i assume 107509 null precisions [13:06:08] merge it merge it! [13:08:47] (03CR) 10Addshore: [C: 032] Reduce complexity of functions in api EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87437 (owner: 10Aude) [13:11:14] (03PS2) 10Aude: (bug 53796) Add numeric validation for globe precision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87545 [13:16:23] (03PD1) 10Addshore: Further reduce complexity of modifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87549 [13:16:24] aude: ^^ :O [13:16:27] :) [13:17:15] ok, so $status is mostly (or completely gone) now? [13:17:20] * aude thinks it was unused [13:17:26] it is completly gone :) [13:17:29] great [13:17:38] it was basically just passed around and everything returns a good status :P [13:17:43] yep [13:17:47] pointless [13:17:51] as if something is bad dieusage will get called imediatly anyway [13:17:59] right [13:18:10] I imagine the complexity should decrease a fair bit :P [13:18:54] (03PS1) 10Jeroen De Dauw: Update doc headers [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87550 [13:19:33] (03PS1) 10Jeroen De Dauw: Remove obsolete compatibility aliases [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87551 [13:19:45] (03CR) 10Addshore: [C: 032] Update doc headers [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87550 (owner: 10Jeroen De Dauw) [13:21:13] (03CR) 10Addshore: [C: 04-1] "there are still references to these classes..?" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87551 (owner: 10Jeroen De Dauw) [13:22:25] (03CR) 10Addshore: [C: 032] "no there are now, mixed the namespaces up.." [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87551 (owner: 10Jeroen De Dauw) [13:24:05] (03PD1) 10Addshore: Refactor LinkTitles api module execute method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87544 [13:24:57] (03PS1) 10Jeroen De Dauw: Remove TODOs that are not needed [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87553 [13:25:58] (03CR) 10Addshore: [C: 032] Remove TODOs that are not needed [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87553 (owner: 10Jeroen De Dauw) [13:26:26] (03CR) 10Aude: [C: 032] Further reduce complexity of modifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87549 (owner: 10Addshore) [13:26:48] next on my list is MultiLangConstraintDetector::addConstraintChecks() :P [13:26:55] heh [13:27:01] NPath complexity of 314000 woo! [13:28:13] * aude amused by the code comments [13:28:23] "Sites are already tested through allowed params ;)" [13:28:41] * aude trying to understand what the code is doing [13:29:00] not sure if that comment helps [13:29:10] hah :P [13:29:23] well the allowedparams method will validate the site code [13:29:38] therefore we can presume it is correct in the api module without further validation [13:29:47] but the comment doesnt reallllly need to be there :) [13:29:49] hmmm, ok [13:29:54] (03Merged) 10jenkins-bot: Further reduce complexity of modifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87549 (owner: 10Addshore) [13:30:44] git blames addshore for that comment :) [13:30:55] mhhhm, with what commit message? :P [13:31:17] oh, you just moved it [13:31:23] git really blames jeblad [13:31:27] :> [13:35:23] hi! [13:35:58] addshore: present? [13:36:03] :O [13:36:10] present! [13:36:29] addshore: can I make linktitle optional? [13:36:37] so linktitle v badges [13:36:43] how do you mean? [13:36:51] linktitle OR badges [13:37:19] so I don't have to provide linktitle if I only want to change badges [13:37:39] in setsitelinks? [13:37:42] i suppose so :) [13:38:01] try it and see what others think ;p [13:38:04] now you have too specify linktitle [13:38:14] which is quite strange if you do not want to change it [13:38:40] in some cases that'd mean that you'd have to get it from somewhere [13:39:08] addshore: heh, I don't want to revert then if that's not what is wanted [13:39:22] DanielK_WMDE_: is here? [13:39:33] lazowik: probably not [13:39:37] he isn't in the office :) [13:39:48] it's a long weekend for most people [13:39:55] aude: ah [13:39:56] who else can I ask? [13:40:03] (03CR) 10Aude: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87544 (owner: 10Addshore) [13:40:49] (not necessarliy now) [13:41:20] (03CR) 10Aude: "and this is one api module my bot does not use, so i can't verify the patch that way. Need to trust the tests or try to verify later." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87544 (owner: 10Addshore) [13:43:16] (03PS1) 10Jeroen De Dauw: Add FieldRemovalFailedException and FieldAdditionFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87555 [13:49:21] (03PS2) 10Addshore: Refactor LinkTitles api module execute method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87544 [13:50:31] (03CR) 10Addshore: [C: 032] Add FieldRemovalFailedException and FieldAdditionFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87555 (owner: 10Jeroen De Dauw) [13:50:37] (03Merged) 10jenkins-bot: Add FieldRemovalFailedException and FieldAdditionFailedException [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87555 (owner: 10Jeroen De Dauw) [13:51:11] (03CR) 10Aude: "checked with Lydia and agree disallowing precision more specific than a day is the way to go for now. (since it's currently problematic in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 (owner: 10Daniel Kinzler) [13:53:18] JeroenDeDauw: which files should I be looking at specifically? [13:58:02] (03PS1) 10Nemo bis: Replace "article" with "page" in wikibase-sitelink-page-edit-placeholder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87559 [14:02:16] I'll go for it [14:05:08] (03PS1) 10Jeroen De Dauw: Implemented MediaWikiSchemaModifier [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87560 [14:05:36] (03PS1) 10Addshore: Add further escaping to mysql and sqlite classes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87561 [14:06:50] (03CR) 10Jeroen De Dauw: [C: 032] Refactor LinkTitles api module execute method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87544 (owner: 10Addshore) [14:09:11] (03CR) 10Addshore: [C: 032] Implemented MediaWikiSchemaModifier [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87560 (owner: 10Jeroen De Dauw) [14:09:23] (03Merged) 10jenkins-bot: Implemented MediaWikiSchemaModifier [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87560 (owner: 10Jeroen De Dauw) [14:09:48] (03CR) 10Aude: [C: 031] Replace "article" with "page" in wikibase-sitelink-page-edit-placeholder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87559 (owner: 10Nemo bis) [14:10:02] (03CR) 10Aude: [C: 032] Replace "article" with "page" in wikibase-sitelink-page-edit-placeholder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87559 (owner: 10Nemo bis) [14:10:14] all the merges :> [14:10:18] :) [14:10:32] * aude having trouble, clicking +1 instead of +2 [14:12:15] Damn... /me was to slow... or rather my mail client [14:12:21] heh [14:14:16] (03Merged) 10jenkins-bot: Replace "article" with "page" in wikibase-sitelink-page-edit-placeholder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87559 (owner: 10Nemo bis) [14:14:55] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87561 (owner: 10Addshore) [14:18:30] JeroenDeDauw: where are these other mysql / sqliute focused todos? [14:28:03] addshore: I send csteip a mail about the escaping, asking if he could comment on it [14:29:11] okay :) [14:29:15] addshore: just search for TODO on src/ [14:29:29] addshore: the DBConnectionProvider stuff can be ignored for now [14:29:46] addshore: the rest still needs to be done [14:29:56] addshore: I will take care of the stuff in src/Schema/ [14:30:22] addshore: the TODOs need to be taken care off in some way, which does not imply implementing the functionality [14:30:37] if we do not need it, we can simply document clearly what is and what is not implemented [14:30:59] addshore: then once all these TODOs are gone, we can finally close the schema updating item [14:31:14] And we will be done with Wikibase Database untill we need some new stuff there [14:31:21] So we can do a initial 0.1 release :) [14:38:01] addshore: now I wonder [14:38:07] why I did sitelinks/badges [14:38:07] ? [14:38:16] why? :P [14:38:23] it's a part of structure, not something optional [14:38:49] I had to add that to default props anyways [14:39:39] addshore: and now I don't know whether I should add that to EntitySerializationOptions [14:40:25] I have extended SiteLinkSerializerTest (already merged) [14:40:49] and in there I add that per test (not to all of them) [14:41:38] JeroenDeDauw: at this stage I would say we can probably forget about adding support to change things such as DEFAULT CHARSET and ENGINE in mysql? [14:41:52] lazowik: link to the change? [14:42:04] addshore: https://gerrit.wikimedia.org/r/#/c/82842/7/lib/tests/phpunit/serializers/SiteLinkSerializerTest.php [14:42:43] you could just make sitelinks always appear, get rid of sitelinks/badges everywhere [14:42:55] addshore: that's what I thought of [14:43:04] seems like a reasonable idea [14:43:13] addshore: of course s/sitelinks/badges ? [14:43:20] and if it is to be done, now is probably the best time [14:43:34] s/sitelinks/badges ? [14:43:41] "you could just make sitelinks always appear, get rid of sitelinks/badges everywhere" [14:43:47] *badges ? [14:43:57] not a good idea to show sitelinks always :p [14:43:58] addshore: probably [14:44:32] addshore: I don't see us needing to be able to change this any time soon [14:44:52] (03PS1) 10Addshore: Remove TODOs for options [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87566 [14:46:25] (03PS1) 10Aude: Remove unused variable in PropertyParserFunction with undefined param [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87567 [14:47:29] (03PS1) 10Addshore: Remove TODOS about non existant global [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87568 [14:48:41] addshore: ^ stop working, answer questions! [14:48:56] lazowik: yes! [14:49:05] :> [14:49:32] addshore: thank you! [14:50:16] (03PS1) 10Jeroen De Dauw: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87569 [14:51:05] (03CR) 10Jeroen De Dauw: [C: 032] Remove TODOS about non existant global [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87568 (owner: 10Addshore) [14:51:29] (03CR) 10Jeroen De Dauw: [C: 032] Remove TODOs for options [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87566 (owner: 10Addshore) [14:51:30] (03CR) 10Addshore: [C: 032] Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87569 (owner: 10Jeroen De Dauw) [14:52:00] (03Merged) 10jenkins-bot: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87569 (owner: 10Jeroen De Dauw) [14:58:24] (03PS1) 10Jeroen De Dauw: Add extra escpaing tests to SQLiteFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87571 [14:59:05] (03CR) 10Addshore: [C: 032] Add extra escpaing tests to SQLiteFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87571 (owner: 10Jeroen De Dauw) [14:59:12] (03Merged) 10jenkins-bot: Add extra escpaing tests to SQLiteFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87571 (owner: 10Jeroen De Dauw) [14:59:50] (03CR) 10Aude: [C: 032] Style the flag 'D' on watchlist and recentchanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82886 (owner: 10Umherirrender) [15:00:51] (03PS1) 10Jeroen De Dauw: Add extra escpaing tests to MySQLFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87572 [15:01:35] (03CR) 10Aude: [C: 032] Rename dir changeop to ChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87543 (owner: 10Addshore) [15:01:52] allllllllll offff the meerrggess [15:01:53] merge everything! [15:02:19] addshore: please review https://gerrit.wikimedia.org/r/#/c/87567/ :) [15:02:37] the undefined param doesn't work too nicely there [15:02:45] (03CR) 10Jeroen De Dauw: [C: 032] Remove unused variable in PropertyParserFunction with undefined param [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87567 (owner: 10Aude) [15:02:49] first! [15:02:50] thanks JeroenDeDauw [15:03:17] (03Merged) 10jenkins-bot: Style the flag 'D' on watchlist and recentchanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82886 (owner: 10Umherirrender) [15:03:21] L< [15:03:22] perhaps today we will break our own record of average time before something gets merged ;p [15:03:28] heh [15:03:28] xD [15:03:33] Where did $options come from [15:03:47] probably a relic from snak formatter refactoring [15:03:50] or something [15:04:11] meh... shouldn't the unit tests cry out about PHP Notices? [15:04:28] they should [15:05:23] maybe that function just hasn't got any :P [15:05:30] * aude looking [15:06:17] @s [15:06:23] (03Merged) 10jenkins-bot: Rename dir changeop to ChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87543 (owner: 10Addshore) [15:08:04] * lazowik is still confused about fixing merge conflicts [15:12:07] (03PS1) 10Jeroen De Dauw: 0.9 release [extensions/Diff] - 10https://gerrit.wikimedia.org/r/87575 [15:12:23] (03CR) 10Jeroen De Dauw: [C: 032] 0.9 release [extensions/Diff] - 10https://gerrit.wikimedia.org/r/87575 (owner: 10Jeroen De Dauw) [15:16:15] (03PS1) 10Jeroen De Dauw: Update readme [extensions/Diff] - 10https://gerrit.wikimedia.org/r/87577 [15:16:23] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update readme [extensions/Diff] - 10https://gerrit.wikimedia.org/r/87577 (owner: 10Jeroen De Dauw) [15:22:16] addshore: you missed this one? https://gerrit.wikimedia.org/r/#/c/87572/ [15:23:25] (03CR) 10Addshore: [C: 032] Add extra escpaing tests to MySQLFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87572 (owner: 10Jeroen De Dauw) [15:23:30] (03Merged) 10jenkins-bot: Add extra escpaing tests to MySQLFieldSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87572 (owner: 10Jeroen De Dauw) [15:23:36] apparently I missed the submit button.. [15:23:50] (03PS1) 10Jeroen De Dauw: Remove clutter comments [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87579 [15:24:37] (03CR) 10Addshore: [C: 032] Remove clutter comments [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87579 (owner: 10Jeroen De Dauw) [15:25:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#938 (master - 3cf5f63 : aude): The build is still failing. [15:25:58] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3e0f5280f0ab...3cf5f6328131 [15:25:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12137266 [15:26:37] addshore: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [15:27:00] why is travis taking 35 min 17 sec for tests? [15:27:20] lolwat? [15:27:43] aude: it is not [15:27:47] that is total build time [15:27:50] Duration: 35 min 17 sec, Finished: 2 minutes ago [15:27:52] look at the individual jobs [15:28:03] JeroenDeDauw: WorldPizza Texas please :) [15:28:17] aude: travis might be having a few problems too [15:28:22] yeah [15:28:24] build speed varies lots :> [15:28:44] addshore: aude: the variance is not just caused by travis worker availability [15:28:57] also by how fast the services it uses (ie the git repos) respond [15:29:10] a good chunch of the build time is cloning core ;p [15:29:13] hmmm [15:29:36] well, there appear to be issues with the merge items tests [15:29:38] well, in this build it is not to bad, since it uses --depth 1 [15:29:44] addshore: do you have a clue about those? [15:30:13] * aude could probably poke but maybe i'm not the most knowledgable about merge items [15:30:30] ill take a look in a second [15:30:34] ok, thanks [15:30:42] it seems some of the error codes have changed :) nothing major :d [15:30:47] ok [15:31:11] i still need to update my bot so it makes use of merge items [15:31:50] Wait... merge item has been merged? [15:31:57] hoo: yes! [15:32:17] \o/ [15:32:31] I need to adopt linkItem for that :) [15:32:35] the next deployment will be amazing in terms of new api functionality [15:32:42] :D [15:32:51] :D [15:32:54] * addshore is happy :> [15:33:10] I'm not looking forward to that much, tbh... linkItem is fairly complex and evil :P [15:33:22] ahh, does editentity claim stuff get deployed next also? :) or was that has deployment? [15:33:32] addshore: it does [15:33:41] not yet deployed [15:33:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#939 (master - 026acee : jenkins-bot): The build was fixed. [15:33:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3cf5f6328131...026acee1c7b5 [15:33:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12137298 [15:34:04] * aude doesn't believe travis [15:34:07] aude: When is the next code freeze? [15:34:14] hoo: wednesday [15:34:17] LinkItem should be fixed then [15:34:20] fyi, the widget does not work with commons [15:34:22] ewk [15:34:25] I know :/ [15:34:28] aude: how odd, the build is fixed :P [15:34:32] so it's disabled at the momemt there [15:34:47] if you want to poke at it or i might poke at the widget some time [15:35:24] Hopefully this weekend or early next week... been ill most of the week :/ [15:36:38] :( [15:37:52] anyone fancy making a special page for merging items before wednesday? :P [15:37:58] :) [15:38:05] it should be amazingly simple :P [15:39:25] (03PS2) 10Addshore: Clean Up includes/actions code and classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87580 [15:45:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#940 (master - 372b601 : jenkins-bot): The build is still failing. [15:45:30] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/026acee1c7b5...372b6014fbe9 [15:45:30] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12137380 [15:45:36] travis is confused [15:45:41] :D [15:45:56] mostly failing though [15:51:54] (03PS1) 10Jeroen De Dauw: Remove clutter comments [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/87583 [15:52:12] (03CR) 10Addshore: [C: 032] Remove clutter comments [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/87583 (owner: 10Jeroen De Dauw) [15:54:54] (03CR) 10jenkins-bot: [V: 04-1] Remove clutter comments [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/87583 (owner: 10Jeroen De Dauw) [15:55:33] .. [15:56:33] jenkins says no.... [16:11:07] (03PS1) 10Addshore: Refactor some of MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87586 [16:11:08] aude: this should do it ^^ [16:11:42] addshore: ok [16:14:03] woah, never noticed before that i can edit the topic of a changeset [16:14:07] in gerrit [16:14:27] :O [16:14:40] * addshore never bothers with topics [16:14:41] seems like it might mess with stuff [16:14:51] or make stuff vanish [16:14:55] * aude suspicious :) [16:17:04] (03CR) 10Aude: [C: 032] Refactor some of MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87586 (owner: 10Addshore) [16:22:17] (03Merged) 10jenkins-bot: Refactor some of MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87586 (owner: 10Addshore) [16:32:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#941 (master - 6ba28f0 : addshore): The build was fixed. [16:32:41] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/372b6014fbe9...6ba28f0ddb6a [16:32:41] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12140466 [16:32:52] ::> [16:32:54] yay! [16:47:38] (03PS1) 10Jeroen De Dauw: Update EntityId handling code [DRAFT, DNM] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 [16:47:53] (03CR) 10jenkins-bot: [V: 04-1] Update EntityId handling code [DRAFT, DNM] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [16:49:12] (03CR) 10Jeroen De Dauw: [C: 032] Clean Up includes/actions code and classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87580 (owner: 10Addshore) [16:50:04] addshore: sitelinks/badges is already deployed [16:50:06] (getting) [16:50:11] it won't be a problem? [16:50:20] i highly doubt it [16:50:26] lazowik: why? [16:50:27] especially as there is nothing to get currently [16:50:56] i think that someone asked me about getting for the python library [17:00:16] lazowik: it may have been legoktm [17:00:26] I think so [17:00:46] dunno if he has written anything already [17:03:05] free choclate ^^ [17:03:06] (03PS1) 10Addshore: Remove unused var from SiteModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87594 [17:03:07] ^^ [17:04:09] (03CR) 10Aude: [C: 032] Remove unused var from SiteModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87594 (owner: 10Addshore) [17:04:14] * aude grabs the chocolate [17:04:49] :> [17:06:19] (03PD1) 10Addshore: Slight Refactor of EditEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87592 [17:12:27] (03Merged) 10jenkins-bot: Remove unused var from SiteModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87594 (owner: 10Addshore) [17:44:18] (03PS17) 10Michał Łazowik: Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [17:52:23] (03CR) 10Michał Łazowik: "Patch Set 17 is a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [17:55:34] addshore: title cannot be an '' string? [17:56:01] (03PD1) 10Addshore: Remove use of 2 deprecated methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87600 [17:56:10] lazowik: where? :P [17:56:19] (03CR) 10Jeroen De Dauw: [C: 032] Slight Refactor of EditEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87592 (owner: 10Addshore) [17:56:25] in sitelink [17:56:38] '' -> empty [17:57:57] in setsitelink? [17:58:23] I know that this will delete the sitelink [17:58:36] maybe I'll tell what I'm worried about [17:59:10] will I be able to correctly differentiate between linktitle= and no param? [17:59:13] addshore: ^ [17:59:29] (first -> delete, second -> change badges if they are set) [17:59:42] yes, one will be passed around as '' and the other I think is either null or false [18:02:28] addshore: well, now there's $page = $site->normalizePageName( $this->stringNormalizer->trimWhitespace( $params['linktitle'] ) ); [18:02:36] and looks like it produces null for '' [18:03:09] mhhhm *looks* [18:03:13] oh, wait [18:03:22] that whole code is in an if [18:03:25] (03PD1) 10Addshore: remove deprecated setIdFormatter method and use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87602 [18:03:35] nope [18:03:39] it's ok [18:04:07] :> [18:04:21] ( is_null( $params['linktitle'] ) || $params['linktitle'] === '' ) ) -> return new ChangeOpSiteLink( $linksite, null ); [18:04:34] sorry for bothering ;) [18:04:43] haha np :D [18:05:05] if I didnt want to help I would just pretend I wasn't here ;p [18:05:14] :D [18:06:56] addshore: You're never here :P [18:07:19] addshore: You are not even here right now some how! :O [18:07:53] (03PD1) 10Addshore: Remove deprecated EntityContentFactory::singleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87604 [18:09:24] JohnLewis: I am :O [18:11:48] addshore :O [18:22:43] addshore: but sitelinks with badges will eat more badwidth [18:23:42] ~9 bytes / sitelink (when no badges) [18:24:11] this can get to ~1 KiB for ~120 links [18:25:02] but sitelinks are displayed by default now anyway..? [18:25:36] yep [18:25:42] but with badges it's more data! [18:26:39] ok, that's ~250 KiB / s more with 250 edits/s concerning sitelnks [18:27:08] and that is probably nothing ;) [18:35:20] (03PD2) 10Addshore: Remove override that only calls parent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87605 [18:52:44] (03PS2) 10Jeroen De Dauw: Update EntityId handling code [DRAFT, DNM] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 [18:52:45] (03CR) 10jenkins-bot: [V: 04-1] Update EntityId handling code [DRAFT, DNM] [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [18:52:54] (03PS3) 10Jeroen De Dauw: Update EntityId handling code [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 [18:53:30] (03CR) 10Jeroen De Dauw: [V: 032] Remove clutter comments [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/87583 (owner: 10Jeroen De Dauw) [18:55:15] (03PS4) 10Jeroen De Dauw: Update EntityId handling code [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 [18:55:30] addshore: y u no review? ^^ [18:56:10] cause I no see :P [18:56:37] ewww, might have to leave that for monday :P [18:56:49] it requires a bit more of an awake person i feel [18:59:03] Hi guys. Anyone wanting to review my request for permission https://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Bot/AyackBot ? Thanks. [19:03:29] Ayack: I'll take a look (Also I gave your bot autopatroll to reduce patrolling) [19:04:11] JohnLewis: Thanks! [19:09:05] addshore: sooo, if there's no sitelinks/badges [19:09:17] can I leave assertEntityPropsSitelinksBadges in getEntitiesTest [19:09:33] it's tricky to get assertEntityEquals play with badges [19:09:35] (03Abandoned) 10Addshore: Use EntityHelper in ModifyEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84318 (owner: 10Addshore) [19:09:39] Ayack: Commented. [19:10:24] lazowik: let me check quickluy :P [19:10:36] if( in_array( 'sitelinks/badges', $expected['props'] ) ){ [19:10:41] JohnLewis: Great, thanks [19:10:50] so it will only do the assertion if the sitelinks/badges is in the props passed to the api currently [19:10:51] addshore: yep, I'd delete that if [19:11:07] and leave just $this->assertEntityPropsSitelinksBadges( $entity, $expected ); [19:11:16] if it is always going to be returned removing that if and just calling $this->assertEntityPropsSitelinksBadges( $entity, $expected ); should be fine [19:11:21] ypu :) [19:11:32] ough, actually no [19:11:44] ? :P [19:11:52] if( in_array( 'sitelinks/badges', $expected['props'] ) ){ -> if( in_array( 'sitelinks', $expected['props'] ) ){ [19:12:09] 'cause sitelinks are not always returned [19:12:47] addshore: ^ [19:13:16] then I guess if( in_array( 'sitelinks', $expected['props'] ) ){ [19:13:28] mhm [19:14:38] looks like it should work :) [19:14:50] (03Abandoned) 10Addshore: Switch use of ClaimModHelper to EntityHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84305 (owner: 10Addshore) [19:15:08] though it would be better to have that checked in assertEntityEquals [19:15:30] (03Abandoned) 10Addshore: Split ClaimModificationHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84304 (owner: 10Addshore) [19:15:39] as it is advertised to check if two entities as a whole are the same [19:15:42] lazowik: probably :) *looks at that method* [19:16:11] well in assertEntityEquals you have if ( isset( $expected['sitelinks'] ) ) { [19:17:04] yep, but the code inside only considres site => title pairs [19:17:10]