[00:12:42] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87951 (owner: 10L10n-bot) [08:34:15] (03PS1) 10Zfilipin: Moving shared code to mediawiki-selenium Ruby gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88010 [08:59:35] aude: hey! i'm online for the daily... anyone around? [08:59:47] we are here [09:00:10] DanielK_WMDE__: on it [09:00:21] no rush :) [09:14:30] addshore: you are not getting from under this one https://gerrit.wikimedia.org/r/87590 [09:14:52] (03PS14) 10Jeroen De Dauw: (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [09:15:21] Hello dear Wikidatians. [09:15:29] hi siebrand [09:15:35] hello! [09:15:41] At translatewiki.net there is a request[1] for clarifying a UI message[2]. [09:15:41] 10[1] 10https://www.wikidata.org/wiki/Q18159313 => [09:15:43] 10[2] 10https://www.wikidata.org/wiki/Category:Wikidata [09:15:56] [1] https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-item-summary-wbeditentity-override/en [09:15:56] 10[1] 10https://www.wikidata.org/wiki/Q181593 [09:16:09] [2] https://translatewiki.net/w/i.php?title=MediaWiki:Wikibase-item-summary-wbeditentity-override/qqq&action=edit [09:16:09] 10[2] 10https://www.wikidata.org/wiki/Category:Wikidata [09:16:16] the bot is annoying :) [09:16:23] yus :/ [09:16:29] * siebrand raises an eyebrow at AsimovBot  [09:16:57] it is an api message so addshore might know better how to answer [09:17:26] ahh its that one! [09:17:32] in some way i think both "override" and "cleared" are correct [09:17:35] but confusing [09:17:39] If you have an account, please immediately update at [2] (my, to, not the bot's ;P) [09:17:39] 10[2] 10https://www.wikidata.org/wiki/Category:Wikidata [09:17:44] * siebrand kicks AsimovBot  [09:17:51] :) [09:18:12] i would say the item gets overridden [09:18:23] but that can be with "{}" which clears it [09:18:34] or can be some other data [09:18:35] potentially might be an idea to split the message? [09:18:40] sue [09:18:43] sure [09:19:00] mhhhm, will take a look in a bit! [09:19:06] thanks [09:20:25] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [09:27:26] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [09:29:41] (03PS2) 10Addshore: Remove unused $restore from PermissionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87676 [09:29:42] (03PS3) 10Addshore: Check permissions in MergeItems.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87669 [09:30:17] (03PS1) 10Daniel Kinzler: Introducing EntityIdLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88014 [09:30:49] (03PS5) 10Jeroen De Dauw: Update EntityId handling code [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 [09:30:58] addshore: ^ [09:31:05] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [09:31:36] (03PS1) 10Addshore: Remove duplicate method from ItemHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88021 [09:33:02] (03CR) 10Addshore: [C: 032] Update EntityId handling code [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [09:36:48] (03Merged) 10jenkins-bot: Update EntityId handling code [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/87590 (owner: 10Jeroen De Dauw) [09:37:34] free candy >>>> https://gerrit.wikimedia.org/r/#/c/87676/2 [09:39:55] addshore: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Wikibase_.22No_Direct_Editing.22 [09:39:56] (03CR) 10Hoo man: [C: 032 V: 032] "Looks harmless" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87676 (owner: 10Addshore) [09:40:26] (03CR) 10Hoo man: Remove unused $restore from PermissionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87676 (owner: 10Addshore) [09:40:26] * aude sends the candy to hoo :) [09:40:42] or he has to come visit again [09:41:26] heh :D I'd love to [09:41:54] we will keep a tally of the board, and when you next come you can jusrt spend all day catching up on eating candy and choclate ;p [09:42:13] I just fixed my Wikibase install, btw :D [09:42:25] \o/ [09:42:55] addshore: OMNOMNOM [09:44:48] Lydia_WMDE: replied to contact the dev team section :) [09:45:08] addshore: thx! [09:46:24] I think I backlogged jenkins with a bunch of draft changes :/ [09:49:20] JeroenDeDauw: >> https://gerrit.wikimedia.org/r/#/c/87680/ [09:53:24] (03PS1) 10Jeroen De Dauw: Update error info in exceptions [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88029 [09:53:35] addshore: https://gerrit.wikimedia.org/r/#/c/88029/ [09:53:56] * Jasper_Deng wonders why addshore condones the overweightness of candy [09:54:10] (03CR) 10Addshore: [C: 032] Update error info in exceptions [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88029 (owner: 10Jeroen De Dauw) [09:54:25] (03CR) 10Jeroen De Dauw: [C: 032] add TODOs for add/removeIndexSql methods in SchemaBuilders [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/87680 (owner: 10Addshore) [09:54:43] lolwat? [09:54:50] (03Merged) 10jenkins-bot: Update error info in exceptions [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88029 (owner: 10Jeroen De Dauw) [09:55:00] Jasper_Deng: you want us to feed addshore candy so he gets overweight? [09:55:08] rather, hoo [09:55:15] (03PD1) 10Addshore: Make ChangeOpClaim use guidParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88015 [09:55:28] We could change our review rule tto that you NEED to eat a cholate whenever you ereviewed something ;p [09:55:36] * hoo runs as fast as he still can (despite the candy) [09:56:36] (03PS1) 10Jeroen De Dauw: Remoove some clutter [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88030 [09:59:30] (03CR) 10Addshore: [C: 032] Remoove some clutter [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88030 (owner: 10Jeroen De Dauw) [10:00:06] (03PD1) 10Addshore: Refactor SetClaimTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88016 [10:01:50] (03CR) 10jenkins-bot: [V: 04-1] Remoove some clutter [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88030 (owner: 10Jeroen De Dauw) [10:02:17] (03PD1) 10Addshore: Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 [10:02:30] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88014 (owner: 10Daniel Kinzler) [10:03:36] (03PD1) 10Addshore: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 [10:04:36] aude: just poked hashar about http://wikidata.beta.wmflabs.org/ [10:05:22] aude: the site links seems broken on beta wikidata : / [10:05:26] aude: he said you fixed/worked around https://bugzilla.wikimedia.org/show_bug.cgi?id=45868 ? [10:05:58] (03PS1) 10Jeroen De Dauw: Update store setup and teardown in EntitiesByPropertyValueApiTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88035 [10:06:14] hashar: need to do the iptables thing? [10:06:35] aude: just did [10:06:38] ok [10:06:40] though I am not sure what is broken [10:06:54] the wikidatawiki.sites table has entries such as site_domain: gro.sbalfmw.ateb.aidepikiw.eh. [10:07:03] hashar: if I understand correctly the API call to the wikipedia to normalize titles is timing out [10:07:19] what tobi says [10:07:33] it can't do api request to beta wikipedia [10:07:38] the API call being made by some maintenance script isn't it ? [10:07:43] no [10:07:55] that was something else [10:08:02] hashar: no, an api call is done every time someone adds a sitelink [10:08:19] I have no clue how that works, do you happen to have the URL timing out ? [10:08:32] hashar: hang on [10:09:47] the code in question is in core [10:09:52] (03PD1) 10Addshore: Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 [10:09:57] MediaWikiSite::normalizePageName [10:10:01] aude: aahrr.. can't find where the call is made, do you remember? [10:10:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88015 (owner: 10Addshore) [10:10:23] wfDebugLog( "MediaWikiSite", "call to external site failed: $url" ); [10:10:27] check the debug logs on beta [10:10:37] if you set a log for that [10:10:42] hashar: ^^ [10:11:10] when i tried wget or what not when logged into beta, it failed [10:11:23] but works fine from outside beta [10:11:39] and wget from beta to outside beta works [10:11:51] aude: yeah, can remember you said this.. [10:12:05] https://www.wikidata.org/wiki/Special:ListDatatypes [10:12:26] JonMelusky: basically we can acommodate all data of those data types [10:12:38] (03CR) 10Jeroen De Dauw: [V: 032] Remoove some clutter [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88030 (owner: 10Jeroen De Dauw) [10:12:41] JonMelusky, you can join multiple channels at a time by the way; just click their channel names. (#wikipedia-en-help, #wikimedia-commons, for example) [10:12:54] (the ones referenced in another channel) [10:13:00] wikidatawiki-50eb305c: 5.4090 11.8M [MediaWikiSite] call to external site failed: http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&prop=info&redirects=1&converttitles=1&format=json&titles=Wikipedia+in+culture [10:13:02] :( [10:13:08] hashar: yep [10:13:14] ok [10:13:18] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88015 (owner: 10Addshore) [10:13:21] beta has the full debug log in /data/project/logs/web.log [10:13:32] hashar: yes, that's the problem [10:13:37] but it works from outside [10:13:49] we hacked around it with iptables for the populate sites script [10:14:05] i don't know if iptables can fix this or what is required [10:14:11] and yeah that is one of the Apaches attempting to access the public IP of an instance which is not supported in labs due to bug 45868 [10:14:16] aude: could be difficult to do that here [10:14:23] iptables probably has to be done on other instances [10:14:54] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#45 (master - 0c0d00e : jeroendedauw): The build has errored. [10:14:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/f4c2aeb9a471...0c0d00e67191 [10:14:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12223971 [10:15:17] JonMelusky: (sry for the noise in here) You may ask questions at http://www.wikidata.org/wiki/Wikidata:Project_chat [10:15:26] So in wikidata - create new item....what do people usually put for labels and Descriptions if it were to be cemetery data ? [10:15:46] the descriptions should be dictionary-style descriptions [10:15:50] Tobi_WMDE: aude: so yeah we need to manually apply the iptables rules on the other instances :/ [10:15:58] (03PD1) 10Addshore: Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 [10:16:04] hashar: ick [10:16:07] Tobi_WMDE: aude: I really need to escalate this on ops side so we get the rules applied by puppet. [10:16:10] addshore: I fixed the brokeness in wikibase query that made danwe mad: https://gerrit.wikimedia.org/r/#/c/88035/ [10:16:11] hashar: ok. :/ [10:16:13] and then everytime stuff is rebooted [10:16:27] JonMelusky: before you start to create items, I would recommend you first familiarize yourself with the concept of properties [10:16:34] (03PS1) 10Jeroen De Dauw: Improve dependency fetching [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88039 [10:16:58] (03CR) 10Addshore: [C: 032] Update store setup and teardown in EntitiesByPropertyValueApiTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88035 (owner: 10Jeroen De Dauw) [10:17:19] Are properties listed on the Wikidata:Introduction website ? [10:17:38] (03PS15) 10Jeroen De Dauw: (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [10:17:39] https://www.wikidata.org/wiki/Wikidata:List_of_properties [10:18:29] labs NFS is dead :/ [10:18:49] hashar: really..? [10:18:57] JeroenDeDauw: what would you propose for https://gerrit.wikimedia.org/r/#/c/88015/? [10:19:39] So a cemetery marker would be a Wikidata:List of properties/Geographical feature ? [10:20:08] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#46 (master - 999a278 : jeroendedauw): The build has errored. [10:20:08] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/0c0d00e67191...999a278a7f35 [10:20:08] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12224073 [10:20:35] ah, that explains why I can't update things on tool labs :/ [10:21:00] :( [10:21:28] JonMelusky: That is beyond my knowledge because I don't work in this field, but if you can't find it, request for the property at http://www.wikidata.org/wiki/Wikidata:Property_proposal [10:21:35] JonMelusky: if you're looking for "place of burial", it's P119 https://www.wikidata.org/wiki/Property:P119 [10:22:49] Thank you Pyb! (^:= **hugs** [10:24:01] Thank you Jasper_Deng! **hugs** I might be back to ask more questions...*grins [10:24:13] I might not be here unfortunately [10:25:37] (03PS1) 10Jeroen De Dauw: Attempt to fix TravisCI build [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88041 [10:29:26] Hai guyz [10:29:49] I found this awesome website [10:29:54] bootysweat.org ! [10:30:14] a [10:30:14] a [10:30:14] a [10:30:15] a [10:30:15] a [10:30:15] a [10:30:15] a [10:30:16] a [10:30:16] a [10:30:17] a [10:30:17] a [10:30:18] a [10:30:18] a [10:30:19] a [10:31:13] :O [10:31:37] JeroenDeDauw: how can I make you happy with https://gerrit.wikimedia.org/r/#/c/88015/ ? :) [10:38:54] http://ultimategerardm.blogspot.nl/2013/10/more-heady-stuff-about-wikidata-and.html [10:41:37] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/82874/ [10:42:46] addshore: 5 BTC [10:44:13] (03PS5) 10Jeroen De Dauw: Remove SimpleQuery::CACHE_TTL_IN_SECONDS [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83098 (owner: 10Daniel Werner) [10:44:15] (03CR) 10Jeroen De Dauw: [C: 032] Remove SimpleQuery::CACHE_TTL_IN_SECONDS [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83098 (owner: 10Daniel Werner) [10:44:23] (03PD1) 10Addshore: Cleanup Wikibase\Lib phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88023 [10:44:25] (03PS1) 10Daniel Kinzler: Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 [10:44:26] (03CR) 10Jeroen De Dauw: [C: 031] (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [10:44:46] value formatter builders? [10:47:03] addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=55350 <- is this what you looked into earlier? [10:49:07] aude: Tobi_WMDE: labs is back up. I have applied the iptables hack on the apache instances, the wikidata api call should be working now. [10:49:18] hashar: great [10:49:39] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=55348 <- is this what you are working on? [10:49:56] Lydia_WMDE: yes [10:50:44] hashar: works for me now. cool, thx! [10:51:15] hashar: will this issue re-appear once one of the instances are rebooted= [10:51:17] ? [10:51:23] yes it will [10:51:28] iptables rules disappear on reboot [10:51:51] the fix would be to write rules using a firewall configuration tool named 'ferm' [10:52:01] I don't have time to investigate how ferm works :-( [10:52:11] so I reapply the rules from time to time :( [10:52:21] (03CR) 10Jeroen De Dauw: [C: 032] "Issue to be fixed later" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88015 (owner: 10Addshore) [10:52:29] hashar: how often will a reboot happen? [10:52:47] the only occurrences of 'ferm' I have found on wikitech is https://wikitech.wikimedia.org/wiki/Projects#Network-based_security [10:52:58] it hasn't started yet :D [10:52:59] (03CR) 10Jeroen De Dauw: [C: 032] Refactor SetClaimTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88016 (owner: 10Addshore) [10:53:12] Tobi_WMDE: the instance reboot from time to time when there is an outage on labs [10:53:45] hashar: ok. so, I'll try to enable browsertests for sitelinks then [10:53:56] and turn them off when they fail too often [10:53:57] hm [10:54:14] hashar: or just poke you everytime they fail.. hehe [10:55:34] or get someone to apply the iptables rules listed on comment #10 https://bugzilla.wikimedia.org/show_bug.cgi?id=45868#c10 :D [10:55:53] essentially, whenever we get 'ferm' that will no more be an issue [10:56:14] given my current workload, that is not going to happen before january if I am the one ending up doing it :/ [10:56:20] hopefully ops will take care of ferm before that [10:56:26] but they are quite busy folks [10:57:21] (03PS20) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [10:57:33] (03CR) 10jenkins-bot: [V: 04-1] Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:03:03] (03PS2) 10Daniel Kinzler: Introducing EntityIdLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88014 [11:03:32] I am going to restart Zuul , events might not proceeded for a few minutes [11:04:08] eek [11:04:16] just when i'm in the middle of a rebase fest# [11:04:27] (03PD1) 10Addshore: Remove use of 2 deprecated js methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88046 [11:04:33] (03PS2) 10Daniel Kinzler: Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 [11:04:35] it is smart enough to wait for jobs to finish usually [11:04:35] :D [11:04:47] usually :> [11:05:51] (03PS1) 10Henning Snater: Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [11:06:15] (03CR) 10Jeroen De Dauw: [C: 032] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87545 (owner: 10Aude) [11:06:28] aude: follow up suggestions: https://gerrit.wikimedia.org/r/#/c/87545/ [11:07:02] (03PS2) 10Jeroen De Dauw: Attempt to fix TravisCI build [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88041 [11:07:07] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Attempt to fix TravisCI build [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88041 (owner: 10Jeroen De Dauw) [11:08:26] (03PS21) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [11:10:07] (03CR) 10Addshore: [C: 032] Introducing EntityIdLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88014 (owner: 10Daniel Kinzler) [11:11:58] (03CR) 10Siebrand: [C: 031] "L10n/i18n LGTM." [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [11:12:34] (03CR) 10Addshore: [C: 032] Improve dependency fetching [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88039 (owner: 10Jeroen De Dauw) [11:13:59] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#47 (master - 9150c06 : jeroendedauw): The build has errored. [11:13:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/999a278a7f35...9150c060e3a9 [11:13:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12225305 [11:14:53] ahh [11:15:11] when looking at the mwext-Wikibase-repo-tests job I noticed a single test takes much of the time : / [11:15:21] Wikibase\Test\Api\GetEntitiesTest::testGetEntities 2 minutes and 16 seconds [11:15:27] https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/4502/testReport/(root)/ (sort by Duration) [11:15:38] it has a lot of test cases in it :> [11:15:38] https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/4502/testReport/(root)/Wikibase_Test_Api_GetEntitiesTest__testGetEntities/ [11:15:42] * aude not surprised [11:15:46] I guess it does a bunch of curl request isn't it ? [11:16:35] lots of web requests, and oh my! I love this testReport thing! [11:16:52] (03CR) 10jenkins-bot: [V: 04-1] Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 (owner: 10Henning Snater) [11:16:58] (03PS1) 10Aude: (bug 55348) Handle formatting of undeserializable values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 [11:17:31] addshore: what ever does the curl request, that should be mocked to speed up the test :D [11:17:50] well, not a curl request [11:18:17] (03CR) 10Aude: "this will conflict with daniel's creation of wikibase value formatter builders and will require a rebase somewhere, but we also like this " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:18:37] DanielK_WMDE: ^ [11:18:54] i am not happy with the ability to handle messages and inject stuff into formatters [11:19:04] addshore: so just slow :-D If one look at optimizing that test, that will make the jenkins jobs faster :-] [11:19:08] if you have suggestions on how to do it better..... [11:19:13] hashar: there is no real way to mock them up to make them faster :/ we use cores ApiTestCase->doApiRequest() method [11:19:52] addshore: i think there might be ways [11:20:04] mhhhm, youd have to play around with core though :P [11:20:32] 120ms i surely a bunch, not sure where the slowdown is though [11:20:33] or mock stuff or structure so we can do more dependency injection stuff [11:20:38] might want to profile the test [11:21:24] oh it also does a db read [11:21:34] (if i remember corectly) [11:22:25] oh actually that might just be another api request.. [11:22:52] (03CR) 10jenkins-bot: [V: 04-1] Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:25:08] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:25:21] Zuul restarted and proceeding events again. [11:25:35] gah! *heul* [11:27:03] (03Merged) 10jenkins-bot: Improve dependency fetching [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88039 (owner: 10Jeroen De Dauw) [11:27:04] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:27:17] (03Merged) 10jenkins-bot: Introducing EntityIdLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88014 (owner: 10Daniel Kinzler) [11:28:57] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#48 (master - 8885747 : jenkins-bot): The build has errored. [11:28:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/9150c060e3a9...8885747def00 [11:28:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12225833 [11:28:59] hashar: Im guessing it would be possible to execute the api tests and the other repo tests side by side in seperate jobs / tasks on jenkins? :O (might be a bad idea but could speed things up) [11:29:50] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:30:14] (03PS2) 10Addshore: Cleanup Wikibase\Lib phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88023 [11:30:16] (03PS1) 10Aude: (bug 55348) Handle formatting of undeserializable values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88051 [11:31:29] (03PS2) 10Aude: (bug 55348) Handle formatting of undeserializable values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 [11:34:13] (03CR) 10jenkins-bot: [V: 04-1] (bug 55348) Handle formatting of undeserializable values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88051 (owner: 10Aude) [11:34:36] jenkins says no but travis says yes! [11:42:28] (03PS1) 10Addshore: Add logic and tests for getRemoveIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88053 [11:42:55] (03PD1) 10Addshore: Rename ChangeOp test dir and fix @covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88052 [11:44:59] *sigh* [11:45:17] every time i9 think i understand how git interacts with gerrit, it does something odd and surprising [11:45:26] :> [11:45:34] gerrit is hungry! [11:45:41] now my rebased change is based on two different commits of the same change, at the same time o_O [11:45:43] wtf. [11:45:44] did it eat your patch? [11:46:00] how is that possible? [11:46:35] DanielK_WMDE: btw, can you provide feedback on https://gerrit.wikimedia.org/r/#/c/88050 and https://gerrit.wikimedia.org/r/#/c/88051 ? [11:46:59] right now diff display is broken for too many items [11:47:16] aude: sorry, first iu have to climb out of this mess [11:47:21] ok :/ [11:47:30] looks like 4 complicated rebases :( [11:47:34] anyone can review.... [11:47:45] one patch is against the branch [11:47:49] applies cleanly [11:47:58] the other will need to be rebased against your stuff [11:48:15] and be made nicer, in terms of tests if possible [11:53:11] (03CR) 10Daniel Kinzler: [C: 032] "It's the right thing to do. I haven't tested it, but I trust Katie has." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:53:21] DanielK_WMDE: indeed [11:53:26] :)( [11:53:41] as i say in the commit message, would be nice to show more details [11:53:42] if possible [11:53:57] i can make another bug for that [11:54:01] (03PS1) 10Addshore: Introducing IndexSqlBuilders [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88054 [11:54:13] (03PS22) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [11:54:32] aude: sure. you can grab info from the UnDeserializableValue object and pass it to the message as parameters [11:54:46] that can include a serialized version ofthe raw data [11:54:56] (not sure if that's desirable, but it's an option) [11:55:14] DanielK_WMDE: thought about it [11:55:32] i actually think we had that at one point [11:55:41] strangely it formatted at one point [11:55:56] showed a list of all the value params in the diff [11:56:42] (03Merged) 10jenkins-bot: (bug 55348) Handle formatting of undeserializable values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [11:56:53] aude: i probably removed the special case handling for that when making it use formatters [11:57:01] and then forgot to make a formatter for bad values [11:57:03] thanks for fixing [11:57:17] ok [11:57:39] once it is backported, i can see about my bot actually setting globes :) [11:57:49] i don't want to do that when the diffs are broken [11:58:03] can you backport yourself? [11:58:08] i see no problem with that [11:58:14] one patch is against the branch [11:58:20] https://gerrit.wikimedia.org/r/#/c/88051 [11:58:28] you can approve it [11:59:03] (03CR) 10Daniel Kinzler: [C: 032] "backport" [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88051 (owner: 10Aude) [11:59:04] * aude goes to get food [11:59:12] (03CR) 10Daniel Kinzler: [V: 032] "backport" [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88051 (owner: 10Aude) [11:59:16] * DanielK_WMDE kicks jenkins [11:59:25] travis should approve [12:02:57] addshore: would you have a look at https://gerrit.wikimedia.org/r/#/c/88044/ and perhaps also https://gerrit.wikimedia.org/r/#/c/84313/ ? [12:03:06] that would move the whole formatter mess a big step forward [12:03:11] will do after I finish this patch [12:03:16] and i don't really want to have to rebase all that stuff again :) [12:03:30] addshore: thanks! [12:05:36] oh wow, rainman was here and i missed him?! [12:05:40] damn! [12:05:53] ah no - i misread. [12:05:56] too bad. [12:06:34] (03PS2) 10Addshore: Introducing IndexSqlBuilders [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88054 [12:08:10] heh already started looking at 88044 ;p [12:11:43] this is the tree of changes I have been wanting to review and merge for ages :D [12:12:07] (03CR) 10Addshore: [C: 032] Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [12:12:14] (03CR) 10jenkins-bot: [V: 04-1] Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [12:12:21] . [12:12:49] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [12:20:55] (03CR) 10Addshore: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [12:21:07] DanielK_WMDE: I managed to -1 them both for you ;p [12:23:00] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88054 (owner: 10Addshore) [12:24:06] (03CR) 10Jeroen De Dauw: [C: 032] Check permissions in MergeItems.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87669 (owner: 10Addshore) [12:24:07] (03Merged) 10jenkins-bot: Remove unused $restore from PermissionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87676 (owner: 10Addshore) [12:25:37] (03CR) 10Addshore: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88054 (owner: 10Addshore) [12:26:51] (03PS1) 10Jeroen De Dauw: Update TravisCI config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88061 [12:26:59] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update TravisCI config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88061 (owner: 10Jeroen De Dauw) [12:27:30] addshore: thanks, will fix [12:28:17] (03PS8) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 [12:28:25] (03CR) 10jenkins-bot: [V: 04-1] Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 (owner: 10Daniel Kinzler) [12:28:41] oh ffs [12:30:13] free candy? ;p https://gerrit.wikimedia.org/r/#/c/88023/ [12:30:58] (03PS3) 10Daniel Kinzler: Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 [12:31:23] (03PS23) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [12:32:11] addshore: wtf is https://gerrit.wikimedia.org/r/#/c/88023/ ? [12:32:14] changing all the tests! [12:32:26] cleaning all of the tests! no logic changes ;p [12:32:32] :) [12:32:51] merge merge merg ;p [12:33:01] * aude steals cand bowl for that [12:33:05] candy [12:33:08] :O [12:33:36] its only about 2000 lines across a gazillion files ;p [12:33:55] (03PS24) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [12:34:39] addshore: fixed both (i hope). waiting for jenkins [12:34:46] :> [12:35:02] (03PS9) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 [12:35:10] DanielK_WMDE: the time validator patch has minor feedback, if you have time to work on that [12:35:17] then it is ready for merge [12:35:21] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#49 (master - 53922fa : jeroendedauw): The build has errored. [12:35:21] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/8885747def00...53922fab7ac7 [12:35:21] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12227807 [12:35:32] aude: yea, will do that now before continuing the rebase fest [12:35:38] ok [12:37:50] (03PS2) 10Daniel Kinzler: (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 [12:37:51] aude: ---^ [12:37:58] DanielK_WMDE: ok [12:38:00] (03CR) 10jenkins-bot: [V: 04-1] (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 (owner: 10Daniel Kinzler) [12:38:10] wtf is wrong with jenkins? [12:38:30] ok, needs rebase [12:38:50] its based on 4d664d0f37b4e9af0c9d34dd4ace6cb3b837786c Merge "Display entity id next to entity label" :P [12:38:57] which i recall being weeks ago :P [12:39:04] ah [12:39:32] it has been getting stale for a while, yes [12:39:40] it's got easyRdf in it [12:39:45] it'S the pesky submodule conflict [12:39:46] part of rebase, i assume [12:39:50] ok [12:39:52] havn't figured out how to fix that with a rebase [12:39:55] cherry-pick here i come [12:40:27] cherry-pick is the best. [12:40:48] DanielK_WMDE: did you change anything else with the Introducing WikibaseValueFormatterBuilders. changeset or just fixed my comment? [12:40:59] oh wait, this is the one I already +2ed.. [12:41:11] Is it just a rebase? :) [12:43:06] (03CR) 10Aude: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88021 (owner: 10Addshore) [12:44:14] (03PS3) 10Daniel Kinzler: (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 [12:44:24] aude: ---^ [12:44:33] ok [12:45:01] (03PS2) 10Addshore: Remove duplicate method from ItemHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88021 [12:45:02] aude: ---^ [12:45:07] :) [12:45:11] [= [12:45:23] * aude reviewing the 2000 lines of code [12:45:27] :> [12:46:03] (03CR) 10Addshore: [C: 032] Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [12:46:10] lets see if this actually merges this time.. [12:50:29] (03PS1) 10Jeroen De Dauw: Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 [12:52:27] (03CR) 10Jeroen De Dauw: [C: 032] Cleanup Wikibase\Lib phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88023 (owner: 10Addshore) [12:52:32] (03CR) 10Tobias Gritschacher: [C: 032] (bug 54493) Extend cucumber sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85856 (owner: 10Tobias Gritschacher) [12:53:02] aude: JeroenDeDauw beat you :P [12:53:14] lol [12:54:29] (03PS1) 10Jeroen De Dauw: Remove unused var in EntityPerPageBuilderTest and clarify control flow [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88067 [12:55:11] (03Merged) 10jenkins-bot: Introducing WikibaseValueFormatterBuilders. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [12:55:52] (03CR) 10Addshore: [C: 032] Remove unused var in EntityPerPageBuilderTest and clarify control flow [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88067 (owner: 10Jeroen De Dauw) [12:56:02] (03PS2) 10Henning Snater: Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [12:56:03] (03PS2) 10Henning Snater: Claimview "movetoolbar" definition refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 [12:56:04] (03PS3) 10Henning Snater: Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 [12:56:05] (03PS3) 10Henning Snater: Improved snaklistview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85676 [12:57:14] addshore: aude: without me even trying! :) [12:57:29] addshore: Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/88064/ That should fix the issue [12:59:22] (03CR) 10Addshore: [C: 032] Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 (owner: 10Jeroen De Dauw) [12:59:45] Zuul: Queue only mode: preparing to exit, queue length: 19 :< [13:01:35] (03PS1) 10Jeroen De Dauw: Update TravisCI config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88070 [13:01:59] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [13:02:33] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [13:02:34] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update TravisCI config [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88070 (owner: 10Jeroen De Dauw) [13:02:42] (03CR) 10Aude: [C: 032] (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 (owner: 10Daniel Kinzler) [13:02:48] JeroenDeDauw: fixes that problem but there's still another [13:02:52] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [13:03:27] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 (owner: 10Daniel Kinzler) [13:04:01] more free candy >> https://gerrit.wikimedia.org/r/#/c/88052/ [13:04:09] (03Merged) 10jenkins-bot: (bug 54493) Extend cucumber sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85856 (owner: 10Tobias Gritschacher) [13:04:31] zuul finally restarted :) [13:05:57] (03PS2) 10Jeroen De Dauw: Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 [13:06:08] (03PS3) 10Jeroen De Dauw: Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 [13:06:19] (03PS2) 10Jeroen De Dauw: Remove unused var in EntityPerPageBuilderTest and clarify control flow [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88067 [13:06:29] (03CR) 10Jeroen De Dauw: [C: 032] "CR by addshore" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88067 (owner: 10Jeroen De Dauw) [13:06:33] (03CR) 10jenkins-bot: [V: 04-1] Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 (owner: 10Jeroen De Dauw) [13:06:49] hah! [13:07:33] (03PS4) 10Jeroen De Dauw: Get rid of some misplaced dependency management behaviour [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 [13:09:18] (03CR) 10Addshore: [C: 032] Get rid of some misplaced dependency management behaviour. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 (owner: 10Jeroen De Dauw) [13:09:31] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#50 (master - d1cc90a : jeroendedauw): The build passed. [13:09:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/53922fab7ac7...d1cc90a6341e [13:09:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12229184 [13:10:23] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [13:11:28] (03CR) 10Jeroen De Dauw: "Please be careful when merging things. This commit had dead references in it, duplicate code and some other stuff..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [13:12:09] (03PS5) 10Jeroen De Dauw: Get rid of some misplaced dependency management behaviour. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 [13:12:21] .. that was merged / in the queue to be merged before your change [13:13:13] 50th build is a charm? https://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds :) [13:16:19] (03CR) 10Addshore: "dead references and duplicate code? If they exist in this change I fail to spot them!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88044 (owner: 10Daniel Kinzler) [13:17:10] (03CR) 10Addshore: [C: 032] Get rid of some misplaced dependency management behaviour. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 (owner: 10Jeroen De Dauw) [13:25:16] (03PS2) 10Addshore: Add logic and tests for getRemoveIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88053 [13:25:20] (03Merged) 10jenkins-bot: (bug 54333) Validate time precision. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84996 (owner: 10Daniel Kinzler) [13:28:07] (03PS1) 10Jeroen De Dauw: Update credits to reflect more significant contribs by Adam Shorland [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88073 [13:29:26] (03CR) 10Addshore: [C: 032] Update credits to reflect more significant contribs by Adam Shorland [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88073 (owner: 10Jeroen De Dauw) [13:29:31] (03Merged) 10jenkins-bot: Update credits to reflect more significant contribs by Adam Shorland [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88073 (owner: 10Jeroen De Dauw) [13:29:59] (03PS1) 10Aude: cleanup in NumberRangeValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88074 [13:31:25] (03CR) 10Jeroen De Dauw: "What are you trying to do with this change?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater) [13:32:07] (03CR) 10Addshore: [C: 032] cleanup in NumberRangeValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88074 (owner: 10Aude) [13:32:11] addshore: do link your name in the credits if you want to [13:33:22] (03PS1) 10Aude: Pass data provider message param in NumberValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88076 [13:34:03] (03CR) 10Addshore: [C: 032] Pass data provider message param in NumberValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88076 (owner: 10Aude) [13:34:29] how many patches do we have today? [13:34:38] aude: <9000 [13:34:45] :D [13:37:07] (03PS8) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 [13:37:41] addshore: so, in your SetClaim patch, my bot still needs to create a guid? [13:37:58] (03Merged) 10jenkins-bot: Get rid of some misplaced dependency management behaviour. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88064 (owner: 10Jeroen De Dauw) [13:38:12] * aude pokes at it [13:38:45] it works / should work exactly as it did before [13:38:48] ok [13:38:57] potentially with more validation than before [13:39:05] alright [13:39:25] it doesn't break my bot :) [13:40:18] oh, too soon to say that [13:40:28] ? :P what happened [13:40:54] * aude testing it with createclaim :) [13:41:02] hah! [13:41:06] let's try it with setclaim [13:43:03] (03PS7) 10Daniel Kinzler: Remove formmating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 [13:43:14] oh, weird, it accepts my edit summary [13:43:30] and shows nothing of the default summary [13:43:38] mhhhhmmm.... [13:43:39] addshore: is that the intended behavior [13:44:04] so if you give it a custom summary it overwrites the default summary? [13:44:06] (03Merged) 10jenkins-bot: cleanup in NumberRangeValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88074 (owner: 10Aude) [13:44:25] aude, addshore: that's how custom summaries got implemented, yes [13:44:32] "Created claim: adding data from enwiki" [13:44:50] ahh aude yes that is how they are implemented, I thought you meant it got rid of everything [13:44:50] * aude reminded to make my summary not enwiki specific [13:44:54] i'm not sure that this is what we agreed on, but it apparently got reviewed and verified. [13:44:56] (03PS3) 10Henning Snater: Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [13:44:57] addshore: ok [13:45:01] it's working as designed [13:45:03] i never actually seen it [13:45:10] hah! :) [13:45:10] since it didn't work with setclaim [13:45:13] me neither xD [13:45:55] rejoyce and rebase... [13:48:30] "Added a language link to connect pages [↔$3]: enwiki:Oslo, cswiki:Swindon Town FC" [13:48:34] huh [13:48:42] DanielK_WMDE: your stuff will apply formatting to that? [13:49:45] aude: it will use formatters, but the output will (for now) stay the same [13:49:53] hmmmm [13:50:06] except for time and geo - these no get formatted properly [13:50:13] nice :) [13:50:14] (03Merged) 10jenkins-bot: Pass data provider message param in NumberValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88076 (owner: 10Aude) [13:50:31] aude: the system could be improved, but for now I tried to just stay compatible [13:50:57] ok [13:51:09] i just think we might have a bug in the linktitles summary or somewhere [13:51:14] (ideally, there would just be a json blob, and we'd always render it on the fly - but i don't think that's possible) [13:51:20] can check once stuff gets merged [13:53:16] (03PS25) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [13:53:30] (03CR) 10jenkins-bot: [V: 04-1] Remove formmating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [13:53:31] addshore: got 2 mins? [13:53:38] grrrraaahhhh! [13:53:42] sorry. [13:55:21] (03PS10) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 [13:55:30] (03PS9) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 [13:55:37] (03PS8) 10Daniel Kinzler: Remove formmating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 [13:56:34] * Lydia_WMDE hands DanielK_WMDE a cup of tea [13:57:03] * addshore hands DanielK_WMDE a beer [13:59:39] * DanielK_WMDE mixes tea and beer and drinks deeply [13:59:47] **BLAARGH** [13:59:50] ok, better now :) [14:00:28] (03PS1) 10Addshore: Add logic and tests for getAddIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 [14:01:34] (03PS2) 10Addshore: Add logic and tests for getAddIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 [14:05:18] aude: can you please close https://bugzilla.wikimedia.org/show_bug.cgi?id=51876 if it is done? thx [14:05:21] it looks done to me [14:10:57] hey [14:11:09] addshore: y why u writing like this: if( array_key_exists( 'props', $params ) ){ ? [14:11:11] (no spaces) [14:11:29] because i tend to miss those spaces :P [14:11:45] now I don't know how to write [14:11:53] (in getentitiestest) [14:11:54] dont copy me ;p [14:12:12] "now I don't know how to write" <- sound kinda strange, eh? [14:12:13] (03CR) 10Aude: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [14:13:15] Lydia_WMDE: closed [14:13:23] aude: thx [14:17:16] (03PS2) 10Addshore: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 [14:17:17] aude: ^^ [14:17:24] (03CR) 10Aude: "hmmm, i also get these test failures on master though not on all my test wikis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [14:17:42] aude: I bumped the IDs up into the thousands :) [14:17:47] ok [14:17:49] I imagine they should pass now [14:19:28] JeroenDeDauw: I imagine we need things such as MWTableDefinitionReaderBuilder also in Database? [14:19:52] addshore: UsageException: Property P4200 not found [14:19:57] something is odd [14:20:10] mhhhm.. [14:20:12] could be just my test wiki or maybe travis too [14:20:25] everything seems to pass for me [14:20:41] and that bit of the code hasnt changes at all :P [14:20:51] yeah [14:21:07] I think DanielK_WMDE might get these too sometimes (I remember it being setclaim) [14:23:38] (03PS3) 10Michał Łazowik: Merge sitelinks/badges to sitelinks (api props) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 [14:23:45] (03CR) 10jenkins-bot: [V: 04-1] Merge sitelinks/badges to sitelinks (api props) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 (owner: 10Michał Łazowik) [14:28:58] aude: hello! [14:29:28] hi [14:30:04] I took the last week off and joined a few classes [14:30:07] dancing and guitar! :) [14:30:10] ok :) [14:30:17] did you read my summary blog post? [14:30:24] yes, it's great [14:30:33] thanks :) [14:30:41] how do you feel about using css3 animations instead of jquery? [14:31:11] I've tried mobile query on a range of phones and other than the top-end iPhones, it's always sluggish [14:31:13] i think that would be okay, although it's not my expertise [14:31:20] ask jon [14:31:24] I can deal with that [14:31:32] I've experimented with css animations befoer [14:31:33] don't know what approach they take [14:31:37] ok [14:31:42] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [14:31:42] but yes, I should get his opinion too [14:32:37] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [14:32:54] Lydia_WMDE: do you have a suggestion for https://gerrit.wikimedia.org/r/#/c/88050/ ? [14:32:59] I'm still a little foggy on the claims html part [14:33:05] what to say in a diff when one of the values is a bad value [14:33:11] e.g. cannot be deserialized [14:33:21] what should we tell the users?] [14:33:49] we want to say something [14:33:52] not nothing [14:34:16] "Value cannot be deserialized" [14:34:21] too techy [14:34:44] aude: "oopsy"? [14:34:51] :) [14:35:05] yes! [14:35:07] DanielK_WMDE: NO! :P [14:35:22] "Guru Meditation" [14:35:27] DanielK_WMDE: A t-rex saying 'oopsy' [14:35:33] t-rexes make things better [14:35:40] heh [14:35:40] :> [14:35:41] :P [14:35:57] https://en.wikipedia.org/wiki/File:Guru_meditation.gif [14:36:09] (epilesy trigger warning) [14:36:12] http://playerpianosara.files.wordpress.com/2012/01/trex.jpg?w=627 [14:36:23] addshore: yeah [14:36:40] let's do that! [14:36:43] JeroenDeDauw: is that yeah in response to my earlier question? Or the picture of the trex in a hat? [14:37:11] how about "The value is invalid and cannot be displayed" ? [14:37:16] addshore: question [14:37:20] not to make the user think they caused the error [14:37:34] use that, yeah [14:37:37] ok [14:37:40] +1 [14:37:42] aude: but "the value is invalid" sounds like someone entered a bad value... [14:38:11] well they did [14:38:15] maybe not the person viewing the fdiff [14:38:17] diff [14:38:22] but someone did [14:38:29] (03PS1) 10Jeroen De Dauw: Added config for phpunit-testrunner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88109 [14:38:29] http://rlv.zcache.com/dinosaur_cant_clap_joke_post_card-r8e39f51ce8704ababd5f249312193a88_vgbaq_8byvr_512.jpg [14:39:32] (03PS1) 10Aude: Improve wording for bad value to display in diffs, etc. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88110 [14:40:39] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [14:40:55] but always remember http://cdn.lolzbook.com/wp-content/uploads/2013/06/T-rex-Deers.jpg [14:41:01] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Added config for phpunit-testrunner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88109 (owner: 10Jeroen De Dauw) [14:41:09] Lydia_WMDE: want chocolate? https://gerrit.wikimedia.org/r/#/c/88110/ [14:41:57] haha addshore have I started something here? :p [14:42:01] :> [14:42:19] (03CR) 10Lydia Pintscher: [C: 032] Improve wording for bad value to display in diffs, etc. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88110 (owner: 10Aude) [14:42:21] Im going to start printing them and sticking them everywhere111 mwwhahahhaaahaaa [14:42:41] (03PS4) 10Michał Łazowik: Merge sitelinks/badges to sitelinks (api props) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 [14:44:27] (03CR) 10Michał Łazowik: "Patch Set #4 is a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 (owner: 10Michał Łazowik) [14:44:33] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [14:44:55] addshore: https://gerrit.wikimedia.org/r/#/c/87615/ (if jenkins approves of that) [14:46:47] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=54497 Do you have further details on that? I can't get the widget to load on commons at all [14:47:06] (03CR) 10Jeroen De Dauw: [C: 032] Add logic and tests for getRemoveIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88053 (owner: 10Addshore) [14:47:10] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88050 (owner: 10Aude) [14:47:57] (03Merged) 10jenkins-bot: Improve wording for bad value to display in diffs, etc. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88110 (owner: 10Aude) [14:49:55] (03PS1) 10Aude: Improve message displayed in diffs, etc. for bad values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88111 [14:49:58] and offering more chocolate ^ [14:50:37] (03PS1) 10Jeroen De Dauw: Improve MySQLSchemaSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88112 [14:50:47] (03CR) 10Addshore: [C: 032] Improve message displayed in diffs, etc. for bad values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88111 (owner: 10Aude) [14:50:53] :) [14:51:04] (03CR) 10jenkins-bot: [V: 04-1] Improve message displayed in diffs, etc. for bad values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88111 (owner: 10Aude) [14:51:08] (03CR) 10Addshore: [C: 032] Improve MySQLSchemaSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88112 (owner: 10Jeroen De Dauw) [14:51:14] addshore: you will need to remove jenkins and +2 verify [14:51:19] kk :) [14:51:21] (03Merged) 10jenkins-bot: Improve MySQLSchemaSqlBuilderTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88112 (owner: 10Jeroen De Dauw) [14:51:25] travis should run tests and approve for the branch [14:51:30] (03CR) 10Addshore: [V: 032] Improve message displayed in diffs, etc. for bad values [extensions/Wikibase] (mw1.22-wmf18) - 10https://gerrit.wikimedia.org/r/88111 (owner: 10Aude) [14:51:54] merged :) [14:51:58] thanks [14:51:59] aude: It is asking me to log in on wikidata [14:52:08] hoo: where? [14:52:12] on commons [14:52:17] huh [14:52:23] for your widget? [14:52:27] had to fake around a bit to get the widget to load yep [14:52:34] oh [14:52:57] mhhm lazowik what would happen if we also displayed or tried to display badges when sitelinks/removed was present? [14:53:05] even though you are logged in on commons? [14:53:19] aude: The error Denny saw was a different one, I guess [14:53:34] (03CR) 10Jeroen De Dauw: [C: 04-1] "(4 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 (owner: 10Addshore) [14:53:39] hoo: i don't know [14:54:13] he's probably using Chromium or Chrome which I think throws an error in case CORS is disallowed [14:54:32] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 (owner: 10Addshore) [14:54:33] Might be a configuration thing after all... going to debug further in a second [15:05:38] aude: It's working now ... though it's not showing me any langs to link to [15:06:10] hoo: that was the issue [15:06:31] there is a setting to tell it which site group to use (other than it's own) [15:06:52] with that, maybe it works but think there was an s [15:06:54] issue [15:07:09] aude: Well, the resource loader module probably needs to be fixed [15:07:16] probably [15:07:45] oh no, it doesn't [15:08:47] sites = wb.getSitesOfGroup( siteGroup ); [15:09:03] (where siteGroup is the current site group) that doesn't work on commons [15:09:20] ok, that makes sense [15:10:38] (03PS3) 10Addshore: Add logic and tests for getAddIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 [15:11:16] aude: Easiest: Introduce a wbLinkSiteGroup (or so) and fill it server side [15:12:27] If you want to link both 'voyage and wikipedia, make it an array (I don't really know how the commons thing works) [15:12:51] lazowik: around? [15:13:13] commons links to wikipedia [15:13:24] wikipedia is the site group [15:13:26] Ok, that's fine... having both would be confusing [15:14:10] (03CR) 10Addshore: [C: 031] "What would happen if we also tried to display badges when sitelinks/removed was true?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 (owner: 10Michał Łazowik) [15:15:35] addshore: yes, sorry [15:15:39] nothing probably ;) [15:15:54] (03CR) 10Addshore: [C: 032] Merge sitelinks/badges to sitelinks (api props) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 (owner: 10Michał Łazowik) [15:16:04] just doesn't make too much sense [15:16:05] no concerns then, looks fine :) [15:17:44] addshore: generally sitelinks/removed is quite strange [15:17:53] it adds removed to every sitelink... [15:19:11] (03Merged) 10jenkins-bot: Merge sitelinks/badges to sitelinks (api props) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/87615 (owner: 10Michał Łazowik) [15:19:27] yay [15:23:47] addshore: sitelinks/removed is only used internally and added to every sitelink [15:23:52] when one is deleted [15:23:57] yup [15:24:01] but then only this deleted is shown [15:24:22] so it's a strange way to show that one sitelink got deleted [15:24:31] (03PS2) 10Daniel Kinzler: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 [15:24:34] and then we do not care what badges it had ;) [15:24:51] (03CR) 10jenkins-bot: [V: 04-1] Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [15:25:34] grrrrr!! [15:25:59] wtf? syntax error?? [15:26:52] No syntax errors detected in repo/includes/EntityView.php [15:26:53] o_O [15:28:48] *looks* [15:28:50] oh oops. forget to git add >_< [15:28:55] addshore: nvm [15:29:02] :> [15:29:20] aude: did you see my followup for wbsetclaim? :) [15:29:32] addshore: if you want to do me a favour, have another look at https://gerrit.wikimedia.org/r/#/c/84313/25 [15:29:39] that thing is blocking four patches [15:29:50] will do! what changed? :P [15:29:59] just lots of rebases? [15:30:20] addshore: claimsaver? [15:30:39] addshore: yes, and your comments [15:30:44] aude >> https://gerrit.wikimedia.org/r/#/c/88017/ [15:31:01] oh wait... my second patchset never got pushed... [15:31:08] * aude blind [15:31:14] no wonder [15:31:19] (03PS3) 10Daniel Kinzler: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 [15:31:36] mhhm, actually I seem to have globed two changeset together... [15:32:40] addshore: reset HEAD^, stash, make new branch, apply stash, undo what you don't wnat in change A. make another branch and apply stash for change B [15:33:36] ... [15:34:13] (03PS2) 10Addshore: Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 [15:34:37] these are the sotrs of times a gui for git is just sooooooo nice ;p [15:36:29] addshore: how does it help? [15:36:46] (03PS3) 10Addshore: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 [15:36:46] addshore: for accepting/rejecting parts of diffs, I use phpstorm. works nicely [15:37:06] i get to the the massive tree of all of my commits with pretty colors ;p [15:38:31] addshore: i find that tree quite useless. for some reason, it confuses my mental picture. [15:38:38] :> [15:38:44] (03CR) 10Aude: [C: 031] "looks better and seems to work fine with my bot. I am still curious why the tests fail for me, but it is unrelated to this patch apparent" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [15:38:45] i don't really need to know what commit some branch is based on. [15:39:14] (03CR) 10Daniel Kinzler: [C: 032] Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [15:39:21] (03PS2) 10Daniel Kinzler: Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [15:39:27] (03CR) 10Daniel Kinzler: [C: 032] Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [15:45:29] hashar: what are these Job Stats I see? :O [15:46:02] addshore: still around ? [15:46:08] yup [15:46:14] addshore: https://tinyurl.com/pqbmze4 [15:46:26] addshore: that is the time in milliseconds to run the Wikibase gate-and-submit [15:46:41] that is pretty new, the metrics are reported since this morning [15:47:26] looks nice! [15:48:01] I think I had some time for jenkins at some point [15:48:04] but can't find them anymore [15:48:49] (03CR) 10Jeroen De Dauw: [C: 032] "(2 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 (owner: 10Addshore) [15:48:55] (03Merged) 10jenkins-bot: Add logic and tests for getAddIndexSql [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88077 (owner: 10Addshore) [15:48:57] addshore: follow up comment at https://gerrit.wikimedia.org/r/#/c/88077/ [15:49:25] hashar: http://goo.gl/WyX41J :> [15:49:53] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [15:49:56] gate-submit has basically the same trend as the general wikibase tests :P [15:50:17] addshore: you are such a hacker :-] [15:50:26] addshore: so there is a bunch of metrics reported by Zuul now [15:50:32] feel free to build your own dashboard somewhere [15:50:42] I will look at getting some Jenkins metrics as well [15:50:50] is there an easier was to find them rather than poking around the url? ;p [15:50:53] *way [15:51:02] addshore: https://graphite.wikimedia.org/dashboard/ [15:51:08] you need a labs account [15:51:15] maybe be part of a specific group as well [15:51:28] access denied [15:51:32] :-( [15:51:33] indeed :P [15:51:38] * aude not wmf staff [15:51:41] maybe restricted to the 'wmf' LDAP group [15:51:55] i think it is [15:52:00] I have filled a RT a bunch of time ago to get wmde in a specific ldap group [15:52:30] Require ldap-group cn=wmf,ou=groups,dc=wikimedia,dc=org [15:52:31] :( [15:53:12] ah the RT is https://rt.wikimedia.org/Ticket/Display.html?id=5023 [15:53:19] ( Create a LDAP group for WMDE developers ) [15:53:32] cant see that either ;p [15:53:56] (03CR) 10Daniel Kinzler: [C: 032] Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 (owner: 10Addshore) [15:53:59] (03PS2) 10Daniel Kinzler: Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 (owner: 10Addshore) [15:54:07] (03CR) 10Daniel Kinzler: [C: 032] Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 (owner: 10Addshore) [15:54:39] addshore: ah true sorry :/ [15:54:55] addshore: anyway, I did request a LDAP group for wmde folks so we can grant you wmf privileges were relevant [15:55:34] ALL of the priviliges = ALL of the NyanCats appearing everywhere [15:56:51] (03CR) 10Daniel Kinzler: [C: 032] Rename ChangeOp test dir and fix @covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88052 (owner: 10Addshore) [15:57:28] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [15:58:04] (03CR) 10Daniel Kinzler: [C: 032] Remove duplicate method from ItemHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88021 (owner: 10Addshore) [15:58:51] (03PS4) 10Daniel Kinzler: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 (owner: 10Addshore) [15:59:04] (03CR) 10Daniel Kinzler: [C: 032] Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 (owner: 10Addshore) [16:00:26] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [16:01:37] (03PS3) 10Addshore: Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 [16:01:40] DanielK_WMDE: thats should / might solve your concerns ^^ [16:01:50] JeroenDeDauw: you are right of course - but I don't see a good workaround. The job object is *created* on the client and *executed* in the repo. [16:02:10] probably should be split up [16:02:35] JeroenDeDauw: that makes proper injection quite hard, and means that the initialization context is completely different from the execution context [16:02:48] aude: this is how jobs work, I see no way to change that [16:03:05] where is summary formatter used there? [16:03:12] and how? [16:04:02] site link updater? [16:04:06] aude: the job changes a sitelink. it needs all kinds of repo code to do that. creating the summary is the least of that [16:04:10] (03Merged) 10jenkins-bot: Rename ChangeOp test dir and fix @covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88052 (owner: 10Addshore) [16:04:18] sit elink updater stuff could be split [16:05:16] JeroenDeDauw: i see three possibilities: a) we pull all storage loigic into lib b) we change core to be smarted about jobs c) we live with the uglyness of an object that needs repo services being instantiated in the client. [16:05:27] JeroenDeDauw: do you have an alternative ida? [16:06:30] oh, my UpdateRepo mess? :P [16:07:06] (03Merged) 10jenkins-bot: Remove duplicate method from ItemHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88021 (owner: 10Addshore) [16:07:43] (03CR) 10Daniel Kinzler: "@Jeroen: you are right, this sucks. I see no easy solution though." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [16:09:13] have a SiteLinkUpdater class in repo? [16:09:15] aude, JeroenDeDauw: ideally, we wouldn't have jobs, but events and event handlers. that would easily solve the problem. [16:09:19] but we don't, so... [16:09:31] if class does not exist, then job can't run [16:09:38] or does nothing [16:09:50] DanielK_WMDE: would be nice [16:09:54] aude: then we strill have a dependency on repo code in lib [16:10:00] you just shifted it around [16:10:23] we can shift that around all we want - we still need a class that is a) able to chaneg and item (repo) and b) be instantiated on the client [16:10:57] updating site link happens on repo [16:11:02] Unless you do ugly things to core (which you probably shouldn't... that sounds like a bad idea from that POV) [16:11:59] already this particular job depends on central auth :) [16:12:25] Yes it does... I was to lazy to also write an abstract auth backend thing [16:12:36] :) [16:13:51] hoo: actually, it would improve the design in core. but it'll take a while. [16:14:30] so SiteLinkUpdater can have constructor param SummaryFormatter [16:14:31] DanielK_WMDE: Really? Injecting a job by a random string on some other wiki doesn't sound super sane to me [16:14:39] that can be null [16:14:41] it's icky [16:14:52] aude: It will always be null [16:14:54] if it is null, then get it from WikibaseRepo [16:15:03] from the factory thing [16:15:12] unless you get a object on client an serialize it into the DB, ... [16:15:14] e.g. in the constructor [16:15:33] hoo hmmmmm [16:15:51] We already thought that out back then I wrote it [16:16:17] hoo: random string? [16:16:41] anyway [16:16:43] DanielK_WMDE: random class name, core can't know whether that's valid or not at that point [16:17:10] the design of this could use some rethinking - maybe it'S not so hard to add core support for what we need (a "job definition" without the job logic) [16:17:23] hoo: think of it as an event identifier. [16:17:35] would be nice [16:17:38] but i see no reason to block this change on that [16:18:21] DanielK_WMDE: Well, mh... nice would be something like: Client change happens, client "tells" repo that a page has been moved, rest is up to repo. :P [16:18:28] can update site links use change ops? [16:18:34] change ops are repo specific though [16:18:36] nevermind [16:18:47] aude: You can use everything repo specific in there [16:19:01] only some methods are working on the lcient anyway [16:19:29] The job will probably fatal if run on the client (never tried it AFAIR) [16:19:46] hwoa bout something that checks if repo is loaded in run() [16:19:53] if it si not then job does nothing [16:20:04] how about.... [16:20:23] * aude wish this was easier :) [16:20:26] the tests do that [16:20:41] but not the job [16:21:05] it would be crazy for the job to be inserted into a client only wiki [16:21:12] would never happen [16:21:24] but still i think can check [16:21:33] Yes... that's why it's just going to fatal, not "nice" exception needed IMO [16:21:39] * no [16:22:51] hmmm, in the clients, we have the change notification job [16:22:57] it then triggers a refresh links job [16:23:16] maybe there could be a move notification job that triggers site link update job? [16:23:32] maybe not better [16:24:04] That's different, but not really much better [16:24:11] yeah [16:26:07] Regarding that change, I would say go for it... we shouldn't block SummaryFormater because we have general design issues [16:28:45] (03PS1) 10Jeroen De Dauw: Add NoClientOrRepoUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88130 [16:29:08] addshore: ^ [16:30:00] lets see if it passes ;p [16:30:02] JeroenDeDauw: Uhm... did you follow? [16:31:04] Wont that fail just because the test itself contains the strings? :P [16:31:04] hoo|away: what? [16:31:46] addshore: going on the wikitech thread, I guess we can easily create a IndexNameEscaper and FieldNameEscaper in the db component [16:31:59] yup [16:32:00] Or perhaps an IndentifierEscaper, if it is really always the same thing [16:32:25] hoo|away: look at the code ;p [16:32:34] hoo|away: I did the evil string split thing [16:32:50] hoo|away: so yeah, you can get around this by doing the same and then eval'ing the code :D [16:32:54] (03PS1) 10Aude: remove unused WikibaseRepo reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88132 [16:33:00] easy chocolate :) [16:33:07] We really should have PHP CS and whatnot installed with a bunch of rules to avoid such amdness [16:33:37] (03CR) 10Jeroen De Dauw: [C: 032] remove unused WikibaseRepo reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88132 (owner: 10Aude) [16:36:19] JeroenDeDauw: got a suggestion for the issue with UpdateRepoOnMoveJob? It's plocking a crucial patch [16:36:39] DanielK_WMDE: I have not looked at your code in detail, so no [16:37:13] JeroenDeDauw: basically: the job already depends on a lot of repo stuff. my code doesn't change that. [16:37:35] i suggest to not block this change on the general nastiness of the job issue [16:37:36] (03PS1) 10Aude: Cleanup and remove unused use in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88133 [16:37:43] (03PS1) 10Jeroen De Dauw: Remove a pile of unused use statements to things that should not be used in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88134 [16:38:11] (I'm beginning to get an idea of how to solve that, but again, it seems bad to block this change on solving an unrelated issue) [16:38:16] addshore: y u no merge https://gerrit.wikimedia.org/r/#/c/88130/ ? [16:38:57] (03CR) 10Addshore: [C: 032] "!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88130 (owner: 10Jeroen De Dauw) [16:39:08] trooollll [16:39:54] who the fuck ever merged this code anyway? [16:39:57] It is clearly bad [16:40:13] right [16:40:27] JeroenDeDauw: probably me. but as I explained, the dependency issue is a fundamental one. it's not easy to fix. [16:40:32] (03Merged) 10jenkins-bot: remove unused WikibaseRepo reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88132 (owner: 10Aude) [16:40:39] the design of Job/JobQueue is just broken in that regard [16:41:42] DanielK_WMDE: Perhaps. Very perhaps. Lets discuss this tomorrow. If you can convince me this is indeed an inherent issue we cannot get around, then I'll remove my -1 [16:43:15] JeroenDeDauw: ok. i'd be happy if you could show me a nice way to do this :) [16:43:21] when will you be at the office tomorrow? [16:43:23] :) [16:44:33] DanielK_WMDE: Daily, probably [16:46:24] ok, me too. [16:47:45] (03PS1) 10Jeroen De Dauw: Improve doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88137 [16:50:16] (03Merged) 10jenkins-bot: Add NoClientOrRepoUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88130 (owner: 10Jeroen De Dauw) [16:50:59] what, jenkins approves? [16:53:48] addshore: https://gerrit.wikimedia.org/r/#/c/88134/ [16:53:58] When that is in, I'll also restrict usage of namespace refs [16:54:36] aude: isn't it approved by addshore? [16:54:45] aude: https://gerrit.wikimedia.org/r/#/c/88134/ [16:54:55] * aude going home [16:55:14] liangent: jenkins merged it [16:55:29] (03CR) 10Hoo man: [C: 032 V: 032] Remove a pile of unused use statements to things that should not be used in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88134 (owner: 10Jeroen De Dauw) [16:55:44] hoo: \o/ [16:55:57] :) [16:56:06] aude: it's always the expected flow that someone CR+2 it then jenkins merges it [16:56:08] isn't it? [16:56:44] generally [16:56:59] tata until the morning [16:57:42] (03PS1) 10Jeroen De Dauw: Add additional checks to NoClientOrRepoUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88140 [17:17:58] aude: please ping me when you can spare a few minutes [18:07:11] aude: Is there just https://gerrit.wikimedia.org/r/#/c/88114/ then? [18:15:59] General query: I wish to enter cemetery grave marker data and photos. Does it matter if I upload photos to wikimedia first or data to wikidata first and then link them ? [18:27:15] I presume the the occupant of the graves have a wikipedia article or whatever? [19:50:54] Reedy: that's all [19:53:45] Reedy: are you running localisation cache update? [19:54:16] the fix works, except the message is missing [19:54:16] https://www.wikidata.org/w/index.php?title=Q13574423&diff=75381381&oldid=53850396