[00:25:27] Reedy, no they don't. [05:28:11] what is this? [05:28:55] it's Wikidata's IRC channel [05:50:29] General query: I wish to enter cemetery grave marker data and photos. Does it matter if I upload photos to wikimedia first or data to wikidata first and then link them ? [05:55:20] You need to upload those photo's first I think... [05:55:54] you cannot upload to Wikidata anyways [05:56:01] all uploads go to Wikimedia Commons [05:56:16] He says Wikimedia, so I think he means Commons btw. [06:02:38] Good morning [06:13:07] Hello GerardM [06:16:00] hoi Sjoerd .. :) [06:16:11] :) [06:47:06] Oops yeah I meant to say Wikimedia Commons. So what is https://www.wikidata.org/wiki/Special:NewItem then ? [06:48:50] basically you make an item for the image after you upload the image [07:18:57] Does WikiMedia Commons check for duplicates or should I search each graver marker name first ? [07:19:28] that is beyond my knowledge, you'd ask that in #wikimedia-commons [07:20:00] Okay thanks for the help. [08:46:37] (03PS4) 10Henning Snater: Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [08:56:59] (03PS4) 10Addshore: Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 [09:21:16] (03PS5) 10Henning Snater: Implemented claimgroupsview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [09:23:47] (03CR) 10Tobias Gritschacher: [C: 032] (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [09:27:06] (03CR) 10Henning Snater: [C: 032] Moved 'jquery.valueview.MessageProvider' dependency into the right module [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85857 (owner: 10Daniel Werner) [09:27:12] (03Merged) 10jenkins-bot: Remove SimpleQuery::CACHE_TTL_IN_SECONDS [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83098 (owner: 10Daniel Werner) [09:27:13] (03Merged) 10jenkins-bot: (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [09:37:29] (03PS1) 10Addshore: Implement MWTableDefinitionReaderBuilder [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88426 [09:52:47] (03PS1) 10Addshore: Expand MediaWikiEscaper to escape identifiers [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88429 [09:58:41] (03PS18) 10Michał Łazowik: Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [09:59:09] (03CR) 10Michał Łazowik: "Patch Set #18 is a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [10:08:26] (03PS1) 10Addshore: Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 [10:08:45] (03CR) 10jenkins-bot: [V: 04-1] Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 (owner: 10Addshore) [10:11:59] (03CR) 10Daniel Kinzler: [C: 032] Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [10:15:13] (03PS1) 10Addshore: Check for FormatJson returning null in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88435 [10:15:16] DanielK_WMDE: ^^ [10:15:35] (03Merged) 10jenkins-bot: Refactor setclaim to use changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88017 (owner: 10Addshore) [10:19:09] (03PS19) 10Michał Łazowik: Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [10:22:31] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [10:22:34] (03PS3) 10Addshore: Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 [10:22:42] (03PS5) 10Addshore: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 [10:23:47] the above 2 have already had +2s for whoever wants candy :) [10:24:00] No [10:24:04] ;_; [10:24:10] no candy for Reedy [10:36:18] (03PS2) 10Addshore: Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 [10:36:48] (03CR) 10jenkins-bot: [V: 04-1] Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 (owner: 10Addshore) [10:47:34] (03PS3) 10Addshore: Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 [10:47:44] (03CR) 10Addshore: "PS3 is rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [10:49:39] (03PS26) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [10:49:48] (03CR) 10jenkins-bot: [V: 04-1] Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [10:56:40] (03PS27) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [10:57:13] (03PS1) 10Addshore: Surround changeop->apply with try catch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88439 [10:57:26] addshore: can you please have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=44117 and see if this is done with what you worked on? thx! [10:57:36] will have a look in a sec [10:58:36] (03CR) 10Daniel Kinzler: "PS 27 is a rebase and also fixes the dependency issue with UpdateRepoOnMoveJob (sorry for the mess)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [10:59:27] Lydia_WMDE: off the top of ym head I dont know, I am guessing not though [10:59:33] k [11:01:19] (03PS1) 10Daniel Kinzler: Use SummaryFormatter in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 [11:01:40] addshore, Tobi_WMDE: ^--- please? [11:01:55] uh, actually, the one before that. [11:02:07] https://gerrit.wikimedia.org/r/84313 <---- that [11:03:01] (03CR) 10Daniel Kinzler: [C: 04-1] "Pending discussion about how to avoid dependencies of lib to repo in this case." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 (owner: 10Daniel Kinzler) [11:08:44] (03CR) 10Daniel Kinzler: [C: 032] Check for FormatJson returning null in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88435 (owner: 10Addshore) [11:09:40] (03CR) 10Daniel Kinzler: [C: 032] Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 (owner: 10Addshore) [11:09:53] (03CR) 10Daniel Kinzler: [C: 032] Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 (owner: 10Addshore) [11:10:15] (03CR) 10Daniel Kinzler: [C: 032] Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [11:10:26] (03CR) 10Addshore: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:11:53] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 (owner: 10Daniel Kinzler) [11:11:56] (03Merged) 10jenkins-bot: Check for FormatJson returning null in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88435 (owner: 10Addshore) [11:12:15] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [11:12:17] (03CR) 10Daniel Kinzler: [C: 032] Surround changeop->apply with try catch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88439 (owner: 10Addshore) [11:12:42] (03PS10) 10Addshore: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [11:12:57] (03PS4) 10Addshore: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [11:14:54] (03Merged) 10jenkins-bot: Use ApiWikibase::loadEntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88020 (owner: 10Addshore) [11:17:33] (03PS1) 10Tobias Gritschacher: Make sitelink browsertests work on beta labs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88444 [11:18:03] (03Merged) 10jenkins-bot: Remove unused ClaimSaver class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88018 (owner: 10Addshore) [11:18:10] (03PS2) 10Tobias Gritschacher: Make sitelink browsertests work on beta labs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88444 [11:20:58] (03Merged) 10jenkins-bot: Add extra ChangeOpClaim tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88019 (owner: 10Addshore) [11:21:06] (03PS9) 10Daniel Kinzler: Remove formating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 [11:21:13] (03CR) 10jenkins-bot: [V: 04-1] Remove formating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [11:26:49] (03Merged) 10jenkins-bot: Surround changeop->apply with try catch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88439 (owner: 10Addshore) [11:33:53] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/88445/ [11:43:23] (03PS28) 10Daniel Kinzler: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 [11:44:24] (03CR) 10Daniel Kinzler: "PS 28 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:45:07] (03PS11) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 [11:45:13] (03PS10) 10Daniel Kinzler: Remove formating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 [11:45:19] (03PS5) 10Daniel Kinzler: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 [11:45:31] (03PS2) 10Daniel Kinzler: Use SummaryFormatter in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 [11:45:41] (03CR) 10Daniel Kinzler: [C: 04-1] "Pending discussion about how to avoid dependencies of lib to repo in this case." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 (owner: 10Daniel Kinzler) [11:47:50] (03CR) 10Tobias Gritschacher: [C: 032] "per CR by addshore" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [11:48:22] (03PS11) 10Daniel Kinzler: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 [11:51:51] (03PS2) 10Tobias Gritschacher: Cleanup and remove unused use in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88133 (owner: 10Aude) [11:52:04] (03CR) 10Tobias Gritschacher: [C: 032] Cleanup and remove unused use in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88133 (owner: 10Aude) [11:52:38] (03CR) 10Tobias Gritschacher: [C: 032] Improve doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88137 (owner: 10Jeroen De Dauw) [11:54:57] (03CR) 10Tobias Gritschacher: [C: 032] Add additional checks to NoClientOrRepoUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88140 (owner: 10Jeroen De Dauw) [11:57:00] Tobi_WMDE: DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=47068 [11:58:13] Lydia_WMDE: did you discuss SMWCon yet? [11:59:32] JeroenDeDauw: we did. [12:00:47] JeroenDeDauw: jep all solved [12:02:28] (03Merged) 10jenkins-bot: Introducing SummaryFormatter. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84313 (owner: 10Daniel Kinzler) [12:04:50] (03CR) 10Jeroen De Dauw: [C: 032] Implement MWTableDefinitionReaderBuilder [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88426 (owner: 10Addshore) [12:06:57] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88429 (owner: 10Addshore) [12:09:24] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88429 (owner: 10Addshore) [12:11:11] (03Merged) 10jenkins-bot: Cleanup and remove unused use in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88133 (owner: 10Aude) [12:14:03] (03Merged) 10jenkins-bot: Improve doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88137 (owner: 10Jeroen De Dauw) [12:15:08] hashar: how come it is taking Jenkins 20 minutes to merge stuff? [12:16:52] (03Merged) 10jenkins-bot: Add additional checks to NoClientOrRepoUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88140 (owner: 10Jeroen De Dauw) [12:23:18] (03PS1) 10Jeroen De Dauw: Rem dead global [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88450 [12:27:04] DanielK_WMDE: it seems the new summary-formatter leaves a comma too much after the key-value pair in the summary. you might want to check that again.. [12:27:49] hrrmmmm [12:27:54] Tobi_WMDE: example? [12:28:03] * DanielK_WMDE suspects an empty value at the end [12:28:46] DanielK_WMDE: e.g. add a new claim: then the summary will look like e.g. "(Created claim: Property:P1042: hg,)" [12:29:00] meh [12:29:01] DanielK_WMDE: note the comma in the end [12:29:05] yea [12:30:13] (03CR) 10Tobias Gritschacher: [C: 032] Remove formating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [12:33:28] (03Merged) 10jenkins-bot: Remove formating logic from ClaimSummaryBuilder. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84979 (owner: 10Daniel Kinzler) [12:34:30] JeroenDeDauw: multiple changes being send, and all of them using the same job [12:34:44] JeroenDeDauw: the jobs are serialized, I got a patch floating around to let them run in parallel though [12:41:06] sorry Jenkins restarting … killed it by mistake [12:41:42] (03PS1) 10Daniel Kinzler: Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 [12:41:46] Tobi_WMDE: ---^ [12:42:05] Tobi_WMDE: this is a general sanity improvement, i didn't check your exact use case [12:42:20] (i'm abotu to run out for a couple of hours, so I just took a quick shot) [12:42:22] (03CR) 10jenkins-bot: [V: 04-1] Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [12:43:38] DanielK_WMDE: that is jenkins restarting, sorry [12:44:22] (03PS1) 10Daniel Kinzler: Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 [12:46:07] (03CR) 10jenkins-bot: [V: 04-1] Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [12:47:42] (03PS2) 10Tobias Gritschacher: Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [12:48:20] (03CR) 10jenkins-bot: [V: 04-1] Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [12:50:51] addshore: how do you like this? protected $globalVars; [12:53:34] (03Abandoned) 10Jeroen De Dauw: Rem dead global [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88450 (owner: 10Jeroen De Dauw) [13:00:54] make ALL of the setup code non-static! [13:01:09] :O [13:01:11] Lydia_WMDE: https://bugzilla.wikimedia.org/buglist.cgi?columnlist=product%2Ccomponent%2Cassigned_to%2Cpriority%2Cbug_severity%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate%2Ckeywords%2Cvotes&email1=wikidata-bugs%40lists.wikimedia.org&emailassigned_to1=1&emailcc1=1&emailtype1=substring&query_format=advanced&order=votes%20DESC%2C&resolution=--- :> [13:01:34] (03PS1) 10Tobias Gritschacher: Fixed link to Special:SetSiteLink in ItemView - again [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88454 [13:01:39] addshore: \o/ [13:11:55] (03PS1) 10Jeroen De Dauw: Make nearly all setup code non-static and non-global [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88456 [13:14:46] addshore: reviewwwwwwwwwwwwwww https://gerrit.wikimedia.org/r/#/c/88456/ [13:18:15] (03PS1) 10Jeroen De Dauw: Add config for phpunit-testrunner [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88458 [13:32:21] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88456 (owner: 10Jeroen De Dauw) [13:32:53] (03CR) 10Addshore: [C: 032] Add config for phpunit-testrunner [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88458 (owner: 10Jeroen De Dauw) [13:32:59] (03Merged) 10jenkins-bot: Add config for phpunit-testrunner [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88458 (owner: 10Jeroen De Dauw) [13:33:33] (03CR) 10Addshore: [C: 032] Fixed link to Special:SetSiteLink in ItemView - again [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88454 (owner: 10Tobias Gritschacher) [13:39:39] (03PS2) 10Jeroen De Dauw: Make nearly all setup code non-static and non-global [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88456 [13:40:38] (03CR) 10Addshore: [C: 032] Make nearly all setup code non-static and non-global [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88456 (owner: 10Jeroen De Dauw) [13:40:42] hashar: so we should be proud we are successfully DoS'ing Jenkins? ;p [13:40:53] :> [13:43:27] (03PS1) 10Jeroen De Dauw: Add doc and assign var by ref [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88460 [13:44:33] andre__: it'd be awesome to have a "waitingforreply" status or something in bugzilla :) [13:44:46] (03CR) 10Addshore: [C: 032] Add doc and assign var by ref [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88460 (owner: 10Jeroen De Dauw) [13:47:30] (03PS1) 10Jeroen De Dauw: Do not use fully qualified paths for tests [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88461 [13:47:31] (03PS1) 10Jeroen De Dauw: Docs++ [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88462 [13:50:38] (03Merged) 10jenkins-bot: Add doc and assign var by ref [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88460 (owner: 10Jeroen De Dauw) [13:55:50] Lydia_WMDE, if I understood why the damn code does not work we'd already have it :-/ [13:56:02] andre__: :( [13:56:12] andre__: any help if i tell you that kde has it? [13:57:59] JeroenDeDauw: $result['sql'] doesnt work and $result=>sql doesnt work, the first complains about using an object as an array, the latter an array as an object... Using your ResultIterator in a foreachloop.. which should work...? any hints? [14:30:00] Lydia_WMDE, status or flag? I was thinking of a flag that also Mozilla and RedHat use. [14:30:12] status i easy, but you cannot needinfo "against" something which might be nicer :) [14:37:34] (03PS3) 10Addshore: Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 [14:37:35] (03CR) 10jenkins-bot: [V: 04-1] Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 (owner: 10Addshore) [14:38:40] (03PS1) 10Jeroen De Dauw: Update test namespace and testsuite definitions [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88472 [14:38:41] (03PS1) 10Jeroen De Dauw: Add HookSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88473 [14:38:42] (03PS1) 10Jeroen De Dauw: Added foundation for WikibaseQueryBuilderTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88474 [14:38:44] (03PS1) 10Jeroen De Dauw: Add ExtensionSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88475 [14:41:30] (03PS4) 10Addshore: Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 [14:41:38] (03CR) 10jenkins-bot: [V: 04-1] Expand integration test to use DefinitionReader [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88434 (owner: 10Addshore) [15:07:17] (03PS2) 10Addshore: Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [15:07:19] (03PS3) 10Addshore: Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [15:08:56] addshore: review ALL of the changes https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikibaseQuery,n,z [15:09:03] Im going to :P [15:10:17] (03CR) 10Addshore: [C: 032] Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 (owner: 10Daniel Kinzler) [15:10:55] (03CR) 10Addshore: [C: 032] Add ExtensionSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88475 (owner: 10Jeroen De Dauw) [15:11:29] (03CR) 10Addshore: [C: 032] Added foundation for WikibaseQueryBuilderTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88474 (owner: 10Jeroen De Dauw) [15:11:50] (03CR) 10Addshore: [C: 032] Add HookSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88473 (owner: 10Jeroen De Dauw) [15:12:56] (03CR) 10Addshore: [C: 032] "It will be interesting to see how this works out in the medium / long term" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88472 (owner: 10Jeroen De Dauw) [15:13:49] (03CR) 10Addshore: [C: 032] Docs++ [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88462 (owner: 10Jeroen De Dauw) [15:14:11] (03CR) 10Addshore: [C: 032] Do not use fully qualified paths for tests [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88461 (owner: 10Jeroen De Dauw) [15:16:40] (03Merged) 10jenkins-bot: Remove formatting logic from ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84975 (owner: 10Daniel Kinzler) [15:16:51] addshore: this one https://gerrit.wikimedia.org/r/#/c/88434/ ? [15:16:59] heheh https://twitter.com/JeroenDeDauw/status/387550908931776513 [15:17:27] JeroenDeDauw: yus [15:17:41] morning legoktm (even though i dont know what time it is :O) [15:17:46] morning [15:17:57] 8:17am [15:19:17] addshore: I get this when running that commit with MySQL http://pastebin.com/pMXM1dMK [15:19:32] addshore: same error as you get for SQLite [15:20:59] I havnt got around to testing it on mysql yet.. [15:21:28] addshore: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [15:23:24] JeroenDeDauw: Jumbo Pizza Hawaii [15:23:48] :> [15:25:22] (03Merged) 10jenkins-bot: Add ExtensionSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88475 (owner: 10Jeroen De Dauw) [15:25:23] (03Merged) 10jenkins-bot: Added foundation for WikibaseQueryBuilderTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88474 (owner: 10Jeroen De Dauw) [15:25:23] JonMelusky: Hello, is it what you want to do ? https://commons.wikimedia.org/wiki/Category:Grave_of_Stanislas_Dubois [15:25:24] (03Merged) 10jenkins-bot: Add HookSetupTest [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88473 (owner: 10Jeroen De Dauw) [15:25:25] (03Merged) 10jenkins-bot: Update test namespace and testsuite definitions [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88472 (owner: 10Jeroen De Dauw) [15:25:27] (03Merged) 10jenkins-bot: Docs++ [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88462 (owner: 10Jeroen De Dauw) [15:26:38] angrypoulpe: kde uses a status and i like that more because i can't do anything with the bug until they replied [15:27:01] angrypoulpe: sorry this wasn't for you [15:27:04] tab completion fail [15:31:58] (03CR) 10Addshore: [C: 032] Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [15:34:06] (03PS6) 10Tobias Gritschacher: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [15:34:17] (03CR) 10Tobias Gritschacher: [C: 032] Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [15:35:08] (03CR) 10Addshore: [C: 032] Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [15:36:06] (03Merged) 10jenkins-bot: Handle empty summary arguments nicely. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88451 (owner: 10Daniel Kinzler) [15:39:26] http://www.troll.me/meme/clueless-manager [15:39:34] addshore: Abraham_WMDE ^ [15:39:39] Lydia_WMDE: ^ [15:40:32] * Lydia_WMDE pokes JeroenDeDauw [15:42:08] (03Merged) 10jenkins-bot: Use SnakFormatter for HTML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84987 (owner: 10Daniel Kinzler) [15:42:32] Lydia_WMDE: is this what you wanted? http://www.troll.me/2013/10/08/clueless-manager/clueless-manager-says-you-no-can-has/ [15:42:40] Lydia_WMDE: you can recaption it yourself ofc :D [15:48:34] JeroenDeDauw, Lydia_WMDE: http://www.troll.me/2013/10/08/clueless-manager/oh-god-why/ [15:51:40] DanielK_WMDE: yes! [15:51:41] :P [15:55:31] (03PD2) 10Addshore: Split Repo and Repo api tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88486 [16:01:46] addshore: odd sqlite behaviour verified, not an issue with our code [16:01:56] it does not happen with sqlite itself eiether though [16:02:01] so MW is messing something up [16:02:46] indeed [16:06:43] (03PS1) 10Addshore: Add groups to a file missing them [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88493 [16:08:23] addshore: I will investigate this further [16:08:38] addshore: should not change the interface because MW is buggy or whatever [16:09:02] :> [16:19:31] (03CR) 10Jeroen De Dauw: [C: 032] Add groups to a file missing them [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88493 (owner: 10Addshore) [16:36:56] PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf20/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [16:40:11] addshore: meh, its not MWs fault either [16:40:16] looks like this is in PDO [16:40:19] yee [16:40:27] mediawiki passes something like CREATE /* DatabaseBase::query */ TABLE fish1 (foo); CREATE TABLE fish2 (bar); to pdo [16:40:36] and then pdo does sad things [16:43:19] guess we will have to pass the queires around in arrays and execute them one by one then? [16:49:14] addshore: http://stackoverflow.com/questions/19253673/pdosqlite-does-not-run-multiple-statements-in-one-query [16:49:26] addshore: no, the issue resides in executing the SQL [16:49:29] It should be handled there [16:49:35] Not in the code that created the SQL [16:49:37] *creates [16:51:27] addshore: what about specifying that the sql generators return one statement per line, each line ending on ;? [16:51:28] Lydia_WMDE: add https://bugzilla.wikimedia.org/show_bug.cgi?id=43069 to the next sprint, including refactoring wbsearchentities [16:51:39] then MediaWikiTableBuilder can split on that [16:51:39] JeroenDeDauw: that could work! [16:52:25] addshore: got stackoverflow? [16:52:36] somewhere :P [16:53:27] addshore: upvote!! ;p [16:54:44] taxobox, wistfully waiting for tracking: https://test2.wikipedia.org/wiki/Vipera_berus :-) [16:56:46] Lydia_WMDE: :O [16:56:46] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BInfrastructure%5D&filters%5B%5D=%5BIte [16:56:46] ration%5D%5Bis%5D%5B%28Current+iteration%29%5D&group_by%5Blane%5D=status&lanes=In+Analysis%2CReady+for+Estimation%2CReady+for+Development%2CIn+Development%2CAwaiting+Final+Code+Review%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&style=grid&tab=Story+Wall [16:56:49] oh ... [16:57:06] addshore: What the hell with the link? :p [16:57:08] Lydia_WMDE: !! > http://goo.gl/CVeMNo [16:57:14] I want one ;p [17:02:28] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [17:30:18] JeroenDeDauw: is there any good reason to keep SerializerTest? Seems like that functionality is covered by SerializerBaseTest [17:45:14] (03CR) 10Addshore: [C: 032] Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [17:45:21] (03CR) 10jenkins-bot: [V: 04-1] Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [17:48:15] (03PS12) 10Addshore: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [17:48:28] (03CR) 10Addshore: "PS12 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [17:52:55] (03CR) 10Addshore: [C: 032] Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 (owner: 10Daniel Kinzler) [17:54:55] (03PS3) 10Addshore: Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [17:58:32] (03PS1) 10Jeroen De Dauw: Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88524 [17:58:40] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88524 (owner: 10Jeroen De Dauw) [18:01:11] (03CR) 10Addshore: [C: 032] Removed EntityIdSerialize where it wasn't needed. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88452 (owner: 10Daniel Kinzler) [18:01:21] DanielK_WMDE: I rebased and merged those 2 changes for you ;p [18:02:56] addshore: thanks! [18:03:00] want a cookie? [18:03:03] :D [18:35:53] DanielK_WMDE: http://stackoverflow.com/questions/18948462/find-alphabetically-first-value-using-php [18:38:43] (03PS1) 10Jeroen De Dauw: Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88531 [18:41:15] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88531 (owner: 10Jeroen De Dauw) [18:44:41] DanielK_WMDE ping , can you come and let me out? :p [18:45:31] I'm locked in :/ [18:46:43] :S [18:54:58] (03PS1) 10Jeroen De Dauw: Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88535 [18:55:08] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update TravisCI config to run coveralls [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88535 (owner: 10Jeroen De Dauw) [19:01:30] (03PS1) 10Jeroen De Dauw: Add docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88537 [19:01:31] (03PS1) 10Jeroen De Dauw: Add badges to readme [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88538 [19:01:40] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88537 (owner: 10Jeroen De Dauw) [19:01:48] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add badges to readme [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88538 (owner: 10Jeroen De Dauw) [19:10:37] (03PS1) 10Jeroen De Dauw: Doc reorg [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88613 [19:10:49] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Doc reorg [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88613 (owner: 10Jeroen De Dauw) [19:14:03] (03PS1) 10Jeroen De Dauw: Improve docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88614 [19:14:15] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Improve docs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88614 (owner: 10Jeroen De Dauw) [20:06:56] Hello I saw the property IMDb identifier or Commons category are the type string but in the item the value is a link web... How I can change a string value to a link ? thanks [20:13:34] Hello I saw the property IMDb identifier or Commons category have the type string but in the page the value of the properties is a link web... How I can change a string value to a link ? thanks [20:43:30] karima: we have a gadget that does that, I can add a value for you [20:43:38] https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js [20:45:24] legoktm : thanks ;) [20:46:24] legoktm : for the moment I try to understand how it's working. Bye. [20:46:31] ok [21:17:43] welcome back Eloquence [23:16:32] (03PS1) 10Reedy: Add .gitreview and .gitignore [extensions/DataValuesInterfaces] - 10https://gerrit.wikimedia.org/r/88659 [23:16:33] (03PS1) 10Reedy: Add .gitreview and .gitignore [extensions/DataValuesInterfaces] - 10https://gerrit.wikimedia.org/r/88659 [23:16:46] (03PS1) 10Reedy: Add .gitreview and .gitignore [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/88660