[10:55:17] Lydia_WMDE: ping ;) [10:59:40] benestar: hey - sorry - need to head out (traveling atm) - please email [10:59:50] ok [11:52:30] hey, can anyone help me with git? [11:52:44] @aude [11:53:42] benestar: If you want I can try to help you [11:54:13] well, if I try to do git review there come thousands of unrelated commits [11:54:42] and the question "Is this really what you meant to do?" [11:55:27] You want to create a pull request with more than one commit? [11:55:53] sorry, *branch [11:56:04] there appears a list of lots of branches I don't know [11:57:07] So, if I understand well, you want to make git review on one commit but git try to do it one more than one? [11:57:17] I think so... [11:57:27] The solution is to rebase the change. [11:57:38] I think that will work [11:58:37] git rebase gerrit/master if you want to make a pulle request on master [11:58:37] well I tried it but didn't work [11:58:48] however git remote update was the solution :) [11:59:40] Tpt: thanks for you help anyway! [12:00:18] I'm happy to help people contribute with MediaWiki :-) [12:09:34] Good afternoon [12:11:46] goede middag :) [12:12:12] Tpt: do you know how the Gerrit Notification Bot at bugzilla works? [12:13:59] I believe it match commit messages looking for something like bug XXXX and then adds comments to the linked bug when a change is submitted and when a change is merged. [12:32:56] Tpt: however it didn't recognize my change... :( [12:33:38] Have you add something like (bug XXX) at the beginning of your commit message? [13:03:39] Tpt: yes, I did: https://gerrit.wikimedia.org/r/#/c/89513/ [13:06:40] benestar: I have "The page you requested was not found, or you do not have permission to view this page." when I try to see your change [13:06:57] and I don't see it in https://gerrit.wikimedia.org/r/#/q/owner:%22Bene+%253Cbenestar.wikimedia%2540googlemail.com%253E%22,n,z [13:07:04] maybe this one? https://gerrit.wikimedia.org/r/#q,I898e2a8330923f5f32809c9485a83d71546c1c65,n,z [13:09:34] I can't see it. It's strange [13:11:15] Tpt: do you have javascript enabled? It's recommened [13:12:09] of course I have. Everything works fine in gerrit, except your change [13:36:01] benestar: \o/ [13:36:07] Lydia_WMDE: what? [13:36:12] patches :) [13:36:30] yes :) [13:36:32] Tpt: nice! @ commons [13:41:56] Lydia_WMDE: Thanks :-) [13:42:15] :) [13:42:33] alright guys - need to go and check out of this hotel to change to another one [13:42:38] back later [13:44:04] Tpt: do you know if there is any config variable to enable the js in the user preferences for my local mediawiki installation? [13:45:16] Sorry but I don't understand what you mean with "enable the js" [13:45:29] enable User:XX/common.js ? [13:52:47] Tpt: no, it's very strange [13:52:58] if I go to Special:Preferences on my local installation [13:53:14] there is no javascript enabled, so I see no tabs but the whole page at once [13:54:18] Oh. I remind now. user's JS is disable in Special:Preferences in order to allow him to disable broken scripts [13:54:49] But MediaWiki core and extensions Js should be enabled [14:03:37] Tpt: You're into hacking javascript? [14:07:10] multichill: Yes, I create scripts and gadgets sometimes. [14:07:24] And I contribute also to MediaWiki. [14:07:30] Do you already have a script to have one click addition of claims? [14:07:57] I have list of possible claims, would be nice if a user could just click "yes, this is correct" and than the claim gets added [14:08:25] I did this on Commons for several templates, but haven't done anything with Wikidata in this direction [14:10:33] No, I haven't something in this direction. But some of Magnus's gadgets does it. [14:11:15] like https://www.wikidata.org/wiki/User:Magnus_Manske/wikidata_useful.js [14:11:38] One click claim, that's what I need :-) [14:19:30] addshore: u here? [15:07:02] multichill, are you sure there is no Amazon patent on that ? [15:07:59] Hehe, than I violated that one at https://commons.wikimedia.org/wiki/File:Zij-_en_voorgevel_nr._CJ_2_-_Abbekerk_-_20479670_-_RCE.jpg and many more pictures! [15:24:44] Lazowick, appatrrntly I am :-) :-) [15:25:00] My internet just appeared ;p [15:25:37] welcome back addshore it does not show you were gone :) [15:26:11] addshore: REVIEW! [15:26:12] I never leave ;p [15:26:29] Haha, review from my tablet.. Could be fun... :-) [15:26:31] addshore: https://gerrit.wikimedia.org/r/#/c/89476/ [15:26:55] addshore: you just need to click the merge button, works just fine on a tablet [15:27:32] (03CR) 10Addshore: [C: 032] Remove the SetStatementRank API module as we are not going to use it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89476 (owner: 10Jeroen De Dauw) [15:27:37] hehe [15:28:04] I have some things for you yo review but my laptop doesn't have internet :p [15:29:41] Mhhm I wonder :p [15:30:21] addshore: ur tablet does, but ur laptop not? lolwat? [15:30:55] (03Merged) 10jenkins-bot: Remove the SetStatementRank API module as we are not going to use it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89476 (owner: 10Jeroen De Dauw) [15:31:37] Well I have to plug my laptop into my phone :( [15:35:03] addshore: http://bit.ly/1901iPJ [15:49:41] mwhahaha laptop is alivee! [15:50:11] (03PS1) 10Addshore: Use constants in FieldDefinition constructor [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89525 [15:50:46] (03PS1) 10Addshore: Fill gaps in unit tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89526 [15:50:47] (03PS1) 10Addshore: fix SQLiteTableDefinitionReader and Unique indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89527 [15:50:48] (03PS1) 10Addshore: Add MYSQL AutoIncrement support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89528 [15:50:49] (03PS1) 10Addshore: Add AutoIncrement support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 [15:50:50] (03PS1) 10Addshore: Inject Mocks in tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 [15:50:51] (03PS1) 10Addshore: Add tests for Mutating Indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89531 [15:50:58] have fun JeroenDeDauw ;p [15:53:09] (03PS2) 10Addshore: Add AutoIncrement support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 [15:53:23] \o/ [15:53:39] addshore: I'm writings docs, it can't get more exciting then that! [15:54:16] JeroenDeDauw: Im thinking of moving Primarykeys away from IndexDefinitions and into KeyDefinitions [15:54:27] the way mysql and sqlite handle them is so different :/ [15:57:57] addshore: what would KeyDefinition contain (fields) and where would it be used (as field)? [15:59:38] mhhm, either KeyDefinition or PrimarykeyDefinition only [15:59:43] addshore: select( 'ham', array( 'egg' ), array( 'chips' ) ) [15:59:45] and yes it would only really contain fileds.. [15:59:47] you huungry or what? [15:59:49] '[ [15:59:51] ;p [16:00:00] $this->returnValue( 'FOOBAR' ) hehe [16:00:21] {PK doesnt have a name so it doesnt really fit in IndexDefinition [16:01:03] also with sqlite I have to do some ugly stuff for PK as if a field is autoincrement it need to be the PK and you need to create the field and define it as a PK in the field sql [16:01:05] hi [16:01:18] I guess we could not call the PK an index at all and just include it in the fielddefinitions [16:01:26] at the moment there is lag between article creation and availability in wikidata for links [16:01:29] (03CR) 10Jeroen De Dauw: [C: 032] Fill gaps in unit tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89526 (owner: 10Addshore) [16:01:31] each FieldDefinition could have a param called $partOfPk or something? [16:01:48] I added an article about 1 minute ago [16:02:04] and I can't add it to wikidata links [16:02:13] other problem, I choose french as language [16:02:20] (03CR) 10Jeroen De Dauw: [C: 032] fix SQLiteTableDefinitionReader and Unique indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89527 (owner: 10Addshore) [16:02:29] and that's english that is displayed [16:02:38] there is no more the list of choosen languages [16:02:57] that allow to add quickly name and short description in choosen languages [16:03:42] ok [16:03:49] after a reload, works now ??? [16:10:08] how I still fail at putting colspan in the correct tag... >_> [16:11:31] ... there are not unit tests for SearchEntities.... [16:12:04] that just seems silly... [16:18:11] JeroenDeDauw: Hi! I'm working on a new version of wikibase-api-php based on the WikibaseDataModel component (the idea is to let the bots based on wikibase-api-php edit the Entity object and, when it's done, push back the changes to wikidata with the wbeditentity api). But, in order to make the conversion between Entity object and API representation (in the two directions) I need the code that is in the \Wikibase\lib\Serializer namespace of the Wikibase [16:18:11] extension. Do you think it's possible to move these classes into a stand alone component? They doesn't looks to have strong dependancies on the other parts of the Wikibase extension. [16:46:14] popolon: donc tout est réglé ? [16:46:20] (03PS1) 10Addshore: Add basic tests for SearchEntities... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 [16:47:44] Pyb, ouaipe, merci, enfin, pour cette édition, mais ça fait au moins la 2e fois que je constate ce problème en 2 jours [16:48:22] un article récemment renommé ou crée, qui est inaccessible dans les liens wikipedia de wikidata dans la minute qui suit ? [16:49:51] popolon: personne n'a signalé ce problème jusqu'à présent, c'est peut être temporaire (quelques jours) [16:50:24] aucune idée [16:57:24] (03PS2) 10Addshore: Add basic tests for SearchEntities... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 [17:19:54] Tpt: replied on wikidata-tech [17:20:07] Figured it was time to start a discussion about it there now [17:20:19] I've been occasionaly raging about this for the last few months ;p [17:21:06] JeroenDeDauw: Thanks a lot! I think it would be a huge step forward Wikibase code reusability [17:21:40] :> [17:21:59] Once we start deploying using a build it shoudl be much easier to split everything :D [17:23:29] Tpt: it would be. This is code one needs when interacting with the API, if duplication is to be avoided [17:23:46] addshore: yeah... [17:23:56] This new Component would depend on Serialization [17:24:03] So even if we keep it in Wikibase.git for now... [17:24:08] We'd still need a new thinf [17:24:11] thing [17:27:13] A fist step is maybe to get out the MWException dependance. With this dependance removed, I believe that the serializer folder will only depend on WikibaseDataModel, and so, will be usable in bots. [17:30:47] Tpt: sounds like a plan.. [17:45:07] Tpt: there are more bad dependencies, some of which are in datamodel itself [17:45:29] Tpt: you can already start by fixing the MWException usage stuff however [17:45:57] Ok. I'll try to do it this week. [17:50:55] JeroenDeDauw: In order to replace MWException, what do you think about create \Wikibase\lib\SerializationException and\Wikibase\lib\DeserializationException that would be after replaced by the correspondent exceptions of the Serialization extension? [17:57:37] aaargh, Polish idiots!!! They mixed namespaces a created a complete mess :@ [18:03:11] :O [18:24:30] addshore: Ah, this is bad, it's much bigger than that. I found a lot of cross namespace links :-( [18:24:37] :/ [18:24:44] such as? linky? :O [18:25:15] https://www.wikidata.org/wiki/Special:Contributions/Multichill <- see some of my recent edits [18:26:05] :< [18:26:35] Do we have any policy pages about this? Couldn't find any [18:30:08] I think the currentl policy is simply not to link across namespaces [18:30:35] That's what I know from running interwiki bots for years, but did we write this down somewhere? [18:32:33] not entirly sure, cant really check from here, maybe post on the project chat? [18:35:18] first food :-) [19:13:56] addshore: hey, looks like I need to set an alias [19:14:00] (lazowick) [19:14:17] :P [19:14:47] addshore: soo, I made link title optional [19:15:28] now sitelink get's deleted when both link title and badges are not present or the link title is "" [19:15:46] (now doesn't mean that it's merged) [19:16:09] and looks like summaries are working [19:17:26] sounds good :) [19:17:38] if its ready take the DNM out of the commit message ;p [19:21:03] addshore: sorry, OS halted [19:21:10] (chcked logs) [19:21:10] hah! [19:21:13] sounds good :) [19:21:16] if its ready take the DNM out of the commit message ;p [19:21:47] addshore: I'll add tests for the new behaviour of link title [19:21:53] and then it should be ready [19:22:35] but you can check manually if everything works as advertised already [19:23:26] bah, * can already check [19:32:04] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89597 (owner: 10L10n-bot) [19:32:19] WUT? [19:32:37] lol [19:37:22] hah! [19:40:02] (03CR) 10Jeroen De Dauw: [C: 04-1] "(2 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 (owner: 10Addshore) [19:41:30] cannot be merged? i18n bot will not be stopped and merges anyways [19:41:57] indeed [19:42:11] think jenkins was just having an issue :P [19:43:53] (03CR) 10Addshore: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 (owner: 10Addshore) [19:50:52] addshore: you want to try out my new awesome SubPageList 1.0 extension ;p [19:50:58] https://github.com/wikimedia/mediawiki-extensions-SubPageList/blob/master/doc/INSTALL.md [20:04:41] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 (owner: 10Addshore) [20:04:51] addshore: that comment is still wrong tho [20:05:02] yup, will fix the comment in the morning [20:05:17] y does the cleaning personel turn off half of the lights when they come in? [20:05:28] :> [20:05:42] * JeroenDeDauw puts a white thing on one monitor for light replacement [20:05:47] (03PS2) 10Jeroen De Dauw: Inject Mocks in tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 (owner: 10Addshore) [20:08:19] (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 (owner: 10Addshore) [20:08:52] (03CR) 10Jeroen De Dauw: [C: 032] Add tests for Mutating Indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89531 (owner: 10Addshore) [20:23:14] (03CR) 10Jeroen De Dauw: [C: 032] Add MYSQL AutoIncrement support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89528 (owner: 10Addshore) [20:23:15] (03Merged) 10jenkins-bot: Add SQLite AutoIncrement support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89529 (owner: 10Addshore) [20:31:09] addshore: 69730 cross namespace items on first query [20:39:08] multichill: and why Poles? [20:39:33] Most mistakes I found related to the plwp [20:40:00] I don't know why [20:40:26] multichill: hmm, actually yesterday Marek_M asked on #wikimedia-pl about something related [20:41:09] Ok. Filtered out Commons. Leaves about 41K items, including false positives [20:42:21] * multichill removes wikivoyage too [20:42:46] multichill: [[Q859417]] and [[Q10876391]] is then some sort of horror ;) [20:42:49] 10[3] 10https://www.wikidata.org/wiki/Q85941713 => [20:42:51] 10[4] 10https://www.wikidata.org/wiki/Q10876391 [20:43:08] WTF! [20:43:55] (03Draft1) 10Bene: (bug 54103) allow ftp links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89513 [20:43:59] that's what Marek_M pointed out [20:44:25] At least that's in Wikipedia namespace and not category as far as I can see [20:44:28] (03Draft1) 10Bene: Bug 55466 - Better "start page" for ItemDisambiguation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89510 [20:44:47] multichill: not all of them [20:47:07] * Jasper_Deng pokes putnik [20:47:44] zh_yuewiki, urwiki, ttwiki, simplewiki, plwiki (hehe), nowiki, idwiki, hakwiki, fawiki, enwiki, arzwiki are not [20:52:39] (03CR) 10Michał Łazowik: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89513 (owner: 10Bene) [20:58:46] (03PS2) 10Bene: (bug 54103) allow ftp links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89513 [20:59:12] addshore / lazowik_ : Dumped some data on https://tools.wmflabs.org/heritage/cross_namespace.txt [20:59:21] (03Draft2) 10Bene: (bug 54103) allow ftp links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89513 [20:59:33] Loads of false positives :-) [21:02:55] JeroenDeDauw: yep, it can be clearly seen from your g+ that you _should_ be writing docs [21:03:40] lazowik_: ?? [21:03:56] JeroenDeDauw: you said that you're writing docs [21:04:17] and suddenly there are a lot more cats in the interntetz [21:04:59] lazowik_: cats are self documenting, so if you add cats, the percentage of documented stuff goes up [21:05:07] ah, ok [21:05:10] will note that [21:05:18] * JeroenDeDauw is off to the land of faildows to play some starcraft [21:05:26] and show that to my future boss if I need to [21:07:10] 'night [21:54:31] (03Draft1) 10Bene: (bug 47496) Use (hidden) preference for copyright acknowledgment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 [22:02:32] Jasper_Deng? [22:02:46] nvmd [22:02:49] =) [22:07:37] hey guys [22:07:49] how to add a new shortcut properly at mediawiki? [22:08:02] --> https://bugzilla.wikimedia.org/show_bug.cgi?id=46538 [22:08:54] benestar: as in? [22:09:26] I want a short cut for the edit links button [22:09:38] something like alt - enter - d [22:09:52] (it is already used) [22:09:55] *d [22:10:11] enter -> shift [22:10:19] like eg for the random page link [22:11:51] that has to be on the technical side [22:17:58] 10 Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf20/extensions/WikibaseDataMode [22:17:58] l/DataModel/Claim/Claims.php on line 276 [23:08:35] is now back up [23:25:02] Reedy: that one again.... ? hehe, its been there occasional for almost a yearm and still no one knows how it is happening [23:29:52] (03CR) 10Jeroen De Dauw: [C: 032] Use constants in FieldDefinition constructor [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89525 (owner: 10Addshore) [23:30:39] (03CR) 10Jeroen De Dauw: [C: 032] "Please still mind the first comment" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88429 (owner: 10Addshore) [23:30:57] (03PS2) 10Jeroen De Dauw: Add documentation on SQL format to interfaces [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88715 [23:32:44] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 (owner: 10Bene) [23:34:16] (03CR) 10Jeroen De Dauw: [C: 032] (bug 54103) allow ftp links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89513 (owner: 10Bene) [23:36:25] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 (owner: 10Addshore) [23:39:02] (03Abandoned) 10Jeroen De Dauw: Fix API rights, that is permissions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/47033 (owner: 10John Erling Blad) [23:39:46] (03Abandoned) 10Jeroen De Dauw: (Bug 44876) Add toc to EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/52796 (owner: 10John Erling Blad) [23:44:33] (03PS3) 10Jeroen De Dauw: Add documentation on SQL format to interfaces [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88715 [23:45:28] (03CR) 10Jeroen De Dauw: "abandon?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/55109 (owner: 10Daniel Kinzler) [23:46:33] (03CR) 10Jeroen De Dauw: "Is this linked to some bug? If no one will work on this soonish< I rather see this abandoned, and referenced from that bug." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/64081 (owner: 10Denny Vrandecic) [23:47:15] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/67243 (owner: 10Aude) [23:47:33] (03CR) 10Jeroen De Dauw: "Abandon?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71280 (owner: 10Liangent) [23:48:01] (03CR) 10Jeroen De Dauw: "Rebase required" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72939 (owner: 10Daniel Kinzler) [23:48:29] (03CR) 10Jeroen De Dauw: "Rebase required" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72909 (owner: 10Pragunbhutani) [23:48:55] (03CR) 10Jeroen De Dauw: "This generally looks good though, thanks for the patch!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72909 (owner: 10Pragunbhutani) [23:50:05] (03CR) 10Jeroen De Dauw: "Either rebase or abandon" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [23:50:22] (03Abandoned) 10Jeroen De Dauw: Add validator for the precision field of GlobeCoordinate [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81493 (owner: 10Jeroen De Dauw) [23:50:56] (03PS2) 10Jeroen De Dauw: Add overview of dispatch states to DispatchStats. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71811 (owner: 10Daniel Kinzler) [23:51:17] (03CR) 10Jeroen De Dauw: [C: 04-1] "Comments still need addressing and still needs tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71811 (owner: 10Daniel Kinzler) [23:51:34] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/76080 (owner: 10Daniel Werner) [23:52:43] (03CR) 10Jeroen De Dauw: [C: 032] load ValueView when Wikibase is installed via composer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88746 (owner: 10Aude) [23:55:55] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89208 (owner: 10Henning Snater) [23:57:49] (03CR) 10Jeroen De Dauw: "As I asked before, what is the goal of this change?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater)