[04:07:16] is there any standard way to notify editors/queue up tasks if we detect that something's changed? just have a bot edit in a template that adds a cat? (a la {{fact}}) [04:07:17] 10[1] 04https://www.wikidata.org/wiki/Template:fact [04:07:36] uh [04:07:39] what do you mean? [04:08:02] jeremyb: please elaborate [04:08:11] give me a min, i'm typing! [04:08:22] (and legoktm already asked!) [04:08:26] :) [04:09:19] i'm thinking e.g. for articles about software in debian we could use debian's watch files to detect when software has a new release. so then we can notify editors that the subject should be reviewed to update the infobox and give a quick check of release notes, etc. to see if there's a notable difference in the new version [04:09:42] https://wiki.debian.org/debian/watch/ [04:10:31] Jasper_Deng: legoktm [04:10:46] interesting idea [04:10:50] ^ [04:11:00] anyway, that's just a use case [04:11:11] well to answer your question, no there isn't any way to do that :P [04:11:25] my question was about whether we had a way to notify people besides just edit in a template or have a bot leave a talk page msg [04:11:32] riiiight [04:11:46] so, are there any similar use cases with wikidata yet? [04:12:03] and any ideas how this might be done [04:12:21] the main way wikidata fits in is that the mapping of article <-> debian package would be done in wikidata [04:12:24] i think [04:12:53] and then the tool (@ labs i guess) would use that data from wikidata and query debian directly [04:13:29] we could even give louder warnings for major version changes vs. minor (if people are doing semantic versioning) [04:13:38] http://semver.org/ [04:13:49] anyway, food for thought [04:14:09] how meta, semver uses semver for versioning [04:14:22] semver doesn't have a change log >.> [04:14:25] But yeah [04:14:28] sounds like a good idea [04:14:33] just need someone to do the work xD [04:14:52] you mean like https://github.com/mojombo/semver/commits/master ? [04:15:28] a human readable summary [04:15:48] hah [04:15:56] looks human readable to me [04:16:47] legoktm: i don't know wikidata so well. could ya'll think about how this mapping should be done in wikidata. the entity <-> debian package [04:17:06] note not all would be a 1:1 mapping [04:17:18] right [04:17:23] https://www.wikidata.org/wiki/Q698 [04:17:38] so you would have a property like 'debian package name' => 'firefox' [04:17:57] that property would have a qualifier like 'version' => '24.0' [04:17:58] https://en.wikipedia.org/wiki/Coreutils#Programs_included_in_coreutils [04:18:02] a lot of those are not redlinks [04:18:27] and those relationships are not in wikidata [04:18:42] that e.g. mkdir is part of coreutils [04:18:59] i think there is a member of property [04:19:18] sure, i guess someone just has to do the work [04:19:34] but if the list is not generated automatically from wikidata then it will get out of date [04:20:34] also, debian has both source and binary packages. and multiple binary packages can come from a single source package. every binary package is from only one source though [04:21:08] I uh. [04:21:47] okay....... [04:21:52] I think, [04:21:55] you should do the work ;) [04:22:40] ("binary" doesn't mean architecture dependant. e.g. http://packages.debian.org/python-beautifulsoup is one pkg for all architectures) [04:23:27] one common reason to have a source split into multiple binaries is so that arch independant stuff can go in a separate package from stuff compiled per arch [04:23:49] ok [04:23:50] legoktm: maybe... i'll come back and discuss in a day or 3 maybe [04:23:56] aude: look up :) [04:23:57] sounds good :) [06:24:41] hey! [06:25:37] addshore: my client doesn't support aliases :( no lazowicks :( [07:05:18] (03PS23) 10Michał Łazowik: Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [07:05:52] (03CR) 10Michał Łazowik: "Patch Set #23 is a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [07:08:04] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [07:25:56] (03Abandoned) 10Liangent: Special case for English in Utils::getLanguageFallbackChainFromContext() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71280 (owner: 10Liangent) [08:05:48] (03PS5) 10Henning Snater: Allow passing index when adding a Reference to a ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/88969 [08:06:12] (03PS3) 10Henning Snater: Implemented indexOf method in ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89010 [08:16:58] (03PS1) 10Addshore: Use FieldValueEscaping DNM [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89631 [08:17:04] (03CR) 10jenkins-bot: [V: 04-1] Use FieldValueEscaping DNM [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89631 (owner: 10Addshore) [08:23:37] (03CR) 10Henning Snater: [V: 04-1] "Snaklistview QUnit tests are failing. Might be a missing dependency for the 'snakview.variations' module (see snakview.variations.Value.js" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89109 (owner: 10Daniel Werner) [08:24:59] (03PS3) 10Addshore: Inject Mocks in tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 [08:25:00] (03PS2) 10Addshore: Add tests for Mutating Indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89531 [08:27:05] DanielK_WMDE: poke [08:36:09] (03CR) 10Henning Snater: [C: 032] Implements option for locking snaktype in snakview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89111 (owner: 10Daniel Werner) [08:42:07] (03CR) 10Tobias Gritschacher: [C: 032] Allow passing index when adding a Reference to a ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/88969 (owner: 10Henning Snater) [08:42:17] (03Merged) 10jenkins-bot: Allow passing index when adding a Reference to a ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/88969 (owner: 10Henning Snater) [08:47:19] (03CR) 10Tobias Gritschacher: [C: 032] Implemented indexOf method in ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89010 (owner: 10Henning Snater) [08:47:44] (03Merged) 10jenkins-bot: Implemented indexOf method in ReferenceList [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89010 (owner: 10Henning Snater) [08:54:53] (03CR) 10Addshore: [C: 032] Add documentation on SQL format to interfaces [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88715 (owner: 10Jeroen De Dauw) [08:54:58] (03Merged) 10jenkins-bot: Add documentation on SQL format to interfaces [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/88715 (owner: 10Jeroen De Dauw) [08:55:51] (03CR) 10Addshore: [C: 032] Rename method to match interface name [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88975 (owner: 10Jeroen De Dauw) [08:56:07] (03CR) 10jenkins-bot: [V: 04-1] Rename method to match interface name [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88975 (owner: 10Jeroen De Dauw) [08:56:09] (03PS5) 10Addshore: Update docs and @since tags. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88739 (owner: 10Jeroen De Dauw) [08:59:11] (03CR) 10jenkins-bot: [V: 04-1] Update docs and @since tags. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88739 (owner: 10Jeroen De Dauw) [09:12:52] (03PS2) 10Addshore: Add escaping of identifiers in MYSQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89631 [09:12:59] addshore: compare no-such-site and not-recognized-siteid [09:13:06] aren't they the same thing? [09:13:17] probably :> [09:13:23] api errors in general look a bit messy [09:13:41] yep [09:13:46] they were far far far worse :P [09:19:06] addshore: if I make linktitle optional in setsitelink should I also make title optional in edientity? [09:19:30] the title param in edit entity is not used to actually edit things [09:19:33] just to identifiy the entity [09:19:36] so no :) [09:19:58] addshore: noo, title inside sitelink ;) [09:20:07] not param of api call, in json [09:21:02] addshore: to make calls like {"sitelinks":{"svwiki":{"site":"svwiki","badges":["Q149","Q42"]}}} possible [09:21:41] or is editentity assumed to work based on full serialization? [09:22:31] (03CR) 10Tobias Gritschacher: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89208 (owner: 10Henning Snater) [09:24:36] editentity should probably be full serialization :) [09:25:28] addshore: but I can't request badges [09:25:37] that'll break the api [09:25:42] ?? [09:25:48] (03Merged) 10jenkins-bot: claimgrouplabelscroll: Prevent running in error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89208 (owner: 10Henning Snater) [09:26:27] addshore: if I require badges to be present in data provided to editentity [09:26:45] then all current calls to sitelinks will fail [09:27:36] also it looks like checkSiteLinks() only checks if values are of proper type and not if they are there [09:27:54] so when you don't provide sth it will fail with internal [09:31:47] addshore: so for editentity I'd go with require title, not require badges [09:32:07] sounds like a plan :) [09:32:54] addshore: no problem with that not being consistent with wbsetsitelink? [09:33:22] (setsitelink will allow to change only badges without providing linktitle) [09:33:29] well it sort of is consistent with setsitelink, if you dont pass setsitelink badges it does nothing to them [09:33:40] lazowik: oh reallly..?? [09:33:50] I would have thought you could change them both at the same time :O [09:33:57] addshore: you can [09:34:12] but you can also change only badges, not even knowing what title is [09:34:30] basicly you have linktitle OR badges [09:34:30] (03CR) 10Tobias Gritschacher: [C: 032] "This is a simple refactoring as the commit message tells us. Looking at the code it is removing some lines of code, joining the handling o" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater) [09:34:38] or both :P [09:34:45] yep, logical OR [09:35:08] mhhhm, you could go for the same in edit entity I guess [09:35:22] addshore: and that's what I'm asking about from the begining ;) [09:35:22] go for whatever you think makes the most sense to you :) and let the reviewer review it ;p [09:35:30] ok [09:39:42] JeroenDeDauw: awake? [09:42:33] (03CR) 10Tobias Gritschacher: Claimview "movetoolbar" definition refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater) [09:53:51] (03CR) 10Tobias Gritschacher: [C: 032] Claimview "movetoolbar" definition refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater) [09:57:08] (03Merged) 10jenkins-bot: Claimview "movetoolbar" definition refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 (owner: 10Henning Snater) [10:00:56] (03CR) 10Tobias Gritschacher: [C: 032] Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 (owner: 10Henning Snater) [10:03:38] (03Abandoned) 10Daniel Kinzler: Add overview of dispatch states to DispatchStats. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71811 (owner: 10Daniel Kinzler) [10:04:24] (03Merged) 10jenkins-bot: Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 (owner: 10Henning Snater) [10:05:30] (03Abandoned) 10Daniel Kinzler: Create Stores from settings via builder function. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72939 (owner: 10Daniel Kinzler) [10:05:44] (03CR) 10Tobias Gritschacher: [C: 032] Improved snaklistview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85676 (owner: 10Henning Snater) [10:07:21] (03PS2) 10Daniel Kinzler: (bug 49242) clear cached sites data when running populateSitesTable script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/67243 (owner: 10Aude) [10:07:51] (03CR) 10Daniel Kinzler: "PS2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/67243 (owner: 10Aude) [10:08:58] (03Abandoned) 10Aude: (bug 49242) clear cached sites data when running populateSitesTable script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/67243 (owner: 10Aude) [10:09:20] (03PS4) 10Daniel Kinzler: RDF dump creating script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/64081 (owner: 10Denny Vrandecic) [10:09:31] (03CR) 10jenkins-bot: [V: 04-1] (bug 44580) RDF dump creating script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/64081 (owner: 10Denny Vrandecic) [10:09:41] (03Merged) 10jenkins-bot: Improved snaklistview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85676 (owner: 10Henning Snater) [10:12:48] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Moving shared code to mediawiki-selenium Ruby gem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88010 (owner: 10Zfilipin) [10:14:47] (03PS1) 10Tobias Gritschacher: (hotfix) SiteLinksEditTool: Address correct scope [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/89688 [10:15:13] (03CR) 10Tobias Gritschacher: [C: 032] (hotfix) SiteLinksEditTool: Address correct scope [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/89688 (owner: 10Tobias Gritschacher) [10:15:14] (03Abandoned) 10Daniel Kinzler: Support redirects (INCOMPLETE, DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/55109 (owner: 10Daniel Kinzler) [10:19:36] (03CR) 10jenkins-bot: [V: 04-1] (hotfix) SiteLinksEditTool: Address correct scope [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/89688 (owner: 10Tobias Gritschacher) [10:27:12] addshore: what exception (php, not api error) I need to use when user tries to set badges for non-existent sitelink? [10:27:15] outofbounds? [10:30:02] (03PS3) 10Daniel Kinzler: (bug #55511) Introducing DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 [10:30:50] or maybe UnexpectedValueException ? [10:31:42] lazowik: InvalidArgumentException, or some subclass of that. [10:32:16] i don't like OutOfBounds for this though - that should only be used for array-like things [10:34:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1026 (master - b34a78c : jenkins-bot): The build has errored. [10:34:02] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/536fdfcba305...b34a78c578d9 [10:34:02] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12512956 [10:35:27] DanielK_WMDE: mhm, thanks [10:42:36] (03PS1) 10Addshore: Add escaping of identifiers in SQLite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89691 [11:00:43] (03PS4) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [11:00:48] (03PS2) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [11:00:52] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 (owner: 10Henning Snater) [11:00:53] (03PS2) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [11:01:01] (03CR) 10jenkins-bot: [V: 04-1] Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 (owner: 10Henning Snater) [11:01:14] (03CR) 10jenkins-bot: [V: 04-1] Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 (owner: 10Henning Snater) [11:02:10] (03CR) 10Tobias Gritschacher: [V: 032] (hotfix) SiteLinksEditTool: Address correct scope [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/89688 (owner: 10Tobias Gritschacher) [11:05:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1029 (mw1.22-wmf21 - 942d887 : Henning Snater): The build has errored. [11:05:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/fe2e8c106c22...942d8877c4e4 [11:05:36] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12514320 [11:08:23] (03PS7) 10Henning Snater: Implemented claimgrouplistview widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88048 [11:08:24] (03PS3) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [11:08:25] (03PS3) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [11:08:26] (03PS2) 10Henning Snater: Removed movetoolbar widget's listView option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88979 [11:08:27] (03PS2) 10Henning Snater: Improved toolbarcontroller's event namespace assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88994 [11:08:28] (03PS5) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [11:08:29] (03PS5) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [11:11:48] (03CR) 10jenkins-bot: [V: 04-1] Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 (owner: 10Henning Snater) [11:12:08] (03CR) 10jenkins-bot: [V: 04-1] Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 (owner: 10Henning Snater) [11:16:54] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [11:17:10] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 (owner: 10Henning Snater) [11:19:22] (03PS6) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [11:19:23] (03PS6) 10Daniel Kinzler: (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 [11:20:12] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [11:31:03] (03PS2) 10Daniel Kinzler: Removes references to QuantityValue from SnakTest. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89399 [11:34:07] Lydia_WMDE: --> https://bugzilla.wikimedia.org/show_bug.cgi?id=46538 [11:34:18] which shortcut is recommened? [11:34:49] benestar: ufff all 3 suck :( [11:35:07] yes, I know [11:35:15] it's not that easy... [11:35:26] benestar: j and k are usually used for next and previous [11:35:32] we shouldn't use those [11:35:38] ok, so g? [11:35:40] i am unhappy with g but it seems to be the least bad [11:35:49] ok, thanks [11:36:09] np [11:38:47] (03PS1) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [11:41:23] (03CR) 10jenkins-bot: [V: 04-1] (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [11:47:29] (03PS7) 10Daniel Kinzler: (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 [11:48:07] (03CR) 10jenkins-bot: [V: 04-1] (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [12:11:17] For p131, how would I know when to use city vs. town? [12:11:34] Is there some definition based on population or something? [12:12:02] (03PS7) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [12:13:52] *p31 [12:14:40] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [12:16:34] (03PS8) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [12:16:36] (03PS2) 10Addshore: Add escaping of identifiers in SQLite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89691 [12:16:37] (03PS3) 10Addshore: Add escaping of identifiers in MYSQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89631 [12:16:37] JeroenDeDauw: revieewww [12:16:38] (03PS4) 10Addshore: Inject some Mocks in tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 [12:16:39] (03PS3) 10Addshore: Add tests for Mutating Indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89531 [12:16:40] (03PS1) 10Addshore: Fix and add group and covers tags [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89700 [12:16:41] (03PS1) 10Addshore: Add IntegrationTest for PrimaryKeys & UniqueIndexs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89701 [12:16:42] (03PS1) 10Addshore: Add tests for mysql PRIMARY and UNIQUE indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89702 [12:16:43] (03PS1) 10Addshore: Add integration test for SchemaModification [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89703 [12:19:17] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [12:21:31] (03PS9) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [12:24:12] (03CR) 10jenkins-bot: [V: 04-1] Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [12:26:25] (03PS1) 10Addshore: Add unit test for MediaWikiSchemaModifierBuilder [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89704 [12:30:06] (03PS10) 10Henning Snater: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 [12:32:29] aude: when will the foundation switch to mw1.23? any idea? was that answered in the call last week? [12:33:42] soon :) [12:33:50] probably end of october [12:35:19] aude: so, we don't know yet if we're branching 22 or 23 next week, right? [12:35:52] i assume mw1.23-wmf1 [12:36:10] https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap [12:36:23] there is no 1.22wmf23 there [12:38:32] (03PS6) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [12:38:56] (03PS1) 10Addshore: Expand builder unit test for both db types [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89705 [12:39:41] (03CR) 10Jeroen De Dauw: [C: 032] Add escaping of identifiers in SQLite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89691 (owner: 10Addshore) [12:39:44] hashar: around? :) [12:40:01] (03PS7) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [12:40:06] addshore: yes [12:40:14] (03CR) 10Jeroen De Dauw: [C: 032] Add tests for Mutating Indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89531 (owner: 10Addshore) [12:40:18] can jenkins run our qunit tests? :O [12:40:53] (03CR) 10Jeroen De Dauw: [C: 032] Fix and add group and covers tags [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89700 (owner: 10Addshore) [12:41:30] addshore: yeah it should be possible [12:41:49] (03CR) 10Jeroen De Dauw: [C: 032] Add escaping of identifiers in MYSQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89631 (owner: 10Addshore) [12:41:50] (03Merged) 10jenkins-bot: Add escaping of identifiers in SQLite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89691 (owner: 10Addshore) [12:41:54] that would be great :P [12:43:16] (03PS4) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [12:43:21] (03PS4) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [12:44:00] (03CR) 10Jeroen De Dauw: [C: 032] Inject some Mocks in tests [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89530 (owner: 10Addshore) [12:45:02] addshore: one potential problem is: which combinaison of repo/client should be tested ? :-D [12:45:13] heh [12:45:43] just repo? :) [12:46:03] apparently there are currently only qunit tests for the repo :) [12:47:03] (03CR) 10Jeroen De Dauw: [C: 032] Add IntegrationTest for PrimaryKeys & UniqueIndexs [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89701 (owner: 10Addshore) [12:47:42] (03CR) 10Jeroen De Dauw: [C: 032] Add tests for mysql PRIMARY and UNIQUE indexes [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89702 (owner: 10Addshore) [12:48:12] addshore: generating the job [12:48:19] :) [12:48:30] !jenkins mwext-Wikibase-qunit [12:48:34] .. [12:48:42] :O [12:49:25] (03CR) 10Jeroen De Dauw: [C: 032] Add integration test for SchemaModification [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89703 (owner: 10Addshore) [12:51:51] (03CR) 10Jeroen De Dauw: [C: 032] Add unit test for MediaWikiSchemaModifierBuilder [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89704 (owner: 10Addshore) [12:52:29] ahh [12:52:38] :O [12:53:24] one day we will have to talk about all the extensions under wikidata umbrella [12:53:39] there are too many of them :-] [12:53:56] how do you mean? =] [12:55:11] just mixed up Wikibase and WikbiaseDatabase [12:55:25] haha :P [12:56:29] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89705 (owner: 10Addshore) [12:57:06] addshore: https://gerrit.wikimedia.org/r/#/c/89705/ [12:57:15] will take a look in a sec [12:57:17] Wikibase Database is a simple database abstraction layer. It is inspired by the MediaWiki database abstraction layer and both improves and extends on it. [12:57:18] :-(((((( [12:57:27] trying to deb ug some STUPID sqlite stuff [12:57:47] hashar: ?? [12:58:23] JeroenDeDauw: what about updating/fixing the mediawiki/core db layer instead of adding another extension? [12:58:42] JeroenDeDauw: seems WikibaseDatabase would be a good RFC candidate and might probably land in core :-] [12:59:02] hashar: sure, someone can make it into an RFC and bundle it with core if they want [12:59:10] hashar: we need this stuff now though, not in a year [12:59:14] :P [12:59:17] indeed [12:59:19] and we also do not want to maste man-weeks on discussing this [12:59:35] For instance, this uses namespaces, exceptions and other crazy stuff [12:59:36] if it was only me, i would prevent WikibaseDatabsae to be deployed in wmf branches [12:59:41] thats like uber controversial in core [13:00:51] just when we start actually working on RFC / cleaning out the mw/core technical debt, you come up with an "extension" which is essentially replacing a part of mw/core [13:01:08] and surely going to rebase all your extension to use that [13:01:17] I must say this is not very constructve [13:01:34] addshore: got something more or less running https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/2/console [13:02:04] addshore: Jenkins setup a mediawiki installation listening on localhost:9413 (or some port like that) [13:02:22] hashar: you minsunderstand what this library does. It does not replace what is in core in any way [13:02:29] It builds on top of it [13:02:34] No duplication of functionality [13:02:43] addshore: the job does two curl requreqst to find out whether the install is working. One is against [[Special:JavaScriptTest/qunit]] which claims the entry point is wrong: "Use repo/Wikibase.php resp. client/WikibaseClient.php instead." [13:02:44] 10[2] 04https://www.wikidata.org/wiki/Special:JavaScriptTest/qunit [13:03:11] hashar: now that is interesting.. [13:03:11] addshore: I guess you want to hack the switch( getenv( 'JENKINS_JOB' ) ) in the Wikibase.php entry point [13:03:19] ahh indeed. [13:03:28] JeroenDeDauw: what I mean is that we should put that in core so everyone can take advantage of it [13:03:44] JeroenDeDauw: but I guess we can now simply ask to get WikibaseDatabase to be merged in core :-D [13:04:03] addshore: I am adding it to tests [13:04:06] once it is ready ;p [13:04:21] hashar: good luck with that. I think it'd be great to have this bundled with core [13:04:45] hmm hashar the switch should currently load everything correctly [13:04:57] hashar: also please don't go make assumptions on how evil I am or whatnot. Im not planning to have all my extensions use this, or to undermine core dev, or whatever [13:05:27] addshore: it is based on the jenkins job name. The Qunit job is named 'mwext-Wikibase-qunit' so you will need a new entry [13:05:38] JeroenDeDauw: I know you are not evil :-] [13:05:51] hmm, but the switch has a default set of stuff to load [13:05:55] JeroenDeDauw: just find a pity that all this code is in an extension when it could land in core and thus improve core !! :-D [13:06:00] so every jenkins job should run no matter what the name [13:06:06] addshore: ah true, so there might be another issue [13:06:54] hmmm, slightly odd [13:07:18] do we need to get the var to enable the quint special page or does the qunit job already do that? [13:07:47] addshore: PHP_SAPI !== 'cli' [13:07:57] addshore: the Wikibase.php entry points dies out whenever called from non CLI [13:08:12] ahhhh! true! [13:08:13] addshore: which is the case with qunit since the code is being run under Apache :] [13:08:19] okay, slight modification needed ;p [13:08:40] addshore: I am pretty sure it is there to make sure someone does not add that entry point by mistake [13:09:01] indeed, but making sure getenv( 'JOB_NAME' ) === false should be enough [13:09:10] hopefully :-] [13:09:57] is the full job name 'mwext-Wikibase-qunit' ? [13:10:07] mwext-Wikibase-qunit [13:10:08] yeah [13:11:18] (03PS1) 10Addshore: Allow entry by qunit jenkins test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89707 [13:12:23] hashar: care to +2 it? :P [13:12:35] will test it out first [13:12:38] let me deploy qunit first [13:12:49] https://gerrit.wikimedia.org/r/#/c/89708/ [13:12:53] :> [13:14:51] addshore: building your hack manually : https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/3/console [13:15:00] hehe :P [13:15:26] oh noez! hax00rz! [13:15:30] quick, hide! [13:15:33] * lazowik hides [13:15:48] Aborted due to warnings. :/ [13:16:04] 13:14:54 This entry point is for use by the Jenkins testing framework only. [13:16:04] 13:14:54 Use repo/Wikibase.php resp. client/WikibaseClient.php instead. [13:16:05] na [13:16:12] though that might be the wrong file being tested hehe [13:16:13] mhhhm [13:16:28] add the value of $jenkins_job_name in the message? [13:16:36] okay :) [13:17:02] well.. it is === false :P [13:17:19] there is no way that could be wrong xD [13:17:34] oh wait... [13:17:35] ahhh [13:17:37] except [13:17:39] the jobname will not get set.. [13:17:48] JOB_NAME is not set in apache :/ [13:17:53] ;_; [13:18:08] can was add more hacks? :P [13:18:14] *we [13:18:15] so [13:18:26] we could have the job export its environment variable in a file [13:18:27] or give me some other var to look for ;p [13:18:35] then have the PHP entry point to load theenv variables [13:18:37] but that is ugly [13:18:47] hashar: this is already ugly ;p [13:19:52] can't even use $wgEnableJavaScriptTest = true; [13:19:58] since it is injected after grgmblb [13:23:19] hashar: $_SERVER[HTTP_USER_AGENT] ? :P [13:23:30] hehe [13:23:39] I wonder what that would be in this case [13:25:14] hmm, there is actually a todo in the file that says .. //TODO: Use a different file for jenkins, use this for a standard repo+client setup. [13:27:05] any other environment vars set at all? :P [13:27:57] think about a way to inject Jenkins env in Apache [13:29:00] http://stackoverflow.com/questions/17550223/set-an-environment-variable-in-htaccess-and-retrieve-it-in-php ? :P [13:29:04] hashar: ^^ [13:30:11] that is evil :-] [13:30:25] evil is just what we want? :P [13:30:33] evil addshore :) [13:30:48] * addshore is making jenkins more and more evil every day [= [13:31:03] wgWikimediaJenkinsCI = true; [13:31:04] ;-D [13:31:18] really? :P [13:31:53] yeah [13:31:57] I think that is even more evil [13:32:11] so your adding a $wgWikimediaJenkinsCI? :P [13:32:43] echo -e "$wgWikimediaJenkinsCI = true;\n" \ [13:32:43] >> "$WORKSPACE/LocalSettings.php" [13:32:49] that is horrririiiibbbbbbble [13:32:51] eww but okay :P [13:33:07] job updated [13:33:14] give me 2 ticks :) [13:33:27] over thenext few weeks I will eventually drop lot of the jenkins job configuration online shell scripts [13:33:39] and move them to plain shell scripts, that will be easier to hack in [13:33:40] so in https://gerrit.wikimedia.org/r/#/c/89707/ [13:33:48] potentially you will have $wgWikimediaJenkinsCI set to true [13:34:10] hmm but still no JOB name? [13:34:15] nop [13:34:19] okay [13:34:32] can't get that in the Apache process without using some very bad hacks [13:35:51] (03PS2) 10Addshore: Allow entry by qunit jenkins test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89707 [13:35:52] hashar: lets try again :) ^^ [13:36:17] ahh, job is already in there :) [13:36:34] heh [13:36:38] PHP Parse error: syntax error, unexpected '=' in /srv/ssd/jenkins-slave/workspace/mwext-Wikibase-qunit/LocalSettings.php on line 119. [13:36:47] see [13:36:50] my php is bad [13:36:55] xD [13:38:20] of course echo "$foobar = true" [13:38:22] expands to: [13:38:23] = true [13:38:24] :-D [13:38:29] https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/5/console [13:38:31] \O/ [13:38:45] rebasing quicky :P [13:38:59] (03PS3) 10Addshore: Allow entry by qunit jenkins tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89707 [13:40:03] huh, serialization? [13:40:06] validator? [13:40:09]