[00:01:20] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/Diff] - 10https://gerrit.wikimedia.org/r/89651 (owner: 10L10n-bot) [00:01:35] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/Diff] - 10https://gerrit.wikimedia.org/r/89651 (owner: 10L10n-bot) [03:25:33] (03Draft1) 10Aude: remove unused WikibaseClient use statements in lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89767 [07:46:44] (03PS2) 10Henning Snater: (hotfix) Make inherit work with IE 8 again [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89733 (owner: 10Daniel Werner) [07:52:20] (03PS1) 10Henning Snater: inputAutoExpand: Catch miscalculation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89774 [07:55:17] (03PS2) 10Henning Snater: inputAutoExpand: Catch miscalculation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89774 [07:56:07] (03CR) 10Henning Snater: [C: 032] (hotfix) Make inherit work with IE 8 again [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89733 (owner: 10Daniel Werner) [07:57:36] I am writing a Wikidata bot to add links to Commons images. [07:57:38] Problem: pywikibot.page.ImagePage(u"TheImage.jpg") does not work. I guess I have to specify the Commons site, but how to do? [07:58:11] Nicolas: hi! [07:58:21] i don't know to answer the question… but hi! [07:58:31] Hi rschen7754 Nice to see you here :-) [08:02:18] (03CR) 10Tobias Gritschacher: [C: 032] inputAutoExpand: Catch miscalculation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89774 (owner: 10Henning Snater) [08:02:30] (03Merged) 10jenkins-bot: inputAutoExpand: Catch miscalculation [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89774 (owner: 10Henning Snater) [08:38:51] (03PS1) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [08:40:35] I have found: site = pywikibot.Site("en", "wikivoyage"); image = pywikibot.page.ImagePage(site, u"TheImage.jpg") [09:07:22] https://gerrit.wikimedia.org/r/#/c/83846/ [09:07:23] DanielK_WMDE: [09:08:40] (03PS2) 10Henning Snater: claimview: Re-attaching event listeners when creating qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89199 [09:09:17] (03CR) 10Addshore: [C: 032] remove unused WikibaseClient use statements in lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89767 (owner: 10Aude) [09:09:50] (03PS8) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [09:09:55] (03PS5) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [09:10:01] (03PS5) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [09:17:04] (03CR) 10Addshore: [C: 032] "Everything looks good here" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [09:19:45] (03CR) 10Tobias Gritschacher: [C: 032] claimview: Re-attaching event listeners when creating qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89199 (owner: 10Henning Snater) [09:22:19] (03CR) 10Daniel Kinzler: "(12 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [09:23:04] (03CR) 10Daniel Kinzler: [C: 04-1] "see previous comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [09:26:41] Thanks rschen7754. ;) [09:26:47] (03Abandoned) 10Tobias Gritschacher: Fix var keywords to go with coding conventions [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/81661 (owner: 10Tobias Gritschacher) [09:27:11] hmm? [09:28:46] (User rights log); 11:19 . . Rschen7754 (talk | contribs) changed group membership for User:Sjoerddebruin from autopatroller to autopatroller and rollbacker ‎(rollbacker on nlwiki) [09:28:55] oh [09:28:57] no problem :) [09:29:01] short-term memory loss lol [09:29:22] (03Merged) 10jenkins-bot: claimview: Re-attaching event listeners when creating qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89199 (owner: 10Henning Snater) [09:29:29] 4 minutes... New record? [09:33:49] (03CR) 10Daniel Kinzler: "yea, what Jeroen said :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 (owner: 10Addshore) [09:34:52] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 (owner: 10Daniel Kinzler) [09:35:43] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 (owner: 10Addshore) [09:37:27] How do I register facts on battles ? [09:39:59] (03CR) 10Daniel Kinzler: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89025 (owner: 10Addshore) [09:42:16] (03PS3) 10Addshore: Add basic tests for SearchEntities... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 [10:01:15] (03CR) 10Addshore: [C: 04-1] "(10 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [10:07:42] (03CR) 10Addshore: [C: 04-1] "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [10:16:56] (03PS2) 10Addshore: Removed replacing of suggester input text when hovering a suggestion [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89159 (owner: 10Henning Snater) [10:20:19] (03CR) 10Addshore: [C: 032] Removed replacing of suggester input text when hovering a suggestion [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89159 (owner: 10Henning Snater) [10:20:29] (03Merged) 10jenkins-bot: Removed replacing of suggester input text when hovering a suggestion [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89159 (owner: 10Henning Snater) [10:22:03] (03PS2) 10Addshore: $.ui.suggester: Implemented autocompletestring for static result set [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89160 (owner: 10Henning Snater) [10:22:11] (03PS3) 10Addshore: Factored getscrollbarwidth utility function out of suggester widget [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89172 (owner: 10Henning Snater) [10:22:12] (03PS2) 10Addshore: $.ui.suggester: Suppress autocomplete's native blur handling [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89178 (owner: 10Henning Snater) [10:27:32] (03CR) 10Addshore: [C: 031] "php looks fine, I will let someone else once over the js" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 (owner: 10Henning Snater) [10:28:07] (03PS8) 10Addshore: (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [10:28:17] (03PS17) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [10:29:57] (03CR) 10jenkins-bot: [V: 04-1] (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [10:31:01] (03PS18) 10Aude: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [10:33:45] (03CR) 10jenkins-bot: [V: 04-1] (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [10:34:55] (03PS1) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [10:35:39] oh no, " You are not allowed to use Repo or Client code in Lib!" :o [10:35:45] :P [10:35:52] bad aude! [10:36:04] :) [10:37:18] (03CR) 10Addshore: [C: 032] Add update method to QueryStoreSetup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88977 (owner: 10Jeroen De Dauw) [10:37:46] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [10:40:05] (03PS19) 10Aude: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [10:40:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [11:02:13] saluton [11:03:48] hoi Marek_M [11:04:17] Kial ne funkcias [[P435]] en [[Q4891371]]? Ligilo: http://musicbrainz.org/recording/1289ea33-a7f2-4cb2-9b5f-714b5ad6086e funkcias [11:04:19] 10[1] 04https://www.wikidata.org/wiki/P43513 => [11:04:21] 10[2] 10https://www.wikidata.org/wiki/Q4891371 [11:04:43] [[Property:P435]] [11:04:44] 10[3] 10https://www.wikidata.org/wiki/Property:P435 [11:09:39] Marek_M: what is it you want ? [11:11:13] (03PS3) 10Addshore: Expand TableCreateModifyDeleteTest integrationTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89712 [11:15:28] (03CR) 10Tobias Gritschacher: [C: 032] Removes references to QuantityValue from SnakTest. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89399 (owner: 10Daniel Kinzler) [11:15:33] GerardM Why do not work[[Property:P435]] in [[Q4891371]]? http://musicbrainz.org/recording/1289ea33-a7f2-4cb2-9b5f-714b5ad6086e do work [11:15:41] (03Merged) 10jenkins-bot: Removes references to QuantityValue from SnakTest. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/89399 (owner: 10Daniel Kinzler) [11:15:48] 10[4] 10https://www.wikidata.org/wiki/Property:P43513 => [11:15:50] 10[5] 10https://www.wikidata.org/wiki/Q4891371 [11:19:18] hehe aude thats core change is now on PS8 :> [11:21:00] Marek_M: there is a musicbrainsID in use [11:21:31] and the ID given seems to be wrong [11:23:06] (03PS24) 10Addshore: Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:26:18] weird [11:26:23] (03CR) 10jenkins-bot: [V: 04-1] Extend API to support editing badges (DNM) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:28:04] addshore: oh noez! I have local changes! [11:28:10] thats fine :P [11:28:18] it will ujst push over the top of it [11:28:34] ok [11:28:59] bye! [11:34:27] hashar: do the qunittests on jenkins run with a db? [11:35:08] addshore: iirc the mediawiki install uses a sqlite backend [11:36:44] most of the errros seem to be to do with focus of things or things that depend on the db, will poke some more [11:45:54] Marek_M: [[Property:P435]] is for works, http://musicbrainz.org/recording/1289ea33-a7f2-4cb2-9b5f-714b5ad6086e is a recording though… [11:45:57] 10[6] 10https://www.wikidata.org/wiki/Property:P435 [11:46:09] (03PS4) 10Daniel Kinzler: (bug #55511) Introducing DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 [11:46:18] (03PS7) 10Daniel Kinzler: (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 [11:50:36] hmm hashar the errors have messges such as Message: API request failed returning code: "internal_api_error_DBQueryError". See console for details. (is there any way to 'see the console' for further details within jenkins? :P) [11:50:54] that is the phantomjs console isn't it ? [11:51:04] not sure how to fetch it [11:53:30] maybe that is the stack trace being displayed ? [11:53:41] Krinkle|detached would know but he is no more around :( [11:54:16] okay :P final qu, is there any way to mark tests to be ignore by jenkins? :P (other than the obvious comment them out? :P) [11:55:08] no more around? [11:55:33] addshore: in qunit ? no clue [11:55:38] addshore: you would have to skip them [11:55:42] you mean holiday? [11:55:44] okay :P [11:55:53] addshore: jenkins itself is pretty dumb :-D [11:56:48] hmm now nice and interesting, some of the test that fail seem to pass when run by themselves. this is like phpunit all over again [11:58:02] (03PS8) 10Daniel Kinzler: (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 [11:58:15] (03PS3) 10Daniel Kinzler: Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 [12:00:16] heh, and the more I run them the less they fail... [12:01:31] (03PS4) 10Daniel Kinzler: Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 [12:02:00] (03PS2) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [12:02:13] addshore: addressed your comments --^^^^ [12:03:31] (03PS6) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [12:11:58] aude: may be of interest to you: http://blog.sofistes.net/2013/04/working-with-vim-on-large-projects.html [12:13:34] (03PS2) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [12:14:46] DanielK_WMDE: cool :) [12:14:53] (03PS13) 10Addshore: Build for mw1.22-wmf21 14:14 15.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/88991 [12:16:23] (03CR) 10jenkins-bot: [V: 04-1] (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [12:19:34] DanielK_WMDE: all looks good to me, perhaps someone should also give it a once over [12:19:50] there is a fail ammount of basic mathy stuff that we dont want to have messed up ;p [12:20:44] (03CR) 10Addshore: [C: 031] (bug #55511) Introducing DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 (owner: 10Daniel Kinzler) [12:20:45] (03CR) 10Addshore: [C: 031] (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [12:20:46] (03CR) 10Addshore: [C: 031] Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [12:20:47] (03CR) 10Addshore: [C: 031] Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [12:21:50] so aude in your opinion whats the next step for the build step? :) [12:23:42] addshore: well, i need to see that submodules do work [12:23:46] * aude thinks so [12:23:58] and then have the build updated [12:24:00] aude: they already doo :P we we have a submodule in wikibase already ;p [12:24:21] update it each time something gets merged :) [12:24:25] for master [12:24:43] hashar: does that sound feasable in a jenkins job? [12:24:49] addshore: i think submodules do work but a gazillion submodules? :) [12:25:04] and submodule of submodules [12:25:22] addshore: we can make a grunt task that does this [12:25:32] * aude thinks jenkins can work with grunt [12:25:36] easyrdf is a submodule of a submodule, :P as wikibase itself is a submodule in the first place :) everything should be recursive [12:25:41] addshore: true [12:25:47] aude: all we need is a bash script ;p [12:25:58] addshore: i trust you :P [12:26:14] but then the question is do we want a build for every commit, or just for our branches? [12:26:23] addshore: a bash script is okay too [12:26:29] if it is flexible [12:26:43] addshore: all commits, each and every one [12:27:01] all merges [12:27:03] that sounds mildly painfull :P [12:27:15] so all merges of all submodules too :P [12:27:33] maybe if jenkins / travis approves of commits in each individual repo [12:27:42] not required though [12:27:54] hehe, postmerge jobs :) [12:28:31] beta runs latest master of everything and will use the build [12:28:33] Henning_WMDE: http://plasmasturm.org/log/6debug/ [12:28:41] well making it happen for master of everything is easy, now just to think about the branches [12:28:48] branches are easier [12:28:54] are they? :P [12:28:56] yes [12:29:23] but easier in an automated way? :P or we will also have to branch the Wikidata repo when we branch everything else? [12:29:38] if we want to start with my grunt scripts, they put all the extensions as subdirectories of the wikidata build directory [12:29:45] but can be changed to do submodules [12:30:24] addshore, aude: one major use case for the build script will be pruning easyRdf for our needs (instead of manually maintaining a fork). [12:30:25] branching wikidata when we branch everything.... not sure how that works [12:30:36] (just something to keep in mind) [12:30:39] DanielK_WMDE: sure [12:31:13] addshore: my script updates the composer file in each extension so it gets the branch versions of the dependencies for travis [12:32:05] git pull > git submodule foreach git pull > git submodle update --recursive > git commit -a -s 'Update build' > git push :P [12:32:14] thats basically all that needs to happen :P [12:32:45] ok :) [12:33:02] infact the script to update everything could just be included in the repo as well :P [12:33:06] https://git.wikimedia.org/summary/integration%2Fgrunt-contrib-wikimedia.git if we want to go that way [12:33:16] as example [12:33:16] git pull > ./update.sh > xD [12:33:24] ok [12:33:42] infact, ignore the git pull also ;p [12:44:00] addshore: can we have additional jenkins jobs that load just client + dependencies and separately load repo + dependencies? [12:44:25] for what? [12:44:30] for the build [12:44:46] looks like it loads both and does one job [12:44:55] + lint [12:45:14] we could, but then we are just massivly duplicating tests and adding load on jenkins [12:45:27] hmmmmm [12:47:19] eventually it would be great to run the tests with our actual settings also :) [12:47:25] instead of example settings [12:47:52] well, potentially yes for the build :P [12:48:08] * aude demands it  [12:48:14] not yet though [12:49:02] * addshore needs to wait for someting somewhere to be merged to see if these few commands work :P [12:49:10] ok [12:50:46] addshore: I think I might be able to enable parallel processing of phunit jobs [12:50:52] addshore: got to break everything first [12:51:11] wait, they already do run in parallel though..? :P [12:51:32] aude: idealy jenkins would do things like this for us http://git.wikimedia.org/commit/mediawiki%2Fextensions/d0e5b5dca0f33cd176a46fb4e07c0457bab8ffbb [12:51:42] when the extension is updated it updates the submodule in the container [12:52:01] which is defecitvly the same for us, when we commit to wikibase it updates wikidata and then updates extensions [12:52:11] addshore: yep [12:53:02] hashar: do you mean parallel processing of phpunit jobs or phpunit tests? :P I am confused! [12:53:14] oh wait! [12:53:23] parallel processing of jobs when the job is the same ! [12:53:30] that would be amazing xD [12:58:18] (03PS1) 10Addshore: Add missing implements UnEscaper [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89817 [12:59:10] addshore: yeah // of jobs [12:59:25] addshore: the blocker is that each builds reuse the same sqlite filename [12:59:26] but [12:59:30] I got a patch :-] [12:59:31] addshore: http://git.wikimedia.org/tree/mediawiki%2Fextensions [12:59:32] :D [12:59:34] see some scripts there [13:00:13] heh aude thats probably exactly what we want / need xD [13:00:18] i think so [13:00:32] I need to decouple some shell commands first [13:00:36] i'm not sure exactly how/when/where those run [13:00:56] probably triggered post jenkins merge [13:01:34] probably [13:10:06] DanielK_WMDE: you made your stuff rather hard to review :| [13:11:48] (03PS4) 10Addshore: Expand TableCreateModifyDeleteTest integrationTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89712 [13:12:41] (03CR) 10Jeroen De Dauw: [C: 04-1] "Follow ups with fixes need to be approved first" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 (owner: 10Daniel Kinzler) [13:14:20] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [13:23:51] (03CR) 10Jeroen De Dauw: [C: 04-1] "(5 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [13:24:27] (03PS5) 10Addshore: Expand TableCreateModifyDeleteTest integrationTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89712 [13:24:31] JeroenDeDauw: bingo ^^ [13:25:19] apaprently it doesn want the tablename when removing an index... [13:26:10] (03PS1) 10Henning Snater: (hotfix) claimview: Correctly rebuild qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89823 [13:27:51] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [13:30:14] Henning_WMDE: is this hotfix something to backport? [13:31:05] No, it's in master but not in the deployment branch [13:31:10] ok, fine [13:36:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [13:36:49] addshore: \o/ [13:39:09] (03CR) 10Jeroen De Dauw: [C: 032] Expand TableCreateModifyDeleteTest integrationTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89712 (owner: 10Addshore) [13:43:58] (03PS1) 10Addshore: Improve sqlite documentation with links [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89826 [13:44:45] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89817 (owner: 10Addshore) [13:46:47] Abraham_WMDE: ping [13:47:25] Abraham_WMDE: got a bunch of repos that are probably better suited on WMDE GH then WMF gerrit [13:52:17] (03PS1) 10Jeroen De Dauw: Add TODO file [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89827 [13:52:24] (03CR) 10Jeroen De Dauw: [C: 032] Add TODO file [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89827 (owner: 10Jeroen De Dauw) [13:52:38] (03PS6) 10Jeroen De Dauw: Update docs and @since tags. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88739 [13:52:59] (03PS2) 10Addshore: Improve docs with links for mysql and sqlite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89826 [13:54:53] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89725 (owner: 10Addshore) [13:55:31] (03CR) 10jenkins-bot: [V: 04-1] Update docs and @since tags [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88739 (owner: 10Jeroen De Dauw) [13:56:29] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89826 (owner: 10Addshore) [13:57:04] (03PS2) 10Jeroen De Dauw: Match https://gerrit.wikimedia.org/r/88975 in QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 [13:59:43] (03PS2) 10Henning Snater: (hotfix) claimview: Correctly rebuild qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89823 [13:59:52] (03CR) 10jenkins-bot: [V: 04-1] Match https://gerrit.wikimedia.org/r/88975 in QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 (owner: 10Jeroen De Dauw) [14:01:13] (03PS3) 10Addshore: Improve docs with links for mysql and sqlite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89826 [14:03:47] (03CR) 10Jeroen De Dauw: [C: 04-1] "(10 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [14:05:09] (03CR) 10Jeroen De Dauw: "I am disappointed we are writing code that is legacy from the beginning, while it is clear how we can do this better, and while it is also" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [14:05:53] (03CR) 10Jeroen De Dauw: [C: 032] Improve docs with links for mysql and sqlite [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89826 (owner: 10Addshore) [14:07:10] JeroenDeDauw: in theroy thats the big parts of the component done [14:07:44] addshore: probably yes [14:08:09] addshore: I'll be doing an extra review pass for the security related stuff later today [14:08:28] addshore: first going to finish my QueryEngine work now though, been doing a lot of review already [14:09:02] addshore: can you have a look at https://gerrit.wikimedia.org/r/#/c/88976/ and see if you can find the cause for the WikibaseDatabase failures? [14:09:19] addshore: there are some repo/datamodel related ones as well, though these are already fixed in another commit [14:12:23] (03PS1) 10Addshore: Add @group Database tags [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89829 [14:12:29] JeroenDeDauw: this could be it.. ^^ [14:13:08] aude: care to merge my above commit? [14:16:48] (03CR) 10Jeroen De Dauw: [C: 032] Add @group Database tags [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89829 (owner: 10Addshore) [14:17:47] (03PS3) 10Addshore: Match https://gerrit.wikimedia.org/r/88975 in QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 (owner: 10Jeroen De Dauw) [14:18:06] Reedy: when you update wikidata, https://gerrit.wikimedia.org/r/#/c/89715/ [14:19:04] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#127 (master - 7053147 : jeroendedauw): The build has errored. [14:19:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/fda95b6943bd...705314710fb4 [14:19:05] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12570123 [14:19:10] whahaa [14:19:33] stalled :) [14:20:42] (03CR) 10jenkins-bot: [V: 04-1] Match https://gerrit.wikimedia.org/r/88975 in QueryEngine. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 (owner: 10Jeroen De Dauw) [14:20:48] heh JeroenDeDauw that didnt fix it :P [14:21:50] :| [14:22:49] JeroenDeDauw: it may have to extend MediawikiTestCase instead... [14:23:01] function needsDB() { [14:23:04] if ( preg_match( '/@group +Database/im', $rc->getDocComment() ) ) { [14:23:04] return true; [14:23:04] } [14:23:08] return false; [14:25:19] I would hope the LazyDBConnectionProvider gets around that though [14:26:13] (03CR) 10Tobias Gritschacher: [C: 032] (hotfix) claimview: Correctly rebuild qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89823 (owner: 10Henning Snater) [14:26:53] (03CR) 10Tobias Gritschacher: [C: 032] Removed movetoolbar widget's listView option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88979 (owner: 10Henning Snater) [14:27:45] addshore: I don't see how LazyDBConnectionProvider would mitigate the needof subclassing that evil thing, if there indeed is such a need [14:27:56] Though that might indeed be it - the need to subclass it [14:28:14] shall we try? :/ [14:28:28] if not we could always skip the integration tests if no DB is actually provided.. [14:28:47] addshore: yeah, try [14:28:54] addshore: oh, you figured out why it is failing? [14:29:22] no :P but it is only the integration tests that fail, and they are the only tests that need a db, so im guessing it has to be that.. [14:29:48] (03Merged) 10jenkins-bot: (hotfix) claimview: Correctly rebuild qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89823 (owner: 10Henning Snater) [14:30:36] PHPUnit_Framework_Error : Argument 1 passed to Wikibase\Database\SQLite\SQLiteTableDefinitionReader::__construct() must implement interface Wikibase\Database\QueryInterface\QueryInterface, null given [14:30:40] * JeroenDeDauw blames addshore [14:30:48] O_o [14:30:58] where is that one? :P [14:31:11] I just see a lot of InvalidArgumentException: The table $fields list cannot be empty [14:33:20] (03PS3) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [14:33:22] (03Merged) 10jenkins-bot: Removed movetoolbar widget's listView option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88979 (owner: 10Henning Snater) [14:38:26] (03Draft3) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [14:39:01] Abraham_WMDE: where are you hiding> [14:39:14] addshore: don't worry, it is already fixed now [14:39:54] (03PS1) 10Addshore: Attempt to fix tests in Query and QueryEngine.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89831 [14:40:02] oh :P [14:40:14] (03Abandoned) 10Addshore: Attempt to fix tests in Query and QueryEngine.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89831 (owner: 10Addshore) [14:42:00] maybe anyone wants to merge or review this one? https://gerrit.wikimedia.org/r/#/c/89510/ [14:43:01] JeroenDeDauw: I've got a question at this: https://gerrit.wikimedia.org/r/#/c/89607/1/repo/Wikibase.hooks.php [14:43:14] (03CR) 10Daniel Kinzler: "(5 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [14:43:22] JeroenDeDauw: --^ [14:43:29] I don't want to delete the lines of code because I don't know if they are needed later [14:44:05] but they create an ugly amount of checkboxes in the preferences... [14:47:47] (03PS5) 10Jeroen De Dauw: Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 [14:47:56] (03CR) 10jenkins-bot: [V: 04-1] Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [14:47:57] addshore: reviewwww [14:47:59] err [14:48:35] whut? [14:48:48] (03CR) 10Daniel Kinzler: "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [14:49:17] JeroenDeDauw: more replies ---^ [14:49:26] briefly discuss this f2f? [14:50:03] JeroenDeDauw: maybe I can remove the lines and add them in another patch again? [14:50:35] (03CR) 10Daniel Werner: [C: 04-1] "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 (owner: 10Daniel Kinzler) [14:51:35] benestar: what are you talking about? [14:51:38] DanielK_WMDE: in a momemnt [14:51:56] JeroenDeDauw: I've got a question at this: https://gerrit.wikimedia.org/r/#/c/89607/1/repo/Wikibase.hooks.php [14:52:04] (03PS6) 10Jeroen De Dauw: Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 [14:52:12] (03CR) 10jenkins-bot: [V: 04-1] Add updating capability to SQLStore setup. [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [14:52:44] benestar: that would be preffered yes [14:52:53] ok, thanks :) [14:54:12] addshore: have you seen this? https://integration.wikimedia.org/ci/job/mwext-WikibaseQueryEngine-testextensions-master/151/console [14:54:27] (03PS2) 10Bene: (bug 47496) Use (hidden) preference for copyright acknowledgment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 [14:55:19] huh... [14:55:32] (03CR) 10Tobias Gritschacher: [C: 032] Improved toolbarcontroller's event namespace assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88994 (owner: 10Henning Snater) [14:55:42] Unexpected non-MediaWiki exception encountered, of type "UnexpectedValueException"Build step ... [14:55:45] thats a bit odd.. [14:56:34] addshore: can you review anyway? Tests run locally for me, and we can see if they run on travis [14:56:59] (03Abandoned) 10Jeroen De Dauw: Adding dataTypeId field to PropertyValueSnak [DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85530 (owner: 10Jeroen De Dauw) [14:57:02] (03Abandoned) 10Jeroen De Dauw: Adding dataTypeId field to PropertyValueSnak [DNM] [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/85529 (owner: 10Jeroen De Dauw) [14:57:18] (03CR) 10Daniel Werner: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [14:59:43] (03Merged) 10jenkins-bot: Implemented index in ChangeOpReference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88997 (owner: 10Henning Snater) [14:59:44] (03Merged) 10jenkins-bot: Improved toolbarcontroller's event namespace assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88994 (owner: 10Henning Snater) [15:01:45] (03PS7) 10Addshore: Add updating capability to SQLStore setup. [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [15:01:54] (03CR) 10jenkins-bot: [V: 04-1] Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [15:02:20] (03CR) 10Addshore: [C: 032 V: 032] Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [15:02:26] :/ [15:02:28] (03CR) 10jenkins-bot: [V: 04-1] Add updating capability to SQLStore setup [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/88988 (owner: 10Jeroen De Dauw) [15:11:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [15:14:51] (03PS9) 10Henning Snater: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 [15:15:15] travis is taking a stupid ammount of time... [15:16:01] JeroenDeDauw: >> https://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/12573602 [15:16:06] (03PS6) 10Tobias Gritschacher: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 (owner: 10Henning Snater) [15:16:32] (03PS3) 10Daniel Werner: Remove "Wikidata" specific handling of copyright message introduced in Ie7dba1130202c3c1d7dd12fc50d7ee65059d99b4 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 [15:16:45] (03CR) 10jenkins-bot: [V: 04-1] (bug 55740) Remove "Wikidata" specific handling of copyright message introduced in Ie7dba1130202c3c1d7dd12fc50d7ee65059d99b4 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [15:17:28] addshore: ? [15:17:57] addshore: I went crazy and implemented a new system to inject settings to a Jenkins MediaWiki install [15:18:03] addshore: https://gerrit.wikimedia.org/r/89837 :-D [15:18:40] will test it out tomorrow I guess [15:18:49] haha xD [15:19:15] hashar: if you dont have to run off, any idea / way to get more info about Unexpected non-MediaWiki exception encountered, of type "UnexpectedValueException"Build step 'Execute shell' marked build as failure ? :P https://integration.wikimedia.org/ci/job/mwext-WikibaseQueryEngine-testextensions-master/151/console [15:21:18] addshore: you are missing the show exception details :/ [15:21:23] which my patch above should fix [15:21:51] haha :P [15:22:07] (03CR) 10Tobias Gritschacher: [C: 032] Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 (owner: 10Henning Snater) [15:22:38] (03PS7) 10Tobias Gritschacher: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 (owner: 10Henning Snater) [15:25:59] (03Merged) 10jenkins-bot: Implemented index in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88999 (owner: 10Henning Snater) [15:27:46] (03PS5) 10Tobias Gritschacher: introduces mw.ext.wikibase, wikibase.repo and wikibase.repo.fetchedEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89109 (owner: 10Daniel Werner) [15:27:51] (03Draft1) 10Daniel Werner: (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 [15:28:32] (03CR) 10Tobias Gritschacher: [C: 04-1] "Needs manual Rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [15:29:14] (03PS2) 10Tobias Gritschacher: (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:29:24] (03CR) 10jenkins-bot: [V: 04-1] (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:31:31] JeroenDeDauw: >> http://status.travis-ci.com/ [15:40:34] (03PS6) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [15:42:04] (03PS7) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [15:47:57] pah [15:53:25] (03PS1) 10Addshore: Simplify all switches [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89845 [15:53:25] Danwe: https://bugzilla.wikimedia.org/show_bug.cgi?id=55740 <- is this really important now? is the rest of the sprint work done? ;-) [15:53:38] sorry to be a pain in the ass about it but things are in the sprint for a reason [15:53:41] Lydia_WMDE: I am not working on this [15:53:57] I only created the bug today [15:54:11] Danwe: hmm? there are patches in the bug? [15:54:14] because it has been there for weeks [15:54:18] ah ok [15:54:20] but no bug has been there [15:54:23] ok cool [15:54:30] nvm then [15:54:52] so I had to either abandone it or create a bug so the wikidata community can do steh stuff required for merging the fix [15:54:52] yeah [15:54:52] makes sense [15:55:10] aude: ^ is this on your radar for deployment? [15:58:09] Lydia_WMDE: huh? [15:58:59] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=55740 [15:59:52] move all the messages? [16:01:27] Lydia_WMDE: i think we need input from the i18n team if this approach is feasible [16:01:27] aude: ok [16:01:32] the messages are in WikimediaMessages extension with a different message key [16:01:57] anyway, what is Lydia_WMDE doing here during vacation? :) [16:02:23] aude: procrastinating preparing my talk :P [16:02:23] oh, ok [16:10:59] (03PS4) 10Jeroen De Dauw: Match https://gerrit.wikimedia.org/r/88975 in QueryEngine. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 [16:11:31] (03CR) 10jenkins-bot: [V: 04-1] Match https://gerrit.wikimedia.org/r/88975 in QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 (owner: 10Jeroen De Dauw) [16:12:51] (03PS1) 10Addshore: Refactor SQLiteTableDefinitionReader::getPrimaryKeys [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89847 [16:13:32] (03PS5) 10Daniel Kinzler: Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 [16:15:34] (03PS20) 10Aude: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [16:17:04] hashar: those tests seem to pass on travis :/ https://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/jobs/12573603 [16:17:58] (03CR) 10Aude: "@jeroen I agree with the general overall design improvements and moving serialization stuff." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [16:18:24] (03CR) 10Daniel Kinzler: "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [16:19:13] (03PS3) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [16:19:33] (03CR) 10jenkins-bot: [V: 04-1] Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [16:45:17] (03PS4) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [17:29:15] (03PS1) 10Bene: Add an option in the user preferences to choose additional languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 [17:33:06] addshore: do you have access to a recent version of the map of geo-coordinates on wikidata? [17:40:49] addshore: nvm got it [17:41:14] * aude scrambles to add more africa coordinates :) [17:41:50] you'll notice that some african countries are filled in a bit more but not all yet [17:42:05] \o/ [17:46:22] hey aude :) [17:47:59] hi [17:49:07] Lydia_WMDE: you're online? :) [17:49:33] Abraham_WMDE1: working on my talks :P but going out now to the bird parc next door [17:49:58] :D [17:50:57] they have baby monkeys!!!111eleven [17:51:38] Lydia_WMDE: send us photos! [17:51:38] will try ;-) [17:51:38] some are already on flickr [17:51:38] but not from there [17:51:38] more animals for wikidata :) [17:51:38] for our board [17:51:38] let me get you a link [17:51:38] ok [17:51:38] https://secure.flickr.com/photos/nightrose/tags/fozdoigua%C3%A7u/ [17:51:38] Lydia_WMDE: Should have taken a Wikidata relate item and attempted to put it on the monkeys :p Promoting Wikidata ;) [17:51:41] JohnLewis: lol [17:51:45] poor monkeys [17:51:47] Lydia_WMDE: amazing [17:52:04] aude: indeed! i also did a helicopter flight over the falls [17:52:08] it was breathtaking [17:52:13] but way too short [17:52:15] just 10 mins [17:52:15] \o/ [17:52:16] Lydia_WMDE: Not poor monkeys, Cute Wikidata Promotion :D [17:52:26] JohnLewis: haha - point! [17:54:24] (03CR) 10Jeroen De Dauw: [C: 032] Simplify all switches [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89845 (owner: 10Addshore) [17:55:07] if anyone feels like working on an item: https://www.wikidata.org/wiki/Q202316 would be cool as I'll be showing that if i can get the organizer to switch my talk [17:55:16] and with that i am out [17:55:18] laters :) [17:55:20] (03CR) 10Jeroen De Dauw: [C: 032] Refactor SQLiteTableDefinitionReader::getPrimaryKeys [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89847 (owner: 10Addshore) [17:56:52] Lydia_WMDE: When is your talk? [17:58:01] JohnLewis: friday supposedly [17:58:33] Lydia_WMDE: Well, I'll clear WD:PP out and see if I can add anything additional to it :) [17:58:33] Lydia_WMDE: is there any bug that should be fixed and that is not too hard? [17:59:14] JohnLewis: all assuming i can convince the organizers that a wikidata presentation is better than the other one they have me planned for but i'm hopeful [17:59:28] benestar: did you already have a look at the bugs marked need-volunteer? [17:59:48] benestar: also the one i just edited maybe [17:59:55] one sec [18:00:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=55731 [18:00:23] ok - but now for real [18:00:28] * Lydia_WMDE is gone ;-) [18:02:05] :p [18:03:52] and new code deployed! [18:03:55] benestar: We just clashed :p You created the same claim I changed :p [18:04:08] ups :P [18:04:23] lol [18:04:34] JohnLewis: on German Wikipedia it says 1914... [18:05:02] In 1910, the colony's status was upgraded to the position of "vila" (town or village), named "Vila Iguazu", and, in 1914, to city. At that time, the city was known as Foz do Iguassu. [18:05:26] JohnLewis: do you know a fitting qualifier for this two statements? [18:05:34] Hm. [18:05:48] benestar: Add it back in and I'll look around for one. [18:14:10] Abraham_WMDE1: RCM remade his first clean code episode, which is mostly motivational. Think it'd not be bad for everyone in the team to have a look at it http://www.cleancoders.com/codecast/clean-code-episode-1/show [18:22:19] JeroenDeDauw: thanks for the pointer [18:22:32] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#131 (master - d6d3a81 : addshore): The build has errored. [18:22:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/abcdd4eb0899...d6d3a812ccd0 [18:22:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12580706 [18:22:59] JeroenDeDauw: that's exactly the right input for the "developer cinema" I'm currently planning (we talked a bit about) ;) [18:26:08] addshore: this stupidify is not present in SQLIte as it is overriden there [18:26:14] Same effect still occurs though [18:26:17] Since http://php.net/manual/en/pdo.quote.php is used [18:26:22] Which quotes numbers as well [18:26:29] Not sure if this should be used for numbers [18:33:19] (03PS1) 10Bene: (bug 55731) escaped HTML-chars in wbclient-linkItem-goButton label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89874 [18:44:59] JohnLewis: did you find something? [18:45:35] benestar: Was busy. I'll look now. [18:45:41] k [18:52:28] aude: if you have time you might review my patches ;) [18:54:18] benestar: Significate event is all I can find tbh and that might not fit too well. [18:55:16] well, should we use it though? [18:57:12] benestar: Might as well really. If someone disagrees they should find a better property :p [18:57:24] you're right ;) [18:59:22] JohnLewis: what's the id of the property? [19:01:32] I think grrrit-wm cannot decide xD [19:02:27] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Match https://gerrit.wikimedia.org/r/88975 in QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88976 (owner: 10Jeroen De Dauw) [19:18:23] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#64 (master - 9cd12bc : jeroendedauw): The build was broken. [19:18:23] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/f16c5d33116c...9cd12bc91c92 [19:18:23] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12583292 [19:50:13] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#65 (master - b83e372 : Translation updater bot): The build is still failing. [19:50:13] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/9cd12bc91c92...b83e37279093 [19:50:13] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12584580 [20:42:30] (03PS1) 10Jeroen De Dauw: Fix conceptual issue with the TableNameFormatter interface [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 [20:53:28] (03PS1) 10Jeroen De Dauw: Update TravisCI config so it uses a db prefix on MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015