Foobar

[01:39:43] could someone with property creator rights please look at https://www.wikidata.org/wiki/Wikidata:Project_chat#Many_term_properties_await_promotion? [08:05:15] I dont understand where the Foobar tag in the comes from in the wikidata-dumps. I don't think its the en-title [09:15:21] addshore: can you look at https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#New_API_wbeditentity:_Help ? [09:15:24] please? [09:15:30] i think you know the answer better than i do [09:15:37] will do in a few mins [09:15:40] k [09:24:10] I dont understand where the Foobar tag in the comes from in the wikidata-dumps. I don't think its the en-title [09:25:12] lbenedix: you mean Q42 for example? [09:25:33] no [09:26:19] then i am not sure where you are talking about? which dumps? [09:26:32] http://dumps.wikimedia.org/wikidatawiki/ ? [09:26:43] ok... i mean yes [09:27:05] it's just the page title which is same as item id [09:28:05] other than that, i think there is nothing special for wikidata when it comes to the dumps [09:31:02] the dumps are ok [09:31:11] but I wonder about the Title on https://www.wikidata.org/wiki/Q2570036?setlang=de [09:31:36] there is no label but a HTML- [09:31:56] <GerardM> aude is there a dump created after 31 september so that the statistics can be created ? [09:32:05] <aude> GerardM: october 6 [09:33:37] <aude> lbenedix: i think the language fallback is handling that [09:34:01] <aude> e.g. you have en in your babel box so it uses english there, in case german is not found [09:34:18] <aude> language fallback does not work everywhere yet but in some places like that it works [09:34:37] <lbenedix> why not pasting that into the label input field, so the user can edit or save it? [09:35:08] <aude> lbenedix: i don't think anyone has considered exactly that [09:35:41] <aude> in case of an item about a person, that makes sense but might not always [09:36:03] <aude> therefore might need some thought and discussion on how to do fallback in that situation [09:36:08] <lbenedix> I dont say, that you should save that for every item [09:36:16] <aude> ok :) [09:36:25] <lbenedix> just make it easy for people to check the label and save it, if its correct [09:36:27] <aude> certainly an interesting idea and might work [09:36:53] <aude> would you like to put that on https://www.wikidata.org/wiki/Wikidata:Paper_cuts ? [09:37:04] <lbenedix> I'll do that later [09:37:07] <aude> ok [09:37:31] <aude> thanks for the idea :) [09:37:40] <lbenedix> and I think about writing a gadget to set the same label for all langs in one step [09:37:52] <aude> ok [09:38:01] <lbenedix> the name of a person is allmost the same in every language [09:38:05] <aude> true [09:38:11] <lbenedix> I know, there are exceptions [09:55:36] <grrrit-wm> (03PS1) 10Aude: (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90100 [09:56:32] <grrrit-wm> (03PS1) 10Aude: (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 [09:59:26] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 (owner: 10Aude) [09:59:31] <aude> gah [10:04:07] <GerardM> hoi sjoerddoetniks ... helmaal niks ? [10:04:24] <sjoerddoetniks> Ja was net bezig met PHP maar nu niks dus. [10:04:45] <hashar> addshore: baack :-] [10:05:07] <hashar> sjoerddoetniks: GerardM: that is dutch isn't it ? [10:05:37] <sjoerddoetniks> Yes "Sjoerddoingnothing" [10:07:23] <addshore> morning hashar :) [10:07:34] <GerardM> <grijns> als je je verveelt ... wat vragen beantwoorden ? [10:07:53] <hashar> addshore: I eventually hacked something to let us build some jobs in parallel [10:08:02] <aude> \o/ [10:08:10] <addshore> :D hacked nicely or not so nicely? :P [10:08:14] <addshore> and which jobs? :> [10:08:22] <hashar> well at least it is not using PHP [10:09:31] <hashar> basically, instead of having a bunch of shell directly in the jobs, the jobs will be made to refer to a shell script [10:09:31] <hashar> https://git.wikimedia.org/blob/integration%2Fjenkins.git/master/bin%2Fmw-install-sqlite.sh [10:09:32] <hashar> that one install sqlite [10:09:51] <hashar> and I hacked it up so the sqlite database name is based on the build number [10:09:58] <hashar> AND on the workspace name [10:10:17] <hashar> the workspace name being basically one of the parallel job [10:10:28] <hashar> sorry that is probably unclear [10:10:57] <aude> hashar: for core commits to deployment branches, like https://gerrit.wikimedia.org/r/#/c/89715/ [10:11:10] <aude> jenkins runs tests on the branch [10:11:47] <hashar> yup [10:11:49] <aude> for wikibase, i'd like any patches to our branches to pull the branches of its dependencies [10:11:57] <hashar> oh my [10:12:07] * hashar wants composer [10:12:08] <aude> is there anything special done for the core jobs, that would give me a clue? [10:12:11] <aude> ok :) [10:12:20] <hashar> for core we don't care [10:12:23] <hashar> there is no dependency [10:12:24] <aude> our composer files are setup to get the dependencies, so travis works [10:12:28] <aude> ok, right [10:12:53] <hashar> for extension, it is ALWAYS use the master branch of core [10:12:59] <aude> hmmm [10:13:06] <hashar> which is unfortunate [10:13:09] <addshore> :P [10:13:14] <hashar> I have found time yet to think about it [10:13:19] <aude> ok [10:13:26] <hashar> since we mostly care of having tests running for tip of master [10:13:32] <hashar> but we can surely hack something :-] [10:13:34] <hashar> first [10:13:48] <hashar> i want to get rid of shell lines in jobs, so people can "simply" hack the shell script [10:13:49] <aude> i can think some about it, although we at least have travis [10:14:00] <aude> so when i overrule jenkins and +2, it's with some sanity [10:15:19] <hashar> AHHHHHHHHHHhhhhh [10:15:30] <hashar> WE ARE STILL RELYING ON A TWO YEARS OLD ANT SCRIPT [10:15:33] <hashar> :-( [10:15:38] <aude> hmmmm [10:16:47] <hashar> sorry I am merely writing to myself :-( [10:16:59] <grrrit-wm> (03CR) 10Aude: [V: 031] "note that WikibaseDataModel master is incompatible with mw1.22-wmf21 Wikibase, due to https://gerrit.wikimedia.org/r/#/c/89015/" [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 (owner: 10Aude) [10:17:01] <addshore> hehe :P we enjoy reading ;p [10:17:19] * aude removes jenkins as reviewer [10:17:35] <hashar> :D [10:18:04] <aude> DanielK_WMDE: can you please review https://gerrit.wikimedia.org/r/#/c/90100 ? [10:18:07] <aude> it's tiny [10:18:34] <aude> but needs to be backported/deployed [10:18:46] <hashar> I am going to update mwext-Wikibase-repo-tests to use the shell script installer [10:18:52] <aude> hashar: ok [10:19:06] <hashar> I already tested it overnight with another job, that should be fine [10:20:48] <hashar> addshore: aude: also WMF platform is probably going to have hiphop on beta cluster and in Jenkins over the next two months or [10:21:03] <hashar> addshore: aude: so we will probably run tests using hiphop as well. That is apparently MUCH faster [10:21:03] <aude> wow, that soon? [10:32:27] <hashar> aude: for this quarter hiphop is now a project [10:32:33] <hashar> thought not high priority [10:32:54] <GerardM> hashar: did you see the warning mail about updates by Amir Aharoni ? [10:32:55] <hashar> so basically we are going to package it (Chad), probably get it on beta cluster + jenkins test non voting [10:33:16] <hashar> and next quarter the hiphop project will probably get prioritized and we will deploy it :-] [10:33:20] <hashar> GerardM: link? [10:33:37] <aude> hashar: ok. something for me to try on my test wikis [10:33:43] <GerardM> https://bugzilla.wikimedia.org/show_bug.cgi?id=55779 [10:33:51] <aude> although on beta and jenkins is good too [10:33:53] <hashar> aude: you got time :-] [10:34:07] <hashar> aude: mark bergsma is heavily interested in having hiphop on beta [10:34:19] <aude> ok :) [10:34:21] <hashar> aude: will probably use a different subdomain such as en.wikipedia.hiphop.wmflabs.org [10:34:32] * aude is installing cirrus search now [10:34:33] <hashar> but that will still point to the same architecture, only the backend app server will be different [10:34:59] <hashar> GerardM: nothing I can do on that sorry. At first, I would make that the commit referenced by Amir is actually the one causing the issue [10:35:24] <hashar> GerardM: aka look at mediawiki with the commit before that and after that to confirm that it is indeed introducing the regression [10:35:32] <GerardM> I understand you may make software live ... [10:35:38] <GerardM> that is why I asked [10:35:44] <hashar> GerardM: as for Vector / CSS / Less, it is really not my area of expertise. I probably could fix it but that would needs a bunch of hours from me :-( [10:35:55] <aude> GerardM: i assume someone is on it [10:36:08] <aude> working on it and will be resolved soon [10:36:15] <GerardM> ok cool ... I did what I could :( [10:36:17] <GerardM> :) [10:36:28] * aude is not really qualified to touch css and less :) [10:36:44] * aude would probably make it worse [10:37:39] <hashar> GerardM: will follow up with siebrand in #mediawiki-i18n [10:37:56] <aude> i think it probably gets fixed by the time wikipedias get updated with new mediawiki (tomorrow) [10:39:59] <hashar> I migrated mwext-Wikibase-repo-tests to use a shell script when install sqlite. [10:40:02] <hashar> seems to be working [10:42:12] <aude> hashar: where in gerrit does the shell script reside? [10:45:36] <hashar> aude: integration/jenkins.git [10:45:38] <hashar> still undocumented [10:45:53] <hashar> that repo is fetched by puppet on all CI slaves under /srv/slave-scripts/ [10:46:01] <hashar> (undocumented as well) [10:46:02] <aude> ok [10:57:33] <grrrit-wm> (03CR) 10Addshore: [C: 032] Add MediaWikiEscapingTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/89878 (owner: 10Jeroen De Dauw) [11:00:08] <grrrit-wm> (03CR) 10Addshore: [C: 04-1] "(3 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 (owner: 10Jeroen De Dauw) [11:49:21] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 (owner: 10Aude) [11:49:46] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90100 (owner: 10Aude) [11:50:28] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 (owner: 10Aude) [11:53:39] <grrrit-wm> (03Merged) 10jenkins-bot: (bug 55782) Fix UpdateRepoOnMoveJob autosummary [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90100 (owner: 10Aude) [11:56:39] <grrrit-wm> (03CR) 10Aude: [C: 032 V: 032] "due to incompatibility with WikibaseDataModel master, Jenkins fails on the mw1.22-wmf21 Wikibase branch." [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90101 (owner: 10Aude) [12:10:36] <hashar> aude do you think extensions usually have REL_xxx branches ? [12:10:38] <hashar> just like in master? [12:11:22] <hashar> whenever an extension patch is submitted on a branch (i.e. REL1_21), we could look at MediaWiki and find out whether it has such a branch, if so fetch that, else fallback on master [12:11:32] <aude> hashar: we name them like mw1.22-wmf21 [12:11:49] <hashar> if you are using the same convention, that would be possible [12:12:46] <aude> https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikibase.git/3df75186f1b824069da0339bf2f8661aea54e5ce/composer.json [12:12:49] <aude> for example [12:15:17] <aude> note that we don't make branches for all mediawiki core branches [12:16:12] <grrrit-wm> (03PS8) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [12:16:29] <grrrit-wm> (03PS9) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [12:16:34] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 031] "(23 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [12:17:36] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] "sry, wrong click." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [12:23:44] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 032] Add basic tests for SearchEntities... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 (owner: 10Addshore) [12:25:40] <aude> Reedy: if you are around, https://gerrit.wikimedia.org/r/#/c/90108/ [12:25:51] <aude> or hashar if you like to deploy that :) [12:27:19] <grrrit-wm> (03Merged) 10jenkins-bot: Add basic tests for SearchEntities... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89538 (owner: 10Addshore) [12:33:47] <hashar> aude: too busy with CI right now :/ Is that urgent? [12:33:52] <hashar> need a rebase as well :-] [12:42:01] <aude> hashar: not that urgent [13:17:15] <grrrit-wm> (03PS5) 10Daniel Kinzler: (bug #55511) Introducing DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 [13:17:33] <DanielK_WMDE> Danwe_WMDE: --^ [13:17:43] <grrrit-wm> (03PS9) 10Daniel Kinzler: (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 [13:17:49] <grrrit-wm> (03PS6) 10Daniel Kinzler: Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 [13:17:57] <grrrit-wm> (03PS5) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [13:42:18] <grrrit-wm> (03CR) 10Daniel Werner: [C: 032] (bug #55511) Introducing DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88771 (owner: 10Daniel Kinzler) [13:48:36] <aude> Reedy: when you have a moment https://gerrit.wikimedia.org/r/#/c/90108/ [13:49:12] <grrrit-wm> (03PS10) 10Daniel Werner: (bug #55512) QuantityValue rewrite based on DecimalValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [14:23:38] <liangent> aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=54313 seems still not deployed despite your announcement of new code deployment? [14:24:15] <addshore> hmm, it should be.. [14:24:19] <addshore> it has been merged for weeks [14:24:26] <addshore> I need to document editentity a bit! [14:29:47] <liangent> addshore: hm it's a different error from the original one [14:29:58] <liangent> the error is {\"servedby\":\"mw1136\",\"error\":{\"code\":\"failed-save\",\"info\":\"Change could not be applied to entity: Exception while applying changes: Entity does not have claim with GUID Q15075313$bef86f03-4de9-0aa4-85d2-ca7f636c63db\"}} now [14:30:14] <aude> oh, that [14:30:16] <addshore> does the entity have a claim with that guid? :P [14:30:26] <liangent> addshore: it has [14:30:32] <grrrit-wm> (03PS3) 10Daniel Werner: (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 [14:30:34] <liangent> see https://www.wikidata.org/wiki/Q15075313 [14:30:38] <grrrit-wm> (03PS2) 10Daniel Werner: optional lang fallback chain in EntityRevisionSerializer::newForFrontendStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89102 [14:30:55] <aude> it is an existingc[D laim? [14:31:00] <aude> claim [14:31:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [14:31:13] <liangent> aude: yes [14:31:22] <addshore> hmm [14:31:47] <grrrit-wm> (03PS6) 10Daniel Werner: introduces mw.ext.wikibase, wikibase.repo and wikibase.repo.fetchedEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89109 [14:31:57] <aude> possible there is a bug or it's not documented well-enough how to do this properly [14:32:04] <addshore> indeed [14:32:05] <grrrit-wm> (03PS8) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [14:32:13] <addshore> I think I might have to document expected format :P [14:32:26] <addshore> liangent: your the second person today that has had an issue with it [14:32:55] <addshore> liangent: could you stick the $data you sent to the api in a pastebin for me? [14:34:22] <addshore> liangent: potentially add it to https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#New_API_wbeditentity:_Help [14:34:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] introduces mw.ext.wikibase, wikibase.repo and wikibase.repo.fetchedEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89109 (owner: 10Daniel Werner) [14:34:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [14:42:37] <liangent> addshore: http://pastebin.com/3YcRXffH [14:57:31] <liangent> addshore: ah I guess I should remove all ids in my request? [15:07:07] <grrrit-wm> (03PS21) 10Aude: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [15:07:18] <grrrit-wm> (03CR) 10Aude: "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [15:07:37] <Lydia_WMDE> lbenedix: no need to put it on the paper cuts page - this whole thing needs a lot more work and it is on my list already [15:08:05] <Lydia_WMDE> aude: could you have a look at the newest topic on project chat please? [15:08:12] <aude> Lydia_WMDE: working on it [15:08:13] * Lydia_WMDE waves from latinoware [15:08:18] <Lydia_WMDE> aude: ah perfect :) [15:08:30] <Lydia_WMDE> you're ahead of me again it seems :P [15:08:32] <Lydia_WMDE> damn it [15:08:41] <aude> well, i didn't reply as i need to find the cause [15:08:46] <Lydia_WMDE> *nod* [15:08:53] <aude> either something missing in the branch or a new issue [15:09:39] <Lydia_WMDE> aude: for the future a "I'm looking into it" can't hurt in such cases to let people know that we're aware of the problem [15:09:44] <Lydia_WMDE> but no need now [15:09:52] <aude> let's see how long it takes [15:10:00] <Lydia_WMDE> :D [15:10:02] <Lydia_WMDE> yeah [15:10:17] <aude> it's null globe again [15:10:25] <Lydia_WMDE> and i got my talk changed \o/ so i'll be talking about wikidata on friday here at latinoware [15:10:31] <aude> oooh [15:10:39] <Lydia_WMDE> aude: null again? meh :( [15:10:58] <aude> so, a missing backport which is quick to fix [15:10:58] <aude> or a new problem [15:11:33] <Lydia_WMDE> ok [15:14:06] <grrrit-wm> (03PS2) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [15:28:42] <addshore> liangent: ids such as? [15:28:50] <addshore> not has a chance to look yet :/ [15:33:16] <addshore> mhhhm liangent there is a slight inconsistency with your request to the one that I have in the unit tests [15:33:34] <addshore> oh actually no there isnt... [15:33:37] <addshore> need to look more.. [15:47:24] <liangent> addshore: there's a &clear= [15:47:50] <addshore> where? [15:47:55] <liangent> http://pastebin.com/3YcRXffH [15:48:31] <addshore> .. [15:48:48] <addshore> well, if you clear, you wont have a claim on the entity with a guid.. [15:48:55] <addshore> you wont have anything.. :P [15:49:23] <liangent> addshore: so I said "I should remove all ids" right? [15:49:32] <addshore> ahh, guids, yes [15:50:31] <liangent> addshore: and that means I can't create claims with specified uuid? [15:50:38] <addshore> no! [15:51:22] <liangent> addshore: why can't we allow that? [15:51:27] <aude> https://www.mediawiki.org/wiki/User:Aude/Deployments#mw1.22-wmf21 [15:51:43] <addshore> liangent: why would you ever need to do that? [15:51:51] <aude> that's the one thing i omitted from project chat as i thought it was too detailed [15:52:04] <aude> "For new entities, EditEntity does not accept bot generated claim guids" [15:52:04] <liangent> addshore: because wikibase itself does so [15:52:08] <grrrit-wm> (03PS3) 10Daniel Kinzler: Introducing QuantityFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 [15:52:24] <addshore> ... wikibase accepts claim guids? O_o [15:52:43] <liangent> wait let me have a look [15:52:51] <aude> for set claim, i think they are still accepted but not for much longer [15:53:14] <grrrit-wm> (03PS7) 10Daniel Kinzler: Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 [15:53:21] <grrrit-wm> (03PS4) 10Daniel Kinzler: Introducing QuantityFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 [15:53:24] <grrrit-wm> (03PS6) 10Daniel Kinzler: Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 [15:54:37] <DanielK_WMDE_> Danwe_WMDE: care to merge https://gerrit.wikimedia.org/r/#/c/88787 ? [15:56:01] <lbenedix> Lydia_WMDE: okay [15:56:26] <liangent> addshore: to create a claim inside wikibase codebase, you need to generate a uuid yourself, instead of waiting for the saving action to provide one (this is what's done for entity id) [15:56:28] <liangent> is this right? [15:56:54] <aude> "The method showDiffPage() has an NPath complexity of 27896832. The configured NPath complexity threshold is 200. (PHPMD)" [15:57:02] * aude reminded not to run phpmd on core [15:57:37] <Harmonia_Amanda> Ash_Crow: faut pas claquer la porte, comme ça :p [15:57:53] <Ash_Crow> quelle porte ? ^^' [15:59:55] <Harmonia_Amanda> Ash_Crow: tu te co et déco ;) [15:59:58] <Harmonia_Amanda> la porte du chan [16:00:33] <liangent> addshore: so actually what I'm doing is, I have a modified or newly created item in my local WikibaseDataModel, and I want to push it to wikidata.org [16:01:03] <addshore> liangent: EntityIds and ClaimGuids are different though.. [16:01:42] <addshore> and also not so different, when creating a new entity you dont pass it an id [16:01:59] <addshore> you let the site generate one for you. The same applies / should apply for slaim guids everywhere [16:02:22] <aude> that would be logical [16:03:09] <aude> in wikibase data model, it requires a claim guid when you make a claim [16:03:19] <Ash_Crow> Harmonia_Amanda, Je suis parti il y a 3 heures pour l'atelier à Pompidou, je reviens juste [16:03:24] <aude> if you actually send it to the api, you should unset the id array key [16:03:35] <aude> and let wikidata assign one [16:03:44] <addshore> as far as I know datamodel doesnt require a guid currently..? [16:03:46] <Ash_Crow> s'il y a un ordi qui co-déco mon compte entretemps, c'est pas moi (et c'est inquiétant) [16:03:46] <Harmonia_Amanda> Ash_Crow: je parlais des dernières minutes [16:03:49] <aude> addshore: it's new [16:03:53] <aude> apparently [16:03:53] <addshore> oh... [16:04:06] <Harmonia_Amanda> Ash_Crow: tu as bien été absent ces dernières heures [16:04:19] <Ash_Crow> ok [16:04:20] <aude> it's what caused jenkins to say no to patches in the branch [16:04:22] <Harmonia_Amanda> mais tu t'y es repris à plusieurs fois pour te connecter sur ce chan :) [16:04:35] <Harmonia_Amanda> Ash_Crow: il était bien l'atelier ? [16:05:20] <aude> addshore: errr, it is realted but not exactly the same issue https://gerrit.wikimedia.org/r/#/c/89015/ [16:05:22] <Ash_Crow> Harmonia_Amanda, oui :) [16:05:23] <liangent> aude: and I miss the reference to a originally known given claim [16:05:24] <aude> related [16:05:40] <liangent> ie I can't find a specified claim back [16:05:49] <aude> liangent: you can do that [16:06:00] <aude> only omit the claim guid in editentity for new claims [16:06:10] <addshore> indeed [16:07:12] <liangent> aude: maybe that would work for editentity calls without &clear= [16:07:33] <liangent> but if I omit &clear=, it doesn't remove what I removed in my local data structure [16:07:33] <aude> liangent: not sure but maybe [16:07:41] <addshore> liangent: yes [16:07:51] <addshore> when you clear an entity you clear an entity, all of the claims are gone.. [16:08:03] * aude is sticking to setclaim for my bot (for now ) :) [16:08:21] <liangent> addshore: well is accepting specified uuid difficult? [16:08:55] <liangent> or problematic? [16:08:56] <addshore> it is easy if the guid is already in the entity but we have not allowed it for claims that do not exist delibratly [16:10:45] <DanielK_WMDE_> addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=55795 [16:11:37] <addshore> lianget which error exactly did you get again? [16:12:05] <liangent> addshore: http://pastebin.com/3YcRXffH [16:12:35] <grrrit-wm> (03PS1) 10Tpt: Removes MWException from serializer objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 [16:12:38] <addshore> Entity does not have claim with GUID, odd, thats not where I was expecting it, It isnt in ChangeOpClaim.. [16:13:13] <liangent> addshore: http://pastebin.com/uLcua84H seems to work [16:13:18] <addshore> heh, ChangeOpMainsnak... [16:13:20] <liangent> but creates an ugly diff https://www.wikidata.org/w/index.php?title=Q15075313&diff=78685452&oldid=78656729 [16:14:10] <addshore> but why are you using clear there? [16:14:28] <addshore> all you appear to be doing is adding a sitelink..? [16:15:25] <liangent> addshore: yes, but the saving function doesn't know what have been edited in meantime' [16:16:03] <addshore> what saving function..? [16:16:38] <liangent> my own saving function [16:16:41] <liangent> hooked to PageContentSave [16:16:48] <liangent> and send the content to wikidata api [16:17:26] <DanielK_WMDE_> liangent: provide a base revision id, then you don't need to know what has been edited in the meantime [16:17:32] <DanielK_WMDE_> the api will resolve the conflict be auto-merging [16:17:37] <DanielK_WMDE_> (or reporting a conflict) [16:17:53] <liangent> DanielK_WMDE_: not for conflict [16:18:01] <liangent> 'the saving function doesn't know what have been edited in meantime' means it has to use wbeditentity [16:18:13] <liangent> instead of a more direct wbsetsitelink etc [16:18:21] <DanielK_WMDE_> why? [16:18:48] <addshore> as far as I can tell thats no issue with wikibase but and issue with the way your using the api [16:19:13] <addshore> and thats probably very dangerous to call clear when you dont actually want to clear.. [16:20:59] <liangent> addshore: because there's no api doing exactly what I want to do [16:21:22] <liangent> ie remove all stuff that's not mentioned in wbeditentity call [16:21:41] <addshore> but when would you want to do this? [16:22:05] <addshore> Im struggling to see what your aiming for [16:24:01] <liangent> addshore: my workflow: fetch original item, edit the item in all means, finally save my edited item [16:24:53] <addshore> so why do you need clear? have you tried pushing it back simply without the clear param? [16:25:36] <liangent> addshore: if I removed some claims in the second step, wbeditentity without &clear doesn't do it for me on the site [16:25:51] <addshore> ahhhh!! you want to remove claims :P [16:26:07] <liangent> or sitelinks [16:26:10] * addshore points at '{"claims":[{"id":"GUID","remove":""}]}' [16:26:21] <addshore> for sitelinks you should just be able to set their value to '' [16:26:23] <addshore> or null [16:26:37] <addshore> the same for labels, descriptions and aliases [16:27:08] <liangent> addshore: and I have to log my changes somehow, or diff them to get the removal myself [16:28:40] <addshore> why?, simply make remove add the remove flag [16:30:07] <liangent> addshore: what does 'simply make remove add the remove flag' mean? [16:30:15] <addshore> '{"claims":[{"id":"GUID","remove":""}]}' [16:30:36] <liangent> well all my {"claims":[{"id":"GUID","remove":""}]} structures come from the standard wikibase serializer [16:31:02] <addshore> which serializer exactly? [16:33:30] <liangent> addshore: well the saving function I mentioned: http://pastebin.com/15jQktfa [16:36:58] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [16:37:01] <liangent> addshore: and https://www.wikidata.org/w/index.php?title=Q4115189&diff=78692622&oldid=78397159 [16:38:04] <grrrit-wm> (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [16:44:46] <addshore> hmm liangent after looking through the serializers it ywould appear you will have to add the remove flag to the claims after the serilization has been created [16:46:57] <liangent> addshore: and wikibaseEntityContentSave has to know what were removed, and it doesn't know currently [16:49:52] <addshore> so make it know? :P [16:50:49] <DanielK_WMDE_> for the record: the reals solution would be to a) build a diff between old and new version b) build a serialization suitable for wbeditentity from that diff [16:55:16] <liangent> and it need to go as deep as qualifiers / references etc [17:06:32] <aude> addshore: DanielK_WMDE_ want to help debug? [17:06:35] <aude> https://www.wikidata.org/wiki/Q325180 [17:06:46] <aude> i am having trouble reproducing this on the branch [17:06:56] <aude> and apparently this exception does not appear in exception logs [17:07:15] <aude> this item has null globe [17:07:27] <aude> a claim guid with lower case q325180 [17:07:39] <aude> https://www.wikidata.org/wiki/Special:Export/Q325180 [17:07:54] <aude> and other null globe items do same [17:12:10] <addshore> http://pastebin.com/ZCDRqdA3 [17:20:28] <grrrit-wm> (03PS1) 10Aude: Register undeserializable value formatter [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90158 [17:21:02] <grrrit-wm> (03PS1) 10Aude: Register undeserializable value formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90159 [17:21:15] * aude waits for jenkins [17:21:51] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Register undeserializable value formatter [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90158 (owner: 10Aude) [17:22:01] <aude> obviously [17:23:54] <aude> addshore: DanielK_WMDE_ unrelated i get a different issue when importing the item [17:23:57] <aude> http://dpaste.com/1419110/ [17:24:03] <aude> but it does import [17:24:35] <aude> oh, that is plurals [17:25:35] <aude> probably an issue with my setup [17:26:12] <aude> addshore: anyway, jenkins approves https://gerrit.wikimedia.org/r/#/c/90159/ [17:30:18] <grrrit-wm> (03CR) 10Addshore: [C: 032] Register undeserializable value formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90159 (owner: 10Aude) [17:30:21] <addshore> aude bing ^^ [17:30:25] <aude> yay! [17:33:01] <addshore> now for a backport :D [17:33:06] <grrrit-wm> (03CR) 10Aude: [C: 032 V: 032] Register undeserializable value formatter [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/90158 (owner: 10Aude) [17:33:07] <aude> got it [17:34:52] <grrrit-wm> (03PS22) 10Aude: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [17:38:08] <aude> Reedy: https://gerrit.wikimedia.org/r/#/c/90108/ ready for deploy [17:43:11] <grrrit-wm> (03CR) 10Aude: [C: 04-2] "more follow-up work is needed on the serializers before we move forward with this patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [17:54:55] <notconfusing> which dump to use? if i just want a latest rev of each item in the main namespace? http://dumps.wikimedia.org/wikidatawiki/latest/wikidatawiki-latest-pages-articles.xml.bz2 ? [18:22:54] <DanielK_WMDE_> notconfusing: yes. [18:48:12] <grrrit-wm> (03PS2) 10Daniel Kinzler: Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 [19:18:09] <grrrit-wm> (03CR) 10Siebrand: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [19:47:36] <grrrit-wm> (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 (owner: 10Tpt) [19:49:06] <grrrit-wm> (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 (owner: 10Jeroen De Dauw) [19:53:07] <grrrit-wm> (03PS2) 10Jeroen De Dauw: Fix conceptual issue with the TableNameFormatter interface [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 [20:24:16] <grrrit-wm> (03PS3) 10Jeroen De Dauw: Fix conceptual issue with the TableNameFormatter interface [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 [20:24:20] <grrrit-wm> (03PS2) 10Jeroen De Dauw: Update TravisCI config so it uses a db prefix on MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 [20:46:06] <JeroenDeDauw> addshore: MEERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/90003/ [20:46:20] <JeroenDeDauw> addshore: or I'll fly back to Berlin to throw things at you [21:20:09] <Lydia_WMDE> multichill: you had this image of a huge family tree based on wikidata date [21:20:10] <Lydia_WMDE> *data [21:20:22] <Lydia_WMDE> i can't seem to find it but could use it for a talk [21:20:31] <Lydia_WMDE> can you give me a link please? [21:20:36] <multichill> Yes, Charlemagne [21:20:52] <Lydia_WMDE> geneawiki is borked so i can't demo it live unfortunately [21:20:56] <Lydia_WMDE> so this will have to do [21:21:19] <multichill> https://commons.wikimedia.org/wiki/File:Elizabeth_II_to_Charlemagne_ancestry.svg [21:21:33] <Lydia_WMDE> multichill: thanks! you're the best [21:21:41] <multichill> https://commons.wikimedia.org/wiki/File:Beatrix_of_the_Netherlands_to_Charlemagne_ancestry.svg [21:22:08] <multichill> You're welcome! [21:42:25] <grrrit-wm> (03CR) 10Daniel Kinzler: [C: 04-1] "missing tests for new functions" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler)