[01:02:30] aude: i never looked to see if there was followup discussion but i did highlight you at the time. saw my proposal? re debian watch files [01:02:52] jeremyb: don't think i saw it [01:03:10] i would link to it if the bot were working! :P [01:03:51] aude: do you have logs? [01:04:09] sure i do [01:04:54] too late, i have it ready for pastebin :P [01:05:05] easier [01:06:13] aude: http://dpaste.com/1419513/plain/ [01:06:21] no particular rush [01:07:37] interesting [01:08:57] aude: also, what's the high-level, current state of maps/gis? [01:09:11] i could bounce you a couple relevant tickets [01:09:44] probably can't handle them in a timely manner [01:09:58] no, not for you to answer. just fyi [01:10:08] they initiated and i think they had a call with mroth. pharos responded [01:10:14] we may have a meeting with them [01:10:14] ok [01:10:53] aude: anyway, 17 01:08:57 < jeremyb> aude: also, what's the high-level, current state of maps/gis? [01:13:09] basically: they want to provide locator maps and maybe other maps for some areas [01:13:46] but... i'm thinking we should get the raw data from them too and then the question is do we just handle it in labs somehow and wikis only get bitmaps [01:13:46] ok [01:14:02] *or* can we upload shapes, etc. to a wiki? [01:14:46] depends what kind of data and probably not yet [01:14:50] labs for now [01:15:02] there is also talk and effor for wikimaps [01:15:13] is there a page for that? [01:15:28] https://commons.wikimedia.org/wiki/Commons:Wikimaps [01:15:43] there might be more to that [01:16:57] *click* [02:28:54] aude: i wonder if flow/ee people have an opinion about that notification thing. [02:29:02] * jeremyb goes to poke them [02:30:59] (in #wikimedia-corefeatures) [08:24:41] (03CR) 10Tobias Gritschacher: "@Siebrand: QUnit is currently not working properly on Jenkins for Wikibase. This is unrelated to this change. It's also the reason why it " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [09:02:00] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 (owner: 10Jeroen De Dauw) [09:17:26] (03CR) 10Daniel Werner: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [09:22:58] (03CR) 10Siebrand: "Thanks for explaining, Tobias." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [09:31:02] (03CR) 10Daniel Werner: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [09:39:46] (03CR) 10Daniel Werner: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [09:42:16] (03CR) 10Daniel Werner: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89510 (owner: 10Bene) [09:45:06] (03CR) 10Siebrand: "Best check how shortcut key indicators in core are being created. I don't know by heart... EditPage.php probably contains something about " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [09:46:34] (03CR) 10Daniel Werner: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89874 (owner: 10Bene) [09:46:44] (03CR) 10Siebrand: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [09:59:19] (03PS3) 10Addshore: (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [09:59:42] (03CR) 10Addshore: "PS3 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [10:00:48] DanielK_WMDE_: any objection to using markdown for the docs? :> [10:02:08] (03CR) 10Daniel Werner: [C: 04-1] "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 (owner: 10Bene) [10:13:54] (03PS7) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [10:14:23] (03PS10) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [10:27:27] (03CR) 10Daniel Werner: [C: 04-1] "(4 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 (owner: 10Daniel Kinzler) [10:34:29] (03PS4) 10Addshore: (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [10:35:23] aude: ^^ would be great if you could do a final review of that doc and then merge it :) [10:36:25] (03CR) 10Daniel Werner: [C: 032] "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/88787 (owner: 10Daniel Kinzler) [10:39:24] (03CR) 10Daniel Werner: [C: 031] Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [11:01:56] (03PS3) 10Daniel Kinzler: Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 [11:04:45] (03CR) 10jenkins-bot: [V: 04-1] Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler) [11:10:06] woah, strang [11:10:07] e [11:10:33] DanielK_WMDE_: i just made a "null" edit on coordinates. put an extra space before the "W" but otherwise changed nothing [11:10:36] https://www.wikidata.org/w/index.php?title=Q12859331&diff=78973268&oldid=77703550 [11:10:52] and it changed the coordinate float value slightly [11:11:08] i suppose the js is reparsing it [11:12:03] DanielK_WMDE_: here https://www.wikidata.org/w/index.php?title=Q12859331&diff=78973879&oldid=78973268 [11:12:26] is it possible that the claims have the same hash or i think they get new hash the intermediate edit? [11:25:44] (03PS1) 10Henning Snater: entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 [11:36:16] (03PS1) 10Henning Snater: Implemented numeric index in Claims [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 [12:00:55] http://ultimategerardm.blogspot.nl/2013/10/viaf-sources-and-battle-of-sexes.html the idea is to have sources known in Wikipedia articles in Wikidata as well [12:09:04] (03PS1) 10Zfilipin: Updated Ruby gems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90321 [12:10:22] and a post in French http://zone47.com/dozo/voyage-de-dbpedia-en-wikidata-a-bord-dun-bot [12:13:13] pyb, I would love a "translate" button on this blog [12:14:37] GerardM: I transfer your comment [12:15:04] I do have a translate button on mine [12:49:47] addshore: https://www.wikidata.org/w/index.php?title=Q25227&diff=79001652&oldid=78411618 [12:53:10] hm, is this the correct way to request the deletion of a dupe? https://www.wikidata.org/wiki/Talk:Q13196973 [12:53:49] that or using WD:RFD :P [12:54:09] well, there's nothing to discuss, i think [12:54:27] it went poof :) [13:09:49] hashar: around? :P [13:10:01] addshore: no, busy :/ [13:10:05] unless something is terribly broken [13:10:18] nope, will ping you tommorw ;p [13:12:37] hi [13:13:16] i think at least the en and fr version represent something else then the rest: https://www.wikidata.org/wiki/Q270389 [13:13:22] what to do in this case? [13:13:38] (03PS2) 10Henning Snater: entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 [13:20:10] legoktm, ping [13:23:15] (03PS1) 10Addshore: Make the wbgetentities examples look nicer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90331 [13:29:44] (03CR) 10Addshore: [C: 032] "will fix in a followup.." [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90003 (owner: 10Jeroen De Dauw) [13:30:27] (03PS1) 10Addshore: Remove ugly tab character [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90334 [13:30:51] aude: Tobi_WMDE DanielK_WMDE_ ^^ really realluy free choclate [13:31:03] (03CR) 10Aude: [C: 032] Remove ugly tab character [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90334 (owner: 10Addshore) [13:31:08] * aude demands chocolate! [13:31:10] (03Merged) 10jenkins-bot: Remove ugly tab character [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90334 (owner: 10Addshore) [13:32:17] (03Draft1) 10Aude: Cleanup namespaces and code style issues in content classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 [13:32:57] (03PS1) 10Addshore: Alter travis db prefix [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90335 [13:34:57] Aude .. this one is for you ... https://www.wikidata.org/wiki/Q195 [13:35:32] (03CR) 10Addshore: [C: 032] Alter travis db prefix [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90335 (owner: 10Addshore) [13:36:53] GerardM: :) [13:37:10] aude: DanielK_WMDE_: do you need me for the call tonight? because in general I'm not planning to stay here until 6. [13:37:27] Tobi_WMDE: probably not but would be nice to have you there [13:38:29] Tobi_WMDE, aude: i don't know what to talk about anyway [13:39:00] there's just the one point I've send in the email till now [13:39:00] * aude neither [13:39:16] we could talk about how to integrate the commons usability team in the future [13:39:20] but that does not necessarily need a call [13:39:31] true [13:40:21] oh, we should tell them that phase 3 is now slowly approaching something deployable. [13:40:38] i estimate that we'll need the database work for that done in about a month [13:41:06] that's stuff i really don't know about myself [13:41:38] where the database would be? etc. how it would work in production? [13:41:52] schema changes involved and how they work? [13:43:28] aude: DanielK_WMDE_: would be nice to have JeroenDeDauw in when talking about that [13:43:57] yeah and would be nice for the team to be updated about this stuff :) [13:43:59] aude: new tables being added to the wikibasewiki db [13:44:01] that's about it [13:44:13] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#135 (master - a568fe2 : addshore): The build was canceled. [13:44:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/6e2448dcfa49...a568fe23fccf [13:44:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12668902 [13:44:20] then, scripts run for populating these. that's going to be slow, but not complicated [13:44:27] (03PS3) 10Addshore: Update TravisCI config so it uses a db prefix on MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [13:44:31] which ones, how many? how often do the tables change? [13:44:32] (03CR) 10jenkins-bot: [V: 04-1] Update TravisCI config so it uses a db prefix on MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [13:44:44] Tobi_WMDE: for the details yes, but i'd like to give a quick heads up [13:44:56] just because robla keeps asking about it [13:45:12] would be good to chat about commons [13:45:35] (03PS4) 10Addshore: Update TravisCI config so it uses a db prefix on MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [13:45:35] DanielK_WMDE_: yes, then let's mention it but not going too much into details [13:45:40] (03CR) 10jenkins-bot: [V: 04-1] Update TravisCI config to use a db prefix for MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [13:45:41] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#136 (master - 07b0251 : addshore): The build has errored. [13:45:41] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/a568fe23fccf...07b02513845e [13:45:41] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12669092 [13:45:44] argghh [13:45:46] sorry broke jenkins [13:45:50] :D [13:45:54] :) [13:45:54] okay :> [13:46:11] (03CR) 10Addshore: [C: 032 V: 032] Update TravisCI config to use a db prefix for MySQL [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90015 (owner: 10Jeroen De Dauw) [13:46:23] * addshore ignores jenkins :P [13:48:58] (03PS3) 10Henning Snater: entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 [13:50:20] jenkins should be fine againnow [13:50:28] :d [13:50:29] :D [13:51:09] addshore: I am looking at enabling debug log [13:51:19] and publishing them compressed in the build report [13:51:33] that would be rather nice :> [13:51:46] so I am very bad at communicating [13:51:51] but he [13:51:51] https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/ [13:51:53] look there :-] [13:52:01] the last build archive some log files [13:52:11] mw-debug-cli.log.gz is $wgDebugLogFile output \O/ [13:52:13] Last Successful Artifacts :O [13:52:20] nice :) [13:52:21] had to make sure they are compressed [13:52:26] on master that is a 5MB file [13:52:35] down to 86KB [13:52:44] (03Draft1) 10Addshore: If we use a prefix also install with a prefix.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90338 [13:53:18] I eventually got fed up of you having to attempt to figure out weird build failure [13:53:36] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#137 (master - bbae7a2 : jeroendedauw): The build has errored. [13:53:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/07b02513845e...bbae7a23116f [13:53:36] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12669556 [13:55:00] silly travis :> [14:02:49] (03CR) 10Tobias Gritschacher: [C: 032] entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 (owner: 10Henning Snater) [14:02:53] (03CR) 10jenkins-bot: [V: 04-1] entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 (owner: 10Henning Snater) [14:03:09] (03Draft1) 10Addshore: Still only use the prefix if we are on mysql.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90345 [14:03:21] (03Merged) 10jenkins-bot: Still only use the prefix if we are on mysql.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90345 (owner: 10Addshore) [14:06:51] Tobi_WMDE: poke? [14:06:52] (03PS4) 10Tobias Gritschacher: entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 (owner: 10Henning Snater) [14:07:05] Lydia_WMDE: hey [14:07:39] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:09:12] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#139 (master - 6e2c9b6 : addshore): The build has errored. [14:09:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/e677cf93283d...6e2c9b6662e9 [14:09:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12670224 [14:09:16] wsghbnjmas [14:09:46] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:10:17] addshore: time to change password? [14:10:40] no :P just annoyed at travis :P [14:10:47] oh, ok :) [14:11:58] (03PS2) 10Aude: Cleanup namespaces and code style issues in content classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 [14:12:05] (03CR) 10jenkins-bot: [V: 04-1] Cleanup namespaces and code style issues in content classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:12:10] wtf [14:12:17] too quick [14:12:27] ok, rebase [14:13:19] hashar: is jenkins still broken? [14:13:23] na [14:13:32] I should have fixed it [14:13:37] (03CR) 10Tobias Gritschacher: [C: 032] entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 (owner: 10Henning Snater) [14:13:48] some gzip command was failing due to non existing target, i have simply ignored that error [14:13:49] || : [14:13:51] hack! [14:15:11] so my patch is based on the last merged change in wikibase [14:15:50] (03CR) 10Aude: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:16:24] aude: if you want tests to run, you have to create a new patchset :( [14:16:25] (03Draft1) 10Addshore: Only install using prefix on mysql.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90346 [14:16:29] i see [14:16:32] (03Merged) 10jenkins-bot: Only install using prefix on mysql.. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90346 (owner: 10Addshore) [14:16:36] usually I edit the commit summary and add a new line above the Change-Id: line [14:16:42] (03PS3) 10Aude: Cleanup namespaces and code style issues in content classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 [14:16:42] gerrit strip it iirc [14:16:43] doing [14:17:03] * addshore hops travis works this time... [14:17:14] now it says it can merge [14:17:23] (03Merged) 10jenkins-bot: entityselector: Properly set value when selecting a suggestion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90313 (owner: 10Henning Snater) [14:17:56] (03CR) 10Addshore: [C: 032] Cleanup namespaces and code style issues in content classes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:18:11] hashar: also lovely that one can edit the topic in gerrit [14:18:30] yeah that is very handy [14:18:35] * addshore never bothers with the topic :O [14:18:39] :) [14:18:45] I dont either [14:18:56] they might be useful to group changes together [14:19:10] sure [14:19:12] another nice trick is that you can use the same Change-Id if the git repo + branch is different [14:19:22] I often do that when sending changes for jenkins and zuul [14:19:28] cool [14:19:54] that is rather cool :P [14:21:32] so [14:21:43] no I got to break^Wupdate all extension jobs [14:22:08] (03CR) 10Tobias Gritschacher: [C: 032] $.ui.suggester: Implemented autocompletestring for static result set [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89160 (owner: 10Henning Snater) [14:22:17] (03Merged) 10jenkins-bot: Cleanup namespaces and code style issues in content classes. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90272 (owner: 10Aude) [14:22:27] (03Merged) 10jenkins-bot: $.ui.suggester: Implemented autocompletestring for static result set [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89160 (owner: 10Henning Snater) [14:24:57] hashar: shame i can have no logs for https://integration.wikimedia.org/ci/job/mwext-WikibaseQueryEngine-testextensions-master/156/ :P [14:25:06] addshore: working on it right now [14:26:32] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDatabase#140 (master - 05717b4 : addshore): The build passed. [14:26:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDatabase/compare/6e2c9b6662e9...05717b4aa7a2 [14:26:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDatabase/builds/12670850 [14:28:03] (03PS1) 10Aude: add test case for UnDeserializableValue in snak formatter builders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90348 [14:30:14] grrr.... so many tests that assume $wgLang = 'en' [14:32:07] (03PS1) 10Aude: set $wgLang in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 [14:32:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1045 (master - de8f696 : Henning Snater): The build has errored. [14:32:10] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/d3c042e27036...de8f696eb3ad [14:32:10] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12670903 [14:33:44] (03PS2) 10Aude: set $wgLang in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 [14:34:36] (03PS4) 10Henning Snater: Factored getscrollbarwidth utility function out of suggester widget [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89172 [14:36:13] (03CR) 10Addshore: [C: 032] add test case for UnDeserializableValue in snak formatter builders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90348 (owner: 10Aude) [14:36:21] addshore: hold off on my other patch [14:36:36] I will :P [14:36:39] (03CR) 10Aude: [C: 04-1] "i'd like to investigate the test failures first" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [14:38:27] (03PS3) 10Aude: set $wgLanguageCode in travis to something non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 [14:38:41] (03PS2) 10Addshore: Bug 55466 - Better "start page" for ItemDisambiguation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89510 (owner: 10Bene) [14:39:03] (03CR) 10Aude: [C: 04-1] "would like to investigate test failures before merging this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [14:39:55] (03CR) 10Addshore: [C: 032] Bug 55466 - Better "start page" for ItemDisambiguation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89510 (owner: 10Bene) [14:40:03] (03PS3) 10Tobias Gritschacher: $.ui.suggester: Suppress autocomplete's native blur handling [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89178 (owner: 10Henning Snater) [14:41:35] (03Merged) 10jenkins-bot: add test case for UnDeserializableValue in snak formatter builders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90348 (owner: 10Aude) [14:44:12] (03CR) 10Tobias Gritschacher: [C: 032] Factored getscrollbarwidth utility function out of suggester widget [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89172 (owner: 10Henning Snater) [14:44:27] (03CR) 10Tobias Gritschacher: [C: 032] $.ui.suggester: Suppress autocomplete's native blur handling [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89178 (owner: 10Henning Snater) [14:44:30] (03Merged) 10jenkins-bot: Factored getscrollbarwidth utility function out of suggester widget [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89172 (owner: 10Henning Snater) [14:44:42] (03Merged) 10jenkins-bot: $.ui.suggester: Suppress autocomplete's native blur handling [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89178 (owner: 10Henning Snater) [14:44:44] when does lego here? [14:45:09] oh, look! [14:45:15] our development process summarized: http://asset-5.soup.io/asset/5837/4984_596a.gif [14:46:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1046 (master - a952394 : jenkins-bot): The build has errored. [14:46:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/de8f696eb3ad...a952394e2577 [14:46:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12671123 [14:48:52] (03Merged) 10jenkins-bot: Bug 55466 - Better "start page" for ItemDisambiguation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89510 (owner: 10Bene) [14:49:25] addshore: DanielK_WMDE_ : aude: need a permission check in jenkins. On https://integration.wikimedia.org/ci/job/mwext-DataValues-testextensions-master/1404/ do you happen to see on the left the link [Rebuild] ? [14:50:01] nope :. [14:50:07] /me logs in [14:50:11] * aude  [14:50:18] addshore: even logged in ? [14:50:35] hashar: don't see it [14:50:40] :( [14:50:43] http://grab.by/rf14 [14:50:49] excellent [14:50:54] thanks [14:51:01] I really need a LDAP group for wmde :-] [14:51:14] xD [14:51:32] hashar: can you email me with the RT number for that? [14:51:42] i could poke people in the office next week [14:51:48] yhaha! [14:51:56] or just tell me here [14:52:27] (03CR) 10Tobias Gritschacher: [C: 032] Make the wbgetentities examples look nicer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90331 (owner: 10Addshore) [14:52:42] aude: https://rt.wikimedia.org/Ticket/Display.html?id=5023 [14:52:45] thanks [14:52:55] I might be able to cc you on it [14:53:00] daniel tobias and jeroen are in cc [14:53:03] we don't have rt access [14:53:10] :P [14:53:14] yet another thing to ask about [14:53:22] so much fun :) [14:54:03] aude: no clue what is your mail / name under RT :/ [14:54:26] * aude probably not there [14:54:50] found it [14:54:56] ok [14:55:47] (03Merged) 10jenkins-bot: Make the wbgetentities examples look nicer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90331 (owner: 10Addshore) [14:56:07] aude any idea if this still happens? https://bugzilla.wikimedia.org/show_bug.cgi?id=53142 [14:56:51] addshore: click the link [14:56:56] yes it happens still [14:57:02] the diffs are cached though :/ [14:57:09] errr, let me try again [14:57:12] :> [14:57:37] I toched a lot of code around that sort of areas in the past weeks, wonder if I accidently fixed it [14:59:07] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1047 (master - a0a3f3d : jenkins-bot): The build passed. [14:59:07] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a952394e2577...a0a3f3df3e68 [14:59:07] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12672285 [15:01:01] (03CR) 10Daniel Werner: [V: 031] Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [15:02:47] addshore: https://www.wikidata.org/w/index.php?title=Q430876&diff=79042910&oldid=74920096 [15:02:59] * aude sees no ref in the diff [15:03:06] :< [15:03:08] okay :> [15:04:09] Fur great justice! [15:04:22] JeroenDeDauw! :O [15:04:29] happy vacation! [15:05:42] DanielK_WMDE_: i am getting a pile of test failures for json dumps [15:05:43] http://dpaste.com/1420195/ [15:05:58] any clue why? [15:06:43] could be that it's using the database? [15:06:52] and i already have a Q18 there [15:07:04] aude: yes, it's using the database. [15:07:14] so it fails [15:07:30] make it use bigger Ids :d Q92837465637829345 [15:07:32] aude: i think it should clear the entityperpage table first, to avoid processign leaked entities [15:07:36] perhaps check for that [15:07:45] uh, i don't want it to clear my tables [15:07:53] i want it to use a test table [15:07:58] it does [15:08:07] or if it doesn't, that would be a huge bug [15:08:30] ideally, it wouldn't use the database at all. and i tried to decouple at least most of it from the db [15:08:36] but i have to test the sql in there somewhow [15:08:45] aude if you use create claim does it also show refs in the diff? [15:08:49] or maybe some test is setting items with the same id as in my database [15:09:06] addshore: i never put references in create claim [15:09:07] aude: yes, that's what i think is happening [15:09:52] aude: if that is the case, the test wiouldn't fail when run by itself [15:09:56] hey! [15:10:15] DanielK_WMDE_: i ran jsondumpgeneratortest by itself [15:10:22] still fails [15:10:45] * aude looks at the code [15:11:56] o_O [15:11:59] strange [15:12:11] this is deployed and being run by jenkins all the time, no? [15:12:27] jenkins uses a clean install [15:13:18] passes on my unclean install [15:14:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1048 (master - a2007ac : jenkins-bot): The build passed. [15:14:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a0a3f3df3e68...a2007acac74d [15:14:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12672644 [15:15:05] also fails on my client [15:19:01] (03PS2) 10Cmcmahon: Updated Ruby gems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90321 (owner: 10Zfilipin) [15:23:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1049 (master - c9b6b8e : jenkins-bot): The build passed. [15:23:40] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a2007acac74d...c9b6b8e1df23 [15:23:40] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12673052 [15:24:29] (03PS2) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 [15:24:30] (03PS4) 10Daniel Kinzler: Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 [15:24:37] (03CR) 10jenkins-bot: [V: 04-1] Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [15:27:08] addshore: the Wikibase qunit jobs now has artifacts archiving and debug log :-] https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/108/ [15:27:16] (03PS3) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 [15:27:17] (03PS5) 10Daniel Kinzler: Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 [15:27:22] :D [15:32:22] addshore: and added wgDebugLogFile + archiving to the qunit jobs. https://integration.wikimedia.org/ci/job/mwext-GuidedTour-qunit/103/ [15:32:28] addshore: will do the extensions as well :-] [15:32:44] :DDD [15:53:41] (03PS2) 10Henning Snater: Split inherit tests into different files [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89734 (owner: 10Daniel Werner) [15:56:08] peeps at plwiki have a reasonable feature request [15:56:38] to be able to show somehow links to other language versions for articles that _dont_ exist on the client [15:56:51] but it seem tough to achieve [15:57:02] Lydia_WMDE: ^ [15:58:08] lazowik: i'm not sure i understand what is wanted [15:58:15] can you give an example? [15:58:35] Lydia_WMDE: you have a red link in article [15:58:39] yes [15:58:55] you want it to point to articles in other language versions [15:59:08] either next to it or on a separate page [15:59:27] RED LINK support .... awesome [15:59:28] ah [15:59:38] there are a lot of issues with that [15:59:47] why not go whole hog and link to a wikidata item [15:59:56] (never mind if there is an article) [16:00:00] :D [16:00:40] i have it on my radar but it needs a lot of thought [16:00:43] the best thing I came up with is a separate "class" of "dummy" articles on clients [16:00:47] and is not currently high priority [16:00:54] that only point to wd items [16:01:03] and are not actually articles in db [16:01:24] and then one special page which gets title as an argument [16:01:31] Lydia_WMDE: ok [16:01:31] (03CR) 10Henning Snater: [C: 032] Split inherit tests into different files [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89734 (owner: 10Daniel Werner) [16:01:37] (03PS3) 10Henning Snater: Reorganize and add tests for inherit's naming features + skip some tests in IE8 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89746 (owner: 10Daniel Werner) [16:01:43] Lydia_WMDE: did you read http://ultimategerardm.blogspot.nl/2013/10/viaf-sources-and-battle-of-sexes.html ?? [16:01:50] another thing that IMHO makes sense to have [16:01:59] GerardM: didn't get to it yet - currently at a conference in brazil [16:03:00] lazowik what do you think of what I propose in that post ? [16:03:18] lemme read ;) [16:03:41] whoa, new design! [16:04:19] so you did not read the interview with Lydia like the other 1250+ ? [16:04:59] http://ultimategerardm.blogspot.nl/2013/10/10-wikidata-questions-for-lydia.html [16:06:11] GerardM: hey! I've _seen_ that, but with prevois design [16:06:32] *previous [16:06:56] good for you :) [16:07:17] I may ask Denny some questions in a month or so [16:07:29] Hope he is interesting in answering :) [16:07:36] GerardM: that'd be very interesting [16:07:57] a view from some prespective by someone most involved [16:09:35] (03PS4) 10Henning Snater: Reorganize and add tests for inherit's naming features + skip some tests in IE8 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89746 (owner: 10Daniel Werner) [16:10:55] (03CR) 10Henning Snater: [C: 032] Reorganize and add tests for inherit's naming features + skip some tests in IE8 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89746 (owner: 10Daniel Werner) [16:16:53] Base: hi [16:18:02] legoktm: hi [16:18:09] let me recall what i wanted) [16:18:28] :) [16:18:38] legoktm: https://www.wikidata.org/wiki/Wikidata:Database_reports/Missing_links/ukwiki [16:18:54] yeah, i think that report is broken. [16:19:00] could you teach bot to decorate is as per diff [16:19:10] this report is old [16:19:26] okay [16:19:29] it has more ns14 and ns10 than ns0 but perhaps it's ok [16:19:41] i'll look into getting it running again, but i'm behind on a lot of things so it's low priority right now [16:19:48] and you should add a category to all reports [16:40:28] morning legoktm :) [16:40:44] morning [16:42:34] :) [17:11:54] (03PS9) 10Daniel Kinzler: (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 [17:17:21] (03CR) 10Daniel Werner: [C: 032] (bug #55513) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [17:17:35] (03CR) 10Daniel Kinzler: [C: 032] (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [17:18:06] (03CR) 10Daniel Werner: [C: 032] Introducing DecimalMath [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89717 (owner: 10Daniel Kinzler) [17:18:19] (03CR) 10Daniel Werner: [C: 032] Introducing QuantityValue::transform [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89777 (owner: 10Daniel Kinzler) [17:20:33] it's dennyvrandecic :) [17:20:44] heya :) [17:21:08] :D [17:21:15] hi dennyvrandecic :> [17:21:27] hi all, great to see you again [17:21:38] our new admin :) [17:21:48] congrats! [17:21:52] hey hey hey :D [17:21:55] i wasn't too active yet there [17:22:07] still acclimatizing [17:22:16] did you get my email dennyvrandecic ? :) [17:22:29] its a dennyvrandecic [17:22:47] a wild dennyvrandecic appeard! [17:22:56] addshore: no, i don't think i got your email [17:23:17] <^d> addshore: You got away safely ;-) [17:23:21] woot? wild? [17:23:34] dennyvrandecic: tools.wmflabs.org/wikidata-analysis/map/map.html [17:23:47] ahh, that email — yes i saw that one [17:23:51] it is amazing [17:23:54] <^d> dennyvrandecic: Pokémon reference :) [17:23:59] <^d> http://knowyourmeme.com/memes/a-wild-x-appears-wild-x-appeared [17:24:07] hehe [17:24:17] addshore: does the rest of the analysis scripts also work? [17:24:58] hehe, i havnt actually checked today :) i just saw the map appeared [17:24:59] addshore: that link froze my browser >.> [17:25:05] i presume yes but will check in the morning [17:25:09] ^d is demon? [17:25:21] <^d> Yeah I shortened my nick :) [17:25:28] tabcomplete is hard [17:26:10] Reedy: dont mock people saving the internets from getting all cloged up with not needed bits [17:26:16] ^d yeah, that link should freeze most browsers [17:26:23] (03Merged) 10jenkins-bot: (bug 54216) Implement entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [17:39:26] (03PS5) 10Aude: (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:39:38] (03CR) 10Aude: "patchset 5 is rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:40:02] (03CR) 10Aude: [C: 032] (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:43:28] (03PS2) 10Aude: Removes MWException from serializer objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 (owner: 10Tpt) [17:44:13] (03CR) 10Aude: "patchset 2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 (owner: 10Tpt) [17:44:26] (03CR) 10Aude: [C: 032] Removes MWException from serializer objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 (owner: 10Tpt) [17:48:04] (03Merged) 10jenkins-bot: (bug 52801) Documenting external JSON format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [17:53:24] (03Merged) 10jenkins-bot: Removes MWException from serializer objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90145 (owner: 10Tpt) [18:06:14] (03CR) 10Jeroen De Dauw: [C: 04-2] "If this breaks the build, then it should not go in without the issue being fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90350 (owner: 10Aude) [19:02:34] 26 Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:03:29] :( [19:03:40] how often is this happening? [19:04:10] that's 26 lines out of the last 1000 in the apache syslog [19:04:23] so quite a bit :p [19:07:07] ouch :P does it have timestamps? :P [19:09:58] 24/1000 [19:10:00] *34 [19:10:14] Oct 17 19:05:18 10.64.16.109 apache2[24199]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:15] Oct 17 19:05:18 10.64.16.109 apache2[24199]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:15] Oct 17 19:05:40 10.64.32.65 apache2[11231]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:15] Oct 17 19:05:41 10.64.32.65 apache2[11231]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:15] Oct 17 19:05:16 10.64.0.206 apache2[19090]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:16] Oct 17 19:08:46 10.64.16.99 apache2[19172]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:10:18] Oct 17 19:08:46 10.64.16.99 apache2[19172]: PHP Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf21/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [19:11:15] heh, I think that is happeneing more than we would like :P [19:11:57] I guess we should put in some specific debugging for it [19:16:27] Reedy: we refactored claims and actually thought it got in our branch but it was a few days late [19:17:39] we could perhaps add messages to the asserts too xD [19:33:59] Reedy: well, a fix for this was made last week but after our branch was made [19:34:17] it would be tricky to backport it [19:34:39] aude: we could alwys backport a tiny patch to add messages to the asserts so we know where it is actually tripping up! [19:34:53] and also patch master to give the asserts the same message [19:35:32] it's when viewing a diff for claims that have the same hash [19:35:35] soemthign like that [19:35:47] Ohno [19:35:57] not that assert _Again_ [19:36:10] aude: it doesnt assert hash though :P [19:37:18] if it's bad enough, it *might* be possible to cut a new branch for monday [19:37:29] if selenium + tests are all fine [19:38:13] mhhm, but the claims stuff might have broken other stuff :/ [19:39:05] i don't know [19:39:51] I vote to backport something that chages assert( $oldClaim->getGuid() === $newClaim->getGuid() ); to assert( $oldClaim->getGuid() === $newClaim->getGuid(), $oldclaim->getGuid() ); [19:40:33] i think that could be ok [19:40:48] then we can have a look at an enitty at least :P [19:44:43] make a patch for it aude ? ;p [19:46:11] addshore: no [19:46:13] 5.4.8 The description parameter was added. [19:46:19] apparently it's not in php 5.3 [19:46:24] :( [19:46:38] * aude gets php warning about second param [19:46:50] :< [19:47:16] i'll send a mail to tobi etc. [19:47:40] see if we can try to cut a new branch and run tests [19:47:48] if( $oldguid === $newguid ){ WMFLOG; assert(oldguid === newguid) } xD ? [19:47:55] * aude is pretty comfortable with the code that has gone in since last branch [19:48:07] but i don't know about the js [19:53:55] what php version is actually deployed to the cluster now? :O [19:55:46] 5.3. something [19:56:09] ahh :/ [19:56:20] https://www.wikidata.org/wiki/Special:Version [19:56:23] to be exact :) [19:57:43] mail sent [22:59:18] dennyvrandecic: now we are finally in the same time zone! [23:12:27] JeroenDeDauw: hehe, you mean subjective time zone :)