[05:15:35] anyone around who speaks Russian? [05:18:03] putnik does but is idle [06:20:41] PinkAmpersand, Why Russian? your Wikidata dumped both Billie Lee Turners to [[Q4468157]]. [06:20:42] 10[1] 10https://www.wikidata.org/wiki/Q4468157 [06:21:00] why not to fix a crap at your site first? [06:21:29] qq[IrcCity]: i can fix that right now if you'd like [06:21:32] will take about 15 seconds [06:21:45] splitting an actual encyclopedia article, on the other hand, takes some work [06:22:19] only reason I haven't split it yet is because i thought it was better to wait for the ru.wp articles to get sorted out first [06:22:48] I may not be able to keep my promise if it's too late [06:22:52] in night [06:23:06] Jasper_Deng: ça va [06:24:15] qq[IrcCity]: oh, thanks so much. i'm splitting it now [06:35:33] Jasper_Deng: for Russian labels, do we keep the inverse-order thing they do for biographies? [06:36:24] idk [06:36:29] they do an inverse-order thing? [06:37:22] Deng, Jasper [06:37:28] (except in Russian) [06:38:17] I'd think so [06:38:21] China does this too [06:38:35] well, I don't think they do it in conversation [06:38:46] ru.wp does it for its titles, as a formality [06:38:52] PinkAmpersand, we use direct orders for labels. [06:38:56] Hi all =) [06:39:01] *order [06:39:04] putnik: ah. thanks :) [06:39:32] thanks putnik [06:39:39] a huge number of them must be wrong, though, I'd imagine? since so often we just copy the article title [06:39:54] PinkAmpersand, but by default label equals to article name, which use inverse order. [06:40:14] yeah, exactly. huh. add another backlog to the tally ;) [06:41:10] PinkAmpersand, I think we can fix this by bot (at least for people). [06:41:24] qq[IrcCity]: now split into three items: https://www.wikidata.org/wiki/Q4468157 for Sr., https://www.wikidata.org/wiki/Q15088300 for Jr., https://www.wikidata.org/wiki/Q15088304 for the dab page [06:42:15] putnik: problem is, things we *can* fix by bot is a much larger category than things we *do* fix by bot [06:42:27] for instance, every "List of" should have the "l" lowercased [06:42:51] but only like 5-10% (non-scientific estimate) do [06:44:26] PinkAmpersand, I'll try to fix Russian labels on next week. My bot can't work with labels for now =( [06:44:44] aww :( but cool thanks! [06:45:29] anyways, after about a 90-minute diversion, I can go back to adding {{ill}}s to the List of botanists by author abbreviations [06:45:30] 10[2] 04https://www.wikidata.org/wiki/Template:ill [06:45:37] fuck you AsimovBot [06:45:56] seriously, can we please get rid of that bot? [06:46:01] if i want a link, I can say !link [06:47:33] rschen7754^ [06:47:44] although we really should contact its operator instead [06:48:15] Jasper_Deng: Asimov died in the '90s ;) [06:48:25] operator is jem- [06:48:30] just poked him in #wikimedia-admin [06:49:56] nooo [06:50:02] AsimovBot is useful! [06:50:06] {{done}}! [06:50:06] How efficient, lazyktm! [06:56:15] lazyktm: useful? i bet it doesn't even follow the three laws of robotics ;) [07:58:59] Hey guys. It looks like two extensions are using the same message key at the moment: datatypes-type-quantity already belongs to ext-datatypes, conflict with ext-wikibase-lib [07:59:03] Could you please look into this? [07:59:42] I am going to upgrade Jenkins / restart it for a scheduled maintenance. Expected downtime: 1 hour starting now. [08:06:27] (03PS1) 10Raimond Spekking: Consistency tweak: article -> page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90870 [08:12:37] gdluck hashar ;p [08:12:52] it is booting up :/ [08:12:55] takes a while [08:19:43] hi aude [08:19:44] got a minute? [08:20:52] there's a message that I suspect is "lego" - concatenating things instead of using message functions properly. [08:24:29] aude / Lydia_WMDE : It looks like two extensions are using the same message key at the moment: datatypes-type-quantity already belongs to ext-datatypes, conflict with ext-wikibase-lib. Could you please look into this? [08:34:48] Lydia_WMDE: who can help me investigate a potential problem with a message? ^ [08:35:08] (siebrand needs assistance with another message, too) [08:37:32] solution: get rid of all the messages ;) [08:43:28] siebrand: I have filed a bug already [08:43:43] siebrand: and added a comment in the patch set [08:43:57] Raymond_: Okay. I thought that maybe disabling ext-wikibase-lib might work, too? [08:44:39] siebrand: might work but I hope the bug will be fixed very soon :) [08:46:25] and I filed, too - https://bugzilla.wikimedia.org/show_bug.cgi?id=55961 [08:46:39] didn't go to deep into debugging - the messages there are used in bit weird way [08:53:34] (03PS1) 10Addshore: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 [08:53:55] (03PS1) 10Addshore: Cleanup lib/util file headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90877 [08:54:14] (03PS1) 10Addshore: Refactor lib/SiteMatrixParser.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90878 [08:54:35] (03PS1) 10Addshore: Cleanup lib/Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90879 [08:56:31] (03Abandoned) 10Addshore: Build for mw1.22-wmf11 13:40 11.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/89191 (owner: 10Addshore) [08:56:35] (03Abandoned) 10Addshore: Build for mw1.22-wmf14 13:40 11.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/89190 (owner: 10Addshore) [08:56:37] (03Abandoned) 10Addshore: Build for mw1.22-wmf16 13:40 11.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/89189 (owner: 10Addshore) [08:56:40] (03Abandoned) 10Addshore: Build for mw1.22-wmf18 13:40 11.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/89188 (owner: 10Addshore) [08:56:46] (03Abandoned) 10Addshore: Build for mw1.22-wmf21 14:14 15.10.12 >>> DNM! <<< [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/88991 (owner: 10Addshore) [08:57:32] aude: ping [08:58:35] DanielK_WMDE_: are you planning to join the daily? [08:58:41] remotely? [09:02:47] (03CR) 10Addshore: "It seems I tackled this at roughly the same time as you!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90761 (owner: 10Umherirrender) [09:04:11] Jenkins should be back up now :-] [09:08:28] hashar: indeed it is :) [09:09:05] (03PS8) 10Addshore: Update gitignore [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88966 (owner: 10Jeroen De Dauw) [09:09:06] (03PS11) 10Addshore: Install and update the store when needed [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88753 (owner: 10Jeroen De Dauw) [09:09:20] (03PS4) 10Addshore: (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [09:09:52] (03PS2) 10Addshore: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 [09:09:56] (03PS2) 10Addshore: Cleanup lib/util file headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90877 [09:10:01] (03PS2) 10Addshore: Refactor lib/SiteMatrixParser.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90878 [09:10:06] (03PS2) 10Addshore: Cleanup lib/Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90879 [09:11:12] (03CR) 10Addshore: [C: 032] Optimized imports [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/90581 (owner: 10Jeroen De Dauw) [09:11:53] heh, hashar, the jenkins upgrade seems to have fixed one of our random failures that we couldnt figure out :P [09:12:04] oh really [09:12:14] Jeroen mailed me on friday about some change failing [09:12:26] yup, that appears to have now fixed itself.. [09:12:39] might have been an incompatibility with some extension dependencey [09:13:21] (03CR) 10jenkins-bot: [V: 04-1] Update gitignore [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88966 (owner: 10Jeroen De Dauw) [09:13:28] oh... [09:14:45] well, it is breaking in a different way now ;p [09:15:08] (03CR) 10jenkins-bot: [V: 04-1] Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 (owner: 10Addshore) [09:17:16] (03CR) 10jenkins-bot: [V: 04-1] Install and update the store when needed [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88753 (owner: 10Jeroen De Dauw) [09:19:11] (03PS3) 10Addshore: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 [09:20:16] (03CR) 10jenkins-bot: [V: 04-1] Refactor lib/SiteMatrixParser.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90878 (owner: 10Addshore) [09:20:33] (03CR) 10jenkins-bot: [V: 04-1] (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [09:53:03] (03PS2) 10Addshore: Added some comments and todos. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90106 (owner: 10Daniel Kinzler) [09:53:22] (03CR) 10Addshore: [C: 032] Added some comments and todos. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90106 (owner: 10Daniel Kinzler) [09:55:46] (03CR) 10Siebrand: [C: 032] Consistency tweak: article -> page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90870 (owner: 10Raimond Spekking) [09:59:21] (03Merged) 10jenkins-bot: Consistency tweak: article -> page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90870 (owner: 10Raimond Spekking) [10:00:49] http://tools.wmflabs.org/wikidata-todo/stats.php at the bottom a new statistic is being generated :) [10:04:07] (03Draft1) 10Addshore: Add some wfDebugLog() calls for debugging [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90882 [10:04:09] (03Merged) 10jenkins-bot: Add some wfDebugLog() calls for debugging [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/90882 (owner: 10Addshore) [10:06:37] (03PS1) 10Aude: (bug 55937) remove duplicate datatypes-type-quantity message in Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90883 [10:06:51] * aude should not be awake :) [10:06:58] HAH! [10:07:04] isnt it 3am? [10:07:08] yeah [10:07:12] maybe some jetlag still [10:07:18] although this is normal [10:07:19] Where in the world is aude? [10:07:35] SF :) [10:07:37] * aude is invading the foundation [10:07:43] I was looking at the time [10:07:49] It didn't seem like you were back in the DC area [10:07:53] nope [10:08:14] anyway, the message key is not needed in wikibase [10:10:01] (03CR) 10Raimond Spekking: [C: 032] (bug 55937) remove duplicate datatypes-type-quantity message in Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90883 (owner: 10Aude) [10:14:03] (03Merged) 10jenkins-bot: (bug 55937) remove duplicate datatypes-type-quantity message in Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90883 (owner: 10Aude) [10:17:31] hashar: ! [10:17:48] I may have found my problem! [10:18:49] This failing test > https://integration.wikimedia.org/ci/job/mwext-WikibaseQuery-testextensions-master/212/ made me do https://gerrit.wikimedia.org/r/#/c/90882/ but the jenkins workspace doesnt seem to be updated [10:18:49] https://integration.wikimedia.org/ci/job/mwext-WikibaseQuery-testextensions-master/ws/extensions/WikibaseDatabase/src/SQLite/SQLiteTableDefinitionReader.php/*view*/ [10:19:17] could you poke it? :) [10:26:39] * addshore pokes hashar ^^ to make sure he spotted ;p [10:28:03] bahh [10:28:51] 10:12:11 Fetching WikibaseDatabase [10:28:52] 10:12:11 Deleting and recreating '/srv/ssd/jenkins-slave/workspace/mwext-WikibaseQuery-testextensions-master/extensions/WikibaseDatabase'... [10:28:53] 10:12:11 Copying 'WikibaseDatabase' in '/srv/ssd/jenkins-slave/workspace/mwext-WikibaseQuery-testextensions-master/extensions/WikibaseDatabase' [10:28:54] 10:12:12 Copy complete. [10:29:00] it should be updating WikibaseDatabase [10:29:15] hmmm [10:29:27] maybe I should make the extension fetcher to dump the sha1 / author / rev [10:29:29] could you re run it ? [10:29:38] hashar: that would be awesome :P [10:29:43] sha1 of the commit :> [10:31:23] hmm [10:31:29] all files from Oct 17th [10:31:41] heh :P [10:34:56] addshore: has WikibaseDatabase been updated since Oct 17th? [10:35:11] I have merged 2 things today at least :) [10:35:35] the last I got in my Gerrit local repo is * 05717b4 - (HEAD, master, refs/changes/46/90346/1) Only install using prefix on mysql.. (4 days ago) [10:35:36] so [10:35:43] gerrit replication is broken [10:35:54] hmmm O_o http://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibaseDatabase is behind.. [10:37:37] the other replication has the same issue: * 05717b4 - (HEAD, master, refs/changes/46/90346/1) Only install using prefix on mysql.. (4 days ago) [10:38:05] ah no [10:38:19] hashar: 00:38 < ^d> !log bringing gerrit down to troubleshoot replication [10:38:23] from operations [10:38:30] i don't know that i saw it was resolved [10:38:39] so yeah [10:38:45] git.wm.o is showing a replica as well [10:38:56] so it is broken right now :( [10:39:15] :( [10:39:15] =[ [10:40:21] de515f00 10:40:18.616 push gerritslave@gallium.wikimedia.org:/var/lib/git/mediawiki/extensions/WikibaseDatabase.git [10:40:22] be4eeb5b 10:40:18.911 push gerritslave@antimony.wikimedia.org:/var/lib/git/mediawiki/extensions/WikibaseDatabase.git [10:40:23] 1e3b77ce 10:40:18.931 push gerritslave@gallium.wikimedia.org:/srv/ssd/gerrit/mediawiki/extensions/WikibaseDatabase.git [10:40:24] fe3f83b7 10:40:18.957 push gerritslave@lanthanum.eqiad.wmnet:/srv/ssd/gerrit/mediawiki/extensions/WikibaseDatabase.git [10:40:28] that is Gerrit attempting to replicate the repo [10:40:33] apparently does not work that well :D [10:42:26] :/ [10:42:41] maybe the #wikimedia-operations log has some details [10:42:45] if chad mentioned them there [10:43:37] no details [10:44:21] [01:21:40] <^d> *sigh* This is not how I planned to spend my sunday evening. [10:44:25] he probably rage quit :-D [10:44:26] not good if he couldn't fix it in ~5 min [10:44:33] more complicated [10:44:39] I guess so [10:44:56] ;_; [11:01:35] hashar: any idea if there is a bug open for the git replication? [11:06:13] no clue [11:06:22] look at Wikimedia > git/gerrit in bugzilla [11:06:27] if there is none, feel fee to fill one [11:12:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=55948 :) [11:12:05] found one [11:12:43] hehe lazyktm filed it earlier today :) [11:18:11] nce [11:18:38] this channel is a little scary sometimes, seems you use all your time solving pure technical problems and not to develop :) [11:19:38] (03Abandoned) 10Addshore: Refactor lib/SiteMatrixParser.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90878 (owner: 10Addshore) [11:21:01] Hi! Can someone help with adding inter-wiki link? I get error "Site link Деградация is already used by item Q1046283" but can not find the problem [11:25:23] addshore: I might have found the issue [11:25:30] :D [11:26:53] friday deploy :( [11:30:12] hehe TomT0m, it may appear like that at times :P Its probably mainly me poking hashar :D (I am doing other things at the same time) ;p [11:30:48] follow up in #wikimedia-operations [11:36:22] addshore: well, this is one example why i don't like our deployment process to depend on getting stuff anywhere but from gerrit directly [11:36:40] * aude also notes that github was down over the weekend for a period of time [11:37:02] though we need replication for travis, etc [11:37:30] aude: I can pull from gerrit fine :P [11:37:34] yes [11:37:45] it is just not replicating to github mirror [11:37:50] and apparently we can make composer pull from gerrit meaning travis wouldnt be affected [11:37:51] * aude thinks [11:38:00] yes we can do that and we should [11:38:23] less possible points of breakage is good [11:38:31] but its not even getting as far as git.wikimedia.org :P [11:38:34] points of failure [11:38:38] yeah [11:38:53] idealy jenkins would grab stuff straight from gerrit? :> [11:57:51] (03CR) 10Siebrand: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [11:58:00] (03CR) 10Siebrand: [C: 04-1] Add an option in the user preferences to choose additional languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 (owner: 10Bene) [12:03:01] (03CR) 10Siebrand: "Thanks for looking that up, Bene. Especially core is not without issues. I've submitted Change-Id: If914e26f2af23f04c46f011ad8a276a9d31905" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [12:04:09] (03CR) 10Siebrand: [C: 04-1] "i18n issue in RepoItemLinkGenerator.php. Pointed out in PS1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [12:09:55] Hello everybody :) [12:10:02] !admin please :) [12:13:01] Lydia_WMDE: are you here ? [12:13:10] hsarrazin: hey [12:13:11] yes [12:13:18] hello Lydia :) [12:13:25] * Lydia_WMDE waves [12:14:08] hsarrazin: wasup? [12:14:20] while trying to complete a series of homonyms, I found (at least) 3 items that were created from a single wp (mg). and the page has been suppressed on that wp. [12:14:46] what do we do in these cases ? https://www.wikidata.org/wiki/Q13106012 [12:14:51] * Lydia_WMDE looks [12:15:09] also Q13106508 and Q13108511 [12:15:37] hsarrazin: it seems nothing is using that item and it is empty so i'd put it up for deletion [12:15:48] ok... [12:16:14] Lydia_WMDE: how can I know if something is using a specific item ? [12:16:32] check the "what links here" link in the sidenbar [12:16:46] oh, yes, stupid of me :) [12:16:53] np ;-) [12:16:56] thanx :) [12:27:26] addshore: reeeevieeeew :p [12:31:08] addshore: https://gerrit.wikimedia.org/r/#/c/82637/ [13:04:12] hey wikidata people, https://www.wikidata.org/wiki/Wikidata:Property_proposal/Place#MusicBrainz_area_ID has been sitting there, waiting, for over a month now. is anything missing in the proposal or is something else wrong with it?:) [13:06:14] (03PS3) 10Addshore: Diff sitelinks now link to the relevant page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90896 [13:13:53] (03PS4) 10Addshore: Diff sitelinks now link to the relevant page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90896 [13:32:40] aude: addshore: does one of you know where the apache rewrite rules for wikidata are in git? see latest email to wikidata-l by kingsley [13:41:08] (03PS5) 10Addshore: Diff sitelinks now link to the relevant page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90896 [13:41:19] Lydia_WMDE: ill have a look, should be able to find them [13:41:28] addshore: thanks! [13:41:59] aude is or should be asleep :P [13:45:59] we're on the same side of the earth! I'm awake ;-) [13:46:13] it's nearly 12 here [13:51:39] Lydia_WMDE: hey, poked Henning_WMDE ? [13:51:59] lazowik: ah no - not yet [13:52:23] Henning_WMDE: lazowik wanted to see the mockup for the badges UI - would be cool if you could take a picture and put it online somewhere [13:52:37] lazowik: done :P [13:52:44] :D [13:55:14] http://tools.wmflab s.org/wikidata-todo/stats.php?reverse [13:55:30] http://tools.wmflabs.org/wikidata-todo/stats.php?reverse [13:55:58] This makes the community effort more visible :) [13:56:39] Lydia_WMDE: https://github.com/wikimedia/operations-apache-config/search?q=wikidata&ref=cmdform [13:57:15] Lydia_WMDE: I cant find them :P [13:57:18] lazowik: oh great - do you also have the official wikimedia repo that is mirrored from? [13:57:28] ahh xD [13:57:30] operations/apache-config [13:57:31] lol [13:57:43] https://gerrit.wikimedia.org/r/#/admin/projects/operations/apache-config [13:57:46] \o/ [13:57:48] thanks guys [13:57:55] i will email kingsley [13:58:06] I was looking in the wrong repo :P [13:58:13] actually I wanted to change something in there for wd [13:58:21] (language code subdomains) [13:58:37] lazowik: what exactly? [13:59:21] Lydia_WMDE: like pl.wikidata.org/wiki/Berlin -> http://www.wikidata.org/wiki/Special:ItemByTitle/plwiki/Berlin [13:59:43] https://gerrit.wikimedia.org/r/#/c/47088 abandoned per Tim Starling [14:00:06] lazowik: ah yeah.... this is a complete mess atm tbh [14:00:09] and current attempt by Dzahn https://gerrit.wikimedia.org/r/#/c/65443/ [14:00:37] well, "current" [14:01:12] lazowik: i am also not convinced this is a good idea tbh [14:01:29] pl.wikidata.org should give you wikidata in polish [14:01:44] not link you to the item with some polish name [14:01:51] also why do this based on wikipedia [14:01:57] what about wikivoyage and all the others? [14:02:16] Lydia_WMDE: heh, now it makes no sense [14:02:27] but then other links were not even on the horizon :p [14:03:09] http://www.youtube.com/watch?v=m4OFBR7Ge5k [14:03:10] hehe [14:08:54] PS THe "official" WMF statistics are now available for September .. [14:18:19] Hey, is there any api module for [[Special:ItemsWithoutSitelinks]]? [14:18:21] 10[3] 04https://www.wikidata.org/wiki/Special:ItemsWithoutSitelinks [14:18:28] nope :/ [14:18:40] addshore: is there a bug for it? [14:18:47] i believe so [14:19:39] addshore: do you know the id? [14:20:09] ill have a quick look :) [14:20:35] thx [14:21:41] benestar: I dont think there is actually, I believe I was thinking of https://bugzilla.wikimedia.org/show_bug.cgi?id=49137 [14:22:00] hmm [14:22:22] So there is a class called WikibaseApi in the repo [14:22:35] yup [14:22:42] However it says it is only for editing so I believe we should call it EditWikibaseApi [14:22:44] right? [14:22:58] hmm *looks* [14:23:22] so we could create another class called QueryWikibaseApi (like SpecialWikibaseQueryPage in lib) [14:24:02] (03PS6) 10Addshore: Diff sitelinks now link to the relevant page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90896 [14:24:06] and this class could be inherited by something like ItemsWithoutSitelinks [14:24:19] addshore: ??? [14:24:34] so, we have ApiWikibase [14:24:44] * benestar nods [14:24:52] which indeed says Base class for API modules modifying a single item identified based on id xor a combination of site and page title. [14:24:59] although it is currently used for more than just that! [14:25:21] right [14:25:48] so I think we should rename this class to WikibaseEditApi or sth like that [14:26:02] if you agree I will create a patchset [14:26:46] you could indeed do that [14:26:47] oh noez! [14:26:51] more rebases?! [14:26:58] hehe :P [14:27:06] and then make a higher class called WikibaseApi [14:27:10] yes [14:27:15] which contains methods like addSiteLinksToResult etc [14:27:19] addshore: qick, merge my patch! [14:27:24] which are used for both getting and editing [14:27:25] addshore: I disagree [14:27:39] addSitelinksToResult etc isn't needed for queries [14:27:54] because they return more than one item [14:27:55] but GetEntities and GetClaims currently extends ApiWikibase [14:28:08] which means your naming of WikibaseEditApi would be wrong if they were left there [14:28:12] ugh [14:28:12] * aude thinks we should get away from inheritance here [14:28:21] * benestar agrees [14:28:22] aude: its rather impossible in the api ;p [14:28:38] maybe not editapi but something like singleitemapi [14:28:44] but we are making it worse :P [14:28:45] we could have lots of code duplicate but that doesnt really help us either [14:29:01] benestar: but itdoes more than just single items ;p [14:29:11] addshore: hmm? [14:29:23] I mean it just works on single items [14:29:28] aude: I want to factor the building of api results out of the base class ()i have a draft i am working on for that) [14:29:44] benestar: getentities works on many items ;p [14:29:59] ok, so this would be a candidate for the second api baseclass [14:30:05] called queryitemsapi [14:30:11] or sth like that ;) [14:30:21] this sounds kinda logic [14:30:27] it might even be worth trying to ApiQueryBase in core [14:30:37] using actio=query [14:30:42] oh dear I can not type! [14:31:02] addshore: well, this sounds good [14:31:04] hooking into action=query would be good [14:31:09] aude: indeed [14:31:23] so action=query&list=wbgetentities ? [14:31:31] looks good to me :) [14:31:35] or list=itemswithoutsitelink ? [14:31:44] I would keep the wb prefix [14:31:46] ok, if you agree I will try this :) [14:31:50] k [14:32:11] addshore: should I create a bug for this anyhow? [14:32:16] (03PS9) 10Addshore: Update gitignore [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88966 (owner: 10Jeroen De Dauw) [14:32:21] switching wbgetentities to that might be complicated [14:32:22] benestar: yup :) [14:32:32] and for all of the other special pages ;p [14:32:33] aude: why do you think so? [14:32:33] but to use that approach for items without sitelink would be ok [14:32:56] ok, so I will keep the wbgetentities as it is for now [14:33:01] benestar: well, bots rely on the current way wbgetentities provides results [14:33:09] right [14:33:16] i can't imagine how we can keep it compatible [14:33:35] so it would break bots, which is something we shouldn't do very often and not without good reason and care [14:33:35] don't know, so just keep wbgetentities as it is for now [14:33:40] k [14:34:26] really we should potentially have something like action=wbedit&what=entity&data={} etc. :P but that would break a lot of things for a lot of people ;p (unless we kept them both running side by side and deprecated one ;p) [14:34:50] yeah, that would need to be the approach i think [14:34:56] aude, go to sleep ;p [14:35:02] (03PS1) 10Henning Snater: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 [14:35:06] * aude is awake now [14:35:11] it's morning! :) [14:35:14] (03PS1) 10Addshore: Fix comment in ApiWikibase that is not correct [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90909 [14:35:18] fine then, aude ^^ ;p [14:35:28] (03CR) 10jenkins-bot: [V: 04-1] Update .gitignore [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88966 (owner: 10Jeroen De Dauw) [14:35:38] a few timezones off from lydia though [14:36:51] hmm hashar wikibasedatabase still didnt seem to get updated on jenkins for https://integration.wikimedia.org/ci/job/mwext-WikibaseQuery-testextensions-master/ws/extensions/WikibaseDatabase/src/SQLite/SQLiteTableDefinitionReader.php/*view*/ [14:37:00] might I need to merge something into the repo to kickstart things? [14:37:59] let me check [14:38:11] (03CR) 10Aude: [C: 032] Fix comment in ApiWikibase that is not correct [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90909 (owner: 10Addshore) [14:38:20] cheers aude :) [14:38:29] :) [14:38:31] i'll eat the choclate for you ;p [14:38:37] ok [14:38:55] * aude has chocolate for the office here [14:39:40] go and have one then :D [14:40:21] WikibaseDatabase has * 05717b4 - (HEAD, master, refs/changes/46/90346/1) Only install using prefix on mysql.. (4 days ago) [14:40:34] there should be 2 after than :< [14:40:42] :> [14:40:47] so the replication did not magically catch up :] [14:40:53] not sure how to resync the repos [14:41:08] Shall I go and poke everything with some pointless cleanup? [14:41:23] potentially [14:41:36] or attempt send a patchset on WikibaseDatabase [14:41:41] that might kick of the replication process [14:41:46] since there is a new ref [14:41:47] (03Merged) 10jenkins-bot: Fix comment in ApiWikibase that is not correct [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90909 (owner: 10Addshore) [14:41:47] OR [14:41:52] OR! [14:41:58] maybe Chad has to manually resync them :/ [14:42:11] addshore: it is quite heavy to extend query [14:42:25] have to use hooks as I understood it [14:42:37] :/ [14:42:52] (03CR) 10Tobias Gritschacher: "(2 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [14:43:03] Henning_WMDE: 2 comments: https://gerrit.wikimedia.org/r/#/c/90318/ [14:43:06] benestar: no you don't [14:43:22] aude: so how can I do it? [14:43:28] it's a tiny module but take a look at the api module in wikibase client [14:44:20]