[00:11:54] (03CR) 10Jeroen De Dauw: [C: 04-1] "(7 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [00:14:35] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 (owner: 10Henning Snater) [00:18:52] (03PS3) 10Aude: Parse lowercase ids in ByPropertyListUnserializer [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/91088 (owner: 10Addshore) [00:19:41] (03CR) 10Aude: "i wouldn't mind a test case here, even in the backport. But this is probably okay, as long as the test case(s) go into master." [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/91088 (owner: 10Addshore) [00:20:04] (03CR) 10jenkins-bot: [V: 04-1] Parse lowercase ids in ByPropertyListUnserializer [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/91088 (owner: 10Addshore) [00:22:17] (03CR) 10Aude: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91086 (owner: 10Addshore) [00:26:59] (03CR) 10Aude: [V: 04-1] "in testing myself against the api, I had only one reference. With multiple, it would fail. (as tests caught)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91086 (owner: 10Addshore) [00:31:43] (03CR) 10Jeroen De Dauw: [C: 04-1] "(5 comments)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [00:43:34] how come WMDE doesn't get a button at the bottom of the page, next to the Wikimedia and MediaWiki ones? [00:44:34] good question [00:46:04] Lydia_WMDE: around? [06:44:09] (03CR) 10Henning Snater: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 (owner: 10Henning Snater) [07:11:25] (03PS2) 10Henning Snater: Implemented numeric index in Claims [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 [07:23:47] (03CR) 10Henning Snater: "(4 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [07:24:37] (03PS4) 10Henning Snater: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 [07:27:30] (03PS5) 10Henning Snater: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 [07:54:41] good morning [08:45:50] addshore: Guten Tag. The Gerrit replication being fixed, have you noticed any issue yesterday evening or this morning? [08:55:54] (03CR) 10Tobias Gritschacher: "I agree with using "position" instead of "index" would be better. In especially because we're dealing with arrays inside these methods, on" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [08:56:21] hashar: nope :) [08:56:27] all seems fine :) [08:58:54] good [08:59:29] addshore: I amended one of your @cover change https://gerrit.wikimedia.org/r/#/c/91077/1..2//COMMIT_MSG,unified [08:59:34] PS2 contains my diff [08:59:37] PS3 is a rebase [08:59:48] if that looks fine to you, will +2 [08:59:49] it is good to me [09:00:00] just converted the //TODO to /** @todo foo */ [09:00:05] so Doxygen catch them [09:00:17] yep looks fine :) [09:01:16] +2 :-} [09:01:20] thank you for the @covers !! [09:01:47] my patch to add cloverphp plugin in Jenkins Job Builder is still pending review [09:01:53] hopefully will be handled by the end of next week [09:02:17] change seems fine on first review, now waiting for a second person to test it [10:49:20] (03CR) 10Addshore: [C: 031] "I see no problem with 'index'." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [11:19:05] (03PS1) 10Henning Snater: Reflect changes to ByPropertyIdArray in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91171 [11:20:04] (03PS6) 10Henning Snater: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 [11:20:53] (03CR) 10jenkins-bot: [V: 04-1] Reflect changes to ByPropertyIdArray in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91171 (owner: 10Henning Snater) [11:41:01] (03CR) 10Addshore: [C: 031] "Code all looks fine!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:57:42] (03PS1) 10Jeroen De Dauw: Fix @covers tag [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/91174 [11:58:00] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Fix @covers tag [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/91174 (owner: 10Jeroen De Dauw) [12:00:36] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#70 (master - 59d8cc5 : jeroendedauw): The build has errored. [12:00:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/977c373f1e40...59d8cc5dbeff [12:00:36] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12875565 [12:09:45] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Update gitignore [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/88966 (owner: 10Jeroen De Dauw) [12:12:47] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#71 (master - 7b2b0df : jeroendedauw): The build has errored. [12:12:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/59d8cc5dbeff...7b2b0df02c9a [12:12:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12876006 [12:54:50] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#71 (master - 7b2b0df : jeroendedauw): The build passed. [12:54:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/59d8cc5dbeff...7b2b0df02c9a [12:54:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12876006 [13:08:49] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#70 (master - 59d8cc5 : jeroendedauw): The build was fixed. [13:08:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/977c373f1e40...59d8cc5dbeff [13:08:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/12875565 [13:10:46] (03CR) 10Tobias Gritschacher: [C: 032] Implemented numeric index in Claims [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [13:10:59] (03Merged) 10jenkins-bot: Implemented numeric index in Claims [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [13:25:27] (03PS1) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [13:25:40] (03PS2) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [13:26:46] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDataModel#112 (master - 09ec8a0 : Henning Snater): The build has errored. [13:26:46] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/compare/172616a58fdb...09ec8a05c96b [13:26:46] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDataModel/builds/12878716 [13:38:50] (03PS7) 10Henning Snater: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 [13:40:26] (03PS3) 10Henning Snater: Upgraded ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 [14:01:27] (03CR) 10Tobias Gritschacher: [C: 032] Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 (owner: 10Henning Snater) [14:01:38] (03Merged) 10jenkins-bot: Using property id serialization in ByPropertyIdArray [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90908 (owner: 10Henning Snater) [14:03:33] (03CR) 10Tobias Gritschacher: [C: 032] Reflect changes to ByPropertyIdArray in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91171 (owner: 10Henning Snater) [14:04:53] Tobi_WMDE: can you please review https://gerrit.wikimedia.org/r/#/c/91088/ ? [14:05:35] you can ignore jenkins there and run tests yourself on the branches, if you like [14:06:51] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDataModel#113 (master - 8566596 : Henning Snater): The build passed. [14:06:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/compare/09ec8a05c96b...85665969902d [14:06:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDataModel/builds/12881332 [14:07:11] (03Merged) 10jenkins-bot: Reflect changes to ByPropertyIdArray in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91171 (owner: 10Henning Snater) [14:14:52] (03PS3) 10Henning Snater: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 [14:14:53] (03PS4) 10Henning Snater: Implemented index parameter in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90504 [14:14:54] (03PS5) 10Henning Snater: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 [14:14:55] (03PS8) 10Henning Snater: Keep track of reference's index in referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89004 [14:14:56] (03PS11) 10Henning Snater: Implemented referenceview movetoolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89007 [14:14:57] (03PS3) 10Henning Snater: Keeping track of claim index in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 [14:27:27] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Parse lowercase ids in ByPropertyListUnserializer [extensions/Wikibase] (mw1.22-wmf21) - 10https://gerrit.wikimedia.org/r/91088 (owner: 10Addshore) [14:32:00] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1063 (mw1.22-wmf21 - 5cdf61d : addshore): The build has errored. [14:32:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/8903c2234d62...5cdf61d72ac5 [14:32:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/12882546 [14:35:13] thanks Tobi_WMDE [14:35:46] would you also be willing to follow up on addshore's patch for master? (if addshore doesn't) [14:36:00] henning's changes might impact it in some way also [15:13:55] (03PS1) 10Jeroen De Dauw: Optimized imports [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/91186 [15:14:45] (03PS1) 10Jeroen De Dauw: Optimized imports [extensions/Ask] - 10https://gerrit.wikimedia.org/r/91187 [15:15:23] (03PS1) 10Jeroen De Dauw: Optimized imports [extensions/Diff] - 10https://gerrit.wikimedia.org/r/91188 [15:16:51] addshore: protip: the static code analysis of phps7 appears to have been impoved ;p [15:17:44] * aude is in JeroenDeDauw's timezone! [15:18:37] i guess it's not that late there yet [15:21:02] (03CR) 10Aude: [C: 032] Optimized imports [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/91186 (owner: 10Jeroen De Dauw) [15:21:08] (03Merged) 10jenkins-bot: Optimized imports [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/91186 (owner: 10Jeroen De Dauw) [15:21:19] (03CR) 10Aude: [C: 032] Optimized imports [extensions/Ask] - 10https://gerrit.wikimedia.org/r/91187 (owner: 10Jeroen De Dauw) [15:21:27] (03Merged) 10jenkins-bot: Optimized imports [extensions/Ask] - 10https://gerrit.wikimedia.org/r/91187 (owner: 10Jeroen De Dauw) [15:21:44] (03CR) 10Aude: [C: 032] Optimized imports [extensions/Diff] - 10https://gerrit.wikimedia.org/r/91188 (owner: 10Jeroen De Dauw) [15:21:50] (03Merged) 10jenkins-bot: Optimized imports [extensions/Diff] - 10https://gerrit.wikimedia.org/r/91188 (owner: 10Jeroen De Dauw) [15:26:11] aude: I travelled back to the real URC+1 today, so pretty jetlagged atm [15:26:33] :) [15:27:24] (03PS1) 10Henning Snater: Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 [15:28:53] (03CR) 10jenkins-bot: [V: 04-1] Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 (owner: 10Henning Snater) [15:37:38] (03CR) 10Jeroen De Dauw: "(3 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/90318 (owner: 10Henning Snater) [15:39:19] aude: hi! around? can you take a look at https://gerrit.wikimedia.org/r/#/c/90944/ please? [15:39:44] aharoni: sure [15:39:53] thanks! [15:40:34] assuming it is good (looks trivial to me), it will be in the branch we deploy on monday [15:41:00] great. [15:42:12] (03PS1) 10Henning Snater: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 [15:43:28] aude: come to think of it, it may fix https://bugzilla.wikimedia.org/show_bug.cgi?id=55962 . [15:43:44] (03CR) 10jenkins-bot: [V: 04-1] Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 (owner: 10Henning Snater) [15:43:51] but another one that I'm very curious about and find a bit puzzling is https://bugzilla.wikimedia.org/show_bug.cgi?id=55961 . [15:47:16] (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [15:52:19] (03CR) 10Jeroen De Dauw: [C: 04-2] "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [16:00:18] (03CR) 10Jeroen De Dauw: "(7 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [16:01:53] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [16:04:08] (03CR) 10Jeroen De Dauw: "What about putting this in ins own repo right away?" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 (owner: 10Daniel Werner) [19:37:27] aude: Any progress with the coordinates/ [19:37:28] ? [19:37:42] multichill: no [19:38:01] i am travelling and busy [19:38:03] Busy doing other things? [19:38:05] yes [19:38:12] Ah, where are you traveling? [19:38:15] maybe when i get back, i can start again [19:38:24] * aude is at the WMF office :) [19:39:20] Ah, what brought you to SF aude? [19:39:28] gsoc mentor summit [19:39:30] An aeroplane [19:39:33] heh [19:41:08] Siebrand also there? [19:41:19] don't think so [19:41:37] Hmm, thought he was a mentor too, not sure [19:41:51] only so many (or few) can go from each organization [19:42:01] * aude will skip next year to allow someone else to attend [19:42:14] Fun? Interesting? [19:42:22] yes! [19:42:42] people from other open source projects [19:42:52] I got a gsoc t-shirt this week [19:42:53] One of the few women? Or not too bad? [19:42:58] but I'm not a mentor [19:43:00] somewhat amusing [19:43:19] multichill: one of few, although the gsoc organizers are mainly women [19:43:31] Reedy: :) [19:43:35] Like with the hackathon in Amsterdam ;-) [19:45:31] It's not a gender gap, it's a gender canyon ;-) [20:41:27] Does anyone here know if there's a particular group of editors working on election-specific items? [20:42:18] GorillaWarfare: You could look at the task forces, but I doubt it [20:42:32] Yeah, I looked, but there's nothing really. Wasn't sure if I was missing something :) [20:43:01] I'm helping a research lab on my campus work on some stuff that will involve Wikidata, and it's all election-related stuff, so I didn't know if there was some unified group I could check in with. [21:12:03] GorillaWarfare: what type of elections ? [21:21:26] GerardM: International elections -- presidential and, more recently, parliamentary [21:25:38] particularly for results ? [21:27:23] They're collecting large amounts of polling data [21:57:13] morning aude :> [21:58:55] moin! [21:59:39] the property id uncaught exception is fixed on wikidata [21:59:51] the patch for master still needs follow up, afaik [22:04:03] hmmm, I told tobi, but I have no time for it :< [22:04:07] didnt manage it today :< [22:04:11] that's fine [22:04:29] maybe i can at least apply the fix i did to the master patch [22:07:26] (03PS1) 10Aude: (bug 56018) add descriptions to entity search [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91303 [22:10:02] (03PS2) 10Aude: (bug 56018) add descriptions to entity search [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91303 [22:11:12] (03PS3) 10Aude: (bug 56018) add descriptions to entity search [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91303 [22:15:09] indeed! [22:15:10] night! [22:22:54] nacht! [22:24:44] (03PS4) 10Aude: (bug 56018) add descriptions to entity search [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91303 [22:30:52] (03CR) 10Aude: [C: 032] RTL tweaks for label title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90944 (owner: 10Amire80) [22:34:29] (03Merged) 10jenkins-bot: RTL tweaks for label title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90944 (owner: 10Amire80) [22:56:36] aude: ping [22:57:37] oh well [22:58:00] can anyone here tell me why I cannot execute php scripts on tools.wmflabs.org ? [22:58:11] I mean access in the browser [23:01:40] What do you get instead? [23:09:36] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by AyeImCharles link https://www.mediawiki.org/w/index.php?diff=806475 edit summary: [-140] [23:10:15] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by John F. Lewis link https://www.mediawiki.org/w/index.php?diff=806476 edit summary: [+140] Undo revision 806475 by [[Special:Contributions/AyeImCharles|AyeImCharles]] ([[User talk:AyeImCharles|talk]]) [23:10:18] 10[1] 04https://www.wikidata.org/wiki/Special:Contributions/AyeImCharles13 => [23:10:20] 10[2] 04https://www.wikidata.org/wiki/User_talk:AyeImCharles