[01:24:36] <Guest55285>	 Hi Sannita!
[01:35:27] <Guest55285>	 Is any Flemish speaking person here?
[01:42:58] <Jasper_Deng_busy>	 no
[01:43:07] <Jasper_Deng_busy>	 most people in Italy would be asleep by now
[01:43:17] <Reedy>	 ...
[01:43:31] <Reedy>	 Try Belgium
[01:43:40] <Jasper_Deng_busy>	 same
[01:43:51] <Jasper_Deng_busy>	 it's past midnight there
[10:19:00] <grrrit-wm>	 (03CR) 10Addshore: "The issue is I have no idea why this is actually happening." [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/92515 (owner: 10Addshore)
[10:19:05] <addshore>	 Tobi_WMDE: megreee ^^^^
[10:20:31] <addshore>	 or JeroenDeDauw if your around and awake :D
[10:21:19] <grrrit-wm>	 (03PS4) 10Addshore: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 
[10:33:03] <grrrit-wm>	 (03PS5) 10Addshore: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 
[10:33:11] <grrrit-wm>	 (03CR) 10Addshore: "PS4 was a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 (owner: 10Addshore)
[10:34:26] <grrrit-wm>	 (03PS1) 10Henning Snater: Removed default event handler generation from toolbarcontroller [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92627 
[10:36:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 (owner: 10Addshore)
[10:36:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed default event handler generation from toolbarcontroller [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92627 (owner: 10Henning Snater)
[10:39:38] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 031] "This is probably the only way to find out why the tests in the other component are failing. Adding a testcase here could be hard because i" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/92515 (owner: 10Addshore)
[11:12:16] <GerardM>	 I just read that Incubator is integrated in Wikidata .... Why did I hear about this only now ... is this another best kept secret ??
[11:12:28] <aude>	 GerardM: it's news to me
[11:13:00] <addshore>	 and to me :P
[11:13:50] <GerardM>	 ... Steve Slivinsky wrote about this in his mail in the [Wikidata-l] Happy Birthday, Wikidata! thread
[11:14:08] * aude  shall let Lydia answer if she wants to

[11:14:21] <aude>	 no idea where he got the info :)
[11:14:35] <Lydia_WMDE>	 yeah - no integration at the moment
[11:14:42] <GerardM>	 What I do know is that you can add content in ASL ...
[11:14:47] <Lydia_WMDE>	 and incubator is not highest on the list of next projects tbh
[11:14:57] <GerardM>	 yes I agree
[11:15:14] <aude>	 Lydia_WMDE: do you get highlighted when i say Lydia?
[11:15:20] <Lydia_WMDE>	 aude: yes ;-)
[11:15:27] * aude  trying not to bother you, but #fail

[11:15:32] <Lydia_WMDE>	 hehe it's fine
[11:15:40] <Lydia_WMDE>	 listening to a talk and going through a few emails
[11:15:46] <aude>	 ok :)
[11:15:59] <Lydia_WMDE>	 aude: also i set up my client this way so if at all it's fail on my side
[11:16:15] <aude>	 heh
[11:24:26] <grrrit-wm>	 (03PS1) 10Henning Snater: (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 
[11:25:53] <grrrit-wm>	 (03PS2) 10Henning Snater: Removed default event handler generation from toolbarcontroller [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92627 
[11:31:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 (owner: 10Henning Snater)
[11:32:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed default event handler generation from toolbarcontroller [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92627 (owner: 10Henning Snater)
[11:43:50] <grrrit-wm>	 (03PS2) 10Henning Snater: (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 
[11:45:30] <GerardM>	 http://ultimategerardm.blogspot.nl/2013/10/magnus-master-of-wikimedia-tools.html
[11:48:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 (owner: 10Henning Snater)
[11:49:17] <grrrit-wm>	 (03PS3) 10Henning Snater: (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 
[11:53:07] <grrrit-wm>	 (03PS7) 10Addshore: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 
[11:58:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 (owner: 10Henning Snater)
[11:58:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 (owner: 10Addshore)
[12:03:58] <grrrit-wm>	 (03PS8) 10Addshore: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 
[12:06:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 (owner: 10Addshore)
[12:07:42] <addshore>	 mhhhm, something is up with jenkins
[12:08:16] <addshore>	 Krinkle, any ideas? ;/  >> https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/3840/console
[12:12:56] <Krinkle>	 addshore: I don't know, I see it myself as well
[12:13:05] <Krinkle>	 hashar made some changes just now, but he's not on irc.
[12:13:15] <Krinkle>	 I've pinged him already
[12:13:56] <addshore>	 awesome :)
[12:14:00] <aude>	 huh
[12:14:12] <aude>	 no such file or directory?
[12:14:55] <aude>	 q
[12:15:01] <aude>	 grr
[12:15:05] <addshore>	 [=
[12:20:39] <Krinkle>	 addshore: Just review as usual, I'll be sure to poke patches with CR+2 once it is fixed.
[12:20:49] <addshore>	 okay :)
[12:38:32] <grrrit-wm>	 (03PS1) 10Addshore: Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 
[12:41:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore)
[12:42:11] <aude>	 jenkins fail!
[12:42:51] <addshore>	 indeede :D
[12:46:47] <hashar>	 hey
[12:46:52] <hashar>	 so I killed jenkins :/
[12:46:57] <hashar>	 some paths are wrong and are being fixed
[12:47:04] <hashar>	 I thought you were all on vacations!
[12:47:09] * aude  is back!

[12:47:17] <addshore>	 :P
[12:47:20] * addshore  is back :D

[12:47:20] <hashar>	 so I am working on the fix
[12:47:26] <aude>	 ok
[12:47:37] <hashar>	 but the jobs are taking a long time to fix
[12:47:52] <aude>	 not a problem
[12:52:33] <Lydia_WMDE>	 <3 http://ultimategerardm.blogspot.nl/2013/10/magnus-master-of-wikimedia-tools.html
[12:53:07] <hashar>	 GerardM: gooooood job :-]
[12:53:15] <hashar>	 err
[12:53:22] <hashar>	 Lydia_WMDE: gooooooood job!
[12:53:32] <hashar>	 (or something like  Kleine Arbeit) ? 
[12:53:35] <addshore>	 Lydia_WMDE: aude how long were we keeping the logo for? :P
[12:54:22] <Lydia_WMDE>	 addshore: wanted 48h but someone already removed it after 26
[12:54:22] <Lydia_WMDE>	 *sob*
[12:54:34] <Lydia_WMDE>	 hashar: "gute arbeit" ;-)
[12:54:57] <hashar>	 Lydia_WMDE: I really need to take some german lessons to be able to chat with you all.
[12:55:17] <aude>	 awwww
[12:55:24] <Lydia_WMDE>	 hashar: come to the office an dwork with us for a while? ;-)
[12:55:35] <aude>	 +1 :)
[12:55:44] <addshore>	 Lydia_WMDE: its back ;p
[12:55:56] <aude>	 someone put the logo back?
[12:56:03] <Lydia_WMDE>	 addshore: :D
[12:56:27] <aude>	 ah, ok :)
[12:58:19] <hashar>	 I should bring my family for a week in berlin
[13:00:15] <addshore>	 hashar: dont learn too much german or else I won't understand you ;p
[13:00:29] <hashar>	 Lydia_WMDE: that GerardM interview should be posted on the foundation blog :-]
[13:00:42] <Lydia_WMDE>	 GerardM: ^
[13:01:15] <GerardM>	 :)
[13:05:05] <GerardM>	 hashar writing on the WMF blog is writing by committee ... well written but typically dry
[13:05:13] <GerardM>	 too late
[13:07:11] <Lydia_WMDE>	 GerardM: can be republished there?
[13:07:16] <Lydia_WMDE>	 wouldn't be the first time
[13:08:15] <GerardM>	 I am happy when it is 
[13:09:35] <GerardM>	 <grin> the 99% uptime picture is not freely licensed ... but apart from that it is fine
[13:09:47] <hashar>	 I am not sure who can get it pushed on wmf blog though :/
[13:09:55] <hashar>	 but that definitely could use a wide audience. 
[13:10:09] <hashar>	 """ Commons file metadata as Wikidata. On Wikidata itself, or added to Commons itself. """
[13:10:13] <hashar>	 THAT would be awesome :]
[13:10:30] <hashar>	 it has always killed me that we use templates / categories for metadata :-(
[13:10:30] <GerardM>	 That is what multichil is working really hard on
[13:11:46] <GerardM>	 hashar ... http://ultimategerardm.blogspot.nl/2013/10/an-unknown-woman-from-indonesia-picture.html .. all Tropenmuseum contributions now have that template
[13:12:05] <GerardM>	 he inspires other people to work on it as well
[13:12:37] <GerardM>	 <grin> it is in the pipeline ... preparations are already underway
[13:16:44] <addshore>	 why is there no 'api' keyword on bugzilla? :O
[13:17:14] <addshore>	 andre__: ^^ ? :D
[13:17:21] <aude>	 seriously?
[13:17:58] <aude>	 there is a component
[13:18:00] <andre__>	 Why would anybody need such a keyword?
[13:18:13] <andre__>	 I expect really good reasons for adding new keywords.
[13:18:52] <andre__>	 And what's not API nowadays? :P It's like people asking me for a "usability" keyword which I'm 102% against. ;)
[13:19:03] <addshore>	 because this is just ugly :/ https://bugzilla.wikimedia.org/show_bug.cgi?id=39174
[13:19:42] <hashar>	 ahhh one job fixed https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/3843/console
[13:20:12] <aude>	 hashar: i poked ryan about the ldap group
[13:20:15] <andre__>	 addshore, any real arguments?
[13:20:23] <andre__>	 "this is just ugly" doesn't mean anything to me so far.
[13:20:31] <hashar>	 aude: what did he say?
[13:20:33] <aude>	 just need to get him a list of our people and he can do it
[13:21:03] <hashar>	 aude: awesome! I think I added you to the RT ticket, so whenever that is updated I will notice it and hopefully remember to update the Jenkins security matrix.
[13:21:11] <aude>	 ok
[13:21:21] <aude>	 hopefully someone can help me retrieve my password there :)
[13:21:44] <addshore>	 andre__: my only argument is categorizationa nd making it easier to find bugs relating to the api
[13:22:00] <andre__>	 addshore, why would it be easier? I challenge that.
[13:22:34] <andre__>	 Somebody needs to tag API issues then, always, constantly. Otherwise nothing will become easier.
[13:22:52] <andre__>	 feel free to use a whiteboard entry if you want to tag reports.
[13:23:04] <andre__>	 it won't require a keyword.
[13:23:14] <aude>	 hashar: do you know who admins rt?
[13:23:31] <hashar>	 no clue
[13:23:36] <hashar>	 someone from wmf ops for sure
[13:23:49] <hashar>	 andre__: !!!!!!!!!
[13:23:55] <andre__>	 addshore: to me it sometimes feels like we categorize ourselves to death in Wikimedia Bugzilla. For no good reason, just for the sake of spending time categorizing. I really hope my impression is wrong, though :)
[13:23:59] <aude>	 i will find out because the password reminder email is unhelpful, to say the least
[13:24:32] <andre__>	 hashar: it looks like your exclamation mark key is very active today. What can I do for you? :D
[13:24:57] <hashar>	 andre__: I came across a tiny soft that produce Kanban columns of cards from bugzilla bugs :-D
[13:25:00] <andre__>	 aude: RT admin? WMF Operations team.
[13:25:09] <andre__>	 hashar, uh nice
[13:25:13] <aude>	 andre__: hmmm, ok :)
[13:25:20] <aude>	 i can ask around
[13:25:22] <andre__>	 aude: #wikimedia-operations
[13:25:30] <aude>	 yeah
[13:25:30] <andre__>	 aude, depends on what you need
[13:25:49] <aude>	 password reset and someone to tell me the password :)
[13:25:50] <hashar>	 andre__: https://github.com/EvanOman/KanbanBoard  , no clue if we want to use it, but a prerequisite is to add a "whichcolumn" "Drop Down" field.   I was wondering if you had a preprod / labs instance of bugzilla to try it out there :]
[13:26:11] <andre__>	 aude: if I was you I wouldn't ask who is admin, I'd instead express what you'd like to get done/fixed in RT :)
[13:26:28] <andre__>	 hashar, boogs.wmflabs.org
[13:26:35] <andre__>	 thanks to ori
[13:26:36] <aude>	 andre__: ok :)
[13:29:18] <hashar>	 andre__: could you add a field on that dev instance ?  whichcolumn   of type "drop down" ? 
[13:36:38] <andre__>	 hashar, but what would be dropdown field values?
[13:37:07] <andre__>	 plus normally custom field names always start with "cf_"
[13:39:28] <hashar>	 andre__: ahhh 
[13:39:42] <hashar>	 andre__: will have to look at a bit more and ping you back
[13:40:06] <andre__>	 hashar, np. Or just create an account on boogs.wmflabs.org and I make you admin, or so
[13:40:18] <hashar>	 andre__: did, as  hashar@free.fr
[13:40:25] <hashar>	 andre__: thanks!
[13:41:01] <andre__>	 hashar, alright
[14:04:36] <hashar>	 I think your jobs are fixed
[14:04:53] <grrrit-wm>	 (03PS9) 10Hashar: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 (owner: 10Addshore)
[14:05:03] <addshore>	 :)
[14:06:39] <hashar>	 core is screwed though
[14:06:44] <lbenedix>	 I've seen that each edit has a comment telling what was edited... is there a list of comments generated by wikidata?
[14:06:57] <aude>	 :/
[14:07:27] <hashar>	 poor gallium is overloaded for some reason :(
[14:12:38] <GerardM>	 http://ultimategerardm.blogspot.nl/2013/10/missing-labels-in-wikidata-call-for.html PS I love the picture
[14:13:02] <hashar>	 addshore: qunit failling on https://gerrit.wikimedia.org/r/#/c/84990/
[14:13:13] <hashar>	 addshore: apparently for good reason, at least does not seem related to jenkins current issue
[14:13:36] <grrrit-wm>	 (03PS2) 10Hashar: Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore)
[14:13:44] <grrrit-wm>	 (03CR) 10Hashar: "rebased to retrigger tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore)
[14:13:52] <addshore>	 qunit still isnt fixed since we turned it on on jenkins :)
[14:14:14] <hashar>	 ahh it is non voting :]
[14:14:25] <addshore>	 [=
[14:14:27] <grrrit-wm>	 (03PS6) 10Hashar: Adding and removing claims now shows a full diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 (owner: 10Addshore)
[14:14:35] <grrrit-wm>	 (03CR) 10Hashar: "retriggering in Jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90876 (owner: 10Addshore)
[14:23:51] <hashar>	 addshore: aude: your jenkins jobs work now.
[14:23:56] <addshore>	 :D
[14:23:59] <hashar>	 but Jenkins is a bit slow right now so there will be some delay
[14:26:40] <aude>	 hashar: thanks for fixing it 
[14:26:51] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 
[14:27:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler)
[14:27:32] <hashar>	 :(
[14:27:54] <hashar>	 DanielK_WMDE_: seems https://gerrit.wikimedia.org/r/#/c/89850/6 needs a rebase as well
[14:31:04] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Make dumpJson.php robust against failures. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92644 
[14:32:21] <DanielK_WMDE_>	 hashar: yea, saw that. workign through the backlog after 10 days off
[14:34:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make dumpJson.php robust against failures. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92644 (owner: 10Daniel Kinzler)
[14:34:40] <hashar>	 :(
[14:34:58] <DanielK_WMDE_>	 o_O
[14:35:09] <hashar>	 forgot an eentry in autoloader ?
[14:35:14] <DanielK_WMDE_>	 i tested that locally... what gives?
[14:35:44] <DanielK_WMDE_>	 o_O
[14:36:01] <DanielK_WMDE_>	 that class isn't new. i guess we did forget that entry, and never noticed, because we didn't use the class
[14:36:21] <addshore>	 FATAL!
[14:36:32] <hashar>	 write a test for that class in another patchset maybe ?
[14:36:32] <DanielK_WMDE_>	 uh... it
[14:36:35] <hashar>	 that would confirm it
[14:36:44] <DanielK_WMDE_>	 nope, the entry is there. what gives?
[14:37:15] <DanielK_WMDE_>	 oh. ooohhhh. ugh. MessageReporter is in repo, not in lib.
[14:37:21] <DanielK_WMDE_>	 needs to be moved
[14:37:32] <hashar>	 \O/
[14:42:01] <grrrit-wm>	 (03PS2) 10Daniel Kinzler: Make dumpJson.php robust against failures. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92644 
[14:46:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make dumpJson.php robust against failures. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92644 (owner: 10Daniel Kinzler)
[14:46:52] <hashar>	 bahh
[14:47:10] <hashar>	 DanielK_WMDE_: you get a copy of the debug file at https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/3848/
[14:47:36] <hashar>	 might or might not help
[14:52:18] <grrrit-wm>	 (03PS1) 10Addshore: Cleanup lib/includes/serializers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92646 
[15:25:27] <lbenedix>	 I've seen that each edit has a comment telling what was edited... is there a list of comments generated by wikidata?
[15:25:52] <lbenedix>	 like /* wbsetsitelink-set:1|enwiki */ Togo
[15:30:55] <grrrit-wm>	 (03PS1) 10Aude: (bug 49434) Support diff=0 in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92648 
[15:31:37] <aude>	 lbenedix: you can look in Wikibase.i18n.php and WikibaseLib.i18n.php
[15:31:42] <liangent>	 lbenedix: grep wikibase-item-summary- Wikibase.i18n.php
[15:31:44] <aude>	 there might be old messages there, though
[16:03:17] <grrrit-wm>	 (03PS1) 10Henning Snater: Removed unnecessary nodes from "wb-statement" template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92651 
[16:03:18] <grrrit-wm>	 (03PS1) 10Henning Snater: Removed "toolbarParentSelector" option from toolbarbase widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92652 
[16:08:04] <grrrit-wm>	 (03PS4) 10Henning Snater: (hotfix) Checking for property to lock property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92634 
[16:13:57] <grrrit-wm>	 (03PS3) 10Henning Snater: Removed default event handler generation from toolbarcontroller [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92627 
[16:22:07] <grrrit-wm>	 (03PS2) 10Henning Snater: Removed unnecessary nodes from "wb-statement" template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92651 
[16:22:11] <grrrit-wm>	 (03PS2) 10Henning Snater: Removed "toolbarParentSelector" option from toolbarbase widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92652 
[16:32:40] <grrrit-wm>	 (03PS3) 10Henning Snater: Removed unnecessary nodes from "wb-statement" template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92651 
[16:33:11] <grrrit-wm>	 (03PS3) 10Henning Snater: Removed "toolbarParentSelector" option from toolbarbase widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92652 
[16:48:36] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "The database call can be mocked out, and return a string that makes the check fail, so the exception is thrown, no? I'm thinking this is a" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/92515 (owner: 10Addshore)
[17:14:50] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#73 (REL1_22 - aecfb66 : Translation updater bot): The build failed.
[17:14:50] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/REL1_22
[17:14:50] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/13069834
[20:27:44] <^d>	 aude: You still around?
[20:28:27] <^d>	 (or anyone who knows something about Wikibase\EntityView)
[20:33:15] <^d>	 Guess it's late in Berlin :)
[20:34:30] <hoo>	 21:34 :P
[20:35:05] <lbenedix1>	 is /docs/summaries.txt up to date?
[20:36:52] <hoo>	 lbenedix1: No, it's not complete
[20:37:11] <lbenedix1>	 is there a more complete list? 
[20:37:11] <hoo>	 eg. clientsitelink is missing
[20:37:27] <lbenedix1>	 or can you point me to the code where the comment is generated?
[20:37:39] <hoo>	 I doubt it, you could search the code for it, though
[20:38:24] <hoo>	 Those are parameters to the constructor of the Wikibase\Summary class
[20:40:52] <lbenedix1>	 So I need to find all occurences of Summary(...)?
[20:42:20] <hoo>	 Maybe, I'm not totally sure how the API does these nowadays, I haven't worked on the repo stuff recently, maybe it abstracts these away
[20:42:45] <hoo>	 You could also use the i18n files, those contain all (for localization)
[20:43:11] <lbenedix1>	 the \*wbsetfoobar*\ is internationalized?
[20:46:40] <hoo>	 lbenedix1: Yes, these have message keys like wikibase-item-summary-$autocomment
[20:47:19] <hoo>	 You can find those in repo/Wikibase.i18n.php ... I guess (hope) that list is complete there
[20:48:13] <lbenedix1>	 I like to know where the string in the revision table comes from
[20:48:55] <lbenedix1>	 the .i18n file references the docs/summaries.txt
[20:50:30] <hoo>	 $summary = new Summary( /* ... */ ); /* Entity change code stuff */ EditEntity::attemptSave( $summary /* ... */ );
[20:50:45] <hoo>	 lbenedix1: Like that ^
[20:51:08] <hoo>	 the strings themselves are probably defined in each API / Job module
[20:51:38] <lbenedix1>	 gnah
[21:04:44] <aude>	 hi ^d
[21:04:50] * aude  just home 

[21:05:25] <^d>	 aude: Slow function is slow :(
[21:05:26] <^d>	 http://p.defau.lt/?15emxwXHYW0zBVDy8b_IZw
[21:06:07] <aude>	 not surprised, but shall look
[21:08:04] <aude>	 this stuff is essentially equivalent to Parser.php for wikidata
[21:08:19] <^d>	 Yeah. Does it do any sort of caching?
[21:08:20] <aude>	 sure it can be optimized
[21:08:29] <aude>	 yes, memcached
[21:08:42] <^d>	 Hmm...wonder what our cache hit rate is here.
[21:08:56] <aude>	 memcached caches the entity blob (json)
[21:09:14] <aude>	 what are you using the html for? are you actually putting that in the index?
[21:10:06] <^d>	 I'm calling getParserOutput() because I need stuff like links, categories, etc.
[21:10:06] <aude>	 we are not using parser cache 
[21:10:09] <aude>	 but should bw
[21:10:15] <aude>	 be
[21:10:16] <aude>	 ok
[21:12:22] <^d>	 Anyway, I dunno if there's any low hanging fruit for you guys. But would be a nice place to optimize if you can :)
[21:12:23] <aude>	 might be :)
[21:13:47] <aude>	 parser cache would be good place to start, but then it is complicated with wikidata as multilingual, lang fallback etc
[21:17:16] <hoo>	 aude: Parser cache can be split by user lang... that's not recommended, but it works (the Translate and InputBox extensions do that)
[21:19:10] <aude>	 hoo: maybe
[21:21:59] <lazowik>	 lbenedix1: the summary written to db is created with Summary class
[21:22:10] <lazowik>	 but as it has some low chars limit
[21:22:15] <lazowik>	 (around 250?)
[21:22:17] <hoo>	 (09:50:30 PM) hoo: $summary = new Summary( /* ... */ ); /* Entity change code stuff */ EditEntity::attemptSave( $summary /* ... */ );
[21:22:21] <lazowik>	 yep
[21:22:33] <hoo>	 lazowik: Entire thing mustn't have more than 255 bytes AFAIR
[21:22:40] <lazowik>	 there is a hook that expands stuff between /* */
[21:23:00] <lazowik>	 so it's unfortunately hackish :(
[21:23:17] <aude>	 we can't say everything that changed
[21:23:34] <aude>	 it if has to truncate, that is fine
[21:23:40] <lbenedix1>	 the interesting thing ist what type of edit was performed
[21:23:57] <lbenedix1>	 added claim, added reference, changed label, ...
[21:24:43] <hoo>	 You can parse that out of them, but not in super consistent way, only the module names are consistent /* moduleName:... */
[21:25:09] <lbenedix1>	 and I've seen some edits without a summary
[21:27:06] <lazowik>	 lbenedix1: the magic is hapening here: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/Wikibase.hooks.php#L996
[21:28:28] <lbenedix1>	 I found an edit with a summary I dont understand: https://www.wikidata.org/w/index.php?title=Q2487803&action=history
[21:28:39] <lbenedix1>	 the comment is "can combine with Upper Egypt Q203751"
[21:29:10] <lbenedix1>	 in this edit a link was added
[21:47:39] <lazowik>	 hmm
[21:47:54] <lazowik>	 maybe there is a way to skip auto summary?
[21:47:55] <lazowik>	 dunno
[21:48:03] <lazowik>	 aude: ^?
[21:50:03] <lazowik>	 'night!
[21:50:13] <grrrit-wm>	 (03CR) 10Aude: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler)
[22:09:08] <grrrit-wm>	 (03PS7) 10Aude: [bug 49952] Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler)
[22:09:23] <grrrit-wm>	 (03PS8) 10Aude: [bug 49952] Consolidate SerializationOptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler)
[22:09:37] <grrrit-wm>	 (03CR) 10Aude: "rebased in patchset 7" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89850 (owner: 10Daniel Kinzler)
[22:12:48] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "this has substantial conflicts with https://gerrit.wikimedia.org/r/#/c/89850/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92646 (owner: 10Addshore)
[22:29:17] <grrrit-wm>	 (03CR) 10Aude: "in both these cases, the labels get run through Sanitizer::removeHTMLtags (via OutputPage::setPageTitle) which escapes any possible <scrip" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92308 (owner: 10Henning Snater)