[00:02:13] Sven_Manguard: that diagram was made before the user interface was written :) [00:08:21] so, fix it~ [00:08:23] :P [00:51:01] (03PS1) 10Shirayuki: Update comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94080 [01:02:04] (03CR) 10Aude: [C: 032] Update comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94080 (owner: 10Shirayuki) [01:05:50] (03Merged) 10jenkins-bot: Update comments for grep [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94080 (owner: 10Shirayuki) [01:26:37] anyone know if the babelbox data that wikidata uses for the "In other languages" section is accessible from lua? or js? [01:29:05] JS yes [01:29:11] you can just get the content of the users page [01:29:22] Lua, idk how you'd do it since you don't have the user's name. [01:30:44] the user's interface language can be accessed with {{int:lang}}, but I can't figure out a way to get their other possible languages. [01:30:45] 10[2] 04https://www.wikidata.org/wiki/Template:int:lang [01:31:52] would be neat if the babel extension had a lua module [01:33:24] quite. I imagine it would wreak havoc on the caching, but it would be pretty useful... [01:34:57] The i18 modules on Wikidata don't have any way to figure out any fallback languages other than the most likely fallbacks for the interface language, leaving some content English for some users when it would be more useful for it to be in another language. [01:35:11] heh, the list of properties already is totally uncached. [01:35:32] it is? [01:36:03] it never finishes loading [01:36:08] the end of the page is full of script errors [01:36:29] because it goes over the max lua time [01:36:53] ah. [07:49:11] good morning [07:56:42] Lydia_WMDE: will the metrics meeting this evening be recorded? [08:26:18] who can help me implement this https://en.wikipedia.org/wiki/MediaWiki:Wdsearch.js on the oc.wikipedia... [08:29:10] what I need is a step by step explanation on how this is done as well [08:32:02] (03CR) 10Henning Snater: "I guess I am fine with the change as well then. Right now, Displaying the boundaries will look quite ugly in the UI though since DecimalVa" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 (owner: 10Daniel Kinzler) [08:33:39] lbenedix: yes [08:35:14] legoktm: news re more lua work coming soon hopefully :) [08:35:15] great [08:43:15] Lydia_WMDE what kind of Lua work would that be ? [08:43:37] GerardM: there will be a call for feedback to determine what would be most useful [08:43:50] details not decided until that is done [08:43:50] :) [08:43:59] who will be doing that work ? [08:44:06] the wm.de team ? [08:44:42] yes [08:51:32] can we have a page with requests for LUA work ? [08:51:53] for you to decide in the paper cut kinda way ... [08:53:05] (03CR) 10Henning Snater: [C: 04-1] "Just discovered that QuantityValue::newFromDecimal() removed in this change set is still in use in Wikibase extension's WikibaseDataTypeBu" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 (owner: 10Daniel Kinzler) [08:53:11] PS if this work is also in the direction of info boxes ... the UI guys are working on it ... [08:58:40] (03CR) 10Henning Snater: [C: 04-1] ""+3.025±1" is formatted "3±1". "+3.025±1.000" results in the same output." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [09:45:10] to admins please see https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#linkificationNLI [09:53:41] I am waiting for weeks for https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#linkification_for_new_property_NLR_.28Romania.29_identifier please go ahead [09:57:27] Tobi_WMDE: branches made [09:58:00] we can use extensions/Wikidata if you want.... i'm getting it setup on beta today, probably [09:58:37] addshore's thing can be cherrypicked, if important (i think so) [09:59:20] [travis-ci] wikimedia/mediawiki-extensions-DataTypes#39 (mw1.23-wmf3 - d23dc14 : aude): The build passed. [09:59:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataTypes/commit/d23dc1481543 [09:59:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataTypes/builds/13624656 [09:59:42] yay, tests pass! [10:01:57] [travis-ci] wikimedia/mediawiki-extensions-Diff#89 (mw1.23-wmf3 - a4286ae : aude): The build passed. [10:01:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Diff/commit/a4286ae3dd17 [10:01:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Diff/builds/13624662 [10:02:12] (03PS3) 10Addshore: Add validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 [10:03:56] [travis-ci] wikimedia/mediawiki-extensions-DataValues#276 (mw1.23-wmf3 - e86a57d : aude): The build passed. [10:03:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/commit/e86a57df1214 [10:03:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/13624670 [10:04:53] [travis-ci] wikimedia/mediawiki-extensions-WikibaseDataModel#119 (mw1.23-wmf3 - b25d316 : aude): The build passed. [10:04:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseDataModel/commit/b25d316454a6 [10:04:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseDataModel/builds/13624666 [10:11:02] aude: Is Lydia already in the office? [10:11:29] I need someone to proofread a text asking people to re license stuff and I don't want to mess on taht :D [10:11:39] she is [10:12:37] (03Abandoned) 10Aude: Check Wikidata build install path for dispatchChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [10:13:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1130 (mw1.23-wmf3 - b4fc1c0 : aude): The build passed. [10:13:33] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/b4fc1c0c3c19 [10:13:33] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13624705 [10:16:11] aude: PMed her, let's see :) [10:16:31] she is busy right now but should see it soon [10:16:40] Not this urgent :D [10:16:43] k [10:32:19] hi DanielK_WMDE_ ... ich denke, ich werde heute mal damit beginnen das linkItem widget zu refactoren [10:33:40] "Uncaught exception 'Exception' with message 'WikibaseLib depends on the DataTypes extension" :/ [10:33:48] wtf [10:33:51] eek [10:34:28] hoo: can you make a regression test for whatever triggeres this? we have been starting to use cucumber... ask tobi about it [10:35:20] DanielK_WMDE_: meh... my fault... I had it cloned on my personal system, but apparently I forgot to do it on my test server -.- [10:35:43] * aude installs all the extensions in gerrit :) [10:36:08] aude: Hope you have an SSD... or a lot of patience [10:36:13] lol [10:41:42] (03CR) 10Daniel Kinzler: "@henning:" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [10:51:51] Lydia_WMDE: there's quite a few "smalish" things missing for quantities. See https://bugzilla.wikimedia.org/buglist.cgi?list_id=248134&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=quantityvalue&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&component=WikidataClient&component=WikidataRepo&product=MediaWiki& [10:51:53] product=MediaWiki%20extensions [10:51:59] ugh, i hate bugzilla urls [10:52:12] ) [10:52:12] Lydia_WMDE: just look for the "quantityvlaue" whitboard tag [10:52:13] :) [10:54:33] aude: Do you agree it's a good idea to factor out some data logic from linkItem and create a wikibase.client.linkWithEntity module from that? [10:55:18] yes [10:55:24] :) [11:31:54] Tobi_WMDE: Do we have something like (Simple)SiteLink in JS? [11:35:44] (03PS9) 10Daniel Kinzler: Introducing QuantityParser and DecimalParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 [11:44:53] hoo: as far as I know not [11:45:50] Tobi_WMDE: Ok, just going to keep using plain strings for title and site id, then [12:37:30] Hi everybody. I'm helping a new contributor to a very small Wikipedia and "Edit links" for Wikidata doesn't show for her. [12:37:41] I see it when I'm logged in, but she doesn't see it [12:37:48] It is only visible where it has already been added [12:37:51] but not on new pages [12:38:05] I'm guessing this should be a FAQ, but I haven't found any answer/solution/workaround yet [12:38:07] Any advice? [12:40:02] ffww: which page are you talking about? [12:43:24] She's probably using an ancient IE version without CORS supporst [12:43:28] * support [12:44:10] lbenedix: This one, for example: https://tn.wikipedia.org/wiki/Rodipoto [12:44:36] ffww: Is she using IE older than version 10 maybe? [12:44:54] very likely [12:45:10] it was IE [12:45:47] Old versions of IE don't support the techniques we need for the widget so that it's impossible to make the widget work in those. [12:45:52] I think this page has no Wikidata Item that link to it [12:46:00] lbenedix: Doesn't matter [12:46:16] ffww: Can she maybe switch over towards Firefox or Chrome or ...? [12:46:19] I see. Is it a matter of the theme? [12:46:27] there is no "edit links" link in my chrome [12:46:35] I did install Firefox, but having a different browser was already quite a leap from comfort [12:46:55] http://lbenedix.monoceres.uberspace.de/screenshots/36903rpg31_2013-11-07_13.46.42.png [12:47:28] lbenedix: there are no links, but I get "Add languages" (I'm using Firefox here) [12:48:03] lbenedix: Apparently nothing created an item for that page, yet... if you login, you can use the widget though, it works even if the page has no item [12:48:29] you have to be logged in to add a link? [12:48:42] this is strange [12:48:53] lbenedix: Not really, but to use the widget to do it directly from Wikipedia [12:49:09] people were afraid that the widget would attract vandals, that's why ... [12:49:20] have you tested it? [12:49:47] lbenedix: Tested what? The vandalism rate? [12:49:57] yes [12:50:01] Nope [12:52:55] btw. I've never seen this widget, but I planned to implement a similar dropdown-thingy for selecting the page here: https://www.wikidata.org/wiki/Special:EntitiesWithoutDescription [12:53:15] and ...WithoutLabel [12:53:52] lbenedix: You probably want jquery.wikibase.siteselector [12:54:00] which is in lib [12:54:37] one of the problems I have with this specialpages is, that they say "Language" but mean "Language-Code" [12:55:07] that was part of the initial language vs. site id mess we had [13:03:08] Hi please confirm the first link at https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#linkificationNLI can you see a record for Singer, Isaac Bashevis,1904-1991 If so just write right for me at the end of the section [13:06:36] GerardM ping. Can you give me a hand please? [13:11:35] gangleri_back .... applause :) [13:14:21] Tobi_WMDE: https://github.com/mkroetzsch/wda [13:15:04] wikidata-analytics [13:17:40] (03PS6) 10Daniel Kinzler: Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 [13:19:09] Hi GerardM. I am working quite hard with librarries but a few people care about internationalization like links to Flemish libraries to Vatican etc. see the links at https://www.wikidata.org/?curid=16717382#support [13:20:35] Hey guys, wonderful that we finally got Commons support! [13:20:54] I'm just wondering, if i add a Commons page to a Wikidata item can i simply remove all of the interwiki links from the original page? [13:22:20] (03CR) 10Daniel Kinzler: "Note: handling of quantity values could still use several improvements, especially on the browser side. I have marked the relevant tickets" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [13:23:54] huskyr: look at the links to wikipedia on the item page. if these are the links you want to see as language links on the page on commons, then yes. [13:24:20] with all the gallery vs. category confusion, it's not clear that this would always be the case [13:24:20] Ah yes, nice. I'm doing it right then. [13:24:56] Are there any plans for bot integration? It would make sense to delete all the old interwiki cruft whenever a new Commons page is added in Wikidata. [13:25:57] huskyr: generally, the bots would just do both for a large set of pages [13:26:15] DanielK_WMDE__: okay. Makes sense. [13:26:26] best ask multichill or merl about that kind of thing [13:27:52] okay, thanks! [13:30:37] wikidata-analysis [13:30:40] Tobi_WMDE: ^^ [13:35:59] (03PS10) 10Henning Snater: Introducing QuantityParser and DecimalParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 (owner: 10Daniel Kinzler) [13:37:47] (03CR) 10Henning Snater: [C: 032] Introducing QuantityParser and DecimalParser [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/89849 (owner: 10Daniel Kinzler) [13:38:32] (03PS7) 10Henning Snater: Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [13:45:58] (03PS8) 10Henning Snater: Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [13:46:55] (03CR) 10Henning Snater: [C: 032] Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 (owner: 10Daniel Kinzler) [13:47:15] (03PS4) 10Henning Snater: Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 (owner: 10Daniel Kinzler) [13:48:04] (03CR) 10Henning Snater: [C: 032] Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 (owner: 10Daniel Kinzler) [13:52:45] (03Merged) 10jenkins-bot: Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 (owner: 10Daniel Kinzler) [13:57:34] Working on Wikidata again: A good reason to open one of the few club mates I still have around :D [13:57:44] :) [14:10:30] (03CR) 10Tobias Gritschacher: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 (owner: 10Addshore) [14:11:20] aude: The linkWithPage module could in theory link any pages, no matter how many links they each have :) [14:11:39] But I guess the community would kill us if we start merging items around more or less blindly [14:12:02] hmmmm [14:12:27] The merge api can merge items just fine, but it can't fix they're usages across the whole wiki [14:12:29] sadly [14:13:32] that makes the whole thing kind of inflexible [14:14:12] (03PS4) 10Addshore: Add validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 [14:16:28] (03CR) 10Henning Snater: [C: 032] Set explicit direction for wb-entity-undefinedinfo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93518 (owner: 10Amire80) [14:20:17] (03CR) 10Daniel Werner: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 (owner: 10Bene) [14:25:02] (03CR) 10Addshore: [C: 04-2] "investigating a deeper issue" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 (owner: 10Addshore) [14:28:48] (03PS2) 10Henning Snater: Correct and simplify direction setting for propertyedittool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93512 (owner: 10Amire80) [14:29:13] (03CR) 10Henning Snater: [C: 032] Correct and simplify direction setting for propertyedittool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93512 (owner: 10Amire80) [14:29:42] gangleri_back: you did not ask a question and the information on your user page is incomprehensible [14:30:31] please provide me with a question and information that I do understand [14:30:54] Just having trouble with : I posted a note at https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#id_mismatch [14:32:15] Gerard GerardM Please take some time to llok at other proposals from https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control Thanks in advance! [14:33:16] my point of view is that authority control identifiers are ok to have... HOWEVER, I do not want them to be in my face all the time [14:33:48] that is a style issue, not about Wikidata content [14:34:14] When you consider VIAF, it does bring multiple other source control system together ... it however does not always maintain all its records [14:34:28] AC should be grouped and people shold decide temself if they want to see all or not [14:34:43] yep I do want to toggle them on / off [14:34:50] (03Merged) 10jenkins-bot: Correct and simplify direction setting for propertyedittool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93512 (owner: 10Amire80) [14:34:54] but that is future functionality [14:35:13] it does not bother me overly [14:35:59] as to proposing properties, as far as I am concerned that is a broken process [14:36:06] but national librarioes as the newly added linkification to NLR (Romania) identifeir can control themself which authors are in **theri** wiki not necessary at Library of Congress, in Germany etc. This is internationalization not hegemonism [14:36:42] I have an appointment at my doctor need to leav e soon [14:37:08] gangleri_back: I have waited for months on new properties that are easy to create and it does not happen .... apathy or whatever ... I do not know [14:37:54] and yes, Romanians Egyptians et al I want desperately to be presented in source control systems [14:38:20] it proves notability [14:38:25] to some extend [14:44:23] (03PS5) 10Addshore: ReAdd validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 [14:44:45] (03CR) 10Addshore: ReAdd validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 (owner: 10Addshore) [14:50:02] GerardM https://www.wikidata.org/wiki/Q38049 is a huge page It should be possible to **implode the awards**. BTW: She was a theatcher at thy Gamnasium I used to pe previously. [14:50:21] **Gymnasium** [14:53:43] (03CR) 10Daniel Kinzler: "Looks good, but I think it would be nice to have tests that check that the right hook (only) gets called under the right circumstances." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93959 (owner: 10Jeroen De Dauw) [14:54:07] maybe High school in other countries [14:57:34] (03CR) 10Daniel Kinzler: "addendum: i guess doing this in EntityContentTest would be fine." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93959 (owner: 10Jeroen De Dauw) [14:59:29] I found two edits to make :) [14:59:44] ^^ gangleri_back [15:05:41] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92648 (owner: 10Aude) [15:06:53] (03PS6) 10Daniel Kinzler: Accept both types of lists when deserializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93044 (owner: 10Addshore) [15:08:18] (03CR) 10Daniel Kinzler: [C: 04-1] "the follow-up containing the requested tests currently fails, so there's no way to know whether the logic in this patch is ok." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 (owner: 10Addshore) [15:10:58] (03CR) 10Daniel Kinzler: [C: 032] Implement List Serializer and Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 (owner: 10Addshore) [15:14:25] (03Merged) 10jenkins-bot: Implement List Serializer and Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 (owner: 10Addshore) [15:23:36] (03PS1) 10Addshore: Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94135 [15:25:49] (03CR) 10Addshore: [C: 04-1] "this should not be merged until I work out why this passes without the change in data model" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93044 (owner: 10Addshore) [15:26:41] (03PS1) 10Tobias Gritschacher: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 [15:27:54] (03PS2) 10Addshore: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [15:31:23] (03CR) 10jenkins-bot: [V: 04-1] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [15:32:09] (03PS1) 10Henning Snater: Fixed Reference and Statement QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94139 [15:32:39] (03CR) 10Daniel Kinzler: [C: 032] ReAdd validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 (owner: 10Addshore) [15:35:26] Tobi_WMDE: there's a bunch of follow up things to do for the quantity value: https://bugzilla.wikimedia.org/buglist.cgi?status_whiteboard=quantityvalue&resolution=--- [15:35:40] Nemo_bis I will look tonight [15:35:43] i'd like to add some of those to the sprint (which is otherwise somewhat empty for me) [15:35:48] what do you think? [15:37:39] (03Merged) 10jenkins-bot: ReAdd validation for wbsetreference.... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93944 (owner: 10Addshore) [15:38:09] (03PS1) 10Addshore: ReAdd validation for wbsetreference.... [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94141 [15:38:58] (03CR) 10Tobias Gritschacher: [C: 032] Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94135 (owner: 10Addshore) [15:39:12] (03Merged) 10jenkins-bot: Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94135 (owner: 10Addshore) [15:39:22] (03PS3) 10Addshore: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [15:39:33] (03CR) 10Tobias Gritschacher: [C: 032] ReAdd validation for wbsetreference.... [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94141 (owner: 10Addshore) [15:40:09] (03CR) 10jenkins-bot: [V: 04-1] ReAdd validation for wbsetreference.... [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94141 (owner: 10Addshore) [15:42:35] (03CR) 10jenkins-bot: [V: 04-1] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [15:46:28] (03PS4) 10Tobias Gritschacher: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 [15:49:16] (03CR) 10jenkins-bot: [V: 04-1] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [15:51:41] addshore: JeroenDeDauw: any of you here? [15:51:46] pong [15:51:56] hey! [15:52:02] badge duplicates [15:52:08] indeed :O [15:52:13] they should be romevoed in data model? [15:52:18] *removed [15:52:58] and is array_values ok for that? [15:53:38] depends if your working on the serilization or the object itself [15:53:54] the datamodel shouldnt allow 2 badges to be the same [15:54:16] but it needs to compare the objects as 'q1' !== 'Q1' [15:54:22] lazowik: yeah, this uniqueness is part of the domain model, so should be handled by the SiteLink class [15:54:27] mhm [15:54:30] and on object [15:54:39] is ItemId comparable? [15:54:44] yup [15:54:49] great :) [15:54:56] should be an easy fix then [15:55:18] lazowik: My comment just applies to the instance code of the class [15:55:22] Not the static crap in it [15:55:37] ***** that should really not be in there [15:55:44] hmm? [15:55:47] I'm lost! [15:55:57] lazowik: the newFromArray should not be in there [15:56:00] ah [15:56:04] right [15:56:12] I can move that to Item [15:56:13] lazowik: I'll be fixing that soonish, together with other such static cod ein datamodel [15:56:32] err? That will make things worse? ;p [15:56:45] ... [15:56:57] sorry, not a pro coder ;) [15:57:25] lazowik: to enforce the uniqueness on the domain model, you can enahnce the check for badges in the constructor [15:57:32] mhm [15:57:38] And throw an error if there is a duplicate [15:57:52] that harsh? [15:58:38] Perhaps [15:58:52] Just ignoring the potential error silently is nasty [15:59:06] It assumes all users want this to happen [15:59:19] If you have one for which this is not the case, you have a problem [15:59:50] ok [15:59:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1135 (master - 58af234 : jenkins-bot): The build was broken. [15:59:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/153c35bca4f3...58af234cba4a [15:59:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13639240 [16:00:05] lazowik: I have no strong objection against doing that however [16:00:15] If I had to choose, I'd pick doing the strict thing [16:00:29] And putting the removing of dups in the deserializer [16:00:46] JeroenDeDauw: actually if I recall correctly I set api param to not allow duplicates [16:00:57] addshore: ObjectComparerTest \o/ [16:00:57] (ofc. it fails on q1 vs Q1 [16:01:17] so I'll go with error [16:01:31] lazowik: so what is the problem with being strict then? [16:01:40] none :) [16:01:45] What can happen is that a lot of different users will then need to do the check tehmselves [16:02:07] If this ends up being a lot of users, and all of them need this behaviour, then I'd better be in the model [16:02:24] Though it is not clear this is going to be the case [16:02:56] I'm going now to throw InvalidArgumentException in data model [16:03:01] and api error in api [16:03:15] that's ok? [16:04:16] hmm, I don't check for any duplicates in api [16:07:16] (03PS1) 10Addshore: Reduce ResultBuilder constructor to 2 usages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94145 [16:07:17] lazowik: the error should not be thrown in our typical workflow [16:07:30] from ui? [16:07:32] it won't [16:07:33] ie, the deserialization code should already remove the duplicates [16:07:53] there are no badges for now [16:07:55] Or if we want to be strict to the end user, the check should happen in the API, and an error should be thrown there [16:08:02] yep [16:08:20] Should not rely on the check in the datamodel to throw the exception and then catch it all the way in the presentation layer [16:09:09] lazowik: before the check goes into the SiteLink class, we should also make sure this does not cause problems. If we already have siteslinks with duplicate badges stored, we sould be able to deal with those somehow [16:09:29] JeroenDeDauw: there is no way to store badges for now :) [16:09:34] s/store/add [16:10:12] JeroenDeDauw: um, ApiBase::PARAM_ALLOW_DUPLICATES does just $value = array_unique( $value ); [16:11:28] (03CR) 10Daniel Kinzler: [C: 032] Reduce ResultBuilder constructor to 2 usages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94145 (owner: 10Addshore) [16:11:30] JeroenDeDauw: and as there are no badges in the whole world od wikibase I don't need to add duplicates removing to deserialization? [16:12:28] JeroenDeDauw: maybe throw error in data model but just remove duplicates silently in api? [16:12:54] otherwise bots e.g. adding a single badge would need to check first if it's already there [16:13:04] that's x2 api calls [16:13:11] lazowik: depends on the API module I guess [16:13:22] And I don't have a strong opinion on the API thing anyway [16:13:27] addshore: ? [16:14:24] lazowik: duplicate value check would work as I could pass in Q2|q2 which I did [16:14:30] but these are not duplicate values [16:14:39] I know [16:15:08] the thig is what to do in api: remove duplicates silently, or fail with api error? [16:15:51] fail with an error [16:15:57] make a method for validataBadges or something [16:16:00] [= [16:16:04] *validate [16:17:37] "firstSite = wb.getSite( self.firstSiteId ), secondSite = wb.getSite( self.firstSiteId );" well... :P [16:18:17] :O [16:18:21] should I care more for time or memory? [16:19:38] lazowik: that really depends :) [16:19:53] well, I don't expect millions of badges [16:19:59] addshore: http://www.lieferando.de/lieferservice-burger-time-berlin#!cart [16:20:05] Abraham_WMDE: DanielK_WMDE ^ [16:20:15] * aude pay in bitcoins [16:21:37] (03Merged) 10jenkins-bot: Reduce ResultBuilder constructor to 2 usages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94145 (owner: 10Addshore) [16:21:43] aude: send all of your bitcoins to me, you are all thinking they will be worthless anyway [16:21:59] JeroenDeDauw: not today, thanks [16:22:04] :) [16:22:49] I always wonder what will keep the mining alive by the time it wont gain (many) new bitcoins [16:22:57] where's the motivation for mining then? :P [16:23:05] I mean in several years [16:24:57] they will be worth more ;p [16:26:08] addshore: Isn't there a point there no one can't go on mining anymore as everything has been mined so far (as you can only fraction up a bitcoin into n units) [16:26:33] - no [16:26:33] 04Error: Command “no” not recognized. Please review and correct what you’ve written. [16:26:40] I must not use no double negation :P [16:26:52] :D [16:38:34] (03PS1) 10Aude: Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94151 [16:39:01] (03PS1) 10Aude: Fixed Reference and Statement QUnit tests [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94152 [16:39:30] (03CR) 10Aude: [C: 032] Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94151 (owner: 10Aude) [16:39:37] (03PS1) 10Addshore: Allow comparison through equals method if exists [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94153 [16:39:51] (03CR) 10Aude: [C: 032] Fixed Reference and Statement QUnit tests [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94152 (owner: 10Aude) [16:40:25] (03Merged) 10jenkins-bot: Fix pass by ref in object comparer and add tests [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94151 (owner: 10Aude) [16:40:34] (03PS1) 10Addshore: Allow comparison through equals method if exists [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94154 [16:40:37] aude: ^^ [16:40:51] (03PS1) 10Aude: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94155 [16:40:58] addshore: huh? [16:41:10] (03CR) 10jenkins-bot: [V: 04-1] Fixed Reference and Statement QUnit tests [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94152 (owner: 10Aude) [16:41:45] aude: Should I bump versions to mw1.23-wmf3? [16:42:48] * Reedy goes with yes [16:42:49] (03PS7) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 [16:43:03] (03CR) 10Aude: [C: 032] Allow comparison through equals method if exists [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94153 (owner: 10Addshore) [16:43:07] Reedy: sure [16:43:19] if you wait 5 min, we'll have cherry picks in [16:43:51] I can change make-wmf-branch now though ;) [16:43:55] yes [16:44:20] * aude flooding jenkins [16:44:37] (03CR) 10jenkins-bot: [V: 04-1] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94155 (owner: 10Aude) [16:45:13] (03CR) 10Aude: [C: 032] Allow comparison through equals method if exists [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94154 (owner: 10Addshore) [16:45:52] aude: https://gerrit.wikimedia.org/r/#/c/94155/ should pass once that is in [16:45:57] yay! [16:46:13] (03Merged) 10jenkins-bot: Allow comparison through equals method if exists [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94153 (owner: 10Addshore) [16:46:22] (03Merged) 10jenkins-bot: Allow comparison through equals method if exists [extensions/WikibaseDataModel] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94154 (owner: 10Addshore) [16:46:41] (03CR) 10Aude: [C: 032] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94155 (owner: 10Aude) [16:47:19] (03CR) 10jenkins-bot: [V: 04-1] Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [16:48:51] * aude shall just approve everything [16:49:10] hi Lydia_WMDE! (Sumana here) [16:49:18] hi brainwane ! [16:49:19] Hi DanielK_WMDE! [16:49:22] Hi Katie :-) [16:49:27] how's your time off? [16:49:27] (03CR) 10jenkins-bot: [V: 04-1] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94155 (owner: 10Aude) [16:49:30] It's a brainwane [16:49:37] Hacker School is fantastic. I'm loving it. [16:49:39] brainwane: hey! :) [16:49:41] Hiya Jeroen! [16:49:42] awesome :) [16:49:51] :d [16:49:52] * DanielK_WMDE waves to brainwane [16:50:06] I arrive tomorrow morning in Berlin for the conference, and my flight lands at like 9am, so I was wondering whether it would be cool if I came to the WMDE office and worked from there for part of Friday? [16:50:12] sure [16:50:16] (03PS5) 10Addshore: Fix comparison of objects in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94137 (owner: 10Tobias Gritschacher) [16:50:16] * aude says yes [16:50:24] brainwane: that should be cool, yes [16:50:38] brainwane: we have some free desks in the wikidata corner [16:50:50] Indeed! [16:51:00] hi brainwane :D [16:51:02] addshore: do you want to approve things in correct order https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Wikibase,n,z [16:51:04] Thanks! I will probably do that, then. [16:51:05] ? [16:51:15] Hi hoo! Will I see you tomorrow as well, then, if I come into the office? [16:51:34] brainwane: No, I'm working from home ;) :/ [16:51:38] aude: http://www.harihareswara.net/ces.shtml is where I've been blogging about my Hacker School experiences. I'm learning a lot. [16:51:47] cool [16:52:06] oooh, python [16:52:09] I'm also brainwane on GitHub in case you want to see my crappy code [16:52:18] * aude sure it's not crappy [16:52:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1136 (master - 05ff484 : addshore): The build was fixed. [16:52:23] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/58af234cba4a...05ff4845d604 [16:52:23] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13641666 [16:52:29] O_o [16:53:36] brainwane: blue hair! [16:53:47] (03CR) 10Addshore: [V: 032] Fix comparison of objects in ClaimDiffer [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94155 (owner: 10Aude) [16:53:56] I've gotten several folks here to take a look at Wikidata and use it as a potential data source for their projects :-) or otherwise play with the MediaWiki API, especially re drawing from Wikidata [16:54:08] DanielK_WMDE: yes! it's fun [16:54:13] We link pages in Diffs now? That's super cool :) [16:54:36] :D [16:55:08]