[00:00:24] (03CR) 10Addshore: [C: 032] Remove some silly usages of newFromNumber [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95274 (owner: 10Jeroen De Dauw) [00:00:28] haha [00:00:32] JeroenDeDauw: gets another +6 :d [00:01:08] :D [00:02:31] addshore: still at the office? [00:02:36] yup [00:02:51] go home! :) [00:02:55] cant yet [00:02:58] 1 more thing to do :D [00:03:02] :( [00:03:11] also 'ldaplist -l group wmde' got fixed :D [00:03:25] nice [00:06:41] (03Merged) 10jenkins-bot: Remove some silly usages of newFromNumber [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95274 (owner: 10Jeroen De Dauw) [00:10:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1199 (master - eca73d5 : Addshore): The build is still failing. [00:10:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c41bd6a2e481...eca73d5e95a2 [00:10:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13943749 [00:10:31] moo [00:10:59] you're gonna have to move travis-ci to the other channel eventually [00:11:46] I have never understood why it makes each message 3 lines...... [00:12:05] im sure we invented this thing call short urls a while back... [00:16:32] * aude thinks travis could at least join and stay [00:16:38] no rejoins [00:20:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1200 (master - a92ffe0 : jenkins-bot): The build was fixed. [00:20:02] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/eca73d5e95a2...a92ffe0ca667 [00:20:02] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13944052 [00:42:14] aude: indeed, travis actually spams 5 lines each time :P [00:42:19] join message message message part [00:45:33] addshore: https://travis-ci.org/JeroenDeDauw/DataValuesCommon/jobs/13945367 [07:46:10] huh, no grrrit-wm [09:02:40] (03PS2) 10Aude: Add languageLinkSiteGroup to example client settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95328 [12:20:10] (03PS2) 10Addshore: Move Getting sitelink targets to its own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95357 [12:24:07] (03CR) 10Addshore: [C: 04-2] "Please see https://gerrit.wikimedia.org/r/#/c/95357" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94679 (owner: 10Yuvipanda) [12:24:19] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [12:25:01] YuviPanda_zzz: ^^ ;p [12:26:52] he says he is away for a week and brion might help [12:27:08] -2 is harsh! [12:27:08] ahh :) [12:27:17] not harsh :P [12:27:28] I just made a patchset especially for him :D [12:27:34] ok :) [12:42:53] (03PS2) 10Addshore: Allow id and type params in wbeditentity data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [12:44:31] (03PS2) 10Addshore: Enhance api messages for bad wbeditentity data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94776 [12:47:53] hi aude. [12:48:01] Did you test Wikidata with the new ULS? [12:49:44] aharoni: yes and finding first issue [12:49:58] Special:ItemDisambiguation is broken [12:50:15] Aha! Let's see if I can reproduce. [12:51:05] it does var languages = $.uls.data.getAutonyms(); [12:51:20] i am actually not quite sure that's the only issue [12:52:42] huh it works now [12:54:46] aude: Maybe you clicked a ULS icon. It loads the modules. [12:54:53] the important thing is to test without clicking it. [12:54:55] i don't know [12:55:38] aude: what do you mean by "broken"? [12:55:40] JS errors? [12:56:09] i was [12:57:57] I don't see any now. [12:58:17] id you see any on page load? [12:58:21] s/id/did/ [12:58:57] need minute [12:59:40] if ( $.uls !== undefined ) { alert( 'loaded' ); } else { alert( 'not loaded' ); } [12:59:43] * aude gets not loaded [12:59:55] i am logged out though [13:00:10] could be it was already broken before [13:01:31] no uls if i login [13:02:54] aharoni: if i checkout some earlier commit, then it is there [13:03:19] so when is it broken: logged in or logged out? [13:03:26] both [13:03:39] this special page is not critical though [13:03:52] i should just make a list and put it on, and check elsewhere [13:05:04] I don't see any JS errors, whether I am logged in or our [13:05:06] out [13:05:19] because $.uls == undefined [13:05:20] and it skips [13:05:29] you mean generally? [13:06:27] https://etherpad.wikimedia.org/p/uls-wikidata [13:12:57] if $.uls.data.getAutonyms() works now, then it should work in the future. [13:13:07] good [13:13:17] so that is not broken? [13:13:27] only loading $.uls.data [13:13:55] maybe it can be added as a conditional dependency (if there, load) [13:14:01] e.g. ULS is available [13:16:49] (03PS1) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:17:14] aude: The jquery.uls.data module should be a dependency of every module that uses its functions. [13:17:30] aharoni: we don't want to make it required [13:17:38] only soft dependency [13:17:48] Henning_WMDE: Tobi_WMDE ^ [13:18:03] aude: no problem, just make sure that it does what you want. [13:18:23] ULS is changing so that $.uls.data is not loaded by default now [13:18:54] aude: so that's the thing - it's possible that you do have ULS *installed* on the wiki, but not loaded. [13:18:57] what is the best way to have it load for the places it's used if availalbe [13:19:01] and on wikidata.org it's installed. [13:19:14] you can lazy-load it, if you wish. [13:19:15] aharoni: i rolled back my ULS a week or two [13:19:18] then it worked [13:19:37] * aude is not js expert [13:22:20] * aude knows obvious way.... add it conditionally to Resources.php, if uls is there [13:22:58] (03CR) 10jenkins-bot: [V: 04-1] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [13:30:10] aude: if I do `git grep uls.data -- *js', I actually find very little. [13:33:42] 4 places [13:38:56] aude : So, basically, if you do if conditionally as it is now, you lose the functionality, even though you don't have to lose it. [13:39:10] right [13:39:40] probably Henning_WMDE or Tobi_WMDE has better idea, but presence of ULS could be checked in Resources.php [13:40:53] aude : also, checking for $.uls is not quite right, because these are separate modules. [13:40:55] aharoni: when is the next deployment of uls? tuesday? [13:40:58] right [13:41:02] today, I think. [13:41:10] where is uls.data defined in resources? [13:41:12] that's the reason for urgency. [13:41:28] in the ULS extension, Resources.php. [13:41:31] ok, well then nothing breaks but we lose functionality [13:41:34] bad [13:41:40] Lydia_WMDE: ^ [13:42:00] * aude looking for uls.data [13:42:05] let's not lose functionality :) [13:42:13] it's cheap to not-lose it. [13:43:29] can you help me find uls.data? [13:43:59] found it [13:44:13] jquery.uls.data [13:45:15] now lets see if it all works [13:50:42] (03PS2) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:56:11] (03PS1) 10Aude: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 [13:56:20] aharoni: ^ [13:56:29] qunit tests pass, things seem fine [13:57:01] (03PS3) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [13:58:06] was my question about the badges in "links":{ "enwiki":{ "name":"Douglas Adams", "badges":[ ] } answered? [13:58:19] lbenedix: what was the question? [13:58:56] (03CR) 10jenkins-bot: [V: 04-1] Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [13:59:01] gah [13:59:04] what this is [13:59:05] :D [13:59:12] oh [13:59:13] it is not about the "excelent article" stars, it it? [13:59:20] lbenedix: its an array for storing badges [13:59:27] what is a badge? [13:59:29] ERROR: Could not clone repository [13:59:37] * aude thinks jenkins is ill today [13:59:40] or gerrit [14:00:01] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/4362/console [14:00:17] hah [14:00:29] * aude uses my superpowers to rebuild the job [14:00:49] https://en.wikipedia.org/wiki/Japanese_battleship_Haruna has a star for vi, but I cant see it here: https://www.wikidata.org/wiki/Special:EntityData/Q1066681.json [14:00:50] lbenedix: https://bugzilla.wikimedia.org/show_bug.cgi?id=40810 [14:01:11] the feature isnt ready yet [14:01:14] so its not implemented... [14:01:15] okay [14:01:20] (03CR) 10jenkins-bot: [V: 04-1] Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 (owner: 10Addshore) [14:01:24] its half way there [14:01:35] see https://gerrit.wikimedia.org/r/94939 [14:01:39] https://gerrit.wikimedia.org/r/82637 [14:01:43] okay [14:01:58] I just wanted to see if I should count this for my stats ;) [14:03:08] not yet :) [14:03:09] (03PS4) 10Addshore: Further refactor GetEntitiesOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95374 [14:03:13] if you find any ill be amazed [14:03:53] I found descriptions with langcode = "En" (upper case 'e') [14:04:20] I wont be supprised if I find badges even if they are not implemented yet [14:11:50] thanks aude [14:15:00] hmmm losing the use of ULS is NOT nice.. I use it regularly [14:17:39] uls is a usability horror [14:19:25] aude - thanks, we'll review it. Now another issue. I'm still try to get my wiki to show interlanguage links from Wikibase. Any help there? [14:21:29] lbenedix: yes it can be improved but it is better than nothing [14:22:11] it has three default languages ... would like to see them created as a default in a #babel templagte [14:23:16] I made some Usertests for my Thesis and everyone was supprised by the little uls-thingy next to the input boxes and didn't understand the purpose of it [14:23:24] (it is better to have this ... it points to people to the fact that Wikidata is not monolingual ie English) [14:23:36] no [14:23:43] it confuses users [14:25:01] aharoni: back [14:25:02] do you have a better strategy / [14:25:05] ? [14:25:10] you have a repo setup? [14:25:12] dont confuse users [14:25:16] aude: yes [14:26:05] https://gist.github.com/filbertkm/974653d3aaec343b108d is how i do my settings [14:26:15] aude: I don't really care where do those interlanguage links coming from, as long as they get the "Edit links" element to appear. [14:26:28] they have to come from your repo [14:26:33] no problem [14:26:34] depends on db access to the repo [14:26:39] in my opinion ULS should be configureable by the user [14:26:44] needs the $wgLBFactoryConf [14:26:48] If you dont need it, dont enable it [14:27:08] lbenedix: it is [14:27:16] it's not required [14:27:27] it was enabled by default when I made the tests with wikidata [14:27:39] if you have uls installed [14:27:55] it was installed in wikidata.org [14:27:56] i'm not convinced of making a setting for it [14:27:58] yes [14:28:07] (03CR) 10Addshore: [C: 032] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [14:28:09] wikidata has uls [14:28:23] GerardM- said it is gone... [14:28:29] aude: that's quite long... is all of it relevant? [14:28:37] aharoni: it is [14:28:43] wow. OK, I'll try. [14:28:44] the load balancer part [14:28:49] and repoDatabase [14:29:09] and then the client has to be in the sites table [14:29:16] so i make mine "enwiki" [14:29:26] and set siteGlobalID [14:29:33] (03CR) 10Addshore: [C: 032] Get rid of deprecated method in PropertyParserFunctionRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95267 (owner: 10Jeroen De Dauw) [14:30:56] (03CR) 10Addshore: [C: 032] Reduced SnakList.newFromJSON complexity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92304 (owner: 10Henning Snater) [14:31:03] aharoni: i just updated the gist. $wgWBSettings -> $wgWBClientSettings (or $wgWBRepoSettings) [14:32:29] (03PS2) 10Aude: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 [14:34:18] (03CR) 10Henning Snater: "You could probably acquire the languages from the UniversalLanguageSelector and init a plain suggester filled with the language data from " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [14:34:45] (03Merged) 10jenkins-bot: Get rid of deprecated method in PropertyParserFunctionRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95267 (owner: 10Jeroen De Dauw) [14:35:31] (03CR) 10Addshore: [C: 04-1] "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [14:36:31] Henning_WMDE: can you tell me how to check if uls is available? [14:37:07] aude: miraculously, it loads without failing :) [14:37:14] yay! [14:37:20] BUT [14:37:25] but....? [14:37:27] I still don't see anything when I try to add links. [14:37:32] oh [14:37:42] did you purge your client page? [14:37:43] When I click "Add links", the widget appears, but there's no form in it. [14:37:48] no, trying. [14:37:49] oh [14:37:50] (03Merged) 10jenkins-bot: Reduced SnakList.newFromJSON complexity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92304 (owner: 10Henning Snater) [14:37:58] any js error? [14:38:06] lbenedix: I guess with checking if mw.uls is defined you should be fine. [14:38:24] aude: purged, still empty [14:38:34] i wonder if it can access your repo db [14:39:04] aude: how do I know? [14:39:25] let's see.... [14:39:50] OK, so repoDatabase probably shouldn't be "testrepo". [14:40:00] right [14:40:05] whatever yours is [14:40:07] should it be the name of the repo database? [14:40:11] yes [14:40:19] OK, trying [14:40:54] still empty. [14:41:10] I guess that I should do something about the sites table. [14:41:21] might be [14:41:42] (03CR) 10Addshore: "This validation has already been added!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92299 (owner: 10Henning Snater) [14:43:16] probably. [14:43:26] aharoni: maybe you can test in php maintenance/eval.php [14:43:46] "insert" is an sql statement the syntax of which I always google :) [14:43:48] $db = wfGetLB( 'testrepo' ) --- or whatever yours is [14:43:54] var_dump( $db ); [14:43:59] do that from the client wiki [14:44:41] (03CR) 10Addshore: [C: 032] Removed detaching of entityview DOM while initializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94861 (owner: 10Henning Snater) [14:44:57] aha, this is interesting: eval.php says "PHP Notice: Undefined variable: wmgUseWikibaseRepo" about my LocalSettings, and the same about wmgUseWikibaseClient. [14:44:58] (03PS8) 10Addshore: Implemented index parameter in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90504 (owner: 10Henning Snater) [14:45:02] I guess I should define it somewhere. [14:45:06] (03PS9) 10Addshore: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [14:45:12] (03PS7) 10Addshore: Keeping track of claim index in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 (owner: 10Henning Snater) [14:45:18] (03PS6) 10Addshore: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 (owner: 10Henning Snater) [14:45:19] oh.... [14:45:22] my magic settings [14:45:26] (03PS4) 10Addshore: Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 (owner: 10Henning Snater) [14:45:31] (03PS5) 10Addshore: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 (owner: 10Henning Snater) [14:45:42] that's how i can use the same wikibase settings file for both client and repo [14:46:01] i set $wmgUseWikibaseRepo = false for client and true for repo [14:46:15] or you can use just portion of my settings [14:48:05] aude: and what is wmgUseWikibaseBuild ? [14:48:22] (03Merged) 10jenkins-bot: Removed detaching of entityview DOM while initializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94861 (owner: 10Henning Snater) [14:48:58] we are trying to make a "build" .... put all of wikibase and dependencies in a single git repo to deploy [14:49:19] i set that if i want to use that instead of load all the individual components [14:50:26] (03CR) 10Addshore: [C: 032] Implemented index parameter in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90504 (owner: 10Henning Snater) [14:50:49] aharoni: https://gist.github.com/filbertkm/14aa0fd13e1f5cb6578f :) [14:51:18] my local settings. right now i am hard coding it as 'testrepo' but it can figure out otherwise base on the domain name [14:51:35] then use one mw installation for 2 wikis [14:53:06] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [14:57:01] Ok off to Vienna and then Bratislava -> Modra [14:57:57] (03CR) 10jenkins-bot: [V: 04-1] Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 (owner: 10Henning Snater) [14:58:21] (03CR) 10jenkins-bot: [V: 04-1] Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 (owner: 10Henning Snater) [14:59:08] why is jenkins failing? [14:59:21] those were expected to fail [= [14:59:38] oh, cross repo dependency [15:03:16] (03CR) 10Tobias Gritschacher: [C: 032] (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [15:03:26] \o. [15:03:30] / [15:03:39] all the math! [15:04:03] (03Merged) 10jenkins-bot: (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [15:04:05] aharoni: any luck? [15:04:14] aude: OK, now this gets interesting. Now that I press the "Add links" element, I get a little bubble with "An unexpected error occurred". [15:04:23] so I must have done /something/ :) [15:04:43] huh [15:04:48] very helpful :O [15:04:58] I don't see anything in JS log or in Apache log. [15:05:17] it's probably an exception that is caught and somehow becomes "unexpected error" [15:07:21] ok..... [15:08:16] i think the issue might be CORS [15:08:33] are your wikis under different domains or something? [15:09:06] (03PS1) 10Addshore: Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 [15:11:13] aude: ^^ :P [15:11:43] aude: same [15:11:44] $.get( 'http://wikidata-repo/api.php', {'action' : 'query', 'meta' : 'userinfo' }); [15:12:00] substitute your wiki in the url [15:12:12] it appears the widget is making that request [15:12:41] well, I get something. [15:12:46] what am I supposed to see there? [15:13:02] (03PS1) 10Henning Snater: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 [15:13:03] statusTex: "error" [15:13:08] sorry, [15:13:10] statusText: "error" [15:13:13] that's probably relevant [15:13:16] yes [15:13:36] now how do I know the details? [15:14:38] (03CR) 10Aude: [C: 04-1] "(3 comments)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore) [15:15:08] aharoni: mine, i get an error currently in the console [15:15:11] "is not allowed by Access-Control-Allow-Origin. " [15:15:18] which makes it obvious in this case [15:15:28] Well, I get an object with a bunch of things. [15:16:27] one sec [15:16:35] Oh I think I now what's the problem. Just a moment. [15:17:03] wrong URL :) [15:17:12] $.get( 'http://en-wikidata.filbertkm.com/api.php', {'action' : 'query', 'meta' : 'userinfo' }).done(function( data ) { console.log( data ) }); [15:17:16] errr [15:17:19] one of my test wikis.... [15:17:48] (03PS2) 10Addshore: Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 [15:18:10] with the correct URL it returns my user info - Amire80 etc. [15:18:23] ok [15:23:11] (03PS10) 10Henning Snater: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 [15:34:14] (03PS3) 10Henning Snater: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [15:43:00] (03PS4) 10Henning Snater: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [15:44:28] (03PS5) 10Henning Snater: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [15:46:21] (03CR) 10Henning Snater: [C: 032] Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [15:47:32] thanks Henning_WMDE [15:47:34] (03CR) 10Addshore: [C: 032] Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [15:47:43] now to cherry pick [15:48:05] (03PS1) 10Aude: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/95425 [15:48:15] (03CR) 10Aude: [C: 032 V: 032] Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/95425 (owner: 10Aude) [15:48:23] * aude beats jenkins :) [15:49:49] :O [15:49:50] Tobi_WMDE: ^ [15:50:00] did selenium approve? [15:50:10] (03Merged) 10jenkins-bot: Conditionally require jquery.uls.data as dependency, if ULS is available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95380 (owner: 10Aude) [15:51:08] (03PS2) 10Tobias Gritschacher: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [15:52:55] I think I canceled one of your jenkins jobs by mistake, sorry :( [15:53:10] (03Merged) 10jenkins-bot: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [15:53:42] heh [15:53:44] ok [15:55:23] (03PS3) 10Henning Snater: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 [15:55:43] (03CR) 10Tobias Gritschacher: [C: 032] Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [15:56:32] (03CR) 10Tobias Gritschacher: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [16:00:48] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1209 (mw1.23-wmf3 - ff48785 : aude): The build was fixed. [16:00:48] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2f30af84c63b...ff48785ded0c [16:00:48] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13975597 [16:01:03] \o/ [16:02:15] how can I always choose link to enwiki [16:09:12] (03PS4) 10Henning Snater: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 [16:13:26] Reedy: if you can deploy https://gerrit.wikimedia.org/r/95427 would be great [16:13:36] helps avoid wikidata breaking when ULS gets updated [16:14:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1211 (master - 8f88a01 : jenkins-bot): The build was broken. [16:14:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/156d89cae3f8...8f88a0116395 [16:14:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13975856 [16:15:26] why is master broken? [16:15:38] addshore: ^ [16:20:37] (03PS1) 10Henning Snater: Fixed SetClaimTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95429 [16:23:54] (03CR) 10Addshore: [C: 032] Fixed SetClaimTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95429 (owner: 10Henning Snater) [16:36:35] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1212 (master - 9a00046 : Henning Snater): The build was fixed. [16:36:35] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/8f88a0116395...9a0004634aff [16:36:35] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13977712 [16:42:11] I found some errors in the dump [16:43:10] for Q42 there are 9 revisions with invalid json in the node [16:43:57] I looked at 130737 and found {"m&uuot;:["value",18,"string","Douglas adams portrait cropped.jpg"],... [16:44:43] I think &uuot; should be " [16:47:50] Lydia_WMDE: ^ [16:48:08] lbenedix: there is nothing we can do about that [16:48:21] if its invalid its invalid :) this is why the internal structure is unstable [16:48:30] how is wikidata handling this? [16:48:38] where does it come from [16:48:40] what are the rev ids? [16:49:11] for Q42: http://pastebin.com/K2ZtXGBz [16:49:31] replacing &uuot; with " worked [16:49:43] maybe you could do that in the database... [16:50:02] well, wikidata handels them just fine ;p https://www.wikidata.org/w/index.php?title=Q42&oldid=8060 [16:50:54] lbenedix: that would be changing history though! [16:50:57] not really [16:51:11] in the json I see claims here: https://www.wikidata.org/w/index.php?title=Q42&oldid=130737 [16:52:16] I see {"label":{"en":"Bleach","it":"Bleach"},"description":{"en":"A manga drawn and written by Tite Kubo.","it":"Un manga scritto e disegnato da Tite Kubo."},"aliases":[],"links":{"itwiki":"Bleach (manga)","enwiki":"Bleach (manga)","arwiki":"\u0628\u0644\u064a\u062a\u0634 (\u0645\u0627\u0646\u062c\u0627)","bgwiki":"Bleach [16:52:17] (\u043c\u0430\u043d\u0433\u0430)","bugwiki":"Bleach (manga)"},"entity":"q904"} [16:52:44] in the dump? [16:52:48] no [16:53:00] I'm talking about the dump [16:53:15] pastebin me the section? [16:54:02] this is the wikitext: http://pastebin.com/684HJ8hA [16:55:29] sry, i got the wrong IDs [16:55:52] rev_id 24328230 [16:56:54] so whats wrong with it? [16:57:03] &uuot; [16:57:15] should be " [16:58:45] well looking and the json i get http://pastebin.com/BmgvmKiC [16:59:02] go to https://www.wikidata.org/w/index.php?title=Special:Export [16:59:04] which decodes to http://pastebin.com/dAws5YfW [16:59:18] export Q42 with history [16:59:24] lbenedix: Idid [16:59:28] grep for &uuot; [16:59:47] I did and it isnt found anywhere [16:59:50] sorry have to go, meeting! [17:00:00] okay [17:14:50] lbenedix: back [17:15:47] so yes, I dont see there chars anywhere :P [17:16:40] I'm running this right now: pbzip2 -dc /srv/wikidata/wikidata/with_history/wikidatawiki-20131105-pages-meta-history.xml.bz2 | grep '&uuot;' [17:25:11] hi [17:25:28] this user does spam: https://www.wikidata.org/w/index.php?title=User:Safetyshoesagra&action=history [17:25:53] what to do in such a case? [17:28:37] Schisma___: I'll deal with it ;) [17:28:47] hoo: thanks ^^ [17:28:57] hoo: beat you ;p https://www.wikidata.org/w/index.php?title=Special:Log&type=block&user=&page=User:Safetyshoesagra [17:29:07] Henning_WMDE , hoo , Tobi_WMDE , aude - I'm still trying to get a test repo and a test client to work. Now I have a separate client wiki. I create an item. I managed to add a sitelink to ruwiki. [17:29:21] I am trying to add a sitelink to my own client, and I'm getting: "The specified article could not be found on the corresponding site." [17:29:26] addshore: Yeah :P Get back to wrok :D [17:29:52] maybe there should be a way to patrol edits of newly created users [17:30:10] there is [17:30:26]