[08:23:47] Good Morning! I had some questions concerning the Link GA and Link FA templates [08:24:32] Will wikidata take over such templates instead of having them added redundantly to the all wikis? [08:24:41] to all wikis* [08:25:15] one day, yes [08:25:26] unfortunately, it is still being worked on [08:26:06] @rschen7754: is there a timeline? [08:26:15] you would need to ask the devls [08:26:17] *devs [08:26:21] it is actively being worked on [08:26:24] https://bugzilla.wikimedia.org/40810 [08:26:35] but i can't give a date for when it will be ready [08:27:22] https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface.png [08:27:46] what it might look like [08:34:36] thanks @aude for the updates [08:34:45] sure [09:15:58] morning peeps :) [09:16:56] aude: Tobi_WMDE: Henning_WMDE: addshore: JeroenDeDauw: working from home today as i'm not feeling too well - if you need anything i am around on irc and will call in for the daily [09:17:08] :( [09:17:20] why is everyone sick? [09:17:41] stupid weather [09:17:50] blah [09:18:03] blah indeed [09:18:17] but i'll drink a lot of hot tea and it'll be over soon i hope [09:18:33] ok [09:18:45] make sure to rest and not work too much [09:18:59] will try ;-) [09:27:24] Lydia_WMDE: Is there a certain Wikidata Item you use in your presentations? [09:27:44] i always use one fitting for the event [09:27:50] * aude recommends the item for the city you are in [09:27:55] depending on where i am [09:27:58] what the event is about [09:27:59] and so on [09:28:07] there is no prototypical item? one that has all the nice features? [09:28:28] there are a lot of them ;-) [09:28:40] one that is most linked to... [09:28:53] no idea which one that is [09:29:03] probably [[geographical feature]] [09:29:04] 10[1] 04https://www.wikidata.org/wiki/geographical_feature [09:29:12] since p107 still exists [09:29:24] possibly yeah [09:29:29] it's not a good example item, though [09:29:44] or male / female [09:30:07] right [10:41:10] Lydia_WMDE: :D [10:47:18] Tobi_WMDE: sush! :P [10:47:35] haha [10:47:40] I'm fine [11:49:22] does someone know how many revisions are in the dump 2013-02-28? [12:08:58] ~10mio revisions [12:59:55] (03PS2) 10Daniel Kinzler: (bug #57014) Introducing ApiFormatValue [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/95278 [13:00:10] Henning_WMDE: ---^ [13:00:48] Tobi_WMDE: please put #57014 on "feedback". [13:00:48] thanks! [13:00:54] nice [13:02:12] Henning_WMDE: note that the parsevalue and formatvalue modules are oblivious to Wikibase data types. [13:02:45] For more advanced formatting and parsing, specific to data types like url, we'll probably want wbsnakvalueparser/wbsnakvalueformatter [13:08:47] updated https://bugzilla.wikimedia.org/show_bug.cgi?id=49186 [13:09:28] Lydia_WMDE: I suggest to put ---^ into the backlog. we should break it down into more concrete items, perhaps during story time. [13:10:10] DanielK_WMDE: will have a look - thx [13:17:04] (03PS12) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 [13:17:34] (03CR) 10Daniel Kinzler: "PS 12 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [13:18:03] aude: can't reproduce the issue. rebased once more --^ [13:18:16] DanielK_WMDE: i'll let addshore merge it then [13:18:18] :D [13:18:38] don't be surprised it the issue appears on travis or somewhere [13:18:52] aude: the merge conflict i solved for the rebase had the potential to trigger the issue, if handled incorrectly. That was for SetClaim. [13:19:01] no idea why SetReference would have had a problem [13:19:03] there were more issues in other api modules [13:19:09] no data types thing [13:19:22] gives a warning which phpunit considers an error [13:19:36] yes. shouldn't happen. see the fix in SetClaim: [13:19:53] that's just one place [13:20:05] anyway, i am not comfortable to merge it [13:20:19] unless i can figure out why i get the errors [13:20:43] uh, actually... [13:20:43] let me have another look there [13:20:43] * DanielK_WMDE is confused now [13:21:01] i think the whole thing is a mess [13:21:10] not specific to what you are doing [13:21:16] aude: basically, the solution is to always supply a type lookup when constructing a SerializerFactory. [13:21:16] i thought i had done this in all tests. [13:21:23] but now i don't see it - and i don't see errors. what gives?? [13:21:29] but the structure of the api (lack of dependency injection) + structure of serializers i [13:21:34] yes, indeed, it's a mess. [13:21:48] though i hope my patch improves this (replaces local instantiation with injection) [13:21:52] no idea why you don't see and jenkins doesn't see [13:21:56] still not very nice, though [13:22:14] uh.. [13:22:18] * aude hate for you patch to sit another week though [13:22:34] i do see it when i run *just* that test. wtf? [13:22:40] oh [13:22:42] if i run it via the test group, i don't see it [13:22:47] i don't use test group [13:22:52] hmhm [13:22:57] i just point php unit to wikibase directory or subdirectory [13:23:18] jenkins uses --group [13:23:33] so i guess what happens is that *some* provides messes with the error handler (and when using test groups, all providers are executed). [13:23:44] probably [13:23:44] that supresses the error [13:27:52] ugh, finding which provider does this is going to be hard [13:32:12] (03PS1) 10Addshore: Refactor Permissions tests into 2 seperate classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95597 [13:32:25] aude, does it? O_o [13:32:43] meh, broken firefox plugin threatened to kill my kde session. oh joy. [13:33:59] (03CR) 10Daniel Kinzler: [C: 04-1] "Several test failures when running tests individually (not via --group)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [13:34:12] aude, addshore: ---^ [13:34:44] addshore: remember when we talked about test messing with error handlers? i guess this is another one. except that it's a *provider* that messes this up. [13:34:49] which is way worse :( [13:34:53] :/ [13:35:22] Lydia_WMDE: Remember to open the label fallback thing? [13:35:23] i'll fix this, and then investigate what could be causing this [13:35:38] * . [13:35:45] ;) [13:41:45] (03PS1) 10Jens Ohlig: Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 [13:54:56] yay. [13:55:06] so one of the things that messes with the error handler is the DB connect code. [13:55:14] grrrrr [13:55:26] and it does so differently for MySQL than for Postgres. Oh joy. [13:55:33] hah [13:55:57] it doesn't seem to do this for SQLite, so it's no an issue for jenkins, but still [13:56:32] travis will care [13:56:36] damn, PHP *really* needs support for "finally" blocks. very hard to reliably restore an error handler without that [13:57:13] hm, postgres seems to *never* restore the error handler. wtf? [13:57:49] (03PS3) 10Addshore: Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 [13:57:49] oh wait, it does. [13:57:51] (03CR) 10jenkins-bot: [V: 04-1] Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [13:58:15] (03PS6) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. Patch set 4: ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 [13:58:54] Lydia_WMDE: DanielK_WMDE we're starting with the daily in 2 minutes [13:59:03] join the hangout if you want [13:59:09] 2.... 1.... :) [13:59:15] (03PS2) 10Addshore: Refactor Permissions tests into 2 seperate classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95597 [13:59:20] oh, right! [13:59:24] joining in a minute [13:59:44] Tobi_WMDE: please update the calendar entry for the daily [14:00:12] DanielK_WMDE: only abraham has calendar superpowers [14:00:15] DanielK_WMDE: can't do it. abraham has to do it, it's his calendar [14:11:09] Lydia_WMDE: you are late on the first very late daily! [14:12:42] JeroenDeDauw: it was actually the second.. ;) [14:13:08] Tobi_WMDE: daaaah! [14:13:27] Lydia_WMDE: you should tweet this as "current status" http://i.dailymail.co.uk/i/pix/2013/05/14/article-2324210-19C4F5A5000005DC-67_634x345.jpg [14:14:06] Tobi_WMDE: argh... i knew there was something i forgot... [14:14:06] sorry [14:14:26] Lydia_WMDE: blame it on the sushi [14:14:43] poor sushi [14:27:37] (03PS5) 10Tobias Gritschacher: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [14:45:12] !admin please block https://www.wikidata.org/wiki/Special:Contributions/119.241.215.133 [14:45:47] !admin [14:45:52] Pratyya: done [14:46:30] Sannita_: where'll I request in future? [14:46:37] here will be ok [14:46:37] I mean where'll I request block? [14:46:52] Is there any page @wikidata? [14:47:14] Sannita_: [14:47:17] though I think it was not really vandalism, but ip didn't know the rules maybe... you can see that those categories are empty categories in ja-wiki [14:47:28] can you just WAIT for someone to answer you? :D [14:47:50] actually I'm in a big hurry that's why pinging you. [14:47:58] need to go in 2 mins [14:48:05] (ah, a reason was not "vandalism", so not a problem) [14:48:55] Pratyya: administrator noticeboard I think [14:49:13] thanks good bye Sannita [14:50:23] (03PS1) 10Jeroen De Dauw: Fix autoloading for PHP 5.3.2 to 5.3.6 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/95608 [14:50:28] addshore: meeergeee ^ [14:50:57] (03CR) 10Tobias Gritschacher: [C: 032] Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [14:53:34] (03CR) 10Addshore: [C: 032] Fix autoloading for PHP 5.3.2 to 5.3.6 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/95608 (owner: 10Jeroen De Dauw) [14:53:53] addshore: think this fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=56663 [14:54:07] (03Merged) 10jenkins-bot: Fix autoloading for PHP 5.3.2 to 5.3.6 [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/95608 (owner: 10Jeroen De Dauw) [14:54:25] (03Merged) 10jenkins-bot: Restructured template mechanism and implemented simple template cache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95388 (owner: 10Henning Snater) [15:04:05] (03PS6) 10Jeroen De Dauw: (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:04:12] (03CR) 10Jeroen De Dauw: [C: 04-1] (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:04:21] (03CR) 10jenkins-bot: [V: 04-1] (bug 55593) use jQuery.wikibase.snakview on Special:SimpleQuery [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:04:50] (03CR) 10Tobias Gritschacher: [C: 04-1] "When viewing an entity with a statement, I'm getting:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [15:06:25] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [15:15:59] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89102 (owner: 10Daniel Werner) [15:16:08] (03PS10) 10Jeroen De Dauw: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [15:16:51] (03CR) 10Jeroen De Dauw: [C: 032] Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [15:22:00] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89109 (owner: 10Daniel Werner) [15:25:37] (03PS3) 10Aude: Introduce ChangeLineFormatter in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [15:25:47] gah [15:26:57] (03PS4) 10Aude: Introduce ChangeLineFormatter in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95596 [15:27:59] aude: can you have a look at https://gerrit.wikimedia.org/r/#/c/89102/3 ? [15:28:41] about to go home [15:29:01] aude: can you add this to your todo list then? [15:29:06] * aude came very early this morning [15:29:09] k [15:29:12] aude: thnx [15:29:26] Henning_WMDE: do you have any concerns with this commit further then the tests not passing atm? https://gerrit.wikimedia.org/r/#/c/89109/ [15:29:57] addshore: https://gerrit.wikimedia.org/r/#/c/95616/ +1!!!! [15:30:58] sure, see comment [15:31:14] (03CR) 10Jeroen De Dauw: "I'm going to first fix what is on master, and then rebase these changes on top of that" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [15:31:44] JeroenDeDauw: needs to be removed from zuul first [15:32:05] addshore: right, more places to poke >_> [15:32:14] well, no :P just https://gerrit.wikimedia.org/r/#/c/93428/ [15:33:30] addshore: https://gerrit.wikimedia.org/r/95617 [15:33:51] .. [15:33:56] you already have the change open.. [15:34:07] addshore: oops [15:34:10] Closed the old one [15:34:15] .. [15:34:40] .. [15:34:46] ... [15:34:48] :D [15:35:03] JeroenDeDauw: trying to sneak around -2s! [15:35:20] addshore: yeah really [15:35:36] addshore: happy now? [15:35:55] better ;p [15:37:03] (03CR) 10Daniel Kinzler: "So, apparently, some data provider (not a test case!) somewhere sets wgDevelopmentWarnings to false." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [15:41:20] oh. found it. i guess that was indeed me. [15:41:22] ugh. [15:42:15] nasty... [15:42:36] note to self: setMwGlobals() is nice in tests, but never use it in providers! it doesn't restore the global! [15:44:36] :D [15:47:34] (03PS1) 10Daniel Kinzler: Don't spoil $wgDevelopmentWarnings in test provider. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95621 [15:48:19] (03CR) 10Addshore: [C: 032] Don't spoil $wgDevelopmentWarnings in test provider. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95621 (owner: 10Daniel Kinzler) [15:48:23] :D [15:49:05] \o/ [15:49:28] nice find DanielK_WMDE !!! [15:49:38] thanks [15:49:52] addshore: also: https://gerrit.wikimedia.org/r/#/c/95612/ [15:50:07] not sure whether any of that ever was the *actual* problem [15:50:15] but it well *might* me, or become, a problem [15:50:40] and of course: https://gerrit.wikimedia.org/r/#/c/74170/ [15:51:19] aude: i'll probably dump down the JSON patch to use global state until we can make the injection work properly [15:51:39] injecting the lookup via the options sucks. better have a hack for now than this mess. [15:51:54] probably not tonight, though. [15:51:56] monday, perhaps [15:52:08] i'd really like to have this in, but nothing is blocked on it [15:52:15] [travis-ci] JeroenDeDauw/WikibaseQuery#1 (master - 61d3365 : Jeroen De Dauw): The build has errored. [15:52:15] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/a28319334dd5...61d3365e9475 [15:52:15] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14028486 [15:52:49] (03Merged) 10jenkins-bot: Don't spoil $wgDevelopmentWarnings in test provider. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95621 (owner: 10Daniel Kinzler) [15:55:29] [travis-ci] JeroenDeDauw/WikibaseQuery#2 (master - 7864567 : jeroendedauw): The build has errored. [15:55:29] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/61d3365e9475...7864567d9fd7 [15:55:29] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14028686 [15:56:21] [travis-ci] wmde/Serialization#1 (master - 4122849 : Jeroen De Dauw): The build passed. [15:56:21] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/2f01017b193d...4122849126a2 [15:56:21] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/14028742 [15:57:23] [travis-ci] wmde/Ask#3 (master - 9f1954e : Jeroen De Dauw): The build has errored. [15:57:23] [travis-ci] Change view : https://github.com/wmde/Ask/compare/fe362296ecd9...9f1954e699c0 [15:57:23] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/14028772 [15:58:05] [travis-ci] wmde/Serialization#2 (1.0 - 504081f : jeroendedauw): The build passed. [15:58:05] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/1.0 [15:58:05] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/14028887 [15:59:10] [travis-ci] JeroenDeDauw/WikibaseQuery#2 (master - 7864567 : jeroendedauw): The build has errored. [15:59:10] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/61d3365e9475...7864567d9fd7 [15:59:10] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14028686 [16:00:26] [travis-ci] wmde/Serialization#3 (2.0 - 2f01017 : jeroendedauw): The build passed. [16:00:26] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/2.0 [16:00:26] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/14028891 [16:02:36] [travis-ci] wmde/Ask#4 (master - 19f151e : Jeroen De Dauw): The build passed. [16:02:36] [travis-ci] Change view : https://github.com/wmde/Ask/compare/9f1954e699c0...19f151e28e7d [16:02:36] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/14028998 [16:04:13] (03CR) 10Addshore: "(12 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [16:04:18] (03CR) 10Addshore: [C: 04-1] Refactored Wikibase Lua library code to make everything testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95598 (owner: 10Jens Ohlig) [16:04:22] addshore: 1Ann2WbiaW2bnmSx5N3uN5iVDRscNHG65W ? [16:16:46] (03Abandoned) 10Aude: introduce ChangeLineFormatter in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80534 (owner: 10Aude) [16:19:56] [travis-ci] JeroenDeDauw/WikibaseQuery#4 (master - a6a2611 : jeroendedauw): The build has errored. [16:19:56] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/06bb792ebd06...a6a2611332ca [16:19:56] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14029894 [16:20:20] [travis-ci] JeroenDeDauw/WikibaseQuery#3 (master - 06bb792 : jeroendedauw): The build passed. [16:20:20] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/7864567d9fd7...06bb792ebd06 [16:20:20] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14029719 [16:25:20] (03PS1) 10Jeroen De Dauw: Fix imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95634 [16:29:04] (03CR) 10Jeroen De Dauw: "April... abandon?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/55607 (owner: 10Daniel Kinzler) [16:30:08] (03CR) 10Jeroen De Dauw: [C: 04-1] "Needs rebase as well" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84187 (owner: 10Legoktm) [16:32:15] (03CR) 10Jeroen De Dauw: [C: 04-1] "This adds to our legacy code we need to deal with. Ned code ought to decouple itself from the mess that is the MW API and the almost as bi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82451 (owner: 10Legoktm) [16:32:28] (03PS10) 10Jeroen De Dauw: Remove dummy language codes from Utils::getLanguageCodes() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [16:32:41] (03CR) 10Jeroen De Dauw: [C: 04-1] "-1 as per DanielK" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent) [16:33:45] (03CR) 10Jeroen De Dauw: "Can this be abandoned?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84741 (owner: 10Liangent) [16:53:36] (03CR) 10Daniel Kinzler: "still looks sensible. and termindex could indeed use better tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/55607 (owner: 10Daniel Kinzler) [16:57:48] addshore: want to restore your +1 https://gerrit.wikimedia.org/r/#/c/95612/ ? [16:58:13] * aude can't turn blind eye to typos in commit messages :) [16:58:20] done :) [16:58:24] great [17:07:52] Lydia_WMDE: Ping [17:08:07] JohnLewis: hey [17:08:23] Lydia_WMDE: Summary is ready for a dev update :) [17:09:19] JohnLewis: ah right [17:09:21] oh, it's friday? [17:09:23] :D [17:09:30] let me check what i have so far and add the rest [17:09:39] it'll take about 10 mins [17:09:41] aude: I forgot it was Friday two weeks ago :p [17:09:46] * aude scambles to add stuff [17:10:03] Lydia_WMDE: I have to wait for Legobot to update anyway :p So 3 hours unless I ping him early. [17:10:14] k [17:11:49] :O [17:12:07] i forgot it was friday also :D [17:12:54] addshore: I expect it from you :p [17:13:42] ;p [17:14:17] No weekend for you addshore [17:16:26] Wait, addshore actually gets a weekend? I thought he just turned IRC off and refused to come and do work. [17:17:17] done [17:24:53] so, my internet (3g) at home is waaaaaay better than was in the office today [17:27:45] aude: i think its time we divide unit and integration tests in wikibase :) [17:28:08] then i can start writing unit tests for the api modules and reduce the complexity of the integration tests :p [17:28:26] :) [17:28:43] would speed things up also :D [17:28:49] i hope so [17:28:57] all output with be tested via the resultbuilder class [17:29:06] all module be fully unit tested [17:29:18] and just a few integration tests for good measure.. [17:30:26] how long will this take? [17:30:36] how do you mean? :P [17:30:45] why bit? :D [17:31:11] which [17:31:11] more refactoring of the tests? [17:31:16] splitting them [17:31:31] well currently all of the tests are integration tests, not splitting is needed :P [17:31:44] *no splitting is needed [17:31:46] hmmm [17:31:51] it would just actually be writing unit tests [17:32:08] I have already refactored all of the output stuff [17:32:13] ok [17:39:38] [travis-ci] JeroenDeDauw/WikibaseQuery#5 (master - 5f9a5b1 : Jeroen De Dauw): The build passed. [17:39:38] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/a6a2611332ca...5f9a5b10d79d [17:39:38] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14033589 [17:53:17] JohnLewis: dev stuff added :) [17:53:29] JohnLewis: another thing to maybe add: https://twitter.com/mdammers/status/401103112632410112 [17:53:42] JohnLewis: and the office hour log? [17:53:51] https://meta.wikimedia.org/wiki/IRC_office_hours/Office_hours_2013-11-13b [17:54:06] and http://magnusmanske.de/wordpress/?p=114 [17:54:12] I forgot about the office hour :p [17:54:24] http://ultimategerardm.blogspot.de/2013/11/wikidata-howto-nelson-mandela.html?utm_source=twitterfeed&utm_medium=twitter [18:09:57] (03PS1) 10Addshore: implement MergeItemsUnitTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95645 [18:10:00] aude: ^^ [18:10:03] something like that :P [18:10:54] (03PS2) 10Addshore: implement MergeItemsUnitTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95645 [18:31:57] arg there is a limit of 400 characters [18:51:34] Have we already moved to #wikidata [18:54:40] Mark-Potter: i don't think so, though people are in both [18:54:51] Lydia_WMDE: does gerrit etc. move to the new channel? [18:54:52] ok thx aude [18:54:53] :) [18:55:23] aude: yes [18:55:28] ok, when? [18:55:59] not sure - in the next days when this one is turned into a redirect to the other channel [18:56:29] Though updating it to join #wikidata directly is best :p [18:57:37] it's best to update that stuff a day or so in advance [18:57:50] so we're not without them for any period :) [19:21:50] (03CR) 10Addshore: [C: 032] Fix imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95634 (owner: 10Jeroen De Dauw) [19:25:18] (03Merged) 10jenkins-bot: Fix imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95634 (owner: 10Jeroen De Dauw) [19:26:09] * Mark-Potter thinks this is still the channel for wikidata considering the bot is still here [19:27:41] (03PS4) 10Addshore: Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 [19:27:48] (03CR) 10jenkins-bot: [V: 04-1] Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [19:28:35] (03CR) 10Addshore: [V: 032] Add 'wikibase-query-run' permission and checks [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [20:02:45] (03CR) 10Jeroen De Dauw: [C: 032] Refactor Permissions tests into 2 seperate classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95597 (owner: 10Addshore) [20:24:23] (03CR) 10Jeroen De Dauw: [C: 04-1] "This has some copy-paste from the other system test..." [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [20:25:00] (03CR) 10Jeroen De Dauw: "(And to be clear: this should not be solved by creating a new base class to share code)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [20:35:27] addshore: https://github.com/JeroenDeDauw/WikibaseQuery/commits/master [20:46:45] Hey people. Please start migrating to #wikidata - this channel will soon be closed and forwarded. [20:51:52] Barras2: Thanks, that's on my autojoin now [21:52:51] grrit-wm has moved to #wikidata [22:01:14] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#84 (master - 5f9a5b1 : Jeroen De Dauw): The build was fixed. [22:01:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/a28319334dd5...5f9a5b10d79d [22:01:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/14044901 [22:10:59] [travis-ci] wmde/Ask#5 (master - e2439f2 : jeroendedauw): The build was broken. [22:10:59] [travis-ci] Change view : https://github.com/wmde/Ask/compare/19f151e28e7d...e2439f20fe4a [22:10:59] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/14045610 [22:16:42] [travis-ci] wmde/Ask#6 (master - 3ef7ecb : jeroendedauw): The build is still failing. [22:16:42] [travis-ci] Change view : https://github.com/wmde/Ask/compare/e2439f20fe4a...3ef7ecbcdc9d [22:16:42] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/14045890 [22:19:28] ohnoez! they are killing this IRC channel o_O [22:19:32] REBELL! [22:19:37] :D [22:19:38] We need to overthrow aude [22:19:49] JeroenDeDauw: Blame me actually :p [22:20:02] JohnLewis, the man behind the curtain! [22:20:08] I was the one who suggested it to Barras and convinced Lydia >:D [22:20:13] * JeroenDeDauw goes update his irc config [22:20:28] WeeChat. No, YouChat. [22:24:39] JeroenDeDauw: I heard you have T-Shirts with the wikidata cat [22:26:59] lbenedix: be one of the cool kids and join #wikidata [22:27:26] JeroenDeDauw: They are there :p [23:04:03] !admin can you pleasde create https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control#VLACC ? [23:04:31] gangleri_back: Please avoid using the stalkword for property creation requests. Thank you. [23:13:41] Hello lazowik [23:14:05] :D [23:14:29] Mark-Potter: how are you, future historian? [23:14:41] lazowik: I'm cool, thank you. :) [23:15:20] lazowik: Please clarify the use of the word "future" in the context of "future historian" [23:15:44] hmm [23:15:49] realively to 2013 [23:52:01] [travis-ci] JeroenDeDauw/WikibaseQuery#6 (master - 0118b82 : jeroendedauw): The build has errored. [23:52:01] [travis-ci] Change view : https://github.com/JeroenDeDauw/WikibaseQuery/compare/5f9a5b10d79d...0118b82839f4 [23:52:01] [travis-ci] Build details : http://travis-ci.org/JeroenDeDauw/WikibaseQuery/builds/14049463