[20:01:13] RoanKattouw: hi! [20:01:18] Hi [20:01:48] so i haven't got around to finalize the opt-out survey yesterday. my apology [20:01:56] No problem [20:02:03] i will be working on it today and tomorrow [20:02:08] Don't have much time for work this week anyway [20:02:16] that's right [20:02:33] did you have a chance to connect with brion about opt-in/out data generation [20:02:42] Not yet [20:02:52] I just asked him about something else though, and we got a little success there [20:03:11] I got his green light on moving the [edit] link to after the section header instead of before [20:03:25] Right now it looks like it comes after but that's CSS magic [20:03:25] cool [20:03:44] that's great [20:04:22] I had to give him an implementation plan, right? [20:04:50] re the database change for opt-in/out [20:05:10] Yeah [20:05:17] as we do not enable it on day one, it is not critical to have it ready for july 1 [20:05:28] Well the implementation itself is done already [20:05:31] but it will be good to get a support on the idea at least soon [20:05:37] All I really need to do is give Brion a link :P [20:05:46] brion: You getting this? [20:06:00] i think he stepped out for lunch [20:06:03] trevor too [20:06:05] Yeah [20:07:04] let's check-in with brion if he can support us to move Acai to test.wikipedia.org [20:07:22] today or tomorrow would be ideal [20:07:57] Yeah that'd be nice [20:08:07] Not sure he wants to do that on a Friday though [20:09:03] I can live with Monday, but mondays tend to be hectic for everyone at the office [20:10:34] Back when scaps were sort-of-weekly, they used to happen on Tuesdays for that reason [20:11:06] Monday's filled with backlog, later in the week is bad cause all kinds of issues may come up over the weekend if you scap on, say, Friday [20:11:16] Of course no one really *cares* if test.wikipedia explodes for a few days [20:11:45] i do ;) [20:13:05] trevor is back from lunch [20:13:12] HELLO! [20:13:17] Welcome back [20:13:28] what happened with the patch? [20:13:30] I just committed the [edit] thing, will scap prototyype [20:13:41] Brion approved of the part where we change the order [20:13:54] He hasn't answered about removing float: right yet [20:13:59] Presumably he's still lunching [20:15:20] I'll also scap sandbox for the NavigableTOC changes [20:27:24] TrevorParscal: WTF? For some reason mvembed isn't including jQuery... [20:27:47] that's really strange [20:27:51] on the sandbox? [20:28:09] Yeah [20:28:19] The coexists option prevents UI from including jQuery [20:28:27] And now I get lots of errors saying $ and jQuery are undefined [20:29:20] checking with michael [20:34:34] he changed something... [20:35:28] Only included jQuery on pages where he needs it? [20:35:51] Hmm http://bug-attachment.wikimedia.org/attachment.cgi?id=6271 [20:36:11] That's https://bugzilla.wikimedia.org/show_bug.cgi?id=19399 [20:45:18] hmm [20:47:42] the german wikipedia pages look strange [20:48:05] de prototype? [20:48:32] yes [20:48:36] What's strange about them? [20:49:13] i fixed it [20:49:27] remember that strange background bug that we had a long time ago [20:49:31] on de prototype [20:49:57] well, I changed the way the HTML is structured, which makes the bug no longer happen durring the corse of IE6 tweaks [20:49:58] The white background thing? [20:50:09] and then it made our fix actually break it [20:50:14] so I just removed our fix [20:50:18] lol [20:50:25] which is great, cause now that's even less we have to do to deploy! [20:50:57] why does shared.css make all headings inline? [20:51:01] is that something you did? [20:51:13] Dunno, look at the diff [20:51:29] Simetrical wrote most of that patch, I just updated for Vector, resolved conflicts and reviewed [20:52:10] ok [20:52:11] well [20:52:18] yes, this revision is broken [20:52:25] look at the home pages of our prototypes [20:52:41] the inline style is making the color box headings look wrong [20:53:07] 2 ways to fix [20:53:53] every page in every wiki needs to be different, or we come up with another way to place the edit link on the right, even if it's after the heading in HTML [20:54:06] the latter seems best - I will se what can be done [20:56:01] You mean float: right it again [20:56:49] ? [20:57:52] How is this even related to the positioning of the edit links BTW? [20:57:58] The main page doesn't have them [20:58:11] it uses headings [20:58:20] and when headings are set to inline [20:58:22] it affects them [20:58:31] Right [20:59:33] we need to roll this back actually [20:59:47] Go right ahead [20:59:56] But do figure out a way to fix it :) [21:00:08] of course [21:00:15] sorry, I have so much on my plate with RTL right now [21:00:16] You're a hundred times better at all this CSS stuff than I am so I'll just leave it to you [21:00:17] :( [21:00:24] no worries [21:00:24] Yeah that sucks [21:00:25] um... [21:00:35] Fortunately this is of lesser priority right? [21:00:37] ok, so what shall I do to roll this back? [21:00:56] Never reverted something in SVN before? *evil grin* [21:01:06] Are you using TortoiseSVN or the command line or what? [21:01:38] command line [21:01:43] I guess I know how [21:01:44] sorry [21:01:45] svn merge -c -12345 [21:01:56] Then svn commit [21:02:53] Be sure to format your commit summary as something like Revert r12345 ("excerpt from r12345 commit msg here") ... [21:03:19] Hey I just discovered a small bug in the toolbar [21:03:24] k [21:03:40] When you click a tab, you don't see an arrow for a while, because the browser has to download the down arrow image first [21:04:32] we should preload them [21:04:59] can you revert the changes to the parser which changed the output order of section edits? [21:05:06] I did the CSS [21:05:16] but I don't know what else you had to toy with [21:05:37] I'll revert the entire rev [21:05:41] I'm sorry, i know I asked you to do this, but Brion and I decided to hold off until a week after Acai (the week you will be here) [21:05:42] :) [21:06:00] No worries, saw your conversation [21:10:24] Done [21:17:31] TrevorParscal: Are Neil and Salijah (sp?) on board yet? Will they be by the time I get to SF? [21:17:45] They are not coming on board [21:17:47] either of them [21:18:26] Oh? [21:18:39] You guys are still looking to hire, right? [21:18:46] yes [21:19:14] Any particular reason that's appropriate for this public place? :) [21:20:02] They found other offers that better suited them afaik [21:20:14] i was just responding to we are still hiring part [21:20:46] nkomura: Yeah, I got that, I was wondering why they weren't coming aboard. But I guess that was their choice then, not yours [21:21:29] we wanted them and welcomed them, but sadly they chose different path [21:21:33] ce la vie [21:21:42] Yeah [21:21:44] off to meeting, later [21:37:29] so to preload that image - you just add an extra div tag which has the same class as a selected tab, but add display:none to it [21:37:34] the browser will preload it [21:39:15] sorry for crushing your dreams RoanKattouw and TrevorParscal :D [21:39:55] you mean the edit link position thing? [21:40:14] *TrevorParscal is confused [21:41:42] No worries brion; TranslateWiki was also complaining [21:41:52] I messed up their Special:Specialpages and the headers in the nav bar [21:42:40] heh [21:53:22] nkomura: ooh pretty screenshot in yer blog :D [21:53:53] nkomura: which train we taking down? the 5:14 express should get us there at 5:56 (allegedly) ... but then we still gotta walk to the location [21:59:05] where is naoko? [21:59:11] stillman? [21:59:51] brion_: is changing the HTML output based on RTL / LTR acceptable? [21:59:53] I mean... hmm [22:00:19] I'd say not [22:00:28] IE6 cannot make a left aligned right list with right floated items [22:00:54] so, I could not use lists... that's one option [22:01:03] then the navigation is no longer nice ULs though [22:01:04] hmmm [22:01:23] WTF [22:01:27] How does Monobook do that? [22:01:31] checking [22:01:39] they dont [22:02:41] they just let the lists stay in the wrong order I guess [22:03:00] that is, the user tools list [22:03:09] which is the one that must be right float left aligned [22:03:18] is this to say that this is acceptable? [22:03:48] I don't know, just wondering how monobook solved it [22:04:22] they did not - so I will not [22:04:36] now I can move on with my life [22:05:08] TrevorParscal: where necessary we do on occasion, though most of it's been moved to css i think over the years [22:05:16] check ->isRTL() [22:06:10] yeah [22:06:18] OK - so it's not a cardinal sin [22:22:01] what has the ->isRTL function? [22:22:05] TrevorParscal: You around? WTF @ http://prototype.wikimedia.org/s/index.php?title=Sandbox:About&action=edit [22:22:10] I'm very sure that method exists [22:22:33] michael JUST messed with that site [22:22:58] Hmm [22:23:04] This can hardly be Michael's doing [22:23:18] I'm just noting the coincedence [22:23:30] you sent me the message at the same time as he sent http://prototype.wikimedia.org/sandbox/Stream:Explain_editing [22:23:54] thats a really strange error [22:24:10] oh, he changed the sandbox to a different branch, maybe there were parser changes [22:24:11] there [22:24:19] in the other branch.. [22:24:22] (no clue) [22:24:29] Well I looked at s/includes/parser/ParserOutput.php and it clearly has that method [22:24:52] No, I added that method recently, branch probably hasn't been updated for that yet [22:25:16] Ah, I see s_old now [22:41:25] *parutron enters! [22:41:44] hello team! sorry for joining our room so late in the game. [22:41:50] Welcome [22:41:56] I'm gonna say goodbye soon, it's nearly 1 am [22:41:58] thanks roan, for setting this up. [22:42:06] No problem [22:42:16] we are looking forward to having you stateside soon! [22:47:25] RoanKattouw: can you make elephant do a trick to welcome Parul? [22:47:33] maybe tomorrow [22:47:34] !welcome | parutron [22:47:34] --elephant-- parutron: Welcome to the Usability Initiative! [22:48:11] :) [22:48:40] brion: I think Vector and toolbar are getting ready to be staged at test.wikipedia.org [22:48:46] parutron: For the record, elephant also logs everything said here to a public place, so don't say super-secret stuff you don't want everyone to read here ;) [22:48:55] nkomura: Brion's busy right now [22:49:00] oh [22:49:03] super secret stuff! [22:49:12] Michael Jackson is being reported dead and the servers aren't liking the traffic very much [22:49:28] is it a true story? [22:50:07] Not officially confirmed yet [22:50:17] He has been taken to hospital though [22:50:34] Oh wait [22:50:44] http://latimesblogs.latimes.com/lanow/2009/06/pop-star-michael-jackson-was-rushed-to-a-hospital-this-afternoon-by-los-angeles-fire-department-paramedics--capt-steve-ruda.html [22:51:36] huh. [22:51:52] LA Times says he's dead [22:54:24] Both CNN and NYtimes report the news too