[15:53:22] howdy [15:56:10] hi naoko [15:56:24] *werdna lols at roan trying to override mlock [15:56:57] hi andrew [15:57:07] what is mlock? [15:59:03] 12:14 -!- mode/#wikipedia_usability [-t] by RoanKattouw [15:59:04] 12:14 -!- mode/#wikipedia_usability [+t] by ChanServ [15:59:10] Why that happens [16:04:10] from googling, i suppose it is memory management? [16:08:18] all prototype sites are down [16:23:39] huh? [16:25:41] http://prototype.wikimedia.org/en.wikipedia.org/Main_Page [16:25:47] Fatal error: Call to undefined method HttpRequest::useragent() in /srv/org/wikimedia/prototype/wikis/en-wp/includes/HttpFunctions.php on line 372 [16:25:56] i think the most software updates broke them [16:26:02] i mean most recent [16:26:17] i don't see roan on line, so i sent him email [16:37:20] werdna: thank you for running the stats for us yesterday [16:37:31] hi brion [16:37:40] no problem, it's easy to do. [16:38:34] yo yo [16:38:36] having fred take a peek at the server [16:38:38] but we don't seem to have the right pass ;) [16:38:52] I've got root there too [16:39:03] i think it is from the recent update [16:39:13] was helping Trevor set up some of the MW stuff. [16:39:35] brion: I can set up fred/you/somebody an account on that box if you like [16:40:57] werdna: stick in our root key probably might be wise :) [16:41:11] I have no idea what your root key is :) [16:41:22] looks like it's not a server borkage though, mediawiki's broken on it [16:41:25] Fatal error: Call to undefined method HttpRequest::useragent() in /srv/org/wikimedia/prototype/wikis/en-wp/includes/HttpFunctions.php on line 372 [16:41:53] me thinks sw error too [16:42:18] yeah [16:42:34] probably just an update conflict or something [16:42:44] is there easy way to revert back the previous version of sw? [16:43:05] we should be able to figure it out pretty quick, yes :) [16:53:02] nice [17:21:15] ... [17:23:03] TrevorParscal: hi! [17:23:11] hi! [17:24:01] TrevorParscal: brion and fred are looking into reverting the SW on prototypes [17:25:29] i'm doing it right now [17:25:58] thanks [18:05:35] yay, protoptyes are back up [18:05:37] :) [18:13:45] woohoo [18:56:08] TrevorParscal: just a note to look into; atm i don't see the pdf version link (from Collection ext) in the toolbox in vector. that been resolved in svn? [18:58:06] http://www.mediawiki.org/wiki/Extension:Collection uses MonoBookTemplateToolboxEnd [18:58:39] Vector provides an identical hook called VectorTemplateToolboxEnd [18:59:09] It seemed illogical to call a Monobook hook in vector [18:59:21] I could patch Collection to call both hooks with the same function... [18:59:32] seems messy that we have this situation at all [18:59:47] is there a reason it wasn't just SkinTemplateToolboxEnd ? [19:00:18] in fact, Modern calls SkinTemplateToolboxEnd [19:00:39] Vector calls both SkinTemplateToolboxEnd and VectorTemplateToolboxEnd [19:01:09] monobook calls both SkinTemplateToolboxEnd and MonoBookTemplateToolboxEnd [19:01:38] so, it seems to me that the Collection extension writers should have chosen to use SkinTemplateToolboxEnd if they wanted it to show up on templates other than monobook [19:03:01] they even call the hook they are attaching to this insertMonoBookToolboxLink [19:03:20] so, yeah... not sure if they meant to use SkinTemplateToolboxEnd or not [19:03:36] brion: perhaps you do? [19:03:58] no idea [19:04:22] *TrevorParscal eats stroop waffle [19:04:49] shall I mofify the collection extension to make it use SkinTemplateToolboxEnd ? [19:08:28] brion: perhaps I could report it as a bug in bugzilla? [19:10:46] TrevorParscal: mail heiko & johannes and ask em to test their ext w/ vector :) [19:10:59] what are their emails? [19:18:14] brion: poke [19:18:25] emails + lunch poke... [19:18:33] TrevorParscal: sent you a mail w/ such [19:18:40] cool [19:18:41] we're in the middle of upload borkage [19:20:23] sorry to bug [19:20:27] oh no... [20:06:15] "Celebrities use Acai Elite to have a fabulous body." [20:06:21] bwahaha [20:06:38] so, brion, do you? [20:06:52] what can i say, i'm a sexy sexy man [20:06:58] i attribute it all to the vector skin [20:07:59] better than bitmap one - it's not stretchable/shrinkable without lose of quality ;-) [20:13:47] unfortunately i've been scaling out lately :P [20:13:57] need to recompress [20:58:41] Hi, sorry for the prototype downtime folks [20:59:01] hey roan [20:59:44] was it the feedback updates which broke it ? ;) [20:59:57] No, not my code [21:00:11] I updated all of the code, and someone changed something else somewhere that broke it [21:00:21] TrevorHungry: What did you do to fix it? [21:02:02] RoanKattouw: he reverted it [21:02:11] and patched something for DB error [21:02:12] Ah [21:02:18] *RoanKattouw hmms @ DB error [21:02:20] at least that is what he said [21:02:29] *RoanKattouw goes to look at the servers [21:03:22] OK I'm gonna try to apply my changes again and this time I will be around to fix stuff when it breaks [21:06:29] TrevorHungry: Oh, I was so stupid, I TRUNCATEd all those tables and expected update.php to recreate them (wiki_??_wp.optin_survey), but I needed DROP TABLE [21:06:33] it is currently working [21:06:46] Fatal error: Call to undefined method HttpRequest::useragent() in /srv/org/wikimedia/prototype/wikis/en-wp/includes/HttpFunctions.php on line 374 [21:06:49] There it is again [21:06:53] Let's fix it this time [21:06:55] with your feedback survey stuff [21:16:23] OK, prototype updated and back up [21:22:15] RoanKattouw: Howdy! [21:22:29] Afternoon [21:22:33] Late lunch :) [21:22:59] I fixed the fatal errors, they were caused by mdale's "fixes" to his branch merge [21:23:22] RoanKattouw: cool - please feel free to cleanup my patch stuff [21:23:34] it's probably not quite right, but it got things working again [21:23:35] No problem [21:23:55] I thought I'd DROPped the tables before running update.php, but it turns out I'd TRUNCATEd them instead [21:32:27] so, is output buffering allowed in mediawiki development? [21:33:44] OutputPage buffers its output [21:33:47] Why do you ask? [21:34:38] working on something that would be much easier if I use php's ob_start() / ob_get_clean() [21:34:41] but.. [21:34:43] hmm [21:34:47] not sure if that's allowed [21:34:51] Sure is [21:34:59] It's perfectly safe to nest ob_*() calls [21:35:08] *TrevorParscal messes with it [21:46:15] found a new signature icon in de prototype [21:46:28] very intuitive and cute ;)