[11:44:37] yikes [11:44:59] the toolbar doesn't load at all on Safari 2. [11:46:46] Any JS errors? [11:48:10] "Syntax error, unrecognized expression: html" Line 0 undefined [11:48:26] "undefined" Line 0 undefined [11:48:37] Does it give any better clues as to where the error is than Line 0 ? [11:48:43] nope. [11:48:48] which is unusual. [11:49:32] i think it is just the [11:49:58] Can you check on prototype? IIRC that's not configured to serve HTML 5 [11:50:01] let's see if i have that same error on en.wp [11:50:12] RoanKattouw: this was on prototype. [11:50:20] Oh [11:50:25] Does prototype serve HTML 5? [11:50:29] I didn't know that [11:50:36] Or maybe it's the default setting... [11:50:47] Simetrical: Is HTML 5 on by default? [11:57:25] JS in safari 2 really sucks. [11:57:42] but perhaps a fallback to the old toolbar ? [11:57:52] *thedj will file a bug [11:59:18] thedj: Using what? JS? [12:00:40] for instance. [12:01:29] JS execution halts on JS errors [12:01:38] there is no error though. [12:01:43] Hm [12:08:29] there bug filed. [12:37:50] RoanKattouw: suggestion on usability, is an unobtrusive indicator for wether a page is watched or not. (as this is no longer directly visible because the watch tab is now in the dropdown). [12:38:03] http://usability.wikimedia.org/wiki/Talk:Babaco_Designs#Watch_page [12:38:14] You mean like the Firefox bookmark star [12:38:22] Yeah, we're aware of that suggestion, and Brion likes it [12:38:35] But you should really be poking Trevor about design stuff, I suck at that [13:27:28] RoanKattouw, yes, it's on by default. Set $wgHtml5 = false; to turn it off. Theoretically it should be causing no problems. [13:27:44] Can I easily try reproducing it? [13:28:02] Or does it require some baroque ten-step installation procedure, or is hard to reproduce or something? [13:28:28] Simetrical: thedj says Safari 2 messes up JS because of the [13:28:41] And I frowned at that because I didn't recall enabling HTML 5 on prototype [13:28:53] But like you just said it's on by default [13:28:58] It's on by default. Are you sure it's because of ? [13:29:06] It shouldn't causing problems, supposedly. [13:29:15] Except for switching from "almost standards" mode to standards mode. [13:45:21] Are either of you looking at this? I don't have easy access to a Mac. [13:49:43] I don't have a Mac either [13:49:45] thedj was looking at it a while ago *poke poke* [13:52:22] huh ? [13:52:48] thedj> i think it is just the [13:52:51] oh, yeah Safari 2 reported that in the log when i opened the prototype page. [13:53:12] it's not a real problem. doubt anyone will notice it. [13:53:16] OK [13:53:31] But you said that you get an error on prototype but not on enwp, even though the toolbar is blank on both? [13:54:15] if this is indeed due to html5, then the toolbar fails silently on both. [13:54:35] the "html" error was the only error I had, and it was only on prototype [13:55:20] Try setting $wgHtml5 = false. [13:55:34] It might be a bogus error, just reporting it at the first line for no reason. [13:55:45] Does anyone still use Safari 2? Does it happen in other browsers? [13:55:53] only safari 2. [13:56:39] and i only have Safari 2 to test wikipedia and some other websites. hardly anyone uses it I think. [13:56:47] Not terrible, then. [13:56:56] Would be good if this could be investigated further, though. [13:57:14] Nah, especially considering Safari 2 doesn't support jQuery or proper DOM stuff or pretty much anything more than stone-age JS [13:59:32] Okay, then. [16:08:47] Morning TrevorParscal ; would you approve of a namespace with Talk, User, User talk, etc. [16:09:57] In front of the textbox where people type the link target for an internal link [16:10:16] oh [16:11:01] similar to what's going on here -> http://prototype.wikimedia.org/en.wikipedia.org/Special:AllPages [16:11:05] ? [16:11:25] Aye [16:11:50] That exact dropdown with a text field behind it [16:13:24] yeah - but the text field should be on the right of the namespace [16:13:38] always maintain the order [namespace] [title] [16:13:54] Aye that's what I said [16:13:59] A text field behind (to the right) of it [16:14:04] what's going on with head? [16:14:16] What do you mean? [16:14:18] oh [16:14:20] working now [16:14:31] was complaining about the linkscript method of the Html class [16:15:07] Oh there was this thing earlier today where Simetrical wanted to start fixing a bug and he fired up MW and it gave a fatal error because someone used $dbr four lines before it was initialized ^^ [16:19:34] ha ha [16:20:02] RoanKattouw: suggestion on usability, is an unobtrusive indicator for wether a page is watched or not. (as this is no longer directly visible because the watch tab is now in the dropdown). [16:20:14] Seems like Brion's idea of the Firefox bookmark star is popular [16:20:17] "You don't want to end up in the middle of invalid memory! hello? hello?" [16:20:20] hey TrevorParscal [16:20:24] hola [16:20:28] hehe [16:20:59] "You see, the driver hooks a function, by patching the system call table, so it's not safe ot unload it unless another thread's about to jump in and do its stuff" [16:21:11] TrevorParscal: wanna have a peek at the state of the LQT interface? [16:21:13] stupid question time.. if I want to modify the enhaced EditToolbar, the code suggests modifying the editToolbarConfiguration-variable, but how to do this through f.ex. Common.js when the EditToolbar.js is loaded afterwards? [16:21:23] werdna: yes! [16:21:24] TrevorParscal: i's cool if you don't [16:21:28] hven't done much today [16:21:36] looking [16:21:44] Tubarao: There's a new API for modifiying the toolbar, but it's not live on Wikipedia yet [16:21:51] I may have got distracted for most of the day and am starting work at 5pm and will have to work until I pick up my gf from the bus stop at 1am ;) [16:21:59] RoanKattouw: it's not? [16:21:59] *Tubarao wants now.. ;) [16:22:07] Tubarao: See http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js?revision=54967 for example usage [16:22:19] morning brion [16:22:37] TrevorParscal: No, why would it be. You rewrote half the toolbar, Brion's not just gonna glance at that and say "sure, I'll just quickie deploy that" [16:23:00] Which is also why I didn't try to get him to in the first place [16:26:39] actually the refactored version is live [16:26:45] Oh, didn't know that [16:26:54] however, the latest API improvements are not [16:26:58] Ah [16:27:13] only crude removing works [16:27:28] you may have been gone that week [16:27:32] it was a 2 day process [16:28:29] TrevorParscal: I'm slapping a class="namespaceSelector" on the to be empty initially. Any suggestions where the code for async filling $('select.namespaceSelector') should go? [16:29:14] on dialog load? [16:29:30] Well like I just said that's really too late [16:29:41] I'm contemplating changing the toolbar code to execute init() earlier [16:29:47] Like on load time [16:29:53] i mean, what's going to happen when the user selects the text MediaWiki:SomeMessage and the box is supposed to be filled out for them [16:30:07] it needs to happen BEFORE dialog load [16:30:12] Exactly [16:30:31] why don't you build the dom before the dialog is triggered, then attach it after it's loaded [16:30:32] Not only because of what you said but also because the user would see the if i can't edit it; it's kinda confusing as is [18:50:22] isn't it read only? [18:51:21] I think I can just remove that requirement [18:57:46] brion: Merge done. Pretty messy one, so I recommend you put it on test first and let Trevor confirm it's working correctly before pushing it live [19:09:04] whee [19:12:39] RoanKattouw_away: good work! [19:13:15] RoanKattouw_away: uh, was that the update on wmf-deployment? cause it's live now i think [19:26:10] brion: Hm OK let's hope it doesn't explode then [19:27:55] haha [19:27:58] well poke it and see :D [19:33:38] brion: Hm it works but I need to raise some style versions, the old version is still cached [19:33:49] ok lemme poke that local [19:35:00] Brion, when LU is on your testsystem... tell me and I blog about it :) [19:35:02] TrevorParscal: Nice job on the