from the top level (child of ) to the same level as the textbox (i.e. it becomes a sibling of the textbox), to counter issues with jQuery Draggable [18:53:22] hey mdale is here! [18:53:26] hi ;) [18:53:31] hi [18:53:33] hi [18:54:26] *mdale wonders if gaim has a vertical channel list plugin [18:55:06] RoanKattouw: yeah, the layout stuff is mostly changing [18:55:08] no more ta [18:55:10] table [18:55:27] Ah [18:56:34] ah... options placement tabs placement "left" ... cool I can simultaneously be logged into at least 10 more channels now ;) [19:04:09] TrevorParscal: no problems with http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56045 ? [19:08:14] brion: looks reasonable [19:08:33] yay :D [19:08:35] *brion marks it ok [19:08:37] was there specific reason to adding the #head to the rules? [19:08:43] - div.vectorMenu h5 { [19:08:44] + #head div.vectorMenu h5 { [19:08:59] i'm ok with that, but it's curious [19:09:41] maybe the h5 rule wasn't strong enough somehow? [19:10:09] firebug shows me no diff [19:14:31] no idea [19:15:02] well, it's not hurting anything, I will just ask in the review tool [19:15:17] :D [19:19:16] RoanKattouw: return ( param[0] == '_' ? undefined : conf[param] ); [19:19:35] Is that my code or yours? [19:20:30] why are we checking if the param starts with _ ? [19:20:34] well, it's from suggestions.js [19:20:36] jquery.suggestions.js [19:20:38] at the bottom [19:20:42] I'm nearly done reworking it [19:20:48] Because conf._data is used internally [19:20:57] And I don't want the outside world to touch that [19:21:12] At the time I left room for other private stuff to be defined starting with an underscore [19:21:15] ah [19:21:24] I'm also nearly done [19:21:37] why not just block "_data" specifically [19:21:49] Yeah that's better in hindsight [19:21:51] Good idea [19:21:53] :) [19:22:14] BTW I decided not to move the

after all, instead I'm just checking if there's a parent that's .ui-draggable and hooking into the 'drag' event if so [19:22:34] Because having the suggestions

inside the results in an ugly-looking table [19:23:02] I'm about done with the new code for this and it uses all divs [19:23:15] no more table [19:23:20] Yeah but outside of it, in the link dialog, it's still in a table [19:23:26] it behaves much more reliably [19:23:43] So you'd have

suggestions stuff here

[19:23:47] and that looks ugly [19:23:55] So I'm just keeping it where it is, appended to [19:24:10] just wrap the in a div [19:24:36] then when the suggestions are made as a peer, they are all containted together [19:24:42] hmm [19:24:48] well - we can play with this [19:27:29] The way I've got it now is OK [19:27:38] I'm just gonna do caching for the suggestions and then I'm done [19:28:45] ym [19:28:46] um [19:28:52] before you do that [19:28:54] let me commit [19:29:01] then you can do caching on my code [19:30:17] Doesn't matter [19:30:29] (we're probably gonna conflict anyway, but not on caching) [19:30:46] The caching is not built into the suggestions plugin on purpose [19:31:12] ialex * r56060 /trunk/ (2013 files in 76 dirs): [19:31:36] oh [19:31:39] where is it? [19:31:56] In the handler function that fetches the results [19:32:22] Mainly because caching is ridiculously easy to do in the caller [19:44:08] TrevorParscal: OK I committed my changes, if you don't feel like dealing with any resulting conflicts just type 'mf' (mine full) when svn update nags you about them and tell me to sort them out [19:44:37] thanks! [19:44:39] he he [19:44:50] I will look at your changes and try and prevent you dealing with too much [21:30:57] brion: so we were thinking, should we have some special syntax for 'tags' in the code review tool? nothing too fancy as of yet, but if we put something down in the comments like !acaifix, for now it could link to a wikipage explaining what "acaifix" means, then later we could make it searchable etc etc? [21:31:41] *TrevorParscal likes idea of tags being extracted from commit messages [21:33:38] sure could do, i think i proposed this back when i started but ain't got around to implementing :) [21:33:57] throw it at aaron :) [21:49:58] lol @ /topic [21:50:03] and hello everybody [21:51:38] hi danny [21:51:39] bunch of people contacted me recently that they are using vector and monobook simultaneously and if there is chance to have personal common.css and common.js since they don't want to set everything twice (or even more times) [21:52:35] ??????????????????naoko [21:53:18] brion: also, if you can check out the clicktracking code some time this week, that'd be spiffy =) [21:53:43] no guarantees of anything that's not directly involved in getting live software updated this week [21:55:43] ok [22:01:26] CGD? [22:05:25] some of that stuff is broken [23:48:23] nimish_g, TrevorParscal btw the existence check for links is unintuitive [23:48:27] orange / green dots [23:49:12] werdna: roan did that, I made the icons round - I think we need to use the blue / red colors of links [23:49:18] this is something we are going to look at [23:49:21] mmm