, then on the wrapper [15:45:51] interesting [16:02:22] RoanKattouw_away: about your comments [16:02:26] you still there? [16:03:53] darn [16:23:22] TrevorParscal: Yeah? [16:23:25] (was eating dinner) [16:23:56] I replied to the comments in the code review tool [16:24:02] maybe read them first [16:24:06] OK I'll read them in a sec [16:24:09] then we can devise some plots :) [16:25:06] OK read it [16:25:25] ok, so disabling os_suggest [16:25:37] How about fixing mwsuggest.js so the disable function works/ [16:25:51] that could work [16:26:12] I know mwsuggest.js quite well by now, unfortunately :) [16:26:24] ok - you can head that up :) [16:26:39] i will remove the superfluous results rendering bit [16:26:40] OK gotta postpone that to after your lunch though [16:27:11] Leaving for badminton practice in 20 mins and last time I went there I ended up playing for nearly 3 hrs [16:28:12] no worries [16:28:33] it's working now, but it would be better if - as you say, we don't depend on their implementation [16:39:27] TrevorParscal: let me know when you have a chance to touch base on js2 stuff... [16:39:37] ok [16:39:40] probably will today [16:40:13] I could take a quick pass at making your code optionally js2 friendly if you want... [16:40:24] its only a few function changes... based on a conditional [16:40:45] (in your main hooks file) [16:41:08] then there is lot of other stuff "we could do" ... [16:44:55] you mean like class loading? [16:48:21] no.. I mean just loading normal scripts through the script-loader... in the future we should can do more loading after initial page display. [16:49:28] yeah [16:50:28] hmm but you seem to have some scripts going in via addResources and some going in via addScript [16:51:52] whcih use addScript? [16:51:57] I think what we want to do .. is re-factor the msg fallbacks to outputPage (for when script-loader is off) [16:52:36] msg fallbacks? [16:53:58] mdale: addResources is a way to take all the scripts, messages and styles that have been added and actually add them to the page [16:54:31] so, there's 2 stages, collecting all the resources via addScript, addMessage and addStyle - then actually adding them with addResources [16:54:43] probably not the best naming scheme [16:55:06] addResources should be addResourcesToPage or something to make it more clear - but it's temporary code I think [16:55:28] the functionality to add message and global variables to the output page object needs to be created [16:58:19] (when you output your gM call directly to the page) ... then you can just use the new trunk for handling versions of files and have it work with script-loader off .. [16:59:25] yea your recreating the Outputpage functions [17:00:03] we should do something like: http://www.mediawiki.org/wiki/ScriptLoader#How_to_use_the_ScriptLoader_in_your_Extension [17:00:13] well, we need to sort of unify the approach to adding this type of content from the php space into the javascript space [17:00:14] it will still work fine with the script-loader "off" [17:00:57] except that we have to add in fall-back localization support for when the script-loader is off... [17:01:19] yeah [17:01:26] pretty easy to add in [17:01:38] the way I am doing it was my way of dealing with the transition period [17:01:40] of course [17:01:41] right [17:02:10] hi brion [17:02:35] bye brion [17:02:43] he he he [17:03:43] hi again [17:04:31] If agreeable to Brion timeline for js2 integration we should just target integrating that fall-back gM functionality into the trunk and Outputpage.php since it already covers a lot of that functionally you have in the hooks file. [17:05:50] then its just a configuration var switch to test all the script-loader and native js2 stuff. ... while retaining fall-back to non-script-loader in case it runs into bumps on its path to deployment. [17:09:20] TrevorParscal: there might be some minor problems with some existing modularity conventions .. like in js2 we try to have each "class" / "js file" define a object that can be tested like the variable $j.jcrop is defined in jquery.jcrop.js ... and we test against that to see if the script file was successfully loaded parsed (and so we don't have to load it again) ... that might be tricky with jquery.wikiEditor.dialogs.js for example [17:09:48] how so? [17:10:14] jquery.wikiEditor.dialogs.js creates $.wikiEditor.modules.dialogs [17:10:17] does jquery.wikiEditor.dialogs make "typeof $j.wikiEditor.dialogs non null [17:10:19] oh oky [17:10:21] cool [17:10:33] yeah, we should mostly be good on stuff like that [17:10:44] but where we are not, we can make fixes [17:10:49] oky sorry was non-obvious cuz of api usage... [17:14:48] And or we could add a "loader" ... then just load stuff via mwLoad as well... it just depends how aggressively you want to jump into the js2 stuff. ... I think we are getting close to js2 deployment as Tim has been "sanitizing" the js2 folder ;) [17:15:27] *TrevorParscal runs around franticly looking for power supply! [17:15:52] ok [17:15:58] well, i think deploy js2 [17:16:09] then make our stuff js2-riffic [17:19:25] right...but I can only put it in trunk and respond to bugs ;) [17:19:54] tim sanitizing? [17:20:02] what does that mean? [17:21:55] ... removed html example files, removed remote references to things... something along the lines of if one of the example_folder examples links to jquery.ui php based custom style sheet system thing .. then if they get comprised it would make it easier for people to send links to the static html pages on a given wiki to compromise that persons wiki credentials? [17:22:51] interesting [17:24:05] kind of a ~remote~ possibility... but whatever... can rewrite the examples without external dependencies ;) [17:27:05] hi everyone, can anyone explain what "state of issue" means (has something to do with my ID or drivers license) [17:27:24] state means location [17:27:34] issue like, they issue you a license [17:27:45] so the state of issue would be where you got your license at [17:28:21] in this particular context that is of course [17:29:40] like the name of the city? [17:29:44] or state? [17:41:04] do you not have states in Germany? [17:49:07] they're bundeslands [17:50:25] i love that word [17:50:33] how's it going nimish_g ? [17:52:13] good, I have something pretty AND functional that works on my localhost. It might be up on prototype later =) [17:53:02] just to check, (esp with brion ) we're moving to doing all ajax-ish things thru API extensions, right? [17:53:35] yes [17:53:42] afaik [18:00:57] please :D [18:01:00] kill sajax [18:02:19] ha ha [18:02:22] seriously! [18:10:55] I still can't get used to the large text size on google's home page [18:11:20] "Google, now blind people friendly (for at least the home page anyways)" [18:11:24] lunch - brb [18:16:16] The buttons are huuuge. [18:27:18] Annemarie: and they look terrible on OSX cause they are just past the native control style limit [18:45:53] Is all the software of the usability initiative that can be found in the prototype the same as what can be found at translatewiki.net ??? [18:46:11] Remember translatewiki.net runs at the bleeding edge of MediaWiki ... [18:47:10] the reason for asking ... for several languages adoption of the software is not great because of a lousy localisation. [18:47:35] when people test at translatewiki.net, they can improve on the localisation straight away [18:47:51] and see the effect [18:48:31] GerardM-: it should be, but I'll definitely double-check that [18:49:16] translatewiki.net for instance does support the Telugu characterset [19:04:04] TrevorParscal: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56045 <- do we need to fix this or just revert it for now? [19:04:38] looking [19:04:42] tx [19:05:15] oh - he made a reasonable point - i think we are good [19:05:24] yay [19:05:30] mark as ok? [19:05:48] yeah [19:06:36] *poink* done thx :D [19:32:33] hey brion - open web people want to take us up on the hosting offer [19:33:22] brad is asking me (i think I've been in better communication lately with brad) to get a server setup / give him IP to direct domain to... [19:33:39] This is obviously not really my field - and I realize it's not a high priority [19:34:24] but I was hoping you might be able to either get in touch with him and work with him on this, perhaps assign someone else who can do it like fred? or perhaps we can just tell them we can't do it right now [19:34:29] thoughts? [19:35:19] spiffy [19:35:27] :) [19:36:07] it's the Open Web Developer Network now - so the url is going to be www.owdn.org [20:05:26] when did the motion effects get put back into the toolbar? [20:05:27] mdale ... [20:05:54] ok - so the thing is, the animations are wonderful, except when switching between tabs, they are not so wonderful then [20:17:56] Trevorpascal the owdn.org gets me godaddy.com ... [20:27:45] yes [20:27:55] there's no server to point it to yet... [20:28:03] Brad aparently used them to buy the domain [20:36:19] ah ok [20:55:31] TrevorParscal: yea look kind of odd then... [20:56:00] what I would like to see is what I've seen on lightboxes... and actually my website does this too [20:56:33] wonder what fade out fade in would look like... [20:56:35] the toolbar (or booklet) fades out, the size changes to accomadate the new toolbar (or booklet) the new one fades in [20:57:03] combine the fade out then fade in [20:57:05] with sliding [21:00:02] ... well whatever you want to put in there will probably work... just without slide in or some effect it looks weird how it just appears [21:00:47] maybe do some chain where the first thing slides out then the new thing slides in. ... as long as its "fast" should be better than instant swap [21:05:48] yeah [21:05:54] i will do it with callbacks [21:07:03] i just need to add a div that holds the size while the things fade in and out.... [21:07:07] shouldn't be too hard [21:07:27] I've just been avoiding too much purely aesthetic stuff thus far [21:07:41] understandable .... [22:35:26] TrevorParscal? [22:35:34] hi [22:35:38] hi [22:35:59] link dialogue now has page type drop down menu [22:36:13] on prototype [22:36:16] yeah [22:36:31] what is the rationale behind it [22:36:37] roan has been poking at that... [22:36:42] hmm [22:36:50] i guess to specifiy the namespace rather than use a colon [22:36:55] I asked Trevor for permissions [22:36:56] not sure I'm into it [22:36:57] *RoanKattouw hides [22:37:00] this is not a user friendly menu [22:37:00] now that i see it [22:37:11] yeah, that's more clear now that we have it [22:37:16] and it may confuse QA folks [22:37:41] yeah, roan, what if we turn that off at least on prototype so the QA people don't get confused [22:37:52] i see advantage for advanced users [22:37:59] Ah, that implies having an on and off switch [22:38:07] he he [22:38:12] can we add one? [22:38:17] I'll just take it out again, and we can just revert that to add it back in [22:38:29] Making an on and off switch is too much trouble IMO [22:38:51] As long as I remove it cleanly in one rev, it should be no problem [22:38:53] we can play with it on sandbox and discuss, perhaps? [22:39:06] Aye, we can leave the sandbox in the old state [22:39:17] thank you, RoanKattouw [22:39:38] yes [22:39:42] that's perfect [22:39:54] i'm sure there's a way we could make it work [22:40:41] When I work from home I get to eat all day... I'm pretty sure I will gain weight when I work from home for a week later this month [22:41:07] Hm something tells me it works the opposite way for me :) [22:42:06] hm? [22:42:09] oh - so mel's doctor said she's 2cm dialoated and 50% effaced [22:42:22] wow! [22:43:07] so... this weekend for sure but probably not tonight or tomorow morning, but likely friday night or sometime saturday [22:43:14] which works well actually [22:43:32] very thoughtful baby [22:43:46] indeed [22:45:17] nkomura1: so tomorow morning I am meeting with you, then yaron - and somewhere in the Adam is supposed to get started and needs some attention as well [22:45:29] yup [22:45:38] should be an exciting day [22:45:45] and ryan will start in the morning too (remotely) [22:46:07] i asked nimish_g to help adam to set-up the dev environment [22:46:36] let's discuss the initial assignment for adam when we meet tomorrow [22:47:33] is the light-blue for dialogue box suggested by parul? [22:47:53] i mean the border of the dialogue [22:52:03] um, no - it's the same color used elsewhere in vector, but not a whole lot of time has been put into the jquery-ui theme we are using [22:52:37] I generated one from their site http://jqueryui.com/themeroller/ and made some modifications [22:53:33] i think we need to soften the color more [22:53:48] yeah, maybe use more silver rather than pushing the blue... [22:53:50] but let's touch base with hannes and parul [22:54:08] sure [22:54:35] Ah, the QA folks submitted a few more bugs [22:54:41] i see parul's mock-up uses silver/grey [22:54:43] http://usability.wikimedia.org/w/index.php?title=File:ContentGeneration.pdf&page=2 [22:54:50] I'll take a crack at those on the train tomorrow [22:55:14] right on [22:55:17] cool [22:55:45] I'll finalize the resizing thing at that time as well [22:55:54] how's that going? [22:56:03] It mostly works [22:56:27] But it seems to underestimate the needed width a little bit, and doesn't take hidden stuff (AJAX spinner/cirle!) into account [22:56:38] The latter will actually fix the former in our particular case [22:58:09] *TrevorParscal eats vanilla mochi ice cream ball [22:58:20] om nom nom [23:03:10] hey RoanKattouw? [23:03:24] Yeah? [23:03:50] so link suggest-like feature doesn't work on prototype currently [23:03:59] was it disabled? [23:04:27] No, that's probably the z-index thing, lemme check [23:04:33] The QA guy even attached a video of that :O [23:04:43] :) [23:04:50] The suggestions dropdown didn't know that it had to be on top of the dialog rather than below it [23:05:00] i switched the article [23:05:04] and it worked this time [23:05:43] Probably the old CSS getting stuck in cache [23:06:05] TrevorParscal: Can you look into why jQuery Dialog seems to be missing on sandbox all of a sudden? Looks like our JS2 integration has gone wrong [23:06:21] sure [23:06:30] i see the suggestion drop down below the dialogue box too [23:07:38] Ah I forgot to update the CSS version number [23:07:42] Try to clear your browser cache [23:08:58] (Ctrl+R on most platforms) [23:09:07] grrr [23:10:21] sometimes michael makes changes that will affect us, but don't know about them until it breaks :) looks like jquery ui is not loaded when the toolbar is being build (specifically dialogs being built) [23:10:49] he does a lazy loading thing that is sort of causing this i think... [23:10:59] Yeah Mike actually moved the jQuery UI definition around in the hooks file [23:11:07] Lemme find that rev; see if reverting it fixes it [23:11:08] RoanKattouw: you are up so late, can you make school tomorrow? (I sound like your mother.) [23:11:36] nkomura1: I don't have school tomorrow. I only have two courses and the teacher of the busiest one is away this week [23:11:55] k, just checking ;) [23:11:56] TrevorParscal: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/55832 [23:13:08] No worries; you should be more worried about me working so little these last two weeks. I blame tennis :) [23:14:06] TrevorParscal: Oh did you see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56139 ? Someone came to me with that, it was pretty amusing, one syntax error 'fixing' another [23:14:55] ha [23:16:17] what the heck is going on with these includes on 55832 [23:16:28] there used to be a logical order to this... [23:17:38] Oh wait [23:17:52] It's Trevor's suggestions rewrite that screwed up the display thing [23:17:52] js2 provides jquery ui, but there's an issue still that js2 provides a jquery-ui skin that sort of makes the page go bonkers [23:17:59] haha [23:19:03] que? found bug in jquery.suggestions.js ? [23:19:45] See CR [23:19:50] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56126#c3995 [23:20:13] And https://bugzilla.wikimedia.org/show_bug.cgi?id=20587 [23:21:04] ah - that [23:21:12] yeah, I can see how that fell through the cracks... [23:27:46] OK TrevorParscal , nimish_g : I'll be squashing a few bugs this weekend. Basically, bugs 20581-20588 are mine, don't touch them ;) [23:27:55] he he [23:28:01] you may have them [23:28:22] I'll try and restrain myself [23:28:26] =) [23:28:49] he he [23:29:14] nimish_g: you need to get that irish whistle over to my house this weekend and rock out to "row row row your boat" [23:29:31] Roan can play piano with his computer keyboard over the internet [23:29:56] *RoanKattouw wonders how well that works on a laptop [23:30:37] I should really just come over for one of the all-staffs and jam with you guys again, that's a bit easier :P [23:31:22] yeah [23:33:39] Is there a date (or range) for the spring all-staff yet? [23:35:50] i heard it is around march(?) [23:36:20] fall all-staff date is still floating [23:37:47] OK WTF [23:38:01] How can it be that flying Bremen - AMS - SFO is cheaper than AMS - SFO direct? [23:38:29] that crap always confuses me [23:40:26] Holy shit Brussels is even cheaper [23:40:36] Via Amsterdam, of course ^^ [23:41:17] I'd *hope* amsterdam to brussels is cheaper than amsterdam to sfo [23:42:07] nimish_g: BRU - AMS - SFO is cheaper than AMS - SFO, even though the latter leg is the exact same plane [23:42:14] It's like 600 vs. 400 euros [23:43:04] aah, gotcha. yeah airlines are weird like that. [23:44:27] when I was originally flying to New Zealand, I found BNA-LGW-AKL was $1000 cheaper roundtrip than BNA-LAX-AKL, even though the first meant I had to needlessly cross the atlantic 4 times [23:46:47] BNA? [23:46:54] Nashville, TN [23:47:07] where I grew up [23:47:11] lol so you flew around the world the wrong way [23:48:13] I couldn't get a transit visa in time (wasn't a US citizen then) but it really bothered me that I had to pay extra to NOT do something so ridiculous [23:49:34] Yeah [23:49:49] btw, is there a 'usability-team' wiki group? I want to upload the special:clicktracking page to SVN so we can see it a little bit right now, but it's *definitely* not ready for general use yet [23:51:07] Just commit it [23:51:20] Nobody will have the CT extension installed anyway [23:51:44] And there's no such group, but you could limit stuff to sysops or something [23:51:55] Most of us are sysops on most prototypes, bug me if you're not [23:52:01] ok [23:54:43] Hey you know what's *really* awesome? Instead of flying people on AMS-BRU, there's this deal where you get a ticket for the high-speed train, which means I'd be able to book a plane ticket from AMS for like half the price and get a free AMS-BRU return ticket on top of it [23:59:59] nkomura1: Two questions: 1) when the date for the March all-staff settles down, can you let me know ASAP, say at least 2 months in advance, so I can book a super-cheap flight? 2) Am I allowed to invoice any review and fixes of Yaron's POM stuff?