[12:35:42] RoanKattouw .... localisations for Sinhalese are done at the moment ... so they will know that localisations are no longer the issue tomorrow if TWN updates today [12:36:06] OK nice [12:36:23] I'll update prototype (that's what they're testing on) when I see siebrand's commit [12:38:10] Roan, you do not run LU on the prototype ?? or do you mean to run it asap [12:38:23] I do run it, but we svn up there all the time anyway [16:53:24] I'm sooo ready to come back to the office... but I feel bad for my wife leaving her home with 2 kids :( [16:54:00] awwwww [16:54:06] and a dog ;) [16:54:12] gto the dog back from the shelter yet? [16:55:15] brion: Preliminary version of stuff that needs to be reviewed for our next deployment: http://wikitech.wikimedia.org/view/Babaco_deployment [16:55:54] eeeexcellent [16:56:46] yeah, we got him back [16:56:53] he's chillin on the couch next to mea [16:56:56] *me [16:57:45] TrevorParscal: When you have time in the next couple of days, there's something that needs CSS love @ https://bugzilla.wikimedia.org/show_bug.cgi?id=20844#c8 [16:58:28] okay! [17:47:29] *RoanKattouw stares [17:47:41] It seems we have the complete team in here for the first time since Wikimania [17:51:10] is everyone responsive? [17:55:00] Apparently not [17:55:07] Naoko is away at least [18:39:12] i'm here! [18:41:31] hey hey hey [18:43:14] it's good to be back [18:43:40] TrevorParscal: what is the current status of babaco? [18:44:38] we are doing some bug fixing on the dialogs and toc [18:44:46] but things are getting pretty stable [18:45:07] has the build on prototypes switched to WMF-deployment branch? [18:45:23] i'm hoping to do a top-down status check tomorow [18:46:01] I don't know how much brion has reviewed yet, but I am thinking very little [18:46:28] we only pointed him to http://wikitech.wikimedia.org/view/Babaco_deployment today [18:49:25] today and tomorrow are gonna be mega-review time :D [18:49:44] right on [18:51:49] nkomura: Nope, we're still running trunk [18:52:08] Mainly because there's a lot of stuff to be merged to wmf-deployment, but that won't happen until brion has reviewed it [18:52:26] k [18:53:07] sounds like reviews can be completed by end of tomorrow, but that does not give us much time to stress test the updated software on prorotypes [18:53:40] The difference between wmf-deployment and trunk would be minimal in terms of usability features [18:54:04] wmf-deployment and trunk would be equal in terms of the UsabilityInitiative extensions, and only differ slightly in terms of the Vector skin [18:54:19] RoanKattouw_away: do we have much to merge? If it's simpler to merge a couple updates into current wmf-deployment we can do that, otherwise I'll do a general review for full update tomorrow, then launch the babaco bits wednesday [18:54:49] We need a full update for extensions/UsabilityInitiative [18:55:15] Because 1) it's way simpler and 2) there are hardly any non-essential revs since the last code update [18:55:51] :D [18:57:12] RoanKattouw_away: even if the changes are minor, we should do a basic run of QA after the review and the merge is done [18:57:35] *TrevorParscal agrees [18:57:51] not that RoanKattouw_away does not [18:58:13] we introduced quite a few unexpected bugs in previous rounds [18:58:23] Yeah [18:58:39] I'll run the merge (which is sort of devilish) today and run it on prototype.wikimedia.org/d [18:59:10] whats the deal with people being suprised when wiked and wikiEditor don't play nice [18:59:12] thanks [18:59:16] they are taking over each other [18:59:21] *RoanKattouw_away goes back to movie [18:59:43] i don't expect they will ever work together perfectly [18:59:56] wikiEditor is'nt designed to [19:03:00] hi, RobH. r u there? [19:14:49] is there environment i can see watch/unwatch implementation? [19:15:20] adam_miller: you around? [19:15:30] we need to change the hover effect of the favorite star [19:15:38] TrevorParscal: yeah i am [19:15:42] we need to use a sprite with 4 images [19:16:07] i changed it yesterday based on what hannes sent me. you need it changed again? [19:16:31] fill/stroke: white/blue, white/yellow, blue/blue, blue/yellow [19:16:35] nkomura: Prototype [19:16:47] make the yellow stroke the hover effect [19:16:54] um [19:16:57] RoanKattouw_away: i don't see it there [19:16:57] hld [19:17:02] Hmm [19:17:18] it'd be better to stage it on sandbox for now [19:17:33] as we are going to the final round of testing on prototype once your merge is complete [19:17:35] yeah, let's not change prototype durring testing [19:17:45] nkomura: I do, you have to log in [19:17:53] k [19:17:53] i didn't see hannes's input on that [19:18:01] was I cc'd? [19:18:04] looking... [19:18:16] The watch icon is in trunk, that's why it's up on prototype [19:18:29] Getting it ready in time shouldn't be hard, right? [19:18:36] last mail on the subject I got from him was on the 21st [19:19:16] RoanKattouw: nimish and I were talking about doing a testing branch to avoid this issue in the future [19:19:21] Right [19:19:50] just to be clear - we do not want to deploy acai enhancements such as (watch/unwatch and new color) on Wednesday yet [19:20:04] we should treat acai enhancements as a separate release [19:20:09] TrevorParscal, are all of those in trunk right now? [19:20:16] Yes, they're all in trunk [19:20:27] so we would have head (latest latest), testing branch (latest when recent testing round started + bugs we mean to fix for the testers), and deployment (brion looked at it, it's good) [19:20:28] Not deploying those is easy, I'll just remove the babacofix on all of thtem [19:21:09] also, the color changes - i need to get involved there still [19:21:38] i don't think much progress is made on the color front yet [19:22:00] let's discuss tomorrow to synch up when u are back in the office tomorrow [19:22:15] OK I'm gonna start my merge black magic now, I'll try to get prototype.wikimedia.org/deployment in the state wmf-deployment would be in on Wednesday [19:22:16] I havn't checked myself about the contrasts being fixed, but we need to see some renders of the colors in use, because that blue being used for watch/unwatch star - well... it doesn't seem any better than the current palete - possibly worse [19:22:19] hannes provided the revised color scheme which needs to be prototyped [19:22:35] yes [19:22:47] the contrast has been fixed and reproposed by hannes [19:23:01] I'm just filling adam_miller in- because i think he started using it for the watch/unwatch stuff [19:23:15] and to be safe, we are better off using the existing pallete until the new one is finalized [19:23:32] cause at least it will be deployable in the case that the new one changes even more [19:24:59] even hannes doesn't like the colors anymore after making them accessible (as per his email) [19:25:12] TrevorPrascal: you were not cc'd on hannes emails to me. I can fwd them if you'd like [19:26:49] i need to be kept in that loop [19:27:23] really, it's quite standard practice to just comunicate over usabilityteam@wikimedia.org (a list with all interested parties) [19:27:56] open communication (keeping anyone interested in the loop) helps us reduce staff meetings and confusion :) [19:28:04] ok i'll try and stick to that in the future [19:28:13] right on! :) [19:28:17] still figuring all of this out [19:28:21] good work though on this [19:28:36] adam_miller: did you create the star from scratch? [19:29:53] we may want to use this sans the shadow -> http://commons.wikimedia.org/wiki/File:Emblem-star.svg [19:30:20] and we need to ensure that the rendering is very sharp at that small size - the bottom points are a bit blurry on the current one [19:32:22] and we usually use PNG images instead of GIF images (unless they are animations) - they compress better and use an open format [19:32:43] for instance -> http://warp.povusers.org/grrr/PNGvsGIF/ [19:36:29] the LZW pattent is technically expired, but - out of principal, PNG is more "free culture" :) [19:37:23] how do you save them out? I use Save For Web from photoshop and GIF seems to produce the lowest file size [19:37:40] um, use PNG-8 [19:37:42] also, Hannes created the star graphics [19:38:05] adam_miller: I will provide you with a graphic in a min [19:40:36] TrevorParscal, adam_miller, RoanKattouw_away, brion-lunch: I just had a talk with Naoko and Parul on a proposal for branches, sort of what me and Trevor were talking about the other week [19:41:07] The idea is that we have a seperate "usability" branch of the code that will be deployed in Sandbox [19:41:09] status? [19:41:43] this branch will be for staging/prototyping/playing around with ideas, etc [19:43:08] the 'stable' code that we're sure will be a part of our releases will be in trunk, and then we can just commit to deployment in case of major bugfixes (and be sure to put those changes in trunk and usability) [19:47:11] nimish_g: Sounds like a good idea, but I'd personally like to hold off on introducing that till after deployment [19:47:22] i agree [19:47:52] usability branch will include babaco and acai enhancements, which will confuse the deployment status [19:55:18] RoanKattouw_away: when the prototype is switched to the candidate build for wednesday, please let me know [19:55:31] i will signal calcey to start pounding on the release [19:56:03] OK [19:58:33] wrt watch/unwatch i do not see full sub-menu in drop-down for admin [19:58:38] is it a known issue? [19:59:19] TrevorParscal or RoanKattouw_away, can either of you make me and admin on our prototype(s) so i can see it in full admin effect? [20:05:40] probably [20:05:41] :) [20:06:49] you have it on http://prototype.wikimedia.org/en.wikipedia.org [20:08:40] cool, thanks. [20:09:04] also RoanKattouw_away, just looking at your email about ellipsis and they are both at the end on prototype and sandbox [20:09:07] at least for me. [20:09:38] and you may or may not already know, but i am getting some drastic misjumps when i use the NTOC (on my mac, using firefox) [20:10:09] Yes, known issue, no fix, it's devilish [20:11:21] really? [20:21:23] parutron: Yeah I decided to just go with it after good reception [20:21:28] (the ellipsis) [20:21:52] oh cool. [20:22:04] well add me to the good reception! [20:23:20] parutron: Lemme +sysop you [20:24:13] parutron: What's your username? [20:24:19] Parul Vora [20:24:42] Hm you're a sysop on en prototype [20:25:17] Any other wikis you want +sysop on? [21:34:18] RoanKattouw_away / TrevorParscal -- does udpating $wgOptInPrefs affect folks who have already opted into beta or just new opters-in? [21:35:25] it only affects new people [21:35:46] which means we may want to do another rev on the optin stuff [21:36:09] that detects if you are one of the people who have opted in to part but not all [21:36:17] okee [21:36:20] I will talk to nimish and roan about this [21:36:26] we will come up with a plan [21:36:33] we're talking about maybe consolidating the experimental prefs into one tab on special:preferences [21:36:52] that's a great idea [21:36:55] which should make it a bit easier for people to progressively try the new bits being added in where we don't want to slap them on all beta users immediately [21:37:10] but for now, it just changes which prefs are being turned on and off when opting in and out [21:37:15] yes [21:39:10] excellent :D [21:40:43] brion, RoanKattouw: 1) I'm not sure Naoko even /wants/ that stuff in optinprefs and 2) why not do an UPDATE to move those people over? [21:41:09] And yes, putting them in their own prefs tab is a good idea, Naoko suggested that before [21:46:11] brion, is bsd licensed stuff in our code ok? [21:48:51] gpl-compat bsd yes :) [21:48:58] if it has the advertising clause i'm less certain [21:49:21] RoanKattouw: yeah we were talking about that just now :) we probably want to do more stuff progressively, in which case making it easy to find is good [21:49:36] Aye [21:49:39] I'll get cracking on that [21:49:52] also quick note on the usability test recruiting - http://www.maxmind.com/app/geolitecity <- we should be able to plug this in to limit the notice to local area [21:50:00] Right now I'm almost done running the merge, after which the merged code will be live at http://prototype.wikimedia.org/deployment [21:50:16] Ah yes [21:50:17] geoip ext being worked on for fundraising stuff, check w/ tomasz [21:51:39] \o/ [21:57:18] OK merge complete [22:01:48] Attention all: deployment candidate is now live at http://prototype.wikimedia.org/deployment and ready to be tested [22:15:42] woot [22:18:45] RoanKattouw, how do I limit a page to only be viewed by admins? apparently $wgSpecialPageGroups['ClickTracking'] = 'admin'; doesn't work [22:19:08] Nope [22:19:17] You have to 1) specify a right in the SpecialPage constructor [22:19:27] Like parent::__construct( 'ClickTracking', 'clicktrack' ); [22:19:38] Then assign the clicktrack right to sysop by default;: [22:19:47] $wgGroupPermissions['sysop']['clicktrack'] = true; [22:20:20] $wgSpecialPageGroups controls the grouping of special pages in Special:SpecialPages [22:20:45] ah ok [22:26:21] ok [22:26:30] I just refactored the watch/unwatch icon stuff [22:26:37] a few important changes [22:27:10] 1. it's now off by default, and can be turned on using the $wgVectorUseIconWatch global var... [22:27:14] similar to the way we do $wgVectorUseSimpleSearch [22:27:28] Aah nice [22:27:59] 2. it now uses some custom icons I made, and they are setup in a sprite - people, please look carefully at this before making modifications cause sprites although very awesome for performance can be tricky things [22:28:39] 3. it uses CSS for hovering effects - this is important because we don't want to required JS just to do something simple like hover [22:29:00] so - yeah, update and peek [22:30:24] Which is the hover effect? The gold border? [22:31:48] yes [22:31:57] brion: the clicktracking in trunk is set by default to be off now, special:clicktracking is set just for admins (while I'm adding functionality to it) [22:32:13] k [22:32:51] RoanKattouw: should I leave updating things on the prototype server to you? or shall I do it now? [22:33:10] I'll do it real quick [22:33:15] cool [22:34:22] I also had an idea for a performance improvement of the autoEllipse thing [22:34:33] OK shoot [22:34:38] not sure if it will actually improve performance in all cases, but in most cases I think it will [22:34:39] ok [22:34:43] (updated; looks broken though) [22:34:52] what's broken? [22:35:04] OH wait [22:35:06] Needed to purge cache [22:35:14] working for me [22:35:15] :) [22:35:26] You changed .css files without incrementing $wgStyleVersion [22:35:32] darn me! [22:35:49] ok - so the performance thing [22:36:03] Yeah [22:36:28] so right now we test if "longstring" fits, then if no, we test if "longstrin", then "longsti", etc [22:36:57] It looks like you got the watch and unwatch icons the wrong way around [22:37:04] I'm getting a full icon for an unwatched page [22:37:10] in cases where we are really close to fitting, we still end up with allot of extra tests because we first add "..." [22:38:06] RoanKattouw: ha - i might have it backwards [22:38:31] so anyways it's actualy testing "longstring", "longstrin...", "longstri..." [22:38:31] When you fix this, please also increment $wgStyleVersion :) [22:39:29] my point is more, we do test if it fits, if not, does half the length fit, if so then 3/4s the length, and so on [22:39:59] we can in most cases do a fraction of the tests [22:40:03] did that make sense? [22:40:27] Yeah binary search for the right length [22:40:41] That's O(log n) in the length of the word [22:43:31] yeas [22:43:34] binary search [22:43:40] that's what I meant [22:43:41] :) [22:44:11] nimish_g: Ok remind me which name extensions I need to poke on the tracking? [22:44:34] UsabilityInitative/UserDailyContribs for the general records and UsabilityInitative/ClickTracking for the new stuff we'll set up later right? [22:44:41] yes [22:45:13] ok looks like we didn't get UserDailyContribs set up yet :( [22:45:16] so lemme check status on that [22:45:54] *RoanKattouw haunts TrevorParscal 's nightmares with $wgStyleVersion [22:46:02] hah [22:46:03] ha ha [22:46:05] dang it! [22:46:08] i got distracte [22:46:11] *distracted [22:46:31] where is that at? [22:46:44] DefaultSettings.php [22:47:10] doing it now [22:49:59] *TrevorParscal apologizes again about not updating that when he should [22:50:16] No worries, I do that all the time [22:50:37] But the fact that you didn't know where $wgStyleVersion was worries me :) [22:53:11] Updated prototypes, looks OK now [22:57:14] cool [23:07:21] bah [23:07:25] jsmin not in macports? [23:09:23] you can compile your own with 1 line of bash [23:09:56] yeah it just means i have to track it down and do so [23:10:12] wget http://www.crockford.com/javascript/jsmin.c [23:10:15] gcc -ofjsmin jsmin.c [23:10:39] yep [23:10:42] already done :) [23:11:34] sudo mv jsmin /usr/local/bin/jsmin [23:13:18] TrevorParscal: quick q while i've got fixOperaBrokenness on my screen [23:13:43] is doing that textarea check worth the trouble or can you just consistently replace things from \r\n to \n? [23:13:52] or... od you have to convert things *to* \r\n o_O [23:13:53] bleh [23:18:30] hmm [23:18:34] wait [23:18:41] so - what's the brokeness look like? [23:21:07] No idea. :) Just noticed that code looks funky to me :D [23:21:30] wikitext being the code? [23:22:44] no, the function fixOperaBrokenness [23:22:47] dunno what file it's in [23:22:53] pay it no mind [23:23:11] oh [23:23:23] i think Roan wrote that [23:24:17] scappin' w/ update to current UsabilityInitiative [23:24:23] sweetness [23:24:59] did you see the new watch/unwatch icon thing? http://prototype.wikimedia.org/en.wikipedia.org/Main_Page [23:26:19] very nice :D [23:26:29] OH MY GOD I LOVE THE SPINNY STAR [23:27:36] :) [23:27:47] thank you laidies and gentlemen [23:27:50] :) [23:28:13] ok i'm gonna have to start stealing that idea :D [23:28:33] I've pattented it! [23:28:41] hehe [23:28:57] I may slow the animation down a tad [23:29:10] but i think it's pretty close [23:34:11] it's awesome is what it is :D [23:36:26] thanks - by the way, I'm sad to see you are leaving but very excited for you - I'm sure you will be doing exciting new things there [23:36:43] I hope you will be able to unleash years of repressed creative programming on them [23:37:54] :) [23:38:56] rom within function "UserDailyContribsHooks::storeNewContrib". Database returned error "1064: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ON DUPLICATE KEY UPDATE contribs=contribs+1' at line 1 (10.0.6.21)". [23:38:58] oh piffle [23:39:16] ha! added in 4.1 :) [23:39:37] nimish_g: ok here's what i recommend [23:39:56] issue the UPDATE first, then check the number of rows modified [23:40:00] if it's 0, then do an insert [23:40:07] should work well enough [23:40:10] ok [23:40:34] *brion stabs mysql in its warm, code-y underbelly with his staff of upgrade justice [23:41:03] what mysql are we using currently? [23:41:13] *TrevorParscal films the epic event and uploads it to youtube [23:41:20] | 4.0.40-wikimedia-log | [23:50:13] cyall in the office tomorow morning