[20:51:33] adam_miller: i'm trying cascading tabs on german prototype [20:51:39] works great [20:51:44] which sandbox are you using? [20:51:55] http://prototype.wikimedia.org/de.wikipedia.org/Wikipedia:Hauptseite# [20:52:03] we are staging it for QA [20:55:17] eeeww, the dividing lines are way too large on there. i'll try to get that fixed [20:56:52] adam_miller: What's up with the fact that when you shrink the window, it only collapses the tab when Read hits Discussion, but when you grow the window, you gotta grow it way farther before it uncollapses [20:57:14] because it needs enough room to put it back up there [20:57:49] oh, also it's using delayed bind, so it wont collapse instantly [20:57:52] RoanKattouw: does Trevor exist right now? [20:58:20] werdna: I'm pretty sure he exists [20:58:26] He's talking [20:58:43] Or do you mean the name or what? [20:58:47] need to bug him somewhere :) [20:58:55] his autogrowy thing isn't working that well [21:00:10] You're just not loading it I think [21:01:33] Oh wait you're loading it, but in the wrong order [21:01:47] You're loading jquery.autogrow.js /before/ js2.combined.js, which contains jQuery [21:04:59] ... or maybe you're not. Wait [21:05:16] Trevor did it all, so blame him :D [21:05:19] it seems to work sometimes [21:05:28] but it just works poorly [21:07:35] werdna: You copied Trevor's code without thinking about it much, he says :) [21:07:44] What's happening is that LQT and UI both load jQuery [21:07:49] RoanKattouw: so the inconsistency with the collapse of the tabs is a bug with the way i'm applying my buffer space. I watched it closer and spotted it, and am fixing it now. [21:07:52] And UI's instance overwrites LQT's, including plugins [21:07:58] adam_miller: OK awesome [21:08:46] werdna: So tomorrow at the tech meeting we're gonna talk about centralizing this stuff [21:09:08] RoanKattouw: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/57686 [21:09:14] Trevor copied his own damn code :p [21:09:47] werdna: That revision is not relevant, the problem existed before then [21:09:56] I'm talking about js2.combined.js [21:10:12] what problem? [21:10:33] The problem that any plugins added by LQT will be killed by UI, or vice versa, depending on their order in LocalSettings [21:10:42] I was talking about autogrow being unreliable and throwing errors. [21:10:54] That problem existed before r57686 but wasn't apparent because LQT didn't add any plugins yet [21:10:57] UI? [21:11:00] UsabilityInitiative [21:11:01] What's UI? [21:11:07] you mean the jQuery UI plugin? [21:11:11] No [21:11:16] I mean the UsabilityInitiative extension [21:11:51] Both LQT and Usability define jQuery instances, and one of them ends up killing the other's plugins [21:11:55] where's jQuery being added by the UsabilityInitiative extension? In the enhanced toolbar? [21:12:20] Yes, and EditWarning, and CollapsibleTabs these days [21:12:24] The latter means all page views [21:12:46] So with CT [21:12:55] (and SimpleSearch) we'll have jQuery on every page [21:13:18] So I think we might as well just put jQuery in core; but we'll be discussing that tomorrow [21:13:20] I see. Well, what am I supposed to do to fix it? [21:13:33] if ( ! jQuery ) { ... } [21:13:34] Wait till tomorrow :) [21:13:42] No, because you're loading before we are [21:14:39] I'm sorry I complained about this to you now I realize it's not really your fault [21:14:49] not so much complained to and confused [21:14:53] s/and/as/ [21:15:53] Yeah sorry dude [21:16:34] :D [21:16:36] it's fine [21:16:55] hmm, if i'd have known the first day was mostly ops anyway maybe I could have made it [21:16:58] oh well [21:17:42] The upside is we haven't completely lost our cross-timezone coverage [21:21:26] heh\\\ [21:34:36] adam_miller: Do you have code comment notification e-mails configured? [21:34:51] i do, i've been getting all of your comments in my inbox [21:35:04] Oh OK [21:35:07] Just wondering, no pressure [21:42:19] Ah so the -4 was actually not necessary? [21:42:55] no, i'm not sure why i had it in there initially. It was a buffer, but i took it out and it seemed to still collapse where I wanted it to [22:12:00] nimish_g: RoanKattouw TrevorParscal: http://www.mediawiki.org/wiki/Code_review_process_notes