[00:14:38] TrevorParscal - Roan thought that using SimpleXML might be a bad idea, because it's not a standard part of PHP. [00:14:52] For parsing the XML template definition, that is. [00:15:09] There's lots of XML parsers for PHP [00:15:11] I have no idea how widespread that library is, although it appears to be common... [00:15:14] Right. [00:15:14] use whichever makes the most sense [00:15:27] in my experience, SimpleXML is very widely distributed [00:15:28] Well, SimpleXML is quite easy to use. [00:15:43] Okay. Do you know why Special:Import doesn't use it? [00:16:25] but you need to talk to both our ops people to see if it's part of our distribution, and also get a feel for how common it is for 3rd party users to have support on shared hosting solutions (which i think is very widespread) [00:16:44] I don't know, I didn't write Special:Import, but SimpleXML may not have been common when that was written [00:17:29] Yeah, I figured it was something like that. [00:17:40] Who should I talk to? [00:17:57] I mean, the Wikimedia ops people. [00:20:15] Would Rob Halsell be a good person? [00:33:46] Tomasz might know [00:33:56] Rob is great for that sort of thing - Mark even better I think [00:34:04] Tim would definately know [00:34:07] Brion would know [00:34:20] Basically anyone not on our team [00:46:01] Got it. [01:01:05] simplexml wouldn't deal well with multiple gigabytes of streamed xml [01:01:13] on account of it works with a single document in memory [01:01:23] it's also new in php 5, so didn't exist when we originally wrote the xml import/export [01:02:46] but php 5 is now a mediawiki requirement afaik, and the usage of SimpleXML in the template info case would be well within it's capabilities... So I'm thinking that's a safe bet... [01:04:07] ok [01:04:09] heading home [01:04:10] cyall! [14:25:28] what apppppp [14:25:30] airport in da house [16:17:54] roan are you there? [16:18:00] Yeah [16:18:05] hey cool. hi [16:18:22] i am wondering how headings are beeing used [16:18:38] i cant find any sub sub sub headings [16:18:48] are there any particular usecases? [16:19:08] I am talking about level4 and 5 [16:19:24] They're used in some articles, yes [16:19:41] Can't think of any examples, but they can be and are used [16:20:50] even realy huge articles like "history of the world" does not make use of level4 and 5 headins [16:21:20] anyway.. but there are no special usecases for level4 and 5 headings? [16:21:29] like in boxes or anything like that? [16:26:19] No, not really [16:27:29] ok..so it looks like these small headings are basically not used [16:27:30] thx [18:28:06] RoanKattouw_away: you really away? [19:04:37] TrevorParscal: Back now [19:04:51] When you asked me, Firefox was hanging and not even logging :( [19:06:02] :) [19:08:40] As you may have noticed I did the branching thing you e-mailed about [19:09:36] Normally I would've waited until I talked to you, but I was bored :) [19:15:21] TrevorParscal: I see you changed the color of the tabs back; don't you think it looks ugly and disconnected to have a white active tab attached to a grey box? [19:15:55] well, I have some ideas for that [19:16:31] but the most pressing thing is actually that we need to have a totally custom control there instread of jquery-ui - something I expected to be the case early on and now I'm very convinced of it [19:16:47] I'm working on a wireframe of how it will all go together [19:17:31] but essentially the preview/edit tabs will not be the only thing just above the toolbar [19:18:08] and the styling of the tabs will be changing even more, and jquery-ui is not flexible enough for us in this case [19:19:22] Hacking up custom tab-like things shouldn't be too hard [19:19:50] The hardest part from my point of view is making them look like tabs, but that's your area :) [19:26:21] TrevorParscal: In engine.js: a comment indented with 28 tabs? Really? [19:27:30] TrevorParscal: Did you write engine.js? It doesn't look like you [19:28:14] no [19:28:20] it came from codepress [19:28:36] and nimish took a first pass at merging the 3 enginges together into one [19:28:46] and we will be pulling things out of there as we need them - if we need them [19:28:49] it's scrap [19:29:36] yeah, for the record I most definitely did *not* write that code either =) it was just a first-pass attempt at merging their engine files [19:31:46] Would it hinder you if I went ahead and fixed up the indentation style of that file? [19:32:12] Basically make it look like a sane person wrote it [19:34:37] (only if you're not working on it right now, of course [19:42:58] don't bother though [19:43:25] I mean [19:43:31] only if it's really easy [19:43:46] like, clicking source -> format in eclipse or something [19:44:21] cause that code has to be changed allot to be useful anyways [19:44:26] and will be used in isolated bits [19:46:04] HEh [19:46:09] I'm done already [19:46:13] :) [19:46:17] right on [19:46:18] I replaced all tabs by two tabs, all instances of four spaces by a tab [19:46:27] Then went through and adjusted where necessary [19:46:32] Also broke stuff like [19:46:35] if ( foo [19:46:38] || bar ) { [19:46:41] Like [19:46:43] if ( foo || [19:46:45] bar ) { [19:47:07] The latter makes more sense as you're reading the code, makes it more clear that the first line isn't finished yet [19:47:47] right on [19:47:52] Committed now [19:52:53] TrevorParscal, nimish_g: Do you feel the need to discuss branching still? [19:53:04] (Or is the need for lunch more urgent? :) ) [19:53:10] i was hoping you could do the branching for us [19:53:17] I already did something [19:53:19] lunch is coming in a few minutes [19:53:22] ? [19:53:33] RoanKattouw, do you not see a need for branching? [19:53:42] Basically what I did is I created /branches/usability/acaifix and babacofix [19:53:45] Yes, I do [19:54:21] The acaifix branch contains the same code that runs on prototype/deployment: a copy the wmf-deployment version with the acaifix revs merged in [19:54:35] The babacofix branch contains the state of trunk just before I committed side-by-side preview [19:57:49] cool [19:58:06] Hi. [19:58:08] and head will be the late babaco stuff, and upon that release we can branch that too, and head will be citron, etc.. [19:58:10] yes> [19:58:11] ? [19:58:20] Yes [19:58:45] Basically whenever we feel we've got most of the features for a release and wanna make significant changes for the next one, we branch [19:59:15] TrevorParscal, RoanKattouw: I need to set up a couple prototypes tonight. I shredded the file on my system that had the mysql root password in it. Can one of you sent it to me again? [19:59:54] Ryan_Lane: Sent it in a private message [19:59:55] awesome. thanks [20:13:55] test [20:14:02] thats fun [20:14:15] hannes is awesome [20:14:23] it's like a ghetto google wave! [20:14:27] i don't even need to hit enter [20:14:34] oh wait, everyone else can see this too [20:16:18] *RoanKattouw is compiling Xen on his Ubuntu box [20:57:06] trevor are you there? [20:57:16] yes [20:57:19] what's up? [20:57:33] we are up to finish the toolbar icon how to page [20:57:57] I just wanted to check with youi that the icons are good for implementing [20:58:05] link plz [20:58:23] I will send you a mail with an icon as a example [20:58:28] k [20:59:05] done [20:59:35] do you need a file that is 20px*20px? [20:59:52] or can it be any size until it s not bigger than 20px? [21:00:18] 22px by 22px is the icon file size [21:00:25] 1px of border around the icon should be blank [21:01:20] so we got 14px height of the icons.. that will give you 16px height [21:02:12] or shall we do a 20px*20px icon (so the 14px high icon would have more blank space around it) [21:02:29] or 22px*22px [21:04:56] sorry, I'm sort of confused as to what you are asking me [21:05:17] what filesize do you want? [21:05:36] the icon itself is not more than 14px*14px [21:05:44] we can add any blank space if you like [21:09:34] ok anyway.. I ll wrapp my question up and send you a mail [21:12:51] k [22:09:09] RoanKattouw: would now be a good time to start moving things around in head? [22:09:20] what code is being worked on right now? [22:24:54] TrevorParscal: By all means go apeshit [22:25:05] I'm not currently working on anything, I'm watching a movie :) [22:26:03] Ooh, shiny wireframes [22:26:11] Oh an edit summary dialog! Awesome! [22:26:21] WARNING: CODE IS MOVING AT HIGH VELOCITY [22:26:24] yeah, so we can get rid of all that nonsense at the bottom [22:26:35] HARD HATS REQUIRED - YOU ARE NOW ENTERING THE REFACTOR ZONE [22:26:43] it's all the same verbage just presented prettier =) [22:26:51] TrevorParscal, nimish_g: If you're not working on it already, I'd love to make those wireframes happen tomorrow [22:28:26] *RoanKattouw goes back to movie, feel free to continue talking to me [22:28:48] ok [22:28:52] sounds great [22:29:00] *TrevorParscal goes back to refactoring code [22:29:14] hey TrevorParscal [22:29:21] TrevorParscal: what are you refactoring? [22:31:37] UsabilityInitiative stuff