[17:18:14] <TrevorParscal>	RoanKattouw_away: you around?
[17:36:04] <RoanKattouw_away>	Leaving in 5 mins
[17:36:14] <RoanKattouw_away>	Were you asking for the JSON thing or something else?
[17:37:31] <RoanKattouw_away>	TrevorParscal: I didn't do anything about implementing those wireframed designs just yet because it seems like they're far from final
[17:37:53] <TrevorParscal>	yeah - no worries
[17:37:57] <TrevorParscal>	I was just poking
[17:38:03] <TrevorParscal>	wha'ts your availability today?
[17:38:29] <RoanKattouw_away>	Afternoon only
[17:38:40] <RoanKattouw_away>	I gotta run in a few minutes, I'll be back after lunch
[17:39:55] *RoanKattouw_away 	runs
[20:41:14] <TrevorParscal>	RoanKattouw: how's it going?
[20:47:40] <RoanKattouw>	Hey man
[20:47:53] <RoanKattouw>	Little tired, intense badminton practice :) good otherwise
[21:05:37] <RoanKattouw>	TrevorParscal: I see you've been active today :)
[21:06:24] <TrevorParscal>	yes
[21:16:34] <TrevorParscal>	damn PHP and it's broken static member inheritance model!
[21:18:41] *TrevorParscal 	needs late static binding
[21:23:04] <RoanKattouw>	Aaron committed something using LSB today
[21:23:11] <TrevorParscal>	LSB?
[21:23:12] <TrevorParscal>	oh
[21:23:16] <TrevorParscal>	yeah?
[21:23:17] <RoanKattouw>	I kindly pointed out that that ain't gonna fly
[21:23:19] <TrevorParscal>	and it broke
[21:23:20] <TrevorParscal>	:)
[21:23:27] <TrevorParscal>	we need PHP 5.3 already
[21:23:33] <RoanKattouw>	Well not really, but he mentioned LSB in the commit summary, which alarmed me
[21:24:03] <TrevorParscal>	was he doing an LSB hack?
[21:24:07] <TrevorParscal>	there are some strange work-arounds
[21:26:32] <RoanKattouw>	No
[21:26:53] <RoanKattouw>	He was making it so that Article::newFromId() instantiates a subclass of Article where approriate
[21:27:05] <RoanKattouw>	Using new static( $title); instead of new Article( $title );
[21:31:39] <TrevorParscal>	interesting
[21:57:50] <TrevorParscal>	RoanKattouw: ok, the unified loaders are done at this point
[21:58:00] <RoanKattouw>	Yeah I saw the commits
[21:58:07] <RoanKattouw>	I haven't even started reviewing them yet
[21:58:52] <TrevorParscal>	So I want to delete the old stuff at some point
[21:59:00] <TrevorParscal>	especially to prevent people form working on the old versions
[21:59:13] <TrevorParscal>	cause now there's 2 incompatible copies of most things
[21:59:57] <RoanKattouw>	Hm
[22:00:12] <RoanKattouw>	I haven't looked at the code yet, but that makes sense
[22:00:14] <TrevorParscal>	CollapsibleTabs, EditToolbar, EditWarning, NavigableTOC, SideBySidePreview and SimpleSearch can all get removed
[22:00:22] <RoanKattouw>	Provided everything's been ported and verified working
[22:00:39] <TrevorParscal>	I didn't want to jump the gun on that, but I've ported everything now, and tested things as working
[22:01:03] <TrevorParscal>	but yeah, I would like you to svn up, and test for youself as well
[22:01:29] <RoanKattouw>	Tonight I'm just gonna review it, not run it
[22:01:42] <TrevorParscal>	require_once( "$IP/extensions/UsabilityInitiative/WikiEditor/WikiEditor.php" );
[22:01:42] <TrevorParscal>	require_once( "$IP/extensions/UsabilityInitiative/Vector/Vector.php" );
[22:01:46] <RoanKattouw>	Oh and take a shower first, it should be available now
[22:01:49] <TrevorParscal>	that's the only thing needed to get it running
[22:05:38] <RoanKattouw>	OK I'm gonna go now, I'll be back in like 30 mins to review those changes
[22:06:38] <TrevorParscal>	sent email about moves
[22:43:08] <parutron_>	http://www.josefrichter.com/helvetimail/
[22:43:26] <parutron_>	http://www.josefrichter.com/helvetwitter/
[22:43:42] <parutron_>	http://www.iamadtaylor.com/helvetical/
[22:50:04] <TrevorParscal>	:)
[22:50:09] <TrevorParscal>	you reviewing now?
[22:50:36] <RoanKattouw>	Not yet
[22:50:43] <RoanKattouw>	I'm updating some special pages on frwikisource first
[22:50:49] <TrevorParscal>	right on
[22:50:55] <RoanKattouw>	Rob's too busy so I'm doing a few site requests on the side here and there :P
[22:51:03] <TrevorParscal>	i'm anxious to get rid of the old stuff :)
[22:51:10] <RoanKattouw>	heh
[22:51:15] <TrevorParscal>	we do have it in a branch...
[22:51:18] <RoanKattouw>	That too
[22:51:32] <RoanKattouw>	And if it breaks, we can just revert the rev that removes them
[22:51:52] <RoanKattouw>	Go ahead and kill them, I'll revive them if I think it's necessary
[22:51:56] <TrevorParscal>	k
[22:53:34] <TrevorParscal>	done
[22:57:28] <RoanKattouw>	About your e-mail: SVN won't let you make changes to ghost folders
[22:57:48] <TrevorParscal>	i sent that before the deletion
[22:57:51] <RoanKattouw>	It'll tell you that "Commit failed: EditToolbar is out of date", after which you have to svn up
[22:57:52] <RoanKattouw>	Ah
[22:59:31] <RoanKattouw>	TrevorParscal: Do you know about the existence of "svn copy" and how it preserves history?
[23:00:10] <TrevorParscal>	hmmm
[23:00:15] <TrevorParscal>	yeah, I should have used that
[23:00:16] <TrevorParscal>	:(
[23:00:48] <RoanKattouw>	It's not too late; you don't seem to have changed anything in EW, SS and CollTabs at least
[23:00:57] <TrevorParscal>	yeah
[23:01:11] <TrevorParscal>	well, I did make some changes actually
[23:01:15] <TrevorParscal>	message names and stuff
[23:01:22] <RoanKattouw>	Hm
[23:01:39] <RoanKattouw>	But in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58571 you just copied stuff?
[23:01:48] <RoanKattouw>	If you'd used svn copy, the diff would tell me that
[23:01:52] <RoanKattouw>	:)
[23:02:22] <RoanKattouw>	+				// These are probably only for testing purposes?
[23:02:23] <RoanKattouw>	+  				'wgNavigableTOCCollapseEnable' => $wgNavigableTOCCollapseEnable,
[23:02:25] <RoanKattouw>	+				'wgNavigableTOCResizable' => $wgNavigableTOCResizable
[23:02:38] <RoanKattouw>	No, they're actually being used to decide to run or not run certain blocks of code
[23:03:40] <RoanKattouw>	+				$enable['global'] || (
[23:03:42] <RoanKattouw>	+					$enable['user']
[23:03:44] <RoanKattouw>	+					&& isset( self::$modules[$module]['preferences']['enable'] )
[23:03:45] <RoanKattouw>	+					&& $wgUser->getOption( self::$modules[$module]['preferences']['enable']['key'] )
[23:04:17] <RoanKattouw>	When breaking conditionals, please but && and || at the end of the first line instead of at the beginning of the second; the latter makes for less confusing reading IMO, and I think the MW coding style guide may even mention this
[23:04:19] *RoanKattouw 	looks it up
[23:04:32] <TrevorParscal>	no worries
[23:04:40] <TrevorParscal>	funny - i usually do as you are saying
[23:04:47] <TrevorParscal>	not sure why I did otherwise
[23:04:55] <TrevorParscal>	I was blazing through the code pretty fast
[23:06:31] <RoanKattouw>	You know I've never used it but it's supposed to be pretty awesome: http://svn.wikimedia.org/svnroot/mediawiki/trunk/tools/code-utils/stylize.php
[23:06:47] <RoanKattouw>	A command line script that stylizes your PHP files for you
[23:06:51] <RoanKattouw>	Sadly there's no JS equivalent
[23:08:08] <RoanKattouw>	+				$modulePreferences .= "'" . Xml::escapeJsString( $key ) . "':'" . Xml::escapeJsString( $key ) . "'";
[23:08:22] <RoanKattouw>	Use FormatJson::something() ? Or did you already change that?
[23:11:32] <RoanKattouw>	TrevorParscal: You know, I think I could diff all these files against their 'old' versions, then use svn copy and patch to "fix" the history
[23:12:28] <TrevorParscal>	dude
[23:12:40] <TrevorParscal>	if you can do that, you will be the ninja of ninjas
[23:13:06] <RoanKattouw>	I've had worse struggles with SVN
[23:13:14] <TrevorParscal>	the kind of guy that people remember long after they've left and say "man, what just h
[23:13:17] <RoanKattouw>	Well maybe I haven't, but what the heck
[23:13:19] <TrevorParscal>	happend"
[23:13:24] <TrevorParscal>	ha ha
[23:13:37] <TrevorParscal>	RoanKattouw cleans up after TrevorParscal
[23:14:00] <RoanKattouw>	And after Yaron too, these days :)
[23:14:21] <RoanKattouw>	-  				'wgNavigableTOCCollapseEnable' => $wgNavigableTOCCollapseEnable,
[23:14:22] <RoanKattouw>	-				'wgNavigableTOCResizable' => $wgNavigableTOCResizable
[23:14:24] <RoanKattouw>	+  				'wgNavigableTOCCollapseEnable',
[23:14:26] <RoanKattouw>	+				'wgNavigableTOCResizable'
[23:14:29] <RoanKattouw>	I hope that's a multifunctional format?
[23:14:43] <TrevorParscal>	multifunctional?
[23:14:45] <RoanKattouw>	Like 'wgFooBar' works, but 'blah' => $wgFooBar ? 'foo' : 'bar' does too?
[23:15:14] <TrevorParscal>	well, it's a static definition
[23:15:32] <RoanKattouw>	Oh
[23:15:43] <TrevorParscal>	I'm open to suggestions on all this stuff
[23:15:49] <RoanKattouw>	+						global $$variable;
[23:15:52] <RoanKattouw>	+						$variables[$variable] = $$variable;
[23:15:54] <RoanKattouw>	Holy crap, that works? :P
[23:16:10] <RoanKattouw>	I knew $$variable worked, but I didn't know you could global that too
[23:16:23] <TrevorParscal>	I mean, in nearly all ways this is nice and clean, but there are some sitations where I'm supporting the old way of doing things just to avoid making even wider spread code changes
[23:16:28] <TrevorParscal>	ha ha
[23:16:29] <TrevorParscal>	yeah
[23:16:29] <RoanKattouw>	I would've probably just used $GLOBALS[$variable], but let's keep this, it's a piece of art :)
[23:16:33] <TrevorParscal>	crazy huh
[23:16:43] <TrevorParscal>	ew - globals array :)
[23:17:44] <RoanKattouw>	+		$wgOut->addScript(
[23:17:45] <RoanKattouw>	 			Xml::tags(
[23:17:47] <RoanKattouw>	 				'script',
[23:17:49] <RoanKattouw>	 				array( 'type' => $wgJsMimeType ),
[23:17:50] <RoanKattouw>	-				'$.wikiEditor.config = {' . implode( ',', $preferencesList ) . '};'
[23:17:52] <RoanKattouw>	+				'var wgWikiEditorPreferences = ' . FormatJson::encode( $preferences, true ) . ';'
[23:17:53] <RoanKattouw>	 			)
[23:18:15] <RoanKattouw>	Use UsabilityInitiative::addVariables() for that? In turn, that uses the makeGlobalVariablesJS hook (or whatever it's called), which provides a somewhat cleaner interface for this
[23:18:25] <RoanKattouw>	And groups all the var declarations in one <script> tag
[23:18:47] *RoanKattouw 	apologizes for appearing nitpicky, this is what I'm like in code review mode
[23:19:41] <RoanKattouw>	 		// Remove the old toolbar
[23:19:43] <RoanKattouw>	 		$j( '#toolbar' ).remove();
[23:19:44] <RoanKattouw>	-		// Build a wikiEditor around the textarea
[23:19:45] <RoanKattouw>	-		$j( 'textarea#wpTextbox1' ).wikiEditor( {
[23:19:47] <RoanKattouw>	+// Add toolbar module
[23:19:48] <RoanKattouw>	+$j( '#wpTextbox1' ).wikiEditor( 'addModule', {
[23:19:50] <RoanKattouw>	Indentation?
[23:20:17] <RoanKattouw>	TrevorParscal: Did you just scap prototype?
[23:20:44] <TrevorParscal>	no
[23:21:33] <TrevorParscal>	indentation, yeah, sorry ...
[23:21:49] <TrevorParscal>	I don't know, that whole bit was changing allot and then ended up much the same as it started...
[23:22:13] <TrevorParscal>	and the addVariables thing doesn't allow you to set a json object, only a string/number
[23:22:16] <TrevorParscal>	*scalar
[23:22:41] <RoanKattouw>	Hm, then that should be fixed :)
[23:23:45] <TrevorParscal>	yeah, I think there's actually a comment there that says I want to do that
[23:24:07] <RoanKattouw>	+	'author' => 'Trevor Parscal, Roan Kattouw, Nimish Goutam and Adam Miller',
[23:24:17] <TrevorParscal>	yes?
[23:24:21] <RoanKattouw>	That supports arrays, which presumably will localize 'and'
[23:24:32] <RoanKattouw>	(and I just realized it misspells Nimish's last name)
[23:24:36] <TrevorParscal>	ooh! really! that would be nice
[23:25:05] <TrevorParscal>	shall I arrayifiy that list?
[23:25:12] <nimish_g>	arrayify credits?
[23:25:25] <TrevorParscal>	yes
[23:25:27] <TrevorParscal>	doing it now
[23:25:58] <RoanKattouw>	 	/**
[23:25:59] <RoanKattouw>	+	 * From here down, with very little modification is a copy of what's found in Vector/Vector.hooks.php.
[23:26:00] <RoanKattouw>	+	 * Perhaps we could find a clean way of eliminating this redundancy.
[23:26:02] <RoanKattouw>	+	 */
[23:26:15] <TrevorParscal>	you like that?
[23:26:28] <RoanKattouw>	I noticed that too, and I believe I may have even seen it in a third place
[23:26:31] <TrevorParscal>	I spent an hour trying to use some sort of LSB type thingy and just resorted to that
[23:26:36] <nimish_g>	RoanKattouw: what do you think of adding an extra step in the minify and combining js? http://code.google.com/closure/compiler/
[23:26:38] <RoanKattouw>	But on second thought, that could be a post-midnight delusion
[23:27:38] <RoanKattouw>	nimish_g: Hm, that seems to make sense, but we'd have to be very careful for regressions
[23:28:31] <nimish_g>	yeah I don't know how stable it is, and it could make debugging a bitch, but some of this syntax hilighting stuff (which only really lives on the whiteboard right now) might get pretty computationally-heavy. A crazy optimizer would help
[23:28:50] <RoanKattouw>	Some toolbar stuff is already heavy
[23:29:04] <RoanKattouw>	I wonder what that compiler would do to jQuery :P
[23:29:36] <RoanKattouw>	Would be fun to run jQuery through it and see what happens
[23:31:32] <TrevorParscal>	I just ran jquery.wikiEditor.js through it, and it got it down to 939 bytes gzipped from 7.24KB raw
[23:31:52] <RoanKattouw>	heh
[23:31:57] <RoanKattouw>	What about EditToolbar.js
[23:32:02] <TrevorParscal>	checkin
[23:32:47] <TrevorParscal>	9.09KB gzipped from 63.54KB raw
[23:32:52] <RoanKattouw>	Nice
[23:32:56] <RoanKattouw>	Factor 7 both times
[23:33:13] *RoanKattouw 	wonders if property names in EditToolbar.js were preserved
[23:33:24] <TrevorParscal>	what's the min and gzipped size of EditToolbar.js as we are doing it now?
[23:33:46] <RoanKattouw>	Min is in SVN
[23:33:51] <RoanKattouw>	Gzipped I don't know
[23:34:45] *RoanKattouw 	goes from review mode to fixing our SVN mode
[23:36:26] <TrevorParscal>	:)
[23:36:37] <TrevorParscal>	I just fixed the makefile
[23:36:40] <TrevorParscal>	might want to update that
[23:37:02] <RoanKattouw>	Yeah thanks
[23:39:08] <TrevorParscal>	the closure compiler got EditToolbar.js down to 43.01KB (not gzipped) and our current use of JSMin only got it down to 47.62KB
[23:39:47] <TrevorParscal>	and I think the gzip ratio of the compiled version is a bit better as well due to the way they re-use a, b, c etc. as variable names
[23:42:54] <Ryan_Lane>	I'm creating the pl, it, and fr prototypes. Where can I get a dump for content?
[23:44:39] <RoanKattouw>	Ryan_Lane: You can get recursive dumps using Special:Export, but I may need to give you rights for that
[23:44:52] <RoanKattouw>	Ryan_Lane: If you go to Special:Export on e.g. plwiki, do you see a small textbox you can enter a number in?
[23:45:00] <Ryan_Lane>	gimme a sec
[23:45:18] <RoanKattouw>	TrevorParscal: What's the predecessor of WikiEditor/Modules/Highlight? Was there any?
[23:45:25] <TrevorParscal>	nope
[23:45:30] <TrevorParscal>	it's brand spanking new
[23:45:33] <TrevorParscal>	mostly spanking
[23:45:34] <RoanKattouw>	OK good
[23:45:54] <Ryan_Lane>	no place for a number
[23:46:01] <RoanKattouw>	OK I'll sysop you, sec
[23:46:06] <Ryan_Lane>	k
[23:46:12] <RoanKattouw>	Ryan_Lane: What's your username?
[23:46:18] <Ryan_Lane>	Ryan lane
[23:47:23] <RoanKattouw>	# (del/undel) 13:47, 6 November 2009 Catrope (talk | contribs) changed global group membership for User:Ryan lane from (none) to Staff ??? (Ryan Lane works for the usability team)
[23:47:28] <RoanKattouw>	Refresh the form
[23:47:50] <Ryan_Lane>	do I need to logout/login?
[23:47:59] <RoanKattouw>	No
[23:48:09] <RoanKattouw>	TrevorParscal: Ugh, you renamed the toolbar files, diff -urN doesn't like that :(
[23:48:28] <Ryan_Lane>	not seeing it. I'm supposed to be on pl.wikipedia.org right?
[23:48:38] <RoanKattouw>	Yeah
[23:48:41] <RoanKattouw>	Hm, lemme check
[23:49:15] *TrevorParscal 	makes RoanKattouw's job difficult
[23:49:30] <RoanKattouw>	Ah, staffs don't have the override-export-depth right
[23:50:45] <RoanKattouw>	# (del/undel) 13:50, 6 November 2009 Catrope (talk | contribs) changed global group membership for User:Ryan lane from Staff to Staff, sysadmin ??? (Temporarily making Ryan a sysadmin so he can do recursive exports)
[23:50:52] <RoanKattouw>	Ryan_Lane: Try again
[23:51:07] <Ryan_Lane>	Yeah. working now
[23:51:21] <Ryan_Lane>	so, I should export Main Page? With what depth?
[23:51:22] <RoanKattouw>	Ryan_Lane: And notify me when I'm done so I can take that right away again; I'm not sure people like the idea of you having certain rights that come with the sysadmin group
[23:51:30] <RoanKattouw>	Main Page depth 1 should be fine
[23:51:34] <Ryan_Lane>	ok
[23:51:38] <RoanKattouw>	Depth 2 is generally huge
[23:51:42] <RoanKattouw>	Importing is very slow
[23:51:43] <Ryan_Lane>	It might be sometime late tonight
[23:51:59] <RoanKattouw>	Like, importing a few thousand pages will take hours
[23:52:55] <Ryan_Lane>	I need to change my password to something more secure :)
[23:56:34] <RoanKattouw>	TrevorParscal: You'd already renamed the SideBySidePreview messages in-place?
[23:56:51] <TrevorParscal>	in-place?
[23:56:56] <RoanKattouw>	Ah, before moving
[23:57:00] <TrevorParscal>	yes
[23:57:05] <TrevorParscal>	sorry
[23:57:09] <RoanKattouw>	No worries
[23:57:14] <RoanKattouw>	And you did update the JS for that?
[23:57:44] <RoanKattouw>	OK hands off SVN everyone, there's some ninja action going down
[23:58:56] <TrevorParscal>	ha ha
[23:59:03] <nimish_g>	it's a massacre
[23:59:13] <nimish_g>	code flying everywhere
[23:59:31] <RoanKattouw>	And it's the second one of the day