[00:00:32] *TrevorParscal almost got hit in the face with a //FIXME: comment [00:28:19] And the grand restructuring is done [00:29:57] I strongly recommend you svn up, and to backup any local changes [00:57:53] RoanKattouw: you rock! [01:44:52] Prototype wikis seem to be broken... [19:17:58] TrevorParscal: + context.$content = context.$iframe.contents().find( 'body > pre' ); [19:18:05] Overly specific selector? [19:18:48] maybe? [19:19:11] I mean, it's possible we will end up having a pre somewhere in there [19:19:20] like when we start building out UI and such [19:19:27] for template forms and what have you [19:19:35] hi everyone [19:19:54] TrevorParscal: Yeah that's probably true [19:19:55] So it seems less error prone as it is [19:20:06] that was my thinking anyways [19:20:17] we could use your help [19:20:25] we are doing some really fun stuff right now [19:21:04] we are building out the functionality previously provided by the textSelection plugin in the wikiEditor context.fn space [19:21:11] Ah yes, I just realized how much work that is [19:21:18] and so far I've just been planning to keep API compatiblity [19:21:33] That's not sacrde [19:21:36] *sacred [19:21:50] yeah, I figured we would do it that way to start [19:22:01] and then clean up the API where it makes sense [19:22:06] just to do one thing at a time [19:22:32] Yeah [19:22:43] one thing I expect to be wacky is the difference between byte offsets when using textareas and whatever is used with the iframe, probably character offsets .. [19:23:06] But the whole relative offset thing we discussed during numerous drives up and down CA-1 has to materialize first before we can implement any of this [19:23:16] Yeah, character != byte [19:23:23] *RoanKattouw still hates Opera for that [19:24:10] yeah - so the with a designMode iframe, I am interested to see how things are handled.. researching it now [19:24:26] BTW does trunk still work? [19:24:39] um... atm not completely [19:24:54] all text selection stuff is still in the middle of being ported [19:24:56] Heh I thought so [19:25:07] My preview changes should merge fine though [19:25:41] nimish is porting the codepress selection code over to the wikiEditor's context.fn.* space [19:25:59] which will replace the textSelection stuff [19:26:13] I've already tweaked the line of code for the toolbar that handles that [19:26:24] yes, and my head asploding while looking @ it [19:26:29] but the dialogs do all kinds of stuff with text selection that will need to be ported [19:26:45] and the TOC will probably get tweaked a bit as well [19:26:54] my head is also exploding :( [19:27:25] but if we can push through this change, we will be mostly done with what we are to be releasing in december [19:27:56] merging of acai/babaco, magic iframe, fixed all rediculous textarea related bugs, etc. [19:28:03] so we have some time.. [19:28:19] *TrevorParscal spins in his office chair [19:28:57] Take it easy guys, this is not something you do in 7 hours :) [19:29:12] And your well-deserved lunch break is only 30 mins away [19:29:25] ha ha [19:29:34] so what part of all this do you want to tackle RoanKattouw ? [19:29:44] what are you working on / interested in working on? [19:29:54] I'm currently working on the preview stuff still [19:30:11] k [19:30:23] But that's mostly done, except that it's on my laptop and I'm at my stepdad's, where there'll be no wifi till this time tomorrow [19:30:23] well, once the text selection is basically working [19:30:57] I will probably want you to port the dialogs over to the new stuff (should be trivial to change the dialog code, but may open many cans of worms in the process) [19:31:13] I'll take any task that's not clearly out of my league, but I have the small logistical problem of having one computer with internet access and another one with MediaWiki for the next 24 hrs [19:32:10] That's cool; you're right it'll probably involve more regression testing and fixing than actual porting [19:32:15] And I know that code best [19:32:59] :) [19:39:53] Is there anything else I can work on over the weekend? [19:40:35] At this point it doesn't sound like the text selection code will be working properly before Monday [19:43:14] well [19:43:17] with preview [19:43:22] now that we have an iframe [19:43:39] the preview has to make a preview of the code in the iframe not the textarea [19:43:59] That's easy [19:44:15] var wikitext = context.$textarea.val(); [19:44:40] so, we need to make the copy back and forth functions a bit more modular, and on preview it needs to copy from the iframe to the textarea before using the textarea's content for a preview [19:44:46] You guys would presumably write a function that grabs the content from the iframe, falling back to the textarea if the former is not present [19:45:00] No, that's not necessary [19:45:17] I can grab wikitext from the iframe just fine if you provide a function for that [19:45:28] And the pre-submit handler already does the copying, so I'm fine there too [19:45:36] yeah [19:46:01] you would be basically just taking the pre-submit handler and making the part that does the copy resusable [19:46:08] and doing that just before the preview [19:46:11] I wouldn't even need that [19:46:23] Just the part that grabs the contents [19:46:38] Which I guess is also in there, you're right [19:46:39] it's important to note that we use the textarea not just as a place to store the wikitext, but a way to decode the HTML entitites [19:46:48] Aah yes [19:46:54] In that case we probably do need to copy [19:47:16] so the context.$textarea.html( some html here ) results in context.$textarea.val() being correct code [19:47:26] Yeah [19:47:38] things like & get correctly converted [19:47:46] Not to mention
[19:47:49] that's the only way to do that in javascript [19:48:00] we do the
tags manually [19:48:10] but yes, [19:49:10] when you look at the codepress getCode() function (in the engines.js file) you see that they are trying to do allot of replacements themselves rather than using the textarea HTML entitiy decoding trick [19:52:04] TrevorParscal: The "↓ Contents" thing in the preview wireframe, is that a collapse/expand thing for the NTOC? [19:52:23] um, it's like a show thing [19:52:36] it's supposed to end up much more like the wireframe I did afaik [19:52:43] adam has been poking at that [19:54:13] OK so I don't need to do that [19:55:09] That means I have a pretty complete patch for preview at this point, implementing the entire wireframe except for the collapse thing and the fact that it takes the copyright warning straight from the existing one instead of doing a distilled version [19:55:32] awesome [19:55:35] Also, I wasn't totally sure what the "Cancel" (top right) and "Go back" (dialog) buttons were supposed to do [19:55:47] Go back just closes the dialog right now [19:56:24] And I'm not sure whether to make "Cancel" behave like the brower's back button (that's what it does now) or like "Reset", resetting the textarea contents [19:57:38] *RoanKattouw requests parutron_ 's input on the above [19:58:42] does the same as the cancel link [19:59:18] Refresh the page you mean? [19:59:28] That's cool, that means I can just put no handler on it :) [20:19:28] TrevorParscal, parutron_ : Another question: when the user closes the save dialog, do we want to preserve the values of the summary box and the minor/watch checkboxes, or do we want to wipe them? [21:14:28] TrevorParscal, nimish_g: FYI, I'm gonna look at that Polish Wikipedia gadget Naoko mentioned [21:22:19] k [21:22:40] RoanKattouw: we should not blank them out [21:22:46] they should be persistent [21:22:58] OK [21:22:59] how's it going? [21:23:01] That's what I have now [21:23:17] It's pretty much done, but I need to wait till tomorrow to commit it [21:23:25] k [21:23:41] how's school going? [21:23:43] Because I need to set up wifi in this house first, and I'm missing an Ethernet cable [21:23:48] Good, I passed one of my exams [21:23:53] The other one is still unknown [21:24:51] why not just buy an ethernet cable [21:24:53] and expense it [21:25:06] be like "i needed this to do work"... [21:27:07] hehe [21:27:10] I am gonna do that [21:27:19] But you can't buy Ethernet cables at 8 PM in this place [21:27:37] (that = buy the cable, not expense it) [21:27:50] My stepdad wants wifi in his place anyway, he'll pay for the cable