[17:57:28] yeah - copy/paste seems great with ff 3.5 [18:03:59] So are we gonna go with Skype or call-in? [18:04:34] TrevorParscal: OK I committed my code, lots of random crap happening there [18:05:15] nkomura: Are we gonna do Skype or call-in? [18:06:05] hannes-tank: [18:06:11] hi [18:06:18] hannes-tank: we have a call [18:06:24] i know [18:06:31] "host not ready" [18:06:40] we are in [18:06:45] can you call back? [18:06:52] i ll try [18:07:27] RoanKattouw: call in [18:08:02] OK. Ping me when I should call [18:09:06] we are ib roan [18:09:12] OK I'm calling too [18:10:53] *RoanKattouw is in [18:17:09] RoanKattouw: did you notice sandbox 1, 4, and 5 are broken as well? [18:17:23] *RoanKattouw is in a meeting [18:17:32] No, thanks for reporting [19:36:18] nkomura: I fixed the bug where in-article links on deployment pointed to en-wp [19:36:31] I also unbroke the prototypes and sandboxes that were broken [19:41:48] nimish_g: Could you tell Trevor to get back on IRC now that he's obviously walking and talking and committing code :) [19:42:09] I promised him I'd explain how the left nav clicktracking works [19:53:06] RoanKattouw: thanks for the fix in the deployment [19:53:18] Sure [19:54:25] nkomura: I also disabled SimpleSearch on deployment [19:54:49] TrevorParscal: Still want the explanation of how the left nav clicktracking is done? [19:55:22] Hm wait, I don't even have to explain that to you [19:55:47] Just fire up LiveHTTPHeaders and click a left nav link on the en prototype [20:17:00] RoanKattouw: will you reflect the changes in all prototypes? [20:17:16] we should verify all prototypes today [20:33:44] nkomura: Which changes? [21:05:21] TrevorParscal: why'd you ditch the margins for fixed widths when you were doing the wikiEditor structure changes? [21:05:45] margins for fixed widths? [21:06:24] before, it was setting a margin right on the text area, and a width on the TOC [21:06:31] ah [21:06:33] and shifting the TOC back into place with a negative margin [21:06:37] well now they are no longer in the same div [21:07:05] so we need a new approach? [21:07:10] so now they don't need margins set, but we need to update the widths dynamically on resize [21:07:27] we used to be able to allow VSS logic to handle the resize for us [21:07:36] VSS? [21:07:39] now we just need to do an on resize event [21:07:45] sorry CSS [21:13:22] Are you guys talking about how the TOC looks really weird right now, especially with preview enabled? [21:15:11] yeah, related to that [21:15:22] i'm talking about how it looks weird as soon as you change your browser window [21:15:39] TrevorParscal: can't we still do it all with CSS? [21:16:10] margin-right on the toolbar, and text, negative margin-right on the right container, and set the width on the left container [21:16:44] Hm [21:16:51] It now has the title in the toolbar for me [21:16:56] *RoanKattouw disables preview to see what happens [21:17:34] Same thing [21:17:52] Is the fact that the page title appears in the toolbar intentional? [21:17:59] no i don't think so [21:18:06] that's not what was wireframed anyway [21:18:37] Hm, well I guess you guys will sort it out [21:19:06] yeah i'll try to get that sorted out in a few minutes here [21:41:15] adam_miller: can we still do it with css - hmm [21:41:23] well, basically we have 2 divs [21:41:26] i've got it working locally [21:41:27] left and right [21:41:33] nevermind [21:41:40] i'm sure you've got it sorted [21:41:46] yeah i think this should work [21:42:04] there's some weirdness we'll have to deal with with height adjustments when you expand or collapse a toolbar menu [21:42:11] but other than that, it's working like it used to [21:42:30] you are awesome [21:50:21] adam_miller: how close are you to commiting? [21:50:31] a few minutes away [21:50:44] awesome [21:52:36] RoanKattouw: where do we stand with the text selection stuff? [21:52:46] I'm trying to figure out what I should be working on.... [21:52:54] TrevorParscal: EncapsulateSelection is done, but for Firefox only [21:53:00] k [21:53:12] Nimish and I sort of agreed that I would be working on code for moving the cursor and/or selection places [21:53:23] but if you wanna do that that's cool too [21:53:28] k [21:53:31] As long as it's element-based, like scrollToTop() is [21:53:54] Then of course we need IE support in encapsulateSelection() and every other function we write, and I still don't have IE [21:53:56] well, I was hoping to split up the preview module like I was sort of laying out in that email [21:54:02] *RoanKattouw hates xen for being so much trouble [21:54:08] Ah yes [21:54:13] Move the tabbing stuff to wikiEditor [21:54:15] That's cool [21:56:05] alright, committed my css and basic js changes [21:56:27] i'm gonna work on fixing the resizing now [22:01:02] adam_miller: You've got console.log() calls in your committed code again. No rush, but do clean them up at the end of the day, as they break in non-Firebug environments [22:01:33] bah, sorry. removed it and will commit soon [22:04:05] we need to write a script we can use as svn hooks or something to detect that [22:10:26] RoanKattouw: I had an idea for how to reduce the number of requests with all these plugins [22:11:41] Shoot [22:11:57] (As in let's hear in, rather than "crap!") [22:12:54] ha [22:13:09] *it [22:13:55] well, we could combine and minify all the module specific scripts like Toolbar.js or Toc.js for instance, but use the new wgWikiEditorPreferences variable to make the code in each of them actually run or not [22:14:11] Good idea [22:14:14] which would make the resource totally cachable [22:14:24] we are already exporting the info, may as well use it [22:14:26] I will do that now [22:14:36] while helping nimish split up preview [22:15:24] Awesome [22:15:39] I have tomorrow off, so I'll be doing selection stuff [22:15:41] then [22:19:21] RoanKattouw: i still see new search box and side-by-side preview in prototypes [22:19:34] can you disable them? i want to verify all prototypes today [22:19:41] Yes, only deployment reflects the deployment state [22:20:17] Well you could have all prototypes tested, but they're not running the same code as the deployment wiki, so I don't see a huge benefit there [22:21:19] deployment is just in english [22:22:03] Yes [22:22:13] so that doesn't help verify other languages [22:22:22] That's true [22:22:34] I could make quick clones of the deployment wiki in other languages, takes like 10 mins [22:24:12] that'd be super [22:25:27] will you replace english prototype with deployment too? [22:26:09] i'm not sure if i can get to, but thinking of a blog about the release [22:26:27] Mind you, I wouldn't be replacing anything [22:26:33] I'd just be creating d-fr, d-de, etc. [22:26:56] With the same contents as the originals, but with different software [22:37:40] RoanKattouw: i'm not following you ... what do you mean by d-fr? [22:38:07] nkomura: prototype.wikimedia.org/fr-wp would still be what it is now: French Wikipedia content running on current software [22:38:27] prototype.wikimedia.org/d-fr/ would be the same frwiki content running on the to-be-deployed software [22:38:40] i see [22:38:49] deployment in french (d-fr) [22:39:28] Yes [22:39:34] Or, for pretty URLs, /deployment-fr/ [22:53:44] so it is good to go? [22:54:09] TrevorParscal: intersting problem - the mousemove and mouseup events i'm binding to $() don't fire when the mouse is in the iframe [22:54:28] nkomura: Not yet, I'm still working on it. Nearly finished though [22:54:44] adam_miller: That's because it's a separate document [22:54:45] k, let me know when i can start diving in [22:55:01] should i bind them to the iframe as well? can i even do that? [22:55:06] they fire in the iframe, just attach a handler to the iframe and then trigger the same action on the parent document [22:55:39] context.$iframe[0].contentWindow.document [22:55:46] awesome thanks [22:56:27] $( context.$iframe[0].contentWindow.document ).bind( 'mousedown', function( e ) { /* trigger something on document or whatever */ } ); [22:58:58] how do I target the parent document from inside the function to trigger the event on it? [22:59:16] nkomura: They should be ready now. They're slow because I disabled caching, I'm investigating how I can enable it without the deployment and the non-deployment version of a wiki biting each other [22:59:52] RoanKattouw: great, how do i get to deployment for non-english? [22:59:55] Hm I'm probably gonna need that technique too since I'll need to capture keydowns on the iframe at some point [23:00:03] nkomura: http://prototype.wikimedia.org/deployment-fr/ [23:00:11] Replace fr by any language code [23:00:23] nice [23:01:43] The languages we have are ar, de, en, fr, it, ja, pl, ru, si, sr [23:01:53] Oops, the bottom half of the alphabet are broken [23:01:59] RoanKattouw: beta is set default for prototypes [23:02:20] they need to be un-default for me to test watch/unwatch feature [23:03:19] OK, on its way [23:04:15] OK try now [23:04:34] k [23:07:05] i still see beta is enabled without opting in [23:07:21] Yeah me too [23:07:27] Oh wait Vector is still enabled [23:07:29] *RoanKattouw disables [23:08:19] do i need to create an account on deployment? [23:08:39] *RoanKattouw clearly needs sleep, types "$wgDefaultSkin = 'vector';" to disable Vector [23:09:03] nkomura: Your accounts carry over from their mirror wikis [23:09:21] So you don't need to create an account on d-ja if you already have one on ja prototype [23:09:37] i am on french wiki right now [23:09:53] i probably haven't created my account on french prototype [23:15:00] adam_miller: the border around the drop down arrow still looks funky [23:15:01] http://prototype.wikimedia.org/deployment-de/Wikipedia:Hauptseite [23:15:23] ok - I just committed some good stuff! [23:15:29] everyone should update [23:15:51] nkomura, adam_miller: Could be that I just didn't merge that rev. If Adam can tell me in which rev he fixed that, I'll merge it [23:16:22] I did commit something to attempt to fix it. i'm checking if it's there [23:16:36] now, the Vector and WikiEditor extension's modules's javascript files use the wgWikiEditorPreferences / wgVectorPreferences objects to turn things on or off, and all the javascript files for each modules get combined and minified [23:16:50] Nice [23:16:53] *RoanKattouw looks at the rev [23:17:04] so instead of 7 different raw javascript files, you now get 2 minified ones [23:18:18] it seems it's missing [23:19:07] TrevorParscal: Warning: Invalid argument supplied for foreach() in /srv/org/wikimedia/prototype/extensions/UsabilityInitiative/Vector/Vector.hooks.php on line 108
[23:19:23] hmm - ? [23:19:31] I tested it on raw, combined and min [23:19:59] $wgUsabilityInitiativeResourceMode could be garbage, and should default to raw in that case [23:20:07] ah [23:20:07] yes [23:20:19] (or not set) [23:20:33] Oh wait it can't be not set, nm [23:20:45] so what's going on in your install? [23:21:10] i have to help the fundraisers [23:21:30] RoanKattouw: r58570 should be applied to the german prototype wiki to fix that problem [23:21:31] perhaps you could come up with a clean way to ensure that variable is a valid value in a central place? [23:21:38] like the initialize() function>? [23:21:49] Maybe [23:21:54] UsabilityInitiative::initiatlize() [23:21:59] adam_miller and RoanKattouw: cascading tabs not working on de deployment [23:22:09] 800 x 600 look pretty broken [23:22:11] could be like, if it's not one of these values, then set it to 'min' or something... [23:22:20] http://prototype.wikimedia.org/deployment-de/Wikipedia:Hauptseite [23:22:20] nkomura: Probably part of a larger issue [23:22:24] I'm fixing it now [23:22:30] TrevorParscal: 'minified', not 'min' [23:22:37] hmm [23:22:39] what is the larger issue? [23:22:55] that seems to be the issue right there [23:23:00] I used min in my arrays [23:23:04] and tested with min [23:23:10] Yes, use minified instead, that's what we used to use [23:23:15] And what prototype is configured for [23:23:16] which made UsabilityInitiative resort back to raw or something [23:23:28] ok [23:23:30] let me fix [23:24:12] No, which made the code break [23:24:25] self::$scripts['minified'] doesn't exist, but should [23:24:39] Anyway, s/min/minified/ in WikiEditor.hook.php and Vector.hooks.php and we're fine [23:24:40] cascading tabs not working in english prototype too [23:24:48] just commited the fix [23:24:55] brb [23:25:40] nkomura: Refresh the page and try again please, we had some issues [23:26:07] so all languages are ready to be tested? [23:26:28] Should be [23:27:07] *RoanKattouw points TrevorParscal to https://bugzilla.wikimedia.org/show_bug.cgi?id=21471 [23:27:56] opt-in user flow is broken again [23:28:20] For anons? [23:28:30] yes [23:28:38] welcome beta gives feedback form [23:28:59] the same problem we fixed when you were here [23:29:34] Right [23:29:38] I'm trying to reproduce it now [23:30:08] Works just fine for me [23:30:29] in deployment? [23:30:37] I created an account, then clicked "Return to Special:UsabilityInitiativeOptIn" all the way at the bottom of the welcome page (OK maybe novice users don't do this), then clicked Let's do it again [23:30:47] Yes [23:30:54] Lemme try it the other way [23:31:10] i'm talking about the flow after "let's do it" [23:31:48] the page after "let's do it" should not show the beta feedback and leave beta text [23:31:54] it should go to welcome page [23:32:08] You mean the page titled "Welcome to Beta"? [23:32:33] the page says Welcome to Beta [23:32:52] Yeah [23:32:57] And it displays in Vector, right? [23:32:57] but the text says Thank you for trying the Beta. We would like to know what you think about our new interface, so we would appreciate it if you filled out the optional survey below before clicking "Leave Beta". If you would like to continue using Beta, you can return to Main Page. [23:33:03] Huh [23:33:08] That's not happening for me [23:33:24] k [23:33:29] Could you try to reproduce this again using a brand new account and telling me which steps you take and on which wiki? [23:34:15] If you tell me what you're doing as you go through the process, I can go along with you [23:34:16] sure [23:34:33] I'm at http://prototype.wikimedia.org/deployment-en/Main_Page [23:34:38] not logged in [23:35:47] OK [23:36:03] 1) I clicked "Try Beta" link and at the landing page [23:37:13] Yes [23:38:12] TrevorParscal: + // Check preferences for toolbar in toc.js , minor copypaste mistake [23:38:42] TrevorParscal: +if ( $j.wikiEditor.isSupportKnown() && !$j.wikiEditor.isSupported() ) {return $(this); [23:38:49] TrevorParscal: Use $ consistently there [23:39:46] RoanKattouw: ok it worked for me this time [23:40:31] Otherwise the code could explode in certain exotic environments [23:40:33] Hm, weird [23:40:46] i'm trying with my account now [23:40:56] yeah, that was a mistake [23:41:05] can you fix it for me [23:41:12] I'm on nimish's computer [23:41:15] I feel lost [23:41:16] nkomura: Using an account that already exists will not do what you expect [23:41:48] TrevorParscal: Maybe that's because you're in the wrong body [23:41:57] is there a ryan lane in the house? [23:42:07] what's ryan's handle? [23:42:11] anyone? [23:42:27] rlane i think [23:42:32] i don't see him [23:42:42] out of curiosity - when did he join our team?? [23:42:56] he's been around for a few months [23:43:00] nimish: im in ur eclipse changin ur prefs [23:43:02] he was on the whiteboard chart we made [23:43:03] what does he do again? [23:43:07] *nkomura starts testing deployment [23:43:17] DB stuff. TrevorParscal, no worries [23:43:27] parutron_: ryan does all the cool stuff [23:43:34] he does admin support [23:43:49] also currently setting up test automation environment [23:43:53] 120 character margin line now visible [23:45:26] RoanKattouw: got syntax error when i tried to view watch list [23:45:27] Parse error: syntax error, unexpected T_SL in /srv/org/wikimedia/prototype/wikis/d/includes/DefaultSettings.php on line 1608 [23:45:36] nkomura: Fixed [23:45:47] tee hee [23:45:55] at least someone is doing all the cool stuff [23:45:56] haha [23:45:57] I was merging Adam's fix and it threw a merge conflict [23:46:44] *nkomura wonders about the readiness of Thursday's deployment [23:49:18] nkomura: It's just the one rev I forgot to throw in [23:49:22] k, cascading tabs still not working ... [23:49:29] *RoanKattouw tries [23:52:59] Hm, it could be I forgot to merge in some more revs [23:53:21] RoanKattouw: i think we need to step back a little [23:53:31] and approach this more systematically [23:54:05] can you update english prototype with the targeted features first? [23:54:14] *parutron wonders if she can help [23:54:23] and let's confirm all the features are functioning properly [23:54:28] and test the rest of languages [23:55:06] i have 4pm meeting so i'll be away for 30 minutes [23:55:32] parutron: You can test collapsibletabs when I tell you to [23:55:45] i'm waiting for your signal! [23:56:31] cascading tabs is working on en.prototype but not on deployment [23:57:11] Yeah that's weird [23:58:31] nimish: why the width:50% on wikiEditor-tabs and wikiEditor-buttons? [23:59:14] I was going off TrevorParscal 's layout [23:59:44] those two rules made the whole thing editor shrink in half for me [23:59:53] thing editor! :)