[18:17:08] TrevorParscal: Noooooo, not again :( [18:17:16] ? [18:17:27] Another day of fundraising work? [18:18:57] oh [18:19:05] no just commiting some work I did last night [18:19:38] *relief* [18:19:41] ha [18:19:50] we got work to do on Citron [18:19:52] I worked on the IE issues at uni today and sorted some out [18:19:57] No, we got work to do on IE bugs [18:20:23] There's basically two issues left, but one of them was already broken anyway, and the other should be easy [18:21:29] Right now, most issues are fixed except for select+replacing headers (inserts after the header instead of replacing it, but is broken much worse on Wikipedia) and the selection not being picked up by the link dialog (hopefully easy once I take a look at the code) [18:29:07] TrevorParscal: have I ever told you how much I hate IE? [18:29:11] I have a copy now [18:29:25] IE sucks [18:29:30] Microsoft sucks [18:29:50] People who choose to use IE despite being aware of other options suck [18:29:57] this bug is pissing me off [18:30:09] all these people should be shot, or at least moved to a remote island without internet access [18:30:21] If you use the AJAX edit form in IE7, then it appears broken -- none of the textboxes appear [18:30:39] then I open up the debugger, use the "select by clicking" option, and click where the textbox should be [18:30:51] it seems to be in the HTML, so I go back to the browser, where the textbox has magically appeared [18:31:22] what the fuck, IE. What the fuck. [18:34:00] I think that finding the textbox in the HTML causes IE to "discover" it [18:34:03] it's bizarre. [18:35:09] s/discover/remember/ maybe [18:53:51] *RoanKattouw points TrevorParscal and the other fundraising techs to http://www.nedworks.org/~mark/reqstats/reqstats-weekly.png [18:57:06] i can haz moar traffic [19:01:09] Hey at least now the fundraising screwup holds the traffic record, we're off the hook :) [19:03:04] hi everyone [19:03:09] *Roan-meeting has called in for the meeting already, listens to ridiculous waiting music [19:04:31] this music is much better than i've previously experienced waiting for confy calls to start [19:05:04] much more regal, less elevator-y [19:10:11] Roan-meeting: there's a console.log() in jquery.wikiEditor.js on the deployment candidate [19:12:58] hello nkomura [19:17:03] http://usability.wikimedia.org/wiki/Beta_Feedback_Survey [19:19:06] TrevorParscal: Did you design the thermometer fundraiser banner? [19:20:33] If so, you have incurred the wrath of Domas [20:53:14] Roan-meeting: wha'ts domas's issue with the thermometer? [20:53:24] I might be able to sprite some of the images... [20:53:38] but that would mean I spend more time doing fundraising work [20:53:42] TrevorParscal: I think there are too many images, yes. Ask domas for details [20:53:48] and that would incur the wrath of naoko [20:54:10] Yes [20:54:41] if we're seriously 4 or 5 images per page away from melting down, we have more serious problems than the design of the banners [20:54:48] heh [20:55:28] OK so do you still have to eat or are you ready to crunch some IE bugs? [20:58:19] TrevorParscal: ? [21:00:31] yes [21:01:09] Is that "yes I'm ready to kick IE ass"? [21:01:35] hi werdna. did you try to reach me? [21:02:12] nkomura1: not for anything in particular [21:02:32] k, saw your earlier ping [21:02:53] TrevorParscal: do you have any clue on IE7 hating innerHTML (as used through $j(some html) ) [21:03:41] I just use the jquery $(something).html( some html here ) [21:06:39] TrevorParscal: I assume that uses innerHTML as well [21:07:12] well, it's abstracted - so it should use whatever is needed to get it to work the same as other browsers [21:07:19] I could look at the implementation [21:07:23] are you without jquery? [21:07:29] I looked at the implementation [21:07:33] no, I'm using jQuery [21:07:50] $j(container).load(wgServer+wgScript, 'title='+encodeURIComponent(wgPageName)+ [21:07:53] query+'&lqt_inline=1', finishSetup ); [21:08:01] then doing this [21:08:01] $j(container).slideDown( 'slow', finishShow ); [21:08:09] in finishSetup [21:08:26] but in IE7, any textboxes and textareas do not display correctly [21:08:30] (i.e. all I get is blank space) [21:08:36] but here's the really really weird thing [21:08:58] if I go into the IE8 (in IE7 mode) debugger and disable then enable one of the CSS properties, it looks correct [21:09:07] you need to put anything that depends on content added with html() or innerHTML() in a timeout set to 1ms [21:09:39] the dom manipulation may take a fraction of a second to happen, meanwhile the code will continue to run asynchronously [21:10:00] making the selection of content created with the html() or innerHTML() functions unavailable [21:10:15] and from browser to browser this tends to be inconsistent [21:10:35] so just wrapping it in a timeout is ugly scary hackery, but seems to somehow consistently work [21:11:16] well, I'm using load() [21:11:33] I think I was wrong in saying that $j(html) is used [21:11:45] *werdna fails at reporting problems [21:12:55] http://autocompleteme.com/ [21:12:59] load() should have a callback [21:13:15] yes, I'm using that [21:14:15] parutron_: Hilarious, spreading that on identi.ca and Twitter [21:14:29] if you have ten seconds to look at the code, it's at http://pastebin.ca/1675370 (just the method in question) [21:16:00] parutron_: try also: i like to [21:16:10] haha [21:16:16] i just tried "why do" [21:16:44] OH MY GOD [21:16:53] I get funnier ones in the search bar than on the site [21:16:54] i like to think of jesus as a mischevious badger TOO! [21:17:12] :D [21:17:14] Hah "Why is there a dead Pakistani on my couch" is now on top for "why is" [21:17:24] *RoanKattouw cheers on LOST references in Google autocomplete [21:17:42] werdna: have you checked the values of some of these variabels you are using in your conditional statements? [21:18:40] it's possible that the closure finishSetup has slightly different scoping than you think when it's made into a variable rather than defined inline or as a function with a name... Not sure... [21:18:41] werdna: Could you do me a favor and test something for me in IE? [21:18:46] yes [21:18:49] Or TrevorParscal , anyone with IE [21:18:56] *TrevorParscal fires up IE [21:18:58] RoanKattouw: I'll do it [21:19:03] TrevorParscal is MIINE [21:19:04] http://prototype.wikimedia.org/d-en/index.php?title=Manchester_Small-Scale_Experimental_Machine&action=edit --> select some text and use the dialog to linkify it [21:19:13] The selected text should appear in the dialog (twice) [21:19:32] VM firing up [21:19:41] *RoanKattouw and werdna roll over the floor fighting over who owns TrevorParscal [21:19:51] TrevorParscal: which vars are you thinking of? [21:19:54] did I already ask that? [21:20:12] Rand is sitting in the bushes with a sniper riffle, ready to take me back to his "war room" [21:20:41] werdna: preload ? [21:20:43] RoanKattouw: I'm not even getting the enhanced toolbar [21:20:54] JS errors? [21:20:55] TrevorParscal: if it's preloading text into the textbox [21:21:15] RoanKattouw: none, I'm not even getting vector [21:21:22] *TrevorParscal is reaching his threading limit [21:21:25] RoanKattouw - Bold and italic are both working for me in IE7 now [21:21:42] werdna: Oh sorry; create an account and enable it [21:21:58] password resetting :) [21:22:01] adam_miller: Awesome. How about selecting text and clicking the link button? [21:22:18] *RoanKattouw multithreads three verifiers [21:23:00] the link button did not work, it put it at the top of the textarea [21:23:06] the cursor stayed in place though [21:23:51] adam_miller: Did it copy the selected text to the dialog? [21:23:53] TrevorParscal: you can see the symptoms in IE7 at http://liquidthreads.labs.wikimedia.org/wiki/Talk:Main_Page -- try clicking a reply link [21:23:56] if you have the time [21:24:55] RaonKattouw: no it did not. the dialog pops open with blank input fields [21:24:58] crap [21:25:00] Gah [21:25:01] i was in IE6 [21:25:04] ha [21:25:09] wow - lqt in IE6 == death [21:25:22] Hmm I wonder if focus events work asynchronously [21:25:22] hah [21:25:39] Like if you do $(this).focus(); something that depends on this having focus [21:26:07] Will 1) this be focused at the time of the second statement (I think so) and 2) all event handlers bound to focus have been run (I don't think so) [21:27:31] adam_miller: 1) is this the case even after Shift+Refresh? 2) does the first textbox in the dialog receive focus when the dialog opens? [21:28:06] gosh dang my comp is so slow when I run VMs [21:28:16] i have 4gb of ram, but... it still suck [21:28:18] *sucks [21:28:27] gosh dang? [21:29:07] werdna: People in the US don't actually swear, they just pretend to [21:29:42] RoanKattouw: 1) after clearing the cache with dev toolbar AND shift refreshing. 2) No, when the dialog opens the textarea seems to has focus with the cursor at the beginning of the text but when i type, nothing is changed. [21:29:44] werdna: IE7 is behaving [21:29:50] for me [21:30:16] and gall-darnit! I can pretend to effing swear all I want! :) [21:30:56] adam_miller: Try shift+refresh again? [21:31:29] RoanKattouw: bingo, works now [21:31:45] text is placed in both fields and first has focus with the cursor at the end of the text [21:32:00] brb - getting food quickly [21:32:03] TrevorParscal: you can successfully AJAX reply with IE7? [21:32:37] adam_miller: Awesome! Is insertion still broken? [21:32:44] RoanKattouw - the link is still being inserted at the top of the text area though, instead of at the cursor location prior to clicking the insert link button [21:32:54] Yeah [21:33:00] But the cursor does stay in place, right? [21:33:29] hmm i dont think so [21:33:42] let me try again to confirm but i think it goes back to the very beginning [21:34:05] werdna: script error -> document.editForm = $(some selector thingy) [21:34:11] ok, so the cursor is placed right after the inserted text [21:34:15] document.editForm ? [21:34:21] TrevorParscal: ugh, I thought I fixed that already [21:34:25] :) [21:34:26] brb [21:34:59] [andrew@zwinger LiquidThreads_alpha]$ grep -i 'document.editform' lqt.js [21:35:02] [andrew@zwinger LiquidThreads_alpha]$ [21:35:11] there may be some caching there? [21:36:33] I've manually purged it [21:36:39] adam_miller: Shift+Refresh and try again? [21:38:32] adam_miller: Also try inserting text in a position that's scrolled out of range. What happens then? [21:39:49] cleared cache, refreshed, scrolled, and it still put the link right at the top [21:40:11] Damn [21:42:11] adam_miller: Try again? [21:42:40] adam_miller: Also, could you try putting the cursor on a position, scrolling that position out of view, then clicking Bold? Does it automatically scroll it back into view [21:43:38] ok, still broken - no change, but the the second thing totally works [21:43:51] select text, scroll it out of view, click bold, and it scrolls it right back in [21:43:56] Good [21:45:16] adam_miller: Could you enable debugging and pastebin the output of the debugging console? (Needs IE8) [21:46:27] can you run ie7 and ie8 on the same machine without hacks? [21:46:57] I don't know [21:47:12] Maybe TrevorParscal can run IE8 in a VM [21:47:22] aight i'm gonna clone my ie7 vm and get IE8 installed on it [21:47:34] the link thing worked 2 2nd time.. [21:47:41] *second [21:47:53] TrevorParscal, adam_miller, werdna: Whoever gets to it, please do the following: 1) turn on debugging 2) try inserting a link 3) pastebin console output [21:48:07] RoanKattouw: the first time, it did nothing [21:48:13] there was no console output [21:48:19] it just did nothing on first click [21:48:22] Yeah, my mistake, Shift+Refresh [21:48:33] each click after that works [21:48:40] First click on what? [21:48:47] link button [21:48:55] hmm [21:49:01] did a full reload [21:49:07] now it works on first click in IE7 [21:49:10] Ah good [21:49:14] well, IE8 in IE7 mode.. [21:49:19] should I try real IE7? [21:49:31] TrevorParscal: did you try again? [21:49:41] your thing? [21:50:58] werdna: works now [21:51:37] hmm [21:51:43] just sitting there, i got an IE error [21:52:21] 'attr(...)' is null or not an object - lqt.js line 286 character 4 [21:55:25] okay, will look at that [21:55:27] I'm so confused [21:55:33] it breaks in IE8 in IE7 mode for me [21:55:41] *werdna grumbles, will look closer tomorrow [21:56:09] TrevorParscal, adam_miller, werdna: Can either of you get me that console log output? [21:56:17] working on it [21:56:21] microsoft sucks so badly, we need a whole new set of dirty words just for them [21:56:32] RoanKattouw: there was no console output [21:56:33] it worked [21:56:51] TrevorParscal: What do you mean it worked? [21:57:06] the link button worked in IE7 after a full reload [21:57:07] Inserting a link worked as in it's not inserting on top of the page? [21:57:14] yes [21:57:18] worked as expected [21:58:25] :O Really? [22:00:13] http://pastebin.ca/1675429 [22:00:22] ie8 mode allows the console output aparently [22:01:08] TrevorParscal: Right, but the feature did work as expected? The link got inserted at the right place? Can you test this both with and without selected text? [22:01:43] yes [22:01:44] both [22:01:48] AWESOME [22:01:49] in IE7 and IE8 modes [22:01:56] you are the IE master! [22:02:06] can we get you some software or something so you can test locally? [22:02:10] a machine perhaps? [22:02:19] mac mini? [22:02:27] with VMWare or something? for mac + windows... [22:03:00] OK now I just gotta sort out what I did and commit it [22:03:15] ha ha [22:04:08] RoanKattouw - console output http://i46.tinypic.com/2u6ckfm.png [22:04:32] adam_miller: Thanks; can you confirm Trevor's observation that link insertion works now? [22:04:36] and not to be a party pooper but it didn't work for me [22:04:40] still put the link at the top [22:04:58] this was in IE8 with it set to IE7 mode with the debugger on [22:05:14] adam_miller: Try Shift+Refresh? Try IE7 mode off? [22:06:50] no matter what i do it seems to put it at the top of the textarea [22:06:55] adam_miller: mash buttons until it works.... like an NES game, or an american car [22:08:05] TrevorParscal: Can you Shift+Refresh and see if it still works? [22:08:29] perfectly [22:08:54] http://pastebin.ca/1675447 [22:09:40] maybe adam's computer has a strange virus that only affects this particular feature of wikipedia's editing tools... [22:09:43] it is windows... [22:09:57] it's a mac, with parallels [22:09:59] maybe worse? [22:10:02] :) [22:10:30] has it been completely demagnitized [22:10:45] by steven hawking himself [22:10:47] Then I guess werdna will have to be the tiebreaker [22:11:11] adam_miller: have you tried turning it on and off again... [22:12:27] *RoanKattouw lassoes werdna [22:13:18] hmm? [22:13:33] *werdna turns on the Win7 box [22:14:50] RoanKattouw: gimme the link [22:15:11] http://prototype.wikimedia.org/d-en/index.php?title=Manchester_Small-Scale_Experimental_Machine&action=edit [22:15:37] werdna: Select some text in the middle of the article, click the link dialog (text should be filled in in dialog fields), and click insert (text should be replaced by link) [22:18:20] adam_miller, TrevorParscal: Meanwhile, could you Shift+Refresh yet again and confirm that the textarea does not automatically lose focus after 250 ms? [22:20:31] I'm not sure I understand....250 ms after what? page load? [22:20:38] looking good [22:20:46] assuming page load [22:20:58] No, 250 ms after the last keypress on the textarea [22:21:42] looks good to me [22:21:51] i counted to 30 already [22:21:59] after keypress [22:22:08] OK good [22:24:52] RoanKattouw: sorry, disappeared [22:24:56] good for me too in 7 and 8 [22:27:00] RoanKattouw: hmm, I seem to be unable to edit the page title and link text textboxes [22:27:26] werdna: Does the page title textbox receive focus upon opening the dialog? Or does the textarea get focus? [22:27:45] ... and the link goes to the top of the window too [22:27:56] RoanKattouw: I don't know where the focus is, when I type nothing happens [22:28:22] this is IE8 [22:28:23] *RoanKattouw WTFs [22:28:30] werdna: Did you Shift+Refresh? [22:28:40] I didn't have the edit toolbar enabled previously [22:29:50] Still, try Shift+Refresh [22:29:52] *RoanKattouw is paranoid [22:30:23] just did [22:30:27] looks like the textbox has focus [22:31:14] Grrrrrrrrr [22:31:30] TrevorParscal: You're the only one for whom it worked. Could /you/ Shift+Refresh and try again? [22:31:38] sure [22:32:06] TrevorParscal: I know you love domas [22:32:22] he's awesome [22:32:29] we love to bicker [22:32:36] and hug [22:32:37] huuuugs [22:32:37] RoanKattouw: yes, still working great [22:32:44] werdna: I gave him a gug [22:32:57] *hug at the berlin dev conference [22:33:09] it's like hugging a sequoia tree [22:33:21] haha [22:33:36] hah [22:33:40] RoanKattouw: gimme the link again [22:33:45] http://prototype.wikimedia.org/d-en/index.php?title=Manchester_Small-Scale_Experimental_Machine&action=edit [22:33:53] Or any edit page on that wiki, really [22:34:29] still no worky [22:34:33] let me try in IE7 compat mode [22:35:18] still fails, RoanKattouw [22:35:37] I'll turn on debugging [22:36:24] nothing [22:36:55] where do I find the IE8 console? [22:37:06] F12 [22:37:13] Then click "Start debugging" [22:37:42] yes, but where does the console appear? [22:38:31] In a separate window [22:38:39] Should be in Tools -> Developer tools or sometihng [22:38:55] I'm in the developer tools [22:39:04] but where in that thing is the console/ [22:39:16] There should be a tab near the top right of that window that says Console [22:39:30] oh never mind, I found it [22:39:35] in the script tab [22:40:01] OK so doing the link insert thing I talked about should cause some output to appear in the console [22:40:17] you mean the link icon in the toolbar, to be clear? [22:41:00] Yes [22:41:21] I don't think I'm even getting anything in the console [22:41:27] Oh wait [22:41:29] *RoanKattouw slaps himself [22:41:33] I cleaned that up [22:42:03] still nothing [22:42:12] Shift+Refresh and try again? [22:42:21] *RoanKattouw had accidentally removed the console.log() calls already [22:43:19] 'tis loadin' [22:44:26] slowly [22:45:15] Load avg on prototype: 0.00 0.00 0.00 [22:45:35] That can't be the problem :P [22:48:42] LOG: Not setting selection [22:48:43] LOG: Blurring, selection = (882,892) [22:48:43] LOG: Setting selection to (882,892) [22:48:43] LOG: Not setting selection [22:48:43] LOG: Blurring, selection = (0,0) [22:48:45] LOG: Setting selection to (0,0) [22:48:47] LOG: Blurring, selection = (0,0) [22:48:50] LOG: Setting selection to (0,0) [22:48:52] LOG: Blurring, selection = (0,0) [22:49:36] Meh [22:49:43] That's the same output Adam got. But Trevor got something else [22:49:50] wtf? [22:49:50] *RoanKattouw is thoroughly confused [22:49:54] what OS? [22:50:01] I was using Win7 [22:51:11] Win7 Professional, IE8 [22:52:51] RoanKattouw: i have a quick question for you when you have a moment [22:53:10] Sure [22:57:50] my vm's are all running XP [22:58:06] nkomura: Fire away [23:02:19] I guess it kinda depends on how this is used, and the nature of the client. Bots performing maintenance tasks can afford to wait for maxlag to drop, but tools like AWB that aim to provide relatively fast user interaction don't want to wait all day. In a scenario where one slave is badly lagged but the rest is not, avglag could help for these slightly higher priority edits. Of course it would... [23:02:21] ...need to be set to a low value like 2. [23:02:24] Oops, copypaste fail [23:02:35] catrope * r59185 /branches/usability/acaifix/ (7 files in 4 dirs): acaifix: Some IE fixes. This should fix bug 21492, bug 21220, bug 21248 and bug 21246 [23:02:54] TrevorParscal adam_miller werdna: Please verify each of these bugs so I know which ones I can close [23:03:24] where do I test it? same page? [23:04:28] Any edit page [23:04:46] 21492 Toolbar buttons insert text on top in IE [23:04:49] confirmed fixed [23:04:58] in IE8 [23:05:22] 21492 is fixed [23:05:30] 21220 Opera/IE : Not copy the highlighted value to Page Title [23:05:39] confirmed fixed (except the field is still read only) [23:06:28] 21220 is fixed (checking all these in IE7) [23:06:51] whoa freaky, clicking discussion just makes the page scroll [23:07:28] 21248 signature jumping up into text in IE8 [23:07:39] adam_miller: Do you have werdna's can't-edit-textboxes-in-dialog problem [23:07:46] still happens, but it seems to be only if you're on a blank line, which is deliberate I assume [23:07:51] otherwise confirmed fixed [23:08:06] werdna: If you're on a blank line it goes to the previous one? [23:08:30] RoanKattouw: yes i do, weird [23:08:38] didn't notice that before [23:08:52] i can't edit, or even get the text inputs to gain focus [23:09:17] RoanKattouw: yes [23:09:27] OK I'll try to deal with that after you guys are done confirming stuff [23:09:43] http://prototype.wikimedia.org/d-en/index.php?title=Manchester_Small-Scale_Experimental_Machine&action=historysubmit&diff=5539&oldid=5465 [23:09:47] search and replace works [23:09:56] so 21246 Search and Replace: Not function the Replace Next and Find Next in IE 7 [23:09:59] is confirmed fixed [23:14:55] RoanKattouw: i'm back. my question is what would happen to opt-in/out stats once a wiki goes default? [23:15:16] i suppose it stops taking any updates right? [23:15:26] nkomura: Well we'd disable OptIn on that wiki, so yes, it just stops adding new data [23:15:44] thanks [23:15:44] RoanKattouw: additional oddity - in IE7, whenever I click anywhere outside of the textarea, it scrolls the entire window to the text area. Links dont take me to the pages they're linking to, they just act as if they're anchor tags pointing at the textarea [23:16:01] adam_miller: OK I'm gonna try to fix that now [23:16:03] yes, that's the error I've found with the tab [23:16:08] just wanted to provide that information when i publish beta opt-in/out data [23:16:08] it's seriously broken :D [23:16:29] seriously. the buttons work, but no links [23:16:56] how do i get a signature button to show in the edit menu? [23:17:59] Nevermind :) [23:18:13] adam_miller, werdna: OK try now, with hard refresh [23:18:25] 21248 works for me in IE7 [23:18:39] RoanKattouw: I magically have IE6 powers now if needed [23:18:50] RoanKattouw: you are no fun [23:19:03] nimish_g: IE7 or 8 is what we need [23:19:11] RoanKattouw: fixed now [23:19:18] :O Awesome [23:19:41] It introduces the worst hack ever to replace the second worst hack ever [23:19:43] it does insert at the top still though [23:19:44] yep, so is the issue with the dialog [23:20:00] Wait what so now the link insert problem is unfixed? [23:20:14] NTOC is navigating nicely now too although the current section in the ntoc doesn't seem to be getting highlighted correctly [23:20:55] RoanKattouw: well, it inserts at the top [23:20:58] so *shrug* [23:21:03] Yes [23:21:10] But that was fixed at some point, rigt? [23:21:17] I don't think so [23:21:43] Hmm [23:21:57] ugh sorry but i gotta run kids, i've got people coming over for dinner tonight [23:22:03] No worries [23:22:10] RoanKattouw are you gonna be ok without my surrogate IE7? [23:22:18] Yeah I'll just abuse werdna [23:22:28] Although I realize it's 11:22 in London and he'll be off soon too [23:22:29] I may go to bed at some point [23:22:42] sick gf needs looking after [23:22:43] you guys are troopers [23:23:02] *RoanKattouw has taken to working till 1:30 on Tuesdays [23:23:02] adam_miller: I don't start until later [23:23:05] thanks for your help adam_miller [23:23:15] you bet i'll see you guys tomorrow [23:23:41] werdna: What's she got? [23:23:54]