[09:48:18] it seems that clicktracking is breaking some user scripts. [09:48:19] http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Scripts_are_down [10:48:07] for the record, I fixed it :) [10:51:10] werdna: By disabling CT you mean? [10:51:15] yes [10:52:45] *RoanKattouw claims credit for a future proper fix that allows running CT without messing with javascript: links [10:53:54] hey roan [10:54:47] where is the design of the insertlinkdialogues like in my mockup? [10:54:59] hannes-_-: http://prototype.wikimedia.org/sandbox.3/ [10:55:10] Go edit a page and click the link icon in the toolbar [10:55:30] no thats different [10:55:42] the structure is similar [10:55:52] but there are many differences in detail [10:57:19] what would you suggest for displaytext with invalid link entries? [10:59:34] Leave the display text alone under all circumstances, else you'll be suggesting there's something wrong there, which is never the case [11:00:04] "leave it alone" = black text? [11:00:18] cause we used blue and red as a kind of preview [11:00:25] Yes, that too [11:00:35] Don't change its display at all, ever [11:00:47] Because changing the display text doesn't change the blue/red/invalid status of the link [11:00:49] hmm, not sure about that [11:01:03] We talked about doing a separate "link preview" [11:01:16] yeah... i thought about that too [11:01:41] but i don tlike to have several previews [11:02:09] The link text textbox wouldn't be a preview any moer [11:02:10] i think it would be better to have that dialogue as slim as possible [11:02:21] I see that, but I don't want to confuse users [11:02:30] And you can't put the external link image in the textbox anyway [11:02:36] (I think) [11:02:44] ? [11:03:01] You know how an external link has a blue arrow image at the end? [11:03:01] it s not. is it? [11:03:08] ah ok.. [11:03:12] I don't think you can reliably put *that* in a textbox [11:03:22] So that kind of sinks the idea of previewing in a textbox [11:03:44] put the searchbox has a pic inside it, too [11:03:52] isn t that similar? [11:04:02] Sort of, yes, but the arrow would have to "walk along" with the text [11:04:09] I don't think that's possible [11:04:12] brb, I have to reboot [11:04:15] sure [13:06:38] hmm. [13:06:39] CollapsibleTabs.js:8TypeError: Result of expression '$moving.data('collapsibleTabsSettings')' [undefined] is not an object. [13:07:40] thedj: Noted, will ping Adam when he comes on [13:07:47] Safari 4 btw [13:07:51] on en.wp [13:09:10] it works on protype, so must be something missing in the wmf branch [14:23:11] roan? [14:23:23] Yeah? [14:23:45] let me try to explain my concern about the x hoover [14:23:57] u said thats part of jquery? [14:24:51] strange.... it looks so odd [14:24:54] Yeah but I gotta go in a few minutes [14:24:59] hmm... [14:25:04] Continue if you want, I'll read the chatlog [14:25:09] i ust noticed that there are two different ytsle [14:25:16] ups. [14:25:28] I jsut noticed, that there are two different styles [14:25:53] ok i ll write a mail - so everyone can read it [17:17:24] RoanKattouw_away - check out r59254 for the fix to the RTL vector menu style fix [17:34:37] adam_miller: ? [17:34:50] 14:06 < thedj> CollapsibleTabs.js:8TypeError: Result of expression '$moving.data('collapsibleTabsSettings')' [undefined] is not an object. [17:35:16] adam_miller: can I use collapsibletabs for other tabs? [17:35:18] did you *just * start seeing that? [17:35:24] safari 4 on english wikipedia. it's working on protype [17:35:24] if so, how? [17:35:34] adam_miller: no, couple of hourse ago. [17:36:13] safari on windows or mac? [17:36:17] mac [17:36:37] it's working on prototype, so much be a missing revision in the wmf branch [17:36:49] i can't get it to throw that error [17:37:04] i get it after i make the window very narrow. [17:37:05] i'm on 4.0.3 on os 10.6.1 [17:38:39] cache emptied, shift refreshed, debugger open - still can't see it [17:38:42] hmm, perhaps it's my javscript extensions somewhere... [17:38:48] i don't see it on nl.wp either. [17:40:03] ok, well let me know - i need to run home and will be offline for a bit [17:40:45] is there a trevor in the building? [17:40:47] apparently not? [17:41:13] is moving.data a jquery global ? [17:41:31] thedj: $moving is a jquery object, .data() is a method of that [17:41:43] You can use it to store stuff in DOM elements [17:41:50] ah [17:41:54] Apparently $moving.data('collapsibleTabsSettings') wasn't set [17:41:57] hmm, perhaps it's the mwembed gadget... [17:42:01] (you set with .data('foo', 'bar'); ) [17:42:03] I doubt that [17:43:17] ok, i think i know what it is. [17:43:31] double loading of jquery [17:43:40] Ah yes [17:43:49] Is LQT active on that wiki? [17:43:59] no, my new version of HotCat [17:44:03] Ah [17:44:31] we should really do something with callbacks for importScript. [17:44:37] Yeah [17:44:46] You could use addOnLoadHook() [17:44:52] no, doesn't work on safari [17:44:55] And check for jQuery presence in there [17:45:06] Safari fires onload before loading all scripts? [17:45:18] I'm sorry, but that's just broken behavior, plain and simple [17:45:42] i'm doing jquery stuff before domload is finished [17:45:50] You shouldn't do that ever [17:45:57] api queries [17:46:18] Ah, right, so you're not manipulating the DOM there [17:46:24] nope [17:47:10] Still, my advice is not to do that [17:47:12] But I gotta run now [17:47:14] but when you do import(); and then start using $j, you aren't garuanteed that the DOM imported file is parsed before it starts executing your commands. [17:47:31] it's just that only on Webkit that this is actually reality :D [17:52:35] thedj: am I hearig/reading that you are encountering issues with cascading tabs in english wikipedia? [17:53:32] found the cause. was a gadget loading jquery, causing a reset of .date(collapsibleTabsSettings) [17:53:38] s/date/data [17:54:25] as far as i'm concerned, the sooner we have a persistent and centralized jquery the better :D [17:54:45] i hear you [17:54:56] js2 would be even better [17:56:53] ah, js2 [17:57:12] hello nkomura [17:57:36] hi werdna, thank you for your help yesterday [17:57:40] much appreciated [17:58:08] it's cool [18:01:49] no problem :) [18:01:50] hi parutron [18:03:47] werdna: may i ask you another favor though? [18:03:58] will you change the rev status from new to ok? [18:04:08] i added the comments to five revs that you reviewed it [18:04:22] but i hate to keep them new while they are deployed already [18:05:47] I did mark them as OK [18:05:49] didn't I? [18:05:58] TrevorParscal: I had something to annoy you about but I forgot it [18:06:32] when you remember... feel free to poke me [18:06:35] werdna: that's good, they were unchanged when i checked yesterday [18:07:54] TrevorParscal: ah yes, is there any way to customise the tabs in vector? [18:08:19] werdna: did you get your question re: CollapsibleTabs answered? [18:09:18] how do you wish to customize them? [18:09:25] there's a hook that gets used [18:09:42] werdna: five revs you reviewed are still says "new". will you change them to "OK"? [18:09:47] Flagged revisions has been modified to use it [18:09:59] nkomura: which ones? [18:10:09] 96.93 [18:10:11] grr [18:10:14] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59191 [18:10:15] adam_miller: roan asked where, and then disappeared :) [18:10:16] wrong paste... [18:10:25] werdna: SkinTemplateNavigation hook [18:10:30] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59185 [18:10:48] what was the other copy for? [18:11:20] nkomura: I remember marking these OK, and leaving commens, but obviously it didn't go through [18:11:21] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58969 [18:11:38] 96.93 == amount I spent last night on computer hardware I am expensing [18:11:45] ah [18:11:48] what did you buy? [18:12:01] werdna: let me just list all five of them so that you have them [18:12:10] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/57541 [18:12:21] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/57425 [18:12:22] werdna: i wrote CollapsibleTabs to be portable and more of a utility but it's still a little biased towards our use case. [18:12:30] adam_miller: nod [18:12:38] how would I go about using it myself? [18:13:36] TrevorParscal: hmm, I seem to use SkinTemplateTabs [18:13:46] you'd need a container for each nav location, and you can pass css selectors to the plugin to identify them [18:13:50] yeah, that only works in monobook and modern [18:14:13] because they treat tabs as one consecutive list of items [18:14:32] I think we should eventually convert mono [18:14:41] you can also pass conditions for when it should expand and when it should collapse [18:14:47] monobook and modern to use SkinTemplateNavigation [18:14:55] and fix all usage [18:15:08] TrevorParscal: does SkinTemplateNavigation work for both? [18:15:10] but that's sort of... possibly allot of work to track all that down.. [18:15:18] Not yet [18:15:24] that's what I am saying [18:15:59] lame [18:16:27] SkinTemplateNavigation uses array( 'namespaces' => array( ... ), 'views' => array( ... ), 'actions' => array( ... ) ) [18:16:39] SkinTemplateTabs only has array( ... ) [18:16:52] nod [18:16:56] so, converting SkinTemplateTabs to use SkinTemplateNavigation is possible [18:17:06] but not the other way around [18:17:15] it would loose information [18:17:42] nod [18:18:11] when we rewrite MediaWiki in python, lets try and remember these architectural mistakes :) he he he [18:18:53] perl [18:19:06] ha! I knew you would say that [18:19:28] Perl 5 when it's finalized in three or four more years [18:23:09] 30 or 40 [18:27:23] TrevorParscal: does delayedBind support namespaced events? [18:40:01] hmm [18:41:48] since it does a stright up bind, it should [18:42:14] it adds some other bindings and triggers in there, but the actual binding is done as usual [18:42:21] so, you should be able to use namesapcing [18:48:03] ok, i think i'm going to refactor CollapsibleTabs a little bit soon - i'll give it a try [18:53:50] right on [18:56:53] hi aude [18:57:19] hey! [19:25:37] is there a RoanKattouw in the room? [19:25:40] how can I see the channel history? [19:26:06] hannes-_-: http://ur1.ca/8856 [19:35:16] parutron_: maybe! [19:35:28] hi werdna! [19:35:30] how are you? [19:35:52] I'm okay [19:35:58] just ok? [19:36:42] heh, nothing too exciting! [19:39:58] but nothing to complain about :) [21:43:04] *RoanKattouw wonders what's up with parutron 's "Forget this" e-mail [21:43:21] well i just thought that having a preview is too complicated too [21:43:28] and we should go back to something simple [21:43:41] what do you think? [21:44:20] Well the greying out invalid parts is a no-go [21:44:30] Basically because we just know something's invalid, not what's invalid about it [21:44:44] And I see how the red can be dissuading [21:45:26] In fact, I think the dialog's fine the way it is now, except maybe that the state icon (maybe even with a short text) could be on the right side next to the "Link target" label instead of next to the textbox [21:45:51] That was a good call of Hannes's, which has pretty much been in all of his mockups [21:49:35] werdna: About the CollapsibleTabs thing: just use the hook Trevor pointed you to so your tab gets picked up by Vector, then slap the "collapsible" class on it [21:49:53] No, they're at the top of top-level threads [21:49:55] like, within a page [21:50:11] what makes you think it was just hannes??? hahah [21:50:15] i agree though [21:50:32] the addition of the gray example text and the verification/icon placement should suffice [21:53:23] werdna: Then you can't reasonably collapse them into our dropdown, can you? [21:53:32] parutron: Aye [21:53:37] no, but maybe I can collapse them into my own dropdown with the same methods [21:53:46] Hm, good point [21:54:08] adam_miller is supposed to be rewriting stuff, right? Maybe he can generalize it to the point where you can choose which things to collapse into what [21:54:54] nkomura, others: I'll be away during office hours tomorrow, grandparents' 50th anniversary. I'll get cracking on the link dialog improvements parutron mentioned during my day, though [21:56:42] that's a nice occasion [21:56:49] congratulations [21:57:17] RoanKattouw: I'm sending email to tim, you and adam_miller about the CSS rev for RTL [21:57:43] Right; there's more of them, IIRC, I guess adam_miller knows best [21:58:09] really, i thought only 59254 [21:58:16] I'd also like http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59253 reviewed (fix for CollapsibleTabs so it can be enabled again) [21:58:27] nkomura: He redid stuff in a later rev, lemme check [21:58:54] r59224 and r59254 [22:00:22] nimish_g: Are you aware of the fact that CollapsibleTabs uses no database indexes whatsoever? I just realized that this morning, and I would advise against deploying a UI that queries the CT tables without adding the proper indexes first [22:00:57] RoanKattouw: so does tim know about those revs? [22:01:02] collapsible tabs? [22:01:04] or shall i let him know? [22:01:09] nimish_g: ClickTracking :D [22:01:19] nkomura: I don't think Tim knows anything at this point [22:01:21] uses no database indexes? what do you mean/ [22:01:26] k [22:01:30] nimish_g: Do you even know what database indexes are? :P [22:01:39] evidently not [22:01:39] RoanKattouw: I have a homework for you ;) [22:01:49] What's that? [22:02:12] will you install VMware and windows on your machine asap? [22:02:28] Yeah I got that done a few hours ago, using VirtualBox (thanks werdna for the link) [22:02:38] :) [22:02:42] cool [22:02:47] oh, you're saying I'm not querying using any of the indexed columns? [22:02:55] :) [22:02:56] nimish_g: OK I'll fix it for you tomorrow [22:02:57] which Windows OS did you install? [22:03:04] nimish_g: There are no indexed columns AFAICT [22:03:09] XP [22:03:28] I just got it set up so I don't even know which version of IE it's running yet [22:03:38] what?? I'm almost certain that's not right, let me double check [22:04:19] adam_miller: there? [22:04:36] is IE8 supported on XP? [22:04:44] nimish_g: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.sql?revision=57548&view=markup http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UsabilityInitiative/ClickTracking/ClickTrackingEvents.sql?revision=55430&view=markup [22:04:47] nkomura: sorta - making dinner and entertaining a three year old [22:04:49] nkomura: Yes [22:04:55] checking back periodically [22:04:58] werdna said it was a few days ago [22:05:32] adam_miller: are both revisions needed for your CSS RTL fix? [22:05:37] RoanKattouw: primary keys ARE indexed [22:06:03] nimish_g: Yeah those are. But I can hardly believe that's all your querying by [22:06:29] nimish_g: Also, only one of the two tables has a primary key [22:06:35] And the syntax is not SQLite-compatible [22:06:46] yeah [22:06:49] (the latter's no biggie for WMF deployment of course) [22:06:52] *nkomura waves to adam_miller's son [22:14:55] RoanKattouw: ok yeah if you want to put indexes on that's fine but I'm kind of querying on every field in click_tracking [22:15:18] nimish_g: I'll take a look at the queries and determine what's needed [22:15:28] go for it =) [22:17:36] Will do tomorrow [22:18:00] I'm not gonna do anything but zombie for the half hour or so left todaty [22:21:20] *werdna notices that it is 22:21 [22:21:22] *werdna orders pizza [22:21:42] Dude can you eat that late? [22:21:58] If I did that I would have to go to sleep at like 2 or 3 [22:23:02] I'm going to sleep at 2 or 3 anyway [22:23:09] Lauren is at a midnight screening of a film [22:23:16] and I have many hours to myself to hack at random crap [22:23:55] and to drink, eat pizza [22:24:20] werdna: I put in a request for review and deployment of that ClickTracking fix of mine, but I guess that's less interesting that random crap and/or your girlfriend [22:24:34] I dunno [22:24:37] code review isn't hacking :D [22:25:13] Exactly [22:41:21] nimish_g: i don't want to make you the go to person for translation [22:41:28] so excuse me when i do exactly what i don't want to do! [22:41:31] http://blog.wikimedia.org/2009/11/18/ux-usability-study-take-two/ [22:42:03] my lame attempts to google translate comment 5: [22:42:41] I will sacrifice money, when you take a Yandex-money! I think many users from Russia of the same opinion. [22:42:52] Yandex money?!?! [22:43:57] sounds like spam parutron [22:44:10] that kind of comment shouldn't event be published [22:44:20] you can ping moka or jay to delete it [22:44:48] I agree, I'm double checking but it sounds like a russian company [22:45:04] oh tee hee [22:45:11] i thought it was somehow related to our fundraiser [22:45:25] like "well give you money when you take our [insert cultural niche here] money [22:45:33] like previously there money wasn't good enough for us [22:47:34] that's what it sounds like [22:48:46] *werdna eats pizza [23:00:14] parutron: I'm fine with being the translation guy =)