[00:33:48] i was wondering, will we see the SimpleSearch deployed on en.wp at some point ? [00:35:36] hi thedj. yes [00:35:44] the plan is to rollout in citron [00:35:53] which is scheduled in the second half of january [00:36:01] k. [00:36:15] i can tell you now, that many folks won't like it :D [00:36:28] why is that? [00:36:55] i say this based on that the Google custum search does the opposite (only search, not go), and that drew quite a few complaints as well :D [00:37:20] so i'm guessing the "core" users like having two functions. [00:38:27] perhaps a "search for more .." element after the go redirect is an idea. (no idea where to put that though) [00:39:11] even the list of articles is displayed as you type? [00:39:15] or an 'alt click' behaviour for the "go" button. [00:39:23] nkomura: definetly. [00:39:42] we still support "go" functionality, it is a different interaction [00:39:45] nkomura: because titles != content or section headers :D [00:42:15] not sure i follow you [00:43:07] nkomura: If I want to look for all page sections with the header JavaScript, i can't avoid ending up on the page "JavaScript" with the new interface. [00:43:44] I need to go to [[Special:Search]] by hand if i want to avoid this. Before i would just click the Search button, instead of the Go button. [00:45:51] so that is a usecase that the advanced users will miss. [00:47:28] is the search advanced tip such as including sections documented somewhere? [00:48:27] so to make sure i learn this correctly [00:48:38] if i wan to search a section for an article [00:48:51] http://en.wikipedia.org/w/index.php?title=Special%3ASearch&redirs=0&search=untrodden+ways&fulltext=Search&ns0=1 [00:49:18] correction [00:49:19] http://en.wikipedia.org/w/index.php?title=Special%3ASearch&redirs=1&search=She+dwelt+among+the+untrodden+ways&fulltext=Search&ns0=1 [00:49:51] In the new interface, I would always be taken to the article [[She dwelt among the untrodden ways]] [00:50:17] but as you can see, that sententence has many more mentions in wikipedia that I might want to see. [00:53:04] isn't that another reason removing "Go" as default search better way? [00:53:25] i thought Go was becoming the default behaviour ? [00:53:45] no, it is opposite [00:53:58] oh, because the prototype site uses Go. [00:54:40] anyway, whichever option you take away, SOME advanced users will complain. [00:54:40] the auto-fill is not working properly at a moment [00:55:11] yeah [00:55:21] we need to communicate the change clearly in advance [00:55:25] and get more feedback [00:56:55] nkomura: http://en.wikipedia.org/wiki/Wikipedia:Google_Custom_Search [00:57:03] That is Google Custom Search for Wikipedia. [00:57:27] And it only has the "Search" feature, no Go feature. And users of the Gadget disabled it because of that. [00:59:16] i see [00:59:27] thedj: sorry we caused a bit of confusion [00:59:45] search on prototypes are not quite at the presentable state yet [01:00:38] the plan is to integrate "Go" feature as auto-fill and also "contains" section for more expanded search in one interface [01:01:15] it is hard to communicate without working prototype ;) [01:01:25] yeah, i guess :D [01:03:03] search change is a big change, so we will make sure to communicate the change clearly [01:03:05] nkomura: someone changed some mediawiki hooks around on us, we had to change which hooks we were using, and now our search suggestion is not turning on - so I will need to work with Roan to get this sorted tomorow.. [01:03:07] thanks for your feedback [01:03:22] roger :D [01:03:35] TrevorParscal: got it [01:03:54] good nite all ! [01:04:04] good nite thedj [01:04:25] nkomura: btw. read http://www.webdesignerdepot.com/2009/12/wikipedia-redesign-whats-in-store/ sounded positive for an outside view. [01:04:37] yeah [01:04:45] we saw that earlier today [01:05:01] pretty comprehensive coverage including hidden features ;) [01:06:01] good to see that outsiders have interest for this. [01:06:28] i mean, that's what you guys are doing this for really :D [01:10:53] yeah, hopefully buzz like this will bring in more beta users [10:35:50] hi [10:47:07] hi [12:37:08] thedj: hey [12:37:20] can u see the toolbar on the prototypes? [12:44:02] Natalie: i'll check [12:44:35] nope [13:01:42] "natalie"? [13:48:24] hannes-_-: I think I know what the problem with the prototypes is, will hopefully be fixed in the next 15 mins or so [13:50:50] GREAT [13:56:41] Fixed now on en prototype [13:57:20] roan i love you [13:57:23] you saved my day [13:57:54] Rather, someone (probably Michael or Trevor) broke your day and I fixed it :) [13:58:04] Do you intend on demonstrating any sandboxes/ [13:58:12] In that case you might wanna check on those as well [13:58:39] yeah they are fine as much as i can see [13:58:46] Also, please verify that the basic functionality actually works; like I said Trevor changed quite a few things so he might've broken something along the way [13:59:02] I ll take some screenshot with me [13:59:04] to be sure [17:36:14] *Natalie pets thedj. [17:48:13] Hosiryuhosi: welcome to the usability IRC room [17:48:38] :) [17:51:54] nkomura : ??????????????????????????????? (????????????????????????????????????(?????????????????????????????????????????????????????????)) [17:52:08] ????????? [17:52:18] I have a meeting in eight minutes [17:52:56] so i will be idle for a while though [17:53:00] ???????????????????????????????????????????????????????????????????????????(?)?????????????????? (IE8(????????????IE7???????????????)) [17:53:13] ????????????????????????????????????????????? [17:53:19] ????????? [17:53:29] ??????,????????????????????? [17:53:51] ????????????????????????????????????????????? [17:53:59] thedj: Note that SimpleSearch does support both Search and Go, but you need to use the mouse (bug, need to provide this for arrow keys as well). The idea is that if you type "JavaScript", you'll get "JavaScript" as a suggestion (click that and you go to [[JavaScript]]) as well as "Pages containing JavaScript" (click that and you go to the search results page) [17:54:02] ??????????????????(??????????????????) [17:54:22] ?????????????????????????????????????????????????????????????????? [17:54:29] But I hear from TrevorParscal that SimpleSearch is totally broken right now (let's sort this out after the meeting) [17:54:49] yes - it's not really a big deal [17:54:52] ???????????????????????? [17:55:00] it's a order of scripts being included thing - agaion [17:55:00] nkomura@wikimedia.org ????????? [17:55:10] Gah [17:55:12] someone got rid of OnBeforePageDisplay [17:55:31] Was that dantman's EditPage rewrite? [17:59:16] DNS????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? [18:01:01] TrevorParscal: No they didn't, it's still there in trunj [18:01:21] Or do you mean OnBeforePageDisplay usage in our extension? [18:01:49] um.. [18:02:34] you are saying the hook is still there and working? [18:02:42] nkomura: Please ping me when the meeting starts, I've called in but I'm on hold [18:02:51] TrevorParscal: I'm saying it's there in the code, not sure about the working part [18:03:28] Except that Vector.php doesn't use BeforePageDisplay, it uses AjaxAddScript [18:03:40] RoanKattouw: will do [18:04:47] Ha, and the comment claims it's a beforeToolbar hook, fixed the comment [18:04:51] but it used to ... ? [18:04:54] checking [18:05:28] I found it [18:05:35] AjaxAddScript is only called if $wgUseAjax is true [18:05:39] We should use BeforePageDisplay [18:05:41] Fixing [18:06:44] polycom doesn't work... [18:08:51] TrevorParscal: Have you read http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59710#c4683 ? [18:09:10] The most hilarious sentence is "Roan, can you please assign someone from the usability team to teach Yaron the basics of web security?" [18:10:28] As I don't have the authority to assign anyone to do anything, and it's not like there's anyone on this team who didn't get their security lessons from Tim or me :) [18:12:46] yikes [18:12:53] that isn't nice :D [18:13:03] Nope, it's not nice, but it's true [18:13:07] RoanKattouw: we have problems with the phoe [18:13:11] Bleh [18:13:13] we may have to switch the room [18:13:39] RoanKattouw: still. might not be the best way to help people along... [18:13:47] have a nice meeting guys [18:22:41] RoanKattouw: hi [18:22:42] ping [18:22:50] call in now? [21:22:40] RoanKattouw: did you see this protected page textarea alignment bug? [21:22:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=21799 [21:22:55] Yes [21:22:58] Looking at it [21:23:04] right on [21:23:10] I'm convinced it's an unclosed tag in a system message, but I can' t find it [21:23:25] nkomura: Can you reproduce the bug you filed? [21:23:40] it is IE bug [21:23:45] it required me to reboot [21:23:46] TrevorParscal: Oh and PLEASE PLEASE PLEASE remember to update style versions and recombine when you change JS [21:23:55] yeah - sorry [21:24:02] i was being very lazy :( [21:24:18] I recombined for you twice today, for like a dozen revs [21:24:23] sort of just commiting away durring the meeting.. and some fixes yesterday too I think [21:24:29] There's no way you didn't see the 12 CodeReview notification e-mails [21:24:32] thanks! [21:24:35] i did [21:25:29] RoanKattouw: it won't help you much, but the text area looks fine on my FF3 on Ubuntu for Japanese [21:25:51] Yeah me too [21:26:02] *TrevorParscal can't reproduce either [21:26:18] I'll fire up and IE and look at it, trying different uselang= params too [21:26:19] not even on IE8? [21:29:07] Hello, everyone! Greetings from the People's Republic of China. [21:29:16] hello YaronK [21:29:24] how's Shanghai? [21:29:55] Nice - the buildings are insane, but the people are friendly. [21:30:15] I mean, the architecture. [21:30:23] And the food is excellent. [21:30:42] nice [21:30:48] is it really cold there? [21:31:19] In the 40s and 50s, basically. [21:31:27] I'm fine with my coat. [21:33:16] I gave a demo of Semantic MediaWiki to some college students here yesterday - it was an interesting experience. [21:33:40] what do you mean by interesting? [21:36:15] Well, among other things, I think there's a different attitude to being in a group - I and some other people spoke, and none of the students had any questions for us, which I thought meant that they weren't interested, but then afterwards, talking to them one-on-one, they had a whole bunch of questions. [21:38:24] yeah, communication style is quite different in asian countries [21:38:31] i can't speak for chinese community [21:38:54] but you would experience the similar pattern in japan too [21:39:15] they are not used to open discussion forum in public setting [21:39:46] Yeah - that makes sense. [21:40:33] This group was also much more into semantics than into wikis, which may or may not be also tied in. [21:49:07] TrevorParscal: Can I dynamically pull in a CSS file with jQuery? [21:49:55] Putting show changes in a tab is more trouble than I thought it was gonna be, thing is we don't have a clean external interface for diffing to something that's not a revision [21:54:14] RoanKattouw: interesting [21:54:25] well - yeah, so adding in CSS with jquery is easy [21:54:48] Add a to the ? [21:55:23] just do a $(document).append( $( '' ).attr( 'src', 'some/path/to/some/css/file' ) ); [21:55:29] it doesn't have to be in the head [21:55:42] neither do scripts [21:55:58] in fact, scripts should be at the bottom of the body for best performance [21:56:22] Right well I'm putting it in the head anyway because I'm running that code multiple times and want to add the CSS only once [21:57:16] Ha [21:57:29] Figure out what's wrong with this code and why it blows up your page ;) [21:57:40] $( 'head' ).append( $( 'link' ).attr( {'rel': 'stylesheet', 'type': 'text/css','href': stylepath + '/diff.css'} ) ); [21:59:18] $( 'link' ) should be $( '' ) [21:59:20] Yay, got it working. Implementation sucks on multiple levels, but it works [21:59:23] Exactly [21:59:43] *TrevorParscal passes the test! [21:59:53] *TrevorParscal expects cookie [21:59:59] *TrevorParscal demands cookie [22:00:15] You'll get that cookie when you recombine and bump style versions [22:00:51] For r59850 [22:02:11] OK guys I'm gonna take a shower now that my family is still awake, they'll hate me if I shower at 1 AM [22:02:18] Be back in 30ish [22:02:46] I have a CSS-related question too, actually - I moved the CSS for displaying template info into its own file, but now the formatting only shows up when you go to '&action=purge'. [22:03:17] Like here - http://discoursedb.org/w/index.php?title=Template:Good_XML&action=purge [22:04:12] I've seen this problem (MediaWiki caching doesn't allow for changing $wgOut) before, but I don't know how to fix it. [22:04:16] YaronK: That's because you added the CSS in the XML tag handler, probably [22:04:27] Yeah, I did. [22:04:52] And it doesn't get cached along with the rest [22:04:54] I mean, I don't want to add it for templates that don't use , if that's possible. [22:05:29] Workarounds: 1) add it everywhere 2) add before templateinfo's HTML output [22:05:48] Where (1) means adding TemplateInfo's CSS to all page views ever [22:05:55] Right, okay. [22:06:01] I'd prefer (2), not sure it'll work though [22:06:11] Will