[00:48:41] TrevorParscal: About your last commit: please add a comment clarifying the regex; I can figure it out but it took time. Also, you can use .replace( /\[|\]/g, '\\\$1' ) to escape [ and ] in one call [00:49:36] + alert( event.type ); [00:49:51] agh! [00:49:59] that shouldn't have been ther! [00:51:42] TrevorParscal: ... and recombine, bump style versions [00:51:55] gosh dang me [00:52:06] who the hell gave me commit access? [00:53:48] Well whoever it was didn't consider the possibility of holding meatloaf hostage in exchange for proper practice ;) [00:54:10] mmmm [00:55:17] RoanKattouw: I could use some IE and Opera help with the iframe [00:55:23] top priority afaik [00:55:46] What do you need help with? [00:56:00] I'm not gonna write any more code today, it's 1:55 [00:56:04] well, I'm getting strange errors in IE and total silence in Opera [00:56:09] yeah - I mean in the next few days [00:56:26] I added a ready event for modules [00:56:37] the event handling in wikiEditor is pretty slick actually [00:56:52] I'll poke at it [00:56:53] so now, toc doesn't build it's outline until the iframe is ready [00:57:03] I should remind you guys that I have 3 hours of paid work left this month [00:57:09] but yeah - things are just wonky in IE and silently not working in Opera [00:57:16] agh! [00:57:17] Of course that doesn't necessarily stop me from working, but I'll be feeling less obligated :) [00:57:23] ha ha... [00:57:29] So I'll probably spend tomorrow making Rob happy [00:57:47] But during the day (when all the SF folks are asleep and I can't do shell reqs anyway) I'll poke at the IE thing [00:57:52] Well, I could use some help with this in particular, so... we shall see [00:57:59] thanks man [00:58:08] I'm also working on writing a function that returns the DOM element right before or right after the cursor [00:58:13] For NTOC highlighting purposes [00:58:22] that will be very useful [00:58:26] As well as pressing/unpressing bold/italic [00:59:00] TrevorParscal: When recombining, also bump the style version for the combined files; added bonus: you get to bump it from 99 to 100 [00:59:24] agh! [01:01:37] ok [01:01:41] I'm heading home now [01:01:49] thanks for all your work today [01:02:06] (RoanKattouw)... and everyone I else too.. and stuff [01:02:07] ok [01:02:10] leaving now [01:26:43] adam_miller: i see the tooltip is updated in production [01:26:44] nice [01:27:22] i'll take a look [01:28:25] suuure is. looks good. [01:42:07] adam_miller: could you also confirm the RTL CSS fix is properly reflected in production as well? [01:43:32] looks like it is [01:43:45] just checked ar.wikipedia.org and that seems fine [01:43:53] great [01:44:00] nice work adam_miller [12:57:39] id [16:13:06] hmm, UI Droppable doesn't seem to be in my js2 combined setup [16:15:03] *werdna prods RoanKattouw [16:15:15] how can I get hold of the code and stick it in my combined js file? [16:20:54] hi nkomura [16:21:44] hi werdna [16:21:47] how are you? [16:21:58] I'm well, just doing some fun drag-and-drop UI for LiquidThreads [16:22:12] off for a month at the end of next week, too [16:22:17] that'll be fun [16:22:51] drag and drop [16:22:55] that sounds exciting [16:23:04] i thought you are around till the end of next week [16:24:57] yes [16:25:01] that's correct [16:25:16] It's for reordering threads and moving them underneath other threads [16:25:50] sorry i misread your text [16:25:59] i thought you said end of this week [16:26:08] it's okay :) [16:26:11] so all that exciting stuff is live on labs? [16:28:15] no, it's not done yet [16:29:10] let us know when we cab play with it [16:29:38] we have spare sandbox if you want to install it there [16:32:31] :) [16:34:24] werdna: I'll add Droppable then. We kind of adopted the policy of not adding stuff until we need it [16:34:33] And we (usability) don't use drag&drop [16:35:06] nkomura: Show changes tab I mentioned in the meeting yesterday: http://usability.wikimedia.org/wiki/File:Changes.png [16:35:23] (and that's not a mockup, it's a screenshot of working ode) [16:35:44] nice [16:36:40] it is a nice work flow to have "show changes" like that [16:36:56] RoanKattouw: it would be good to have experimental stuff in our sandboxes [16:37:00] including drag and drop [16:38:00] nkomura: We don't have drag and drop anywhere :) what would we use it for? [16:38:23] werdna is asking me to add a drag&drop module for him so can add drag&drop functionality to LiquidThreads [16:39:24] just because we don't use it, it doesn't mean we won't use it [16:39:36] if it is experimental stuff, why not? [16:40:28] code for sandbox does not need to be mirrored with what we are going to deploy in the near future [16:40:41] True [16:40:45] if it is a time constraint, i understand [16:40:50] But enabling drag&drop doesn't really do anything [16:40:54] we are heads down for making citron stable [16:41:02] You'd have to have a clear idea of what you're gonna use it for [16:41:16] For instance, Andrew wants to be able to switch thread order around with d&d [16:41:17] is it drag and drop within the browser? [16:41:24] Yes [16:41:31] or is it drag and drop from the desktop into the browser? [16:41:35] We could e.g. allow people to change the order of toolbar icons by dragging and dropping them [16:41:37] No, the former [16:41:55] i think it opens up potential [16:46:05] RoanKattouw_away: I fixed it, never mind [16:46:39] found the code in jQuery UI, copied it into my js2.combined.js [16:59:35] Ah yes you were keeping that around anywy [17:05:05] nod [18:20:19] RoanKattouw_away: ping when you around [18:25:37] How y'all doing today? [18:29:45] goodish [18:30:01] IE and Opera still suck, but otherwise things are good [18:31:33] ah, IE [18:31:37] my favourite browser [18:33:04] TrevorParscal: Back [18:33:12] I wrote the show changes tab thign [18:33:28] i see [18:33:29] Oh wait I still have to commit an API module for it :) [18:33:36] *RoanKattouw does tandem commits with himself [18:33:42] why not a changes module? [18:33:58] *TrevorParscal splits things up allot :) [18:34:41] Meh maybe [18:34:53] We should have shared code for "I want a tab filled with some AJAX stuff" [18:34:55] *TrevorParscal nitpicks [18:35:18] well, we did make shared code for I want a tab [18:35:21] Like a module that makes you a tab with a Loading thingy and all that and you just give it a URL, postdata object and a callback to handle the AJAX result [18:35:29] Yeah we could add it there [18:35:51] is the changes thing not implemented fully? or do I need to add some API thing to get it working? [18:36:02] I just added an API module for it [18:36:21] Or well, I added a parameter to a module so you can diff against a submitted text instead of just against a rev [18:38:29] ah - i see it now [18:39:34] we can see how dirty our diffs are [18:39:45] or.. maybe you are accidentally adding a new line at the end? [18:40:14] if I go to changes without making any actual changes, it shows I added a new line at the end [18:40:20] That's probably due to a lack of PST [18:40:26] PST? [18:40:30] Try adding a signature and compare the tab with the actual Show changes [18:40:53] pre-save transform [18:40:57] not pacific standard time :) [18:41:13] real show changes is fine [18:41:19] how do we run a PST then? [18:41:41] action=parse&onlypst [18:41:44] Still gotta do that [18:41:47] k [18:42:22] So that's two AJAX reqs; the alternative is adding a pst option in the module that does the diffing, not doing that since difftotext is kind of the limit of what I'll put up with there [18:46:12] TrevorParscal: So, need help with your I Hate Internet Explorer Crusade? [18:46:40] yes... [18:46:59] perhaps just see if you can detect why IE is freaking out [18:47:02] OK [18:47:19] i'm trying to get opera to respond somehow to some kind of event taking place in an iframe [18:47:20] You're running HEAD? What are you doing to make it freak out (just visiting the edit form I assume)? [18:47:26] yes [18:47:29] just visiting the pag [18:47:32] *page [18:47:34] in head [18:48:08] *RoanKattouw fires up VM [18:48:40] My last hour of paid work is officialy starting now [18:48:45] (in 2009 of course) [18:51:32] parutron, hannes-_-: Have you guys seen http://usability.wikimedia.org/wiki/File:Changes.png ? [18:52:21] TrevorParscal: The screen goes blank again, looks like another issue with modifying inside the iframe [18:52:27] AKA the DOM decapitating bug [18:52:35] grr [18:52:36] yes [18:52:48] we could pass the wikitext as a get parameter? [18:52:55] to the iframe HTML? [18:53:02] sounds wacky but might work [18:53:09] RoanKattouw: eeeeps! [18:53:14] i heard the oohs and aahs [18:53:21] and then i looked, and then i oohed and aahed [18:53:25] ha [18:55:12] It's still got a bit of a problem with that added line at the bottom and it doesn't process signatures just yet, but I already know how I'm gonna fix that [18:56:21] i'm saying, pass the wikitext we want to fill the iframe with as a parameter to the iframe via get parameter [18:56:23] well [18:56:25] that won't work [18:56:32] there's a get limit.. [18:56:33] grr [18:57:25] is the changes tab an option? or visible by default? [18:57:52] hannes-_-: By default [18:57:53] RoanKattouw: dude you need to set an avatar on identica [18:58:01] that scary gray face is driving me nuts ;) [18:58:04] Yeah I would if I had any non-horrible pics of myself [18:58:05] hannes-_- still up in the air at this point though [18:58:15] Oh wait TrevorParscal has a non-horrible pic of me at Embarcadero BART [18:58:31] I will email it to you ... in a bit [18:59:07] TrevorParscal: AFAIK that GET limit is not enforced consistently and is server-side rather than client-side [18:59:22] RoanKattouw: we could try it [18:59:29] So as long as the /client/ doesn't limit it, it should work [18:59:31] there's that nifty get function on the iframe HTML page [18:59:34] hmm, i wonder how newbies would react to the changes tab [18:59:36] Yeah [19:00:08] parutron: hallway test with the less technical / newer staff? [19:00:27] (after we get the dirty diff thing solved) [19:00:56] All the good guiney pigs are on the Mission St side of the office [19:00:56] and also, it would be interesting (perhaps good) if the changes tab were disabled until you actually make a change [19:01:15] Hm yeah [19:01:34] that would prevent them from clicking on it and getting nothing... and also give them more context that the changes we are talking about are their changes to the text - hence it comes to life when they make some [19:01:35] interessssting [19:01:45] TrevorParscal: What's &ts=now() for? Cache? [19:02:02] Then of course we would have to have a disabled tab look [19:02:24] i'm gonna think about it. but yeah, lets do some mission st. side testing when we have a feature set for citron we need some newbie perspective [19:02:32] you know during cary's wiki training might be a good time. [19:02:38] or at the end of it [19:02:45] we'll get a lot of first impressions [19:03:10] What/when's that? [19:03:16] And for whom? [19:03:19] (the training that is) [19:03:33] cary's hosting a wiki workshop [19:03:38] for anyone in the office that's interested [19:03:53] RoanKattouw: yes, that keeps the iframe from being cached - or at least prevents a cached version from being used [19:05:37] I'm thinking maybe we don't need the GET param 'cause the iframe can access the parent document's jQuery instance anyway [19:05:56] But I already coded up the former, so let's try that first [19:06:15] RoanKattouw: any thoughts about confirming that left navigation mystery event? [19:06:17] RoanKattouw: the get param is the instance number [19:06:29] there can be more than one wikiEditor instance on a page [19:06:33] I know [19:06:47] without that instance number, how can the iframe know which instance it's of? [19:06:50] parutron: Nope, I researched pretty extensively the other day and came up with nothing [19:07:11] TrevorParscal: Yes, yes, I know that. I'm talking about the &code=all_crap_goes_here param [19:07:39] RoanKattouw: oh.. [19:07:45] yeah, good point [19:07:53] it can reach into the wikiEditor and get it it'self! [19:08:04] context.fn.getContents() :) [19:09:41] Aye [19:09:49] Otherwise we get a fail like the one I just e-mailed you [19:09:58] *TrevorParscal laughs at useless and outdated web help -> http://www.javascriptkit.com/javatutors/ns6update.shtml [19:10:16] RoanKattouw: ha ha ha [19:11:01] "modern browsers such as IE6+ and Firefox" [19:12:22] TrevorParscal: You do realize your raising the font size to 9.5 pt makes the text kind of.... big? [19:12:59] 9pt seems to be the default size for me [19:13:36] RoanKattouw: i might not even do that at all [19:14:10] *RoanKattouw kills the font-size property to see what happens [19:15:18] http://translatewiki.net/wiki/File:Wikieditor-toolbar-tool-table.png [19:15:31] http://translatewiki.net/wiki/File:Wikieditor-toolbar-tool-table.pngn [19:15:33] http://translatewiki.net/wiki/File:Wikieditor-toolbar-tool-table.png [19:15:56] Oh that's a good one [19:16:11] Is that an idea of Siebrand's of did you just invent the idea of uploading screenshots to TW? [19:17:09] it was him [19:17:18] adam is changine that preview message to example [19:17:23] and we need to consider the image [19:18:41] IE8 fail: adding a CSS file to the doesn't work [19:20:34] TrevorParscal: [attr^=value] means attr contains value as a substring, right? [19:21:05] begins with [19:21:07] specifically [19:21:46] [attr*=value] is contains somewhere within [19:21:49] OK [19:21:55] [attr$=value] is ends with [19:24:41] Yay for broken behavior [19:24:57] RoanKattouw: while you are working on the html file for the iframe, you might want to wrap the event binding code in a $j( document ).ready( function() { ... } ); [19:25:11] Yeah [19:26:03] Something I'm struggling with now is that in IE, you can add style sheets to the and they show up when you do $('head link').each(function(){ console.log($(this).attr('href')); }); but $('head link [href*=diff.css]').size() returns 0 [19:26:17] Also, the style sheet isn't actually getting applied [19:27:12] *TrevorParscal looks at codemirror source to steal ideas [19:27:52] no space between link and [ ? [19:28:00] Oh oops [19:28:38] Yup that's it [19:30:58] Nope, IE still fails at the style sheet thing' [19:35:34] ie sucks [19:36:52] TrevorParscal: Don't call build() on the TOC in the iframe ready handler if the TOC isn't even set up yet at that point [19:37:14] The TOC delays its own setup, so it'll build just fine [19:37:53] RoanKattouw: well, i was getting errors cause it was trying to build to early [19:38:35] So you made it build too early and now you're not getting errors any more? :P [19:38:58] no, i moved it cause it was getting errors... [19:40:43] Oh right I commented it out and now it's not building [19:44:01] TrevorParscal: I'm gonna go watch a show now, good luck :) [19:44:10] k [19:52:26] nkomura: what were you seeing with the wikieditor dialogs in RTL mode that needs fixed? [19:53:28] the layout in the table was not reversed [19:53:49] but at that time there were tabs for wiki and external [19:53:59] so it won't apply anymore [19:54:01] yeah it looks pretty good right now [19:54:07] great [19:54:12] the buttons aren't switched, should we flip those? [19:54:23] you mean the link icon? [19:54:36] nah, 'INSERT' and 'CANCEL' [19:54:47] they're in the same order and on the same side as LTR languages [19:55:30] i think the layout should be the mirror image [19:55:53] k i'll mirror the buttons then [19:55:58] thanks [19:58:51] http://geekandpoke.typepad.com/.a/6a00d8341d3df553ef0120a7318403970b-800wi [20:00:53] Duesentrieb: usability coders don't make such mistake, ahem [20:01:05] :) [20:43:11] am I missing something, or is http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59832 adding code that references but never defines a variable called handler ? [20:43:17] in edit.js [20:43:18] at the bottom [20:57:04] adam_miller: i notice you were working on the link dialog. [20:57:31] i have two issues with trunk, where do you want me to report ? [21:00:58] mediawiki comments? [21:01:27] issues? bugs? [21:01:31] bugzilla [21:02:00] bugs [21:02:17] yeah then put your comments in bugzilla [21:02:19] first of all, i can no longer instert a link :D [21:02:22] bugzilla.wikimedia.org [21:02:47] hartman: in head, things are often a bit screwy durring the workday [21:02:51] you may just want to talk to us [21:03:06] jquery.wikiEditor.js:426 Error: WRONG_DOCUMENT_ERR: DOM Exception 4 [21:03:14] why i choose insert [21:03:19] range.insertNode( document.createTextNode( insertLines[i] ) [21:03:59] what browser? [21:04:03] Safari [21:04:07] 4 [21:04:07] looking [21:04:43] the range is on contentWindow, but the new textNode is created on document. [21:04:50] the button is just locked up to right? [21:05:16] i can only leave the dialog by choosing cancel [21:05:25] right.. [21:05:41] and bold/italics have the same error it appears... [21:06:27] RoanKattouw_away: are you away for the rest of the day? [21:08:14] hartman: I will look into this [21:09:09] Still want me to create bugreports ? [21:14:37] no, it's ok - we're in the middle of reworking that module anywyas [21:15:01] ok, also, when you select text, choose link [21:15:22] then type a destination link. it will override the original selected display text. [21:15:56] which is unlikely to be desired behavior. [21:16:23] but good that it now recognizes http:// :D [21:21:05] TrevorParscal: Yes, I found that edit.js breakage too [21:21:47] did you see my ie thing? [21:21:55] append() instead of html() [21:21:57] Yes [21:22:00] strange but interesting [21:22:24] Does that work? I had a fix that fixed the freezing but created an empty iframe [21:22:27] So yours is better [21:29:05] ha [21:35:55] svn up people [21:35:58] in 5 [21:36:08] 4, 3, 2 [21:36:15] .... [21:36:27] 1 [21:36:47] What does that fix [21:36:53] *RoanKattouw needs sleep and will do code review in the morning [21:37:14] Ah I see [21:37:18] General breakage [21:37:20] you like that [23:18:53] check out new wikihow [23:19:08] http://www.wikihow.com/Main-Page\ [23:23:42] nkomura1: when did they change their main page? [23:23:56] a few hours ago [23:24:16] wow, it's nice [23:24:22] nkomura1: do you have ideas for redesigning or changing wikipedia's main page? [23:25:20] i know it's always been a community process, but i think the community would be open to ideas [23:25:49] i have ideas and suggestions, but the usability project is currently focusing on editing tool as you know [23:26:03] hi aude [23:26:20] sure, that makes sense to focus on editing [23:26:25] i think and hope the main page or all wikimedia page can be a lot more interactive than current state [23:26:59] i helped out some when the main pages was redesigned, but that was back in 2005 and early 2006 [23:26:59] a long time ago [23:28:12] hi werdna [23:34:08] werdna: are you around tomorrow? [23:34:13] I'm always round [23:34:43] i know your taking a holiday soon [23:35:02] yes, end of next week [23:36:03] i have ideas about the HTMLForm class, for what i'm doing now, but also thinking about the user login form and other forms [23:38:18] but, i have to run out for dinner now. i will be around tomorrow and all next week if you have any time to discuss