[18:02:38] <RoanKattouw>	Morning nimish_g_
[18:03:14] <nimish_g_>	afternoon for me, actually =) I'm in Boston
[18:03:41] <pdhanda>	afternoon!
[18:03:51] <RoanKattouw>	Ah
[18:04:07] <RoanKattouw>	I saw you committing code at 9:55 PT so I thought you must be in the office
[18:05:11] <nimish_g_>	nah, I'm working from Boston for the next few days, and realistically probably sporadically throughout the next week as well
[18:05:37] <RoanKattouw>	Right
[18:05:52] <RoanKattouw>	I just wanted to quickly comment on something I saw in your last rev
[18:06:19] <RoanKattouw>	You added a getTemplateInfo() stub, but you should probably know that the templateinfo fetching will be asynchronous
[18:06:57] <RoanKattouw>	So realistically, getTemplateInfo() would not both call the API /and/ return the result
[18:07:15] <RoanKattouw>	(in the same call at least)
[18:07:27] <nimish_g_>	hm?
[18:07:31] <nimish_g_>	OH I see what you mean
[18:10:06] <RoanKattouw>	That code alone is not a big deal, but if you start building a lot more code around the assumption that getTemplateInfo() will be synchronous, restructuring all that would be kinda painful
[18:11:33] <nimish_g_>	yeah, I'll structure it in a way that it doesn't block for an asynchronous call =)
[23:52:49] <adam_miller>	RoanKattouw: you around?
[23:52:54] <RoanKattouw>	Yeah
[23:53:22] <adam_miller>	i've been adding some RTL code into wikiEditor.toc.js
[23:53:45] <adam_miller>	but thinking that's a bit dirty and something that should be more configuration code
[23:54:23] <RoanKattouw>	What do you mean configuration code?
[23:55:21] <adam_miller>	just debating if lines like $j( 'body' ).is( '.rtl' ) ? true : false; shouldn't be in Toc.js, rather than jquery.wikiEditor.toc.js
[23:56:26] <RoanKattouw>	No, I don't think so
[23:56:36] <RoanKattouw>	Hmm
[23:56:39] <RoanKattouw>	Although
[23:56:47] <RoanKattouw>	Yeah maybe it should, I see your point
[23:57:00] <adam_miller>	it doesnt really harm anything to put it in there
[23:57:08] <adam_miller>	but it is specific to our markup
[23:57:20] <adam_miller>	you could argue it either way
[23:57:53] <RoanKattouw>	Yes it is MediaWiki-specific and should therefore be in Toc.js
[23:58:06] <RoanKattouw>	I agree with that
[23:58:22] <RoanKattouw>	Feel free to refactor that if you want to
[23:58:41] <RoanKattouw>	Or just be like well we've got more pressing concerns right now :P
[23:59:35] <adam_miller>	ok i think it should be something we pass into wikiEditor on the first call to the main plugin
[23:59:47] <adam_miller>	and make a RTL boolean variable accessible to the plugins