[15:12:39] adam_miller: hey adam [15:12:48] yo [15:12:55] are u working on the dialogs at the moment? [15:13:02] or can I send u the button files later? [15:14:37] i put them on hold and am working on template folding now [15:14:40] you can send them later [16:09:55] adam_miller: 1px* 100px? why 100px? [16:10:22] that's how big the gradient is [16:10:27] it's an image from jquery ui [16:10:55] i'm guessing the extra space is a buffer for vertical expansion [16:13:22] so if we have a 20px high button the gradient is scaled down? or cut? [16:33:31] sorry hannes-_- missed your last message [16:34:10] the 20px gradient would be fine, i'll just pin it to the top or the bottom and if the button was taller that 20px, the rest would be a solid color [16:44:54] adam_miller: in your first re mail to the refinements - you said "what happens to the tabledialog when a user drags it. do you mean resize? [16:45:09] yes i did mean resize [16:45:12] ok [17:04:36] is this a good place to ask about problemsm with the watchlist? [18:50:19] Why's the extension directory and all subdirectories on prototype world writable? [18:56:33] and why's it owned by www-data? does the webserver need to modify anything in there? [18:56:54] i ask, cause i'd like to fix it, but don't want to break anything [20:02:49] in the conference call now [20:02:54] (hold music) [20:04:33] I have also joined ;) [20:08:03] nimish_g: hey, are u around? [21:00:13] hannes-_-: yes [21:00:34] rather...yes? [21:03:00] RobH: Can I get a copy of the flaggedrevs configuration on labs? [21:03:18] yea, lemme snag it. [21:03:25] cool. thanks [21:04:27] http://pastebin.com/d48d20604 [21:04:39] thats just the section for labs [21:04:56] ahh, wait, i missed one. [21:05:15] yeah. It may be the same one on prototype. wanted to be sure though [21:06:06] ok http://pastebin.com/d75e1babe [21:06:11] that has both labs info [21:07:25] RobH: hmm. they look like they are for different installations... which of the two should I be using for the sandbox? [21:07:51] i imagine flaggedrevs_labswikimedia [21:07:57] ok. thanks [21:07:59] but i wanted to give you both incase. [21:17:14] going to do a global rename of "mw.addOnloadHook" to "mw.ready" ( more consistent with mwEmbed 'extending' jquery conventions ) [21:36:43] I don't think the js2stopgap should include jquery.ui [21:38:02] TrevorParscal: is it oky if I de-merge that? [21:39:34] mdale: in your branch? [21:39:46] once we have the script loader, js2stopgap will be gone [21:40:01] yea but js2 does not include jquery ui by default [21:40:19] you need to request it.. so It needs to be a separate file [21:40:37] ( which is merged latter on ) [21:40:52] do the "view" pages use all the jquery.ui stuff ? [21:42:08] this would probably be quicker for you to do. than i ... if you could just separate it out and put it ontop of your script include list? .. unless other extensions are using js2stopgap with the assumption that it provides jquery.ui ... but thats a bad assumption anyway... [21:43:02] only some of our editing stuff uses it [21:43:10] basically we are only using dialog and resizable [21:43:23] yea.. so lets move it out of js2stopgap? [21:43:29] we can just make sure those are being included in those cases [21:43:31] suren [21:43:41] cool [21:43:47] I'm just saying, why even mess with that file? [21:43:50] it's a stopgap [21:44:02] once we switch to the real thing, it will be deleted [21:44:06] cuz it breaks sandbox2 [21:44:22] ok [21:44:33] cuz I want to include your extension while using the js2 branch [21:44:33] sounds fine to me [21:44:56] the stopgap file should be replacable with the new system with no other code changes [21:45:07] if that's not the case, we should modify things so it is [21:45:08] right .. so we need to remove jquery.ui [21:45:29] but it still needs to be loadable [21:45:53] yea naturally .. just like all the other jquery plugins your including [21:46:14] the reason we combined it was for performance [21:46:29] (but all your other scripts get combined anyway no?) [21:49:10] also would be good to switch $out->addScript( ... to $out->addScriptFile( ... trunk and js2 compatible way of adding scripts.. (even though your handling grouping internally .. using addScriptFile will let the script-loader group you in with all the other extensions js, user-scripts, site scripts etc. [21:50:24] all plugins get combined [21:50:30] all loader scripts get combined [21:50:35] and js2 gets loaded [21:50:58] there's at most 4 scripts (js2, plugins, wikiEditor, vector) [21:52:25] scriptloader wise I recommend two includes: "core scripts" and "everything else" [21:52:46] (core scripts include "loaders" for user interface actions that result in more stuff getting loaded ) [21:53:02] the loaders.js from mwEmbed modules [21:53:37] everything else includes any scripts you know you will need and want to block dom display on [21:55:37] (for given context) ... like edit page... perhaps skins js should be part of "core scripts" .. switching skins is not that common .. and could let us unify the "view" page to a single script include [22:04:15] is there something special I'm supposed to do to get foreign file repo working? I'm getting "failed to open stream: Connection timed out" when it tries to pull images from commons or enwiki. [23:14:32] TrevorParscal: I moved the jquery.ui stuff out into a separate folder... we can switch to using the core version once we re-merge in the js2-work branch [23:15:53] I need to run the "minify" on it though .. (need to fix local copy of jsmin) .. if someone beats me to minified version commit thats fine.