[00:03:06] RoanKattouw: are you sure the toc code is the problem in IE7? [00:04:15] it doesn't look like highlight finishes marking up the iframe content [00:04:38] i'm only seeing one div.wikiEditor-highlight in the whole thing [00:07:23] i'm viewing it in a legit copy of ie7, not IE8 in IE7 compatibility mode [00:07:34] so maybe that's causing us to see different things [00:19:03] RoanKattouw: can you respond to my last couple messages? I need to head home in a few minutes [00:19:32] updated? [00:22:38] Oh sorry Adam [00:22:45] Ah I'm not suer [00:23:03] Lemme check real quick [00:24:13] RoanKattouw: when you have a moment, could you check the toolbars for non-english prototypes [00:24:19] Sure [00:24:23] they are not visible for ja and de [00:24:27] adam_miller: OK so for me in IE7 compat mode [00:24:31] i haven't checked other languages yet [00:24:41] The cursor jumps to the header just fine, but the "force" parameter seems not to be taken into account [00:25:09] i.e. the section doesn't jump to the top if it was already in view [00:25:18] The wikieditor div is also in there just fine [00:25:28] i'll check it in compat mode then [00:28:12] RoanKattouw: confirmed. it's doing the same thing for me in compat mode. You should probably take a look at an actual copy of ie7 to see if you encounter the same thing i was seeing [00:28:19] Ah yes [00:29:01] Trevor will check it later, I'd have to install a new VM to get IE 7 [00:29:31] i have it [00:31:41] adam_miller: On an unrelated note: http://twitpic.com/yq5bo [00:32:23] you tweeted it? [00:32:35] No, you can use twitpic without tweeting stuff [00:32:46] [ ] Check this if you do not want this photo posted to your Twitter account [00:33:45] what am i to be seeing there? [00:34:30] The arrow next to the last item [00:34:39] I'd personally expect it to be top-aligned [00:40:00] nkomura: Fixed on de now [00:40:09] thanks [00:40:34] adam_miller: Trevor says he doesn't see any difference between real IE 7 and compat mode, but that could be due to a fix he just committed. Could you svn up and try again? [00:40:34] does your fix other languages too? [00:40:39] Hopefulyl [00:43:43] i see "F" and "K" for de.wp prototype. nice :-) [00:43:47] parutron: http://prototype.wikimedia.org/de-wp/index.php?title=1834&action=edit [00:54:37] oh cool [00:54:46] does anyone have siebrand's contact info? [00:55:00] TrevorParscal & RoanKattouw - I'm still seeing the same thing in ie 7.0.5730 on my win XP vm [00:55:10] i found this: http://en.wikipedia.org/wiki/User:Siebrand [00:55:18] but an email address would be better [00:55:52] adam_miller: what are you seeign? [00:55:56] *seeing? [00:56:22] the iframe contents only contains one div [00:56:52] suggesting that highlight is bombing after it wraps the first template [00:57:46] so then the toc doesn't work because the items aren't linked to elements that actually exist [00:58:07] i'm not testing ANY template stuff at all [00:58:13] because we aren't working on that stuff [00:58:23] because we aren't deploying that stuff until later [00:58:34] we are focusing on stablixing things without templates [00:58:49] Still , that requires that wrap manages to process multiple headers [01:00:10] how do i disable all template stuff then? [01:00:29] i thought it was a user preference before, but now it looks like it's globally enabled [01:01:25] well, on my localhost i can do it with prefs [01:01:28] TrevorParscal: how do I disable the template stuff? [01:04:22] ok disabling the templates did the trick. [01:05:11] now i am heading home. i'll see you guys tomorrow [01:05:32] Cool [01:05:33] Dude you've been working late :) [01:07:31] it's not THAT late, but i am starving. need to get some dinner. [01:07:54] Yeah but it's late to get home to a wife and kids [01:08:33] I know that if I had them I wouldn't dare leave the office after 6 [01:10:52] Depends on the wife and kids I suppose, especially on how easy or hard it is to keep the kids in line by yourself [01:12:02] I just beat them with a stick [01:12:07] wife and kids alike [01:13:05] ... careful this channels logged :P [01:14:06] oh crap! [01:14:15] I mean, I love them... [01:14:21] and give them hugs and stuff [01:14:25] does that sound better? [01:15:06] Be careful teaching Cadence stuff though, she might come up with more sophisticated methods to block the front door than just standing before it [01:15:46] ha ha ha [01:16:03] cadence is totally capable of doing that [01:32:35] mdale: AMW is working in s-2! [01:33:19] did you test the upload? [01:34:08] not yet [01:35:02] fyi, if anyone ever wants to reach siebrand, i found his email: siebrand@kitano.nl [01:35:18] preview is inserting additional images [01:37:47] i take it back [01:37:55] hmm [01:38:19] i was following the link from your blog [01:38:47] my blog? [01:39:01] yeah http://techblog.wikimedia.org/2009/10/new-media-features-gadget/ [01:39:37] oky.. yea looks like there is a preview issue.. will try and push out the fix [01:41:55] shall i test upload? [01:45:56] image uploading is working nicely, mdale [01:47:04] good to hear it works for ya ;) ... I think it still a bit rough around the edges though especially cross platform i imagine [01:48:54] do you want me to get QA going? [01:50:12] i'm out guys! see you tomorrow hopefully! [01:50:24] oooh [01:50:32] but first i'm going to check out the add media wizard [01:51:59] AMW working nicely [01:52:13] preview has a bit of glitches [01:53:49] is it on prototype? [01:53:51] or a sandbox? [01:54:19] sandbox 2 [01:54:22] http://prototype.wikimedia.org/sandbox.2/Polar_bear [01:55:41] hmmm to who should i direct my comments? [01:55:44] mdale? [01:55:59] yeah, mdale and guillaume [01:56:06] sorry... got distracted by the talk [01:56:32] mdale: shall i kick-off cross browser testing? [01:57:46] nkomura: yes, I think some initial testing would be helpful [01:57:54] got it [01:57:58] i'll email calcey tonight [01:58:11] give some visibility to the areas that are broken.. might be a short test ;) [03:18:14] well, i talked to my buddy who has apple remote desktop, and he cannot get it to prompt and connect to the raskin server. [03:18:23] so something funky happened, will check it in the morning in person. [03:19:20] thank you RobH [03:19:38] ryan and trevor are offline [03:19:46] no worries, figured someone would see it =] [03:19:54] its allows me to login to it via ssh [03:19:58] but thats useless to me on os x. [03:20:05] will know more tomorrow [03:20:35] what do we do without you? [03:20:58] thank you for keeping a close eye on it [03:21:16] prolly find someone else to sit in the DC and press buttons ;] [03:21:23] im off to bed, will update you tomorrow [03:21:39] good night RobH [17:56:09] hi everyone [17:57:44] hey hannes-_- [17:58:15] if you have a second -- I'm not sure I understood what you were talking about in your e-mail [17:58:20] sure [17:58:37] oh wait, it's staff meeting time [17:58:39] well [17:58:50] could you just tell me where you experienced this? [17:59:02] on the usab wiki [17:59:12] the link u sent me was correct [17:59:45] so you tried to upload a file through the "upload file" link from the sidebar [17:59:53] ok [18:00:24] oooh ok, Michael's firefogg thingy must be enabled by default there [18:00:31] meeting time, bbl [18:40:08] hi nkomura [18:40:15] hi hannes [18:40:25] paru is not there yet, right? [18:40:41] no she is on jury duty today [18:40:50] cause I though we d meet today at 10am/7pm [18:40:55] oh [18:40:56] ok [18:41:49] we are going to have the team meeting in 20 minutes [18:42:14] i pushed out for an hour because all staff was moved from yesterday to this morning [18:44:20] yes - I read that on the mail you sent. but paru and I wanted to meet before the groupmeeting [18:44:46] but she wrote that she can say for sure because of this jury duty thing [18:44:48] i see [18:45:01] (she can't) [18:45:20] she may be in the afternoon, but i don't think she will be in the morning [18:47:52] hmm [18:48:00] i ll cancel my meeting tomorrow in that case [18:48:12] otherwise I couldn t talk to her this week [18:48:34] cause I won t be available thursday and friday [19:03:52] hi adam_miller. ru calling in? [19:04:26] yep, didn't realize the time [19:17:52] Version support map: http://pastebin.com/m5f385009 [19:22:36] howief: You might find this convenient ---^^ [19:22:47] thanks! [19:35:58] puhh... would be nice if one person speaks at a time [20:28:03] parutron: hi [20:31:20] hey hannes [20:31:23] what are you doing up? [20:32:36] hannes-_- [20:32:50] i'm back from jury duty [20:32:52] for the time being. [20:32:58] after 4:30 i call to hear my fate. [20:33:40] naoko's out, but i'll ask her for a quick recap of this morning's meeting [20:33:46] anything major on your end? [20:33:49] iframe iframe iframe [20:33:54] kind of [20:34:06] the dialogs should be refined [20:34:14] but adam could do that yet [20:34:36] so I don t now, but... they are not 100% ready by tomorrow I guess [20:34:54] but adam should have all changes from us [20:34:57] the dialogues [20:34:58] yeah [20:35:04] did you check on your updates to the search and replace. [20:35:17] the most urgent issues are done [20:35:32] cool, so it's just the refinements to the link and table dialog [20:35:49] roan said we should not disallow resizeablility [20:35:50] minor [20:36:13] (minor refinements) [20:36:15] but I asked adam to disallow it for the table dialog only. [20:36:25] yeah minor style refinements [20:36:29] cool [20:36:34] eccept the buttons maybe [20:36:43] oh right. [20:36:54] another thing [20:37:04] we ve talked about the toolbar & dialogs [20:37:24] yeah [20:37:32] i added that to the list of "must have before going default" [20:37:33] someone (I think nimish) mentioned that we should have an indication on the icons if a dialogs popsup or not [20:37:36] dialogs for the other buttons [20:37:45] I made add file today [20:37:47] see mail [20:37:50] i saw it [20:38:18] i was looking at the old toolbar data, and it looks like people use the "add file" and "add image" equally [20:38:21] maybe interchangeable? [20:38:38] am wondering if add media will take care of both add file and add image, image gallery [20:38:40] i'm not sure [20:38:42] these are different buttons?!? [20:38:45] yeah [20:38:53] on the old toolbar [20:39:06] did n see it for while [20:39:14] no worries [20:39:31] so actually I am not sure what to do next [20:39:40] anyway, i'll look into that more so hold off on doing any more on that front. [20:39:43] give me work! ;) [20:39:55] sure [20:40:00] but we do need more dialogs for the buttons, though their functionality will be stripped [20:40:02] i.e. references [20:40:21] image gallery (if not part of AMW) [20:40:26] but we already have mockups for the insert references dialog. don t we? [20:40:26] AMW = add media wizard [20:40:43] we do, and hopefully we'll get to making it that developed [20:40:57] in the meantime, we need a bare bones dialog that only does what the button does now [20:41:02] does that make sense? [20:41:03] I thionk our developers are pretty busy [20:41:07] it's giving it a dialog only to have a dialog [20:41:08] they are [20:41:12] I feel like they are running out of time [20:41:19] this won't be developed/released until later [20:41:31] they have everything they need from us for the upcoming release [20:41:34] bare bones dialog? [20:41:39] so my sights are on the next releases [20:41:44] for which there is still much to do! [20:41:55] like just a dialog saying "You succesfully insertet a bold text" [20:41:57] yes. it'll hardly involved any design work [20:42:02] not for bold and italics [20:42:06] just for things that get inserts [20:42:08] reference [20:42:11] image gallery [20:42:15] k [20:42:24] i'll have to look back on the videos again for others. [20:42:32] file (if it's not part of add media wizard) [20:42:49] the reason we're doing this is we have to get the toolbar in a state where it'll be acceptable for wide release [20:43:02] so even though they're not the kind of dialogs we'd like to eventually have, the keep the experience consistent [20:43:17] another toolbar item, to give you more work, are the new icons [20:43:39] let me take a look at my numers again. one of the two we were discussing (nowiki, redirect) was a must include [20:45:43] nowiki [20:46:05] so what did u think about my first tries? [20:46:27] I sent u some mockups for the nowiki icon on the 6th of jan [20:46:58] nowiki icons is really a tough one [20:52:42] paru? [20:53:50] sorry [20:53:52] here [20:54:53] so anything else? [20:55:12] yes. [20:55:13] what about template folding? [20:55:19] i've emailed siebrand in the netherlands [20:55:27] to get his suggestions on the default text formatting icons [20:55:43] whether, for the languages that don't have their own icons, it should be B/I or A/A [20:56:17] i think we're leaning for B/I but would be better to get an opinion of someone that was more in touch with the cross-language aspects [20:56:30] http://www.siebrand.nl/ ? [20:56:45] we also need to investigate what implications using our left navigation interaction would have across different language wikipedias as well as other projects [20:57:12] hmm I can do that [20:57:15] http://en.wikipedia.org/wiki/User:Siebrand [20:57:18] that would be great. [20:58:06] as for templates, we can continue with forms, but i'm not sure how much we can do there for now. [20:58:38] hopefully nimish + adam will be able to continue on the sandbox with the capsule stuff we sent [20:59:05] hmm I guess that ll take some more time, huh? [20:59:09] looks like it [20:59:27] so feel free to asign work so me if something comes to your mind [20:59:29] i'm not sure how productive it'll be for us to push further without looking and playing with that and getting some feedback [20:59:36] I have some capabilities [20:59:52] true [21:00:08] one other thing that is in addition to everything we've been working on: [21:00:36] we've all discussed how to allow for users/admins to add extra icons/features to their toolbar [21:00:46] i want to come up with a suggestion or two for how we do this [21:01:21] i'll get in touch with trevor and roan on their suggestions/what's possible [21:01:28] extra icons = other icons than bold/italic? [21:01:29] my initial thinking is that we have tool bar bundles [21:01:39] so we have a "math bundle" [21:01:58] a "character formatting bundle" that include superscript, subscript, small, and large [21:02:12] that sounds good to me [21:02:16] but if you have any thoughts on the matter, let me know [21:02:27] lors of icons [21:02:31] lots of icons [21:02:37] that s what I think ;) [21:02:43] i think in terms of strict design, we just really need to be keeping tabs on everything we've started [21:03:00] - tabs and colors, etc will move to prototype after the release [21:03:26] - we need to finish up the "below the edit box stuff" - including publish and cancel buttons (will respond to your email with the latest mock) [21:03:48] - left navigation investigations (and refinements where needed) [21:03:53] ok [21:03:58] - toc, search [21:04:09] and of course the dialogs, but those are for the upcoming release [21:04:10] toc is done, no? [21:04:53] adam put lots of work on that last week and I think its good to go [21:05:09] and all of the info has been given to adam on the dialogs, so that's just a matter of checking on them after he's had time to make the updates [21:05:38] cool - yeah i heard he was fighting [21:05:47] ok - so i guess I ll have enough to do tomorrow [21:05:55] i kept that on my list because i wanted to revisit the styling [21:06:01] is it clear what the article title is? [21:06:06] what section is selected? [21:06:06] etc [21:06:19] let me know if your juryduty allows you to come in tomorrow morning [21:06:23] i will [21:06:38] also - we shouldn't entirely wait on the dev boys to continue with forms [21:06:45] so if there isn t anything urgent I d like to go offline [21:07:06] nothing really urgent. [21:07:15] ok cool [21:07:21] so talk to u tomorrow [21:07:32] will email you with my jury duty update. [21:07:45] talk to you later and let me know what you find re:left navigation! [21:07:50] ACK [21:07:52] hannes-_-: [21:07:54] one more thing [21:07:57] bye [21:08:00] oh no [21:08:07] got u [21:08:08] wait wanted to share one more development with you [21:08:10] oh cool [21:08:12] till here [21:08:16] still here [21:08:23] remember way back when we thought "donate" should be more prominent? [21:08:28] and explored ways to do that. [21:08:36] sure [21:08:40] depending on how it gets release, i think we should rope that back in [21:08:47] i'll see if i can track down our old mocks [21:08:58] cool [21:09:03] but with collapsing section, i think something like the german one we looked at would be great [21:09:13] I can do a mockup of that in the new style [21:09:17] sweet. [21:09:27] i'll send over any related files, sketches, ideas [21:09:33] fine [21:09:55] goodnight! [21:10:30] bye [21:54:51] guillom: what's your schedule like tomorrow afternoon? [21:55:08] i'm meeting with paul from goto media, a local user research contract company [21:55:22] (i mentioned this in our flurry of emails last friday) [21:57:57] parutron, let me check [21:59:23] parutron, I don't have anything planned yet [21:59:29] gottago to a meeting now [21:59:35] cool [22:00:09] i'll send you over a little more information, but i think if you are still interested in conducting more formal studies, it'll be great if you can join us [22:00:18] especially if we're gonna try and synch [22:00:23] i'll let you know [22:07:16] TrevorParscal: I'm having another problem with the order in which event handlers are called - didn't you help me fix something similar before? [22:07:35] maybe... [22:07:41] what's the current calling order? [22:08:25] on the resize handler, the toolbars function get's called after the TOC's [22:08:26] TrevorParscal: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61272 [22:08:49] RoanKattouw: scariest diff ever, right? [22:10:04] Still looking at it [22:10:07] TrevorParscal: so when the TOC expands or collapses, and the toolbar size is changed because of the collapse/expand, the heights become uneven between the TOC and the text area [22:10:11] adam_miller: what you can do is trigger a new event, called by the toolbar's resize event [22:10:15] Was passing it to Trevor because there's some CSS3 stuff going on there that might or might not be OK [22:10:28] so it goes resize -> core -> toolbar -> newEvent -> core -> toc [22:10:48] or vice versa [22:11:42] hmm that might work. i'd call the toolbar's handler from the TOC since it's smaller than the TOC's [22:11:52] basically, you can trigger events through context.fn.trigger() like "tocCollapse" and there can be a handler for those on a module like $.wikiEditor.modules.toc.evt.tocCollapse [22:12:12] and please name the events in a way that they are obvious in origin [22:12:38] so, if it's triggered because the toolbar is expanded or collapsed, you could make the event toolbarExpand or toolbarCollapse [22:15:56] TrevorParscal: I just want to trigger the resize handler in jquery.wikiEditor.toolbar.js? [22:16:40] context.modules.toolbar.$toolbar.trigger("resize")? [22:23:11] what is the cause of this event? [22:23:17] the collase or expand of the TOC? [22:23:22] *collapse [22:24:56] TrevorParscal: correct, collapse/expand of the TOC [22:26:32] context.fn.trigger( 'tocCollapse' ); and context.fn.trigger( 'tocExpand' ); [22:26:37] then in the toolbar [22:26:54] you add event handlers for those events [22:27:07] that way, if some other module is interested in that event, they too can act upon it [22:27:20] just trigger the events in the TOC code [22:27:34] they will get passed through the core and propagate to all interested modules [22:28:46] so it's not a problem that in the toolbar code, i'll just be copy+pasting the resize event and renaming it to tocCollapse and tocExpand? [22:30:52] no need to do that [22:31:32] just make the contents of the tocCollapse and tocExpand just pass the context and event to the other function [22:31:37] a redirect basically [22:32:04] gotcha [22:34:04] committed. [22:47:31] adam_miller: are you planning on letting the TOC restore itself to the user-desired width when the browser is sized back up? [22:48:16] also, I suggest adding a 5 px buffer so you don't end up with rendering glitches of wrapping being corrected too late [22:48:25] but seriously, this is awesome! [22:48:26] TrevorParscal: possibly, but not by tomorrow. i've been sitting on these changes for three days though, so i needed to commit the base once i got it put together [23:08:55] TrevorParscal: That webkit bug you mentioned on our call, where highlight doesn't fully run until you click into the iframe ??? any idea when that will be fixed? [23:09:17] i'm going to look at it as soon as I fix this scrollToTop stuff [23:09:21] in IE7 [23:10:15] ha, that's what i'm working on right now [23:10:40] i'll let you take it though ?????i've got some stuff other things that need done yet for tomorrow [23:10:40] oh [23:10:53] unless you need help with that [23:10:55] why do we check the outer frame's scroll positions being > 0 ? [23:11:19] I could use help, yes [23:11:21] because it was screwing with the elements position if the main window wasn't at the top [23:12:02] this function doesn't quite make sense to me yet [23:13:39] things i know - the main windows scroll position seems to affect the value $element.offset().top returns [23:13:50] i think we should try using something like this -> http://www.kryogenix.org/code/browser/smoothscroll/#top [23:14:08] and html.scrollTop( y ) works for firefox, but body.scrollTop( y) works for safari [23:14:51] maybe a more jquery-ified version [23:14:53] looking around [23:14:54] Doesn't jQuery support this is a nice and smooth, crossbrowser, way ? [23:15:28] oh, I okay TrevorParscal [23:15:47] http://snipplr.com/view/12510/smooth-scrolling-with-jquery-and-internal-page-links/ this is interesting [23:16:48] you make the toc links actual links with a target of the iframe [23:17:02] or..hmm [23:17:06] no.. this overrieds that [23:17:11] *overrides [23:26:01] TrevorParscal: i think i have something consistently working in safari and firefox [23:26:22] i have something very simple working in IE [23:26:45] let me try mine in IE before i proclaim victory [23:29:15] http://demos.flesler.com/jquery/scrollTo/ [23:30:02]