? [00:11:58] If that's it, it'd presumably be fixed with

tagging [00:12:04] true [00:13:02] but even after you move the selection again, it won't let you select text until you click on the toc again... [00:13:09] it definately seems linked tot he TOC [00:13:21] but the nubmer of clicks to get it to come back doesn't seem consistent [00:13:34] Interesting [00:13:49] hmm [00:14:05] it actually seems like it depends on which item you click in the TOC [00:14:15] anything after the 3rd heading breaks it [00:14:25] while 1-3 fixes it [00:14:59] strangely, that is very consistent [00:16:29] ok, has nothing to do with how far down it is [00:16:35] seems to be the level [00:16:45] adam_miller: Ha I like the concept of code being "honest" [00:16:46] so, the 2nd top level heading in the TOC and below breaks it [00:17:24] hmm [00:17:41] well, it's less consistent than that.. but it's still connected... thoughts? [00:17:58] can anyone else reproduce this? [00:18:09] RoanKattouw: commit messages could always stand to be a bit more poetic [00:19:38] poetry; bah, it's like consensus: who needs it anyway? [00:22:40] adam_miller: :) I'm sorry I'm so anal about small things in code review sometimes [00:24:03] Why? I love it. Keeps me on my toes. [00:24:22] TrevorParscal: No idea, let's retry tomorrow with the

tagging thing. I should go to sleep now, driving test in 12.5 hours [00:25:25] RoanKattouw: good luck! [00:25:29] adam_miller: Glad to hear that :) feel free to treat my code with the same rigor if you come across stuff that looks quirky [00:25:32] RoanKattouw: where can i find a page with a "save draft" button? re: https://bugzilla.wikimedia.org/show_bug.cgi?id=19688 [00:25:36] *RoanKattouw hopes it won't be canceled a 4th time [00:25:36] remember, don't press the gas and the brake at the same time [00:25:56] unless you are trying to burn out, in which case, do exactly that [00:26:00] TrevorParscal: I'm driving a stick, I have greater worries ;) [00:26:12] adam_miller: Drafts extension, Trevor can tell you more [00:26:13] ha ha ha [00:26:15] did someone create an enhancement request in bugzilla for loading spinner? [00:26:21] Nope [00:26:23] RoanKattouw: what car will you be using? [00:26:40] My instructor's BMW [00:27:39] BMW 318D, diesel, 143 HP, 6 gear manual [00:28:00] Very young too, he bought it (new) about 9 months ago [00:29:57] Off to bed now, thanks for wishing me luck :) [18:23:42] RoanKattouw_away: you around? [18:26:59] I am now [18:27:03] *RoanKattouw passed his driving test :) [18:31:12] hoooray! [18:32:07] so, what car will you be driving regularly? [18:32:16] the BMW? [18:32:37] the Rolls? [18:32:38] Nope, that's my instructor's car [18:33:09] My mother's Kia Rio, presumably [18:33:26] (less fancy; it's from 1999 I think, 5-gear manual, runs on gas) [18:33:32] *RoanKattouw prefers diesels [18:33:48] *TrevorParscal prefers BMWs [18:33:53] you don't consider diesel to be gas? [18:34:25] Gasoline is not Diesel, but both are technically Petrol [18:34:33] TrevorParscal: you've got a BMW minivan right? [18:34:38] Honda [18:34:58] TWAS a joke [18:35:13] But that's an automatic, at which point I don't care if it's gas or diesel, it probably scares me anyway [18:35:15] 2003 Honda Odyssey -> http://terravali.com/testimonials/03odyT.jpg [18:35:24] ha ha [18:35:33] *TrevorParscal misses internet humor [18:35:57] adam also told me it was sunny and warm back in Pittsburgh and I believed him... [18:36:03] ha [18:36:07] *TrevorParscal is apparently gullible [18:36:11] TrevorParscal misses in-person humor [18:36:12] or dense [18:36:15] ha ha [18:36:21] http://www.odyclub.com/ [18:36:36] you hang out on that site TrevorParscal? [18:36:46] dude, custom rims -> http://www.odyclub.com/images/members/bmorison/Bobs00018.jpg [18:36:49] no, can't say I do [18:36:51] ha ha [18:37:20] Do you refer to it as The Ody? [18:37:34] no, but I'm the only person I know who has one [18:37:39] strangely [18:37:43] I see them all over the place [18:38:13] and not just because I'm driving one [18:38:22] allthough, that does always tend to raise my awareness [18:39:02] Yeah I started seeing those BMWs all over the place a few weeks after I started driving one [18:41:46] RoanKattouw: I made real compat maps for TOC and Dialogs now [18:41:53] Yeah saw them [18:42:29] I like resolving bugs by saying "we've blacklisted this browser, so it's virtually fixed" [18:42:32] nimish_g: I'm about to poke at wikiEditor.highlight.js and wikiEditor.toc.js, are those files clean on your end? [18:42:56] they are...I actually haven't had a chance to poke around at them much yet [18:43:14] can we get these critical bugs resolved? [18:43:48] Which ones? [18:44:11] I was gonna do the

-class-instead-of-anchor thing, but I'm happy to fix more critical things if you want me to? [18:44:37] RoanKattouw: no, work on that [18:44:43] I think it's going to solve lots of other things [18:44:51] OK [18:55:07] hannes-_-: grabbing my skype headset and heading to a quiet room [19:00:04] hannes-_-: call me when you're ready [19:17:41] RoanKattouw: big commit, mostly just adds compatiblity tables to modules [19:17:53] OK, I'm prepping a commit myself [19:17:59] but also rearanges the wikiEditor.js file so that the nasty hack isn't so nasty [19:18:20] there's a new (very basic) requirements system [19:18:37] i have ideas of how to enhance it if we need to [19:19:17] but for now, the core just turns on required things when needed [19:20:24] Hm so wikiEditor itself is fine with 2.0.0.3 & friends? What were the issues with those versions anyway? [19:21:11] yes [19:21:13] tested [19:21:23] TrevorParscal: + if ( $.wikiEditor.modules[module]['req'][req] == 'iframe' ) { [19:21:34] That's not very generic, you can easily make that prettier [19:22:07] um [19:22:08] oops [19:22:34] bad copy paste [19:22:37] fixing [19:24:23] ok [19:24:24] that one [19:24:37] hmm. should have referenced the previous revision in the commit comment [19:25:35] reqirement [19:25:36] Really? [19:26:47] TrevorParscal: How do you manage to misspell a parameter name in the function signature *and* in the body in the same way? [19:27:06] copy paste? [19:27:09] ha ha ha [19:27:20] *TrevorParscal has shameful visial spelling habbits [19:27:23] *visual [19:27:24] ha ha [19:31:50] RoanKattouw: ficksed [19:32:48] TrevorParscal: OK I committed the

tagging thing, please test the bugs that it's supposed to fix again [19:37:33] Anyone with IE around that can confirm that https://bugzilla.wikimedia.org/show_bug.cgi?id=22566 really is specific to SInhala and doesn't happen on the English prototype? [19:37:56] (I'd fire up my VM but it slows down my laptop so much when I'm running Firefox and Chatzilla as well) [19:39:00] checking both... [21:30:55] RoanKattouw: hi [21:31:02] was at horrible lunch experience [21:32:39] What happened? [21:37:07] really bad service [21:37:11] food was like 1 hour late [21:37:16] it was actually quite expensive [21:37:27] and the food was just so-so [21:37:37] Was this a Thai place by any chance? [21:37:49] *RoanKattouw remembers hearing about slow Thai one time [21:37:59] Some vietnamese place we'd never been to on mission and 4th [21:38:17] i waited about 45 minutes for a noodle soup [21:38:19] There's a Vietnamese place there? On which corner? [21:39:41] I know that particular intersection pretty well as the Mosser is on that block and I think I still remember what's on 3 of the 4 corners, but I don't remember seeing a Vietnamese restaurant (maybe I just filtered it, too many Asian places in SF to remember) [21:40:24] Ah I see it now [21:40:52] it's more, mid-block [21:40:56] between 4th and 5th [21:41:12] Yeah Priyanka dropped the name in the other channel and I gmapped it [21:45:00] There's also a deli on that block in the other side, I believe it was Denny's, and I walked in there looking for breakfast on a Sunday I think, around like 10, and I walked in and asked for a sandwich and the guy at the counter said they were closed [21:45:19] So I walked out thinking like "wtf, you guys don't want my money? There's prepped sandwiches on display right there" [21:46:35] what a bunch of bastards! [21:48:14] Well it was only one guy [21:48:38] But considering Americans will happily eat dinner for lunch, I figured a sandwich place has to be open at breakfast time to stand a chance [21:48:39] https://bugzilla.wikimedia.org/show_bug.cgi?id=22358 [21:49:02] where does this stand? [21:49:27] It stands at where my last comment says it stands [21:49:36] It should be fixed [21:49:40] Needs to be confirmed [21:50:06] I will try and confirm it then [21:52:43] i'm getting errors in IE now [21:52:52] on line 1398 of wikiEditor.js [21:53:59] What's the error message? [21:54:07] Invalid argument [21:54:19] are you getting this? [21:54:21] Helpful as always *sigh* [21:54:28] (if you have windows open) [21:54:33] *RoanKattouw is not running his VM and should really be asleep [21:54:42] oh [21:54:46] yes, go to bed man! [21:54:47] What's preRange.text.length? 0? [21:54:48] please! [21:56:30] preRange.text is the entire text of the article [21:56:50] htmlText is the entire HTML of the article [22:01:15] RoanKattouw: TrevorParscal The good news is the cursor no longer jumps (yay!) [22:01:51] :) [22:01:55] and the bad news? [22:02:07] Paste a TOC line to another TOC line [22:02:29] it does some funky jumpy things [22:02:43] or concatinates them, or adds spaces...a few things depending on where it goes [22:02:51] but that's the only old problem I still see [22:03:00] WTF [22:03:06] I mean...that's the only problem with the TOC and text position I see [22:03:19] anymore [22:03:27] Ha, the paste restore thing is broken [22:03:31] It prepends 'foo' to { [22:03:36] {foo|bar=baz}} [22:03:54] AKA doesn't honor wikiEditor-noinclude, it seems [22:04:14] we can strip that out on paste [22:04:32] Well the thing is I'm not copypasting a template wrapper [22:04:42] I'm copypasting stuff in an article that happens to also contain a template wrapper elsewehre [22:04:45] And it does this [22:05:15] eww [22:07:42] *RoanKattouw is off to bed now