[14:44:03] Ryan_Lane: Around? [14:46:56] Ryan_Lane: I'm gonna be tweaking your sidebar extension a bit here and there to make it prettier [16:01:09] Ryan_Lane: OK I'm mostly done tweaking now, ended up changing it pretty heavily and didn't test my changes (sorry) [16:01:18] s/mostly/completely [16:07:35] Ryan_Lane: Left two TODOs for you in my reply to http://www.mediawiki.org/wiki/Special:Code/MediaWiki/62947#c6013 [17:05:30] hello folks [17:05:47] how are you feeling adam_miller? [17:06:09] nkomura: better, probably about 75% HEALTHY today [17:06:34] glad to hear you started feeling better [17:08:00] adam_miller: we discussed and decided on the change of actions for the release, so please review the meeting notes i sent out yesterday [17:08:55] saw them, i was also on the call being quiet yesterday until hannes and roan jumped off [17:09:36] oh we didn't hear you calling in, so we assumed you were still down [17:09:48] sorry about that [17:10:05] I heard him bleep in I think [17:10:14] Morning all [17:12:05] hi RoanKattouw [17:23:56] MC8: Did you know that we have a prototype of AJAX preview already? http://prototype.wikimedia.org/sandbox.3/ [17:27:54] *MC8 didn't [17:30:27] (I saw you say something about AJAX preview in the logs) [17:35:20] RoanKattouw: how do I use $.wikiEditor.autoMsg? [17:36:14] i've got the label, want the proper string back [17:36:18] Say you call $.wikiEditor.autoMsg( object, 'label' ) [17:36:37] whats my object though? [17:37:12] i'm attempting to get the default text a numbered list button is inserting to compare to the current selection [17:37:13] Then it'll use object.label if available or mw.usability.getMsg( object.labelMsg ) otherwise [17:37:53] Toolbar.js lines 258-260 [17:38:09] pre: "# ", [17:38:11] periMsg: 'wikieditor-toolbar-tool-olist-example', [17:38:12] post: "", [17:38:47] So what it does is it takes the config object and calls autoMsg( configthingy.action.options, 'pre' ) [17:38:54] (or 'peri' or 'post') [17:39:21] ah, seems like overkill [17:39:28] This happens in jquery.wikiEditor.toolbar.js line 243 and down, in a duplication of autoMsg() [17:39:32] i'm sure that's useful for other things though [17:39:33] That code should be shortened [17:39:39] Well what it's useful for is periMsg [17:39:51] autoMsg( object, 'peri' ) returns a translated version of periMsg [17:40:48] oh yeah, got it working now. Thanks [17:42:03] adam_miller: Are you touching jquery.wikiEditor.toolbar.js lines 242-250? If not, I'll quickly remove the code duplication there and convert it to using autoMsg() [17:42:22] no i'm working in jquery.wikiEditor.js [17:42:27] OK [17:42:41] and apparently i could have just done options.peri and been done with the whole thing :) [17:42:56] thanks for the autoMsg tutorial anyway [17:43:22] Not necessarily, it may use periMsg instead [17:43:24] Sure [17:46:21] TrevorParscal: Good morning. This afternoon (my time) I decoupled browser checks and iframe req for the dialogs (didn't loosen any restrictions yet, see commit) and polished Ryan's DynamicSidebar extension. I have to go now and will be back just before noon [17:47:05] awesome [17:47:12] I will take a look at your commits [18:02:43] adam_miller_away: how away are you? [18:03:19] like thinking, hey I need to feed myself before it gets too late, so i should stand up and walk to the kitchen soon [18:03:32] that kind of away. do you need something? [18:05:38] well i'm going to make lunch, i'm only ten feet away so just act like i'm here and i'll reply slightly more delayed than normal [18:06:05] We're going to try and have a meeting sometime before lunch [18:06:25] Nimish is going to have laser eye surgery today [18:06:41] so we wanted to sort of go over the template stuff before he goes blind [18:10:04] ok, time? [18:10:11] is that all we're covering? [18:13:47] lets shoot for 11am [18:14:09] PST [18:14:57] aka - Center of the Universe Time [18:18:34] no way, sun rises from the east [18:19:16] but as every cowboy movie teaches us, it sets in California [18:20:50] :) [19:01:48] RoanKattouw_away: poke [19:01:57] adam_miller: poke [19:02:06] nimish_g: poke [19:02:22] TrevorParscal: poke [19:02:37] guys, you're leaving the graph incomplete... [19:03:46] i'm going to abstain from any poking [19:09:56] adam_miller: not sure if my message went through [19:10:10] nkomura: email? [19:10:14] ey [19:10:15] hey [19:11:31] adam_miller: side bar [19:21:09] anyone seen hannes? [19:21:15] hannes-_-: [19:23:08] parutron: [19:48:28] hey adam_miller that's fun - you made the capsules on s3 scaleable? ;) [19:49:25] RoanKattouw_away: I made some notes in CodeReview about the DynamicSidebar extension. I can't commit from here, so I'll have to make any fixes from home. [19:49:31] .back [19:49:36] hannes-_-: Which capsules? [19:49:39] RoanKattouw: array_search isn't working though. [19:49:45] Blegh [19:49:55] That code was as untested as it was elegant [19:50:03] :) [19:50:10] I like the changes, for sure [19:50:45] It allows for way more things to be cached. That's actually how I wanted to do it to begin with, but was trying to avoid so many core changes [19:51:03] and I'm also on a much older mediawiki version ;) [19:51:16] Ah right [19:51:24] I tweaked MW core specifically for this [19:51:40] Because the addToSidebar() function was being retarded and insisting on being passed a message key [19:51:47] Which is why I created addToSidebarPlain() [19:51:51] yeah. the changes were easy enough to backport for my install thankfully [19:52:42] Why not just add a parallel install of trunk? You're gonna need that anyway if you intend on doing more dev work [19:52:58] This was for a project at work [19:53:12] I'm using trunk at home [19:53:41] Ah [20:22:32] RoanKattouw: [20:22:40] we are doing the template form stuff [20:22:44] OK [20:24:35] nimish_g_: is going to send you an email outlining some things he wants help on while recovering [20:25:08] i gotta grab some food [20:25:13] OK [20:25:13] what's your avail? [20:25:16] Enjoy lunch [20:25:17] today [20:25:20] cool :) [20:25:27] I'll be taking a shower now to coincide with your lunch [20:25:35] And I'll be around till 2:30-3ish [21:30:17] TrevorParscal: I've got a guy from IE9 team wants to give me a preview of their ongoing work on supporting web standards etc. You guys want in on this action? Provisionally scheduled for march 5 [21:31:45] brion: March 5 is all-staff [21:32:10] blast [21:32:16] what's a better day for yall? [21:36:31] I need it! [21:36:40] please get me all up in there [21:36:44] :D [21:37:12] will they be checking for weapons on the way in? [21:37:13] cc'ing you and naoko on a reply, feel free to suggest another date [21:37:16] haha [21:37:21] thank you!@ [21:37:28] :) [21:37:39] TrevorParscal: stole my joke :P [21:37:52] *brion is keeping fingers crossed for native canvas and svg [21:38:00] and video tag support :) [21:38:03] and rounded corners [21:38:14] And no more whitespace collapsing [21:38:18] hehe [21:38:22] And W3C Range support, and... and... [21:38:42] well hopefully this is our chance to beg for specific features ;) [21:40:15] TrevorParscal: Read that one wiki page before you go there ;) [21:40:44] brion: thank you for the invite! [21:41:08] we'll do our best not to complain too much about IE6 and 7 :D [21:42:19] not much to be done about them at this point i guess ;) [21:42:36] no ... [21:42:44] *guillom falls from his chair reading "IE" and "supporting web standards" in the same sentence [21:44:46] hey they've been getting better :) [21:44:57] heck ie5/mac had the best css support of its browser generation [21:45:01] which is.... VERY scary [21:45:06] considering how godawful it was [22:02:22] brion-lunch: you're showing your age with all that IE5/mac stuff [22:02:28] :) [22:21:50] I truly hate PHP sometimes... [22:22:37] :P [22:23:36] *MC8 hits his userpage [22:24:45] array_splice doesn't preserve keys. Is there any way for me to replace an entry in an array without changing the location within the array? [22:25:42] The problem is you're potentially replacing it with multiple entires [22:25:54] yeah. true [22:26:00] And yeah you need to preserve keys /and/ order [22:26:26] this is one of the reasons I was just appending the text before. didn't have to mess around with the arrays [22:26:37] You could of course just iterate over the array copy stuff to a new array one key at a time, putting in stuff where needed [22:26:50] (if you do this, be smart and iterate over it just once, not three times) [22:27:02] heh [22:27:28] lemme try that really quick [22:45:26] RoanKattouw: that works much better. [22:47:24] :) [22:47:39] Disclaimer: I didn't invent this array approach, it was changed in core some time between 1.14 and today [22:48:12] heh. it isn't really a problem. just slightly a PITA to work with [22:48:16] Yeah [22:52:26] I need to get my svn access working from here. It's annoying not being able to commit from work. [23:05:56] In the "Insert link" dialog can't we have auto-detection of local URLs? [23:10:20] We do, in a slightly awkward way [23:10:31] It only kicks in when you click insert [23:11:20] why not just do it automatically? [23:12:27] We haven't really been over this in detail (yet) [23:12:53] I'll send an e-mail to Parul tomorrow asking what she thinks is the best way to deal with this [23:13:18] Pasting a URL and seeing it change into something else right under your nose can confuse people [23:15:43] Its simple isn't it, start the dialog on "to a wiki page", before checking if the page exists/is external attempt conversion. If the user selects "to an external..." convert to an external link. [23:18:08] Meaning the textbox would still show a URL? [23:19:42] I guess the simple way to describe it is their's a third radio button "Automatic" which converts on the fly between the two forms [23:20:04] I was thinking of it more as hidden state [23:20:19] Blegh [23:20:43] Ah well, I'll e-mail Parul with some alternatives as well as asking for her own ideas [23:21:17] She's our user interaction person and she's a designer, a non-technical person, so probably better at determining what's the least confusing on the latter basis alone