[17:25:30] Ryan_Lane_: I hear you and Trevor had some ideas about the directory structure for Selenium tests in our SVN repo? [18:09:21] RoanKattouw_away: We discussed how things may interact with CodeReview. Not sure if we talked about the structure in SVN. [19:50:37] Ryan_Lane: OK so is there any sane dir structure you recommend, or are the tests just flat files you can just throw in one directory? [19:58:58] hey nimish_g [20:00:43] so it is a fact that we cannot affect highlighting in the editor? [20:02:42] ? [20:02:53] What do you mean by "highlighting in the editor" exactly? [20:10:40] RoanKattouw: if you select text it gets higlightet [20:10:47] I think it is a browser thing [20:10:57] cause it looks different on pc and mac [20:11:05] Then it probably is a browser thing, yes [20:11:16] Don't you /expect/ selected text to be highlighted? Isn't that what selected text looks likle? [20:11:57] not thats fine - but we want to affect it when a template or capsule gets highlighted [20:12:40] anyway...if it is not possible we should leave this and spend our time on something else ;) [21:29:43] Whoo hoo [21:29:59] nimish_g: I'm about to commit some code that finally makes multiline templates really work [21:30:22] There were all kinds of problems with the newlines being eaten, stuff breaking for multiline templates starting in the middle of a line, etc. [22:03:24] RoanKattouw: you around? [22:03:43] Yes [22:04:41] can you explain your comments more on my change to the atEnd detection stuff [22:05:31] RoanKattouw: if I exclusively use startConatainer and startOffset I miss cases where the selection is not collapsed [22:05:48] Ah [22:06:05] So we do care about the end of the selection as well as the beginning then [22:06:25] i feel like we should [22:06:34] I guess it makes sense to check start-of-line for the start and end-of-line for the end; or whatever turns out to work [22:07:17] I don't feel like thinking super hard about this at 11pm, so if you tell me it works I believe you :) [22:09:22] ha, understandable [22:09:40] If the code you committed is good after all I'll just change the rev from fixme to ok [22:09:47] it works well for all the cases i'm testing, but I also don't feel super confident that I'm thinking of all of the cases possible [22:10:40] i'd say the code i committed is good. if the selection is collapsed, like you said, then the end values will be the same as the start values [22:11:00] if it's not, then we're looking at the tail end of the selection anyway and can tell if it ends at the end of the line [22:17:19] RoanKattouw: I'll make a comment on the code review page to this affect, and you can take another look in the morning with fresh eyes and see if it looks alright [22:18:26] OK