[10:48:00] RoanKattouw: why are all these bugs being reported against r63174? [10:48:18] Because the version number on prototype is inaccurate [10:48:43] so they are actually testing against code we wrote yesterday? [10:49:04] Yeah [11:35:05] adam_miller: Actually the reason I thought it was old was the message text, which we stopped parameterizing with the row/col numbers months ago [11:35:16] In fact, I think we did that in response to the October study [11:36:01] RoanKattouw: did you see my comment? the icons are old in that screenshot as well [11:36:17] Yes [11:36:31] I was responding to your comment, pointing out how we look at different things [11:36:42] You being a programmer/designer and me being a programmer/mathematician :) [11:38:19] ha yeah i totally didn't notice that difference [11:39:02] i was on my way to being a mathematician at one point [11:39:28] then i decided typography sounded cooler than diff eq [12:12:30] heh [12:34:01] good morning people [12:34:15] Morning [12:34:32] good morning [12:34:55] RoanKattouw: how do the encapsulated toolbar buttons work when the iframe is disabled? [12:35:12] they use the generic textSelection plugin [12:35:30] which defers to the iframe implimentation automatically if the iframe is setup [12:35:42] it's too early for me to care about spelling [12:35:44] it's not selecting things correctly in IE7 after insertion [12:36:01] do we care? should i file a bug? [12:36:07] Whatever's going wrong is probably in jquery.textSelection.js [12:36:09] can you verify it's a textarea not an iframe? [12:36:15] verified [12:36:17] And I think there's a bug about it already [12:36:31] letting it go [12:37:04] TrevorParscal: I just added this user JS http://en.wikipedia.org/wiki/User:Usability_8/vector.js for all usability study accounts [12:37:34] On second thought it might've been better if I had just used importScript() there so it's easier to tweak, but whatever [12:37:52] I also turned on the hidden prefs (for which the code isn't even live yet) for these users [12:39:09] awesome [12:39:28] so, what's the plan with the changes tab? [12:39:33] just comment it out or something? [12:39:56] configure it out? [12:40:10] We can do either [12:41:56] Getting an error on line 74 of wikiEditor.publish [12:42:06] reference to undefined property "newcopywarnHTML" [12:42:36] the right align of labels in the form... not liking it [12:43:01] in that mockup [12:43:37] adam_miller: Fixing [12:46:21] adam_miller: catrope * r63864 /trunk/extensions/UsabilityInitiative/ (4 files in 3 dirs): UsabilityInitiative: Fix undefined variable in r63825, consistent casing [12:46:46] RoanKattouw: thanks! [12:47:33] WTH, no commits to SVN at all in three hours, then two in the same minute [12:47:44] And I mean the entire repo, not just /trunk or /extensions/UsabilityInitiative [12:50:37] ha [12:50:45] people are snacking [12:51:15] We're scattered across timezones, there should be a constant stream of commits :D [12:51:40] Although in practice most committers are in PST, EST, GMT, CET or AET [12:52:03] the people writing code in the middle of the pacific ocean are on vacation? [12:52:07] :) [13:07:37] Blehh [13:07:45] I'm filling out my provisional tax return for 2010 [13:08:13] EUR 6,231 :( [13:08:29] OK - so bugs https://bugzilla.wikimedia.org/show_bug.cgi?id=22347 https://bugzilla.wikimedia.org/show_bug.cgi?id=22858 https://bugzilla.wikimedia.org/show_bug.cgi?id=22859 seem relevant to this release [13:08:35] any thoughts? [13:09:58] IE7, IE6 and IE7/8 respectively [13:11:38] so, the old toolbar in IE6 seems most important [13:12:00] Yes [13:12:03] That's a breaking bug [13:12:05] *RoanKattouw grabs dinner [13:12:05] right [13:12:12] *TrevorParscal works on that bug [13:13:52] parutron: are we still running the screener? [13:14:01] nope [13:14:20] happy st. patricks day! [13:38:00] i wish bugzilla had a remove comment button - "like, oh crap I didn't mean to do that!" [13:38:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=22347#c9 [13:38:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=22858 is solved now [13:41:44] hello [13:42:04] Good morning [13:42:22] I just finished dinner and I gotta run out in 3 mins or so [13:42:36] hi RoanKattouw_away [13:42:51] when will you be back? [13:42:52] TrevorParscal: I'll be getting back around 11:15-11:25 [13:43:01] I'm poking at these last 2 IE bugs [13:43:03] k [13:43:08] So by that time please have an idea of whether the code is deployment-ready [13:43:39] So you don't have to like think about it and look stuff up when I ask :) [13:43:44] RoanKattouw_away and TrevorParscal, i want to discuss opt-in configuration for beta users when RoanKattouw_away is back [13:43:48] OK [13:44:04] If the code is ready by the time I can get back, we can get the deployment done before lunch [13:44:11] If not, we'll probably have to do it at 1 [13:44:23] -can [13:47:31] *RoanKattouw_away runs out [13:56:59] adam_miller: whatcha working on:? [13:57:36] TrevorParscal: bugs, if there's something more pertinent to todays release, please reassign me :) [13:58:01] no, that's perfect - which bugs? [13:58:15] I was just about to poke at #22859 [13:58:24] and I see it's yours [13:59:31] it is [13:59:57] are you in bug withdrawl that you want to work on some of mine? [14:00:11] ha ha [14:00:28] i'm just poking at things that are relevant to the release today [14:01:37] i can leave that bug for you if you want - there's also #22347 [14:02:05] TrevorParscal: will you have a look at this bug and assign the priority and assignment accordingly? [14:02:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=22811 [14:02:22] empty text field for internal links triggers a pipe [14:03:18] I can just fix this quickly [14:08:15] Nkomura and all, I love the preview :) .. are there also previews in other languages ? [14:08:35] if there are, I am happy to blog about them [14:10:21] GerardM-: we will enable the preview tab for the usability study [14:11:00] if we confirm the positive outcome, it will be enabled in the future release for all languages [14:11:53] nkomura: https://bugzilla.wikimedia.org/show_bug.cgi?id=22811 is fixed now [14:11:56] I love to tell that point .. it makes it RELEVANT to have a look [14:13:21] GerardM-: preview tab is in still early phase of staging and evaluation. ( i suppose you find it in sandbox?) [14:13:55] yes [14:14:09] so it is important not to set the expectation that it is confirmed feature [14:14:42] if that point is made clearly, i'm fine that you are communicating [14:15:00] please be aware that the state of sandbox changes quickly [14:15:07] some features come and go, [14:15:20] Am happy to give you a preview before I post [14:16:06] i'll see if i can find time to review, but i don't want to delay your post [14:16:26] TrevorParscal: Thank you for fixing the pipe trigger bug. [14:16:43] n/p [14:27:50] Oh great; I just got my train ticket in the mail and realized I booked it for the wrong date [14:27:53] One week too late [14:29:27] crap [14:30:55] so, copy+paste into a template capsule is pretty broken [14:31:05] rather, paste into template capsule [14:31:18] if you copy and paste, our paste handler handles unformatting the stuff properly [14:33:22] TrevorParscal: And it's non-changeable, non-refundable :( so that's EUR 39 down the drain [14:33:38] Unless I magically find someone who wants to travel to Berlin on Monday the 19th [14:34:14] craigslist? [14:34:16] *RoanKattouw goes to book the same trip on the correct date [14:34:35] Yeah we have a local equivalent of Craigslist but i [14:34:44] I don't think anyone would search train tickets there [14:35:47] *RoanKattouw makes mental note to find out if that day's train got significantly delayed [14:35:55] So I could claim a refund [14:36:02] A partial one that is [14:37:39] RoanKattouw: don't they usually let you do a 50% refund no matter what? I'm pretty sure that was DB's policy as of a few years ago [14:38:05] Not if you buy a Superdiscount ticket [14:38:10] I bought it with NS Hispeed [14:38:34] DB is more expensive for my particular situation, NS gives me EUR 10 off because I get domestic train travel for free with my student pass [14:39:11] But yeah DB would've refunded my ticket, even the cheap-ass Europaspezial, minus a E 15 fee [14:39:36] OK, so April 12 [14:39:40] That's the correct date, right? xD [14:42:46] GerardM-: We just put this stuff in the software and TWN picks it up, so they probably translated the preview stuff as well [14:46:25] they do [14:47:01] LocalisationUpdate needs to be set up separately to get the updates ? [14:47:24] What do you mean? [14:47:43] LU works per cluster ... at the WMF.. [14:47:51] Not any more [14:47:56] ? [14:48:01] That was when it still used the DB [14:48:11] But using the DB was a mistake in the first place [14:48:25] So I rewrote LU to not pump megabytes of data through the DB clusters but use text files instead [14:48:41] Which means we no longer need per-cluster stuff, it's one setup for everything [14:49:13] how does that work for software that is so much ahead of everything ? [14:50:44] It checks whether the English version of the message changed [14:50:53] If it did, it doesn't update the message [14:52:02] RoanKattouw: I will be in berlin on the afternoon/evning of the 12th [14:52:25] Cool [14:52:31] I just booked a train that arrives at 7:31pm [14:52:38] On the correct date this time [14:52:43] the 13th is supposed to be work/sightseeing/etc [14:52:47] awesome [14:56:22] Any news on which hotel we're in? [14:57:16] adam_miller: fyi - https://bugzilla.wikimedia.org/show_bug.cgi?id=22859 [14:57:26] I noticed this is a duplicate and marked it as such [14:58:13] TrevorParscal: OK. [15:02:31] RoanKattouw: we are all in whatever hostel daniel is booking [15:02:50] Kinzler? [15:02:54] I asked for reservation there starting on the 12th in my registration [15:03:02] yes, or whoever's helping him with that stuff [15:03:07] Oh wait [15:03:10] So... [15:03:17] When I registered I requested WMDE book accommodation [15:03:18] staff will be in the hostel with everyone says Danese, including her [15:03:25] yes, me too [15:03:27] Then I heard WMF was gonna cover it and I e-mailed them withdrawing that request [15:03:33] hmm [15:03:34] Was that the right thing to do? [15:03:39] Or do I need to flip-flop again? [15:03:42] I'm really sorry about any confusion [15:03:53] hey ... [15:04:07] RoanKattouw's accommodation will be covered by WMF [15:04:21] and RoanKattouw can reimburse the travel expense later [15:04:24] does that mean WMF is booking it though? or just paying for it? [15:04:37] we are booking for him [15:04:45] i se [15:04:56] maybe I need to withdraw my booking request then [15:05:00] sorry about all of this [15:05:02] i put RoanKattouw on the list for WMF's travel arrangement [15:05:05] OK [15:05:06] k [15:05:24] So you guys will clear this all up and make it work? :) [15:06:10] howief: About those optin numbers: WTF. Can you pinpoint the date at which the drop occurs? [15:06:12] RoanKattouw: please let TrevorParscal know your arrival and departure dates [15:06:25] I just gave him my arrival info [15:06:37] Monday, 7:31pm Berlin Ostbahnhof railway station [15:06:47] I haven't booked my trip back yet [15:07:02] RoanKattouw: i could, but i can't do it now [15:07:22] erin or daniel in the office will contact attendees for the travel arrangement [15:07:28] howief: Me neither :) [15:07:56] ok let's pick this up either tomorrow or the day after [15:08:01] Yeah [15:08:11] TrevorParscal: Sooo it's lunchtime. How ready is the current code? [15:08:32] Apart from the fact adam_miller 's whitespace highlighting bugfix broke another whitespace highlighting feature [15:08:43] i just resolved that issue you caught [15:09:09] Yeah but you didn't run make [15:09:25] Or make -B [15:10:33] there's a bug that adam is poking at https://bugzilla.wikimedia.org/show_bug.cgi?id=22347 [15:10:49] RoanKattouw: dang it! [15:11:25] Right [15:11:32] So I'll be working on this school project during lunch [15:11:43] i did, then there was a merge conflict, so I reverted and made my 1 line change again, and forgot the rebuild the second time,... [15:12:16] Ah right [15:12:23] I think the thing that adam is poking at is minor, we can push to test when i get back from lunch [15:12:33] The other thing that often happens is you svn up right before you run make [15:12:41] In which case the timestamps have changed and make does nothing [15:12:47] OK [15:12:51] So let's regroup at 1 then [15:12:56] ok [15:13:11] nkomura: we're going to push to test and deploy when ready starting a 1pm [15:13:14] sound good? [15:13:51] all high priority bugs cleared? [15:14:31] two things - beta opt-in page hasn't been updated [15:15:20] and beta-opt in features upon opting in need NTOC off [15:15:28] when i checked last night it was turned on [15:16:06] yes, we will update that before we push to test [15:16:13] sounds good [15:16:26] looks NTOC is turned off already [15:17:17] nkomura: NTOC is on BUT we hacked it so it's off even when it's on [15:18:05] RoanKattouw: what does it mean from user perspective? [15:18:36] Is it on in user preferences but disabled? [15:18:39] If you just use the optin/optout thing and don't know about preferences, you notice nothing [15:19:00] If you do know about preferences, you'll see [x] Navigable TOC (or whatever the description is) and even though the box is checked you don't get the feature [15:19:02] but you are not turning it on though? [15:19:26] Nope we're leaving it off [15:19:38] i.e. in off-even-when-it's-turned-on-in-prefs mode [15:20:12] for existing users who had NTOC turned on -> yes [15:20:38] so after today's release, new beta opt-in users or returning opt-in users [15:20:51] NTOC is turned OFF in preferences, right? [15:20:55] Yes [15:21:00] That's currently the case already I think [15:21:12] when i opted in last night [15:21:17] it was on [15:21:21] Optin in: NTOC doesn't get turned on, opting out: NTOC gets turned off if it was turned on [15:21:28] Hm [15:21:36] Well it doesn't matter all too much right now [15:21:48] Could you try optin out and back in to check? [15:21:51] it looks fine [15:21:58] i might have been dreaming [15:22:02] And also check that NTOC gets turned off when opting out before optin in again [15:22:11] (IOW, "Have you tried turning it off and on again?") [15:22:35] yes troy ;) [15:23:00] we'll verify it again once we stage on the test [15:24:47] OK [15:25:21] RoanKattouw: committed update to that fixme rev [15:25:36] RoanKattouw: when you have a chance, will you update non-English deployments? [15:25:45] they all have english builds [15:26:26] Hm deployment-si worked for me this afternoon [15:26:37] http://prototype.wikimedia.org/deployment-ar/Main_Page [15:26:44] i see english page instead of arabic [15:26:56] WTF [15:27:08] -si works [15:27:31] what is the URL? [15:27:56] http://prototype.wikimedia.org/deployment-si/Main_Page [15:28:10] ^^ is this right? [15:28:34] Oh wait, file cache? [15:28:50] Looks right to me [15:29:03] [[Main Page]] doesn't exist in Sinhala, but at least the interface is not in Englis [15:30:05] http://prototype.wikimedia.org/ar.wikipedia.org/%D8%A7%D9%84%D8%B5%D9%81%D8%AD%D8%A9_%D8%A7%D9%84%D8%B1%D8%A6%D9%8A%D8%B3%D9%8A%D8%A9 [15:30:06] works [15:30:10] It's just the main page [15:30:41] Hm http://prototype.wikimedia.org/ar.wikipedia.org/Main_Page WFM now [15:30:43] ^^ [15:30:53] *RoanKattouw has no idea what happened there [15:46:49] RoanKattouw: i see prototypes in arabic, i was referring to deployment though [15:47:18] Oh right [15:48:49] What the hell [15:48:54] It only does this for Main_Page [15:48:57] All other pages are fine [15:49:08] oh [15:54:15] adam_miller: i think insert and cancel button in link dialog is reversed [15:54:50] nkomura: reversed in comparison to what? [15:55:08] oh missed the context, you're talking about the arabic prototype? [15:55:10] http://prototype.wikimedia.org/ar-wp/index.php?title=%D8%AA%D9%88%D9%82%D9%8A%D8%AA_%D8%B9%D8%A7%D9%84%D9%85%D9%8A_%D9%85%D9%86%D8%B3%D9%82&action=edit [15:55:28] Ah, they're sharing file caches, I thought so [15:55:56] nkomura: that's the correct order. cancel is on the inside [15:56:02] adam_miller: yes, i'm referring to link dialogs for RTL [15:57:50] adam_miller: got it [15:58:47] nkomura: ar issue fixed now [15:58:48] RoanKattouw: i started seeing right main pages for non-english on deployments [15:58:53] thank you [16:03:26] ok [16:03:34] reading backlog [16:04:11] ok - scanning backlog [16:04:24] RoanKattouw: i just opted into beta in ja-deployment [16:04:38] NTOC was turned on in preferences [16:05:18] the feature is turned on too [16:06:11] do we need to modify this page at all? http://img514.imageshack.us/img514/4368/picture1a.png [16:07:34] nkomura: Hmm [16:07:44] Then I guess my info was outdated [16:07:56] Appears we currently do turn on the NTOC for people that have it turned on [16:08:14] Oh wait [16:08:16] ja-deployment [16:08:23] nkomura: Can you test on the cluster, e.g. jawiki? [16:08:36] TrevorParscal: looks good to me [16:08:45] RoanKattouw: k, one sec [16:09:14] RoanKattouw: could you pastebin the config for optin we are going to be using on the cluster for me? [16:09:49] http://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php , Ctrl+F for OptIn [16:10:41] RoanKattouw: NTOC is "on" upon beta opt-in in ja.wp in production [16:12:10] interesting.... [16:12:21] Weird [16:12:26] According to the config that shouldn't be happening [16:12:32] Could you try opting out and back in? [16:12:32] NTOC is off upon beta opt-in [16:12:51] so the updates few weeks ago only applied to en.wp? [16:13:22] No [16:13:29] They were applied cluster-wide [16:14:52] do you think it is due to cache? [16:15:35] adam_miller: I remember you were working on template copy-paste rebindings [16:15:48] anything further happen with that? [16:16:14] RoanKattouw: ja.wikinews.org shows the correct opt-in feature set upon opt-in [16:16:36] Hm [16:16:43] It should just work that way cluster-wide [16:16:44] nimish_g: i separated the event binding functionality out into separate methods that could be called later, didn't implement calling them yet [16:16:56] there might have been crack in the chocolate i just had [16:16:59] The thing on jawiki could be either due to cache or due to you having the NTOC preference turned on yourself [16:17:01] this doesn't make sense [16:17:21] RoanKattouw: but i left beta and opted in again [16:17:35] that should clear the previous preferences right? [16:17:39] It should, yes [16:17:40] nkomura: are you gonna share the chocolate then? =) [16:17:46] Could you do that again and check your prefs in between? [16:17:52] Like after you opt out but before you opt back in? [16:18:12] nimish_g: i finished it already ;p [16:18:35] RoanKattouw: i will try with a brand new fake account [16:18:52] lol. nkomura and parutron, I tested the templates for everything we have on the sheet and the things that don't work are pasting in general [16:19:05] is this ok for the user tests? [16:19:08] it's working on my localhost as expected [16:24:44] OK so [16:24:44] so NTOC is off if i use a new account for ja.wikipedia.org (production) [16:24:50] TrevorParscal: Are we ready for pushing to testwiki? [16:24:57] yes [16:25:01] we can test the optin there [16:25:03] OK [16:25:40] so if i use the newly created account [16:25:43] i can't reproduce [16:25:54] Weird [16:25:55] strange [16:26:04] so it must be existing account [16:26:26] let's verify it on testwiki and [16:29:40] so if i use my own account on ja.wp [16:30:13] adam_miller: I marked your latest two revs as fixme, please fix them [16:30:19] i do not see NTOC enabled in the editor, but it shows "on" in the preferences [16:30:34] i did opt-out from beta before opting back in of course [16:30:34] Ah [16:30:39] So maybe we did hack it in JS [16:30:46] *RoanKattouw goes to check [16:31:18] RoanKattouw: should the first one be fixed by me removing the offending lines of code in the second one? [16:31:22] Nope doesn't look like we did [16:31:47] adam_miller: No, they're totally unrelated [16:31:58] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/63873#c6262 and http://www.mediawiki.org/wiki/Special:Code/MediaWiki/63875#c6263 [16:33:06] i cannot reproduce it in en.wp though [16:33:45] Strange [16:34:01] OK I'm gonna push this code to test without the fixes for Adam's revs [16:34:08] I'll merge them in as he commits them [16:35:37] Now why do we have two copies of jQuery [16:35:41] Oh sorry wrong window [16:36:26] RoanKattouw: i tried again with en.wp, but opt-in configuration in preferences is correct [16:36:35] i'll try again with ja.wp [16:39:00] ok, i can't reproduce any more in ja.wp [16:39:18] i cleared the cache and shift+refresh [16:39:29] OK [16:39:35] Probably some freak accident or stale cache then [16:42:46] i can reproduce the problem in deployment-en using my account though [16:43:06] i'll try with a new account now [16:50:27] RoanKattouw: i'm confused now [16:51:08] when i opt-in from deployment-en, i wind up being on en.prototype [16:51:19] so let's verify it on test [16:51:27] OK test is all set now [16:51:39] *nkomura goes to test [16:51:42] Go into your prefs and enable dialogs&toolbar [16:52:37] hm? [16:52:50] i want to test features enabled for opt-in first [16:53:16] *nkomura loves new beta landing page [16:55:07] *nkomura confirms NTOC is off in her preferences [16:55:16] TrevorParscal: We are live on test now [16:55:20] k [16:55:23] poking [16:59:33] RoanKattouw: you going to bed soon? [16:59:45] test looks good to me [17:00:00] Soonish, yes [17:01:09] test looks good [17:01:14] i'm fine proceeding [17:01:20] me too [17:01:20] it looks good to me too [17:01:46] let's do it then [17:02:02] OK [17:02:29] I guess I can stay a little bit longer and skip tomorrow's early morning lecture about basic SQL [17:03:34] OK let's proceed then [17:03:57] *nkomura is standing by [17:10:01] OK should be done [17:11:31] nkomura, TrevorParscal: We should be live on the cluster now, please test [17:11:46] k, will check [17:11:56] checking a tester account [17:11:59] Yes [17:12:04] I as just gonna tell parutron to do that [17:12:22] Verify that my Save -> Publish hack worked and that template editing, preview and publish are enabled and work [17:12:25] woo hoo [17:12:29] will check in a few [17:12:33] accounts are Usability X [17:12:54] For X=1..8 [17:12:57] right [17:13:41] i need the password for the accounts.. someone PM me if they know it [17:15:09] RoanKattouw: two link icons are visible [17:15:19]