[12:58:21] hi nimish_g how are u? [12:58:34] tired, but good =) [12:59:15] you? [13:00:14] I am good [13:00:28] actually it s a holiday today [13:00:32] not for the states huh? [13:00:44] yeah, that would be too religious [13:00:44] for the US [13:00:45] LOL [13:01:23] what about australia? [13:01:56] public holiday [13:02:02] barely any supermarkets are open [13:02:06] the whole place just shuts down [13:02:14] wait...it's a holiday? what day is it? [13:02:22] good friday [13:02:27] aah [13:05:28] I just checked our calender, we don't get today off...bummer, I could've gone back to sleep [13:13:03] nimish_g: do we support FF 3 ? [13:13:23] meaning: do we want to support FF3? [13:15:23] yes we do [13:15:33] why wouldn't we want to? [13:15:35] ok, than I ll fill a bugreport [13:15:50] thought it might be too old [13:15:53] ;) [13:16:01] hmm it s not that old, is it? [13:16:02] ooh, you mean FF 3.0 [13:16:09] yes [13:16:19] yeah we're technically supporting it, what's broken on it? [13:16:32] remember this justification bug? [13:16:40] that also occurs on FF 3.0 [14:15:47] good morning parutron [14:15:53] morning [14:15:56] how's everything going? [14:16:01] i'm about to head over to goto [14:16:02] fien [14:16:06] the sun is just about to come up [14:16:09] ;) [14:16:09] ugh [14:16:12] oh u missed the first? [14:16:35] hehe...not your favorite time of the day huh? [14:17:15] not at all [14:17:20] i don't see sean online [14:17:35] is it just you, regan and sean (aka facilitator) in the uservue? [14:17:58] i guess yes [14:18:50] ohoh....10 minutes till the next one starts [14:19:17] oh crap [14:19:18] gotta go! [14:21:00] hi parutron [14:21:05] parutron: ha! you have to work on friday! [14:21:07] *werdna hides [14:21:12] oh you went [14:21:13] lame [14:21:27] she'll be around...yay user studies [14:21:28] i don't know. it's so early it feels like late thursday night [14:31:37] *werdna hands nimish_g some sympathy for parutro [15:29:29] hannes-_-: haha - just saw your email about font/logo. [15:29:40] good to see you're still pushing for the lowercase A! [15:30:15] cary bass is also involved in the font/logo discussions - do you have his email? [15:40:27] oh sure [15:40:31] hey dont leave [15:40:34] come back [15:45:37] you scared her! [15:47:06] nimish_g or hannes-_- did you get the name of the city in wisconscin? [15:47:09] i totally forget [15:48:01] and didn't catch what account he was on [15:48:06] hannes-_-: [15:48:09] nimish_g: [15:54:05] parutron, http://en.wikipedia.org/w/index.php?title=Waukesha,_Wisconsin&curid=236130&action=history [15:54:16] *guillom iz da wizard [15:55:20] parutron: whats carys email? [15:55:25] cbass@ [15:55:29] wikimedia.org [15:56:28] parutron I already rolled back all his changes [15:57:40] guillom you'd better start wearing a pointy hat if you are gonna go that route [16:03:07] how can i involve in this project ? [16:04:36] thanks nimish_g and guillom ! [16:05:34] also nimish_g, hannes-_- and guillom - want to make sure you received the updated participant grid. [16:05:39] it really only affects our next subject [16:06:48] well, I got it, alright, but I'm gonna leave home soon and head to the Moscone center :) [16:06:54] *guillom is in vacation today [16:11:25] our stuff showed up on fatwallet?!?!?!? [16:11:45] what? where? [16:12:04] that's how some participants seemed to find out about our study/incentive to be interviewed [16:12:06] weird [16:20:36] nimish_g: hannes_away FYI: http://www.fatwallet.com/forums/free-stuff/996001 [16:20:45] no other real traces of it, with my short investigation [16:29:15] omg, she ruined the grammar [16:31:55] hahaha, parutron do you have global rollback? [16:32:16] i don't think so? [16:32:22] I can help you with that if you need it [16:32:25] but am hoping you do :) [16:32:33] i usually just "undo" [16:32:52] but because you've been so radical, i haven't had to do that as much ;) [16:37:37] hehe I've just been undoing all the crazy edits (like...now) [16:49:16] guillom: are you observing this study?? [16:49:26] no I'm at home [16:49:30] on vacation [16:49:31] we have a subject that's kind of grabbed onto the idea of adding/uploading pics [16:49:31] :) [16:49:32] oh [16:49:34] oops [16:49:35] tee hee [16:49:39] omg i want to watch [16:49:40] what are you doing on IRC on vacation!?!??!? [16:49:43] what's the code? [16:49:51] F201BC [16:49:53] hilarious [16:50:07] the image part was just a section (which i've marked for you g). [16:50:09] parutron, I've been on IRC for years as a volunteer [16:50:18] on vacation!?!? [16:53:22] pdhanda: fyi, sean cut her off on the photo stuff [16:53:33] back to the more typical script you saw yesterday [16:54:47] nice [16:58:01] she is not afraid of editing for sure [17:01:31] blah [17:01:57] she makes our UI look really bad [17:06:48] D68CB4 [17:06:50] for those of you on [17:06:55] give it a bit [17:07:45] i'm done for today i think :) [18:51:17] TrevorParscal, have been assuming you're not watching the remote sessions today [18:51:41] (hope all is going well with the prefSwitch) [18:52:04] ping me if you join in and FYI, we will be doing the back up session at 1pm today (the last of the day) [19:27:14] parutron: I'm a bit more focused on the default stuff [19:27:22] cool [19:27:43] are things good to go on that front - i might have an out of office meeting on monday 4/5 [19:27:52] am wondering if that'll pose any problems with the go default stuff [19:27:58] have been out of the loop a little [19:28:08] or just plain loopy from these early mornings [19:28:27] read: are we close to being good to go? [19:28:43] TrevorParscal same question (and same level of loopy) [19:29:24] at this point I'm just making minor adjustments and working on the PrefSwitch thing [19:29:35] we should be all set [19:31:56] Good afternoon everyone [19:31:58] *RoanKattouw apologizes for absence [19:46:50] RoanKattouw: i could use a hand [19:47:06] Yeah sorry [19:47:20] Is this about PrefChange or whatever the new awesome name is? [19:47:21] no worries [19:47:25] I have yet to catch up on CR [19:47:28] PrefSwitch [19:47:35] well, before you do [19:47:40] And e-mail, twitter, wikitech-l, .... [19:47:45] just take a look at SpecailPrefSwitch.php [19:47:56] at line 215 [19:48:27] *RoanKattouw svn ups [19:48:27] I'm trying to output some links, but I don't want to use patchwork messages and be building the link names from separate messages [19:48:36] but it's escaping my HTML tags [19:48:43] hoped you might know a trick [19:48:53] I'll need to look at the code but I'll probably know a workaround [19:49:03] that's my hope [19:49:24] the gist of what I did was break the survey system into it's own set of classes [19:50:08] now we have class PrefSwitchSurvey, interface PrefSwitchSurveyField and a set of classes which implement it [19:50:40] it's not perfect, but it's much cleaner and I fixed plenty of other messes along the way [19:50:46] OK so you're using addWikiMsgArray [19:51:01] yup [19:51:16] That in itself is not bad [19:51:22] The bad thing is you're setting the parse option [19:51:26] k [19:51:34] Which, in fact, is hardcoded in addWikiMsgARray [19:51:37] but without that i don't get clever parsing [19:51:48] ah - didn't notice that in the code there [19:52:58] Clever parsing also means escaping links [19:53:22] :( [19:53:27] Oh wait [19:53:29] replaceafter [19:53:34] yeah [19:53:48] OK there's multiple things wrong here [19:53:54] First is you're inserting URLs into the message [19:53:54] :) [19:54:07] alternative? [19:54:12] I have no idea how they're used but because of replaceafter the parser just sees $2 instead of the URL, so clever stuff like [$2 foo] won't work [19:54:18] Solution: don't use replaceafter [19:54:22] Problem 2: [19:54:37] $this->mOriginLink is an HTML link, which you can't insert into a message to then parse it [19:54:59] Instead, do some cleverness with $this->mOriginURL [19:55:15] Which is just the URL of the exact same link [19:55:40] So you'd e.g. pass both OriginURL and OriginTitle as params, then use [$1 $2] in the message [19:55:48] That combined with dropping replaceafter should solve your problems [19:56:13] Oh [19:56:18] Hmmm [19:56:24] No wait [19:56:33] Reading the message caused some doubts, but I'm fairly sure my plan will work [19:57:06] TrevorParscal: Is this something you can work with? [19:57:26] hmmm [19:57:41] it's not an issue with the orgin stuff [19:57:50] the origin works fine [19:58:33] Right [19:58:39] But only because it relies on replaceafter [19:58:46] Which breaks the other thing [19:59:36] Summary of my plan: 1) remove replaceafter 2) change foo to [$2 foo] 3) change originlink param to originurl, origintitle and use [$1 $2] (also causes renumbering of $2 and $3 to $3 and $4) [19:59:57] ah [19:59:59] will try [20:01:08] aZaFred: forward/reverse lookup for grid.tesla.usability.wikimedia.org is strange... [20:01:36] it is [20:01:41] Name: grid.tesla.wikimedia.usability.org [20:01:43] Address: 205.178.145.65 [20:01:44] Non-authoritative answer: [20:01:46] 65.145.178.205.in-addr.arpa name = vux.bos.netsolhost.com. [20:01:54] Non-authoritative answer: [20:01:55] 247.152.80.208.in-addr.arpa name = grid.tesla.usability.wikimedia.org. [20:02:04] forward isn't correct, for sure [20:02:16] indeed that is odd [20:03:33] hmm. though, that is only from my command line. everywhere else seems to be fine [20:03:52] dns zone seems to check out [20:03:58] RoanKattouw: hmm [20:04:02] checking something in [20:04:04] take a look [20:04:14] it's not parsing the links [20:06:03] Hm it looks like you did exactly what I said [20:06:09] Lemme install this extension locally and check it out [20:06:15] How do I reproduce this exactly? [20:07:07] just click on the new link [20:07:09] Aah got it [20:07:11] it will show the page [20:07:17] You need full URLs [20:07:23] Instead of relative ones [20:07:53] So bascially that's s/getLinkURL/getFullURL/ [20:09:15] ah [20:10:22] I'm catching up on the last 70 revs in trunk now [20:10:35] I should have caught up with review in 10-20 mins [20:10:43] l [20:10:46] *k [20:10:48] that worked [20:11:03] Oh and we need to figure out what we do with revs like r64458 in terms of review [20:11:04] sorry, I'm asking dumb questions cause I'm a bit frazzled [20:11:08] No worries [20:11:16] Have you been up since like 5 again? [20:11:28] Oh wait no [20:11:33] You went to sleep at like 1:30 [20:11:40] what's wrong with r64458? [20:11:48] you can't properly review it? [20:11:49] Well, it's CSS [20:11:52] Exactly [20:11:55] ah [20:11:59] And neither can you because you wrote it :D [20:12:04] right [20:12:12] Now I'm not very worried, but it'd be nice to have someone (Adam?) look over this stuff [20:12:26] Similar thing applies to certain revs by Adam, I can't review all of his code either [20:13:04] So basically our review division (once we get in quieter waters and people who are not me actually start doing review) would basically be: [20:13:19] Trevor's CSS revs -> Adam [20:13:27] Roan's revs -> Trevor [20:13:29] yeah [20:13:30] Rest -> Roan [20:13:34] :) [20:14:03] The latter is not so much because I don't trust you to do *review*, more like I don't trust you to *do* review [20:14:09] how do i make these wiki links not look external? [20:14:17] You know, because you're busy and a manager now and have the 5YP thing going on and all :) [20:14:25] TrevorParscal: [20:14:39] That's parser-safe, and class="" are on the parser's HTML whitelist [20:15:02] thanks - i'm brain dead [20:16:47] Dude don't worry about it [20:17:05] You guys have all been doing a ridiculous amount of work the past few days [20:17:38] $user->getOption( 'skin' ) returns 'vector' because it's the default, rather than null [20:17:58] To the point of making me feel guilty for not having time to do much work :) [20:18:00] Yes [20:18:04] so, I guess the whole default is actually just nothing is totally hidden from the API [20:18:11] hidden beneeth the API [20:18:15] it's an implimentation detail [20:18:28] Right [20:18:33] :)) [20:18:35] You're saying that $user->getOption('skin') never returns null? [20:23:58] TrevorParscal, nimish_g: For your comic relief: did you see http://www.mediawiki.org/wiki/Special:Code/MediaWiki/64478 ? [20:26:03] ummm [20:26:04] wow [20:36:25] TrevorParscal: I'd like to add pss_name to the unique index since surveys can and probably will share question IDs [20:37:05] um [20:37:41] so, just add to the current uniqe index [20:37:47] right [20:39:56] Yes [20:40:02] if ( in_array( 'PrefSwitchSurveyField', class_implements( self::$fieldTypes[$config['type']] ) ) ) { [20:40:11] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/64460#c6434 ? [20:40:15] I wanted to convert that to an instanceof call but it turns out that's not easy [20:40:21] yeah [20:40:39] there should be an implementationof keyword [20:40:46] So I'm thinking about maybe dropping that check entirely, it seems kinda useless [20:40:58] There's no external factors that could make that test fail, only internal ones [20:41:04] So it's pointless to keep checking it on every run [20:41:22] :( my defensive programming skillz are overkill? [20:41:27] yeah [20:41:38] Yeah about that CR comment: you're hardcoding the number 2 etc. , I didn't really like it. It's more of an aesthetics thing really [20:41:58] Well it's either that or some remnant of Java [20:42:15] Where you have to explicitly cast the object to an instance of the interface before you can call a method on it [20:43:31] I learned it from D probably [20:44:02] how are you liking this refactor overall? [20:44:30] It looks nice so far [20:44:48] i need to take a break before I fix the page title stuff [20:44:50] I'm making small changes as I'm reviewing it but the first part of .classes.php looks like it's gonna be really clean code [20:44:56] Fix what exactly? [20:45:03] I'm also in your code, cleaning things up [20:45:09] i removed the overkill checks and committed it a sec ago [20:45:11] Only minor stuff though [20:45:12] did you see that? [20:45:14] Yeah [20:45:16] feel free to hack away [20:45:20] I'm going to take a break [20:45:28] But you got the index order wrong so I'm just gonna overwrite your changes :( [20:45:33] (in the SQL file) [20:48:51] k [21:04:35] TrevorParscal: This code is a damn sight cleaner than the old OptIn code, good work [21:04:48] thanks [21:04:57] I think I'd personally favor rewriting it to be survey object-based rather than using all this static stuff which gets awkward in places [21:05:23] wohoo i get to work on Usability project for the rest of the day! [21:05:47] But that's really a minor thing and probably not worth the (second) rewrite [21:08:49] Cleanup committed [21:08:49] RoanKattouw: I have no issue with that [21:08:56] I have lots of ideas for that too [21:09:04] But no time :) [21:11:52] hmm [21:12:17] $user->saveSettings() is not committing on my localhost [21:12:40] I will save settings, then use $user->getOption() and get the old values [21:13:40] :O [21:14:46] hmm [21:15:00] there's litterally a $dbw->commit() being called [21:15:08] maybe I'm doing something else wrong... [21:15:46] O [21:15:48] haha [21:16:00] Try to pass $user by reference in the functions that mess with user options [21:16:09] um [21:16:11] i'm dum [21:16:23] I'm doing the title processing ahead of the form processing [21:18:44] Ah [21:19:06] fixed [21:19:30] Also, it seems the JS registering browser+OS data on optin got lost [21:21:46] TrevorParscal: + 'prefswitch-survey-submit-off' => 'Turn New Features Off', [21:21:56] Don't Use Title Case In Messages Like That, Siebrand Doesn't Like It [21:22:02] ah [21:22:04] will fix [21:22:24] (It's fine for things that are actually titles of course, but people tend to overuse it all the time) [21:24:07] + 'prefswitch-main' => 'We\'ve been working hard to make things easier for our users. We\'re excited to share some improvements, including a new look and feel and simplified editing features. Improving the usability of the site is an ongoing effort here at Wikimedia and we\'ll be sharing more updates in the future. [21:24:17] Use double quotes for this [21:24:22] ah [21:24:51] I used to do that all the time but then Siebrand slapped me :) [21:25:21] and escape the " in the ? [21:25:36] Yes [21:25:39] Bleh [21:25:43] OH [21:25:49] I don't know what's preferred in that case then [21:26:00] "We've love to hear from you" -> ah? [21:27:20] Does

work in wikitext? *surprised* [21:27:27] *TrevorParscal just had a committing spree [21:27:30] yes [21:27:34] it was in the old toolbar [21:27:46] with a side note in the tooltip "use sparingly" [21:27:51] heh [21:27:53] Well [21:28:00] There's ---- for it in wikitext [21:28:07] ah [21:28:07] I thought that's what the old toolbar inserted [21:28:16] yeah, probably did [21:28:25] should I really switch to that? [21:28:32] Nah don't bother [21:28:40] I was surprised

works, is all [21:31:19] haha: [21:31:27] - 'id' => "prefswitch-survey-{$name}", [21:31:29] + 'id' => "prefswitch-survey-{$mode}" [21:31:34] I guess I half-fixed that line then [21:31:54] I saw it being in single quotes so I knew that was definitely wrong, turns out my version wasn't really any less wrong [21:32:24] ha ha [21:32:25] yeah [21:33:01] I guess me reviewing code at 11:30 that you wrote at 2 is not very healthy