[08:11:14] RoanKattouw: didn't you set in berlin for cs bold and italics buttons as B and I? i see again A & A [08:11:34] No, I don't think I did [08:11:41] I fixed the bug where one was A and the other was I [08:41:05] RoanKattouw: so should i file a bug for having b/i in cs inseatd of a/a or is this form of wish good enough? [08:41:48] Please file a bug [08:41:55] I'm not gonna be working on WMF work much today [10:48:18] I can never get this channel name right [10:49:16] Hoi, cary|wfh but you got there in the end .... what does wfh stand for ? [10:49:26] <^demon> work from home :) [10:49:31] "What fresh Hell" [10:49:37] or what ^demon said [10:50:03] thanks :) [10:58:39] RoanKattouw_away: will you ping me when you are back? [11:10:12] damn, /me spies |wfh attached to cary [11:11:28] Who's in the office and wants to ask Sue the name of the organization that matches projects seeking volunteers to people seeking volunteer opportunities? [11:11:44] *mikelifeguard hopes she remembers that and doesn't look at the pass-it-along-er like they have three heads [11:13:13] If I remember correctly, Sue is not in the office today. [11:13:18] nkomura: Back [11:13:30] hi RoanKattouw [11:13:37] But [11:13:42] "Volunteer-match" sounds familiar [11:13:54] i've been playing with the improved search on the prototype [11:14:11] i wanted to confirm two things. [11:14:22] 1) is adam's fix on truncation included? [11:14:34] i think it did as I cannot reproduce the bug [11:14:34] cary|wfh++; [11:14:47] nkomura: Yes, it's included [11:15:18] my second point is about the hover over effect you mentioned [11:15:44] The tooltip [11:15:56] for? [11:16:18] for the magnifying glass? [11:21:27] why don't we extend the search suggestions fully when it is selected in stead of keeping the term shortened by the ellipsis in the middle? [11:23:02] Erik has suggested this too, I guess we could do this [11:23:08] The suggestions can't be longer than 255 chars anyway [11:30:01] RoanKattouw: when you have the change ready, i'll send out the notice to the community to try it out [11:30:23] if we encounter more issues, we will restore back to the original search behavior tomorrow [11:30:31] OK so you want infinite expansion, I can hack that up real quick [11:30:49] the word infinite scares me :-) [11:31:03] adam_miller: I am going to touch the suggestions plugin now to remove the maximum expansion width. Notifying you as you're probably in there too [11:31:18] heh [11:31:18] yeah, want to hold off one minute? [11:31:20] about to commit [11:31:24] Oh then commit [11:31:26] By all means [11:31:38] nkomura: Of course it can't really be infinite, as titles are limited to 255 chars :) [11:31:40] RoanKattouw is afraid of commitment [11:33:11] RoanKattouw: i'm gonna remove the expandToLeft var [11:33:14] i dont think we'll need it now [11:33:35] We still need to account for RT+L [11:33:38] *RTL [11:33:59] You're right you won't need to do anything special when you're right-anchoring the suggestion box [11:34:08] But you will need to left-anchor it in RTL mode, presumably [11:35:34] i think i got that taken care of [11:35:48] just going to check in RTL to be sure before committing [11:36:11] OK [11:42:32] RoanKattouw: r66642 [11:42:59] Thanks [11:43:01] !r 66642 [11:43:01] --elephant-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66642 [11:43:45] + console.log("LEFT"); [11:43:52] + console.log("right"); [11:44:12] argh [11:44:23] there's at least one spelling mistake too [11:45:11] *RoanKattouw grins at how these console.log statements use inconsistent case [11:45:23] Oh yeah, wether [11:45:36] fixed [11:45:45] BTW you can use newCSS.left instead of newCSS['left'] if you want to, although the latter is not wrong [11:45:55] array( 'src' => 'js/plugins.combined.js', 'version' => 400 ), [11:46:01] 400! [11:46:34] Whee [11:46:38] RoanKattouw: there's still a typo in p-personal (p-mycontris) :| [11:46:40] Finished reading, looks OK [11:46:48] mikelifeguard: Where is that? [11:46:56] pt-mycontris, sorry [11:46:59] sloppy, boys [11:47:09] mikelifeguard: This is in Vector? Is the Monobook ID spelled right? [11:47:19] in p-personal (I assume it is vector only, because y'know, who would ever want to share HMTL with monobook?) [11:47:29] Well you know [11:47:38] Some other skins also have a my contribs liink [11:47:48] :o [11:47:50] you're right! [11:47:54] this is wrong! all WRONG! [11:48:05] Well [11:48:07] Thing is [11:48:12] Monobook also calls it p-mycontris [11:48:21] So it appears this was done deliberately for Monobook compat [11:48:52] There are quite a few elements that are functionally equivalent between the two skins, and we have given these identical IDs to make CSS/JS easier to write [11:49:04] and I guess we don't want to fix monobook :\ [11:49:19] There's nothing to "fix", really [11:49:23] give it two ids! and normal people can use the properly-spelled one :P [11:49:27] We could've also used #dfjgkjdfglds [11:49:33] But we chose to use something descriptive [11:49:44] Changing the ID would be horrible from a compat perspective [11:49:55] I know, I'm just giving you a hard time :) [11:49:56] #348OMGWHATAMESS85439 [11:50:58] RoanKattouw: ALTHOUGH! Do you know why I am getting such ... strange ... results from a sitematrix query? -> http://sprunge.us/dfBD?pl [11:52:33] What's strange? [11:52:53] Where is the 32 coming from, for example? [11:53:40] No idea what those numbers mean [11:53:44] bugwiki [11:53:46] *RoanKattouw never looked at the ApiSiteMatrix code [11:54:01] oh, who wrote it? [11:54:03] cary|wfh: There's also a barwiki, which leads me to believe there must be a foowiki as well [11:54:05] mikelifeguard: vvv I tihnk [11:54:21] Eh? [11:54:28] RoanKattouw, if we ever create a Mongo Language Wikipedia it will be lolwiki [11:54:43] vvv: see my question above? [11:54:51] cary|wfh: I wonder if they would get vandalized! [11:55:02] mikelifeguard: it didn't output such things when it was first commited [11:55:03] or maybe just smothered with cats [11:55:03] all the damn time. [11:55:18] *mikelifeguard imagines a giant pile of cats raining down on WMF servers [11:55:34] The question isn't if a wiki will be vandalized, but how [11:55:57] vvv: It's strange because the number 32 doesn't appear anywhere in the response when I view it in my browser... nor any of the other numbers [11:57:51] mikelifeguard: I have no ideas [11:58:04] May you give me a URL to reproduce? [11:58:42] Well, the API result is http://en.wikipedia.org/w/api.php?action=sitematrix - but what I showed earlier is a Perl hash of the result. [11:58:59] It is possible MediaWiki::API is doing something stupid with the response, I will ask the maintainer. [12:17:58] OMG, it is actually possible for page titles to run off-screen [12:18:14] nkomura: Would it be OK to use the ... trick if the title would run off-screen otherwise? [12:18:19] "An_Act_to_restrict_membership_of_the_House_of_Lords_by_virtue_of_a_hereditary_peerage;_to_make_related_provision_about_disqualifications_for_voting_at_elections_to,_and_for_membership_of,_the_House_of_Commons;_and_for_connected_purposes" doesn't fit on my screen [12:18:39] And that's 236 chars, titles up to 255 chars plus namespace prefix (which can be something like "Wikipedia talk:") are possible [12:19:03] OMG! :D [12:19:12] what a long article name [12:19:52] i have to look up that article in WP [12:20:14] BTW, of course it is ok to use ... for that case [12:20:44] I ran a DB query on enwiki for the hell of it [12:20:51] Getting the first 10 titles longer than 200 chars [12:20:57] *first 5 [12:21:01] And this was the longest one among them [12:21:41] it's redirected to House of Lords Act 1999 [12:38:27] nkomura: "Infinite" (i.e. screen edge-bounded) expansion is now live on the prototypes [12:39:10] woot! [12:39:37] adam_miller: SimpleSearch and suggestions.js are all yours now, I have other stuff to do [12:41:28] i love it! :-) [12:43:10] http://ultimategerardm.blogspot.com/2010/05/new-wikipedia-related-logo-just-spotted.html You may have read it first on my blog [12:43:21] OR you belong to an incrowd ... [12:44:04] RoanKattouw: it works nicely in german too [12:44:26] I also paid attention to making it work in RTL [12:45:23] GerardM-: i'll read it later ;-) [12:45:38] still busy following up the deployment from last week... [12:48:00] RoanKattouw: can i try the search box with RTL anywhere? [12:48:19] aharoni: http://prototype.wikimedia.org/ar.wikipedia.org/ [13:30:32] RoanKattouw, if you're still: the searchbox in Arabic prototype looks fine, although i have a very patchy knowledge of Arabic [13:30:43] OK [13:30:54] Arabic and Hebrew should work about the same [13:31:05] Yeah it's really just about LTR vs. RTL here [13:31:15] i'd be glad to try in a Hebrew environment. [13:31:25] i went over the feedback spreadsheet from he.wikipedia. [13:31:31] I'm not sure if we have a Hebrew prototype wiki [13:31:39] I don't think we do [13:32:21] one user actually complained about wrong alignment in the search box - left instead of right. [13:32:32] The main difference is that Hebrew text is generally more readable at smaller size than Arabic. [13:32:47] Wrong alignment inside the search textbox? [13:32:48] yes, it probably is :) [13:33:28] (more readable) [13:33:42] yes, that's what one user said - alignment to left instead of right. [13:33:50] i tried the beta since day one and i don't remember it happening. [13:34:04] and i guess that the new search box is rewritten anyway. [13:35:32] is the "containing" link in the search box in the live en.wikipedia supposed to work now? after cleaning the cache and action=purge i still don't see it. [13:38:15] No, it's disabled for now [13:45:52] Oh hai aharoni [13:46:07] hallo, vvv [13:46:16] Decided to join usability figthing club on IRC? :) [13:46:35] The first rule of Usability fight club is [13:46:48] You don't talk about Usability Fight Club [13:48:12] do i have a choice? [13:48:57] The second rule of Usability Fight Club is [13:49:08] You don't talk about Usability Fight Club [13:51:02] *vvv wonders what would be the Thrid Rule [13:58:47] RoanKattouw: do we really want the suggestions box to expand to 1347px wide? [13:59:16] it's expanding that far for me when i type 'an' on prototype [13:59:34] I know that [13:59:38] It's bounded by the screen size [13:59:46] I'm not sure that is the best idea ever [14:00:00] i'd suggest we cap that somewhere [14:00:09] i thought you were doing that before? [14:00:14] But nkomura_lunch and Erik said 2x the search box width was too narrow so I decided to go with something that wasn't arbitrary [14:01:03] can we cap it at 3x the width? [14:01:15] Well we can [14:01:19] Ask nkomura_lunch when she gets bakc [14:01:22] it looks a mistake at 12x the length [14:02:02] Yeah I agree it probably makes sense to limit it somewhere [14:05:56] the "..." in the middle is a bit weird, although it's probably better to have that than to have only the first few letters which may be the same for all the suggestions. [14:06:22] i would limit to 90% of the screen maybe. [14:08:22] aharoni: There's also a tooltip on hover for when you really want to know what's being hidden by the ... [14:11:27] am i in the usability fight club? ;) [14:11:39] adam_miller: i'm back [14:12:41] RoanKattouw: that's not what i meant... [14:13:04] i meant expand to the length of the article name when the suggestion is selected [14:13:09] sorry i didn't test that [14:13:19] Oh [14:13:21] Wait [14:13:25] That would be... weird [14:13:38] yeah that would be really bizarre [14:13:45] We have a tooltip already [14:14:00] We could increase the factor 2 like Adam suggested [14:14:12] really? [14:14:53] why can't we have a fixed width ... for the articles names which do not fit and expand if that article is selected? [14:15:25] i only see the tooltip the fisrt time. [14:15:58] nkomura: I agree with Adam that would be really bizarre [14:16:16] And the name might still not fit [14:16:38] k [14:17:10] let's see it with adam_miller's suggestion then ;) [14:17:53] Why wouldn't it be a fixed size if the suggestions shown fit in that and expand to fit the longest one if needed, up to, say, 3x the initial fixed size? Isn't that fairly standard behaviour for search boxes you see elsewhere online? [14:18:12] i type "an", i see the long title and the tooltip works. then i click elsewhere. then i type "an" again. the long title appears, but the tooltip does not. [14:21:10] mikelifeguard: we are incorporating the auto-expansion, and discussion how much expansion [14:28:18] RoanKattouw: i'm ok setting the expansion to x3 and use ellipsis for names over 3x width [14:31:16] OK [14:31:20] I will implement that right away [14:36:35] RoanKattouw: are you just putting back the maxExpandFactor code you had before? [14:37:16] i'm about to commit the bold-ing of matched text in the results and still have your maxExpandFactor code in there [14:37:23] Well, sort of [14:37:30] Hold on for just a minute [14:37:34] k [14:40:58] All done, go bonkers [14:41:50] yay! [14:43:17] adam_miller: Please update prototype after you commit, I haven't [14:43:33] will do [14:44:55] (And I'm about to leave) [14:50:46] is adam_miller enhancing the prototype with something too? [14:51:01] Yes, boldening of the prefix [14:51:03] adding a little into our suggestions [14:51:17] OK so I'm gonna go take a shower now [14:51:21] *nice" [14:51:25] *nice* [14:51:32] nkomura: I will get you your statistics in the morning [14:51:36] happy showering [14:51:41] Hopefully before midnight your time [14:51:54] I will check back here before going to sleep [15:26:59] adam_miller: Did you just fixme your own rev? :P [15:27:05] (I added another comment) [15:27:05] totally [15:27:21] i'm not sure why it won't let me just use a span there [15:27:47] i switch it div and it works, but if i use a span, it seems to strip the strong out [15:28:08] is blahahhh illegal? [15:28:24] no [15:28:36] maybe in wikitext [15:29:12] it's either jquery or firefox that's removing it [15:29:47] Maybe it is illegal to put a strong inside a span [15:29:53] Have you tried to use a styled span instead of a strong? [15:31:41] that doesn't make sense [15:32:28] *cary-wfh consults w3 [15:33:52] and are both phrasing content elements [15:33:57] they can be stacked with no problem. [15:34:02] in either direction [15:34:55] adam_miller: Oooh, maybe it's the double "var text" declaration [15:35:05] JS implementations differ in what they do when you try to declare a var twice [15:35:06] no, it was doing it before i did that [15:35:10] Yours might shadow it [15:35:13] Hm [15:35:21] i'm just gonna do it another way [15:35:27] so i can use text() instead of html() [15:36:10] And be safe against XSS too [16:04:11] flipzagging: [16:04:12] I think the current form is only supposed to work in FF3+ or FF3.5+ [16:04:12] (for now) [16:04:15] am I right? [16:09:08] adam_miller: plz let me know when you are updating the prototype [16:09:24] nkomura: i'm done updating the prototype [16:09:26] but i broke things [16:09:32] that i'm now trying to fix [16:09:32] oh [16:09:35] :) [16:09:38] got it ;) [16:13:56] guillom: yes. [16:14:04] guillom: it works in Chrome, almost. [16:14:25] ok, thanks [16:14:30] guillom: I haven't done extensive IE testing. [16:14:54] flipzagging: no worries [16:24:33] nkomura: so i just updated it again [16:25:16] i kinda got things fixed, but i'm having lots of problems getting the bold-ing and auto ellipsing working concurrently [16:25:24] so it seems that auto ellipsing is not working right now [16:25:46] *nkomura goes to prototype and look [16:26:05] but the 3x max size is in place [16:27:15] what do people think of the left expansion? [16:27:54] i love the bold format for the matching letters [16:28:09] me too [16:28:39] the left expansion is great [16:29:33] i think so too [16:29:42] it'd be nice if ellipsis works for the extreme long word [16:29:54] so that the end does not cut off [16:30:02] two questions (sorry if this has already been discussed) [16:30:02] but i think that's an extreme edge case [16:31:09] 1) why is the default position on the "containing. . ." vs. the first auto-suggest? this seems a little contrary to standard auto-suggest behavior (seems like most either default to none or the first auto-suggest) [16:31:27] 2) what about making within the search field go to the magnifying glass icon? [16:31:44] (similar to how goes to "google search") [16:34:09] i also thought about your first point [16:34:57] i'm neutral to none vs 'containing' [16:36:31] google - none; apple - none; facebook - first; yahoo - none; bing - none [16:37:10] k [16:37:47] there's also a bug where if there are multiple auto-suggests, i can't up-arrow past the last auto-suggest [16:38:03] for example, enter "manc" and try to up-arrow to "manchester mark 1" [16:38:18] re: 2), not sure what we gain by selecting magnifying glass upon tabbing [16:38:55] i havne't thought this through completely [16:38:56] bug against the enhanced search already? [16:39:20] but if we go with either none or first as the default [16:39:36] then tabbing gives the user a quick keystroke way to get to "advanced" search [16:40:41] right [16:41:08] btw, i see none is selected now on the prototype [16:41:25] but we could make simply default to advanced search if we select "none" as the default position [16:44:28] we talked about changing the behavior of for a long time [16:45:07] changing the behavior of enter from article search to advanced search will cause a lot of confusion to existing users [16:45:43] it is a valid point, but it is not a change we can introduce over night [16:46:15] i think we can share the current prototype as is and get more feedback, what do you think howief?