[12:12:03] GitHub [7benapetr/wikimedia-bot] benapetr commented on issue Add ability to view and manage permissions for other channels without joining them: https://github.com/benapetr/wikimedia-bot/pull/84#issuecomment-637500627 [12:13:30] MacFan4000: did you actually test that patch? [12:14:07] No, I don’t really have a good setup for that [12:14:22] aha ok [12:14:27] well let's see [12:14:32] GitHub [7benapetr/wikimedia-bot] benapetr pushed 1 commits into branch master: https://github.com/benapetr/wikimedia-bot/compare/a0ddce47222d...98f1677aeabe [12:14:32] GitHub [7benapetr/wikimedia-bot] commit by MacFan4000 (MacFan4000) https://github.com/benapetr/wikimedia-bot/commit/98f1677aeabe44c591ef674482e39ef95eeb992e Add ability to view and manage permissions for other channels without joining them (#84) * Add ability to get trusted list for a specific channel that the bot is in and also improve error message [12:14:32] DEBUG Exception in module NetCat: Unable to write data to the transport connection: The socket has been shut down. st: at System.Net.Sockets.NetworkStream.Write (System.Byte[] buffer, System.Int32 offset, System.Int32 size) [0x00107] in :0 at System.IO.StreamWriter.Flush (System.Boolean flushStream, System.Boolean flushEncoder) [0x00098] in :0 at System.IO.StreamWriter.Flush () [0x00006] in :0 at wmib.Extensions.NetCat.SendMessage (System.IO.StreamWriter& writer, System.String text) [0x0000a] in <39d25b072c37410ebe12b1faf5bcf0dc>:0 at wmib.Extensions.NetCat.Client (System.Object data) [0x0013c] in <39d25b072c37410ebe12b1faf5bcf0dc>:0 [12:16:09] doesn't even compile :P [12:17:04] if only people were aligning {} in a sensible way, maybe they would overlook missing ones ;) [12:17:54] since some time it became favourite amongst developers to put opening bracket on same line as previous line, I have no idea why. It looks ugly. It's impractical. It leads to mistakes. [12:23:08] I will fix it [12:23:19] petan: https://github.com/benapetr/wikimedia-bot/pull/86 [12:25:08] I trust: .*@.*[Ww]iki.*\/.* (2operator), .*@freenode/.* (2admin), .*@wikipedia/fsf.member.Lixxx235 (2admin), .*@wikimedia-commons/JurgenNL (2admin), .*@countervandalism/.* (2operator), .*!.*@gentoo/developer/maffblaster (2operator), .*@miraheze/.* (2operator), .*!.*@tnb/staff/.* (2operator), [12:25:08] @trusted [12:25:27] MacFan4000: it's not so simple, it wasn't just missing bracket [12:25:34] I trust: .*@.*[Ww]iki.*\/.* (2operator), .*@freenode/.* (2admin), .*@wikipedia/fsf.member.Lixxx235 (2admin), .*@wikimedia-commons/JurgenNL (2admin), .*@countervandalism/.* (2operator), .*!.*@gentoo/developer/maffblaster (2operator), .*@miraheze/.* (2operator), .*!.*@tnb/staff/.* (2operator), [12:25:34] @trusted #MacFan4000 [12:25:38] Oh [12:26:53] you need to understand it was so long ago when I wrote wm-bot that I completely forgot the code... I have to understand how it works again :D right now I am lost in why there are 2 @trusted functions and how is that blue color generated :D [12:28:23] there is some uber-hack behind this [12:32:54] ok so the hack is this functionality is already implemented :D it works in private messages to wm-bot [12:34:39] I will try to make it possible to do in a channel too [12:35:08] that Trusted function you modified is invoked only via PM, it was already expecting channel name as parameter, no need to change that, when you run it in channel it calls [12:35:16] private static void TrustedList(CommandParams parameters) [12:35:43] Color is https://github.com/benapetr/wikimedia-bot/blob/ef37646ed4d8472280bace1079899c6fa1eb1677/src/WMBot/Security.cs#L578 [12:35:51] yeah I found that already [12:41:23] I was trying to do @trustadd and @trustdel as well [12:41:29] I know [12:41:32] I am working on that [12:41:50] Ah, k [12:52:41] it's not so simple because there is no invoker in implementation of these 2 functions [12:52:51] you were for some reason assuming there is [13:00:15] Oh [13:01:16] GitHub [7benapetr/wikimedia-bot] benapetr pushed 1 commits into branch master: https://github.com/benapetr/wikimedia-bot/compare/98f1677aeabe...dcab792ecff7 [13:01:16] GitHub [7benapetr/wikimedia-bot] commit by benapetr (Petr Bena) https://github.com/benapetr/wikimedia-bot/commit/dcab792ecff7dde7ccccd2f4b344958ad1275669 fixed previous commits [13:01:19] this should d it [13:02:22] of course Visual Studio started auto-format the code with some weird style, I don't know why, it didn't do this 5 years ago :D [13:03:54] K [13:04:54] You are root and identified by the name .*@wikimedia/Petrb [13:04:54] @whoami [13:04:57] I trust: .*@.*[Ww]iki.*\/.* (2operator), .*@freenode/.* (2admin), .*@wikipedia/fsf.member.Lixxx235 (2admin), .*@wikimedia-commons/JurgenNL (2admin), .*@countervandalism/.* (2operator), .*!.*@gentoo/developer/maffblaster (2operator), .*@miraheze/.* (2operator), .*!.*@tnb/staff/.* (2operator), [13:04:57] @trusted [13:05:02] I trust: petan!.*@wikimedia/Petrb (2admin), [13:05:02] @trusted #petan [13:05:18] @trustadd [13:05:18] Wrong number of parameters, go fix it - example @trustadd regex (admin|trusted) [13:05:18] @trustadd test [13:05:28] Successfully added .* [13:05:28] @trustadd .* trusted #petan [13:05:32] I trust: petan!.*@wikimedia/Petrb (2admin), .* (2trusted), [13:05:32] @trusted #petan [13:05:36] I trust: .*@.*[Ww]iki.*\/.* (2operator), .*@freenode/.* (2admin), .*@wikipedia/fsf.member.Lixxx235 (2admin), .*@wikimedia-commons/JurgenNL (2admin), .*@countervandalism/.* (2operator), .*!.*@gentoo/developer/maffblaster (2operator), .*@miraheze/.* (2operator), .*!.*@tnb/staff/.* (2operator), [13:05:36] @trusted [13:05:42] Successfully added test [13:05:42] @trustadd test admin #MacFan4000 [13:05:46] @trustdel .* #petan [13:06:01] well [13:06:04] it almost works :D [13:06:12] @trust del test #MacFan4000 [13:06:31] @trustdel test #MacFan4000 [13:06:44] User not found, sorry [13:06:44] @trustdel test [13:06:50] User not found, sorry [13:06:50] @trustdel .* [13:06:57] it worked, but it responded in the other channel [13:07:18] oh lol [13:09:06] well yeah that implementation sucks, it sends errors from function AddUser / DeleteUser to channel which is involved [13:10:13] Thanks :) [13:10:49] * MacFan4000 looks at updating the docs [13:11:25] I am changing it [13:11:29] the code [13:11:31] not docs [13:13:38] GitHub [7benapetr/wikimedia-bot] benapetr pushed 1 commits into branch master: https://github.com/benapetr/wikimedia-bot/compare/dcab792ecff7...0459f1f3d443 [13:13:38] GitHub [7benapetr/wikimedia-bot] commit by benapetr (Petr Bena) https://github.com/benapetr/wikimedia-bot/commit/0459f1f3d443e18036ab9d6ca034e18a06f98212 security message flow enhanced make it possible to specify alternative channel for response [13:14:42] User not found, sorry [13:14:42] @trustdel .* #petan [13:14:42] !ping [13:14:42] Pong. [13:14:55] so here we go [13:18:13] Change on 12meta.wikimedia.org a page Wm-bot was modified, changed by MacFan4000 link https://meta.wikimedia.org/w/index.php?diff=20134369 edit summary: Update [13:18:13] Change on 12meta.wikimedia.org a page Wm-bot was modified, changed by MacFan4000 link https://meta.wikimedia.org/w/index.php?diff=20134369 edit summary: [+438] Update [13:22:26] 10WM-Bot, 10User-Examknow, 10User-MacFan4000: wmbot returns ‘unable to connect to SQL: unknown’ when enabling github relay - https://phabricator.wikimedia.org/T249364 (10MacFan4000) 05Open→03Resolved a:03MacFan4000 This seems to be fixed now. [13:26:36] 10WM-Bot, 10User-Examknow, 10User-MacFan4000: wmbot returns ‘unable to connect to SQL: unknown’ when enabling github relay - https://phabricator.wikimedia.org/T249364 (10MacFan4000) a:05MacFan4000→03None [13:27:22] @systeminfo [13:27:22] * wm-bot4 is online; channels: 88 connected: True working: True queue: 0 [13:27:22] * wm-bot3 is online; channels: 81 connected: True working: True queue: 0 [13:27:22] * wm-bot2 is online; channels: 86 connected: True working: True queue: 0 [13:27:22] * wm-bot5 is online; channels: 84 connected: True working: True queue: 0 [20:03:40] Attempting to join #SigmaBot using wm-bot [20:03:40] @join #SigmaBot [20:03:58] Attempting to join #miraheze-bots using wm-bot3 [20:03:58] @join #miraheze-bots [20:24:20] I trust: Texas!.*@miraheze/Examknow (2admin), [20:24:20] @trusted #miraheze-bots [20:24:40] MacFan4000: Hello [20:24:46] hi [20:26:25] Successfully added .*@miraheze/.* [20:26:25] @trustadd .*@miraheze/.* trusted #miraheze-bots [20:28:04] Successfully added .*@.*[Ww]iki.*\/.* [20:28:04] @trustadd .*@.*[Ww]iki.*\/.* trusted #miraheze-bots [20:30:43] Attempting to join ##RhinosF1 using wm-bot4 [20:30:43] @add ##RhinosF1