[10:40:53] <Urbanecm>	 shreyasminocha, takidelfin|sick: bug report: It isn't possible to add comment, hiding.js doesn't seem to work
[10:41:12] <Urbanecm>	 I'm on mobile and unable to investigate
[10:41:58] <Urbanecm>	 In case anybody has time before me, please upload a patchset!
[10:42:04] <takidelfin|sick>	 Urbanecm: okay, I feel better now. Fixing :D
[10:42:14] <Urbanecm>	 Thanks!
[11:05:26] <takidelfin|sick>	 Urbanecm: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479412
[11:05:29] <takidelfin|sick>	 done
[11:05:45] <takidelfin|sick>	 there was a problem with 'display:none' in CSS
[11:06:00] <takidelfin|sick>	 :)
[11:06:40] <Urbanecm>	 Isn't hiding.js supposed to unhide it?
[11:06:50] <Urbanecm>	 Thanks anyway, will review ASAP
[11:11:14] <takidelfin|sick>	 yup, but hiding.js uses 'hidden' property of HTMLElement
[11:11:23] <takidelfin|sick>	 https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/hidden
[11:11:44] <takidelfin|sick>	 and 'display: none' overrides `hidden` propery
[11:11:51] <takidelfin|sick>	 so there was a problem D:
[11:17:53] <Urbanecm>	 Aha, thanks.
[11:18:14] <Urbanecm>	 Shreyas, if you are around before I will, please review :)
[11:21:33] <takidelfin|sick>	 shreyasminocha ^
[15:25:01] <takidelfin|sick>	 and ? :D
[15:26:50] <shreyasminocha>	 :O didn't see all that
[15:27:34] <shreyasminocha>	 Urbanecm: is this what you were talking about last night or is this something else?
[15:28:08] <Urbanecm>	 you mean the bug? Nope, this is something different
[16:22:00] <shreyasminocha>	 left a CR
[16:22:30] <shreyasminocha>	 btw let me set up wikibugs for this channel
[16:22:51] <shreyasminocha>	 will have to speak to freenode staff and get him (her?) exempt from SIGYN
[16:23:11] <shreyasminocha>	 (he'll post only tracker-related updates ofc)
[16:23:15] <shreyasminocha>	 (she?)
[16:40:01] <shreyasminocha>	 k, now wikibugs is exmpt from Sigyn
[16:40:13] <shreyasminocha>	 as instructed in wikibugs2/gerrit-channels.yaml
[16:40:48] <shreyasminocha>	 what i do not understand is how to include wikimedia-cz/tracker in the yaml file...
[16:41:08] <shreyasminocha>	 -dev receives notifs about the project, but it doesn't explicitly mention wikimedia-cz/tracker
[16:44:07] <shreyasminocha>	 okay, we have https://gerrit.wikimedia.org/r/c/labs/tools/wikibugs2/+/479478
[17:08:52] <Urbanecm>	 Thanks Shreyas :)
[17:20:30] <shreyasminocha>	 (y)
[17:24:13] <takidelfin|sick>	 shreyasminocha: :D
[17:24:40] <takidelfin|sick>	 I was trying to find webhook API for phabricator to make bot like wikibugs but for tracker ;-;
[17:25:10] <takidelfin|sick>	 https://usercontent.irccloud-cdn.com/file/ixr7ha4g/screenshot_20181213_182311.png
[17:25:14] <takidelfin|sick>	 https://usercontent.irccloud-cdn.com/file/NDiqzuRd/screenshot_20181213_182258.png
[17:25:29] <takidelfin|sick>	 shreyasminocha, Urbanecm: Umm ?
[17:29:22] <shreyasminocha>	 looking
[17:30:22] <shreyasminocha>	 takidelfin|sick: style the button tag somewhere up in the stylesheet (because it'll be a general rule) ¯\_(ツ)_/¯
[17:30:23] <takidelfin|sick>	 https://usercontent.irccloud-cdn.com/file/RjyEX2Tj/screenshot_20181213_183017.png
[17:30:25] <takidelfin|sick>	 or like that?
[17:30:50] <takidelfin|sick>	 Urbanecm: umm, you prefer a link 'Add comment' or button 'add comment' ?
[17:30:56] <takidelfin|sick>	 because it will be a style change
[17:31:15] <shreyasminocha>	 you can style the button to match the earlier style, i'm sure
[17:31:24] <takidelfin|sick>	 I know
[17:31:25] <takidelfin|sick>	 but
[17:31:56] <takidelfin|sick>	 but what is the point of it? Styling button to look like a link?
[17:32:13] <shreyasminocha>	 here the semantically correct tag is <button>
[17:32:26] <takidelfin|sick>	 yup...
[17:32:57] <shreyasminocha>	 it'd be better to have it right ofc, although it's not too big of a deal
[17:58:41] <takidelfin|sick>	 export PATH=$PATH:`pwd`/flutter/bin
[17:58:43] <takidelfin|sick>	 oops
[17:58:49] <takidelfin|sick>	 sorry :(
[19:47:38] <shreyasminocha>	 lol
[20:26:00] <Urbanecm>	 i'm back finally
[20:26:02] <Urbanecm>	 shreyasminocha, takidelfin|sick ^
[20:26:26] <shreyasminocha>	 Nice to know
[20:26:31] <shreyasminocha>	 Was gonna sleep
[20:26:48] <shreyasminocha>	 Am gonna sleep, I think
[20:27:04] <takidelfin|sick>	 Urbanecm: o/
[20:27:29] <takidelfin|sick>	 I'm currently working on autocomplete feature :D
[20:27:52] <takidelfin|sick>	 also, Could you review fix comments patch?
[20:28:06] <takidelfin|sick>	 https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479412
[20:28:36] <Urbanecm>	 hi takidelfin|sick, shreyasminocha reviewed it, react somehow to it, please
[20:28:47] <takidelfin|sick>	 ^ see the discussion above
[20:28:52] <shreyasminocha>	 Ok?
[20:29:12] <shreyasminocha>	 "React somehow to it pleaee"?
[20:29:20] <takidelfin|sick>	 Urbanecm: So, I should leave it as a link or make it look like a button?
[20:29:24] <takidelfin|sick>	 because it is a UI change
[20:29:54] <takidelfin|sick>	 so I didn't want to change the UI without your decission
[20:30:12] <shreyasminocha>	 Lel, this is minor
[20:30:17] <shreyasminocha>	 But okay
[20:30:24] <takidelfin|sick>	 shreyasminocha: "react" ( ͡° ͜ʖ ͡°)
[20:30:30] <shreyasminocha>	 Better safe than sorry :D
[20:30:40] <shreyasminocha>	 Takidelfin: :D
[20:30:45] <takidelfin|sick>	 react is cool
[20:30:47] <takidelfin|sick>	 Vue is cool too
[20:30:50] <takidelfin|sick>	 :>
[20:31:07] * shreyasminocha will seriously look into vue some day
[20:31:17] * takidelfin|sick :O
[20:31:22] <Urbanecm>	 takidelfin|sick, i prefer a link, but if you think button's prettier or something, won't object it
[20:31:44] <takidelfin|sick>	 I think link fits 'Add comment' better too
[20:32:12] <shreyasminocha>	 It *can* be a <button>, but look like a link
[20:32:22] <shreyasminocha>	 I think that's appropriate
[20:32:26] <takidelfin|sick>	 yup, but what is the point of styling a button to look like a link :D
[20:32:47] <shreyasminocha>	 Semantically correct tags
[20:32:51] <takidelfin|sick>	 eh
[20:32:53] <takidelfin|sick>	 okay
[20:34:45] <Urbanecm>	 i mean visual side of things, not tag side of things ofc :D
[20:35:06] <shreyasminocha>	 Simple way: add a class to the button and add that class to the rule that styles link
[20:35:48] <shreyasminocha>	 'linkey', button.linkey  :D
[20:37:43] <takidelfin|sick>	 https://www.irccloud.com/pastebin/YA22Octm/
[20:37:43] <takidelfin|sick>	 ?
[20:38:50] <shreyasminocha>	 Can't test, on phone in bed
[20:39:12] * takidelfin|sick whispers: it works as expected, just review the style
[20:40:17] <shreyasminocha>	 How does 18bc9c look? Verbally?
[20:40:41] <shreyasminocha>	 (the color)
[20:40:47] <takidelfin|sick>	 https://usercontent.irccloud-cdn.com/file/hY5eXguW/screenshot_20181213_214042.png
[20:40:51] <takidelfin|sick>	 shreyasminocha ^
[20:41:15] <shreyasminocha>	 Lgtm
[20:41:48] <takidelfin|sick>	 https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479412
[20:41:49] <takidelfin|sick>	 :>
[20:41:52] <takidelfin|sick>	 please review
[20:42:00] <takidelfin|sick>	 Urbanecm, shreyasminocha: ^
[20:45:44] <takidelfin|sick>	 shreyasminocha: i'm too lazy https://usercontent.irccloud-cdn.com/file/j2Hd3i9U/screenshot_20181213_214515.png
[20:48:08] * shreyasminocha just got out of bed and onto laptop to CR
[20:49:21] <shreyasminocha>	 aah my eyes hurt
[20:51:00] <shreyasminocha>	 done
[20:53:16] <takidelfin|sick>	 (you can use polygerrit on phone btw)
[20:53:50] <takidelfin|sick>	 https://usercontent.irccloud-cdn.com/file/mgdITD2d/screenshot_20181213_215344.png
[20:53:56] <takidelfin|sick>	 shreyasminocham Urbanecm: Thanks ^^
[20:54:03] <Urbanecm>	 yw
[20:54:11] <shreyasminocha>	 takidelfin|sick: is there an app?
[20:54:15] * Urbanecm loves the fact polygerrit is responsible
[20:54:28] <takidelfin|sick>	 shreyasminocha: no, it is new 'skin' for Gerrit
[20:54:30] <Urbanecm>	 *responsive
[20:54:36] <takidelfin|sick>	 made using Polymer iirc
[20:54:54] <takidelfin|sick>	 shreyasminocha: you can enable it by going to: https://gerrit.wikimedia.org/?polygerrit=1
[20:54:57] <takidelfin|sick>	 :)
[20:54:57] <Urbanecm>	 ftr, the old skin you might be using was removed in upstream
[20:54:57] <shreyasminocha>	 btw is there an app for gerrit?
[20:55:02] <Urbanecm>	 shreyasminocha, i don't think so
[20:55:03] <shreyasminocha>	 oh
[20:55:05] <Urbanecm>	 but you can write some
[20:55:16] <shreyasminocha>	 :D someday sometime
[20:55:17] <takidelfin|sick>	 shreyasminocha: I'm learning flutter, maybe I will give it a try
[20:56:12] <shreyasminocha>	 nice
[20:56:16] <shreyasminocha>	 saw your command
[20:56:17] <shreyasminocha>	 :D
[21:00:35] * shreyasminocha desperately needs to sleep
[21:00:35] * takidelfin|sick is embarrassed by his awkwardness
[21:00:44] <takidelfin|sick>	 shreyasminocha: good night!
[21:00:51] <shreyasminocha>	 gn!
[21:06:53] <Urbanecm>	 gn shreyasminocha
[21:07:03] <Urbanecm>	 takidelfin|sick, what's with you, btw?
[21:07:08] <Urbanecm>	 your nick says you're sick
[21:15:57] <takidelfin|sick>	 Urbanecm: umm, I'm sick still. But I feel better now (and I can't sleep any longer :<), so I decided to do something more interesting :D
[21:16:16] <Urbanecm>	 it's great you feel better
[21:16:39] <takidelfin|sick>	 thanks ^-^
[21:40:54] <takidelfin|sick>	 shreyasminocha: wow... https://usercontent.irccloud-cdn.com/file/0vXLpfNR/screenshot_20181213_224034.png
[21:42:39] <Urbanecm>	 takidelfin|sick, if you don't want to sleep yet, i added two bugs to bugs column ;)
[21:54:56] <takidelfin|sick>	 Urbanecm: sure, thanks
[21:55:09] <Urbanecm>	 yw