[07:45:58] Hey everyone, looks we have wikibugs here! [09:32:33] (PS1) Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - https://gerrit.wikimedia.org/r/480444 [09:33:20] * Urbanecm waves to shreyasminocha [09:33:21] https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/480444 [09:33:32] (CR) jerkins-bot: [V: -1] Implement proxy for MediaWiki API [wikimedia-cz/tracker] - https://gerrit.wikimedia.org/r/480444 (owner: Urbanecm) [09:33:57] * shreyasminocha waves; looking. [09:34:06] btw why is wikibugs so bland here? [09:34:17] where's his (her?) ansi color magic? [09:34:31] let me fix it [09:36:07] ^^ that should be it ^^ [09:36:37] 👌 [09:36:41] how did you do it? [09:36:45] (03PS2) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [09:36:52] \o/ [09:37:04] this channel had colors blocked [09:37:06] (that's +c) [09:37:21] :o [09:38:03] so I removed the mode +c by setting -c [09:38:05] ops can do it [09:38:13] so I told ChanServ to op me [09:38:18] and then removed the mode [09:39:00] yeah. nice. [09:39:12] niice [09:39:13] And as I ended my work, I've now told ChanServ to de-op me [09:39:30] why even de-op though? [09:39:54] should you be logged as root all the times? [09:40:04] :D [09:40:37] the question should be: why NOT de-op? :) [09:41:41] anyway, to answer your question properly, at least for me, it allows me to remember easily what can an ordinary user to and what can be done only by an op [09:42:04] hm [09:42:16] brb [09:42:45] * shreyasminocha is gonna study [09:43:49] :) [09:43:54] that's up to shreyasminocha, obv [09:45:03] I'll test the patch I uploaded later (hopefully with in an hour), merge it and rebase my mediainfo patch, so you can continue your work [09:45:12] the endpoint will be /api/mediawiki [09:45:27] it will connect to whatever configured in MEDIAINFO_MEDIAWIKI_URL in settings.py [09:45:38] so it won't become an open proxy [09:46:06] as you can see, POSTing it will issue a POST [09:46:15] and GETting it will issue a GET [09:46:48] I'll probably change the code a little to allow to send authorized requests if the user is authorized etc [09:47:03] but you don't need to worry about it, it should just work (tm) [10:04:43] 10WMCZ-Tracker: All notifications in preferences should check all notification rows JS-side - https://phabricator.wikimedia.org/T212033 (10Nathan_fraignt) a:03Nathan_fraignt [10:10:39] (03PS3) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [10:11:37] (03CR) 10jerkins-bot: [V: 04-1] Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 (owner: 10Urbanecm) [10:11:48] shreyasminocha, pushed updated version that's somehow better (once Jenkins's satisfied) [10:11:58] It employs MediaWiki class that was created for such purposes [10:13:51] (03PS4) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [10:15:28] (03CR) 10jerkins-bot: [V: 04-1] Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 (owner: 10Urbanecm) [10:16:43] (03PS5) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [10:17:48] (03PS1) 10Nathan fraignt: All notifications input checks all notification rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480453 (https://phabricator.wikimedia.org/T212033) [10:20:30] Urbanecm: nice. will look into it. [10:20:45] hi Nathan_fraignt [10:20:53] Hi :) [10:21:15] yw shreyasminocha [10:21:28] I'm going to crash-test it now, hoping it'll goes well [10:21:52] * Urbanecm probably should write some docs for the API, so we won't forget how to use it. [10:23:01] :D [10:34:57] (03PS6) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [12:10:25] * Urbanecm waves to shreyasminocha [12:29:36] (03PS7) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [12:33:44] (03PS8) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [12:37:52] (03PS9) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [12:41:24] (03PS10) 10Urbanecm: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 [12:41:51] (03CR) 10Urbanecm: [C: 03+2] Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 (owner: 10Urbanecm) [12:42:18] (03CR) 10Urbanecm: [C: 03+2] Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 (owner: 10Urbanecm) [12:43:26] (03Merged) 10jenkins-bot: Implement proxy for MediaWiki API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480444 (owner: 10Urbanecm) [12:49:52] 10WMCZ-Tracker: Use some meaningful user-agent in requests issued by Tracker - https://phabricator.wikimedia.org/T212198 (10Urbanecm) [12:49:55] shreyasminocha, merged [12:50:18] nice [12:50:36] did you write the docs like you planned? :D [12:53:11] The first problem is "Where to put them?" [12:53:49] Maybe I'll setup tech.wikimedia.cz for tech-related documents... [12:53:53] what do you think shreyasminocha ? [12:54:07] hmm [12:54:10] anyway, it's pretty simple - just use /api/mediawiki instead of https://commons.wikimedia.org [12:54:23] simple enough :D [12:54:31] *instead of https://commons.wikimedia.org/w/api.php [12:54:38] yes [12:56:16] what do you think about docs location? [12:56:39] in the future? [12:56:49] coz doesn't seem necessary here [12:57:36] tech.wikimedia.cz/docs maybe sounds good [12:57:59] I can put a wiki instance there, so we can use the standard MW functions [12:58:08] Well, you asked me several questions about Tracker - how to get MW account connected, how to authenticate with the API etc [12:59:00] point [12:59:39] In case some random stranger picks a task in Phabricator, they might struggle and give-up just because they don't know about this proxy endpoint. [12:59:46] tech.wikimedia.cz + wiki instance sounds good [12:59:47] yeah [12:59:55] ok, will do that in a moment [13:08:46] (03PS1) 10Urbanecm: Fix locales errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480478 [13:09:04] (03CR) 10Urbanecm: [C: 03+2] Fix locales errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480478 (owner: 10Urbanecm) [13:10:12] (03Merged) 10jenkins-bot: Fix locales errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480478 (owner: 10Urbanecm) [13:11:26] Urbanecm: is `/api/mediawiki?action=query&list=allimages&...` correct? [13:11:35] should be [13:11:41] getting a 500 [13:11:46] 500? [13:11:47] :( [13:11:56] let me confirm it's not an issue on my end [13:12:00] can you disclose the full URL please? [13:12:13] http://localhost:8000/api/mediawiki?action=query&list=allimages&aisort=timestamp&aidir=descending&ailimit=10&aiuser=Martin_Urbanec&aiprop=timestamp%7Curl%7Ccanonicaltitle&format=json works for me [13:12:27] hmm... [13:13:08] `'Settings' object has no attribute 'MEDIAINFO_MEDIAWIKI_URL'` [13:13:17] :p [13:13:31] yup, add https://commons.wikimedia.org/w/api.php to it :D [13:13:51] you've added it to the template, right? haven't checked [13:13:51] that reminds me... [13:14:00] ...I forgot to amend settings.py.template [13:14:07] let me do that now :D [13:14:09] :D [13:16:04] (03PS1) 10Urbanecm: Add two variables to settings.py.template [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480482 [13:16:18] ^^ this should be it ^^ [13:16:34] \o/ [13:16:42] (03CR) 10Urbanecm: [C: 03+2] Add two variables to settings.py.template [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480482 (owner: 10Urbanecm) [13:17:47] shreyasminocha, does it work after adding those variables to settings.py? [13:17:47] (03Merged) 10jenkins-bot: Add two variables to settings.py.template [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480482 (owner: 10Urbanecm) [13:17:53] it does! [13:18:06] great! [13:18:28] (03PS26) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [13:19:58] Urbanecm: we need the last how many pictures again? [13:20:15] good q [13:20:29] can we list last, let's say, 25, and allow the user to change it? [13:21:14] yeah, sgtm [13:23:30] also, please allow user to a) add arbitrary photograph by its name b) filter the list by category c) get the list for some other user (it should still require an MediaWiki account connected, as saving mediainfo object will do some edits) [13:23:54] * Urbanecm wonders why shreyasminocha says "Silently Giggling to Myself" in those cases [13:24:42] (03PS27) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [13:25:02] in which cases? :D [13:26:31] yeah, sgtm [13:26:58] oh. my. god. is that seriously a thing? [13:27:42] lgtm = looks good to me -> sgtm = sounds good to me :D [13:28:43] * Urbanecm is trying to say jokes unsuccessfully :D [13:29:03] was wondering if you were serious :p :D [13:30:03] anyway, I really wondered about it for few days, as I don't use chatty slang much, I googled the abbr and https://ctrlv.cz/1OzU was the first result [13:30:37] hmm yeah. third seems to be "sounds good to me" [13:31:26] second is "Sindicato General de Trabajadores de Malaria" [13:31:45] :D [13:32:02] (btw, google's personalized, so this doesn't have to be same across all devices) [13:32:14] :D [13:33:01] gewgle [13:35:15] 10WMCZ-Tracker: Some permission denied messages in views.py are not internacionalized - https://phabricator.wikimedia.org/T212204 (10Urbanecm) [13:35:40] ^^ we should have linter for this too probably ^^ [13:36:41] yee [13:51:24] (03PS1) 10Urbanecm: SECURITY: Allow only whitelisted actions in proxy [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480493 [13:51:36] (03CR) 10Urbanecm: [C: 03+2] SECURITY: Allow only whitelisted actions in proxy [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480493 (owner: 10Urbanecm) [13:51:46] :D [13:52:02] I won't be happy if WMCZ server IP gets blocked :D [13:52:15] :D [13:52:25] currently only query is whitelisted, I hope this is enough from frontend side [13:52:27] lmk if not [13:52:36] (03Merged) 10jenkins-bot: SECURITY: Allow only whitelisted actions in proxy [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480493 (owner: 10Urbanecm) [13:53:50] (03PS28) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [13:54:29] (03PS6) 10Urbanecm: Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) [13:54:38] (03PS6) 10Urbanecm: Expose old MediaInfo in the API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480029 (https://phabricator.wikimedia.org/T211636) [13:56:30] okay [13:59:58] (03PS2) 10Urbanecm: Do not allow users to upload/edit docs on archived tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480115 [14:01:08] (03CR) 10jerkins-bot: [V: 04-1] Do not allow users to upload/edit docs on archived tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480115 (owner: 10Urbanecm) [14:03:17] (03PS3) 10Urbanecm: Do not allow users to upload/edit docs on archived tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480115 [14:04:55] ha, jenkins is happy now [14:05:02] (03CR) 10Urbanecm: [C: 03+2] Do not allow users to upload/edit docs on archived tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480115 (owner: 10Urbanecm) [14:06:14] (03CR) 10Urbanecm: [C: 03+2] Throw 403 instead of 404 when adding ack to a ticket you don't own [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480061 (owner: 10Urbanecm) [14:06:16] (03Merged) 10jenkins-bot: Do not allow users to upload/edit docs on archived tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480115 (owner: 10Urbanecm) [14:06:55] (03CR) 10Urbanecm: [V: 03+2] Throw 403 instead of 404 when adding ack to a ticket you don't own [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480061 (owner: 10Urbanecm) [14:07:01] (03CR) 10Urbanecm: [C: 03+2] Throw 403 instead of 404 when adding ack to a ticket you don't own [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480061 (owner: 10Urbanecm) [14:07:13] (03CR) 10jerkins-bot: [V: 04-1] Throw 403 instead of 404 when adding ack to a ticket you don't own [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480061 (owner: 10Urbanecm) [14:07:40] (03PS2) 10Urbanecm: Throw 403 instead of 404 when adding ack to a ticket you don't own [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480061 [14:09:20] I probably missed something, but what is the API you were talking about? [14:09:40] Nathan_fraignt, MediaWiki API prohibit cross origin requests [14:10:00] to bypass this issue, I've created /api/mediawiki that forwards the requests to MW [14:10:18] And does allow cross origin requests [14:10:19] ah [14:10:29] Thanks :) [14:10:31] yw [14:28:44] 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Add support for Translatewiki - https://phabricator.wikimedia.org/T209313 (10Urbanecm) [14:28:49] 10WMCZ-Tracker, 10Continuous-Integration-Config, 10Patch-For-Review: Setup gate-and-submit-l10n for wikimedia-cz/tracker - https://phabricator.wikimedia.org/T211938 (10Urbanecm) 05Open→03Declined Will use a better approach. [14:35:46] 10WMCZ-Tracker, 10User-Urbanecm: Add insertables and checkers to TWN - https://phabricator.wikimedia.org/T212213 (10Urbanecm) p:05Triage→03High [14:38:17] Btw, urbanecm, I saw that Tracker now has 2 more languages. I can translate Tracker to Dutch if you want to [14:39:20] Nathan_fraignt, that's up to you. Translation happens on https://translatewiki.net/, you can apply for translator privs (if you don't have them) and translate all projects that are on TWN (MediaWiki, Tracker and many others) [14:39:38] Alright, I will have a look! [18:39:43] ;( [18:40:16] personal wikibugs for this channel quit [19:28:50] (03PS1) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [19:29:52] (03CR) 10jerkins-bot: [V: 04-1] Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 (owner: 10Shreyasminocha) [19:34:49] (03PS2) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572 [19:35:45] (03PS3) 10Shreyasminocha: Add Commons media selection interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/480572