[10:37:23] * takidelfin waves [10:37:36] ough [10:44:21] Time for a little break from doing a school project :D [11:14:22] * shreyasminocha waves [11:19:55] o/ [11:29:13] Urbanecm: Hi! Could you look at https://gist.github.com/takidelfin/ca6cb0a91b4108af8383673fa5d10302? [11:29:13] I'm fixing line endings errors currently and noticed this. Maybe it is unnecessary? [12:29:40] * Urbanecm waves to takidelfin and is looking on the gist [12:30:17] Looks you're right [15:02:11] * takidelfin back [15:02:19] * takidelfin waves [15:03:16] yay [15:03:33] I will send a patch when I will be back home [15:19:13] that's great takidelfin [19:15:26] \o/ [19:15:31] back [19:20:21] o/ [20:06:01] (03PS1) 10Takidelfin: HTML: Replace unneccesary variables with a string Replaced "notification_type.0" to "muted" in an if statement ("notification_type.0" is always "muted" there) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 [20:06:30] (ops) [20:06:35] ((oops) [20:09:02] (03PS2) 10Takidelfin: HTML: Replace unneccesary variables with a string Replaced "notification_type.0" to "muted" in an if statement ("notification_type.0" is always "muted" there) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 [20:14:33] (03PS3) 10Takidelfin: HTML: Replace unneccesary variables with a string Replaced "notification_type.0" to "muted" in an if statement ("notification_type.0" is always "muted" there) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 [20:14:54] ouw I love git <3 [20:15:37] (03PS4) 10Takidelfin: HTML: Replace unneccesary variables with a string [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 [20:15:56] (Because If I break something, it allows me to fix it easily) [20:23:57] Urbanecm: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/481308 [20:23:57] Could you review it please? \o/ [20:24:02] * Urbanecm waves [20:24:08] * takidelfin waves back [20:27:40] (03CR) 10Urbanecm: [C: 03+2] HTML: Replace unneccesary variables with a string [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 (owner: 10Takidelfin) [20:27:45] lgtm takidelfin [20:28:18] yay, now I can push another change [20:28:24] :) [20:28:45] (03Merged) 10jenkins-bot: HTML: Replace unneccesary variables with a string [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481308 (owner: 10Takidelfin) [20:29:17] takidelfin, you can push as many changes at one time, can't you? [20:29:41] yyyes, but I didn't want to cause a merge problem [20:30:02] okay :) [20:30:25] `error: refusing to lose untracked file` there it goes ;-; [20:31:27] takidelfin, what are you trying to do? [20:31:40] line endings [20:31:44] linter [20:32:17] ah, that error? [20:32:34] nvm, resolved it :) [20:38:38] great! [21:04:21] (03PS1) 10Takidelfin: Lint: Enable htmllint and force LF line breaks by linter(s) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481309 (https://phabricator.wikimedia.org/T211601) [21:04:37] * Urbanecm waves to takidelfin [21:04:47] * shreyasminocha waves to wave [21:05:00] * takidelfin waves to shreyasminocha and Urbanecm [21:05:13] * takidelfin waves to ocean waves [21:05:30] 🌊 [21:05:35] (03CR) 10jerkins-bot: [V: 04-1] Lint: Enable htmllint and force LF line breaks by linter(s) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/481309 (https://phabricator.wikimedia.org/T211601) (owner: 10Takidelfin) [21:05:39] :< [21:06:00] jerkins :-) [21:06:28] https://integration.wikimedia.org/ci/job/wikimedia-cz-tracker-npm-node-6-docker/531/console [21:06:30] weird log output [21:06:34] Urbanecm: lol, true [21:06:42] `line contains trailing whitespace` [21:06:54] wait [21:07:04] (ノಠ益ಠ)ノ彡┻━┻ what is that error thing [21:07:11] i have a regex to remove trailing whitespace if you need it [21:07:16] https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479960 [21:07:24] I saw that already [21:07:28] umh [21:07:32] sorry then [21:07:34] np [21:07:38] `/(?<=[\S])[ \t]+$/g` [21:07:45] I will try to enable it :) [21:07:50] thanks takidelfin [21:12:06] savew em/ [21:12:33] * shreyasminocha messed up [21:12:39] sevaw em/ [21:13:36] kcab sevaw me/ [21:14:25] https://usercontent.irccloud-cdn.com/file/uE1vSh27/screenshot_20181224_221413.png [21:14:26] 🤔 [21:14:35] this regex is used by htmllint [21:14:55] `col 0` [21:19:26] this regex also fails when used in JS ... [21:19:41] interesting [21:19:49] this is related to `*$` [21:20:10] without `$` it works [21:20:20] but maches unrelated whitespaces then